[00:07:34] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 2 others: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2097606 (10Jdlrobson) A few thoughts in reaction to latest discussions: * We're trying to keep the solution non-MobileFrontend specific fo... [00:10:28] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, put SET options in the same order - https://phabricator.wikimedia.org/T128863#2097628 (10Jdforrester-WMF) The problem here is that the two controls have different standard user expectations of how they work – on Special:Preferences, they are... [00:12:15] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Preserve edit summary, minor edit, watchlist checkboxes when switching from VE-MW to WT or back - https://phabricator.wikimedia.org/T128529#2097636 (10Jdforrester-WMF) 5Open>3Resolved [00:19:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10Beta-Cluster-Infrastructure: Beta Cluster threw a 'internal_api_error_DBConnectionError' at me - https://phabricator.wikimedia.org/T129192#2097660 (10Jdforrester-WMF) [00:23:13] 10VisualEditor: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2094227 (10Jdforrester-WMF) Example link: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=UserMergebxveaf&action=edit&uselang=de&veswitched=1 [00:27:05] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 2 others: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2097742 (10Halfak) Hi @jdlrobson, right now, I'm just hoping to figure out what is actually being stored in the page_props table. But t... [00:29:20] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Height of link inspector changes when switching tabs ("Search pages" / "External link") - https://phabricator.wikimedia.org/T129173#2097745 (10Jdforrester-WMF) p:5Triage>3Low [00:33:16] 10VisualEditor, 10Parsoid: Visual Editor mishandles SPARQL template - https://phabricator.wikimedia.org/T129133#2097753 (10Jdforrester-WMF) Hmm. I switched the template to 'block' but Parsoid still trips over the `}` on its own. [00:34:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10Beta-Cluster-Infrastructure: Beta Cluster threw a 'internal_api_error_DBConnectionError' at me - https://phabricator.wikimedia.org/T129192#2097758 (10Jdforrester-WMF) (Seems to be generally working.) [00:35:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10Beta-Cluster-Infrastructure: Beta Cluster threw a 'internal_api_error_DBConnectionError' at me - https://phabricator.wikimedia.org/T129192#2097660 (10AlexMonk-WMF) Did you get an exception ID? [00:36:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10Beta-Cluster-Infrastructure: Beta Cluster threw a 'internal_api_error_DBConnectionError' at me - https://phabricator.wikimedia.org/T129192#2097763 (10Jdforrester-WMF) It does help if I remember to attach the screenshot, doesn't it? :-) {F3553891} [00:39:36] 10VisualEditor, 7Browser-Support-Internet-Explorer, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Impossible to add a reference on IE11 - https://phabricator.wikimedia.org/T128854#2097781 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [00:44:54] 10VisualEditor, 10VisualEditor-MediaWiki: Only show one of the SET-two-tabs dialog (for returning editors) and the VE-welcome-dialog (for newbie editors) - https://phabricator.wikimedia.org/T129200#2097821 (10Jdforrester-WMF) [00:47:10] 10VisualEditor: revisiting uncalled for nowikitags while suffix addition without space outside [[linked wikimarkup area]] to create a compound word - https://phabricator.wikimedia.org/T128349#2097857 (10Jdforrester-WMF) [00:47:12] 10VisualEditor: Come up with a design to make it easier for users to see that there is no space after a link (just the cartouche) and so you probably want to add one - https://phabricator.wikimedia.org/T128060#2097858 (10Jdforrester-WMF) [00:53:17] 10VisualEditor, 10Parsoid: Visual Editor mishandles SPARQL template - https://phabricator.wikimedia.org/T129133#2097897 (10Smalyshev) Now it also seems to have newline handling broken - if I paste text with newlines it all comes out as one line after I save. Is that related to the block thing? Wikitext editor... [01:08:58] RoanKattouw: Hmm. How do I access the sha1() method that RL uses? Is it magically not in scope? [01:09:41] Not sure, ask Krinkle, if he's still up [01:09:59] Ta. [01:10:06] Yeah, it's not a public interface [01:10:14] :-( [01:10:16] it's local to RL and only used there so we can remove it when it change it [01:10:31] What would you want to use it for? [01:10:31] I have a need for it (or another hash function). [01:10:42] You probably don't need sha1 [01:11:19] A/B test for VE on IPs. We need to take an IP and consistently reduce it to a number we can use on which to do modulo arithmetic. [01:11:43] So IP string -> sha1 of IP string -> first three digits of IP hash -> number was my/Roan's thinking. [01:11:59] Hm.. what about s/\D+// and then toString() it [01:12:10] using base 36 [01:12:14] or something like that [01:12:32] Meh. [01:12:45] Not exactly ideal for IPv6. [01:12:49] why can't you use the IP address as the number? [01:12:56] Ipv6 [01:12:58] i mean, IP address is basically a 32-bit int. [01:13:00] well [01:13:01] MatmaRex: 2^128 is much bigger than JS can handle. [01:13:02] or 128-bit [01:13:11] MatmaRex: JS conks out at 2^53. [01:13:33] (And we don't care about the level of detail, we just need a good-enough approximation.) [01:14:24] James_F: if you want it to be consistent per-user, you probably shouldn't take the whole IPv6 address into account anyway. the last few bits are not static [01:14:32] James_F: RoanKattouw : http://stackoverflow.com/a/8076436/319266 (without the prototype part) is a fairly common one [01:15:21] * James_F sighs. True. [01:15:32] MatmaRex: /48 split? [01:16:49] James_F: per https://phabricator.wikimedia.org/T112325 , a /64 range is basically one use [01:17:09] r [01:17:23] I thought it varied by supplier? Eh. [01:17:38] it probably does :D such fun [01:18:02] James_F: Why does it need to be deterministic? [01:18:33] Krinkle: So we can do it on the server after the fact too. [01:18:57] Krinkle: Specifically, so we can reconstruct which IP is in which bucket when looking at the revisions table without joining to EL. [01:19:28] James_F: There is a tag for VE edits, no? [01:19:39] mw.user.sessionId() [01:19:56] Krinkle: sessionId isn't persistent over multiple days. [01:20:23] Krinkle: Tag tells you what editor they ended up saving with, not whether they would have started with one and switched to the other. [01:20:46] I thought that was already tracked elsewhere [01:20:53] In EL. [01:20:55] edit start and all that stuff in EventLogging [01:20:56] yes [01:21:04] And only for 1/16th of users. [01:21:06] what do you need from revision table? [01:21:09] Right [01:21:22] The edits. [01:21:24] Time. Complexity. Reverts. Sequence. [01:21:39] All the stuff in the revision table. :-) [01:21:55] Well you could add more tags. [01:22:17] Not a great outcome for users. [01:22:34] And we'd still need to set it on the client probabilistically and consistently. [01:22:59] Note that random crypto hash (mw.user.generateRandom) and mw.user.bucket can persist longer and will be on the POST to server-side as well [01:23:23] I know, but I want this to be lightweight. [01:24:23] If it touches ApiVisualEditor.php we've somewhat failed. :-) [01:25:09] Lightweight is a matter of perspective. [01:26:04] James_F: How would this work on sql btw? A custom function that somehow uses sha1() and then does the same modulo? [01:26:07] Not sure that works in mysql [01:26:19] You'd presumably also change that over time [01:26:23] Krinkle: Yeah; SHA1 is available. [01:26:26] as the rollout increases. [01:26:31] Yes, but how would you sample the sha1() in sql [01:26:32] We're only going to need this once. [01:26:42] into a boolean [01:26:45] Oh, SUBSTRING [01:27:19] I'll do it the hackyway, but… [01:27:37] (With the .replace()) [01:27:38] and sha1() + substr() + compare for a long sequence of revisions is faster than a join? [01:28:23] I guess that means you'll only sample based on entire characters of sha1 [01:28:29] Krinkle: Joins are not possible with revision without breaking, yes. [01:30:38] James_F: with limited timestamp range, an inner join should be fine. but maybe not. [01:31:15] `+( IP .replace( /\D/g, '' ).substring(0,12)) % factor` could work well enough, I guess. [01:31:37] Worst cases are IPv6 loopback ('::1') and those shouldn't happen in reality. [01:34:42] (03PS3) 10Jforrester: [WIP] Make it possible to enable for a proportion of logged-out users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274158 (https://phabricator.wikimedia.org/T128484) [01:34:57] (03PS4) 10Jforrester: [WIP] Make it possible to enable for a proportion of logged-out users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274158 (https://phabricator.wikimedia.org/T128484) [01:36:35] If you want to include the letter, this might be a crazy start, too. Makes it a little more balanced by giving the letter a little bit of influence. [01:36:35] '2001:0db8:0000:0042:0000:8a2e:0370:7334'.replace(/\W+/g, '' ).replace(/\D/g, function (s) { return String(s.charCodeAt(0))[0]; }); [01:36:40] > 20010198000000420000892103707334 [01:36:53] Oh, good point. [01:37:18] That's gonna be hard to reproduce in SQL though [01:37:36] (03CR) 10Jforrester: [WIP] Make it possible to enable for a proportion of logged-out users (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274158 (https://phabricator.wikimedia.org/T128484) (owner: 10Jforrester) [01:38:01] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2097973 (10Krenair) [01:39:42] Code review welcome. ;-) [01:54:40] 10Citoid, 10VisualEditor, 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy zotero/translators with scap3 - https://phabricator.wikimedia.org/T129143#2096492 (10Jdforrester-WMF) p:5Triage>3Normal [01:55:03] 10VisualEditor, 10Parsoid: Visual Editor mishandles SPARQL template - https://phabricator.wikimedia.org/T129133#2096248 (10ssastry) This is unrelated to template formatting. This is an interesting bug because it reveals that sometimes, nowikis can actually break rendering whereas till now, we were working wit... [01:58:19] 10VisualEditor: Let me set my prefs from the dialog before switching to the wikitext editor - https://phabricator.wikimedia.org/T129048#2093349 (10Jdforrester-WMF) Aha, I created a duplicate, sorry. Will merge this there. [01:58:25] 10VisualEditor: Let me set my prefs from the dialog before switching to the wikitext editor - https://phabricator.wikimedia.org/T129048#2097998 (10Jdforrester-WMF) [01:58:27] 10VisualEditor, 10VisualEditor-MediaWiki: Only show one of the SET-two-tabs dialog (for returning editors) and the VE-welcome-dialog (for newbie editors) - https://phabricator.wikimedia.org/T129200#2097999 (10Jdforrester-WMF) [01:58:52] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2098001 (10Jdforrester-WMF) p:5Triage>3Normal [01:59:21] 10VisualEditor, 10VisualEditor-Tables: Pasting into a table selection should repeat to fill the selection - https://phabricator.wikimedia.org/T129034#2098004 (10Jdforrester-WMF) p:5Triage>3Low [02:33:19] (03CR) 10Krinkle: [WIP] Make it possible to enable for a proportion of logged-out users (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274158 (https://phabricator.wikimedia.org/T128484) (owner: 10Jforrester) [04:17:09] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 2 others: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2098158 (10Cenarium) >>! In T125329#2097606, @Jdlrobson wrote: > A few thoughts in reaction to latest discussions: users). I'm thus not su... [06:23:18] (03CR) 10Siebrand: [C: 032] i18n: Relabel the SET preference and dialog to 'mode' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275720 (owner: 10Jforrester) [06:24:21] (03CR) 10Siebrand: "Should you add a deprecation warning to the parameter in qqq.json and the code, so that it can be removed at some point?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275736 (owner: 10Jforrester) [06:24:45] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275735 (owner: 10Jforrester) [06:34:56] (03Merged) 10jenkins-bot: i18n: Relabel the SET preference and dialog to 'mode' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275720 (owner: 10Jforrester) [06:34:58] (03Merged) 10jenkins-bot: i18n: Explain to returning users that their preferences are mutable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275735 (owner: 10Jforrester) [06:37:38] (03CR) 10Jforrester: [C: 04-1] "Should also remove reference to $1 in the qqq." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275737 (owner: 10Jforrester) [06:38:17] (03CR) 10Jforrester: "> Should you add a deprecation warning to the parameter in qqq.json and the code, so that it can be removed at some point?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275736 (owner: 10Jforrester) [08:23:21] (03CR) 10Siebrand: [C: 032] i18n: Don't refer to the name of the tab in the beta notice given it changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275736 (owner: 10Jforrester) [08:28:08] (03CR) 10Siebrand: [C: 04-1] "There are 116 translations [1] for this message. That's way above average, so the impact of this is fairly high." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275737 (owner: 10Jforrester) [08:33:34] (03Merged) 10jenkins-bot: i18n: Don't refer to the name of the tab in the beta notice given it changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275736 (owner: 10Jforrester) [08:33:39] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links: VisualEditor: When user changes a link anchor which has the same link target, suggest that they may wish to change the link target too - https://phabricator.wikimedia.org/T56947#2098243 (10NicoV) On frwiki, the problem appeared in t... [09:32:04] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Don't give the user the option to discard changes when changing editor - https://phabricator.wikimedia.org/T128585#2098293 (10Pginer-WMF) [09:49:03] 10VisualEditor, 10VisualEditor-ContentLanguage, 7Browser-Support-Firefox: Impossibility to type Japanese characters in a table cell on VE by using Firefox - https://phabricator.wikimedia.org/T129066#2098326 (10Trizek-WMF) * ローマ字入力 (JIS X 4063: 2000) and かな入力 (Kana input) on Windows 7 * ローマ字入力 (JIS X 4063: 20... [10:10:03] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#2098345 (10Brbbl) I repeated the last procedure of @Mbch331 and it worked for me as well. Switching from wikitext editor to VE withou... [10:23:53] 10VisualEditor, 6Community-Liaisons, 7Documentation: Check and update VE Documentation - https://phabricator.wikimedia.org/T96237#2098363 (10Qgil) 5Open>3Invalid >>! In T96237#1930219, @Qgil wrote: >>>! In T96237#1340226, @Whatamidoing-WMF wrote: >> This is not really the sort of task that gets "finished... [10:27:52] (03PS1) 10Esanders: Link inspector: make height consistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275782 (https://phabricator.wikimedia.org/T129173) [10:54:05] 10VisualEditor, 6Discovery, 10Kartographer, 10Maps: Switching edit source <-> edit shows map as markup every other time - https://phabricator.wikimedia.org/T128956#2098438 (10Esanders) 5Open>3Resolved a:3Esanders Working now, probably just a deployment issue. [11:15:11] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaisons, 3Liaisons-March-2016: Publish messages about SET on pl.wiki, monitor for reactions and feedback - https://phabricator.wikimedia.org/T128499#2098482 (10Elitre) Done. [11:15:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable single edit tab on plwiki and review - https://phabricator.wikimedia.org/T128477#2098483 (10Elitre) We'll revisit next week. [11:20:47] edsanders, does this.model.doc.getDir() depend on user language? [11:47:44] edsanders, does this.model.doc.getDir() depend on user language? [12:36:09] no [12:56:01] Hello. I have installed visualeditor using vagrant. But I'm getting this error. [12:56:13] https://www.irccloud.com/pastebin/QkVmVZie/ [13:54:57] 10VisualEditor, 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7WorkType-NewFunctionality: Migrate VisualEditor core npm CI job to Nodepool - https://phabricator.wikimedia.org/T128093#2098719 (10hashar) [15:03:27] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (5d4881e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275705 (owner: 10Jforrester) [15:05:32] (03CR) 10Alex Monk: [C: 04-1] "also, commit message is broken. did you try to commit this with -m?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275737 (owner: 10Jforrester) [15:09:47] (03CR) 10Alex Monk: [C: 04-1] "PS2 comments still apply" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274158 (https://phabricator.wikimedia.org/T128484) (owner: 10Jforrester) [15:17:59] 10VisualEditor, 10VisualEditor-Tables: Changing a link inside a table makes the page jump - https://phabricator.wikimedia.org/T129228#2098964 (10Elitre) [15:23:12] (03Merged) 10jenkins-bot: Update VE core submodule to master (5d4881e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275705 (owner: 10Jforrester) [15:28:28] (03CR) 10Hashar: "check experimental" [unicodejs] - 10https://gerrit.wikimedia.org/r/252734 (owner: 10Esanders) [15:42:15] (03CR) 10Hashar: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275264 (owner: 10Jforrester) [15:47:29] 10VisualEditor, 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7WorkType-NewFunctionality: Migrate VisualEditor core npm CI job to Nodepool - https://phabricator.wikimedia.org/T128093#2099109 (10hashar) ``` 00:03:42.305 Running "karma:main" (karma) task 00:03:47.188 08 03 2016 15... [15:59:02] Finally. [15:59:02] Krenair: Hey, you OK to run the VE auto-disable script one last time on dewiki? [15:59:17] yes [16:00:07] Cool. [16:01:59] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Pasting Excel cells into Internet Explorer doesn't work - https://phabricator.wikimedia.org/T85553#2099199 (10Esanders) Appears to work with Excel2016 + Edge12. [16:05:15] James_F, set on an additional 1113 users [16:05:30] Krenair: Gosh, that's a lot more than I expected. [16:07:29] (03CR) 10Hashar: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275264 (owner: 10Jforrester) [16:20:36] 10VisualEditor, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2099249 (10Jdforrester-WMF) [16:23:51] edsanders: Please +1 https://gerrit.wikimedia.org/r/#/c/272731/ if you're content so we can merge. [16:24:23] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275264 (owner: 10Jforrester) [16:25:59] (03CR) 10Jforrester: [C: 032] "Oy." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275782 (https://phabricator.wikimedia.org/T129173) (owner: 10Esanders) [16:26:21] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Height of link inspector changes when switching tabs ("Search pages" / "External link") - https://phabricator.wikimedia.org/T129173#2099257 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [16:26:55] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Height of link inspector changes when switching tabs ("Search pages" / "External link") - https://phabricator.wikimedia.org/T129173#2097178 (10Jdforrester-WMF) [16:32:44] 10VisualEditor, 10VisualEditor-Tables: Changing a link inside a table makes the page jump - https://phabricator.wikimedia.org/T129228#2099275 (10Elitre) In Opera, it does jump up, but then refocuses again immediately after that. [16:32:57] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10VisualEditor-Tables: Changing a link inside a table cell makes the page re-scroll unnecessarily - https://phabricator.wikimedia.org/T129228#2099276 (10Jdforrester-WMF) p:5Triage>3Normal [16:44:57] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10VisualEditor-Tables: Changing a link inside a table cell makes the page re-scroll unnecessarily - https://phabricator.wikimedia.org/T129228#2098964 (10Esanders) As the inspector opens it sets the selection to null which cancels the tab... [16:50:03] (03Merged) 10jenkins-bot: Link inspector: make height consistent [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275782 (https://phabricator.wikimedia.org/T129173) (owner: 10Esanders) [16:55:48] (03PS1) 10Esanders: Link inspector: Remove premature call to onLinkTypeIndexSet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275845 (https://phabricator.wikimedia.org/T129228) [17:05:00] (03CR) 10Divec: [C: 032] Link inspector: Remove premature call to onLinkTypeIndexSet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275845 (https://phabricator.wikimedia.org/T129228) (owner: 10Esanders) [17:24:34] (03Merged) 10jenkins-bot: Link inspector: Remove premature call to onLinkTypeIndexSet [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275845 (https://phabricator.wikimedia.org/T129228) (owner: 10Esanders) [17:27:44] 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links, 10VisualEditor-Tables, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Changing a link inside a table cell makes the page re-scroll unnecessarily - https://phabricator.wikimedia.org/T129228#2099516 (10Jdforrester-WMF) 5Open>3Resolved a:3E... [17:34:07] (03PS2) 10DLynch: Use throttle instead of debounce for find/replace rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273938 [17:51:50] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 2 others: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2099640 (10Jdlrobson) >>! In T125329#2097742, @Halfak wrote: > Hi @jdlrobson, right now, I'm just hoping to figure out what is actually be... [18:03:02] James_F, where are you? [18:03:27] Krenair: Sorry, Product Managers' Off-site. [18:04:49] ok [18:45:21] (03CR) 10Esanders: [C: 04-1] Use throttle instead of debounce for find/replace rendering (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273938 (owner: 10DLynch) [19:24:46] (03CR) 10Hashar: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275264 (owner: 10Jforrester) [19:27:15] 10VisualEditor, 10VisualEditor-ContentEditable: Double-clicking a table cell doesn't work in Firefox - https://phabricator.wikimedia.org/T129267#2100159 (10Catrope) [19:27:31] James_F|Away, edsanders: ----^^ Regression from wmf15 or earlier [19:30:12] (03CR) 10Hashar: "Sorry using this change as guinea pig to migrate VE toward node4.3 and nodepool instances. T128090" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275264 (owner: 10Jforrester) [20:19:37] (03CR) 10Alex Monk: "Requires followup commit" (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275606 (https://phabricator.wikimedia.org/T128585) (owner: 10Jforrester) [20:20:40] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Don't give the user the option to discard changes when changing editor - https://phabricator.wikimedia.org/T128585#2100434 (10AlexMonk-WMF) 5Resolved>3Open This change does not appear to have been done properly, see comment... [20:35:10] (03PS1) 10Paladox: Debugging karma see https://integration.wikimedia.org/ci/job/npm-node-4.3/224/console [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 [20:35:30] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [20:45:58] (03CR) 10Hashar: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [20:48:21] (03PS3) 10DLynch: Use throttle instead of debounce for find/replace rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273938 [20:54:48] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2094227 (10AlexMonk-WMF) Yes, translation is too long for the default popup widget width of 320px [20:59:57] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2100622 (10AlexMonk-WMF) Okay, ignore my previous comment. On further investigation, it seems the margin applied to `.oo-ui-popupWidget-head > .oo-ui-labelEle... [21:20:46] (03PS1) 10Tchanders: WIP Make dialog for editing galleries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275931 [21:30:49] (03CR) 10Alex Monk: Follow-up I65d96627: Remember the user's preference in WikiEditor too (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275619 (https://phabricator.wikimedia.org/T129130) (owner: 10Jforrester) [21:32:03] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [21:51:33] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [21:52:05] (03PS1) 10Jforrester: Update OOjs UI to v0.16.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276004 [21:55:20] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [21:56:08] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.16.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276004 (owner: 10Jforrester) [22:13:23] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Edit led to a DEFAULTSORT entry being removed(?) - https://phabricator.wikimedia.org/T67200#2100947 (10Krinkle) 5Open>3Resolved a:3Krinkle Can't reproduce this bug anymore. [22:19:10] (03Merged) 10jenkins-bot: Update OOjs UI to v0.16.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276004 (owner: 10Jforrester) [22:20:38] James_F|Away: oojs-ui releases working? [22:25:48] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [22:25:53] (03PS2) 10Paladox: Debugging karma see https://integration.wikimedia.org/ci/job/npm-node-4.3/224/console [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 [22:26:04] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [22:26:25] (03Abandoned) 10Paladox: Debugging karma see https://integration.wikimedia.org/ci/job/npm-node-4.3/224/console [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [22:27:44] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [22:27:55] Krinkle: I hope so. Why? [22:28:11] (03CR) 10Paladox: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [22:30:56] Hey Thalia. [22:37:34] James_F: Because a while ago it didn't work and I made a release instead. Or was that oojs/core? [22:39:01] Krinkle: Oh, yeah, we fixed that. npm had reset my auth server-side but locally everything said it was fine. You helped me fix it. :-) [22:45:13] 10TemplateData, 10VisualEditor, 7HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2101115 (10ori) As a temporary workaround, you //may// be able to do something like this: ```lang=php (03PS1) 10Krinkle: mw.Target: Remove obsolete VE-copy of wgPageContentLanguage var [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276025 [22:57:22] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.16.2), 5OOjs-UI-next-release: Provide Ctrl+Enter as a keyboard shortcut to confirm OOui dialogs - https://phabricator.wikimedia.org/T125860#2101140 (10Jdforrester-WMF) [22:58:04] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.16.2): Provide Ctrl+Enter as a keyboard shortcut to confirm OOui dialogs - https://phabricator.wikimedia.org/T125860#2101146 (10Jdforrester-WMF) [23:12:49] (03PS1) 10Krinkle: mw.DesktopArticleTarget: Fix "Cannot read 'done' of undefined' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276038 [23:12:53] (03CR) 10Krinkle: Don't try to tell the server to set preferences to their current values (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269462 (owner: 10Alex Monk) [23:13:12] (03PS2) 10Krinkle: mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276038 [23:13:56] (03CR) 10Alex Monk: [C: 032] mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276038 (owner: 10Krinkle) [23:14:18] 10Citoid, 10VisualEditor, 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy zotero/translators with scap3 - https://phabricator.wikimedia.org/T129143#2101304 (10greg) [23:15:00] 10Citoid, 10VisualEditor, 10Deployment-Systems, 10scap, 10Scap3 (scap3-adoption): Deploy zotero/translators with scap3 - https://phabricator.wikimedia.org/T129143#2096492 (10greg) [23:26:36] (03Merged) 10jenkins-bot: mw.DesktopArticleTarget: Fix "Uncaught: Cannot read done of undefined" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276038 (owner: 10Krinkle) [23:29:44] (03PS2) 10Krinkle: mw.Target: Remove obsolete VE-version of wgPageContentLanguage var [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276025 [23:32:03] (03CR) 10Jforrester: mw.Target: Remove obsolete VE-version of wgPageContentLanguage var (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276025 (owner: 10Krinkle) [23:33:56] (03CR) 10Krinkle: mw.Target: Remove obsolete VE-version of wgPageContentLanguage var (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276025 (owner: 10Krinkle) [23:34:37] Krinkle: On new pages you don't have a Parsoid DOM from which to extract lang/dir. [23:34:46] I'm aware [23:34:50] Krinkle: ISTR that's why we pulled it from MW not from Parsoid. [23:34:52] I'm not looking at the Parsoid DOM [23:34:57] But maybe I'm just making it up. [23:35:11] MW DOM is interface language not content language. [23:35:30] However, for existing pages, if Parsoid actually supported it (which right now they don't!) it'd be better to use the Parsoid attributes since that way it'll work as expeccted with multi-content pages. [23:35:37] mw.Target is not mw.ArticleTarget [23:35:43] it should work in Flow-like ways as well [23:35:44] Think of kk-latn vs. kk-arab; different directionality for the same(*) content language. [23:35:59] Aka content variants suck. [23:36:00] which in theory can have multiple pieces on a single page with different languages as informed by the Parsoid dom [23:36:18] Incorrect. "MW DOM" isn't anything [23:36:27] there is three different language codes available in the MW DOM [23:36:48] MW DOM as in the HTML blob you get from nginx when MediaWiki is responding. [23:36:57] user interface, site content default, page content (as authored in wikitext) and page view language (as rendered) [23:37:07] All of these are in the DOM [23:37:10] on page views from nginx [23:37:15] in different places [23:37:22] Are they all accurate? [23:37:25] Yes [23:37:40] And also populated for non-existent pages [23:37:42] Accurate at the time we launch VE, or just at the time the bytes are sent? [23:37:48] Which is how VE is able to get it, because it is the same thing [23:37:53] VE doesn't do anything special here [23:37:58] it just calls title->getPageLanguage() [23:38:02] same as MW does already [23:38:02] * James_F nods. [23:38:24] Whatever changes at run time, isn't observed by mw.config and thus not by VE [23:38:35] (although there are no runtime changes to page lang that I'm currnetly aware of) [23:38:45] There are. [23:38:57] If there would be, the DOM would be correct, and not mw conf VisualEditor [23:39:10] James_F: Elaborate. [23:39:24] See e.g. https://zh-yue.wikipedia.org/wiki/2%E6%9C%8824%E8%99%9F – Click "简". [23:39:25] I think he means if there's an edit/creation conflict [23:39:38] Client-side language variants. [23:39:40] S'fun. [23:39:54] RoanKattouw: No, those would still be out-dated; we don't do a new request do we? [23:40:54] Or is it fresh on edit click? [23:41:28] Yeah it'd be outdated [23:41:33] Unless it's Parsoid HTML-based [23:41:55] James_F: Yeah, but that JS clusterfuck present there doesn't count as a run-time change imho. [23:42:03] Krinkle++ [23:42:03] :-D [23:42:12] I was going to say something like that [23:42:17] But Krinkle spared me from the need to mince my words [23:42:29] Krinkle: Be nice. We're possibly going to want to replace the worse PHP code in MW-core with it. [23:42:39] It swaps a few words but it doesn't catch it all and doesn't influence VE [23:43:01] However I'm not convinced MediaWiki core is bug free. [23:43:18] Indeed. [23:43:30] VE should use pageLanguage, as canonically authored for the current page [23:43:38] and that's what the mw.config vars are set to [23:43:42] including those for table sorting [23:43:53] * James_F nods. [23:43:53] Btu it sounds like it should use pageViewLanguage [23:44:00] which is what the content will be in [23:44:04] after conversion [23:44:26] Maybe. [23:45:35] btw, the day we replace php language conversion with that zhwiki gadget, is the Wikipedia will starts it's definitive downfall for our Chinese language audience. It doesn't perform. And that will affect users. [23:45:56] The PHP language conversion doesn't 'perform' either. [23:45:57] Way may run it in Node JS though [23:46:03] But this is a wider discussion. :-) [23:46:18] James_F: I think reality disagrees. It's cached so in the end "nobody cares" and it performs as well as enwiki [23:46:25] Krinkle: I don't agree that it should use pageViewLanguage, because what VE uses should match what language the content is in *as you edit it* [23:46:27] it's all cached for the 99p percentile of page views [23:46:33] Krinkle: Not code performance. Product performance. [23:46:39] If it gets converted to a different alphabet with a different directionality, that should not be reflected at edit time [23:47:02] I'm talking about the only one that matters (short of operational concerns on resources): perceived performances for users [23:47:06] RoanKattouw: And yet that's what the PHP crap does. [23:47:39] RoanKattouw: What do you mean. Does VE render the current individual user's variant, or the canonical one as authored by previous users? [23:47:42] Krinkle: Then you're a fool. A product that is fast and does the wrong thing is worse than useless. [23:48:02] Krinkle: It's not enabled on content variant wikis for a reason. [23:48:32] James_F: That kind of Performance (product) I agree is more important, but that's just word play. Those words aren't related to my statement. Disambiguate. [23:48:54] VE gets the canonical variant from Parsoid (or rather Parsoid gets that from MediaWiki) [23:49:23] so while the VE interface should render in the UI language, the content area should render based on the page content language. We do that already. [23:49:26] (and have since 2013) [23:49:39] But the question is whether VE should use the page lang or page view lang, RoanKattouw. [23:49:44] Krinkle: "Product performance" is the normal term for that, BTW. I generally don't use it. :-) [23:50:53] James_F: Sure, I agree that's the word people use. But it's not a sub category of the various time-based performance measures I was recerring to (code perf, perceived perf, code size, page weight etc.)