[00:03:51] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/276056/ [00:04:49] Krinkle: Well, when you edit the page, you edit the source variant, not the display variant, right? [00:05:02] Like, even if your display variant is latin you might be editing in cyrillic, AIUI [00:05:32] So if you're editing content that's in Cyrillic, you should get LTR, even if your display variant is Arabic [00:06:19] RoanKattouw: Right [00:06:21] That makes sense [00:06:34] We edit the canonical content [00:06:34] AIUI that's the difference between pageLang and pageViewLang [00:06:41] So VE should stick to pageLang [00:06:55] However I don't have experience using language variants so I'm not 100% sure, but I'm pretty sure this is how it works [00:07:02] (03CR) 10Krinkle: [C: 04-1] "This is mutually exclusive with Ibf399dfe5." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276025 (owner: 10Krinkle) [00:07:20] RoanKattouw: Yeah, VE using pageLang instead of pageViewLang makes sense to me [00:07:35] I'm just not sure why MW uses pageLang instead of pageViewLang for the page view. [00:07:36] ;-) [00:07:40] For wgPageContentLanguage pageViewLang does seem like the right choice though [00:07:58] It's just too page it's named so poorly [00:08:02] too bad* [00:08:11] It goes right along with pageContentMOdel [00:08:16] as being canonical [00:08:17] not view [00:08:25] but then again, what is that kind of data doing on page views anyway then [00:08:51] If we change the one in core, the VE one is justified [00:09:31] And even though mw-content-text's attributes are "fixed" since 2013, they remain semantically different from what VE wants (contrary to this JS var, the attribtues *are* pageViewLang based as it should) [00:09:38] so we definitely can't start using those again [00:10:31] Wait, why; it should use pageViewLang, shouldn't it? [00:11:26] Oh yes those attrs are view-based as they should be [00:11:42] Basically nothing on the view page should be based on pageLang, it should all be based on pageViewLang [00:55:58] RoanKattouw: Don't say words in IRC, +1 https://gerrit.wikimedia.org/r/#/c/276056/ instead. :-) [01:02:07] edsanders|away: *cough* https://phabricator.wikimedia.org/T128282 *cough* [03:24:44] 10TemplateData, 10VisualEditor, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16), 7user-notice: TemplateData API should not return a default format if it is not set (currently defaults to inline) - https://phabricator.wikimedia.org/T128337#2101923 (10ssastry) https://pt.wiki... [03:43:49] 10TemplateData, 10VisualEditor, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16), 7user-notice: TemplateData API should not return a default format if it is not set (currently defaults to inline) - https://phabricator.wikimedia.org/T128337#2101938 (10matmarex) A purge is sup... [04:07:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10Beta-Cluster-Infrastructure: Beta Cluster threw a 'internal_api_error_DBConnectionError' at me - https://phabricator.wikimedia.org/T129192#2101951 (10AlexMonk-WMF) I don't think there's anything for VE to do here. Can you still reproduce the issue with beta? [04:26:38] 10VisualEditor, 10VisualEditor-CopyPaste: Plain paste (Ctrl+Shift+V) of external content into a non-paragraph node breaks, shows ☂ and/or ☀ - https://phabricator.wikimedia.org/T129310#2101973 (10Catrope) [08:18:27] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide support for BLP edit notices on enwiki - https://phabricator.wikimedia.org/T56029#2102142 (10whym) [09:08:21] (03CR) 10Esanders: WIP Make dialog for editing galleries (035 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275931 (owner: 10Tchanders) [09:27:10] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2102269 (10Elitre) I asked, but that really shouldn't depend on translations' length. [09:45:19] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: Edit led to a DEFAULTSORT entry being removed(?) - https://phabricator.wikimedia.org/T67200#2102316 (10Elitre) Maybe this was invalid. There is a "Sort this page by default as" option in the Categories section of the settings dialog, so now it's pretty ob... [10:17:10] (03CR) 10Paladox: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276038 (owner: 10Krinkle) [10:22:23] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [10:42:35] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [10:55:19] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [11:06:05] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [11:53:54] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [12:09:24] (03PS1) 10Divec: WIP DONTMERGE: integrate jquery.ime UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276145 [12:56:48] 10Cite, 7Easy: Cite allows block content inside a span - https://phabricator.wikimedia.org/T128718#2083733 (10Aashaka) I would like to work on this bug. I have changed span to div where required and applied display:inline styling to div.reference-text in ext.cite.styles.css. I also made suitable changes in cit... [13:26:05] Hello everyone. I was working with visualeditor to make it work offline. can anyone here guide me? [13:26:58] 10Cite, 7Easy: Cite allows block content inside a span - https://phabricator.wikimedia.org/T128718#2102905 (10Aklapper) @Aashaka: Thanks for working on this! Have you checked the file `citeParserTests.txt` in the Cite repository? I cannot find anything else either... And [[ https://www.mediawiki.org/wiki/Gerri... [13:43:43] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Snowman added and references deleted by edits of one user (broken browser?) - https://phabricator.wikimedia.org/T126910#2102932 (10Aklapper) This has been "Unbreak Now" priority for three weeks without any news - how to proc... [13:45:09] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-References: Snowman added and references deleted by edits of one user (broken browser?) - https://phabricator.wikimedia.org/T126910#2102947 (10Elitre) You're right Andre - I've given all the details I had, I can't reproduce, and AFAICT... [13:46:42] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2102949 (10Elitre) Is https://translatewiki.net/wiki/MediaWiki:Visualeditor-mweditmodeve-popup-title/de enough? [13:55:28] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team-Backlog, 6Performance-Team, 10Reading-Community-Engagement: How to invoke the performance inspector? - https://phabricator.wikimedia.org/T129322#2102960 (10Moushira) [13:56:53] go back to bed, James_F ! :) [14:04:01] Krenair: how many people have VE explicitly disabled at de.wiki? [14:06:30] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [14:37:59] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [15:06:58] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/275903 (owner: 10Paladox) [15:52:31] 10VisualEditor, 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7WorkType-NewFunctionality: Migrate VisualEditor core npm CI job to Nodepool - https://phabricator.wikimedia.org/T128093#2103313 (10Paladox) Waiting for https://gerrit.wikimedia.org/r/#/c/274441/ to be merged so Visua... [15:54:55] 10VisualEditor, 10Continuous-Integration-Infrastructure, 5Continuous-Integration-Scaling, 7WorkType-NewFunctionality: Migrate VisualEditor core npm CI job to Nodepool - https://phabricator.wikimedia.org/T128093#2103327 (10Krinkle) Per https://phabricator.wikimedia.org/T119143#2026030, npm still must still... [16:13:22] edsanders, we got some feedback :) https://www.mediawiki.org/wiki/Talk:Maps#Discussion_from_WikiVoyage_NL [16:15:00] ed got scared by implications [16:57:13] 10VisualEditor, 10VisualEditor-CopyPaste: Plain paste (Ctrl+Shift+V) of external content into a non-paragraph node breaks, shows ☂ and/or ☀ - https://phabricator.wikimedia.org/T129310#2103494 (10Jdforrester-WMF) p:5Triage>3High a:3Esanders [16:57:45] 10VisualEditor, 10VisualEditor-ContentEditable: Double-clicking a table cell doesn't work in Firefox - https://phabricator.wikimedia.org/T129267#2103498 (10Jdforrester-WMF) [16:57:47] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents - https://phabricator.wikimedia.org/T128282#2103499 (10Jdforrester-WMF) [17:16:32] (03CR) 10Ryasmeen: [C: 032] "Reviewed it with Zeljko." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274955 (https://phabricator.wikimedia.org/T119482) (owner: 10Zfilipin) [17:18:29] (03CR) 10Ryasmeen: [C: 032] "Reviewed it with Zeljko." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274694 (https://phabricator.wikimedia.org/T128731) (owner: 10Zfilipin) [17:22:37] (03PS1) 10Paladox: Test: DO NOT MERGE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276208 [17:23:15] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276208 (owner: 10Paladox) [17:25:04] (03CR) 10Esanders: WIP Make dialog for editing galleries (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275931 (owner: 10Tchanders) [17:29:57] (03CR) 10jenkins-bot: [V: 04-1] Test: DO NOT MERGE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276208 (owner: 10Paladox) [17:31:29] (03Merged) 10jenkins-bot: [BrowserTest] Fix Selenium::WebDriver::Error::StaleElementReferenceError [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274694 (https://phabricator.wikimedia.org/T128731) (owner: 10Zfilipin) [17:32:33] (03CR) 10Paladox: "check experimental" [unicodejs] - 10https://gerrit.wikimedia.org/r/252734 (owner: 10Esanders) [17:32:59] (03Merged) 10jenkins-bot: [BrowserTest] Disable failing language screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274955 (https://phabricator.wikimedia.org/T119482) (owner: 10Zfilipin) [17:37:31] (03PS1) 10Paladox: Test: DO NOT MERGE [unicodejs] - 10https://gerrit.wikimedia.org/r/276212 [17:38:11] (03CR) 10Paladox: "check experimental" [unicodejs] - 10https://gerrit.wikimedia.org/r/276212 (owner: 10Paladox) [17:40:44] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2103717 (10AlexMonk-WMF) That fits on my screen. [17:40:47] (03CR) 10DLynch: "I made Ic4bb40d0d6f57420f2582e33636100c2342707b2 for adding throttle into ooui, and we could either wait for that to merge and get updated" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273938 (owner: 10DLynch) [17:42:34] Elitre, hey, sorry [17:46:37] (03CR) 10Esanders: WIP Make dialog for editing galleries (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275931 (owner: 10Tchanders) [17:47:04] see PM [17:48:41] (03PS1) 10Paladox: Update packages todo with karma and phantomjs [unicodejs] - 10https://gerrit.wikimedia.org/r/276213 [17:49:03] (03CR) 10Paladox: "check experimental" [unicodejs] - 10https://gerrit.wikimedia.org/r/276213 (owner: 10Paladox) [17:50:22] (03Abandoned) 10Paladox: Test: DO NOT MERGE [unicodejs] - 10https://gerrit.wikimedia.org/r/276212 (owner: 10Paladox) [18:03:07] James_F: I'm thinking of splitting https://gerrit.wikimedia.org/r/#/c/254348/ in multiple commits since it's becoming rather big, what do you think? [18:03:40] It looks big but most of it is just rewiring existing functionality into a proper model, so I'm on the fence [18:11:19] 10VisualEditor, 10VisualEditor-MediaWiki: Figure out what happens to edits in progress when the site goes to read-only mode - https://phabricator.wikimedia.org/T129382#2103912 (10Whatamidoing-WMF) [18:19:52] 10VisualEditor, 10VisualEditor-MediaWiki: Figure out what happens to edits in progress when the site goes to read-only mode - https://phabricator.wikimedia.org/T129382#2103912 (10AlexMonk-WMF) https://people.wikimedia.org/~krenair/T129382-local-mid-edit.png You can just dismiss it and you go back to the edit s... [18:21:59] 10VisualEditor, 10VisualEditor-EditingTools, 6Collaboration-Team-Backlog, 6Performance-Team, 10Reading-Community-Engagement: How to invoke the performance inspector? - https://phabricator.wikimedia.org/T129322#2102270 (10Mattflaschen) Is this intentionally tagged Collaboration-Team-Backlog (because of VE... [19:04:25] 10VisualEditor, 10VisualEditor-EditingTools, 6Performance-Team, 10Reading-Community-Engagement: How to invoke the performance inspector? - https://phabricator.wikimedia.org/T129322#2104138 (10Catrope) [19:04:57] 10VisualEditor, 10VisualEditor-EditingTools, 6Performance-Team, 10Reading-Community-Engagement: How to invoke the performance inspector? - https://phabricator.wikimedia.org/T129322#2102270 (10Catrope) >>! In T129322#2103984, @Mattflaschen wrote: > Is this intentionally tagged Collaboration-Team-Backlog (be... [19:05:12] 10VisualEditor, 10TPG-Essential-Functions, 3Team-Practices-This-Week, 15User-JAufrecht: Run VE/Analytics SLU - https://phabricator.wikimedia.org/T129116#2104145 (10JAufrecht) [19:05:18] 10VisualEditor, 10TPG-Essential-Functions, 7Epic, 3Team-Practices-This-Week, 15User-JAufrecht: Run Service Level Understanding exercise between VE and Research & Data - https://phabricator.wikimedia.org/T128932#2104149 (10KLans_WMF) [19:14:12] 10VisualEditor, 10VisualEditor-MediaWiki: Figure out what happens to edits in progress when the site goes to read-only mode - https://phabricator.wikimedia.org/T129382#2104198 (10AlexMonk-WMF) 5Open>3Resolved a:3AlexMonk-WMF Tested in beta, behaves as expected [19:54:32] 10VisualEditor, 10VisualEditor-MediaWiki: Figure out what happens to edits in progress when the site goes to read-only mode - https://phabricator.wikimedia.org/T129382#2104334 (10Whatamidoing-WMF) If you resumed editing, and the wiki stopped being in read-only mode, were you able to successfully save your change? [19:58:28] 10VisualEditor, 10VisualEditor-MediaWiki: Figure out what happens to edits in progress when the site goes to read-only mode - https://phabricator.wikimedia.org/T129382#2104350 (10Whatamidoing-WMF) Also, where does that error message come from? I can't find it at translatewiki.net (and I was wondering whether... [20:09:22] 10VisualEditor, 10VisualEditor-MediaWiki: Figure out what happens to edits in progress when the site goes to read-only mode - https://phabricator.wikimedia.org/T129382#2103912 (10Catrope) >>! In T129382#2104350, @Whatamidoing-WMF wrote: > Also, where does that error message come from? I can't find it at trans... [20:32:10] (03Abandoned) 10Paladox: Test: DO NOT MERGE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276208 (owner: 10Paladox) [20:32:19] (03CR) 10Paladox: "recheck" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276208 (owner: 10Paladox) [20:32:39] (03CR) 10Paladox: "check experimental" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276208 (owner: 10Paladox) [20:47:46] 10VisualEditor, 10VisualEditor-MediaWiki: Figure out what happens to edits in progress when the site goes to read-only mode - https://phabricator.wikimedia.org/T129382#2104595 (10AlexMonk-WMF) >>! In T129382#2104334, @Whatamidoing-WMF wrote: > If you resumed editing, and the wiki stopped being in read-only mod... [20:53:31] (03PS2) 10Divec: WIP DONTMERGE: integrate jquery.ime UI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276145 [20:55:56] (03CR) 10Divec: "For use testing https://github.com/wikimedia/jquery.ime/pull/434 , which needs to be put/symlinked into lib/jquery.ime ." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276145 (owner: 10Divec) [20:56:02] James_F (bumping my message from this morning): I'm thinking of splitting https://gerrit.wikimedia.org/r/#/c/254348/ in multiple commits since it's becoming rather big, what do you think? It looks big but most of it is just rewiring existing functionality into a proper model, so I'm on the fence [21:03:07] 10VisualEditor, 10VisualEditor-MediaWiki: Only show one of the SET-two-tabs dialog (for returning editors) and the VE-welcome-dialog (for newbie editors) - https://phabricator.wikimedia.org/T129200#2104648 (10AlexMonk-WMF) a:3AlexMonk-WMF [21:03:07] (03PS1) 10Alex Monk: Suppress welcome dialog this time if we're showing the SET pref dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276268 (https://phabricator.wikimedia.org/T129200) [21:04:43] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Only show one of the SET-two-tabs dialog (for returning editors) and the VE-welcome-dialog (for newbie editors) - https://phabricator.wikimedia.org/T129200#2104655 (10AlexMonk-WMF) see todo in commit message [21:25:31] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, put SET options in the same order - https://phabricator.wikimedia.org/T128863#2088524 (10AlexMonk-WMF) so... does this need design input? [21:39:59] 10VisualEditor, 10VisualEditor-MediaWiki: On single edit tabs wikis, put SET options in the same order - https://phabricator.wikimedia.org/T128863#2104750 (10Elitre) Not really. You can feel free to close, it's probably really annoying only for me, and there are more pressing things!