[00:03:41] 10VisualEditor, 10Kartographer: "Insert" button in the dialog for inserting Map remains disabled unless there is any change - https://phabricator.wikimedia.org/T129589#2110213 (10Ryasmeen) [00:21:01] 10VisualEditor, 10Kartographer: "Insert" button in the dialog for inserting Map remains disabled unless there is any change - https://phabricator.wikimedia.org/T129589#2110293 (10Yurik) [00:27:09] (03PS1) 10Krinkle: Use $context->msg() in ResourceLoader module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/276668 [00:37:17] 10VisualEditor, 10Kartographer: Map zooms in/out while scrolling the page in Read mode - https://phabricator.wikimedia.org/T129592#2110375 (10Ryasmeen) [00:37:49] 10VisualEditor, 10Kartographer: Map zooms in/out while scrolling the page in Read mode - https://phabricator.wikimedia.org/T129592#2110377 (10Yurik) [02:42:47] mw.messages.get( 'visualeditor-dialog-transclusion-no-template-description' ) [02:42:48] "The "$1" template doesn't yet have a description, but there might be some information on the [[{{ns:template}}:$1|template's page]]." [02:42:55] (from prod enwiki) [02:42:59] and yet: https://en.wikipedia.org/wiki/MediaWiki:Visualeditor-dialog-transclusion-no-template-description [02:43:03] no customisation [02:43:10] but no "{{ns:template}}:" [02:43:19] > var_dump( wfMessage( 'visualeditor-dialog-transclusion-no-template-description' )->inLanguage( 'en-gb' )->text() ); [02:43:19] string(116) "The "$1" template doesn't yet have a description, but there might be some information on the [[$1|template's page]]." [02:47:37] change was in https://gerrit.wikimedia.org/r/#/c/274120/ [02:48:13] (03CR) 10Alex Monk: "> var_dump( wfMessage( 'visualeditor-dialog-transclusion-no-template-description' )->text() );" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274120 (https://phabricator.wikimedia.org/T128333) (owner: 10Esanders) [02:50:25] Krinkle, ^ [02:51:59] that would've hit enwiki at around 21:00, i.e. 6 hours ago [02:54:32] RoanKattouw, maybe you know about this? I imagine it's RL caching-related [02:54:46] Probably [02:55:02] I can try to bump it if you can find me a .js file that is in the same RL module as that message [02:55:14] I can do that :p [02:55:17] Or... well you're a deployer yourself, you can do it :) [02:55:25] touch filename.js; sync-file filename.js [02:55:33] Although... wait crap [02:55:38] We have content-based caching now don't we [02:55:42] Shit [02:55:57] RL caching stuff doesn't work the way it used to, and the new stuff is all Kri [02:56:00] * Krinkle [02:56:34] checking [02:57:38] That fixed it [02:57:52] Interesting [02:58:00] I guess timestamps are in fact still used somwhere [05:31:43] 10VisualEditor, 10VisualEditor-MediaWiki: SET should obey the skin compatibility rules - https://phabricator.wikimedia.org/T128574#2079280 (10AlexMonk-WMF) WFM :/ [05:42:31] 10VisualEditor, 10VisualEditor-MediaWiki: If the user picks "show me both tabs" in the VE tab choice menu, reload the page or otherwise show both tabs - https://phabricator.wikimedia.org/T129510#2111089 (10AlexMonk-WMF) a:3AlexMonk-WMF [05:42:39] (03PS1) 10Alex Monk: Reload page after user selects multi-tab option of SET dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276698 (https://phabricator.wikimedia.org/T129510) [05:49:47] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not working in Chrome/Windows, at least for basic refs - https://phabricator.wikimedia.org/T129629#2111104 (10Whatamidoing-WMF) [05:56:44] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not working in Chrome/Windows, at least for basic refs - https://phabricator.wikimedia.org/T129629#2111118 (10Whatamidoing-WMF) [07:01:57] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not working in Chrome/Windows, at least for basic refs - https://phabricator.wikimedia.org/T129629#2111152 (10Whatamidoing-WMF) Two comments: * The Trove website uses HTML definition list formatting to display the mult... [07:06:32] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Exciting!" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276145 (owner: 10Divec) [08:27:41] (03CR) 10Gilles: [C: 032] Use $context->msg() in ResourceLoader module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/276668 (owner: 10Krinkle) [08:29:12] (03Merged) 10jenkins-bot: Use $context->msg() in ResourceLoader module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/276668 (owner: 10Krinkle) [10:29:27] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2111357 (10Elitre) I'm in Safari/Mac today and it works even if I copy/paste it from Phab dire... [10:44:42] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2111374 (10Trizek-WMF) I retried it on xubuntu 14.04, Firefox 44 and Chromium 48: * no proble... [12:48:14] 10VisualEditor: Come up with a design to make it easier for users to see that there is no space after a link (just the cartouche) and so you probably want to add one - https://phabricator.wikimedia.org/T128060#2111602 (10Elitre) (Stumbled upon T101917, possibly related?) [13:08:13] (03PS16) 10Esanders: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) [13:12:57] (03PS1) 10Esanders: CommandHelpDialog: Use this.constructor.static [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 [13:14:31] (03PS1) 10Esanders: CommandHelpDialog: Use this.constructor.static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276730 [13:20:41] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Use this.constructor.static [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 (owner: 10Esanders) [13:49:55] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not working in Chrome/Windows, at least for basic refs - https://phabricator.wikimedia.org/T129629#2111104 (10Esanders) Wikitext conversion only runs on plain text paste at the moment. [13:54:17] 10VisualEditor, 10VisualEditor-Links: External link field must be empty when adding link to existing word - https://phabricator.wikimedia.org/T129650#2111748 (10Elitre) [14:03:22] 10VisualEditor, 10VisualEditor-Links: External link field must be empty when adding link to existing word - https://phabricator.wikimedia.org/T129650#2111775 (10Elitre) [14:04:30] 10VisualEditor, 10VisualEditor-Links: External link field must be empty when adding link to existing word - https://phabricator.wikimedia.org/T129650#2111748 (10Elitre) [14:12:32] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Make it obvious when content is coming from a transcluded page - https://phabricator.wikimedia.org/T129652#2111795 (10Elitre) [14:45:00] (03CR) 10Alex Monk: "(touching MWTemplatePage.js and syncing fixed it)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/274120 (https://phabricator.wikimedia.org/T128333) (owner: 10Esanders) [14:56:30] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2111866 (10Aklapper) Hi @Trizek-WMF. For future reference, please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task to allow othe... [15:08:39] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2111874 (10Trizek-WMF) >>! In T129646#2111866, @Aklapper wrote: > Hi @Trizek-WMF. For future reference, please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE... [15:09:50] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2111604 (10Krenair) >>! In T129646#2111874, @Trizek-WMF wrote: > I'm pretty sure I did associate the task to VisualEditor project... I may have done something wrong while editing the task. Actuall... [15:14:10] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2111879 (10Trizek-WMF) >>! In T129646#2111876, @Krenair wrote: >>>! In T129646#2111874, @Trizek-WMF wrote: >> I'm pretty sure I did associate the task to VisualEditor project... I may have done som... [15:23:12] (03PS1) 10Esanders: Inspector: Position button above mw-body-content [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/276749 [15:44:35] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Add non-breaking space (nbsp) to the "special character" dialog - https://phabricator.wikimedia.org/T70429#2111917 (10Elitre) Given that https://phabricator.wikimedia.org/T53045#1947804 happened, I guess that the special character option is still more... [15:56:55] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Make it obvious when content is coming from a transcluded page - https://phabricator.wikimedia.org/T129652#2111795 (10Esanders) Isn't that what the highlight and the context does? [15:57:25] 10VisualEditor, 10Math: In math inspector, when height is limited the editing section (with active cursor) is not visible - https://phabricator.wikimedia.org/T121150#2111937 (10Tchanders) It does have a scrollbar (on the right in @Ryasmeen's image (@DLynch do you have the latest version checked out?)) - but... [15:58:31] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Make it obvious when content is coming from a transcluded page - https://phabricator.wikimedia.org/T129652#2111942 (10Elitre) No? [16:00:34] 10VisualEditor, 10VisualEditor-Links: External link field must be empty when adding link to existing word - https://phabricator.wikimedia.org/T129650#2111748 (10Esanders) If I open the link inspector, apple is a suggestion but it also selected, so pressing paste overwrites it - leaving a clean link. [16:09:50] 10VisualEditor, 10VisualEditor-Links: External link field must be empty when adding link to existing word - https://phabricator.wikimedia.org/T129650#2111975 (10Elitre) It's selected in the Search pages (internal wikilink) tab, not in the External link one. [16:15:58] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2111985 (10Esanders) >>! In T129646#2111874, @Trizek-WMF wrote: >>>! In T129646#2111850, @Esanders wrote: >> It's just as easy to copy and paste the document contents - and that already works. Conv... [16:20:38] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2111998 (10Trizek-WMF) We both tried with that document: {F3616744} [16:42:57] (03CR) 10Jforrester: [C: 032] Inspector: Position button above mw-body-content [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/276749 (owner: 10Esanders) [16:43:18] (03CR) 10Jforrester: [C: 032] CommandHelpDialog: Use this.constructor.static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276730 (owner: 10Esanders) [16:43:35] 10VisualEditor, 10Math: In math inspector, when height is limited the editing section (with active cursor) is not visible - https://phabricator.wikimedia.org/T121150#2112029 (10DLynch) I have a Mac -- invisible scrollbars everywhere. I'd say collapse the symbol menu. Being able to see the input and the prev... [16:48:49] (03Merged) 10jenkins-bot: Inspector: Position button above mw-body-content [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/276749 (owner: 10Esanders) [16:48:51] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Use this.constructor.static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276730 (owner: 10Esanders) [17:33:52] 10Cite, 10MediaWiki-API, 10MobileFrontend, 3Reading-Web-Sprint-67-If, Then, Else...?: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2112159 (10Jdlrobson) [17:33:54] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 2 others: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#2112160 (10Jdlrobson) [17:36:48] (03PS1) 10Alex Monk: Log readonly code for readonly errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276773 [17:36:50] (03PS1) 10Alex Monk: Prefer error *code* when logging unknown errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276774 [17:37:54] (03PS1) 10Esanders: MWSaveDialog: Fix vertical alignment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276776 [17:40:30] (03PS4) 10DLynch: Use throttle instead of debounce for find/replace rendering [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/273938 [17:51:54] 10VisualEditor, 10VisualEditor-MediaWiki, 6Editing-Analysis: Revise the Edit schema and its use - https://phabricator.wikimedia.org/T118063#2112208 (10AlexMonk-WMF) We should rethink how action.saveFailure.type works - ideally we'd log the actual error codes provided by MW, rather than having our own system... [18:12:11] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not always working in Chrome/Windows, maybe related to list formatting in the source - https://phabricator.wikimedia.org/T129629#2112259 (10Whatamidoing-WMF) [18:12:53] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not always working in Chrome/Windows, maybe related to list formatting in the source - https://phabricator.wikimedia.org/T129629#2111104 (10Whatamidoing-WMF) So when I copy the same letters off the Trove website in Safari... [18:45:50] I am not able to connect the visual editor to parsoid [18:45:59] although not getting error anywhere [18:46:50] every time I hit the edit button. A progress bar appears but the visual editor doesn't shows up [18:54:36] do you get an error message? [18:54:46] no error [18:55:25] It seems like the VE and Parsoid are not able to communicate [18:55:37] check your JS console [18:56:09] you mean for the parsoid api right ? [18:56:11] no [18:56:18] when VE fails to connect to parsoid it should show an error message [18:56:25] if you get no error, I suggest checking your browser's JS console [18:56:36] okay just a sec [18:59:33] no error on the console [19:01:57] " http://localhost/mediawiki/index.php/Main_Page?veaction=edit " this link is called along with a progress bar on the screen that goes complete and then I'm again on the same page i.e " http://localhost/mediawiki/index.php/Main_Page " [19:04:35] 10VisualEditor, 15User-JAufrecht: Follow up on VE SLUs after the Engineering Offsite - https://phabricator.wikimedia.org/T111226#2112616 (10JAufrecht) [19:05:11] veee eeee ssslllloooosss [19:12:35] " http://localhost/mediawiki/index.php/Main_Page?veaction=edit " this link is called along with a progress bar on the screen that goes complete and then I'm again on the same page i.e " http://localhost/mediawiki/index.php/Main_Page " [19:22:59] 10VisualEditor, 10TPG-Essential-Functions, 3Team-Practices-This-Week, 15User-JAufrecht: Run VE/Analytics SLU - https://phabricator.wikimedia.org/T129116#2112730 (10JAufrecht) [19:23:01] 10VisualEditor, 15User-JAufrecht: Run Analytics/VE SLU - https://phabricator.wikimedia.org/T120879#2112731 (10JAufrecht) [19:23:54] 10VisualEditor, 15User-JAufrecht: Run Analytics/VE SLU - https://phabricator.wikimedia.org/T120879#1863923 (10JAufrecht) [19:24:25] 10VisualEditor, 10TPG-Essential-Functions, 7Epic, 3Team-Practices-This-Week, 15User-JAufrecht: Run Service Level Understanding exercise between VE and Research & Data - https://phabricator.wikimedia.org/T128932#2112736 (10JAufrecht) [19:24:27] 10VisualEditor, 15User-JAufrecht: Follow up on VE SLUs after the Engineering Offsite - https://phabricator.wikimedia.org/T111226#2112735 (10JAufrecht) [19:25:48] 10VisualEditor, 15User-JAufrecht: Follow up on VE SLUs after the Engineering Offsite - https://phabricator.wikimedia.org/T111226#1598400 (10JAufrecht) [19:27:29] 10VisualEditor, 7Epic, 15User-JAufrecht: Negotiate Service Levels between VE and Stakeholders and identify underlying contradictory needs - https://phabricator.wikimedia.org/T102571#2112758 (10JAufrecht) [19:28:21] 10VisualEditor, 15User-JAufrecht: Follow up on VE/DR SLU - https://phabricator.wikimedia.org/T129687#2112759 (10JAufrecht) [19:30:00] 10VisualEditor, 15User-JAufrecht: Follow up on VE SLUs after the Engineering Offsite - https://phabricator.wikimedia.org/T111226#1598400 (10JAufrecht) [19:39:26] Error loading data from server. curl 28 error. Parsoidserver-http-error. any help ?? [19:42:23] Error loading data from server. curl 28 error. Parsoidserver-http-error. any help ?? [19:48:19] new_guest, so you are getting errors? [19:48:34] yes [19:49:17] I suppose the problem is that the VE and Parsoid aren't able to communicate [19:49:24] new_guest, what parsoid url did you give VE? [19:50:13] $wgVisualEditorParsoidURL = 'http://localhost:8888'; $wgVisualEditorParsoidPrefix = 'localhost'; [19:50:47] and can you browse to http://localhost:8888? [19:51:11] yes [19:51:22] it opens aparsoid page [19:56:29] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-j: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2112914 (10Jdlrobson) [19:57:01] yes , it opens parsoid page [20:07:09] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-j: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2112933 (10Jdlrobson) [20:07:33] 10Cite, 13Patch-For-Review: References stored in page props are not parsed - https://phabricator.wikimedia.org/T127263#2112939 (10Jdlrobson) [20:07:35] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-j: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2000071 (10Jdlrobson) [20:14:13] yes , it opens parsoid page [21:03:32] Krenair .... yes , it opens parsoid page [21:04:14] hm [21:04:45] well curl times out trying to connect [21:05:17] so that means that it is not able to connect to parsoid [21:06:40] Krenair....can you suggest any documentation on using VE + parsoid on wiki 1.26.x ? [21:07:03] this is with your browser, web server and parsoid all on one machine, right? [21:07:19] right [21:07:24] the existing documentation should be good enough, I suspect there's something wrong on your side here [21:08:15] can you share me the link to the documentation , maybe I am referring the inappropriate documentation [21:09:42] https://www.mediawiki.org/wiki/Extension:VisualEditor#Setting_VisualEditor_up [21:11:07] Krenair ... but this documentation is for wiki 1.27 alpha [21:12:13] doesn't mean it won't work on 1.26 [21:18:54] Krenair... can you send me your local settings.php and local settings.js (only the VE configuration part) ? It would be of very much help [21:19:18] My setup is a mess and far more complicated than a simple VE -> parsoid config [21:22:57] Krenair... I changed the settings a bit but it is now giving me another error "Http:200" error [21:23:13] "error downloading data from the server" [21:30:44] Krenair... I changed the settings a bit but it is now giving me another error "Http:200" error.... "error downloading data from the server" [21:31:16] although status code 200 means everything went fine [21:39:20] (03PS1) 10Krinkle: Use ResourceLoaderContext::msg() in VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276888 [21:44:01] 10VisualEditor, 10VisualEditor-MediaWiki, 7Technical-Debt: Warning: Unable to fetch message `visualeditor-annotationbutton-magiclinknode` and related keys - https://phabricator.wikimedia.org/T129704#2113288 (10Krinkle) [21:44:17] 10VisualEditor, 10VisualEditor-MediaWiki, 7Wikimedia-log-errors: Warning: Unable to fetch message `visualeditor-annotationbutton-magiclinknode` and related keys - https://phabricator.wikimedia.org/T129704#2113302 (10Krinkle) [21:52:34] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Tech: HotCat doesn't load after saving a page in VisualEditor (must refresh/reload first) [AOI] - https://phabricator.wikimedia.org/T103285#2113318 (10kaldari) Switched HotCat to use wikipage.content hook instead (which works for null edits as well): https... [21:52:55] Krenair ... thanks for help [21:53:03] I did it! [21:53:08] I didn't do much [21:53:23] No you did help me [21:53:33] :) [21:53:49] 10VisualEditor, 10VisualEditor-MediaWiki: Null edits in VisualEditor don't fire the postEdit hook - https://phabricator.wikimedia.org/T117455#2113321 (10kaldari) 5Open>3Invalid Closing as Invalid per Krinkle. [21:54:19] (03CR) 10Krinkle: "If either of these messages is supposed to be fetched based on site language rather than user language, then add inContentLanguage()." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276888 (owner: 10Krinkle) [21:57:57] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-j: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2000071 (10jayvdb) Why is it now "Special:MobileCitations" in the task description? There are non-mobile users without JavaScr... [22:40:49] 10VisualEditor, 10VisualEditor-CopyPaste: Support preserving links in pasted HTML content - https://phabricator.wikimedia.org/T129546#2108764 (10Tbayer) This would be extremely cool. I earlier settled on using a detour via LibreOffice's "Wiki Publisher" extention to export to wikitext: https://meta.wikimedia.o... [23:18:22] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not working in Chrome/Windows when the source uses definition list formatting - https://phabricator.wikimedia.org/T129629#2113563 (10Whatamidoing-WMF) [23:18:49] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not working in Chrome/Windows when the source uses definition list formatting - https://phabricator.wikimedia.org/T129629#2111104 (10Whatamidoing-WMF) The problem seems to be related to definition/association list formatt... [23:36:19] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 6Collaboration-Team-Backlog, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2113650 (10GWicke) @ssastry: Thanks for updating the task description. I'm broadly in agreement with your outline....