[00:16:50] 10VisualEditor, 10VisualEditor-CopyPaste: Support preserving links in pasted HTML content - https://phabricator.wikimedia.org/T129546#2115181 (10Esanders) I don't think preserving inline CSS is going to be a good idea for WMF wikis. Most HTML sources contain a ton of unwanted inline styles, and 99% of the time... [07:28:27] (03CR) 10Jforrester: [C: 032] "TWN removes them from their interface to their users, but doesn't remove them in a git change unless another message in that language file" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277054 (https://phabricator.wikimedia.org/T129704) (owner: 10Alex Monk) [07:38:13] (03Merged) 10jenkins-bot: Remove message entries for messages that got deleted a month ago [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277054 (https://phabricator.wikimedia.org/T129704) (owner: 10Alex Monk) [07:45:01] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-15_(1.27.0-wmf.17), 7Wikimedia-log-errors: Warning: Unable to fetch message `visualeditor-annotationbutton-magiclinknode` and related keys - https://phabricator.wikimedia.org/T129704#2115373 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3... [07:52:50] (03CR) 10Jforrester: [C: 031] In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276933 (https://phabricator.wikimedia.org/T125437) (owner: 10Alex Monk) [08:01:17] (03CR) 10Jforrester: "> The label should probably remain in user language." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276888 (owner: 10Krinkle) [08:05:02] (03CR) 10Jforrester: [C: 032] Use ResourceLoaderContext::msg() in VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276888 (owner: 10Krinkle) [08:09:04] (03PS1) 10Jforrester: CitoidDataModule: Fetch JSON config in content language [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/277064 [08:15:44] (03Merged) 10jenkins-bot: Use ResourceLoaderContext::msg() in VisualEditorDataModule [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276888 (owner: 10Krinkle) [10:17:38] 10WikiEditor, 10MediaWiki-General-or-Unknown, 7Design, 7WorkType-NewFunctionality: "Show edit toolbar" preference is confusing - https://phabricator.wikimedia.org/T32795#2115712 (10Nemo_bis) [10:49:51] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2115972 (10Esanders) This works for me pasting from LibreOffice. Which office software and version are you using? Also can you paste into the right hand box here: http://edg2s.github.io/content-edi... [10:59:46] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2115973 (10Esanders) Also works fine in Windows 10 + Office 2016 + Chrome/Firefox. NB there is a known bug if you select all and paste over an existing document in Chrome where some content is dro... [11:01:36] 10Cite, 5WMF-deploy-2016-03-15_(1.27.0-wmf.17): Cite's extension.json does not pass validation - https://phabricator.wikimedia.org/T128311#2115974 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal [11:02:27] 10VisualEditor, 6Discovery, 7I18n: Smarter morphology-aware search for article titles in the Visual Editor linking tool auto-completion - https://phabricator.wikimedia.org/T129769#2115978 (10Amire80) [11:30:59] (03CR) 10Jforrester: [C: 032] MWSaveDialog: Fix vertical alignment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276776 (owner: 10Esanders) [11:35:47] (03CR) 10Jforrester: [C: 031] Prefer error *code* when logging unknown errors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276774 (owner: 10Alex Monk) [11:36:09] 10VisualEditor: Useless box saying "One message" shown when editing with Visual Editor in the user space in the Arabic Wikipedia - https://phabricator.wikimedia.org/T129773#2116031 (10Amire80) [11:38:17] (03CR) 10Jforrester: Log readonly code for readonly errors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276773 (owner: 10Alex Monk) [11:40:42] (03CR) 10Jforrester: "Doesn't this need to handle edit -> WT [change] -> switch to VE with payload?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276698 (https://phabricator.wikimedia.org/T129510) (owner: 10Alex Monk) [11:41:16] (03PS2) 10Jforrester: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267616 [11:41:33] (03CR) 10Jforrester: "Maybe this is OK to land now?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267616 (owner: 10Jforrester) [11:43:18] (03Merged) 10jenkins-bot: MWSaveDialog: Fix vertical alignment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276776 (owner: 10Esanders) [11:55:55] 10VisualEditor, 6Discovery, 7I18n: Smarter morphology-aware search for article titles in the Visual Editor linking tool auto-completion - https://phabricator.wikimedia.org/T129769#2116049 (10Amire80) ... Come to think of it, maybe it's not such a long shot—Completion Suggester sounds like something that coul... [12:05:19] 10VisualEditor: Duplicate annotations not visible (e.g. bold headings) - https://phabricator.wikimedia.org/T129774#2116054 (10Esanders) [12:15:53] 10VisualEditor, 7Design: Provide some way to make duplicate annotations visible to users whilst editing (e.g. bold headings) - https://phabricator.wikimedia.org/T129774#2116080 (10Jdforrester-WMF) p:5Triage>3Low [12:48:45] 10VisualEditor, 10VisualEditor-ContentEditable: Unable to edit table cell after double click on cell - https://phabricator.wikimedia.org/T128588#2116114 (10Nnvu) [12:48:47] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents - https://phabricator.wikimedia.org/T128282#2116115 (10Nnvu) [13:29:42] (03PS2) 10Jforrester: CommandHelpDialog: Use this.constructor.static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276730 (owner: 10Esanders) [13:29:48] (03CR) 10Jforrester: [C: 032] CommandHelpDialog: Use this.constructor.static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276730 (owner: 10Esanders) [13:30:05] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox: [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents - https://phabricator.wikimedia.org/T128282#2116129 (10Esanders) Bisect blames https://gerrit.wikimedia.org/r/#/c/270254/ [13:35:29] (03Merged) 10jenkins-bot: CommandHelpDialog: Use this.constructor.static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276730 (owner: 10Esanders) [13:44:20] (03PS1) 10Jforrester: Update VE core submodule to master (5f451d2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277080 [13:48:24] (03PS2) 10Jforrester: CommandHelpDialog: Use this.constructor.static [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 (owner: 10Esanders) [13:52:22] (03CR) 10Jforrester: "Eurgh. This passes locally, but fails in CI for some reason. Presumably some extension?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 (owner: 10Esanders) [13:52:39] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2116132 (10jeblad) [13:57:16] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2116144 (10jeblad) [13:58:07] (03CR) 10jenkins-bot: [V: 04-1] CommandHelpDialog: Use this.constructor.static [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 (owner: 10Esanders) [14:07:51] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Make it obvious when content is coming from a transcluded page - https://phabricator.wikimedia.org/T129652#2116151 (10Jdforrester-WMF) 5Open>3declined >>! In T129652#2111942, @Elitre wrote: > No? > To clarify, how is that highlight/context different from... [14:18:18] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2116161 (10Jdforrester-WMF) 5Open>3Invalid It's entirely possible to make trailing links in editors that get turned into wikitext via Parsoid (//i.e.// `[[Foo]]bar`), including VisualEditor. However, Pars... [17:49:43] (03Abandoned) 10Alex Monk: Revert "Re-add null appendix tab messages to extension.json" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/267616 (owner: 10Jforrester) [18:04:02] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2116318 (10jeblad) Note that this isn't about the cases where Parsoid write out the internal link as the piped style, it is about Parsoid not respecting the trailing chars. At nowiki we use trailing chars a l... [18:06:31] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2116319 (10jeblad) 5Invalid>3Open [18:07:18] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2116132 (10jeblad) I have reopened this as this is a BUG! Start handling BUGS as they should and don't just make claims that are INVALID! [18:24:03] (03CR) 10Alex Monk: Log readonly code for readonly errors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276773 (owner: 10Alex Monk) [18:24:41] (03CR) 10Alex Monk: In the event of a document reload due to RB vs. API rev ID conflict, always re-set requestedRevId (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276933 (https://phabricator.wikimedia.org/T125437) (owner: 10Alex Monk) [18:26:07] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (5f451d2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277080 (owner: 10Jforrester) [18:28:15] (03CR) 10Alex Monk: [C: 04-1] CommandHelpDialog: Use this.constructor.static (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 (owner: 10Esanders) [18:29:33] James_F|Away, https://phabricator.wikimedia.org/T129501 doesn't count as interrupt? [18:43:43] (03Merged) 10jenkins-bot: Update VE core submodule to master (5f451d2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277080 (owner: 10Jforrester) [19:48:42] (03PS1) 10Esanders: Ensure table cells are ce=true before computing offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277104 (https://phabricator.wikimedia.org/T128282) [20:27:40] (03CR) 10DLynch: [C: 032] "Fixes the issue in Firefox, apart from in Alien tables... but that's niche and kind of messed up anyway." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277104 (https://phabricator.wikimedia.org/T128282) (owner: 10Esanders) [20:33:55] (03Merged) 10jenkins-bot: Ensure table cells are ce=true before computing offsets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277104 (https://phabricator.wikimedia.org/T128282) (owner: 10Esanders) [20:36:56] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility: In template insert dialog, tab focus goes through a bunch of invisible buttons before reaching the "Insert" action - https://phabricator.wikimedia.org/T129791#2116441 (10matmarex) [20:50:58] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility: Tab order in link insertion dialog is all messed up - https://phabricator.wikimedia.org/T129792#2116456 (10matmarex) [20:55:10] 10VisualEditor, 7Accessibility: Please verify that using Ctrl+Enter in all dialogs and inspectors works to confirm the changes - https://phabricator.wikimedia.org/T129793#2116471 (10matmarex) [21:06:07] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility: Tab order in link insertion dialog is all messed up - https://phabricator.wikimedia.org/T129792#2116499 (10matmarex) So, I guess I'd expect this: {F3627895} The order of dialog action buttons is defined by OOjs UI, filed T129794 about them. [21:08:10] 10VisualEditor, 7Accessibility: Please verify that using Ctrl+Enter in all dialogs and inspectors works to confirm the changes - https://phabricator.wikimedia.org/T129793#2116502 (10matmarex) [21:08:13] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.16.2): Provide Ctrl+Enter as a keyboard shortcut to confirm OOui dialogs - https://phabricator.wikimedia.org/T125860#2116503 (10matmarex) [21:19:05] 10VisualEditor, 7Accessibility: Please verify that using Ctrl+Enter in all dialogs and inspectors works to confirm the changes - https://phabricator.wikimedia.org/T129793#2116471 (10eranroz) I test most dialog and everything seems to be cool. The only exception is Insert Media - it doesn't work before clicki... [21:20:02] it would be nice to enable VE for anons in http://en.wikipedia.beta.wmflabs.org [22:28:28] 10VisualEditor: remove non-URL-like text from the Visual Editor link tool when moving to the external link tab - https://phabricator.wikimedia.org/T129815#2116831 (10Amire80) [22:32:08] 10VisualEditor, 7Design: Make buttons in the VisualEditor link tool consistent - https://phabricator.wikimedia.org/T129817#2116857 (10Amire80) [22:32:33] 10VisualEditor, 10VisualEditor-MediaWiki: On redirect pages, meta dialog appears over the top of the SET pref dialog - https://phabricator.wikimedia.org/T129819#2116883 (10AlexMonk-WMF) [23:14:15] 10VisualEditor, 10MediaWiki-ResourceLoader, 10MediaWiki-extensions-CodeEditor, 13Patch-For-Review, 7Regression: [Regression wmf.15] Ace editor doesn't load in debug mode (local 'require' var ends up removed half-way) - https://phabricator.wikimedia.org/T127643#2116934 (10TheDJ) i've added a patch to upda... [23:33:00] 10VisualEditor, 10VisualEditor-MediaWiki: Can't switch from the visual editor to the wikitext editor unless I make a change first - https://phabricator.wikimedia.org/T129724#2116941 (10Whatamidoing-WMF) I started in the visual editor. My account on office.wiki is set to all visual, all the time. (I may somed...