[00:25:13] (03CR) 10Alex Monk: Prefer error *code* when logging unknown errors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276774 (owner: 10Alex Monk) [00:27:58] (03PS2) 10Alex Monk: Prefer error *code* when logging unknown errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276774 [00:49:51] (03CR) 10Jforrester: [C: 032] Prefer error *code* when logging unknown errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276774 (owner: 10Alex Monk) [00:50:18] (03CR) 10Jforrester: [C: 032] Log readonly code for readonly errors (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276773 (owner: 10Alex Monk) [00:57:05] (03PS1) 10Jforrester: Update VE core submodule to master (c1e1bd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277180 [00:59:11] (03PS1) 10Jforrester: Ensure table cells are ce=true before computing offsets [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277181 (https://phabricator.wikimedia.org/T128282) [00:59:34] (03CR) 10Jforrester: [C: 032] Ensure table cells are ce=true before computing offsets [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277181 (https://phabricator.wikimedia.org/T128282) (owner: 10Jforrester) [01:00:49] (03Merged) 10jenkins-bot: Log readonly code for readonly errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276773 (owner: 10Alex Monk) [01:01:50] (03Merged) 10jenkins-bot: Prefer error *code* when logging unknown errors [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276774 (owner: 10Alex Monk) [01:02:02] (03PS1) 10Jforrester: Update VE core submodule to wmf/1.27.0-wmf.16 HEAD (5019e21) [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277183 [01:02:14] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox, 13Patch-For-Review, and 2 others: [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents - https://phabricator.wikimedia.org/T128282#2116982 (10Jdforrester-WMF) a:3Esanders [01:03:53] (03Merged) 10jenkins-bot: Ensure table cells are ce=true before computing offsets [VisualEditor/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277181 (https://phabricator.wikimedia.org/T128282) (owner: 10Jforrester) [01:04:50] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to wmf/1.27.0-wmf.16 HEAD (5019e21) [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277183 (owner: 10Jforrester) [02:37:23] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, and 2 others: Save references in page_props and cache - https://phabricator.wikimedia.org/T125329#1984641 (10GWicke) As you probably know, RESTBase was initially created to address a very similar need: The revisioned storage of HTML and... [05:58:38] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Two copies of a template were inserted - https://phabricator.wikimedia.org/T129725#2117136 (10Whatamidoing-WMF) I managed to do it again. Just double-click the "Insert" button (rapidly – it might take a few tries). [09:16:41] 10VisualEditor, 10VisualEditor-CopyPaste: Don't strip links when pasting HTML to VisualEditor form in non-Main namespaces - https://phabricator.wikimedia.org/T129833#2117358 (10QuimGil) [09:48:03] 10VisualEditor, 10VisualEditor-CopyPaste: Don't strip links when pasting HTML to VisualEditor form in non-Main namespaces - https://phabricator.wikimedia.org/T129833#2117358 (10Esanders) Related T129546 [10:07:27] 10VisualEditor, 6Operations, 10Parsoid, 10Traffic, and 2 others: Decom parsoid-lb.eqiad.wikimedia.org entrypoint - https://phabricator.wikimedia.org/T110474#2117474 (10KartikMistry) [11:05:36] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Make it obvious when content is coming from a transcluded page - https://phabricator.wikimedia.org/T129652#2117545 (10Elitre) ... I can see the difference when I look at the code: I can't when I'm in VE. But whatever. [11:19:08] (03CR) 10Amire80: [C: 032] [BrowserTest] Disable failing language screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276458 (https://phabricator.wikimedia.org/T119482) (owner: 10Zfilipin) [11:33:55] (03Merged) 10jenkins-bot: [BrowserTest] Disable failing language screenshot scenario [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276458 (https://phabricator.wikimedia.org/T119482) (owner: 10Zfilipin) [12:00:20] (03PS1) 10Zfilipin: [BrowserTest] Increase the time Selenium waits for VisualEditor to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277224 (https://phabricator.wikimedia.org/T94150) [12:01:31] (03CR) 10Amire80: [C: 032] [BrowserTest] Increase the time Selenium waits for VisualEditor to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277224 (https://phabricator.wikimedia.org/T94150) (owner: 10Zfilipin) [12:18:50] (03Merged) 10jenkins-bot: [BrowserTest] Increase the time Selenium waits for VisualEditor to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277224 (https://phabricator.wikimedia.org/T94150) (owner: 10Zfilipin) [12:19:09] (03PS1) 10Esanders: FocusableNode: Protect against calculateHighlights being called on null surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277226 (https://phabricator.wikimedia.org/T129549) [12:19:26] 10VisualEditor, 13Patch-For-Review: [Regression pre-wmf.17] Adding a citation note right after another one is throwing an error "TypeError: this.focusableSurface is null" upon save - https://phabricator.wikimedia.org/T129549#2108827 (10Esanders) Can't reproduce but the above commit should protect against the r... [12:34:46] 10Citoid, 10VisualEditor, 10scap, 10Scap3 (Scap3-Adoption-Phase1): Deploy Citoid with scap3 - https://phabricator.wikimedia.org/T116337#2117739 (10mobrovac) a:3mobrovac [12:44:43] 10VisualEditor, 10VisualEditor-CopyPaste, 6Collaboration-Team-Backlog, 10Flow, 13Patch-For-Review: Don't strip links when pasting HTML to VisualEditor form in non-Main namespaces - https://phabricator.wikimedia.org/T129833#2117754 (10Esanders) [12:45:09] 10VisualEditor, 10VisualEditor-CopyPaste, 6Collaboration-Team-Backlog, 10Flow, 13Patch-For-Review: Don't strip links when pasting HTML to VisualEditor form in non-Main namespaces - https://phabricator.wikimedia.org/T129833#2117756 (10Esanders) The above patch whitelists link pasting in Flow. [12:48:30] 10VisualEditor, 10VisualEditor-CopyPaste, 6Collaboration-Team-Backlog, 10Flow, 13Patch-For-Review: Don't strip links when pasting HTML to VisualEditor form in non-Main namespaces - https://phabricator.wikimedia.org/T129833#2117764 (10QuimGil) Whitelisting Flow is a good idea. Thank you! [13:00:20] (03PS1) 10Esanders: Sanitize the paste context in the same way as the paste data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277232 (https://phabricator.wikimedia.org/T129310) [13:04:52] (03PS2) 10Esanders: Sanitize the paste context in the same way as the paste data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277232 (https://phabricator.wikimedia.org/T129310) [13:26:27] (03CR) 10Esanders: "You can use the 'Keyboard' icon from ooui-icons-interaction." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276145 (owner: 10Divec) [13:27:38] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#2117812 (10Sadads) @JDforrester-WMF This could be also something that we build into the #education-program-dashboard -- as it becomes the Programs and Events Dashboard for ot... [13:35:10] (03CR) 10Esanders: "Tag with T126125" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276145 (owner: 10Divec) [14:17:59] (03PS1) 10Esanders: AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277241 (https://phabricator.wikimedia.org/T127643) [14:23:35] (03CR) 10jenkins-bot: [V: 04-1] AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277241 (https://phabricator.wikimedia.org/T127643) (owner: 10Esanders) [14:33:29] edsanders, hi, want to reply to https://www.mediawiki.org/wiki/Talk:Maps#How_is_placing_a_marker_in_the_VE_supposed_to_work_with_Wikivoyage_listings.3F [14:33:41] VE is your area :) [14:35:35] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2117961 (10Trizek-WMF) I just copy-pasted the content on the ghitub form. I have these results on Xubuntu 14.04 LTS, from Libre Office Writer 4.2.8.2 : * Chromium: Importer depuis un traitement de... [14:36:36] 10VisualEditor, 10VisualEditor-CopyPaste: Support preserving links in pasted HTML content - https://phabricator.wikimedia.org/T129546#2117965 (10Tbayer) @Esanders Re workaround, thanks for the hint. Is there an online instance of standalone VE where one could try this out ? (E.g. https://wikimedia.github.io/... [14:43:46] 10VisualEditor, 10VisualEditor-CopyPaste: Support preserving links in pasted HTML content - https://phabricator.wikimedia.org/T129546#2108764 (10Jdforrester-WMF) >>! In T129546#2117965, @Tbayer wrote: > @Esanders Re workaround, thanks for the hint. Is there an online instance of standalone VE where one could... [14:49:11] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277183 (owner: 10Jforrester) [14:58:43] 10Citoid, 10VisualEditor: Tests with 3 sources covered in Zotero - https://phabricator.wikimedia.org/T129858#2118146 (10Elitre) [14:59:09] 10VisualEditor: VisualEditor does not respect trailing chars - https://phabricator.wikimedia.org/T129778#2118159 (10Jdforrester-WMF) 5Open>3stalled >>! In T129778#2116318, @jeblad wrote: > I tend to think that T50463 is close to a show stopper for us. Then you should comment on that task, and not talk on ta... [15:00:01] James_F, you want https://gerrit.wikimedia.org/r/#/c/277183/ in swat? [15:00:14] Krenair: Yeah, if it passes. [15:00:18] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox, 13Patch-For-Review, and 3 others: [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents - https://phabricator.wikimedia.org/T128282#2118174 (10Trizek-WMF) [15:00:26] Oh, damn, off by an hour. [15:00:28] Whoops. [15:01:23] 10Cite, 13Patch-For-Review: Allow to preview list-defined references in the section where they are defined - https://phabricator.wikimedia.org/T128036#2118188 (10Cenarium) {F3631479} Screenshot of preview [15:02:55] Krenair: Can you merge https://gerrit.wikimedia.org/r/#/c/277180/ so we can have it working in master before the cut too? :-) [15:05:14] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277183 (owner: 10Jforrester) [15:05:22] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (c1e1bd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277180 (owner: 10Jforrester) [15:05:57] 10VisualEditor, 10VisualEditor-EditingTools: Report that Control-M didn't work for one user ?in Norwegian? (unknown browser/OS/reproduction steps) - https://phabricator.wikimedia.org/T129865#2118246 (10Jdforrester-WMF) [15:14:54] (03Merged) 10jenkins-bot: Update VE core submodule to wmf/1.27.0-wmf.16 HEAD (5019e21) [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277183 (owner: 10Jforrester) [15:15:01] Ta. [15:21:24] (03Merged) 10jenkins-bot: Update VE core submodule to master (c1e1bd7) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277180 (owner: 10Jforrester) [15:21:30] (03CR) 10Jforrester: [C: 032] FocusableNode: Protect against calculateHighlights being called on null surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277226 (https://phabricator.wikimedia.org/T129549) (owner: 10Esanders) [15:22:00] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2016-03-15_(1.27.0-wmf.17): [Regression pre-wmf.17] Adding a citation note right after another one is throwing an error "TypeError: this.focusableSurface is null" upon save - https://phabricator.wikimedia.org/T129549#2118435 (10Jdforrester-WMF) 5Op... [15:23:13] (03CR) 10Jforrester: [C: 032] Sanitize the paste context in the same way as the paste data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277232 (https://phabricator.wikimedia.org/T129310) (owner: 10Esanders) [15:23:31] 10VisualEditor, 10VisualEditor-CopyPaste, 5WMF-deploy-2016-03-15_(1.27.0-wmf.17): Plain paste (Ctrl+Shift+V) of external content into a non-paragraph node breaks, shows ☂ and/or ☀ - https://phabricator.wikimedia.org/T129310#2118440 (10Jdforrester-WMF) 5Open>3Resolved [15:29:20] 10VisualEditor: Image display as Template Parameter is broken - https://phabricator.wikimedia.org/T129877#2118466 (10mkoitka) [15:37:08] (03Merged) 10jenkins-bot: FocusableNode: Protect against calculateHighlights being called on null surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277226 (https://phabricator.wikimedia.org/T129549) (owner: 10Esanders) [15:37:10] (03Merged) 10jenkins-bot: Sanitize the paste context in the same way as the paste data [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277232 (https://phabricator.wikimedia.org/T129310) (owner: 10Esanders) [15:42:56] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: "Unresponsive script" warning after copying and pasting content several times in tables - https://phabricator.wikimedia.org/T129879#2118570 (10Elitre) [15:50:16] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: "Unresponsive script" warning after copying and pasting content several times in tables - https://phabricator.wikimedia.org/T129879#2118570 (10Esanders) Hmm, I think maybe the internalList isn't merging properly and is therefore doubling in siz... [16:07:14] 10VisualEditor, 10VisualEditor-Tables, 7Browser-Support-Firefox, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16), and 2 others: [Regression FF43] In Firefox, double click on a cell makes the page jump down and doesn't allow to change cell contents - https://phabricator.wikimedia.org/T128282#2118662 (10Jdforrester-WM... [16:09:44] 10Cite, 10MediaWiki-API, 10MobileFrontend: What is impact of storing references - https://phabricator.wikimedia.org/T126802#2118684 (10Jdlrobson) [16:11:08] 10VisualEditor, 10VisualEditor-MediaWiki: Can't switch from the visual editor to the wikitext editor unless I make a change first - https://phabricator.wikimedia.org/T129724#2118687 (10AlexMonk-WMF) # Set tab pref to prefer-ve # Open VE, make a change and save # Open VE again (by pressing 'Edit') # Click [[ ]]... [16:22:31] 10VisualEditor: "plain" rich text is not run through the wikitext converter - https://phabricator.wikimedia.org/T129882#2118765 (10Esanders) [16:27:01] 10VisualEditor: "plain" rich text is not run through the wikitext converter - https://phabricator.wikimedia.org/T129882#2118815 (10Esanders) I guess one heuristic would be a single content node containing no annotations, e.g.

Foo

or
  • Bar
    • [16:38:38] RoanKattouw, https://phabricator.wikimedia.org/T129879 [16:43:46] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-j: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2118890 (10Jdlrobson) [16:50:08] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#2118922 (10Jdforrester-WMF) This is really bad, and it's made worse because it's not clear what we can do to help. :-( The only thing... [16:55:00] (03PS2) 10Jforrester: AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277241 (https://phabricator.wikimedia.org/T127643) (owner: 10Esanders) [16:55:17] (03CR) 10Jforrester: [C: 032] AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277241 (https://phabricator.wikimedia.org/T127643) (owner: 10Esanders) [16:58:03] (03PS1) 10Jforrester: AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277283 (https://phabricator.wikimedia.org/T127643) [17:07:00] edsanders: Does https://phabricator.wikimedia.org/T129776#2118629 affect master? Or wmf.17 [17:21:22] (03PS2) 10Krinkle: CitoidDataModule: Fetch JSON config in content language [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/277064 (owner: 10Jforrester) [17:21:28] (03CR) 10Krinkle: [C: 032] CitoidDataModule: Fetch JSON config in content language [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/277064 (owner: 10Jforrester) [17:21:49] Krinkle: Master, hence "pre-wmf.17". [17:36:44] James_F: I can't reproduce anything like that. [17:37:24] Krinkle: Switch your wiki into debug mode. [17:37:45] I did that [17:37:49] works fine [17:37:53] Didn't here. [17:37:59] Did you git-pull core in the last three days? [17:38:00] git bisect blamed that commit. [17:38:02] Yes. [17:39:26] (03PS1) 10Esanders: Remove unnecessary internalList clone call. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277288 [17:40:26] James_F: What error do you get? Steps to reproduce? [17:41:12] Krinkle: Load a page. Open a console. Do `mw.loader.load( 'oojs' );`. [17:41:19] Krinkle: Then find that `OO` is not defined. [17:41:40] (Read mode, Main Page or wherever.) [17:41:58] Also all things that use OOjs like VE/OOUI infusion/etc. obviously then fail. [17:44:56] or just try and open Echo [17:45:15] * James_F nods. [17:46:28] James_F: K, got it. I see what's going on now. [17:46:31] Commits got split up badly [17:46:35] fixing immediately [17:46:38] Thank you. :-) [17:49:25] (03Merged) 10jenkins-bot: CitoidDataModule: Fetch JSON config in content language [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/277064 (owner: 10Jforrester) [17:49:46] 10VisualEditor, 6Research-and-Data: Add support for hashtags (URL parameter -> edit summary) - https://phabricator.wikimedia.org/T123529#2119249 (10DarTar) To expand on @Jdforrester-WMF's question: there is no design / UX need for this that I am aware of, the task description still has the most accurate scope... [17:50:07] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: "Unresponsive script" warning after copying and pasting content several times in tables - https://phabricator.wikimedia.org/T129879#2119264 (10Esanders) That is the problem. I think it is because newFromDocumentInsertion doesn't consolidate dup... [17:57:44] RoanKattouw: Your thoughts on https://phabricator.wikimedia.org/T129879 and the wonderfulness that is newFromDocumentInsertion appreciated. :-) [18:08:47] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-Tables, 7Performance: "Unresponsive script" warning after copying and pasting content several times in tables - https://phabricator.wikimedia.org/T129879#2119353 (10Jdforrester-WMF) p:5Triage>3High a:3Esanders [18:16:32] (03PS2) 10Jforrester: dm.Document#shallowCloneFrom*: Remove unnecessary internalList.clone()s [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277288 (owner: 10Esanders) [18:16:40] (03CR) 10Jforrester: [C: 032] dm.Document#shallowCloneFrom*: Remove unnecessary internalList.clone()s [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277288 (owner: 10Esanders) [18:17:34] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277283 (https://phabricator.wikimedia.org/T127643) (owner: 10Jforrester) [18:22:56] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility: In template insert dialog, tab focus goes through a bunch of invisible buttons before reaching the "Insert" action - https://phabricator.wikimedia.org/T129791#2116441 (10AlexMonk-WMF) We use tabindex=0 to force elements to be included while tabbing -... [18:24:50] (03Merged) 10jenkins-bot: dm.Document#shallowCloneFrom*: Remove unnecessary internalList.clone()s [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277288 (owner: 10Esanders) [18:27:32] 10VisualEditor, 10VisualEditor-MediaWiki, 7Accessibility: In template insert dialog, tab focus goes through a bunch of invisible buttons before reaching the "Insert" action - https://phabricator.wikimedia.org/T129791#2119496 (10matmarex) They are not proper invisible, though. They're just offscreen. This nee... [18:44:26] (03CR) 10Jforrester: [C: 032] AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277283 (https://phabricator.wikimedia.org/T127643) (owner: 10Jforrester) [18:45:47] (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277241 (https://phabricator.wikimedia.org/T127643) (owner: 10Esanders) [19:00:57] (03Merged) 10jenkins-bot: AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/277283 (https://phabricator.wikimedia.org/T127643) (owner: 10Jforrester) [19:01:00] (03Merged) 10jenkins-bot: AceEditorWidget: Use namespaced 'require' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277241 (https://phabricator.wikimedia.org/T127643) (owner: 10Esanders) [19:05:56] (03PS1) 10Esanders: Table import: Only import the internal list on external paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277318 (https://phabricator.wikimedia.org/T129879) [19:12:05] RoanKattouw: Now in the form of code review on https://gerrit.wikimedia.org/r/#/c/277318/ please. :-) [19:23:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable single edit tab on plwiki and review - https://phabricator.wikimedia.org/T128477#2119766 (10Elitre) It looks like we have a green light for this. I had requested [[ https://pl.wikipedia.org/wiki/Dyskusja_wikiped... [19:23:38] 10VisualEditor, 10VisualEditor-MediaWiki, 6Community-Liaisons, 3Liaisons-March-2016: Publish messages about SET on pl.wiki, monitor for reactions and feedback - https://phabricator.wikimedia.org/T128499#2119767 (10Elitre) It looks like we have a green light for this. I had requested [[ https://pl.wikipedia... [20:04:38] (03PS3) 10Esanders: CommandHelpDialog: Inherit non-corruptively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 [20:18:06] (03CR) 10Jforrester: [C: 032] CommandHelpDialog: Inherit non-corruptively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 (owner: 10Esanders) [20:28:58] (03Merged) 10jenkins-bot: CommandHelpDialog: Inherit non-corruptively [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276729 (owner: 10Esanders) [20:58:34] (03PS13) 10Esanders: Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [21:01:29] (03CR) 10Esanders: [C: 04-1] ""Also as the whole redirect is clickable it should be styled as such: cursor:pointer and possibly a hover style (but disabled the link hov" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [21:05:49] edsanders, around? I'm about to head for a vacation, wanted to sync up with you [21:05:59] yes [21:06:14] edsanders, hangout for a few min? [21:06:29] can't, but can talk here [21:07:02] edsanders, #wikipedia-interactive [21:26:40] 10VisualEditor, 10Math: In math inspector, when height is limited the editing section (with active cursor) is not visible - https://phabricator.wikimedia.org/T121150#2120250 (10Tchanders) a:3Tchanders [21:29:25] (03CR) 10Alex Monk: "PS14: Disabled the link hover underline style." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) (owner: 10Alex Monk) [21:29:27] (03PS14) 10Alex Monk: Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) [21:43:52] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-"Java and JavaScript are basically the same": Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2120284 (10Jdlrobson) @jayvdb the mobile prefix is needed if we put this in the Mobi... [21:44:22] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-"Java and JavaScript are basically the same": Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2120286 (10Jdlrobson) As part of the writing of unit tests I needed to setup some sc... [21:45:01] 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-"Java and JavaScript are basically the same": Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2120291 (10Jdlrobson) [21:51:15] 10VisualEditor: VisualEditor: keyboard-based remove actions (such as removing links) should not require text to be selected. - https://phabricator.wikimedia.org/T129931#2120323 (10Tgr) [21:51:50] 10VisualEditor, 10VisualEditor-EditingTools: Report that Control-M didn't work for one user ?in Norwegian? (unknown browser/OS/reproduction steps) - https://phabricator.wikimedia.org/T129865#2118246 (10Tgr) Maybe the way it needs to be used is just not sufficiently intuitive? See T129931. [21:52:50] 10Cite: Reference spanning two lines - https://phabricator.wikimedia.org/T129932#2120344 (10Esanders) [21:56:21] 10VisualEditor, 7Accessibility: VisualEditor: show keyboard bindings in tooltips - https://phabricator.wikimedia.org/T129933#2120365 (10Tgr) [21:56:25] 10VisualEditor: VisualEditor: keyboard-based remove actions (such as removing links) should not require text to be selected. - https://phabricator.wikimedia.org/T129931#2120323 (10Jdforrester-WMF) What's your proposed alternative? If the document is (real-world examples like this exist quite often, especially on... [22:11:27] 10VisualEditor: VisualEditor: keyboard-based remove actions (such as removing links) should not require text to be selected. - https://phabricator.wikimedia.org/T129931#2120323 (10matmarex) For the particular case of link inspector, you can do Ctrl+K with the cursor anywhere within the link, then Delete and Ente... [22:43:07] mostly asking here since you probably know the most about OOui. What is the appropriate way to know from unrelated code that something was infused? Specifically there is WikimediaEvents code that initializes a test when the user starts typing into a search box. That's using $('...').one(...), but because of how infuse works the element it attaches the event to gets removed from the dom [22:51:30] ebernhardson: it doesn't get removed. or shouldn't. it gets removed, then re-attached. it should be the same element. [22:52:00] ebernhardson: the solution is, if you know that some DOM node is part of an OOjs UI element, to use OO.ui.infuse() yourself to get a reference to it. [22:53:34] MatmaRex: i can confirm it's being removed, or at least holding a reference to the element in my js console the element post-infuse is no longer the same element according to the console [22:53:39] (i might be oversimplifying or misunderstanding, if that's not making sense, please point me to the code you have that doesn't work :) ) [22:53:51] i'll not on the patch that it shuldn't be removed [22:54:49] the patch is https://gerrit.wikimedia.org/r/#/c/252718 [22:55:53] ebernhardson: unless it's some fancy widget that i didn't write ;), that should not be happening. i specifically implemented this DOM node reusing stuff, so that the browser can do autocompletion, or restore input if the page is accidentally closed or navigated away. [22:56:13] ebernhardson: okay, i'll look into what SearchInputWidget does to break this [22:57:46] (brb meeting) [22:59:17] 10VisualEditor: VisualEditor: some keyboard shortcuts are unreachable on some keyboards - https://phabricator.wikimedia.org/T129945#2120620 (10Tgr) [23:07:19] 10VisualEditor: VisualEditor: keyboard-based remove actions (such as removing links) should not require text to be selected. - https://phabricator.wikimedia.org/T129931#2120666 (10Tgr) >>! In T129931#2120377, @Jdforrester-WMF wrote: > What's your proposed alternative? If the document is (real-world examples like... [23:16:10] James_F|Away, edsanders|away: Ugh, right (re internallist) [23:16:37] Problem is it's hard to tell whether internal items are actually the same. Subdocuments probably helps there [23:16:41] Patch looks good to me [23:33:31] 10VisualEditor: Visual Editor's edit summary field doesn't remember my history - https://phabricator.wikimedia.org/T129951#2120806 (10greg) [23:35:10] that feels like a dupe somehow [23:35:25] (03CR) 10Catrope: [C: 04-1] Table import: Only import the internal list on external paste (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277318 (https://phabricator.wikimedia.org/T129879) (owner: 10Esanders) [23:35:38] ugh, hidden columns [23:35:46] 10VisualEditor: Visual Editor's edit summary field doesn't remember my history - https://phabricator.wikimedia.org/T129951#2120823 (10matmarex) [23:35:48] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've used - https://phabricator.wikimedia.org/T50274#2120824 (10matmarex) [23:36:02] Krenair: indeed [23:36:45] hey I was going to merge that [23:39:08] 10VisualEditor, 6Design-Research-Backlog: VE image updating: test two concepts side by side - https://phabricator.wikimedia.org/T96979#2120846 (10ggellerman) [23:39:15] heh [23:39:19] thanks :) [23:40:36] ( 10 && null ) || ( 0 && 30 ) [23:40:52] What values is returned :D ? [23:41:01] value* (in JS) [23:42:54] Surely it would be false. [23:42:55] But no. [23:48:21] 0? [23:48:35] i love language trivia! [23:49:47] 10VisualEditor, 6Design-Research, 10MediaWiki-General-or-Unknown, 10Reading-Community-Engagement, 5Design Research and product team collaboration: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#2120883 (10ggellerman) [23:53:53] 10VisualEditor, 6Design-Research-Backlog, 10MediaWiki-General-or-Unknown, 10Reading-Community-Engagement, 5Design Research and product team collaboration: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#2120895 (10ggellerman)