[00:06:38] 10VisualEditor, 10VisualEditor-Initialisation, 10VisualEditor-Performance, 6Collaboration-Team-Backlog, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2125038 (10ssastry) As far as HTML representation of template args is concerned, one issue we were talking about w... [01:28:41] 10VisualEditor, 10Kartographer: Warning: Kartographer VE modules require messages that don't exist (visualeditor-mwmapsdialog*) - https://phabricator.wikimedia.org/T130088#2125164 (10Krinkle) [01:28:51] 10VisualEditor, 10Kartographer, 7Technical-Debt: Warning: Kartographer VE modules require messages that don't exist (visualeditor-mwmapsdialog*) - https://phabricator.wikimedia.org/T130088#2125164 (10Krinkle) [08:28:07] we re looking for voluntary devs to help us on idea creation tools - join us on #libreidea [08:45:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor (and/or Parsoid?) assumes files' first character is capitalised, not respecting $wgCapitalLinks or whatever - https://phabricator.wikimedia.org/T129877#2125482 (10mkoitka) Yep, but I also wasn't aware of $wgCapitalLinks af... [10:04:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor (and/or Parsoid?) assumes files' first character is capitalised, not respecting $wgCapitalLinks or whatever - https://phabricator.wikimedia.org/T129877#2125636 (10Jdforrester-WMF) >>! In T129877#2125482, @mkoitka wrote: >... [10:48:47] (03CR) 10Jforrester: [C: 032] Trigger plain text transfer handler if HTML paste was unformatted [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277550 (https://phabricator.wikimedia.org/T129882) (owner: 10Esanders) [10:49:28] 10VisualEditor, 10VisualEditor-CopyPaste, 5WMF-deploy-2016-03-29_(1.27.0-wmf.18): "plain" rich text is not run through the wikitext converter - https://phabricator.wikimedia.org/T129882#2125728 (10Jdforrester-WMF) 5Open>3Resolved [10:52:37] (03Merged) 10jenkins-bot: Trigger plain text transfer handler if HTML paste was unformatted [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277550 (https://phabricator.wikimedia.org/T129882) (owner: 10Esanders) [11:04:47] (03CR) 10Jforrester: [C: 032] Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277669 (owner: 10L10n-bot) [11:16:35] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277669 (owner: 10L10n-bot) [11:22:40] 10VisualEditor, 10Wikimedia-Site-Requests: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2125793 (10Jdforrester-WMF) [11:22:53] 10VisualEditor, 6Community-Liaisons, 3Liaisons-March-2016: Follow and facilitate community work around enabling the visual editor for newbies and IPs at de.wiki - https://phabricator.wikimedia.org/T128630#2125798 (10Jdforrester-WMF) [11:22:55] 10VisualEditor, 10Wikimedia-Site-Requests: Enable VisualEditor for logged-out and newly registered users on German Wikipedia - https://phabricator.wikimedia.org/T127881#2057383 (10Jdforrester-WMF) 5Open>3Resolved Happy birthday, `dewiki`. [12:02:28] [13grunt-banana-checker] 15jdforrester pushed 2 new commits to 06master: 02https://github.com/wikimedia/grunt-banana-checker/compare/84922134a2ac...936c7fd292de [12:02:28] 13grunt-banana-checker/06master 149de6fab 15paladox: Update grunt-contrib-jshint to 1.0.0 [12:02:28] 13grunt-banana-checker/06master 14936c7fd 15James Forrester: Merge pull request #47 from paladox/patch-6... [12:04:07] [13grunt-banana-checker] 15paladox opened pull request #48: Update grunt-jscs to 2.8.0 (06master...06patch-7) 02https://github.com/wikimedia/grunt-banana-checker/pull/48 [12:04:43] [13grunt-banana-checker] 15paladox closed pull request #45: Update grunt-jscs to 2.8.0 (06master...06patch-3) 02https://github.com/wikimedia/grunt-banana-checker/pull/45 [12:06:34] [13grunt-banana-checker] 15jdforrester closed pull request #48: build: Update grunt-jscs to 2.8.0 (06master...06patch-7) 02https://github.com/wikimedia/grunt-banana-checker/pull/48 [12:31:07] (03CR) 10Hashar: "check experimental" [unicodejs] - 10https://gerrit.wikimedia.org/r/276213 (owner: 10Paladox) [13:27:14] (03PS1) 10Esanders: ElementLinearData: Include all non-content nodes is isPlainText loose mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277765 [13:30:20] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Wikitext conversion not working in Chrome/Windows when the source uses definition list formatting - https://phabricator.wikimedia.org/T129629#2126025 (10Esanders) The browser decides when you copy whether it's plain text or HTML. Firefox app... [13:31:26] (03CR) 10Jforrester: "Is this meant to be tagged with T129629?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277765 (owner: 10Esanders) [16:20:33] 10VisualEditor, 10VisualEditor-EditingTools: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126452 (10Jdforrester-WMF) [16:24:56] 10VisualEditor, 10VisualEditor-EditingTools: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126470 (10Jdforrester-WMF) [16:32:09] 10VisualEditor, 10VisualEditor-EditingTools: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126452 (10Esanders) I don't agree that items in the menu have to be in the accusative. 'Insert' is really ju... [16:33:50] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126519 (10Nemo_bis) [16:35:51] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2126525 (10Esanders) Paste the rich text into the **right hand side** of the github sandbox, then paste the raw HTML it generates here (i.e. the text in the left hand box). [16:38:39] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2126528 (10Esanders) LO5 + Ubuntu + Chrome/Firefox: {F3644194} [16:38:56] 10VisualEditor: Allow drag and drop of a word processing document on VE - https://phabricator.wikimedia.org/T129646#2126529 (10Esanders) p:5Triage>3Lowest [16:45:30] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126452 (10Nemo_bis) > I don't agree that items in the menu have to be in the accusative. 'Insert' i... [16:51:12] James_F: Regarding speeding up oojs-ui build, if these build steps leveraged a cache of sorts (e.g. local .tmp directory that is git ignored) it could use that for things that haven't changed [16:51:27] or some other way of verifying things [16:51:43] Krinkle: How would it know? [16:51:59] Krinkle: Hash the /src directory and call it .tmp-? [16:52:00] Not for all of 'grunt-build' but for individual steps [16:53:52] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126452 (10matmarex) Using accusative case here in Polish would technically be more correct, but I'v... [16:54:22] James_F: oojs-ui gate build: 20 minutes and counting [16:54:33] mediawiki-core gate build: 7 minutes and ready, blocked on --jsui [16:55:34] Krinkle: jsui? [16:55:38] oojsui [16:55:55] Oh, right. [16:57:46] Krinkle: (The 'correct' channel to talk about OOUI is -editing, BTW; MatmaRex etc. are here but likely aren't watching.) [16:58:55] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126654 (10matmarex) To elaborate. For the following English menu: - Insert - Gallery - Table... [17:04:02] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126661 (10Jdforrester-WMF) So you would use "$1" or maybe "…{{GRAMMAR:accusative|$1}}" if you felt... [17:07:20] Krenair: Cool. :-) [17:07:32] ugh [17:07:40] Everything was fine until I opened hangouts [17:15:44] * legoktm mehs at ?venotify=created [17:16:49] yeah :/ [17:17:11] it's not ideal [17:39:47] 10VisualEditor: Edits don't save in Visual editor at wikimaniawiki - https://phabricator.wikimedia.org/T130136#2126829 (10Effeietsanders) [17:55:26] (03PS1) 10Esanders: Ensure all test documents have an internal list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277820 [18:04:53] (03CR) 10Jforrester: [C: 032] Ensure all test documents have an internal list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277820 (owner: 10Esanders) [18:08:56] (03Merged) 10jenkins-bot: Ensure all test documents have an internal list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277820 (owner: 10Esanders) [18:19:05] 10VisualEditor, 10OOjs-UI: Some svg icons doint work in Microsoft Edge - https://phabricator.wikimedia.org/T130139#2126977 (10Paladox) [18:23:30] 10VisualEditor, 10OOjs-UI: Some svg icons doint work in Microsoft Edge - https://phabricator.wikimedia.org/T130139#2126977 (10Jdforrester-WMF) CanIUse claims Edge supports SVGs as background images – http://caniuse.com/#feat=svg-css – and it's be quite surprising to me that this isn't the case. [18:24:45] (03PS1) 10Esanders: Transactions: Ignore internalList changes in getModifiedRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277828 (https://phabricator.wikimedia.org/T129539) [18:25:08] 10VisualEditor, 10OOjs-UI, 7Browser-Support-Microsoft-Edge: One SVG icon doesn't appear to work in Microsoft Edge, and falls back to the PNG - https://phabricator.wikimedia.org/T130139#2127019 (10Jdforrester-WMF) [18:25:14] 10VisualEditor, 10OOjs-UI, 7Browser-Support-Microsoft-Edge: One SVG icon doesn't appear to work in Microsoft Edge, and falls back to the PNG - https://phabricator.wikimedia.org/T130139#2127021 (10Paladox) It does. Probaly a bug but seems strange to only affect one icon and the others work. [18:25:27] lol I love it when a bug I file against VE is my fault from two years ago [18:25:43] 10VisualEditor, 10OOjs-UI, 7Browser-Support-Microsoft-Edge: One SVG icon doesn't appear to work in Microsoft Edge, and falls back to the PNG - https://phabricator.wikimedia.org/T130139#2127022 (10Paladox) It seems to work now. [18:26:20] 10VisualEditor, 10VisualEditor-CopyPaste, 13Patch-For-Review: VE scrolls down to the bottom after converting pasted wikitext - https://phabricator.wikimedia.org/T129539#2108640 (10Esanders) This will happen on any (long) document with internal list content (i.e. a reference). [18:26:37] RoanKattouw, about that [18:26:43] RoanKattouw: :-) [18:26:50] 10VisualEditor, 10OOjs-UI, 7Browser-Support-Microsoft-Edge: One SVG icon doesn't appear to work in Microsoft Edge, and falls back to the PNG - https://phabricator.wikimedia.org/T130139#2127025 (10Paladox) 5Open>3Invalid [18:26:59] 10VisualEditor, 10OOjs-UI, 7Browser-Support-Microsoft-Edge: One SVG icon doesn't appear to work in Microsoft Edge, and falls back to the PNG - https://phabricator.wikimedia.org/T130139#2126977 (10Paladox) It seems to work now. [18:27:06] RoanKattouw, I fixed getModifiedRange to ignore the internalList [18:27:17] (03CR) 10Catrope: [C: 032] Transactions: Ignore internalList changes in getModifiedRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277828 (https://phabricator.wikimedia.org/T129539) (owner: 10Esanders) [18:27:19] edsanders: Seems sensible. [18:27:21] Ha. [18:27:24] I know, hence my comment [18:27:30] Apparently RoanKattouw agrees. [18:27:36] but that's really patching the symptom [18:27:46] in that case the inserted document had no internal list content [18:27:54] I would've +2ed it faster but I had to look but the break label; syntax to ensure it was used correctly [18:28:04] yet the generated transaction removes and re-inserts the entire list contents [18:28:08] Right [18:28:20] Yeah newFromDocumentInsertion doesn't care too much about generating a minimal transaction [18:28:36] I suspect on Barack Obama you're going to have a bad time? [18:28:38] * RoanKattouw mumbles something about internal lists and death and subdocuments [18:28:56] Ugh, yeah that'd be a performance issue [18:29:02] RoanKattouw: And failures to actually write code? ;-) [18:29:47] of course you can paste a reference so we can't bypass NFDI [18:30:18] I guess the easiest optimization is to have NFDI act more intelligently when the IL of the pasted document is empty [18:30:26] but that's still symptom fighting [18:30:39] * edsanders pastes wikitext on to Barack Obama [18:30:43] You could have to do an actual IL merge on Barack Obama and that would still suck [18:31:24] 800ms [18:36:12] edsanders: Can I grab a +2 on https://gerrit.wikimedia.org/r/#/c/277833/ [18:37:38] we're doing the colour change? [18:38:57] edsanders: Yes? [18:40:12] I think there's a fundamental problem with that change [18:40:30] they've tested blue vs red on all they're colour charts and vision simulators [18:40:46] but not blue vs red vs black [18:40:54] I'm not the person to convince, though, Volker is. [18:40:58] (* their) [18:41:24] we all take responsibility [18:41:39] I strongly prefer the toned-down colours, but I'm not the one in charge of the look and feel. [18:42:27] Apex is still better, though. [18:44:47] edsanders: hmm. i don't think there's a problem with that, though [18:44:54] actually, i'm not entirely sure what you mean [18:45:04] I'll post a picture on the bug [18:45:49] MatmaRex: I've posted a comparative screenshot. [18:46:30] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt: newFromDocumentInsertion transactions always replace the entire internal list - https://phabricator.wikimedia.org/T130142#2127086 (10Esanders) [18:46:55] 10VisualEditor, 10VisualEditor-DataModel, 7Performance, 7Technical-Debt: newFromDocumentInsertion transactions always replace the entire internal list - https://phabricator.wikimedia.org/T130142#2127100 (10Jdforrester-WMF) [18:47:00] 10VisualEditor, 10VisualEditor-DataModel, 7Performance, 7Technical-Debt: newFromDocumentInsertion transactions always replace the entire internal list - https://phabricator.wikimedia.org/T130142#2127086 (10Jdforrester-WMF) p:5Triage>3Normal [18:47:04] yes - that [18:47:17] hmm. [18:47:25] edsanders: The point is to down-play the hinting, though? [18:47:58] um - then why go to such great lengths to ensure it is "Accessibility compliant" [18:48:04] either you're supposed to see it or not [18:48:05] For the primary buttons? [18:51:23] maybe an experience which is less good regardless of how good your eyesight is, is less discriminatory? [18:56:35] (03Merged) 10jenkins-bot: Transactions: Ignore internalList changes in getModifiedRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277828 (https://phabricator.wikimedia.org/T129539) (owner: 10Esanders) [18:58:05] edsanders: Perhaps. [18:59:31] is there any reason this needs to go in 0.16.3? [19:02:31] (how about we always use black text for accessibility, and use light colours to hint at intention... https://doc.wikimedia.org/oojs-ui/master/demos/#widgets-apex-ltr ) [19:05:41] edsanders: but omg, the black:white contrast, eyesss burrnnnnn (allegedly) ;) [19:06:01] edsanders: i think you'd have to rebut https://www.mediawiki.org/wiki/Typography_refresh#Why_did_we_change_the_body_text_color.3F [19:06:14] black/333 whatever [19:06:25] but maybe we could make it darker than #555. [19:22:26] (03PS1) 10Jforrester: Update OOjs UI to v0.16.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277851 [19:23:45] 10VisualEditor, 7Design: Improve citation / Citoid workflow in VisualEditor - https://phabricator.wikimedia.org/T130148#2127245 (10wctaiwan) [19:54:44] edsanders: https://gerrit.wikimedia.org/r/#/c/277851/ too? :-) [20:52:18] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.16.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277851 (owner: 10Jforrester) [20:53:25] (03PS1) 10Jforrester: build: Bump devDependencies to latest [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277868 [20:54:55] James_F, category edit notices: I'd like Cenarium to clarify why that patch has been created the way it has, then I'll test and probably approve [20:55:04] * James_F nods. Sounds good. [20:55:14] Thank you. :-) [20:55:28] (03Merged) 10jenkins-bot: Update OOjs UI to v0.16.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/277851 (owner: 10Jforrester) [21:16:10] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2127550 (10Esanders) >>! In T130121#2126551, @Nemo_bis wrote: > In English, you mean? This is about... [21:22:00] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2127558 (10Esanders) >>! In T130121#2126654, @matmarex wrote: > The following would also be acceptab... [21:22:58] 10VisualEditor, 10VisualEditor-EditingTools, 7I18n: All inspector titles should be passed through GRAMMAR to allow languages that need to vary case based on context - https://phabricator.wikimedia.org/T130121#2126452 (10Catrope) Note that in some languages, you can't do the "Insert... ...table" thing at all... [22:39:51] (03PS16) 10Alex Monk: Show redirect target inside target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/273391 (https://phabricator.wikimedia.org/T63861) [22:43:20] (03CR) 10Alex Monk: "Didn't we add the SET dialog to the wikitext editor too?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/276698 (https://phabricator.wikimedia.org/T129510) (owner: 10Alex Monk) [23:37:26] 10VisualEditor: Section edit lead to deleting the rest of the page - https://phabricator.wikimedia.org/T130165#2128022 (10greg) [23:56:28] (03PS1) 10Jforrester: Update VE core submodule to master (bae50ca) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/277926