[00:48:28] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-22_(1.27.0-wmf.18): VisualEditor: Show something other than a blank page when editing a redirect page - https://phabricator.wikimedia.org/T63861#2133122 (10Jdforrester-WMF) 5Open>3Resolved [04:40:31] [13grunt-banana-checker] 15catrope opened pull request #49: Don't crash when encountering file names that contain '.json' in the middle (06master...06anchor-regex) 02https://github.com/wikimedia/grunt-banana-checker/pull/49 [10:44:44] 10VisualEditor: Experiment with guideline markers in VisualEditor for mobile friendly content - https://phabricator.wikimedia.org/T130237#2130602 (10Esanders) Wouldn't you want to preview all the mobile CSS, not just the width change? [11:58:45] 10VisualEditor, 10Parsoid: Empty tag added at the start of the page, broke the infobox - https://phabricator.wikimedia.org/T130224#2130233 (10Esanders) Do we know what the user did. If they wrapped the whole lede in a heading it's not surprising everything got corrupted... [12:06:18] 10VisualEditor, 6Editing-Department, 10MediaWiki-Gallery, 6Multimedia: Make enwiki's Template:Gallery redundant by implementing all its features in wikitext - https://phabricator.wikimedia.org/T95531#2133705 (10Esanders) The problem is not edge cases (like {{Double image}}), but that we have a template set... [14:33:30] (03PS1) 10DLynch: LinkAnnotationInspector: add a button to edit the label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) [14:52:23] [13grunt-banana-checker] 15jdforrester pushed 2 new commits to 06master: 02https://github.com/wikimedia/grunt-banana-checker/compare/8ba7f9774be9...34d9660f6ec1 [14:52:23] 13grunt-banana-checker/06master 146658794 15Roan Kattouw: Don't crash when encountering file names that contain '.json' in the middle... [14:52:23] 13grunt-banana-checker/06master 1434d9660 15James Forrester: Merge pull request #49 from catrope/anchor-regex... [14:55:37] [13grunt-banana-checker] 15jdforrester opened pull request #50: Extract the regex for a JSON filename (06master...06jdforrester-patch-1) 02https://github.com/wikimedia/grunt-banana-checker/pull/50 [15:01:35] [13grunt-banana-checker] 15jdforrester created 06bump-dev-deps (+1 new commit): 02https://github.com/wikimedia/grunt-banana-checker/commit/ebe2cfd02a68 [15:01:35] 13grunt-banana-checker/06bump-dev-deps 14ebe2cfd 15James D. Forrester: package.json: grunt-contrib-watch 0.6.1 → 1.0.0 [15:01:47] [13grunt-banana-checker] 15jdforrester opened pull request #51: package.json: grunt-contrib-watch 0.6.1 → 1.0.0 (06jdforrester-patch-1...06bump-dev-deps) 02https://github.com/wikimedia/grunt-banana-checker/pull/51 [15:41:21] (03CR) 10Jforrester: "Hmm. On typing, this replaces the selection with an unannotated character for me (both Chrome and Firefox), whereas double-clicking to sel" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [16:01:44] (03CR) 10Stigmj: [C: 04-1] "This change won't fix anything, it just makes the button do nothing." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/271949 (https://phabricator.wikimedia.org/T40487) (owner: 10Haritha28) [16:30:10] 10VisualEditor, 10VisualEditor-DataModel, 7Technical-Debt: Fix ElementLinearData#sanitize conversions - https://phabricator.wikimedia.org/T130377#2134293 (10Esanders) [16:31:00] (03PS1) 10Esanders: ElementLinearData: Add test for sanitize conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278296 [16:36:01] (03PS2) 10DLynch: LinkAnnotationInspector: add a button to edit the label [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) [16:40:00] (03PS1) 10Esanders: ElementLinearData: Test blacklist unwrapping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278299 [16:40:09] It's a theme: half an hour of debugging and careful tracing and comparing of values all results in a single setTimeout being added. [16:40:29] Kemayo: :-) [16:43:29] (03PS1) 10Esanders: ve.dm.Model: Remove unused, untested method 'hasAttributes' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278302 [16:45:57] (03CR) 10Jforrester: "Yup, now works well. Still need to find a design for this (no buttons under the entrybox in MW, as it's an expandable search results list)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278284 (https://phabricator.wikimedia.org/T124305) (owner: 10DLynch) [17:01:34] (03PS1) 10Esanders: ce.Surface: Add tests for table strip delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278308 [17:08:42] (03CR) 10Jforrester: [C: 032] ce.Surface: Add tests for table strip delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278308 (owner: 10Esanders) [17:14:48] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/278302/ BTW. :-) [17:14:52] (03CR) 10Jforrester: [C: 032] ve.dm.Model: Remove unused, untested method 'hasAttributes' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278302 (owner: 10Esanders) [17:15:16] (03CR) 10Jforrester: [C: 032] ElementLinearData: Test blacklist unwrapping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278299 (owner: 10Esanders) [17:15:26] (03CR) 10Jforrester: [C: 032] ElementLinearData: Add test for sanitize conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278296 (owner: 10Esanders) [17:17:37] WTF.... [17:17:42] How long has that been around for [17:20:50] (03Merged) 10jenkins-bot: ElementLinearData: Add test for sanitize conversions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278296 (owner: 10Esanders) [17:20:52] (03Merged) 10jenkins-bot: ElementLinearData: Test blacklist unwrapping [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278299 (owner: 10Esanders) [17:20:54] (03Merged) 10jenkins-bot: ve.dm.Model: Remove unused, untested method 'hasAttributes' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278302 (owner: 10Esanders) [17:21:00] (03Merged) 10jenkins-bot: ce.Surface: Add tests for table strip delete [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278308 (owner: 10Esanders) [17:21:12] 10VisualEditor, 6Design-Research-Backlog, 10MediaWiki-General-or-Unknown, 10Reading-Community-Engagement, 5Design Research and product team collaboration: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#2134595 (10ggellerman) a:5aripstra>3Capt_Swing [17:21:38] 10VisualEditor, 6Design-Research, 10MediaWiki-General-or-Unknown, 10Reading-Community-Engagement, 5Design Research and product team collaboration: MediaWiki's feedback tool interface is confusing - https://phabricator.wikimedia.org/T100011#1303519 (10ggellerman) [17:28:31] (03PS1) 10Esanders: ce.Surface: Add larger table strip-delete test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278313 [17:38:12] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 6Design-Research-Backlog, 6Editing-Department, and 2 others: Showing the Back and Undo buttons in the same place in mobile might be confusing for users; suggest an alternative design - https://phabricator.wikimedia.org/T113638#2134658 (10aripstra) @Jdforrest... [17:48:37] 10VisualEditor, 6Design-Research-Backlog, 7Design, 5Design Research and product team collaboration: Emphasize VE's save button by animating the progress bar attached to the bottom of the toolbar - https://phabricator.wikimedia.org/T99274#2134686 (10aripstra) @Jdforrester-WMF is this going to be addressed a... [18:02:43] (03PS1) 10Esanders: ce.Surface: Test table navigation with enter/tab/shift-tab [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278323 [18:03:43] (03CR) 10Jforrester: [C: 032] ce.Surface: Add larger table strip-delete test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278313 (owner: 10Esanders) [18:05:33] 10VisualEditor, 7Technical-Debt: ve.ce.LinearArrowKeyDownHandler.js is largely untested - https://phabricator.wikimedia.org/T130389#2134748 (10Esanders) [18:06:44] (03CR) 10jenkins-bot: [V: 04-1] ce.Surface: Test table navigation with enter/tab/shift-tab [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278323 (owner: 10Esanders) [18:06:50] (03CR) 10Esanders: [C: 04-1] "more to come" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278323 (owner: 10Esanders) [18:10:32] (03PS2) 10Esanders: ce.Surface: Test table navigation with enter/escape/tab/shift-tab [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278323 [18:12:01] RoanKattouw: probably since forever [18:14:51] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/29903/ "Will be used in future commits to reduce duplication." ... 4 years and counting TrevorParscal [18:17:14] Haha [18:20:01] (03Merged) 10jenkins-bot: ce.Surface: Add larger table strip-delete test [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278313 (owner: 10Esanders) [18:25:50] (03PS1) 10Esanders: Remove TableCaptionCommand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278324 [18:54:07] I wonder if git grep can tell us if it has even been used [19:10:16] (03PS1) 10Esanders: PreviewElement: Check node is a GCN, and always return a boolean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278336 [19:18:16] (03CR) 10Jforrester: [C: 032] Remove TableCaptionCommand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278324 (owner: 10Esanders) [19:19:16] (03CR) 10Jforrester: [C: 032] ce.Surface: Test table navigation with enter/escape/tab/shift-tab [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278323 (owner: 10Esanders) [19:19:37] (03CR) 10Jforrester: [C: 032] PreviewElement: Check node is a GCN, and always return a boolean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278336 (owner: 10Esanders) [19:24:10] (03Merged) 10jenkins-bot: Remove TableCaptionCommand [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278324 (owner: 10Esanders) [19:25:28] (03Merged) 10jenkins-bot: ce.Surface: Test table navigation with enter/escape/tab/shift-tab [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278323 (owner: 10Esanders) [19:25:30] (03Merged) 10jenkins-bot: PreviewElement: Check node is a GCN, and always return a boolean [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/278336 (owner: 10Esanders) [19:26:14] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: (Actually) Add wikitext support for citoid for automatic reference insertion - https://phabricator.wikimedia.org/T130400#2135056 (10Elitre) [20:43:43] [13grunt-banana-checker] 15Krinkle 04deleted 06jdforrester-patch-1 at 1427bbb03: 02https://github.com/wikimedia/grunt-banana-checker/commit/27bbb03 [21:26:20] RoanKattouw: https://github.com/wikimedia/VisualEditor/blob/51f4b4be5471b30d0c750eef49185469d2f20759/modules/ve/ui/tools/dropdowns/ve.ui.FormatDropdownTool.js [21:26:22] used to be used for checking the state of the current heading - we use ve.dm.Node#matches now [21:54:08] hah 2013 [23:41:53] 10Cite: ref inside Wikilinks leave UNIQ - https://phabricator.wikimedia.org/T27417#291567 (10DavidEppstein) This is now also happening with markup inside wikilinks, on en.wiki. (I think that combination used to work, but it's possible that recent changes to math have exposed math processing to this bug.) [23:48:00] 10VisualEditor, 10VisualEditor-MediaWiki: SET: Provide the SET dialog on first-run to wikitext editor users too (if they aren't opted-out) - https://phabricator.wikimedia.org/T130214#2135861 (10AlexMonk-WMF) We already have this code... You just need to be logged into a wiki with SET enabled, not have VE autod... [23:56:05] 10VisualEditor, 10VisualEditor-MediaWiki: Can't switch from the visual editor to the wikitext editor unless I make a change first - https://phabricator.wikimedia.org/T129724#2135865 (10AlexMonk-WMF) I get WTE in step 5