[00:01:06] <Krenair>	 because it's really the metadata requirement that is most of the problem
[00:03:24] <Krenair>	 I'll start looking into implementation detail. what are the API differences we need to do then gwicke?
[00:04:22] <gwicke>	 Krenair: data-mw will be exposed basically the same way data-parsoid is exposed right now
[00:05:47] <gwicke>	 if you'd like to kick off both requests at once, then you could request both by title only
[00:06:01] <Krenair>	 by title only?
[00:06:31] <gwicke>	 IIRC you don't know the latest revision at that point, so you are requesting /html/{title}
[00:06:53] <gwicke>	 data-mw will basically work the same way
[00:07:35] <gwicke>	 to make sure that data-mw matches the html render, the etag headers should be compared
[00:09:29] <Krenair>	 We sometimes set an oldid as well
[00:09:45] <gwicke>	 in the rare case that they don't match, the data-mw request should be repeated using the revision and etag returned by the html response
[00:10:13] <gwicke>	 passing in the oldid is fine, just make sure to pass it in both html & data-mw requests
[00:10:40] * Krenair nods
[00:11:24] <Krenair>	 https://meta.wikimedia.org/api/rest_v1/?doc shows data-parsoid and html among other things
[00:11:25] <Krenair>	 but no data-mw?
[00:11:31] <gwicke>	 eventually, I hope that we can relax the requirement for tids to match
[00:11:40] <gwicke>	 that'll require stable ids in parsoid, though
[00:11:59] <gwicke>	 Krenair: yeah, data-mw is not available yet
[00:12:32] <gwicke>	 I'm actually not entirely sure what the timeline on the parsoid end is at this point
[00:13:24] <gwicke>	 they are working on it, but it's still at least weeks out
[00:15:55] <gwicke>	 Krenair: in any case, we will continue to support old-style requests for quite a while, as long as the expected content-type is specified in the `Accept` header
[00:16:23] <gwicke>	 so VE won't break even if the move to data-mw usage is a bit delayed
[00:16:58] <Krenair>	 okay, I think we should look into this after restbase supports it
[00:17:35] <gwicke>	 yeah, or at least when we are getting ready to deploy
[00:18:05] <Krenair>	 okay, when it's on restbase master? :p
[00:19:00] <James_F>	 Krenair: Talking to RoanKattouw we fundamentally rely on data-mw synchronously for every cite, every template, and a bit for images.
[00:19:16] <Krenair>	 yeah
[00:19:28] <Krenair>	 so we can't delay loading of it, it has to be one of the blockers for loading
[00:19:47] <gwicke>	 James_F: for *rendering*?
[00:19:52] <James_F>	 gwicke: Yes.
[00:19:58] <RoanKattouw>	 For *understanding the HTML*
[00:20:00] <gwicke>	 hm, strange
[00:20:17] <gwicke>	 which information from data-mw do you need for rendering?
[00:20:30] <James_F>	 For edits: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/25be46a57d6b875b64fb3455c93fa776d6d301ee/modules/ve-mw/dm/nodes/ve.dm.MWExtensionNode.js for every extension.
[00:21:24] <gwicke>	 that just stashes it away it seems?
[00:21:41] <James_F>	 For read: https://github.com/wikimedia/mediawiki-extensions-Cite/blob/07db923b86e9a97c7c05be8b22f67df96add1ad9/modules/ve-cite/ve.dm.MWReferenceNode.js for references (so we know which reference is a re-use), https://github.com/wikimedia/mediawiki-extensions-Cite/blob/07db923b86e9a97c7c05be8b22f67df96add1ad9/modules/ve-cite/ve.dm.MWReferencesListNode.js for
[00:21:41] <James_F>	 reference lists (so we know which group of references with which to populate it), and https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/25be46a57d6b875b64fb3455c93fa776d6d301ee/modules/ve-mw/dm/nodes/ve.dm.MWTransclusionNode.js for the name of the template (so we can match the cite templates).
[00:21:51] <James_F>	 Yeah, hence, 'for edits'.
[00:22:09] <James_F>	 The killer use-cases on reads are all related to Cite. Shock, surprise.
[00:23:06] <gwicke>	 when you say 'read', do you mean that this shows up in the initial VE render?
[00:23:22] <gwicke>	 or that the information is needed once the user clicks on a citation?
[00:24:05] <James_F>	 Initial VE render.
[00:25:06] * gwicke never noticed any such information
[00:25:22] <gwicke>	 James_F: is this triggering some icon, or something?
[00:26:18] <James_F>	 The ordering and numbering of the references. The contents of the reference lists.
[00:26:19] <James_F>	 Et.
[00:26:44] <gwicke>	 ah, it is because VE re-builds references from scratch, rather than using Parsoid's render?
[00:36:59] <RoanKattouw>	 Yes
[00:37:10] <RoanKattouw>	 And because Parsoid doesn't provide that information itself
[00:37:31] <RoanKattouw>	 At least not enough of it
[00:41:31] <gwicke>	 that certainly sounds like it would be harder to change
[00:55:16] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Single Edit Tab "four choices" dialog doesn't go away when you exit the visual editor - https://phabricator.wikimedia.org/T130552#2143249 (10AlexMonk-WMF) VE captures the escape key press when you have the document focused, the SET dialog captures it if you have the di...
[00:56:10] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Single Edit Tab "four choices" dialog doesn't go away when you exit the visual editor - https://phabricator.wikimedia.org/T130552#2143251 (10AlexMonk-WMF) (It seems that we try, it's just that the edit surface finishes loading *afterwards*, stealing focus again)
[01:09:16] <grrrit-wm>	 (03PS1) 10Alex Monk: Don't change focus to VE surface if we're opening the SET dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279081 (https://phabricator.wikimedia.org/T130552) 
[01:58:19] <grrrit-wm>	 (03CR) 10Alex Monk: "Anyone else have any thoughts?" [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) (owner: 10Alex Monk)
[02:04:06] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#2143333 (10AlexMonk-WMF) I attempted to apply @Krinkle's edits on metawiki (but they didn't seem to fix the issue, at least on the page that I tested) and enwikibooks (but my template edi...
[04:09:06] <Krinkle>	 Krenair: Looking at metawiki now
[04:09:27] <Krinkle>	 Using action=edit source mode, I see <div class="mw-editnotice mw-editnotice-namespace mw-editnotice-0"><div id="editnotice-area" class="editnotice-area" ..>
[04:09:27] <Krinkle>	 <div class="editnotice-link editnotice-redlink sysop-show accountcreator-show" s ..>
[04:10:43] <Krinkle>	 Looks like you successfully moved the logic to allow an empty notice to be empty
[04:11:06] <Krinkle>	 But forgot the part about making it actually empty (aside from the wrapper, which is fixed) - it's still outputting the redlink by default
[04:11:54] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#2143390 (10Krinkle)
[04:20:32] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Parsoid should treat '|-' syntax as row separator, not row start - https://phabricator.wikimedia.org/T130696#2143392 (10Krinkle)
[04:27:03] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#2143405 (10Krinkle) >>! In T103693#2143333, @AlexMonk-WMF wrote: > I attempted to apply @Krinkle's edits on metawiki (but they didn't seem to fix the issue [..]  Per <https://phabricator....
[09:46:50] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Parsoid should treat '|-' syntax as row separator, not row start - https://phabricator.wikimedia.org/T130696#2143392 (10Esanders) But they aren't separators because you attach attributes to them, e.g.  ``` {| |- | x || y |- style="background:red;" |}  ```...
[10:01:11] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-22_(1.27.0-wmf.18), 7user-notice: [Regression] Continuously getting an error about editing a old revision of the page with VE - https://phabricator.wikimedia.org/T125437#2143829 (10Trizek-WMF)
[10:31:27] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 6Collaboration-Team-Backlog, 10Flow, and 2 others: Don't strip links when pasting HTML into Flow VisualEditor - https://phabricator.wikimedia.org/T129833#2143865 (10Esanders) The bug has been renamed to be just about Flow. If that is going to stay the case we need...
[10:32:12] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 6Collaboration-Team-Backlog, 10Flow, and 2 others: Don't strip links when pasting HTML into Flow VisualEditor - https://phabricator.wikimedia.org/T129833#2143867 (10Esanders) >>! In T129833#2128350, @Etonkovidova wrote: > There are three small issues(they might be...
[10:53:38] <grrrit-wm>	 (03PS5) 10Esanders: Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 
[10:58:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 (owner: 10Esanders)
[11:04:32] <grrrit-wm>	 (03PS6) 10Esanders: Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 
[11:11:31] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Visual editor Template tool should not show deprecated parameter(s), unless already has value - https://phabricator.wikimedia.org/T130676#2143938 (10Aklapper)
[11:12:21] <grrrit-wm>	 (03PS1) 10Esanders: Rename startSave -> onSaveDialogSave [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279106 
[11:12:49] <grrrit-wm>	 (03PS18) 10Esanders: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) 
[11:14:16] <grrrit-wm>	 (03PS2) 10Esanders: Rename startSave -> onSaveDialogSave [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279106 
[11:14:18] <grrrit-wm>	 (03PS19) 10Esanders: [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) 
[11:21:43] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP/POC/POS] Wikitext surface [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) (owner: 10Esanders)
[14:17:17] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Parsoid should treat '|-' syntax as row separator, not row start - https://phabricator.wikimedia.org/T130696#2144352 (10ssastry) 5Open>3declined This is Tidy stripping empty cells in the core parser whereas Parsoid doesn't.  In a top-level page, if Par...
[14:27:57] <wikibugs>	 10Cite: ref inside Wikilinks leave UNIQ - https://phabricator.wikimedia.org/T27417#291567 (10HairyDude) This also affects nowiki tags: see [[https://en.m.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Strip_marker_problems_with_nowiki_tags|this thread on the Wikipedia village pump]].
[14:43:07] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 10RESTBase: VisualEditor should load data-mw from a separate API call alongside the body content - https://phabricator.wikimedia.org/T88623#1016326 (10ssastry) Note that we are at least 3-4 weeks away before both Parsoid and RESTBase are...
[15:21:40] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#2144514 (10AlexMonk-WMF) So the part that I missed out was the Template:Editnotice_load/core edit: https://meta.wikimedia.org/w/index.php?title=Template:Editnotice_load/core&diff=prev&old...
[15:23:18] <grrrit-wm>	 (03PS1) 10Esanders: Improve drop target preview for block node dragging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279125 
[15:24:41] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] "Does this fix any bugs the user would notice?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/270315 (https://phabricator.wikimedia.org/T124318) (owner: 10Divec)
[15:27:57] <Elitre>	 Krenair: would you be able to provide plain steps to fix the issue described at https://phabricator.wikimedia.org/T95822 ? Looks like some wikis figured that out, others didn't (pl), and I'd like to understand how to help the latter.
[15:28:38] <Krenair>	 Elitre, when I have it completely figured out myself 
[15:28:44] <Krenair>	 probably
[15:28:47] <Elitre>	 sure! :D
[15:29:39] <Elitre>	 I mean, I guess that if it was that easy MatmaRex would have probably fixed that himself for his wiki, but I can't be sure.
[15:31:07] <MatmaRex>	 i don't really understand the changes Krinkle did.
[15:31:40] <MatmaRex>	 and i still think VE should handle this by itself. ;)
[15:45:17] <James_F>	 MatmaRex: If only Krenair would merge a change in core we could migrate everyone to a sane system! ;-)
[15:45:19] * James_F kids.
[15:46:40] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "This is a little scary. Roan, could you have a look?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 (owner: 10Esanders)
[15:48:49] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#2144576 (10AlexMonk-WMF)
[16:08:22] <Elitre>	 I read that as "eh. kids."
[16:08:28] <grrrit-wm>	 (03PS1) 10DLynch: LinearArrowKeyDownHandler: test more [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279134 (https://phabricator.wikimedia.org/T130389) 
[16:08:43] * James_F grins at Elitre .
[16:09:45] <Elitre>	 they're good kids! /me is sad that she can't hand out Easter eggs to them.
[16:17:07] * Krenair is drowning in browser tabs and can't remember where he left anything
[16:22:43] <wikibugs>	 10Cite, 10MobileFrontend, 3Reading-Web-Sprint-68-"Java and JavaScript are basically the same": Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2144671 (10Jdlrobson) a:5Jdlrobson>3None
[16:28:00] <Krenair>	 Elitre, I just tried to fix it on zhwiki myself but appear to have broken something
[16:28:32] <Krenair>	 oh, no
[16:28:34] <Krenair>	 still works
[16:28:42] <Krenair>	 just confused because I changed my interface language half way through
[16:30:24] <grrrit-wm>	 (03PS1) 10Esanders: Fix behaviour of SurfaceFragment#annotateContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279139 
[16:30:52] <Krenair>	 on the other hand... I don't seem to have fixed the issue I was trying to fix either
[16:32:49] <Elitre>	 Krenair: if you want to find someone locally to help you, https://zh.wikipedia.org/wiki/Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E5%85%B6%E4%BB%96 looks like a good page to do that (or https://zh.wikipedia.org/wiki/Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E6%8A%80%E6%9C%AF if you want to use the VPT).
[16:43:59] <Krenair>	 yesss
[16:44:00] <Krenair>	 I think I got it
[16:45:21] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#2144749 (10AlexMonk-WMF)
[16:45:46] <Krenair>	 Elitre, okay
[16:46:23] <Krenair>	 Elitre, so basically it's all of this: https://zh.wikipedia.org/wiki/Special:%E7%94%A8%E6%88%B7%E8%B4%A1%E7%8C%AE/Krenair_(WMF) (except for the march 2015 edit obviously)
[16:46:27] <Krenair>	 "basically"
[16:47:12] <Elitre>	 quoting myself, " plain steps" :D
[16:47:27] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on the remaining wikis - https://phabricator.wikimedia.org/T103693#2144751 (10AlexMonk-WMF) a:3AlexMonk-WMF Need to figure out what to do about enwikibooks & FlaggedRevs, then complete the job there.
[16:48:05] <Elitre>	 plwp also has FR :/
[16:50:50] <grrrit-wm>	 (03PS1) 10Esanders: ve.ui.ContentActions: Add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279144 
[16:58:35] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 7Browser-Support-Apple-Safari: Keyboard shortcut to paste plain text does nothing - https://phabricator.wikimedia.org/T130735#2144864 (10Whatamidoing-WMF)
[17:01:12] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor: Paste of content does not use the context's annotation - https://phabricator.wikimedia.org/T50720#2144883 (10Whatamidoing-WMF) I definitely expect that text pasted into the middle of a link will still be part of the link.  `[[Link|Li]]HardToType[[Link|nk]...
[17:17:31] <wikibugs>	 10VisualEditor, 7Technical-Debt: Add test coverage for ve.ui.Sequence - https://phabricator.wikimedia.org/T130737#2144940 (10Esanders)
[17:19:34] <grrrit-wm>	 (03PS2) 10Esanders: ve.ui.ContentActions: Add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279144 
[17:21:29] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Pasting rich text <pre><span>Sample</span></pre> results in empty <pre> block, and nothing upon save - https://phabricator.wikimedia.org/T130739#2144974 (10Whatamidoing-WMF)
[17:22:43] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Pasting rich text <pre><span>Sample</span></pre> results in empty <pre> block, and nothing upon save - https://phabricator.wikimedia.org/T130739#2145000 (10Whatamidoing-WMF)
[17:27:45] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Can't paste a pre-wrapped heading - https://phabricator.wikimedia.org/T130739#2145062 (10Esanders)
[17:28:23] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Can't paste a pre-wrapped heading - https://phabricator.wikimedia.org/T130739#2144974 (10Esanders) The heading is wrapped in an <h1> as well as the span. That gets alienated as you can't have multiple formats on one paragraph, then thrown away by the paste sanitizer.
[17:54:46] <Krenair>	 James_F, does Pi zero use IRC?
[17:55:19] <James_F>	 Krenair: I've seen him around sometimes, but not often.
[17:56:40] <Krenair>	 Alternatively I guess I could ask for the right to approve it myself
[18:01:13] <Krenair>	 staff global group gives review rights
[18:01:35] <Krenair>	 and editinterface, actually. so I could ask an existing member of the group to review
[18:01:43] <Krenair>	 without also needing them to get GEI
[18:05:01] <James_F>	 Krenair: +staff is *incredibly* rarely given out. I don't have it, for instance.
[18:05:21] <James_F>	 Krenair: +staff is for people that need to run CheckUser/etc. mostly.
[18:05:33] <Krenair>	 yeah, I just checked the list and it seems shorter than I was expecting
[18:05:41] <Krenair>	 maybe Reedy (WMF) will help
[18:09:36] * Krenair will be back to nag people to review after dinner
[18:10:04] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Don't change focus to VE surface if we're opening the SET dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279081 (https://phabricator.wikimedia.org/T130552) (owner: 10Alex Monk)
[18:17:43] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Can't paste a pre-wrapped heading - https://phabricator.wikimedia.org/T130739#2145380 (10Whatamidoing-WMF) Could you discard the formatting instead of the text?
[18:19:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't change focus to VE surface if we're opening the SET dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279081 (https://phabricator.wikimedia.org/T130552) (owner: 10Alex Monk)
[18:23:13] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Single Edit Tab "four choices" dialog doesn't go away when you exit the visual editor - https://phabricator.wikimedia.org/T130552#2145416 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3Normal a:3AlexMonk-WMF
[18:26:11] <mobrovac>	 hello visualeditor crew
[18:26:21] <mobrovac>	 we will need a fix from you guys :P
[18:26:34] <mobrovac>	 we are deploying redirects for commons for RB
[18:26:53] <mobrovac>	 but VE is ignoring those :/
[18:27:10] <mobrovac>	 ex url: http://en.wikipedia.beta.wmflabs.org/wiki/File:Test.jpg
[18:27:51] <mobrovac>	 "add local description" gives an alert
[18:28:15] <mobrovac>	 VE complains about revid mismatch because RB started sending it 301s for that
[18:28:28] <mobrovac>	 (it wants to redirect it to the commons url)
[18:33:45] <mobrovac>	 the fix is rather simple though, you just have to follow the redirect and discover the correct revid
[18:40:45] <James_F>	 RoanKattouw: https://gerrit.wikimedia.org/r/#/c/240722/
[18:43:14] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Treat RB 3XXs as 404s for File: pages - https://phabricator.wikimedia.org/T130757#2145502 (10Jdforrester-WMF)
[18:43:18] <James_F>	 mobrovac: ^^
[18:44:18] <mobrovac>	 heh
[18:45:19] <mobrovac>	 thnx James_F
[18:45:49] <mobrovac>	 we also emit those for non-normalised titles now, but that's not possible to get from VE
[18:47:10] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 (owner: 10Esanders)
[18:49:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Treat RB 3XXs as 404s for File: pages - https://phabricator.wikimedia.org/T130757#2145541 (10Pchelolo)
[18:50:25] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Worth (possible?) to test pasteSpecial too? It's the only one untested…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279144 (owner: 10Esanders)
[18:51:21] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Fix behaviour of SurfaceFragment#annotateContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279139 (owner: 10Esanders)
[18:53:15] <grrrit-wm>	 (03CR) 10Esanders: "Not really" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279144 (owner: 10Esanders)
[18:54:41] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste: Can't paste a pre-wrapped heading - https://phabricator.wikimedia.org/T130739#2145563 (10Esanders) That is the end goal, yes.
[18:55:38] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] ve.ui.ContentActions: Add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279144 (owner: 10Esanders)
[19:00:16] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Treat RB 3XXs as 404s for File: pages - https://phabricator.wikimedia.org/T130757#2145575 (10Pchelolo) Some context on redirects in #restbase: 1. We use (will use soon) 301 redirect for requests with non-canonical title. So soon https://en.wikipedia.org/api/rest_v1/pag...
[19:01:28] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Treat RB 302s (used for File: pages from foreign file repos) as 404s - https://phabricator.wikimedia.org/T130757#2145576 (10Jdforrester-WMF)
[19:02:25] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Follow RB 301s (used for requests in non-canonical form) - https://phabricator.wikimedia.org/T130758#2145578 (10Jdforrester-WMF)
[19:03:18] <grrrit-wm>	 (03PS1) 10Esanders: Tests: Add speed warnings to UI surface constructors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279170 
[19:03:21] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki: Treat RB 302s (used for File: pages from foreign file repos) as 404s - https://phabricator.wikimedia.org/T130757#2145502 (10Jdforrester-WMF) Forked the first bit to {T130758} as it's separable, important, but less urgent. :-)
[19:04:13] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Tests: Add speed warnings to UI surface constructors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279170 (owner: 10Esanders)
[19:07:50] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 6Collaboration-Team-Backlog, 10Flow, and 2 others: Don't strip links when pasting HTML into Flow VisualEditor - https://phabricator.wikimedia.org/T129833#2145630 (10jmatazzoni) 5Open>3Resolved Of these various copy-paste issues, @Esanders  writes:  > I don't th...
[19:08:03] <mobrovac>	 James_F: fyi, mathoid now renders (and rb stores and serves) PNGs, so we're one step closer to using mathoid in prod for everything
[19:08:24] <James_F>	 mobrovac: Nice. :-D
[19:08:32] <mobrovac>	 one piece missing is the math ext actually profiting from it
[19:08:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix behaviour of SurfaceFragment#annotateContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279139 (owner: 10Esanders)
[19:08:56] <James_F>	 mobrovac: Then we can switch to MathML with SVG fallback with PNG fallback fallback, and then we can bully Google into re-adding MathML support. ;-)
[19:09:05] <mobrovac>	 yup!
[19:09:06] <mobrovac>	 :)
[19:09:43] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.ContentActions: Add tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279144 (owner: 10Esanders)
[19:10:06] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 (owner: 10Esanders)
[19:10:37] <grrrit-wm>	 (03Merged) 10jenkins-bot: Tests: Add speed warnings to UI surface constructors [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279170 (owner: 10Esanders)
[19:10:49] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Rename startSave -> onSaveDialogSave [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279106 (owner: 10Esanders)
[19:13:57] <Kemayo>	 In case it hits anyone else, my vagrant issues turned out to be fixed by wiping out the node_modules directories in mathod and parsoid then re-updating them.
[19:17:16] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-29_(1.27.0-wmf.19): Single Edit Tab "four choices" dialog doesn't go away when you exit the visual editor - https://phabricator.wikimedia.org/T130552#2145664 (10Jdforrester-WMF)
[19:19:10] <James_F>	 Kemayo: Ha. Fun.
[19:19:22] <James_F>	 Kemayo: When things get really bad I just `vagrant destroy && vagrant up`.
[19:19:27] <James_F>	 Kemayo: WHich is… meh.
[19:20:15] <Kemayo>	 I try to avoid going full destroy, just because taking out the database as well wipes out my collection of test pages and templates and suchlike.
[19:20:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make data-mw/body.html attribute comparable [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/240722 (owner: 10Esanders)
[19:24:19] <James_F>	 Kemayo: Ah, yeah. If you have good test pages/templates, consider putting them in the VE rôle so others can use them (and you get them back in each new one). :-)
[19:28:59] <mobrovac>	 Kemayo: hm, strange vagrant git-update wipes those out usually before installing the new versions
[19:30:12] <Kemayo>	 James_F: Ah, good idea, I hadn't thought of that.
[19:30:39] <James_F>	 Kemayo: I don't think anyone does that.
[19:31:15] <James_F>	 I think it's supported but I've never seen it used.
[19:31:41] <Kemayo>	 mobrovac: Yeah, I thought it was supposed to, but I ran git-update a few times in case it was some transitory npm glitch, and unless there was some fantastic timing coincidence of said glitch resolving, it was the manual deletion that did it.
[19:33:33] <mobrovac>	 ah. might be some race cond with the service running while vagrnat tries to wipe node_modules
[19:33:38] <mobrovac>	 i'll look into it
[19:34:31] <Kemayo>	 Thanks!
[19:48:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rename startSave -> onSaveDialogSave [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279106 (owner: 10Esanders)
[19:50:46] <wikibugs>	 10TemplateData, 10VisualEditor: templatedata: please add "no-ui" attribute to the "params" object - https://phabricator.wikimedia.org/T130764#2145774 (10Kipod)
[20:02:52] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Improve drop target preview for block node dragging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279125 (owner: 10Esanders)
[20:18:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Improve drop target preview for block node dragging [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279125 (owner: 10Esanders)