[00:00:42] Krenair: Hm.. do we honour displaytitle post-edit? [00:00:49] yes, I thinks o [00:00:51] I guess we want the raw title during the edit session, but wondering about after. [00:00:52] think so* [00:04:25] (03PS12) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [00:07:10] (03CR) 10Happy5214: "What, if anything, is holding this patch up? Can we get this merged?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [00:38:19] (03PS2) 10Jforrester: ArticleTarget: Don't assume an explicit oldid is old; check against current [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279576 (https://phabricator.wikimedia.org/T130810) (owner: 10Alex Monk) [00:38:54] (03CR) 10Jforrester: ArticleTarget: Don't assume an explicit oldid is old; check against current (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279576 (https://phabricator.wikimedia.org/T130810) (owner: 10Alex Monk) [00:39:24] Krenair: If you could +1 https://gerrit.wikimedia.org/r/#/c/279576/1..2/modules/ve-mw/init/ve.init.mw.ArticleTarget.js I'll +2. :-) [00:40:11] (03CR) 10Alex Monk: [C: 031] ArticleTarget: Don't assume an explicit oldid is old; check against current [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279576 (https://phabricator.wikimedia.org/T130810) (owner: 10Alex Monk) [00:40:20] Ta. [00:40:33] (03CR) 10Jforrester: [C: 032] ArticleTarget: Don't assume an explicit oldid is old; check against current [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279576 (https://phabricator.wikimedia.org/T130810) (owner: 10Alex Monk) [00:41:19] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-29_(1.27.0-wmf.19): VisualEditor gave me the "The page has been restored" post-edit notification after a perfectly regular edit - https://phabricator.wikimedia.org/T130810#2152610 (10Jdforrester-WMF) p:5Triage>3Normal [00:41:54] 10VisualEditor, 10VisualEditor-MediaWiki, 5WMF-deploy-2016-03-29_(1.27.0-wmf.19): VisualEditor gave me the "The page has been restored" post-edit notification after a perfectly regular edit - https://phabricator.wikimedia.org/T130810#2147233 (10Jdforrester-WMF) 5Open>3Resolved [00:42:32] 10VisualEditor, 10VisualEditor-ContentEditable, 5WMF-deploy-2016-03-29_(1.27.0-wmf.19): getNodeAndOffset bug causes the cursor to jump after the close of a non-focusable node - https://phabricator.wikimedia.org/T124318#2152619 (10Jdforrester-WMF) 5Open>3Resolved [00:50:00] (03Merged) 10jenkins-bot: ArticleTarget: Don't assume an explicit oldid is old; check against current [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279576 (https://phabricator.wikimedia.org/T130810) (owner: 10Alex Monk) [01:45:29] (03CR) 10Jforrester: "Depends on Icc78795fe in m/e/ULS." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/276145 (https://phabricator.wikimedia.org/T126125) (owner: 10Divec) [02:24:36] 10VisualEditor, 10VisualEditor-MediaWiki: Follow RB 301s (used for requests in non-canonical form) - https://phabricator.wikimedia.org/T130758#2145578 (10AlexMonk-WMF) I believe the client-side RB download already does this [02:42:38] 10VisualEditor, 10VisualEditor-MediaWiki: Follow RB 301s (used for requests in non-canonical form) - https://phabricator.wikimedia.org/T130758#2152710 (10AlexMonk-WMF) Tried to test server-side by disabling my client config and updating RB to the latest version, but as usual, that breaks everything: `{"name":"... [03:03:41] (03CR) 10Alex Monk: [C: 032] Template Dialog: pushPending while the dialog is closing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279387 (https://phabricator.wikimedia.org/T129725) (owner: 10DLynch) [03:09:38] (03CR) 10Alex Monk: [C: 032] Defer the user save in onCustomEditor() to post-send [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279461 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [03:13:44] (03Merged) 10jenkins-bot: Template Dialog: pushPending while the dialog is closing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279387 (https://phabricator.wikimedia.org/T129725) (owner: 10DLynch) [03:16:52] (03Merged) 10jenkins-bot: Defer the user save in onCustomEditor() to post-send [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279461 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [03:24:41] (03CR) 10Alex Monk: "Sounds like this also relates to T121613... James?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [03:31:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Edit conflict not triggered, undoing the earlier changes - https://phabricator.wikimedia.org/T130961#2152211 (10AlexMonk-WMF) Cannot reproduce on localhost [05:48:56] (03Abandoned) 10Divec: WIP: Fix node and offset calculations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/267292 (https://phabricator.wikimedia.org/T124318) (owner: 10Divec) [14:05:58] 10TemplateData, 10VisualEditor, 10Wikidata: Add wikidata parameter to Templatedata parameters - https://phabricator.wikimedia.org/T130991#2153019 (10IKhitron) [14:21:45] 10VisualEditor, 10Parsoid: Empty tag added at the start of the page, broke the infobox - https://phabricator.wikimedia.org/T130224#2130233 (10Drongou) To get a tag Cite => Manual => Basic Form => type some blanks => Insert Exemple : https://test2.wikipedia.org/w/index.php?title=Drong-10&type=r... [15:08:55] (03CR) 10Paladox: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279461 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [15:32:43] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Scribunto: provide templatedata information to scribunto (create mw.templatedata library) - https://phabricator.wikimedia.org/T130996#2153109 (10Kipod) [15:33:40] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Scribunto: provide templatedata information to scribunto (create mw.templatedata library) - https://phabricator.wikimedia.org/T130996#2153122 (10Kipod) [15:37:20] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Scribunto: provide templatedata information to scribunto (create mw.templatedata library) - https://phabricator.wikimedia.org/T130996#2153123 (10Kipod) [15:40:26] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Scribunto: provide templatedata information to scribunto (create mw.templatedata library) - https://phabricator.wikimedia.org/T130996#2153109 (10AlexMonk-WMF) Related to T107119? [16:43:53] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Scribunto: provide templatedata information to scribunto (create mw.templatedata library) - https://phabricator.wikimedia.org/T130996#2153109 (10Anomie) Basically a duplicate. Neither bug has naming that follows https://www.mediawiki.org/wiki/Extension:S... [17:11:30] 10VisualEditor, 10VisualEditor-MediaWiki: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#2153252 (10He7d3r) >>! In T95822#2152210, @AlexMonk-WMF wrote: > Do any of these wikis still have the is... [17:49:46] (03PS1) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [17:50:59] (03CR) 10Paladox: [C: 04-1] "This is just here until we want to add demos to visualeditor." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [18:01:56] (03PS2) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [18:04:13] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-Scribunto: provide templatedata information to scribunto (create mw.templatedata library) - https://phabricator.wikimedia.org/T130996#2153273 (10AlexMonk-WMF) [18:04:15] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Provide a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119#2153274 (10AlexMonk-WMF) [18:04:28] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Provide a Lua method mw.loadTemplateData() - https://phabricator.wikimedia.org/T107119#1487052 (10AlexMonk-WMF) >>! In T130996#2153211, @Anomie wrote: > Basically a duplicate. Neither bug has naming that follows > https://www.mediawiki.org/wiki/Extens... [18:05:33] 10VisualEditor, 10VisualEditor-MediaWiki: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#2153290 (10AlexMonk-WMF) You should probably consider this bug expected behaviour in your case then @He7... [18:06:27] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [18:07:32] 10TemplateData, 10VisualEditor: Manage Templatedata tool should handle transcluded templatedata better - https://phabricator.wikimedia.org/T131000#2153292 (10AlexMonk-WMF) [18:48:53] (03PS3) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [18:51:33] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [18:52:38] (03PS4) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [18:55:38] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [18:56:59] (03CR) 10Esanders: [C: 04-1] "The extra index page seems unnecessary (and on it the extra stylesheet - also the google fonts can definitely not be used)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [19:00:11] (03PS5) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [19:03:54] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [19:15:21] (03PS6) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [19:18:40] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [19:19:57] (03PS7) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [19:22:59] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [19:25:01] (03PS8) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [19:29:38] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [19:30:09] (03PS9) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [19:33:12] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [19:39:40] (03PS10) 10Paladox: Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 [19:42:36] (03CR) 10jenkins-bot: [V: 04-1] Publish VisualEditors demos [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [20:30:35] (03CR) 10Krinkle: "None of this is needed aside from a basic entry point (see sync-gh-pages.sh). We already have all this. We have a working demos directory." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279718 (owner: 10Paladox) [21:46:23] 10VisualEditor, 10Math: Math dialog input is only one row high - https://phabricator.wikimedia.org/T131009#2153452 (10Tchanders) [21:56:25] (03PS1) 10Tchanders: Update maxRows and minRows if minRows is changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279725 (https://phabricator.wikimedia.org/T131009) [22:09:11] (03PS5) 10Tchanders: WIP Make dialog for editing galleries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275931 (https://phabricator.wikimedia.org/T45037) [22:13:55] (03CR) 10jenkins-bot: [V: 04-1] WIP Make dialog for editing galleries [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275931 (https://phabricator.wikimedia.org/T45037) (owner: 10Tchanders) [22:15:08] 10VisualEditor, 10VisualEditor-MediaWiki: Assist de/it/pl/pt/ru-wiki communities in updating their edit-notice systems to stop hidden content showing as "1 notice" - https://phabricator.wikimedia.org/T95822#2153494 (10matmarex) Yeah. That is, unfortunately, explicitly not supported since T87412 (and that's the... [22:30:49] (03PS1) 10Esanders: dm.Document#newFromHtml: Allow HTMLDocument argument as well as string [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279728 [22:35:46] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References: Copying and pasting wikitext with refs results in the addition of a block - https://phabricator.wikimedia.org/T127664#2153508 (10Esanders) 5Open>3Resolved a:3Esanders This was fixed (slightly hackily) with htt... [22:36:38] (03PS1) 10Esanders: Filter out auto-generated reference lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279730 (https://phabricator.wikimedia.org/T101553) [22:38:31] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-References, 13Patch-For-Review: Copying and pasting wikitext with refs results in the addition of a block - https://phabricator.wikimedia.org/T127664#2153519 (10Esanders) The above patch fixes this is a cleaner way, using the... [22:39:58] (03CR) 10jenkins-bot: [V: 04-1] Filter out auto-generated reference lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279730 (https://phabricator.wikimedia.org/T101553) (owner: 10Esanders) [23:28:40] (03CR) 10Jforrester: dm.Document#newFromHtml: Allow HTMLDocument argument as well as string (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/279728 (owner: 10Esanders)