[01:40:27] 10Cite, 10ArchCom-RfC, 10Internet-Archive, 10Parsoid, and 3 others: WIP RFC: Reference API requirements and options - https://phabricator.wikimedia.org/T130663#2154238 (10Cenarium) VisualEditor in mobile should then probably match the behavior of page views and not output references list, especially consid... [13:45:30] 10Cite, 10ArchCom-RfC, 10Internet-Archive, 10Parsoid, and 3 others: WIP RFC: Reference API requirements and options - https://phabricator.wikimedia.org/T130663#2154569 (10Sadads) @Cenarium I would like to push back a bit on "they are static blocs of limited usefulness". Citations are at the core of how Eng... [14:32:58] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow: Flow shows VisualEditor errors when users doint have visualeditor installed - https://phabricator.wikimedia.org/T131055#2154633 (10Paladox) [15:08:40] 10VisualEditor, 10WikiEditor: Merge WikiEditor into VisualEditor and rename the extension - https://phabricator.wikimedia.org/T131057#2154681 (10Paladox) [15:09:17] 10VisualEditor, 10WikiEditor: Merge WikiEditor into VisualEditor and rename the extension - https://phabricator.wikimedia.org/T131057#2154693 (10Paladox) [15:30:41] 10VisualEditor, 10WikiEditor: Merge WikiEditor into VisualEditor and rename the extension - https://phabricator.wikimedia.org/T131057#2154736 (10Jdforrester-WMF) 5Open>3declined No. The plan is to build wikitext editing features into VisualEditor, which will become the editor shipped in the tarball, but we... [15:48:55] (03PS1) 10Jforrester: i18n: Drop another two references to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279955 [15:52:17] 10VisualEditor, 10Math, 5WMF-deploy-2016-03-29_(1.27.0-wmf.19): Math dialog input is only one row high - https://phabricator.wikimedia.org/T131009#2154784 (10Jdforrester-WMF) 5Open>3Resolved p:5Triage>3High [16:15:16] 10VisualEditor: Use keyboards arrows with an inline template produces an unexpected behavior on VE. - https://phabricator.wikimedia.org/T128861#2154877 (10DLynch) I think it's actually fixed by @dchan's recent patch on T124318 -- it's a cursoring-right-off-a-focused-block bug, after all. [16:21:22] 10Citoid, 10VisualEditor, 6Parsing-Team, 6Services, 7Technical-Debt: Restructure so that citoid can be run without Zotero - https://phabricator.wikimedia.org/T93579#2154901 (10ssastry) Here are all the classes that zotero uses that xulrunner provides very likely. ``` Components.classes["@mozilla.org/bina... [16:25:40] (03CR) 10Esanders: "The dependent core commit hasn't been pulled through?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279730 (https://phabricator.wikimedia.org/T101553) (owner: 10Esanders) [16:26:44] (03CR) 10Esanders: [C: 032] i18n: Drop another two references to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279955 (owner: 10Jforrester) [16:27:42] Krenair: Single-edit-tab is-this-a-bug question: if you have both tabs showing up, and click "edit", it'll set the URL to action=edit rather than veaction=edit, meaning that if you then reload the page it'll switch from VE to wikitext. Should I ticket that, or is there already one for it? [16:28:46] Kemayo, hmm... yeah, file a ticket for that one please [16:30:06] 10Cite, 10MobileFrontend, 3Reading Web Sprint 70 L: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2154939 (10dr0ptp4kt) [16:34:16] 10VisualEditor, 10VisualEditor-MediaWiki: SET: If using both tabs, edit sets action rather than veaction - https://phabricator.wikimedia.org/T131064#2154960 (10DLynch) [16:34:23] Ticket: filed. [16:37:07] thanks [16:39:16] (03PS1) 10DLynch: MWLinkAnnotationInspector: select entire link when switching tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279961 (https://phabricator.wikimedia.org/T129650) [16:41:09] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikidata: TemplateData: TemplateData should have a parameter to support Wikidata - https://phabricator.wikimedia.org/T69659#2154987 (10matej_suchanek) [16:41:19] (03Merged) 10jenkins-bot: i18n: Drop another two references to the wikitext editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279955 (owner: 10Jforrester) [16:46:29] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 13Patch-For-Review, 5WMF-deploy-2016-03-29_(1.27.0-wmf.19): Double-click on "insert" (?) inserted two copies of a template - https://phabricator.wikimedia.org/T129725#2154993 (10DLynch) a:3DLynch [16:50:06] 10Citoid, 10VisualEditor, 6Parsing-Team, 6Services, 7Technical-Debt: Restructure so that citoid can be run without Zotero - https://phabricator.wikimedia.org/T93579#2154994 (10ssastry) Based on IRC discussion between @gwicke, @mobrovac and me, there seems to be agreement that if we are comfortable making... [16:51:07] James_F take a look at ^ and chime in if needed, please [16:54:30] (03CR) 10Jforrester: "Oh, sorry, thought I'd pulled that through. One second." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279730 (https://phabricator.wikimedia.org/T101553) (owner: 10Esanders) [16:55:12] (03PS1) 10Jforrester: Update VE core submodule to master (59e4090) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279964 [16:55:36] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (59e4090) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279964 (owner: 10Jforrester) [16:55:55] 10VisualEditor, 10VisualEditor-MediaWiki-References: A reference whose contents is just an auto-numbered link is rendered as blank in the re-use dialog - https://phabricator.wikimedia.org/T114085#1684121 (10DLynch) This has been randomly fixed in the meantime. {F3763137} [16:56:16] 10VisualEditor, 10VisualEditor-MediaWiki: SET: If using both tabs, edit sets action rather than veaction - https://phabricator.wikimedia.org/T131064#2155021 (10Jdforrester-WMF) p:5Triage>3Normal [16:58:05] 10VisualEditor, 10VisualEditor-MediaWiki: Make the "Discard changes" message for bi-directional switching clearer - https://phabricator.wikimedia.org/T125481#2155023 (10Jdforrester-WMF) 5stalled>3declined In the end we scrapped the "discard" option entirely (except for wikis / edits where we can't switch),... [16:59:21] 10VisualEditor, 10VisualEditor-MediaWiki: Add a switch-back-to-WT call-out in VE if coming from switching - https://phabricator.wikimedia.org/T131066#2155025 (10Jdforrester-WMF) [17:00:02] 10VisualEditor, 10VisualEditor-MediaWiki: Consider opening the link inspector/citation dialog after user clicks "Okay got it" on educational pop-up - https://phabricator.wikimedia.org/T117273#2155041 (10Jdforrester-WMF) p:5Low>3High Yes. [17:00:58] Krenair: T117273 and T131066 for today would be awesome (so we can do testing). [17:10:25] (03Merged) 10jenkins-bot: Update VE core submodule to master (59e4090) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279964 (owner: 10Jforrester) [17:23:44] (03PS2) 10Jforrester: Filter out auto-generated reference lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279730 (https://phabricator.wikimedia.org/T101553) (owner: 10Esanders) [17:26:00] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Cancel button is sometimes missing in the Cite dialog - https://phabricator.wikimedia.org/T131069#2155137 (10Whatamidoing-WMF) [17:26:46] 10Citoid, 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki: Cancel button is sometimes missing in the Cite dialog - https://phabricator.wikimedia.org/T131069#2155141 (10Jdforrester-WMF) p:5Triage>3Normal [17:26:54] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Cancel button is sometimes missing in the Cite dialog - https://phabricator.wikimedia.org/T131069#2155124 (10Jdforrester-WMF) [17:54:26] 10Cite, 10ArchCom-RfC, 10Internet-Archive, 10Parsoid, and 3 others: WIP RFC: Reference API requirements and options - https://phabricator.wikimedia.org/T130663#2155297 (10Cenarium) >>! In T130663#2154569, @Sadads wrote: > @Cenarium I would like to push back a bit on "they are static blocs of > limited usef... [17:57:58] (03CR) 10Jforrester: [C: 031] "Waiting for the Parsoid deploy on Wednesday before merging." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279730 (https://phabricator.wikimedia.org/T101553) (owner: 10Esanders) [17:59:53] 10VisualEditor, 10VisualEditor-CopyPaste, 10Wikimedia-Etherpad: Nested lists in Etherpad Lite are a lie, which makes pasting into VE poor - https://phabricator.wikimedia.org/T130970#2155334 (10ksmith) I wasn't even aware of the "HTML export function" in etherpad. They hid it well. Hopefully that will serve a... [18:39:00] 10VisualEditor, 10VisualEditor-CopyPaste, 10Wikimedia-Etherpad, 7Upstream: Nested lists in Etherpad Lite are a lie, which makes pasting into VE poor - https://phabricator.wikimedia.org/T130970#2155530 (10Jdforrester-WMF) 5declined>3stalled Not Declined so much as Stalled waiting on upstream. [18:40:03] 10VisualEditor, 10VisualEditor-CopyPaste, 10Wikimedia-Etherpad, 7Upstream: Nested lists in Etherpad Lite are a lie, which makes pasting into VE poor - https://phabricator.wikimedia.org/T130970#2155534 (10Jdforrester-WMF) p:5Triage>3Low [19:12:47] (03CR) 10Jforrester: [C: 032] MWLinkAnnotationInspector: select entire link when switching tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279961 (https://phabricator.wikimedia.org/T129650) (owner: 10DLynch) [19:13:04] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Auto-filled external link field should remain selected when switching from internal link option - https://phabricator.wikimedia.org/T129650#2155653 (10Jdforrester-WMF) 5Open>3Resolved a:3DLynch [19:22:37] (03Merged) 10jenkins-bot: MWLinkAnnotationInspector: select entire link when switching tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/279961 (https://phabricator.wikimedia.org/T129650) (owner: 10DLynch) [19:53:09] (03PS3) 10Jforrester: MWPopupTool: Don't pass $1 to visualeditor-beta-warning any more [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275737 [20:00:39] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: When I'm typing in wikitext in Flow, it should not send my wikitext through Parsoid - https://phabricator.wikimedia.org/T131090#2155746 (10Whatamidoing-WMF) [20:05:58] 10VisualEditor, 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: When I'm typing in wikitext in Flow, it should not send my wikitext through Parsoid - https://phabricator.wikimedia.org/T131090#2155746 (10ssastry) Presumably Flow parses the typed wikitext because in the backend, it stores HTML, not Parsoid.... [21:09:05] (03PS1) 10Krinkle: sync-gh-pages: Fix "oojs-ui-apex.vector.css" 404 Not Found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280081 [21:09:13] James_F: ^ [21:30:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Parsoid should treat '|-' syntax as row separator, not row start - https://phabricator.wikimedia.org/T130696#2156104 (10Krinkle) >>! In T130696#2144352, @ssastry wrote: > So, why add this hack to Parsoid when a simple fix would be to edit the page? That's... [21:32:13] 10Citoid, 10VisualEditor, 6Parsing-Team, 6Services, 7Technical-Debt: Restructure so that citoid can be run without Zotero - https://phabricator.wikimedia.org/T93579#2156135 (10ssastry) If we want to go down the route of moving away from zotero itself, see below for a count of references to zotero code in... [21:35:17] 10VisualEditor, 10VisualEditor-CopyPaste, 10Wikimedia-Etherpad, 7Upstream: Nested lists in Etherpad Lite are a lie, which makes pasting into VE poor - https://phabricator.wikimedia.org/T130970#2152416 (10ssastry) T127207 is related. We might fix this in Parsoid ... if the gsoc project / student doesn't get... [21:58:36] 10VisualEditor, 10VisualEditor-MediaWiki: Treat RB 302s (used for File: pages from foreign file repos) as 404s - https://phabricator.wikimedia.org/T130757#2156224 (10AlexMonk-WMF) Should we just assume that all 302s are basically 404s, and ensure that VE always sends the normalised title, or do we really need... [22:01:22] (03CR) 10Jforrester: [C: 032] sync-gh-pages: Fix "oojs-ui-apex.vector.css" 404 Not Found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280081 (owner: 10Krinkle) [22:01:27] Thanks, Krinkle. [22:05:23] (03Merged) 10jenkins-bot: sync-gh-pages: Fix "oojs-ui-apex.vector.css" 404 Not Found [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280081 (owner: 10Krinkle) [22:06:28] 10VisualEditor, 10VisualEditor-MediaWiki: Treat RB 302s (used for File: pages from foreign file repos) as 404s - https://phabricator.wikimedia.org/T130757#2156232 (10Jdforrester-WMF) >>! In T130757#2156224, @AlexMonk-WMF wrote: > Should we just assume that all 302s are basically 404s, and ensure that VE always... [22:09:37] 10VisualEditor, 10VisualEditor-MediaWiki: Missing arguments in final dialog to feedback in VisualEditor - https://phabricator.wikimedia.org/T129463#2156243 (10Whatamidoing-WMF) [22:11:42] 10VisualEditor, 10VisualEditor-MediaWiki: Missing arguments in final dialog to feedback in VisualEditor - https://phabricator.wikimedia.org/T129463#2106402 (10Whatamidoing-WMF) The screenshot is from https://no.wikipedia.org/wiki/Drabek_Peak so it's Norwegian. [22:29:23] (03PS1) 10Alex Monk: Treat a 302 from RESTBase like a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/280095 (https://phabricator.wikimedia.org/T130757) [22:34:48] (03CR) 10Jforrester: [C: 031] "Looks right; untested." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/280095 (https://phabricator.wikimedia.org/T130757) (owner: 10Alex Monk) [22:55:42] 10VisualEditor, 10VisualEditor-MediaWiki: Add a switch-back-to-WT call-out in VE if coming from switching - https://phabricator.wikimedia.org/T131066#2155025 (10AlexMonk-WMF) Like an education popup on the switch button? [23:10:40] Krenair: ping [23:10:55] pong [23:12:08] Krenair: so on Friday I had a chat about redirect handling in xhr and fetch with the whatwg folks, and it seems that for security reasons, redirect response details will never be exposed [23:12:16] xhr itself always follows redirects [23:12:51] oh right, I had forgotten it does that [23:12:52] kind of breaks my patch, doesn't it [23:13:03] yeah, I think so [23:13:26] damn [23:13:30] well [23:13:31] fetch lets you specify `redirect: 'manual'`, which *might* expose the status [23:13:38] (havent' tested) [23:13:44] gwicke, what does the redirect look like exactly? [23:13:50] I can't test newer versions of restbase myself [23:14:19] Krenair: it'll be a 302 with a location header [23:14:29] Yes I know that part gwicke [23:14:35] what is the contents of the location header? [23:14:44] the commons description page [23:14:45] If we do that, we'll need to react to 301s etc. [23:15:15] the issue is that some sites use the location header to inject secret tokens, and rely on the location to not be accessible to JS [23:15:18] gwicke, the page from MW itself? [23:15:44] so whatwg basically can't start exposing redirects any more, because it would break existing sites [23:16:09] a weird case of narrow interfaces becoming an issue later [23:16:21] Krenair: no, the restbase equivalent [23:16:32] how do you guess the remote restbase url? [23:16:44] so if you asked for html, it'll redirect to the commons restbase API URL for the same [23:17:09] Krenair: we use siteinfo to get the shared repo, and build the restbase URL from that [23:17:18] so even recursive repos should work [23:17:46] how can you possibly build a restbase URL given only the shared repo details? how do you know that the repo has a restbase instance pointing to it somewhere? [23:17:48] assumption is that the public URL is /api/rest_v1/ [23:18:37] I don't think that can work [23:19:17] for exotic configurations we'd need to add some more config vars [23:19:19] you can't enforce there being a single restbase domain per actual domain [23:20:58] well, we are focusing on the common case first; complex stuff can be added as-needed later [23:21:20] in any case, redirects are tricky with browsers [23:21:23] so you haven't actually fully implemented it yet, you've implemented it only for wikimedia sites [23:22:04] wikimedia and sites following the default URL layout [23:22:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, and 3 others: Add polytonic characters for Greek to MediaWiki's special character list as used in WikiEditor and VisualEditor - https://phabricator.wikimedia.org/T130535#2156524 (10Jdforrester-WMF) Adding some individuals who... [23:24:38] gwicke, default URL layout is /path/to/script/dir/index.php/ IIRC [23:24:50] <Krenair> which is slightly better than /path/to/script/dir/index.php?title=<title> [23:25:02] <Krenair> /wiki/ is custom [23:25:08] <Krenair> though recommended [23:25:27] <gwicke> maybe this can help: https://xhr.spec.whatwg.org/#the-responseurl-attribute [23:26:11] <gwicke> supported in FF 32+ and Chrome 37+, it seems [23:26:23] <gwicke> ~September 2014 [23:27:24] <gwicke> https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/responseURL [23:29:18] <gwicke> Krenair: it is very possible to support random domains / paths, but we'll wait until we actually need it [23:29:44] <gwicke> by then, we'll hopefully have a better idea of how apis relate to the main entry point by default [23:31:58] <grrrit-wm1> (03CR) 10Jforrester: [C: 04-1] "* 90% use case not (users with no uploads) not met." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/210831 (https://phabricator.wikimedia.org/T62398) (owner: 10MarkAHershberger) [23:40:29] <grrrit-wm1> (03Abandoned) 10Alex Monk: Treat a 302 from RESTBase like a 404 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/280095 (https://phabricator.wikimedia.org/T130757) (owner: 10Alex Monk) [23:41:26] <Krenair> gwicke, pretty sure VE supports more than FF32+ and chrome 37+ [23:48:24] <James_F> Lots more. [23:48:42] <James_F> Chrome 2+, FF 15+, IE 10+, Safari 7+