[07:43:41] (03CR) 10Legoktm: [C: 032] "Ew :(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283768 (https://phabricator.wikimedia.org/T131633) (owner: 10Alex Monk) [07:54:55] (03Merged) 10jenkins-bot: Restore original WebRequest after we're finished messing with FlaggedRevs on save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283768 (https://phabricator.wikimedia.org/T131633) (owner: 10Alex Monk) [08:51:54] 10VisualEditor, 10MediaWiki-extensions-ParserFunctions: Create Magic Word for VisualEditor - https://phabricator.wikimedia.org/T132897#2213480 (10Dvorapa) [08:57:37] 10VisualEditor, 10MediaWiki-extensions-ParserFunctions: Create Magic Word for VisualEditor - https://phabricator.wikimedia.org/T132897#2213521 (10Dvorapa) [08:59:20] 10VisualEditor, 10MediaWiki-extensions-ParserFunctions: Create Magic Word for VisualEditor - https://phabricator.wikimedia.org/T132897#2213480 (10Dvorapa) [09:00:36] 10VisualEditor, 10MediaWiki-extensions-ParserFunctions: Create Magic Word for VisualEditor - https://phabricator.wikimedia.org/T132897#2213531 (10Dvorapa) [09:02:11] 10VisualEditor, 10MediaWiki-extensions-ParserFunctions: Create Magic Word for VisualEditor - https://phabricator.wikimedia.org/T132897#2213480 (10Dvorapa) [09:05:33] 10VisualEditor, 10MediaWiki-extensions-ParserFunctions: Create Magic Word for VisualEditor (to allow linking between VE and source help pages) - https://phabricator.wikimedia.org/T132897#2213480 (10Aklapper) [10:04:51] mobrovac: I hate that if I convert a bare url from e.g. http://www.ncbi.nlm.nih.gov/pmc/articles/PMC2440746/ it will generate a citation with a doi, but Citoid does not crossreference that doi with crossref and get 'even more information' [10:05:49] Josve05a: and if you jsut input the pmcid it will? [10:07:30] ok, that was a bad url...let m find a concrete example... [10:08:00] :) [10:11:01] ok...let me get back to you...seems as thouh I'm having some issues reproducing something... [10:15:51] mobrovac: Notice the difference here? https://en.wikipedia.org/wiki/User:Josve05a/sandboxCitoid [10:16:28] (that's the other way around as to what I explained, but...) [10:16:43] that's one thing I dislike... [10:20:10] yeah, but the info for the first two is taken from NIH, the last one from dovepress it seems [10:51:36] mobrovac: Well it is inconsistencies like that that nags me to no end :P [10:52:42] i can relate [10:53:27] iirc, crossref is a fall-back [10:55:27] https://en.wikipedia.org/wiki/User:Josve05a/sandboxCitoid :/ [10:56:22] 1690724 doens't give https but 11467425 does [10:56:25] in ^ [10:56:49] sorry...wrong... [10:57:00] 11467425 doesn't give https, while https://www.ncbi.nlm.nih.gov/pubmed/11467425 does [10:58:01] 1690724 doesn't find a doi, but it does find 11467425 which does find a doi [11:01:16] ah yes, we've got http:// hard-coded [11:01:30] why...? [11:01:43] tech-debt i guess [11:01:48] I've added some comments on https://en.wikipedia.org/wiki/User:Josve05a/sandboxCitoid#2 [11:02:00] also, not all websites support https unfortunately [11:02:47] but ncbi.nlm.nih.gov does, and it generated the link when I generated the citation with a PMID [11:03:05] yes, that part is fixable [11:03:18] i'm just saying that assuming https in general is not what we want [11:03:37] dx.doi.org also has https [11:04:20] i'll fix that [11:04:41] regarding the PMC (number 2 on that page above), can't crossref somehow be able to find the doi here [11:04:55] regarding the PMC (number 2 on that page above), can't crossref somehow be able to find the doi here [11:05:18] that i dunno [11:05:26] Josve05a: please file a task about it [11:05:38] (sorry, bad connection) [11:09:25] 10Citoid, 10VisualEditor: Crossref citations with crossref etc. and try and find all possible information using multiple IDs at once - https://phabricator.wikimedia.org/T132910#2213851 (10Josve05a) [11:09:45] mobrovac: https://phabricator.wikimedia.org/T132910 [11:10:00] kk thnx [12:34:46] 10Citoid, 10VisualEditor, 10Source-Metadata, 10Wikidata: [Story] Support for citoid in Wikidata - https://phabricator.wikimedia.org/T131661#2213952 (10Trizek-WMF) @VIGNERON is looking for a demo. Is it alive anywhere? :) [13:16:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, and 3 others: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#493794 (10Qgil) What is missing to consider this task Resolved? I am tryin... [13:28:08] 10Citoid, 10VisualEditor, 06Services, 15User-mobrovac: Use HTTPS for DOI, CrossRef and NIH requests - https://phabricator.wikimedia.org/T132916#2214002 (10mobrovac) [13:41:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, and 3 others: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#2214028 (10Ankry) >>! In T48580#2213983, @Qgil wrote: > What is missing to... [14:31:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-API, 13Patch-For-Review: ApiVisualEditorEdit sets DerivativeRequest into global context - https://phabricator.wikimedia.org/T131633#2214079 (10AlexMonk-WMF) 05Open>03Resolved [15:03:08] Hi there! I have an issue that maybe someone has already solved. I can't force visual-editor by default and i don't have the link "edit", only "edit wikicode". [15:12:55] LcS: Hey. It sounds like either your skin or your browser aren't supported for some reason. [15:13:45] VE work fine if i call it with a right clic on title :-/ [15:15:19] James_F: for information, i use mw 1.26 (sable) and version a733545 of the VisualEditor [15:16:39] Another clue : if i add veaction=edit&vesection=1 in my url, VE is not initalized [15:16:56] Hmm. Very odd. [15:17:50] And of course, nothing in my log files to help me ;-) [15:21:48] LcS: In your browser's JavaScript console are there any errors? [15:22:40] Only that: Use of "mwCustomEditButtons" is deprecated. Use mw.toolbar instead. [15:23:22] that came from load.php [15:25:22] * James_F nods. [15:25:53] What happens if you execute `mw.libs.ve.isAvailable` (without the quotes)? [15:27:50] i don't know how to execute that :-/ [15:28:13] Paste it into the console and press return. [15:28:19] Sorry. [15:29:02] ah ok, i was looking in binaries in my server :D [15:30:25] James_F: that return false [15:30:45] Hmm. [15:32:10] Gah, 1.26 version. [15:32:17] * James_F tries to remember how that code worked. [15:32:47] LcS: This is for a page in a namespace that is a content namespace and your account can edit? [15:33:46] James_F: It is on an existing page, that my account can edit with wikicode and by a right clic on a title with Visual Editor [15:34:24] (the step2 : creating pages with VE will come later :D) [15:34:29] (03CR) 10DLynch: [C: 032] Hide borders on linked images in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283428 (owner: 10Esanders) [15:34:32] I don't understand what "by a right clic on a title" means. Do you have some code that does that? [15:35:08] It is in user preferences, and the only way that i've find to activate VE [15:35:22] try dumping these into console [15:35:29] $.inArray( mw.config.get( 'skin' ), wgVisualEditorConfig.skins ) !== -1 [15:36:04] $.inArray( new mw.Title( wgRelevantPageName ).getNamespaceId(), wgVisualEditorConfig.namespaces ) !== -1 [15:36:30] wgNamespaceNumber [15:36:32] wgTranslatePageTranslation [15:36:35] wgPageContentModel [15:36:39] any of them show as false? [15:37:01] false on the first, true on the second [15:37:09] yeah it's the skin then [15:37:20] (03CR) 10DLynch: [C: 032] Fix access of iframe-created document in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283427 (https://phabricator.wikimedia.org/T65039) (owner: 10Esanders) [15:37:28] Outch :-/ [15:37:32] what skin? [15:37:45] Bootstrap Nexus [15:37:52] never heard of it [15:38:01] http://www.mediawikibootstrapskin.co.uk/nexus/index.php?title=Main_Page [15:38:03] still [15:38:12] VisualEditor only works in Vector and Monobook. [15:38:18] you could try add it to $wgVisualEditorSupportedSkins and crossing your fingers [15:38:30] Well, yeah, but it'll likely break. :-( [15:39:37] possibly but it did work with the right click thing [15:39:39] so maybe? [15:40:00] Yes it works perfectly with the right clic on title [15:40:37] 10VisualEditor, 10VisualEditor-Initialisation, 07Browser-Support-Internet-Explorer, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): VisualEditor: Console shows "Permission denied" on IE9 when VE is first initiated - https://phabricator.wikimedia.org/T65039#2214251 (10Jdforrester-WMF) 05Open>03Resolved a:03Es... [15:41:53] Where should i try the var $wgVisualEditorSupportedSkins ? [15:42:37] LocalSettings.php ? [15:42:38] in your LocalSettings or equivalent [15:43:15] yes [15:46:00] * LcS is still working on it [15:47:22] OMG it's working ! [15:47:33] Guy's you rocks [15:50:17] I still need some tweak to do on my template but VE is now working as expected. Thank you James_F and Krenair ! [15:53:56] Huh. [15:54:16] Krenair: OK, we need to work out why "right click on a section title" loads VE bypassing the code to say not to do so. :-) [15:54:59] (03PS5) 10Jforrester: Add a popup after switching into VE from WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) (owner: 10Alex Monk) [15:55:04] :-D [15:55:18] Krenair: ^^^ now with text. [15:56:10] Please add somewhere in the doc the wgVisualEditorSupportedSkins thing. I did not find it anywhere ;-) [15:57:11] LcS: See https://www.mediawiki.org/wiki/Extension:VisualEditor#Complete_list_of_configuration_options [15:57:43] Hmm. There used to be a high-profile notice there that VE only works in Vector and Monobook. [15:59:08] based on resources/src/mediawiki.action/mediawiki.action.view.rightClickEdit.js in core it just uses .click() on the first section edit link [16:00:37] I've saw that… I did not see the "if the user's skin is not matched, VisualEditor will refuse to load." :-( [16:01:16] Yup. Not helpful to just have that. [16:01:19] Krenair: Odd. [16:02:08] https://www.mediawiki.org/w/index.php?title=Extension:VisualEditor&diff=2101352&oldid=2099824 [16:52:34] 10VisualEditor, 10Improving-access, 06Research-and-Data, 13Patch-For-Review: Make a gadget for hyperlink recommendation - https://phabricator.wikimedia.org/T119477#2214554 (10leila) [16:52:36] 10VisualEditor, 10Improving-access, 06Research-and-Data-Backlog: Turn the link rec gadget into an experimental gadget in enwiki - https://phabricator.wikimedia.org/T126535#2214553 (10leila) [16:58:22] 10VisualEditor, 10Improving-access, 06Research-and-Data-Backlog: Code the mock-ups for link recommendations - https://phabricator.wikimedia.org/T126536#2214584 (10leila) @Ashwinpp let's review the gadget in terms of the UI available together, and see what/if anything needs to be changed in the current UI bef... [17:36:53] (03CR) 10Jforrester: [C: 032] Fix double-click to edit table cells in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283444 (owner: 10Esanders) [17:40:15] (03CR) 10Esanders: "I kept the name of the original file from GitHub:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 (owner: 10Esanders) [18:01:57] edsanders: Are you doing anything to 283426? I need to fiddle with it (add an entry to the AUTHORS file). [18:12:38] James_F: no [18:12:48] Kk. [18:12:59] Mind if I rename the file whilst I'm at it? [18:23:16] (03PS3) 10Jforrester: Add classList polyfill for IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 (owner: 10Esanders) [18:24:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-API, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): ApiVisualEditorEdit sets DerivativeRequest into global context - https://phabricator.wikimedia.org/T131633#2215025 (10Jdforrester-WMF) [18:27:55] (03CR) 10Jforrester: [C: 031] "Will +2 if Ed +1s." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 (owner: 10Esanders) [18:28:23] (03CR) 10jenkins-bot: [V: 04-1] Add classList polyfill for IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 (owner: 10Esanders) [18:48:06] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Calendar input widget for dates in template parameters - https://phabricator.wikimedia.org/T100206#2215094 (10Anomie) >>! In T100206#2207120, @AlexMonk-WMF wrote: >>>! In T100206#2199414, @Anomie wrote: >>> And even when you set type: 'date' in construction c... [19:07:19] (03PS4) 10Esanders: Add classList polyfill for IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 [19:18:58] (03CR) 10Esanders: [C: 031] "Finished off the rename." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 (owner: 10Esanders) [19:45:42] (03CR) 10Jforrester: [C: 032] "Ha, I'm a fool." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 (owner: 10Esanders) [19:45:50] (03PS3) 10Jforrester: Fix access of iframe-created document in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283427 (https://phabricator.wikimedia.org/T65039) (owner: 10Esanders) [19:47:29] (03CR) 10Jforrester: [C: 032] Fix access of iframe-created document in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283427 (https://phabricator.wikimedia.org/T65039) (owner: 10Esanders) [19:47:35] (03PS3) 10Jforrester: Hide borders on linked images in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283428 (owner: 10Esanders) [19:47:40] (03CR) 10Jforrester: [C: 032] Hide borders on linked images in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283428 (owner: 10Esanders) [19:47:47] (03PS2) 10Jforrester: Fix double-click to edit table cells in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283444 (owner: 10Esanders) [19:47:53] (03CR) 10Jforrester: [C: 032] Fix double-click to edit table cells in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283444 (owner: 10Esanders) [19:51:24] 10VisualEditor, 10MediaWiki-extensions-ParserFunctions: Create Magic Word for VisualEditor (to allow linking between VE and source help pages) - https://phabricator.wikimedia.org/T132897#2213480 (10Blahma) I am afraid that "editor used by the currently viewing logged-in user" cannot be turned into a magic word... [19:53:36] (03Merged) 10jenkins-bot: Add classList polyfill for IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283426 (owner: 10Esanders) [19:54:48] (03Merged) 10jenkins-bot: Fix access of iframe-created document in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283427 (https://phabricator.wikimedia.org/T65039) (owner: 10Esanders) [19:54:53] (03Merged) 10jenkins-bot: Hide borders on linked images in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283428 (owner: 10Esanders) [19:54:56] (03Merged) 10jenkins-bot: Fix double-click to edit table cells in IE9 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/283444 (owner: 10Esanders) [20:03:40] 10VisualEditor, 06Editing-Analysis: Generate Jan–Mar 2016 Editing metrics snapshot - https://phabricator.wikimedia.org/T127248#2215389 (10Neil_P._Quinn_WMF) 05Open>03Resolved Completed this, and did my quarterly review presentation and updated the Product page on mediawiki.org. However, the editor-month... [20:27:48] (03CR) 10Jforrester: [C: 04-1] "(Still blocked on upstream.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269433 (https://phabricator.wikimedia.org/T124850) (owner: 10Alex Monk) [20:30:27] (03PS3) 10Alex Monk: Add a hidden link with accesskey=v in SET prefer-wt mode and remember-last wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283591 (https://phabricator.wikimedia.org/T116406) [20:32:47] (03CR) 10Alex Monk: [C: 04-1] Add a hidden link with accesskey=v in SET prefer-wt mode and remember-last wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283591 (https://phabricator.wikimedia.org/T116406) (owner: 10Alex Monk) [20:34:28] (03PS4) 10Alex Monk: Add a hidden link with accesskey=v in SET prefer-wt mode and remember-last wikitext [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283591 (https://phabricator.wikimedia.org/T116406) [20:36:23] James_F, does that popup work as you expect? [20:36:28] the one in https://gerrit.wikimedia.org/r/#/c/283120/ [20:37:11] Krenair: Didn't have time to re-test yet, sorry. [20:40:34] 10VisualEditor: Review Q3 work via Phabricator task reporting - https://phabricator.wikimedia.org/T132967#2215588 (10JAufrecht) [21:10:29] (03CR) 10Alex Monk: "I think I lack the information needed to help here. What other types are we going to put through this? ve-mw is built on the assumption th" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281109 (owner: 10Jforrester) [21:13:06] (03CR) 10Jforrester: "> I think I lack the information needed to help here. What other types are we going to put through this? ve-mw is built on the assumption " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281109 (owner: 10Jforrester) [21:15:55] 10VisualEditor, 10Improving-access, 06Research-and-Data, 13Patch-For-Review: Make a gadget for hyperlink recommendation - https://phabricator.wikimedia.org/T119477#2215729 (10Ashwinpp) Merge the basic UI as a subsequent commit in gerrit and get it code reviewed. Fix the bug where selecting clicking on new... [21:17:11] 10VisualEditor, 10Improving-access, 06Research-and-Data, 13Patch-For-Review: Make a gadget for hyperlink recommendation - https://phabricator.wikimedia.org/T119477#2215739 (10Ashwinpp) @Esanders I tried copying over the current version to my own common.js but my VE stopped loading. I believe it can be used... [21:38:13] (03CR) 10Alex Monk: "Yes, I believe that's the existing action=edit behaviour." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281109 (owner: 10Jforrester) [21:51:04] (03CR) 10Jforrester: "> Yes, I believe that's the existing action=edit behaviour." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281109 (owner: 10Jforrester)