[00:02:19] (03CR) 10Jforrester: "* Needs the "don't show again" checkbox" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) (owner: 10Alex Monk) [00:02:23] (03CR) 10Jforrester: [C: 04-1] Add a popup after switching into VE from WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) (owner: 10Alex Monk) [00:56:42] (03PS8) 10Alex Monk: Add a popup after switching into VE from WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) [01:00:37] (03CR) 10jenkins-bot: [V: 04-1] Add a popup after switching into VE from WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) (owner: 10Alex Monk) [01:05:53] (03PS9) 10Alex Monk: Add a popup after switching into VE from WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) [01:46:08] (03PS10) 10Jforrester: Add a popup after switching into VE from WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) (owner: 10Alex Monk) [01:50:09] (03CR) 10Jforrester: [C: 031] "PS10: Tweak styling to make the bottom padding less huge. LGTM from a product perspective, Ed do you want to +2?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283120 (https://phabricator.wikimedia.org/T131066) (owner: 10Alex Monk) [03:49:13] 10Cite, 10VisualEditor: Citation encapsulation failure - https://phabricator.wikimedia.org/T133255#2226268 (10Ceyockey) [03:51:30] 10Cite, 10VisualEditor: Citation encapsulation failure - https://phabricator.wikimedia.org/T133255#2226280 (10Ceyockey) [07:34:11] 10VisualEditor, 10VisualEditor-ContentEditable, 07I18n, 07RTL: Textual alien on directionality boundary cannot be reached using arrow keys - https://phabricator.wikimedia.org/T131677#2226453 (10dchan) The unexpected cursor jump is a Chromium bug; see https://bugs.chromium.org/p/chromium/issues/detail?id=60... [07:36:59] 10VisualEditor, 06Community-Liaisons: please enable edit, edit source on mediawiki.org - https://phabricator.wikimedia.org/T132760#2226454 (10Aklapper) 05Open>03declined @ThurnerRupert: As per T132760#2225584 and T132760#2221905 I kindly ask you to [[ https://www.mediawiki.org/wiki/Phabricator/Etiquette |... [08:18:21] 10VisualEditor, 10VisualEditor-ContentEditable, 07I18n, 07RTL: Textual alien on directionality boundary cannot be reached using arrow keys - https://phabricator.wikimedia.org/T131677#2226504 (10dchan) I reported the missing visual cursor position as a Chromium bug: https://bugs.chromium.org/p/chromium/issu... [09:05:59] 10VisualEditor: [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title", also cursor is not appearing on that line automatically - https://phabricator.wikimedia.org/T133227#2225686 (10Esanders) Caused by https://gerrit.wikimedia.org/r/#/c/283182/ - MenuToolGroup doesn't set the ico... [09:10:38] 10VisualEditor, 10OOjs-UI: [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title", also cursor is not appearing on that line automatically - https://phabricator.wikimedia.org/T133227#2226543 (10Esanders) p:05Triage>03High a:03matmarex [09:18:45] 10VisualEditor, 10Wikimedia-Site-requests: Enable VisualEditor by default for all users of French Wikinews - https://phabricator.wikimedia.org/T133263#2226552 (10Mattho69) [11:03:43] 10VisualEditor: Link got lost after saving - https://phabricator.wikimedia.org/T133269#2226687 (10Pginer-WMF) [11:10:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2226709 (10Dvora... [11:41:29] (03PS1) 10Esanders: Use Array.prototype.indexOf in support check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284678 [11:41:31] (03PS1) 10Esanders: Create MW targets using a factory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284679 [11:41:33] (03PS1) 10Esanders: Allow extensions to support extra namespaces and content models [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 [12:11:32] (03PS1) 10Esanders: Convert spaces to tabs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/284683 [12:54:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2227014 (10Blahm... [12:59:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2227034 (10Dvora... [13:03:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2227053 (10Blahm... [13:06:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2227079 (10Dvora... [13:12:13] 10VisualEditor, 10MediaWiki-User-preferences: Split up editor preferences into VE and source parts - https://phabricator.wikimedia.org/T133287#2227089 (10Dvorapa) [13:14:38] 10VisualEditor, 10Wikimania-Hackathon-2016, 07JavaScript, 07Ruby, 15User-zeljkofilipin: Port language screenshots for VisualEditor from Ruby to JavaScript - https://phabricator.wikimedia.org/T132574#2227129 (10zeljkofilipin) @Esanders apologies for the late reply, I was traveling. Yes, @dduvall and I ha... [14:22:54] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-ProofreadPage, 06Wikisource: Get rid of
which spans multiple sections, so that each section is balanced HTML - https://phabricator.wikimedia.org/T133294#2227333 (10Esanders) [14:31:01] James_F: so that's the wikisource integration pretty much finished... [14:31:46] edsanders: Show off. :-) [14:32:12] I saw you duped my patch to support different content types. I'll junk mine. [14:33:48] (03PS1) 10Aaron Schulz: Do not call saveSettings() on anon users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284702 [14:40:44] I didn't see yours [14:41:38] (03PS2) 10Aaron Schulz: Do not call saveSettings() on anon users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284702 [14:44:05] James_F: I think yours might be better [14:44:41] I'll copy over the bits I missed [14:44:46] It isn't finished though. [14:44:48] OK. [15:14:32] (03CR) 10Jforrester: [C: 04-1] Do not call saveSettings() on anon users (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284702 (owner: 10Aaron Schulz) [15:18:29] (03CR) 10Jforrester: [C: 032] Use Array.prototype.indexOf in support check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284678 (owner: 10Esanders) [15:21:56] 10VisualEditor, 06Community-Liaisons: please enable edit, edit source on mediawiki.org - https://phabricator.wikimedia.org/T132760#2227460 (10ThurnerRupert) 05declined>03Open @wctaiwan , @WhatamIdoing, this is problematic because the implementation seems somehow broken. i tried to get both tabs for anonymo... [15:22:35] (03PS2) 10Jforrester: ve.ce.SectionNode.css: Convert spaces to tabs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/284683 (owner: 10Esanders) [15:22:43] (03CR) 10Jforrester: [C: 032] ve.ce.SectionNode.css: Convert spaces to tabs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/284683 (owner: 10Esanders) [15:27:23] (03Merged) 10jenkins-bot: Use Array.prototype.indexOf in support check [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284678 (owner: 10Esanders) [15:27:25] (03Merged) 10jenkins-bot: ve.ce.SectionNode.css: Convert spaces to tabs [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/284683 (owner: 10Esanders) [15:28:16] (03CR) 10Aaron Schulz: Do not call saveSettings() on anon users (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284702 (owner: 10Aaron Schulz) [15:28:34] (03PS3) 10Aaron Schulz: Do not call saveSettings() on anon users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284702 [15:29:12] James_F: so it looks like the merge_strategy think should do the work for us, but it isn't [15:50:53] (03PS2) 10Esanders: Allow extensions to support extra namespaces and content models [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 [15:50:55] (03PS1) 10Esanders: Add method that runs after activation, for overriding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284713 [15:51:18] (03CR) 10Esanders: "This should be using the built in merge strategy stuff, but it doesn't seem to be working..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 (owner: 10Esanders) [15:56:44] (03CR) 10Jforrester: [C: 032] Do not call saveSettings() on anon users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284702 (owner: 10Aaron Schulz) [16:02:31] (03Merged) 10jenkins-bot: Do not call saveSettings() on anon users [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284702 (owner: 10Aaron Schulz) [16:03:18] Krenair, Krinkle there's something weird going on with these VE config override stuff [16:03:37] edsanders: I saw warnings in the logs earlier during the codfw switch for VE failing to set thigns for user id 0 [16:03:43] in VE, VisualEditorPluginModules is a property of config [16:03:51] then forgot about it [16:04:02] whereas in extensions it is a root global [16:04:22] legoktm, ^ [16:04:58] config merging only happens on root global? [16:05:02] globals [16:12:03] 10VisualEditor, 10VisualEditor-CopyPaste: Support preserving links in pasted HTML content - https://phabricator.wikimedia.org/T129546#2108764 (10DLynch) Technically, it'd be simple enough: just remove `link` from the `importRules` (defined [here](https://phabricator.wikimedia.org/diffusion/EVED/browse/master/m... [16:12:29] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 13Patch-For-Review: Remove button on link context menu does not work after adding label to a simple link (because it's now the wrong context menu for the item) - https://phabricator.wikimedia.org/T121448#2227629 (10DLynch) a:03DL... [16:14:34] (03PS3) 10DLynch: ve.ui.TabbableElements: JS replacement for unreliable tabIndex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/282964 (https://phabricator.wikimedia.org/T129792) [16:23:55] 10VisualEditor: Please verify that cookies are working correctly for logged-out editors at en.wiki - https://phabricator.wikimedia.org/T133304#2227691 (10Elitre) [16:27:16] 10VisualEditor: Please verify that cookies are working correctly for logged-out editors at en.wiki - https://phabricator.wikimedia.org/T133304#2227720 (10Elitre) [16:33:50] 10VisualEditor: Please verify that cookies are working correctly for logged-out editors at en.wiki - https://phabricator.wikimedia.org/T133304#2227691 (10Whatamidoing-WMF) Steps to reproduce: 1) Log out. 2) Go to https://en.wikipedia.org/wiki/Special:Random 3) Click the Edit button, and get the wikitext editor.... [16:43:39] (03CR) 10Jforrester: [C: 031] "See question." (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284679 (owner: 10Esanders) [16:52:46] 10VisualEditor, 10OOjs-UI: [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title", also cursor is not appearing on that line automatically - https://phabricator.wikimedia.org/T133227#2227810 (10matmarex) I feel like we've broken this at least once in the past… The issue is not a... [16:56:44] 10VisualEditor, 06Community-Liaisons: please enable edit, edit source on mediawiki.org - https://phabricator.wikimedia.org/T132760#2227813 (10wctaiwan) 05Open>03declined For anonymous users, it remembers the last editor chosen. In VisualEditor, you can switch to source editing by clicking on the "[[ ]]" ic... [17:07:42] Krenair: er, more details? [17:07:59] legoktm, I don't know what they're talking about [17:52:48] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.17.0), 13Patch-For-Review: [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title", also cursor is not appearing on that line automatically - https://phabricator.wikimedia.org/T133227#2228023 (10Jdforrester-WMF) [17:52:53] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.17.0), 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title", also cursor is not appearing on that line automatically - https://phabricator.wikimedia.org/T133227#2225686 (10Jdforrester-WMF) 05Open... [18:07:21] 10VisualEditor, 10Parsoid: Unified extension registration mechanism for core/VE/Parsoid. - https://phabricator.wikimedia.org/T133320#2228090 (10cscott) [18:17:09] (03CR) 10Jforrester: Allow extensions to support extra namespaces and content models (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 (owner: 10Esanders) [18:24:42] 10VisualEditor, 10Parsoid: Unified extension registration mechanism for core/VE/Parsoid. - https://phabricator.wikimedia.org/T133320#2228139 (10Arlolra) p:05Triage>03Normal [18:53:19] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.17.0), 07Verified, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title", also cursor is not appearing on that line automatically - https://phabricator.wikimedia.org/T133227#2228284 (10Ryasmeen) [18:53:44] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.17.0), 07Verified, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title", also cursor is not appearing on that line automatically - https://phabricator.wikimedia.org/T133227#2225686 (10Ryasmeen) C... [18:53:59] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.17.0), 07Verified, 05WMF-deploy-2016-04-26_(1.27.0-wmf.22): [Regression pre-wmf.22] Double check mark appearing next to "Heading" and "Page Title" - https://phabricator.wikimedia.org/T133227#2228291 (10Ryasmeen) [19:23:59] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (bf91965) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284616 (owner: 10Jforrester) [19:29:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (bf91965) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284616 (owner: 10Jforrester) [20:07:10] (03PS2) 10Esanders: Create MW targets using a factory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284679 [20:07:12] (03PS3) 10Esanders: Allow extensions to support extra namespaces and content models [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 [20:07:14] (03PS2) 10Esanders: Add method that runs after activation, for overriding [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284713 [20:23:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-ProofreadPage, and 4 others: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#2228508 (10jayvdb) Is it safe to assume this feature will not suddenly beco... [21:24:33] 10VisualEditor, 10TPG-Essential-Functions, 06Team-Practices, 07Epic, 15User-JAufrecht: [EPIC] Run Service Level Understanding exercise between VE and Research & Data - https://phabricator.wikimedia.org/T128932#2229004 (10JAufrecht) [21:24:36] 10VisualEditor, 10TPG-Essential-Functions, 06Team-Practices, 07Epic, 15User-JAufrecht: [EPIC] Run Service Level Understanding exercise between VE and Research & Data - https://phabricator.wikimedia.org/T128932#2090517 (10JAufrecht) [22:17:20] (03CR) 10Jforrester: [C: 032] Create MW targets using a factory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284679 (owner: 10Esanders) [22:17:53] (03CR) 10Jforrester: [C: 031] Add method that runs after activation, for overriding (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284713 (owner: 10Esanders) [22:25:40] (03Merged) 10jenkins-bot: Create MW targets using a factory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284679 (owner: 10Esanders) [23:13:20] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 3 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2156848 (10Deskana) This makes a lot of sense for articles. Th... [23:17:19] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 3 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2229477 (10Jdforrester-WMF) >>! In T131132#2229472, @Deskana w... [23:22:33] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 3 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2229488 (10Deskana) >>! In T131132#2229477, @Jdforrester-WMF w... [23:40:36] (03Abandoned) 10Jforrester: [WIP] Make it possible for extensions to set which content models VE uses [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281109 (owner: 10Jforrester)