[00:22:54] (03PS1) 10Alex Monk: [WIP] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 [00:25:10] James_F, should we have a ticket about reviewing anything saying 'beta' in VE? :) [00:26:22] Krenair: Maybe. :-) [00:26:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 (owner: 10Alex Monk) [00:28:14] (03PS2) 10Alex Monk: [WIP] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 [00:32:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 (owner: 10Alex Monk) [00:33:24] (03PS3) 10Alex Monk: [WIP] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 [00:36:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 07Design: "Fall back to wikitext" does nothing on URL input - https://phabricator.wikimedia.org/T133681#2250401 (10AlexMonk-WMF) It doesn't necessarily change much with all types of inputs. You will loose URL validation if you fa... [00:37:23] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 (owner: 10Alex Monk) [00:39:27] (03PS4) 10Alex Monk: [WIP] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 [00:52:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 07Design: "Fall back to wikitext" does nothing on URL input - https://phabricator.wikimedia.org/T133681#2250457 (10AlexMonk-WMF) That said this feature misbehaves in several ways [08:43:33] 10VisualEditor, 10Kartographer: Map not centred on first load - https://phabricator.wikimedia.org/T133972#2250739 (10Esanders) [09:02:34] 10VisualEditor, 07Community-consensus-needed, 07Epic, 07I18n: Provide some form of image filter to not show 'unexpected' images in image search unless the user opts-in - https://phabricator.wikimedia.org/T121613#2250803 (10Danny_B) [09:10:24] 10VisualEditor, 07Browser-Support-Internet-Explorer: Right click to paste doesn't work in IE9 - https://phabricator.wikimedia.org/T133097#2250816 (10Danny_B) [09:11:40] 10WikiEditor, 07Browser-Support-Internet-Explorer: Search & Replace: Non-regex mode with regex characters like [^ ] fails in IE8 - https://phabricator.wikimedia.org/T23051#2250823 (10Danny_B) [09:41:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, and 2 others: Add sort-by-number Magic Word for cats - https://phabricator.wikimedia.org/T133974#2250859 (10Dvorapa) [10:14:06] 10VisualEditor, 10VisualEditor-MediaWiki: Suggest case insensitive results when searching for categories to add - https://phabricator.wikimedia.org/T59302#619774 (10Pols12) It is a strange behaviour because we attempt it works like article searching. The article search engine has been currently improved to bec... [10:18:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, and 2 others: Add sort-by-number Magic Word for cats - https://phabricator.wikimedia.org/T133974#2250964 (10Danny_B) 05Open>03stalled There is already some request for numerical sorting (@DannyH : Can you perhaps close th... [10:21:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, and 2 others: Enable numeric sort for category members - https://phabricator.wikimedia.org/T133974#2250969 (10Blahma) 05stalled>03Open [10:22:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, and 2 others: Enable numeric sort for category members - https://phabricator.wikimedia.org/T133974#2250859 (10Blahma) 05Open>03stalled [10:25:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, and 2 others: Enable numeric sort for category members - https://phabricator.wikimedia.org/T133974#2250981 (10Danny_B) Technical note: due to its nature it would have to be behavior switch (eg. `__NUMSORT__`) and not template... [10:26:44] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2250983 (10Halibutt) [10:28:01] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2250998 (10Halibutt) [10:28:56] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2250983 (10Halibutt) [10:35:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251005 (10Danny... [10:38:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10MediaWiki-Page-editing, 10MediaWiki-extensions-ProofreadPage: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251012 (10Danny... [10:42:41] 10VisualEditor, 10MediaWiki-User-preferences: Split up editor preferences into VE and source parts - https://phabricator.wikimedia.org/T133287#2251020 (10Danny_B) Keep in mind that there can be various number of editors (Wikimedia sites ATM use four in default plus some of those sites have some additional due... [10:51:50] 10VisualEditor, 10Wikimedia-Site-requests: Enable Visual Editor on all namespaces of Polish Wikipedia - https://phabricator.wikimedia.org/T133980#2251052 (10Halibutt) [12:17:43] 10VisualEditor, 10Wikimedia-Site-requests: Enable Visual Editor on all namespaces of Polish Wikipedia - https://phabricator.wikimedia.org/T133980#2251130 (10Urbanecm) p:05Triage>03Normal a:03Urbanecm I'll do it with T133978. [12:19:46] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2251140 (10Urbanecm) p:05Triage>03Normal a:03Urbanecm I'll take care about it with T133980. [13:46:02] (03PS1) 10Esanders: Update active link on touch end events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/286157 [13:48:35] (03PS2) 10Esanders: Update active link on touch end events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/286157 [13:54:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor: Add the "welcome" dialog (with button to switch) to the wikitext editor - https://phabricator.wikimedia.org/T133800#2251319 (10Elitre) >>! In T133800#2249704, @AlexMonk-WMF wrote: > I don't think the part about the preferences dialog is accurate. How s... [13:54:54] 10VisualEditor, 10Wikimedia-Site-requests: Enable Visual Editor on all namespaces of Polish Wikipedia - https://phabricator.wikimedia.org/T133980#2251320 (10Halibutt) Thanks! [13:55:12] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2251321 (10Halibutt) ...and thanks here as well :) [13:58:19] 10VisualEditor, 10Wikimedia-Site-requests: Enable Visual Editor on all namespaces of Polish Wikipedia - https://phabricator.wikimedia.org/T133980#2251322 (10Urbanecm) @Halibutt I am not sure if you want to enable VE on really all namespaces (including MediaWiki: and Template:). List of namespaces with enable... [14:00:29] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2251330 (10Urbanecm) You're welcome. Do you want to enable it on all namespaces with VE (including the added in T133980) or only on some of them? Thanks you for reply [14:42:59] (03CR) 10Esanders: [C: 04-1] "Shouldn't this commit address the fact the buttons in the find and replace dialog and not tab-accessible?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/282964 (https://phabricator.wikimedia.org/T129792) (owner: 10DLynch) [14:54:00] (03CR) 10Esanders: ve.ui.TabbableElements: JS replacement for unreliable tabIndex (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/282964 (https://phabricator.wikimedia.org/T129792) (owner: 10DLynch) [15:06:08] James_F: is there any reason we use namespace ids instead of canonical names? [15:06:34] edsanders: In JSON? [15:06:55] yeah, AvailableNamespaces [15:07:44] Well, I don't know if that works. [15:07:52] it works if we make it work [15:08:10] i.e. compare to the current namespace's canonical name instead of id [15:08:46] Well, yes. [15:08:58] But it's in a JSON file read by the extension registration system. [15:08:59] it seems more sensible - and allows extensions to add support for namespace via name [15:09:09] If we pass it a string "NS_FILE" won't it break? [15:09:19] those are constants [15:09:23] Do we have to do some magic to evaluate a string as a constant? [15:09:24] the canonical name would be "File" [15:09:44] Is there a function that maps from a string to the constant? [15:09:46] we just read that value in our PHP and compare it to the current namespace [15:10:09] I thought the constants were just numbers. [15:10:13] AvailableNamespaces is a VE feature - nothing to do with core [15:10:20] well they are - but I'm not suggesting we use the constants [15:10:39] This way VE has to know about the string name of every namespace, though? [15:11:03] instead of { "2": true, "14": true } you'd have { "Main": true, "Category": true } [15:11:28] atm it says is "title.getNamespaceId in availableNamespaceIds" [15:11:51] you'd just change that test to "title.getCanonicalNamespaceName in avialableNamespaces" [15:12:15] Is the canonical name always in English? [15:12:20] yes [15:12:33] Hmm. In that case, yeah, that could work. [15:12:40] Want me to add it? [15:13:00] https://www.mediawiki.org/wiki/Help:Namespaces#Localisation [15:13:15] I'll do - we check it in about 4 places [15:13:19] Kk. [15:13:25] Don't do it as a breaking change. [15:13:26] We can either allow mixed: [15:13:34] { "2": true, "Category": true { [15:13:38] We'll need B/C so we can fix WMF config over. [15:13:43] or we can create a new config var and deprecate the old one [15:13:45] Typeof check? Yeah. [15:13:58] "VisualEditorAvailableNamespaceNames" [15:14:09] Allow mixed for a bit, deprecate numbers, then remove later. [15:14:32] Do config-defined namespaces have a canonical name? [15:16:13] Aha, yes. [15:16:55] It'll simplify https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L13417 a bit. [15:19:34] 10WikiEditor, 07Tracking: WikiEditor issues (tracking) - https://phabricator.wikimedia.org/T26493#2251453 (10Jdforrester-WMF) [15:23:14] 10VisualEditor, 10Wikimedia-Site-requests: Enable Visual Editor on all namespaces of Polish Wikipedia - https://phabricator.wikimedia.org/T133980#2251466 (10Urbanecm) [15:23:18] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2251467 (10Urbanecm) [15:25:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 06Editing-Department, and 3 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251475 (10Jdforrester-WMF) >>! In T132897#22... [15:40:02] (03CR) 10Jforrester: "Let's do it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/275931 (https://phabricator.wikimedia.org/T45037) (owner: 10Tchanders) [15:40:40] (03CR) 10Jforrester: [C: 031] Update active link on touch end events [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/286157 (owner: 10Esanders) [15:42:54] (03CR) 10Jforrester: [C: 04-1] "Needs rebasing." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/283591 (https://phabricator.wikimedia.org/T116406) (owner: 10Alex Monk) [15:53:15] (03CR) 10DLynch: Update active link on touch end events (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/286157 (owner: 10Esanders) [15:56:27] (03CR) 10DLynch: "You mean the next/previous and the options buttons? Do you think they should be in-sequence after "Done", perhaps?" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/282964 (https://phabricator.wikimedia.org/T129792) (owner: 10DLynch) [15:56:49] (03PS6) 10DLynch: ve.ui.TabbableElements: JS replacement for unreliable tabIndex [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/282964 (https://phabricator.wikimedia.org/T129792) [16:03:19] (03PS1) 10Esanders: [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286173 [16:07:33] (03CR) 10Bartosz Dziewoński: [C: 031] "I didn't review in detail, but the idea looks solid." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/282964 (https://phabricator.wikimedia.org/T129792) (owner: 10DLynch) [16:08:49] (03CR) 10jenkins-bot: [V: 04-1] [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286173 (owner: 10Esanders) [16:09:30] edsanders: Ha. 105 character line in PHP. [16:09:36] edsanders: Want me to fix and merge? [16:09:42] I'll fix it [16:09:53] Kk. [16:12:39] (03PS5) 10Esanders: Allow extensions to support extra namespaces and content models [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 [16:12:41] (03PS2) 10Esanders: [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286173 [16:13:18] I don't know where the per-wiki config files live - you can update those though [16:19:09] (03CR) 10Jforrester: [C: 031] [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286173 (owner: 10Esanders) [16:25:29] What do we gain by using the names instead of IDs? [16:43:42] Krenair: ProofreadPage uses a different NS ID on each wiki in production, because it was deployed… poorly. [16:44:51] ugh [16:45:11] and I suppose we can't schedule wikisource downtime to fix it? [16:45:48] We could. [16:45:55] But it's been this way for a decade. [16:45:59] If you want to fix it… [17:00:23] 10VisualEditor, 10Kartographer, 13Patch-For-Review: Map not centred on first load - https://phabricator.wikimedia.org/T133972#2251669 (10JGirault) [17:07:50] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10BlueSpice, and 14 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251705 (10Danny_B) Per IRC discussion with @Jdforres... [17:08:27] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 06Editing-Department, and 3 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2251729 (10Danny_B) [17:08:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10BlueSpice, and 14 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251728 (10Danny_B) [17:10:45] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 06Editing-Department, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2251737 (10Danny_B) [17:19:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10BlueSpice, and 15 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251741 (10Danny_B) [17:20:36] (03PS6) 10Esanders: Allow extensions to support extra namespaces and content models [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 [17:20:38] (03PS3) 10Esanders: [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286173 [17:36:57] (03CR) 10Jforrester: [C: 031] [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286173 (owner: 10Esanders) [17:37:06] (03CR) 10Jforrester: [C: 031] Allow extensions to support extra namespaces and content models [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/284680 (owner: 10Esanders) [18:44:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10BlueSpice, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2251921 (10Mattflaschen) Flow does not provide a gene... [19:12:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10BlueSpice, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2213480 (10jayvdb) Ideally I can use different regist... [19:49:21] (03PS1) 10Esanders: Support category pages by default and show category lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286208 [20:15:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 10BlueSpice, and 17 others: Create Special:MyEditor shortcut for the user's current editor, to allow linking VE, wikitext, ProofreadPage, etc. help pages - https://phabricator.wikimedia.org/T132897#2252081 (10Blahma) The original feature request was t... [21:22:09] (03CR) 10Jforrester: "Dupe-ish of Ic6582c0b2?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286208 (owner: 10Esanders) [21:28:18] (03CR) 10Esanders: "Yeah - that patch is ancient. Also this has a core dependency that makes life easier. Will add." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286208 (owner: 10Esanders) [21:35:32] (03PS2) 10Esanders: Support category pages by default and show category lists [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286208 [21:41:53] (03CR) 10Jforrester: "Worth doing for File: pages too? If yes, tag with T58289?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286208 (owner: 10Esanders) [21:42:08] (03Abandoned) 10Jforrester: [WIP] Show non-editable parts of pages in their normal places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/171155 (https://bugzilla.wikimedia.org/56289) (owner: 10Alex Monk) [21:49:47] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#2252477 (10Mvolz) [21:51:59] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#2252484 (10Mvolz) Is there a way to find out which wikis have citoid enabled? Or does anyone... [21:58:18] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#2252489 (10Mvolz) [21:59:23] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1697925 (10Mvolz) [22:08:35] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#2252502 (10Mvolz) [22:09:32] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated. - https://phabricator.wikimedia.org/T114515#1697925 (10Mvolz) [22:41:35] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 06Discovery: Search results for internal links in VisualEditor frequently ignore the exact match if it's a redirect - https://phabricator.wikimedia.org/T126852#2025091 (10Deskana) {F3947638} {F3947640} It's at the bottom of the list, there. (The results are... [22:46:59] 10VisualEditor: VisualEditor link inspector sorts results in incorrect order - https://phabricator.wikimedia.org/T134020#2252768 (10Deskana) [22:47:22] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 06Discovery: Search results for internal links in VisualEditor frequently ignore the exact match if it's a redirect - https://phabricator.wikimedia.org/T126852#2252781 (10Deskana) >>! In T126852#2252765, @Deskana wrote: > (The results are also in the wrong orde... [23:39:23] 10VisualEditor, 10Wikimedia-Site-requests: Enable user signature in VE in Polish Wikipedia - https://phabricator.wikimedia.org/T133978#2252890 (10Halibutt) All of them. We have reviewed versions enabled on pl wiki anyway, so the risk of new users and anons signing their names everywhere in the mainspace is min...