[00:00:17] (03PS1) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 0.7.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/287867 [00:24:50] (03CR) 10Jforrester: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.7.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/287867 (owner: 10Legoktm) [00:35:41] 10VisualEditor, 10VisualEditor-CopyPaste, 07Regression, 05WMF-deploy-2016-05-08_(1.28.0-wmf.1): [Regression] data-ve-clipboard-key span inserted in page - https://phabricator.wikimedia.org/T134680#2279171 (10Jdforrester-WMF) [00:38:12] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.7.1 [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/287867 (owner: 10Legoktm) [01:08:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests, 13Patch-For-Review: Centralize feedback for the visual editor at the Hindi Wikipedia - https://phabricator.wikimedia.org/T134789#2279215 (10Jdforrester-WMF) p:05Triage>03Normal a:03Jdforrester-WMF [01:10:37] 10VisualEditor, 10VisualEditor-ContentEditable, 07Regression: [Regression pre-wmf.17] The highlight and the context menu for a node stays at the previous position after repositioning it - https://phabricator.wikimedia.org/T129541#2279232 (10Jdforrester-WMF) [01:14:02] 10VisualEditor, 06Discovery, 10Maps, 07Regression: [Regression wmf.21] Map loads partially when opening the Insert dialog - https://phabricator.wikimedia.org/T132623#2204680 (10Jdforrester-WMF) p:05Triage>03Normal [01:14:48] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Internet-Explorer: VisualEditor: Can't create new paragraph by hitting return in IE9(?) - https://phabricator.wikimedia.org/T65038#664153 (10Jdforrester-WMF) [01:15:05] 10VisualEditor, 10VisualEditor-MediaWiki, 07Browser-Support-Internet-Explorer: VisualEditor: Save page dialog's edit summary text box is black in Internet Explorer 11 - https://phabricator.wikimedia.org/T74917#775331 (10Jdforrester-WMF) [01:15:49] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-API, 07Easy: ApiTemplateData implements ApiBase::getCustomPrinter for no good reason - https://phabricator.wikimedia.org/T91455#2279256 (10Jdforrester-WMF) [01:16:06] 10Citoid, 10VisualEditor, 10Security-Reviews, 06Security-Team: Security review of Citoid - https://phabricator.wikimedia.org/T98096#1259357 (10Jdforrester-WMF) [01:19:51] 10VisualEditor, 10Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#2279269 (10Jdforrester-WMF) 05Resolved>03Open p:05Low>03High Argh. You removed the restriction on who could move things around on the #VisualEditor workboard which we had... [01:26:32] 10VisualEditor, 10VisualEditor-MediaWiki: "You have switched to source editing" pop-up looks ugly on de.wiki - https://phabricator.wikimedia.org/T129075#2279293 (10Jdforrester-WMF) 05Open>03Resolved a:03AlexMonk-WMF Currently looks like this: {F3989035} So, yes, Resolved. [01:27:09] 10VisualEditor, 10VisualEditor-MediaWiki: Fix arwiki's edit notice hacks to use enwiki's hack, so that it doesn't show up as "One notice" but blank - https://phabricator.wikimedia.org/T129773#2116031 (10Jdforrester-WMF) 05Open>03stalled [01:28:58] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-CopyPaste, 10VisualEditor-Tables: Alien tables: copy / paste causes errors - https://phabricator.wikimedia.org/T124933#1970385 (10Jdforrester-WMF) [01:29:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-UniversalLanguageSelector, 13Patch-For-Review: Integrate jQuery IME control with the VE toolbar - https://phabricator.wikimedia.org/T126125#2279309 (10Jdforrester-WMF) p:05Low>03Normal a:03dchan [01:30:29] 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-EditingTools, 07Design: Allow editors to add and see existing soft hypen (­) non-visible characters where needed - https://phabricator.wikimedia.org/T134269#2260354 (10Jdforrester-WMF) This will need a similar treatment to how we'll need to... [01:32:14] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Tables: Table row context menu is invisible in mobile VE-MW, at least sometimes - https://phabricator.wikimedia.org/T127432#2279317 (10Jdforrester-WMF) [01:51:43] 10VisualEditor, 10Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#2279359 (10Krenair) I think that restriction had already been removed by a Phabricator update actually. That edit policy should never have been allowed. [02:06:02] 10VisualEditor, 10Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#2279367 (10Jdforrester-WMF) >>! In T119622#2279359, @Krenair wrote: > Where was the agreement about this? In the Bugzilla -> Phabricator migration discussions. [06:30:29] 10VisualEditor, 10Parsoid, 10RESTBase: data-parsoid of the wrong render being passed to Parsoid causing intermittent corruptions on saves - https://phabricator.wikimedia.org/T134593#2279557 (10mobrovac) >>! In T134593#2279039, @GWicke wrote: > A patch for the sanity check is now up at https://github.com/wiki... [09:51:41] 10VisualEditor, 10Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#2279862 (10Aklapper) >>! In T119622#2279269, @Jdforrester-WMF wrote: > Argh. You removed the restriction on who could move things around on the #VisualEditor workboard which we h... [10:19:29] 10VisualEditor: Converting a page to a redirect through VisualEditor should remove the existing categories if there is no other content - https://phabricator.wikimedia.org/T134858#2279942 (10geraki) [10:53:39] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Wikimania-Hackathon-2016, 06Community-Liaisons (Apr-Jun-2016): Consider helping some smaller Wikipedias' communities (which?) by writing the TemplateData to enable citoid for them - https://phabricator.wikimedia.org/T127354#2280033 (10Qgil) [10:58:02] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): CLs to socialize the Save/Publish change - https://phabricator.wikimedia.org/T134580#2280045 (10Qgil) p:05Triage>03Normal This task is going on, so I am assuming Normal priority. Feel free to rectify. [12:07:01] Hi all! i'm developing a gadget / extension but I can't understand how to add datas i retrieved from an external API into the page. I want to add popups (like inspectors) so editors can decide if they want to add those informations or not (like inspectors for links that have delete / edit). Except for the buttons and the data no there must be nothing else (i mean, no input text for example), just validation, i want it [12:11:20] I already coded the api calls, the dialog tool and so on. I'm able to add popup-widgets in the panels of the dialog, but I don't know how to "trasform" them into inspectors. I coded a DataModel too, inherit from ve.dm.annotation...what's still unclear is how to add my annotation into the page [12:25:12] 10VisualEditor, 10VisualEditor-Initialisation: VisualEditor: Gracefully handle when available browser UI features are disabled (rather than refusing to load) - https://phabricator.wikimedia.org/T54008#2280335 (10Esanders) 05Open>03declined This little used extension kills APIs that are essential for VE to... [12:39:37] 10VisualEditor, 10VisualEditor-Initialisation: VisualEditor: Gracefully handle when available browser UI features are disabled (rather than refusing to load) - https://phabricator.wikimedia.org/T54008#539737 (10TheDJ) @Esanders I agree, but perhaps we should also be better about error handling in general when... [12:41:22] 10VisualEditor, 10VisualEditor-EditingTools, 06Collaboration-Team-Interested, 10Flow: "Insert a link" popup is too slow after typing [[ in visual mode - https://phabricator.wikimedia.org/T107793#2280407 (10Esanders) 05Open>03declined '[[' is a helper shortcut to open the link dialog, you still need to... [12:56:02] 10VisualEditor, 10VisualEditor-Initialisation: VisualEditor: Gracefully handle when available browser UI features are disabled (rather than refusing to load) - https://phabricator.wikimedia.org/T54008#2280468 (10jayvdb) 05declined>03Open People disable these features for good reason; a nice error message,... [12:58:44] 10VisualEditor, 07Regression: [Regression wmf.23] Cannot switch to Read tab from VE, getting error "this.emit is not a function" - https://phabricator.wikimedia.org/T134794#2280487 (10Ryasmeen) [13:04:24] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Transclusion dialog's "Add more information" button responds to right-click but should not - https://phabricator.wikimedia.org/T71230#2280508 (10Ryasmeen) 05Open>03Resolved [13:11:16] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749049 (10Thomas_Shafee) Copied from a sh... [13:15:20] 10VisualEditor, 10VisualEditor-MediaWiki: after switching from source to visual editing, #mw-content-text loses lang and dir attributes - https://phabricator.wikimedia.org/T123148#1922350 (10Esanders) Works fine for me. Checked the code as well: all we do is empty mw-content-text and replace its contents, but... [13:44:55] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 07Performance: Draw VisualEditor's non-CE block highlights using SVG polygons - https://phabricator.wikimedia.org/T53202#2280692 (10Esanders) In order to prevent the SVG canvas (a bounding rectangle) from capturing click events we'... [14:49:12] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Facilitate deployment of the visual editor at the Japanese Wikipedia - https://phabricator.wikimedia.org/T134147#2280951 (10Elitre) We have agreed that the rollout starts on Wednesday 11th when it's morning in Japan, and it affects registered editors this ti... [15:32:27] (03PS1) 10DLynch: Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) [15:35:39] (03CR) 10jenkins-bot: [V: 04-1] Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [15:37:18] (03PS2) 10DLynch: Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) [15:39:36] (03CR) 10jenkins-bot: [V: 04-1] Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [15:39:46] (03PS3) 10DLynch: Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) [15:40:15] Apparently I picked up a bad habit of adding too many newlines at some point while writing that patch. [15:44:19] 10Cite, 10ArchCom-RfC, 10Internet-Archive, 10Parsoid, and 4 others: WIP RFC: Reference API requirements and options - https://phabricator.wikimedia.org/T130663#2281217 (10Jdforrester-WMF) >>! In T130663#2155297, @Cenarium wrote: > By "static block of limited usefulness", I mean that when a reference is cha... [15:48:29] (03CR) 10Jforrester: Insert undo breakpoints at word breaks (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [15:48:47] Kemayo: :-) [15:49:04] Kemayo: If you use Atom or Sublime, they can run jscs for you and complain before you ever commit. [15:49:34] I do, and I even have that normally working. It apparently didn't want to tell me about that particular problem, though. I suppose I should debug it [15:49:39] Hmm. [15:49:45] Do you have an old version? [15:50:47] We're using grunt-jscs v2.8.0, which uses jscs 2.11.0 [15:51:25] I do have an older version of that. I'll update it and see if that starts complaining properly. [15:51:35] * James_F nods. [15:55:56] (03CR) 10DLynch: Insert undo breakpoints at word breaks (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [15:56:04] (03PS4) 10DLynch: Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) [15:59:18] (03CR) 10Jforrester: Insert undo breakpoints at word breaks (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [15:59:29] (03CR) 10Jforrester: [C: 031] Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [16:04:29] (03CR) 10Esanders: [C: 04-1] "I probably should've mentioned our UnicodeJS library..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [16:05:14] Kemayo: did you see UnicodeJS or were you unaware of it? [16:05:28] I actually didn't realize we had it included. [16:06:20] well we wrote it for VE :) [16:06:52] it abstracts strings as arrays so you can run it directly against linmod data [16:06:55] I see that unicodeJS.wordbreak.isBreak is pretty relevant, certainly. [16:07:11] :) [16:07:28] sorry, I forget which bits I haven't told you about [16:08:21] Oh, hah. [16:08:24] see ve.dm.Document:1397 [16:28:03] 10VisualEditor, 10Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#2281456 (10Jdforrester-WMF) >>! In T119622#2279862, @Aklapper wrote: >>>! In T119622#2279269, @Jdforrester-WMF wrote: >> Argh. You removed the restriction on who could move thing... [16:28:58] 10VisualEditor, 10VisualEditor-MediaWiki: after switching from source to visual editing, #mw-content-text loses lang and dir attributes - https://phabricator.wikimedia.org/T123148#2281469 (10Jdforrester-WMF) 05Open>03stalled [16:29:11] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-Performance, 07Performance: Draw VisualEditor's non-CE block highlights using SVG polygons - https://phabricator.wikimedia.org/T53202#2281474 (10Jdforrester-WMF) 05Open>03stalled [16:33:09] 10VisualEditor, 10VisualEditor-ContentLanguage: Link cartouches interfere with browsers' word break algorithms - https://phabricator.wikimedia.org/T134571#2281502 (10dchan) There may be no feasible fix for this. The cause is that the browser marks a break opportunity on either side of each img, as if it were... [16:33:52] (03PS5) 10DLynch: Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) [16:34:19] (03PS1) 10Esanders: Unify action test runners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287990 (https://phabricator.wikimedia.org/T90370) [16:37:12] 10VisualEditor: Punctuation after end line link should not be isolated in the next line - https://phabricator.wikimedia.org/T125454#1987869 (10dchan) I think this is a special case of T134571 , and will be hard to fix for the reasons given there. (Sadly, we can't set display:none on the img elements, because we... [16:38:07] 10VisualEditor, 10VisualEditor-MediaWiki, 07Browser-Support-Firefox: VisualEditor: Keyboard shortcut to access VE (Alt+Shift+v) is not working from action=edit in FF browser - https://phabricator.wikimedia.org/T69218#2281518 (10Tacsipacsi) [16:38:09] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Wikitext editor's keyboard shortcut for show changes (shift+alt+v) no longer works - https://phabricator.wikimedia.org/T54701#576358 (10Tacsipacsi) [16:49:59] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 06Parsing-Team, 06Services: Clarify data requirements for basic VE rendering - https://phabricator.wikimedia.org/T130873#2149240 (10Jdforrester-WMF) a:03Esanders Ed, could you detail this for Services please? [16:56:28] (03CR) 10Jforrester: "The typed "foo a bar" is only two transactions with this, of course. Still, it's noticeably better." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [16:58:48] (03CR) 10Jforrester: [C: 032] "Simplicity." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287990 (https://phabricator.wikimedia.org/T90370) (owner: 10Esanders) [16:59:14] 10VisualEditor, 07Technical-Debt, 05WMF-deploy-2016-05-15_(1.28.0-wmf.2): Factor out code duplication in ve.ui.*Action tests - https://phabricator.wikimedia.org/T90370#2281631 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [17:00:43] (03CR) 10DLynch: "I could perhaps add some special-cases for single-character words." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [17:00:49] (03Merged) 10jenkins-bot: Unify action test runners [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287990 (https://phabricator.wikimedia.org/T90370) (owner: 10Esanders) [17:02:54] (03CR) 10Divec: [C: 04-1] Insert undo breakpoints at word breaks (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) (owner: 10DLynch) [17:11:28] edsanders, Krenair: VE is still sending about 60 html2wt requests per 24 hours that are missing an If-Match header [17:12:58] gwicke, do you know which wikis they're coming from? [17:13:19] yes, see https://logstash.wikimedia.org/#dashboard/temp/AVSbqItO0z-7ykXOH3V3 [17:13:32] all the big wikis [17:14:25] if-match null, interesting [17:15:24] the rate hasn't changed much over the last week [17:15:40] is there a ticket for this? [17:15:50] but, it could hide other issues [17:15:51] or is it that existing one involving normalisation issues? [17:16:08] I noticed this in the context of that investigation, yes [17:16:25] okay. I'm going to go and have dinner now but I'll look at it as soon as I'm back [17:16:33] 10VisualEditor, 10Parsoid, 10RESTBase: data-parsoid of the wrong render being passed to Parsoid causing intermittent corruptions on saves - https://phabricator.wikimedia.org/T134593#2281719 (10GWicke) Some more data: - So far, no mis-matches between `If-Match` header and mw:TimeUuid were logged. - VE is sti... [17:16:39] just updated the task ^^ [17:16:51] yeah, that's the one I was thinking about [17:17:57] basically, is there any chance that an outdated HTML head could be sent from VE to RB on repeat edits? [17:28:06] (03PS1) 10Bartosz Dziewoński: ve.ui.MWParameterPage: Remove non-working 'focus' handler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/287994 [17:28:41] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Transclusion dialog's "Add more information" button responds to right-click but should not - https://phabricator.wikimedia.org/T71230#2281784 (10matmarex) >>! In T71230#2278157, @matmarex wrote: > The `
` has a 'focus' h... [17:30:32] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 06Parsing-Team, 06Services: Clarify data requirements for basic VE rendering - https://phabricator.wikimedia.org/T130873#2281790 (10Esanders) This would be fairly disruptive to the code and user interaction as we assume everywhere that the document is ful... [17:34:10] 10VisualEditor, 10Phabricator: Fix edit permissions of VisualEditor Phabricator projects - https://phabricator.wikimedia.org/T119622#2281794 (10Aklapper) >>! In T119622#2281456, @Jdforrester-WMF wrote: > Sorry, being unclear; "move things around" as in "make new columns and move them around". Ah, correct: "Ed... [18:07:20] 10VisualEditor, 10Parsoid, 10RESTBase: Intermittent corruptions on saves, likely related to data-parsoid mis-matches - https://phabricator.wikimedia.org/T134593#2281973 (10GWicke) [18:20:36] 10VisualEditor, 10Parsoid, 10RESTBase: Intermittent corruptions on saves, likely related to data-parsoid mis-matches - https://phabricator.wikimedia.org/T134593#2282041 (10GWicke) @Bgwhite, have you seen new instances of this issue in the last 24 hours? [18:37:50] 10VisualEditor, 10VisualEditor-MediaWiki: after switching from source to visual editing, #mw-content-text loses lang and dir attributes - https://phabricator.wikimedia.org/T123148#2282136 (10Amire80) [18:38:45] 10VisualEditor, 10VisualEditor-MediaWiki: after switching from source to visual editing, #mw-content-text loses lang and dir attributes - https://phabricator.wikimedia.org/T123148#1922350 (10Amire80) My bad! I should have properly emphasized that this happens after editing in wiki syntax and then switching to... [18:53:30] 10VisualEditor: Plan activities for VE offsite - https://phabricator.wikimedia.org/T134919#2282234 (10JAufrecht) [18:54:18] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2282253 (10Quiddity) Here's an idea (rough... [19:05:45] 10VisualEditor: Plan activities for VE offsite - https://phabricator.wikimedia.org/T134919#2282305 (10Jdforrester-WMF) p:05Triage>03High [19:06:45] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: Converting a page to a redirect through VisualEditor should (ask if it's OK to?) remove the existing categories/options if there is no other content - https://phabricator.wikimedia.org/T134858#2282311 (10Jdforrester-WMF) p:05Triage>03Lowest [19:08:01] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression: [Regression wmf.23] Cannot switch to Read tab from VE, getting error "this.emit is not a function" - https://phabricator.wikimedia.org/T134794#2282316 (10Jdforrester-WMF) p:05Triage>03High [19:09:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-UniversalLanguageSelector, 10OOjs-UI: jQuery.IME's Ctrl+Enter keyboard shortcut conflicts with OOUI's Ctrl+Enter keyboard shortcut - https://phabricator.wikimedia.org/T134664#2282321 (10Jdforrester-WMF) p:05Triage>03Low [19:11:27] 10Citoid, 10VisualEditor: Tests with 3 sources covered in Zotero - https://phabricator.wikimedia.org/T129858#2282330 (10Jdforrester-WMF) 05Open>03Invalid I think this is indeed a set of upstream issues. [19:12:16] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki: Problems with JAMA Network urls in Citoid - https://phabricator.wikimedia.org/T134698#2282335 (10Jdforrester-WMF) p:05Triage>03Low [19:12:48] 10VisualEditor, 10Flow: "TypeError: cur is null" when pasting a string of text on a Flow page with VE enabled - https://phabricator.wikimedia.org/T134679#2282341 (10Jdforrester-WMF) 05Open>03stalled [19:13:12] 10VisualEditor, 10Flow: CRTL+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2282343 (10Jdforrester-WMF) 05Open>03stalled [19:13:34] 10VisualEditor, 10VisualEditor-MediaWiki: VE->WTE switch gets stuck on errors - https://phabricator.wikimedia.org/T134333#2282344 (10Jdforrester-WMF) p:05Triage>03High [19:16:30] 10VisualEditor, 10MediaWiki-extensions-LocalisationUpdate, 06Release-Engineering-Team: Visualeditor-mweditmodewt-popup-title not updated in the Hebrew Wikipedia, even though it was translated - https://phabricator.wikimedia.org/T134072#2282352 (10Jdforrester-WMF) https://he.wikipedia.org/wiki/%D7%9E%D7%93%D7... [19:16:55] 10VisualEditor, 10MediaWiki-extensions-LocalisationUpdate, 06Release-Engineering-Team: i18n string not updated in the Hebrew Wikipedia, even though it was translated - https://phabricator.wikimedia.org/T134072#2282354 (10Jdforrester-WMF) p:05Triage>03High [19:18:00] 10VisualEditor: VisuaEditor popup for single tab is too small - https://phabricator.wikimedia.org/T128909#2282357 (10Jdforrester-WMF) p:05Triage>03Lowest [19:19:23] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, and 2 others: (regression) Enable every citation to be editable as basic citation - https://phabricator.wikimedia.org/T134183#2282364 (10Jdforrester-WMF) p:05Triage>03Low [19:26:52] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Enable single edit tab on enwiki - https://phabricator.wikimedia.org/T128478#2282411 (10Jdforrester-WMF) [19:26:54] 10VisualEditor, 10VisualEditor-MediaWiki: Enwiki is a wikitext-primary site, and the visual editor is the primary editor for new logged-in editors - https://phabricator.wikimedia.org/T132806#2282409 (10Jdforrester-WMF) 05Open>03declined Yup, sorry about this. I didn't configure the wiki exactly as I had i... [19:27:41] 10VisualEditor, 10VisualEditor-MediaWiki, 06Editing-Analysis, 07Category: Run experiment defaulting anonymous editors to the visual editor on the English Wikipedia - https://phabricator.wikimedia.org/T119269#2282416 (10Jdforrester-WMF) [19:27:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Enable single edit tab on enwiki - https://phabricator.wikimedia.org/T128478#2076099 (10Jdforrester-WMF) 05Open>03Resolved This was done on 12 April; see T132806 for the request to undo a related change, which I have declined with reaso... [19:27:47] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 07User-notice: Migrate wikis to use a single edit tab which has both visual and wikitext modes and allows on-the-fly switching between them - https://phabricator.wikimedia.org/T102398#2282417 (10Jdforrester-WMF) [19:29:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests, 13Patch-For-Review: Enable single edit tab on huwiki and review - https://phabricator.wikimedia.org/T126801#2282426 (10Jdforrester-WMF) [19:29:50] 10VisualEditor: Hungarian labels for single edit tab menu options have been translated lengthily so don't display correctly - https://phabricator.wikimedia.org/T127437#2282424 (10Jdforrester-WMF) 05Open>03Resolved Follow-up to T130021 please. [19:29:58] 10VisualEditor, 10Improving-access, 06Research-and-Data-Backlog: Code the mock-ups for link recommendations - https://phabricator.wikimedia.org/T126536#2282427 (10Jdforrester-WMF) p:05Triage>03Normal [19:57:47] gwicke we seem to record the new etag correctly when opening VE, opening VE after saving, and when switching from WTE [19:58:42] although... [19:59:09] etag:"2796/44f9791b-16e9-11e6-8768-58997a188eda/stash" [19:59:15] is it supposed to be in quotes like that? [19:59:30] yes, etag values start & end with quotes [20:00:46] I'm curious how the remaining html2wt requests without etag happen, especially considering that they do contain revision ids, so aren't for new pages [20:01:20] the content-length fields also make it look like they are pages, and not fragments [20:02:01] is VE making fragment html2wt requests at all? [20:02:10] or are those wt2html only? [20:02:22] ApiVisualEditor.php: $path = 'transform/html/to/wikitext/' . urlencode( $title->getPrefixedDBkey() ); [20:02:45] didn't find any other matches for transform/html/to [20:05:22] I didn't actually check whether the etag is sent in the diff path: https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/d155c5c584140d1214e3d4cfb0a17cda2189c67c/ApiVisualEditor.php#L589 [20:06:44] it seems to be sent [20:07:22] the diff path is not relevant, is it? [20:07:39] not for the corruptions, but it could be relevant for the missing etag requests [20:07:44] also, are you sure RB is never sending etag: null as a header? [20:08:50] let me double-check [20:22:37] so far I haven't found any code path that could result in a 'null' etag being emitted [20:23:21] yeah I didn't find anything weird in VE either :/ [20:23:57] I'm wondering if we should add debug logging on the servers [20:24:29] to rule it out completely, I'll add a check on the way out [20:27:03] the weird thing is that this started without apparent related changes in either RB or VE [20:27:20] (the corruption) [20:28:29] Is it tied to a specific UA? [20:28:33] E.g. a new release of Chrome? [20:28:42] UA is basically all VE [20:28:57] No no no. [20:29:04] That's what it says in your logs. [20:29:09] But I mean the actual UA. [20:29:23] VE just issues JS commands. There's no HTTP or network stack. :-) [20:29:47] right; on the discussion, one user mentioned their browser [20:29:54] We've been bitten by new versions of browsers a few times. [20:30:14] https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#VE_converting_categories_to_crap_and_lists_to_HTML [20:30:26] "The Fantastic Story Quarterly example above was my edit; that was using Chrome on Windows 7." [20:31:17] Chrome 50 rolled out ? last week, right? [20:31:43] http://venturebeat.com/2016/04/13/chrome-50-arrives-with-push-notification-improvements-and-declarative-preload/ [20:31:56] http://googlechromereleases.blogspot.com/2016/04/stable-channel-update_13.html [20:32:01] April 13 [20:32:08] Ah, hmm, not that then. [20:32:20] Maybe a change in the routing layer from Ops? [20:32:25] It seems unlikely though. [20:32:37] * James_F is being unhelpful; shuts up. [20:33:26] I looked a bit into the latest check script output, and didn't find anything related to this issue [20:33:53] so I'm not entirely sure if the issue still exists [20:40:29] 10VisualEditor: Automation citation insert does not work in IE 9 - https://phabricator.wikimedia.org/T134928#2282697 (10Ryasmeen) [20:49:25] 10VisualEditor: In IE 9, the text box inside "Add a template" dialog is misaligned and has another "Add a template" heading with puzzle icon above it - https://phabricator.wikimedia.org/T134929#2282770 (10Ryasmeen) [21:30:21] 10VisualEditor, 10Parsoid, 10RESTBase: Intermittent corruptions on saves, likely related to data-parsoid mis-matches - https://phabricator.wikimedia.org/T134593#2282906 (10Bgwhite) > @Bgwhite, have you seen new instances of this issue in the last 24 hours? I'll check after the Checkwiki 0z run get finished. [21:43:40] (03CR) 10Alex Monk: [C: 032] ve.ui.MWParameterPage: Remove non-working 'focus' handler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/287994 (owner: 10Bartosz Dziewoński) [21:50:49] (03Merged) 10jenkins-bot: ve.ui.MWParameterPage: Remove non-working 'focus' handler [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/287994 (owner: 10Bartosz Dziewoński) [22:09:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 13Patch-For-Review, and 2 others: Multi-part transclusion dialog very slow to load - https://phabricator.wikimedia.org/T134814#2283023 (10matmarex) Like you said in one of the earlier (deleted) comments, yeah, it seems that TextI... [22:37:31] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression: [Regression wmf.23] Cannot switch to Read tab from VE, getting error "this.emit is not a function" - https://phabricator.wikimedia.org/T134794#2283217 (10AlexMonk-WMF) a:03AlexMonk-WMF Looks like this was my fault in https://gerrit.wikimedia.org/r/#/c... [22:40:31] (03PS1) 10Alex Monk: Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288110 (https://phabricator.wikimedia.org/T134794) [22:40:46] James_F, ^ super easy fix to review [22:43:43] * James_F looks. [22:43:55] (03CR) 10Jforrester: [C: 032] "Ha." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288110 (https://phabricator.wikimedia.org/T134794) (owner: 10Alex Monk) [22:43:56] Yeah. [22:44:00] it's effectively this -> _this [22:44:03] or this -> that [22:44:07] * James_F nods. [22:44:10] but we don't use those as variable names anymore :) [22:44:20] this -> notThisNoReallyItIsNowCalledThat [22:44:23] * James_F grins. [22:45:31] actually, might not have been VE using _this [22:46:18] 10VisualEditor, 10Wikimedia-Site-requests, 07User-notice: Enable VisualEditor by default for all users of all "phase 6" Wikipedias - https://phabricator.wikimedia.org/T93387#2283235 (10Jdforrester-WMF) [22:46:34] Historical versions of UploadWizard did [22:46:39] Yup. [22:46:45] We purged it months ago. [22:47:44] You mean not years ago? :P [22:48:10] alex@alex-laptop:~/Development/MediaWiki/extensions/UploadWizard (master)$ git grep _this [22:48:10] resources/mw.UploadWizard.js: * We are using a second array to iterate, because we will be splicing the main one, _this.uploads [22:48:10] alex@alex-laptop:~/Development/MediaWiki/extensions/UploadWizard (master)$ [22:50:11] pff [22:50:16] comments in UploadWizard are not to be trusted [22:50:18] do we want to backport that commit James_F? [22:50:31] they are rarely truthful [22:50:42] Indeed, UW comments are… imperfect. [22:51:03] Krenair: Yeah; I was waiting for the merge to finish. [22:53:28] Eurgh, OOUI's npm-node-4.3 job is so damn slow. [22:55:11] * MatmaRex eyes James_F [22:55:22] maybe we should get rid of the silli minification stuff. just sayin' [22:55:32] silly* [22:55:36] MatmaRex: https://phabricator.wikimedia.org/T134946#2283244 [22:57:22] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on 4 more wikis - https://phabricator.wikimedia.org/T103693#2283272 (10AlexMonk-WMF) [22:57:36] (03Merged) 10jenkins-bot: Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288110 (https://phabricator.wikimedia.org/T134794) (owner: 10Alex Monk) [22:58:18] 10VisualEditor, 10Brickimedia, 10Refreshed: Refreshed should integrate native-support for VisualEditor - https://phabricator.wikimedia.org/T134668#2283279 (10LegoFan4000) [22:58:58] (03PS1) 10Jforrester: Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288114 (https://phabricator.wikimedia.org/T134794) [23:01:08] (03PS1) 10Jforrester: Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] (wmf/1.27.0-wmf.23) - 10https://gerrit.wikimedia.org/r/288115 (https://phabricator.wikimedia.org/T134794) [23:01:15] (03CR) 10Jforrester: [C: 032] Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] (wmf/1.27.0-wmf.23) - 10https://gerrit.wikimedia.org/r/288115 (https://phabricator.wikimedia.org/T134794) (owner: 10Jforrester) [23:01:26] (03CR) 10Jforrester: [C: 032] Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288114 (https://phabricator.wikimedia.org/T134794) (owner: 10Jforrester) [23:02:04] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on more wikis - https://phabricator.wikimedia.org/T134949#2283300 (10AlexMonk-WMF) [23:02:25] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Wikimania-Hackathon-2016, 06Community-Liaisons (Apr-Jun-2016): Consider helping some smaller Wikipedias' communities (which?) by writing the TemplateData to enable citoid for them - https://phabricator.wikimedia.org/T127354#2283316 (10Rical... [23:02:27] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on 4 more wikis - https://phabricator.wikimedia.org/T103693#1396730 (10AlexMonk-WMF) >>! In T103693#2275243, @Elitre wrote: > I noticed hi.wiki has the same issue. I wrote a script to find more like that, the result is {T134949} [23:03:52] Do we have a task about the CX popup being huge and overlapping VE? [23:05:12] we have one about having too many popups for sure. [23:06:29] Krenair: Somewhere, yes. [23:06:51] Elitre, I'm sure we also have a few tasks about making more popups though [23:07:27] (03PS1) 10Jforrester: Update OOjs UI to v0.17.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288125 [23:09:42] oh, totally :D [23:10:11] By the way, my script is very dumb and I doubt that list is complete [23:10:50] Krenair: https://phabricator.wikimedia.org/T124294 - we had a CX related one that I merged there. [23:11:10] It literally just went through sitematrix and checked the notices for User:Krenair, looking for the substring 'sysop-show' [23:11:30] Which may or may not indicate an issue, but usually does [23:11:37] (03Merged) 10jenkins-bot: Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] (wmf/1.27.0-wmf.23) - 10https://gerrit.wikimedia.org/r/288115 (https://phabricator.wikimedia.org/T134794) (owner: 10Jforrester) [23:11:48] Krenair: sure, thanks for doing that still! [23:12:16] But I checked some of the results and there's definitely some showing the issue [23:12:21] (03Merged) 10jenkins-bot: Fix deactivating VE after user explicitly decideas to discard changes [extensions/VisualEditor] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/288114 (https://phabricator.wikimedia.org/T134794) (owner: 10Jforrester) [23:14:17] also thanks for keeping an eye on already closed tasks. [23:22:35] I'm assuming we'll only move forward with ja.wiki after James is done with this regression? [23:25:15] (03CR) 10Jforrester: [C: 032] [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] (REL1_27) - 10https://gerrit.wikimedia.org/r/287757 (owner: 10Jforrester) [23:28:01] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression, 05WMF-deploy-2016-05-03_(1.27.0-wmf.23), and 2 others: [Regression wmf.23] Cannot switch to Read tab from VE, getting error "this.emit is not a function" - https://phabricator.wikimedia.org/T134794#2283435 (10Jdforrester-WMF) 05Open>03Resolved p:... [23:28:22] (03PS8) 10Jforrester: Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 (https://phabricator.wikimedia.org/T133800) (owner: 10Alex Monk) [23:28:31] (03CR) 10Jforrester: [C: 032] Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 (https://phabricator.wikimedia.org/T133800) (owner: 10Alex Monk) [23:29:04] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 13Patch-For-Review: Add the "welcome" dialog (with button to switch) to the wikitext editor - https://phabricator.wikimedia.org/T133800#2283451 (10Jdforrester-WMF) 05Open>03Resolved [23:36:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Centralize feedback for the visual editor at the Hindi Wikipedia - https://phabricator.wikimedia.org/T134789#2283468 (10Jdforrester-WMF) 05Open>03Resolved [23:37:51] (03Merged) 10jenkins-bot: [DEPRECATING CHANGE] Use canonical namespace names for enabling VE [extensions/VisualEditor] (REL1_27) - 10https://gerrit.wikimedia.org/r/287757 (owner: 10Jforrester) [23:42:25] (03Merged) 10jenkins-bot: Add WTE welcome dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286106 (https://phabricator.wikimedia.org/T133800) (owner: 10Alex Monk) [23:59:51] 10VisualEditor, 10Phlogiston (Burnup-Support): Fix data quality issues in list of unpointed tasks - https://phabricator.wikimedia.org/T134418#2283525 (10JAufrecht) @Jdforrester-WMF : is this sufficiently fixed as a side-effect of fixing {T127766} and {T134411}, or is further action required?