[00:36:06] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: Ref name ":0" appears in the dialog box of adding existing reference which has repeated citations - https://phabricator.wikimedia.org/T59875#642457 (10Parker) This bug seems to be back. I'm experiencing it on Chrome, and thought they were invalid refer... [05:44:03] 10VisualEditor: Cannot add internal links with anchor (#) in VisualEditor - https://phabricator.wikimedia.org/T135357#2296293 (10Amire80) [07:35:36] 10VisualEditor: Cannot add internal links with anchor (#) in VisualEditor - https://phabricator.wikimedia.org/T135357#2296370 (10Elitre) [07:35:39] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 06Collaboration-Team-Interested, 10Flow, 07Regression: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#2296372 (10Elitre) [07:36:26] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 06Collaboration-Team-Interested, 10Flow, 07Regression: [Regression wmf23] On creating a wikilink/an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1649374 (10Elitre) [08:12:32] (03CR) 10Jforrester: [C: 032] Explicitly insert transclusion as inline [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/288815 (owner: 10Esanders) [08:18:36] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 06Community-Liaisons (Apr-Jun-2016), and 2 others: Add the "welcome" dialog (with button to switch) to the wikitext editor - https://phabricator.wikimedia.org/T133800#2296388 (10Elitre) [08:19:24] (03PS3) 10Jforrester: [BREAKING CHANGE] Evalute block/inline state when inserting a transclusion node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288813 (https://phabricator.wikimedia.org/T51784) (owner: 10Esanders) [08:19:26] (03Merged) 10jenkins-bot: Explicitly insert transclusion as inline [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/288815 (owner: 10Esanders) [08:19:35] (03CR) 10Jforrester: "PS3: Fix typo." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288813 (https://phabricator.wikimedia.org/T51784) (owner: 10Esanders) [08:19:41] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Evalute block/inline state when inserting a transclusion node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288813 (https://phabricator.wikimedia.org/T51784) (owner: 10Esanders) [08:23:50] edsanders: Argh, can you merge https://gerrit.wikimedia.org/r/288887 please? [08:24:38] Thanks. [08:26:40] 10VisualEditor, 10VisualEditor-DataModel, 07Technical-Debt: VisualEditor: Transclusion nodes should re-evaluate their block/inline status on every update - https://phabricator.wikimedia.org/T51784#2296394 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [08:27:54] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Evalute block/inline state when inserting a transclusion node [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288813 (https://phabricator.wikimedia.org/T51784) (owner: 10Esanders) [08:28:54] 10VisualEditor, 07Technical-Debt, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Factor out code duplication in ve.ui.*Action tests - https://phabricator.wikimedia.org/T90370#1057120 (10Jdforrester-WMF) [09:22:42] (03CR) 10Jforrester: "Shouldn't this be in VE itself?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288773 (https://phabricator.wikimedia.org/T39932) (owner: 10Florianschmidtwelzow) [09:23:19] (03CR) 10Jforrester: "Bump. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [09:28:14] 10VisualEditor, 10VisualEditor-MediaWiki: Fix "1 notice" on more wikis - https://phabricator.wikimedia.org/T134949#2283300 (10Jdforrester-WMF) p:05Triage>03Normal [09:45:13] (03PS5) 10Jforrester: [WIP] Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders) [09:45:25] (03CR) 10Jforrester: "PS5: Manual rebase." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders) [09:45:48] (03PS3) 10Jforrester: WIP some failing tests in fixUpInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114357 (owner: 10Esanders) [09:46:00] (03PS4) 10Jforrester: [WIP] Some failing tests in fixUpInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114357 (owner: 10Esanders) [09:47:37] edsanders: https://gerrit.wikimedia.org/r/#/q/status:open+project:VisualEditor/VisualEditor,n,z more generally. [09:48:22] (03PS3) 10Jforrester: [WIP] Add cloneWithData() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [09:48:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Some failing tests in fixUpInsertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/114357 (owner: 10Esanders) [09:48:51] (03CR) 10Jforrester: "@dlynch, @edsanders – worthwhile or should we abandon?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [09:49:49] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Fix removals when starting/ending after inline node at end of block [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/148690 (owner: 10Esanders) [09:52:01] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add cloneWithData() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [09:58:47] (03PS8) 10Jforrester: [WIP] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [09:59:35] (03CR) 10Jforrester: [C: 04-1] "PS8: Rebase. Still needs (a) some unit tests, and (b) someone needs to work out if the subsequently-written unit test in TableAction which" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [10:01:20] (03CR) 10Jforrester: "Bump. This sounds like something we should be doing… :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/177482 (owner: 10Divec) [10:02:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add some sanity checks in newFromReplacement, pushInsertion and pushRemoval [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/118371 (owner: 10Catrope) [10:13:07] (03PS1) 10Esanders: Check initialFragment is set when closing dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288903 [10:54:05] (03PS5) 10Esanders: [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope) [10:54:07] (03PS1) 10Esanders: Use #getCoveringRange in surface fragment for linear actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288909 [10:54:49] (03CR) 10Esanders: "de-indented so patch is readable and rebaseable" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope) [10:56:40] (03CR) 10Esanders: [C: 04-1] Use #getCoveringRange in surface fragment for linear actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288909 (owner: 10Esanders) [11:02:26] (03PS2) 10Esanders: SurfaceFragment: Use #getCoveringRange for linear actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288909 [11:02:28] (03PS6) 10Esanders: [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope) [11:02:30] (03PS1) 10Esanders: SurfaceFragment: Remove clone flag in getSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288914 [11:05:01] 10Citoid, 10VisualEditor, 10Graphoid, 06Operations, and 3 others: SCB services should not use a proxy for our domains - https://phabricator.wikimedia.org/T97530#2296738 (10mobrovac) [11:12:40] 10VisualEditor, 10VisualEditor-MediaWiki: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#2296756 (10Elitre) For some reasons I thought this was already fixed? It's particularly annoying/confusing on SET wikis. [12:12:18] (03PS4) 10Esanders: Add cloneWithData() utility [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [12:12:38] (03CR) 10Esanders: [C: 031] "LGTM. Can Roan explain why it was marked WIP?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [12:20:29] (03CR) 10Esanders: [C: 04-1] "Tried this with captions but we currently create the sub-document without a reference to the original internal list. This method copied ov" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [12:53:31] 10VisualEditor, 07Browser-Support-Internet-Explorer: Keyboard shortcuts dialog layout broken in IE9 - https://phabricator.wikimedia.org/T135379#2296963 (10Esanders) [12:53:45] 10VisualEditor, 07Browser-Support-Internet-Explorer: Keyboard shortcuts dialog layout broken in IE9 - https://phabricator.wikimedia.org/T135379#2296975 (10Esanders) p:05Triage>03Lowest [13:01:04] (03PS4) 10Jforrester: build: Use stylelint instead of csslint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243233 [13:02:13] (03PS1) 10Jforrester: [WIP] build: Enable a bunch of stylelint rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 [13:04:21] (03CR) 10jenkins-bot: [V: 04-1] [WIP] build: Enable a bunch of stylelint rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 (owner: 10Jforrester) [13:06:12] (03PS2) 10Jforrester: FindAndReplaceDialog: Check initialFragment is set when closing dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288903 (owner: 10Esanders) [13:06:27] (03CR) 10Jforrester: [C: 032] FindAndReplaceDialog: Check initialFragment is set when closing dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288903 (owner: 10Esanders) [13:10:11] (03Merged) 10jenkins-bot: FindAndReplaceDialog: Check initialFragment is set when closing dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288903 (owner: 10Esanders) [13:13:11] (03PS3) 10Esanders: SurfaceFragment: Use #getCoveringRange for linear actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288909 [13:13:13] (03PS2) 10Esanders: SurfaceFragment: Remove clone flag in getSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288914 [13:13:15] (03PS7) 10Esanders: [WIP] Cache all the things in SurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/140244 (owner: 10Catrope) [13:25:57] (03CR) 10Esanders: [C: 032] build: Use stylelint instead of csslint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243233 (owner: 10Jforrester) [13:30:57] (03Merged) 10jenkins-bot: build: Use stylelint instead of csslint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/243233 (owner: 10Jforrester) [13:33:45] (03PS1) 10Esanders: Add more colour rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288931 [13:33:47] (03PS1) 10Esanders: Add font rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288932 [13:37:50] (03PS1) 10Esanders: Add function whitespace rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288933 [13:43:10] (03PS1) 10Esanders: Add single quotes rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288934 [13:52:17] (03PS1) 10Esanders: Remove -ms-repeating-linear-gradient rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 [13:56:40] (03PS2) 10Esanders: Remove -ms-repeating-linear-gradient rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 [13:56:42] (03PS2) 10Esanders: Add whitespace rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288933 [13:56:44] (03PS2) 10Esanders: Add single quotes rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288934 [14:01:53] (03PS3) 10Esanders: Remove -ms-repeating-linear-gradient rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 [14:01:55] (03PS3) 10Esanders: Add whitespace rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288933 [14:01:57] (03PS3) 10Esanders: Add single quotes rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288934 [14:08:40] (03PS1) 10Esanders: Add duplicate property rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288944 [14:16:00] 10VisualEditor: "Uncaught TypeError: Cannot read property '0' of undefined" and VE not loading - https://phabricator.wikimedia.org/T135387#2297159 (10Elitre) [14:17:18] (03PS1) 10Esanders: Add block formatting rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288947 [14:17:20] (03PS1) 10Esanders: Add selector whitespace and double colon rules to styleline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288948 [14:20:57] (03PS1) 10Esanders: Fix watch list (csslint -> stylelint) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288949 [14:39:43] (03PS1) 10Esanders: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 [14:41:13] (03PS2) 10Esanders: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 [14:41:43] 10VisualEditor: Interaction with gadget "Add an [edit] link for the lead section of a page" - https://phabricator.wikimedia.org/T135391#2297246 (10Elitre) [14:45:20] (03PS4) 10Esanders: Remove -ms-repeating-linear-gradient rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 [14:45:22] (03PS2) 10Esanders: Add duplicate property rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288944 [14:45:24] (03PS2) 10Esanders: Add block formatting rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288947 [14:45:26] (03PS2) 10Esanders: Add selector whitespace and double colon rules to styleline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288948 [14:45:28] (03PS4) 10Esanders: Add whitespace rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288933 [14:45:30] (03PS4) 10Esanders: Add single quotes rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288934 [14:45:32] (03PS1) 10Esanders: Add whitespace rules for media sections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288955 [14:45:59] (03CR) 10jenkins-bot: [V: 04-1] Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 (owner: 10Esanders) [15:08:18] (03CR) 10DLynch: [C: 032] SurfaceFragment: Use #getCoveringRange for linear actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288909 (owner: 10Esanders) [15:17:17] (03PS2) 10Esanders: Add whitespace rules for media sections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288955 [15:17:19] (03PS1) 10Esanders: Enforce tabs and file-level whitespace (newlines) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288960 [15:17:21] (03PS1) 10Esanders: Disallow duplicate selectors with stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288961 [15:17:23] (03PS1) 10Esanders: Require animations to exist using stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288962 [15:17:25] (03PS1) 10Esanders: Disable browser hacks for unsupported browsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288963 [15:17:27] (03PS1) 10Esanders: Enforce ascending specificity with stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288964 [15:21:20] (03Merged) 10jenkins-bot: SurfaceFragment: Use #getCoveringRange for linear actions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288909 (owner: 10Esanders) [15:23:42] (03CR) 10DLynch: [C: 032] SurfaceFragment: Remove clone flag in getSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288914 (owner: 10Esanders) [15:30:38] (03Merged) 10jenkins-bot: SurfaceFragment: Remove clone flag in getSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288914 (owner: 10Esanders) [15:43:18] 10Cite, 10MobileFrontend, 10Reading-Web-Backlog, 10Reading-Web-Planning, and 2 others: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2297540 (10Jhernandez) Looks good to me, I've QAd and all, but I can't merge because I've... [15:50:44] (03CR) 10Florianschmidtwelzow: "I'm not sure, I thought about that, too. But this mostly has to be handled by the integration of VE as it depends on how an image upload i" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288773 (https://phabricator.wikimedia.org/T39932) (owner: 10Florianschmidtwelzow) [15:59:25] (03CR) 10Bartosz Dziewoński: "Fancy :o I'm surprised that this just works (and it seems to, I didn't try myself). mw.Upload was never tested with images from clipboard," [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288773 (https://phabricator.wikimedia.org/T39932) (owner: 10Florianschmidtwelzow) [15:59:34] 10Cite, 10MobileFrontend, 10Reading-Web-Backlog, 10Reading-Web-Planning, and 2 others: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2297638 (10Jdlrobson) >>! In T125897#2297540, @Jhernandez wrote: > Looks good to me, I've... [16:15:40] 10VisualEditor: VisualEditor adding `` tags inline - https://phabricator.wikimedia.org/T135334#2297719 (10Danny_B) 05declined>03Invalid [16:27:33] 10VisualEditor, 10Math, 06Services, 07Regression, 07Verified: [Regression pre-wmf.15] Math node is appearing as UNIQ marker in Read mode - https://phabricator.wikimedia.org/T127738#2297773 (10Danny_B) [16:49:28] 10Cite, 10VisualEditor, 10VisualEditor-ContentEditable, 13Patch-For-Review: Cursoring jumps over references and some extra characters - https://phabricator.wikimedia.org/T123608#2297888 (10Esanders) This is broken in a slightly different way now. In Chrome cursoring right works, but left it skins over the... [16:51:39] (03PS2) 10Esanders: [Failing test case] Cursoring over empty alienInline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280683 (https://phabricator.wikimedia.org/T123608) (owner: 10Jforrester) [16:54:21] (03CR) 10jenkins-bot: [V: 04-1] [Failing test case] Cursoring over empty alienInline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280683 (https://phabricator.wikimedia.org/T123608) (owner: 10Jforrester) [16:55:14] 10VisualEditor, 10VisualEditor-ContentLanguage, 07I18n, 07RTL: Link cartouches break bidi algorithm - https://phabricator.wikimedia.org/T131660#2297923 (10Esanders) >>! In T131660#2178707, @eranroz wrote: > .ve-ce-nail { display: none; } > Should work, though I guess there is a reason for this nail. Yes -... [17:09:33] (03CR) 10Catrope: "I don't know why this was WIP. Maybe it was because I had no use for it except in a WIP patch, or because it had no tests." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/155655 (owner: 10Catrope) [17:17:24] 10VisualEditor, 10VisualEditor-ContentLanguage, 07I18n, 07RTL: Link cartouches break bidi algorithm - https://phabricator.wikimedia.org/T131660#2297969 (10Esanders) Directionality is inferred from the dash type, not link presence, so – is always used for date ranges, and minus for maths. [17:38:46] (03CR) 10Esanders: "I've split these out into separate commits with fixes - this commit will get abandoned eventually." (0311 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 (owner: 10Jforrester) [17:41:47] 10VisualEditor, 10VisualEditor-ContentLanguage, 07I18n, 07RTL: Link cartouches break bidi algorithm - https://phabricator.wikimedia.org/T131660#2298048 (10dchan) 05Open>03Resolved a:03dchan Ok. So if we're not redefining links to embed a directionality context, then I think there's no feasible fix fo... [17:42:20] 10VisualEditor, 10VisualEditor-ContentLanguage, 07I18n, 07RTL: Link cartouches break bidi algorithm - https://phabricator.wikimedia.org/T131660#2298053 (10dchan) 05Resolved>03declined [17:45:31] 10VisualEditor, 10Phlogiston (Burnup-Support): Fix data quality issues in list of unpointed tasks - https://phabricator.wikimedia.org/T134418#2298076 (10JAufrecht) 05Open>03Resolved a:03JAufrecht [17:50:15] (03PS1) 10Esanders: Disable !important in stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288992 [17:52:46] (03CR) 10Esanders: [WIP] build: Enable a bunch of stylelint rules (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 (owner: 10Jforrester) [17:53:32] (03CR) 10Esanders: "Real commits start at I5a70a4a7484301c759c25d0618e326048a3672d6" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 (owner: 10Jforrester) [18:38:40] (03CR) 10Jforrester: [C: 032] Add more colour rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288931 (owner: 10Esanders) [18:38:53] (03CR) 10Jforrester: [C: 032] Add font rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288932 (owner: 10Esanders) [18:40:13] (03CR) 10Jforrester: [C: 032] Add whitespace rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288933 (owner: 10Esanders) [18:40:40] (03CR) 10Jforrester: [C: 032] Add single quotes rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288934 (owner: 10Esanders) [18:41:15] (03CR) 10Jforrester: [C: 031] "This doesn't actually touch .stylelintrc…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 (owner: 10Esanders) [18:41:39] (03CR) 10Jforrester: [C: 032] Add duplicate property rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288944 (owner: 10Esanders) [18:42:01] (03CR) 10Jforrester: [C: 032] Add block formatting rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288947 (owner: 10Esanders) [18:42:12] (03CR) 10Esanders: "No - I deferred the rule associated with this because it wasn't working properly - but these should definitely go." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 (owner: 10Esanders) [18:42:26] (03CR) 10Jforrester: [C: 032] Add selector whitespace and double colon rules to styleline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288948 (owner: 10Esanders) [18:42:37] (03CR) 10Jforrester: [C: 032] Add whitespace rules for media sections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288955 (owner: 10Esanders) [18:43:00] (03CR) 10Jforrester: [C: 032] Enforce tabs and file-level whitespace (newlines) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288960 (owner: 10Esanders) [18:43:16] (03CR) 10Jforrester: [C: 032] Disallow duplicate selectors with stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288961 (owner: 10Esanders) [18:43:28] (03CR) 10Jforrester: [C: 032] Require animations to exist using stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288962 (owner: 10Esanders) [18:43:59] (03CR) 10Jforrester: [C: 04-1] Disable browser hacks for unsupported browsers (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288963 (owner: 10Esanders) [18:44:34] (03CR) 10Jforrester: [C: 032] Enforce ascending specificity with stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288964 (owner: 10Esanders) [18:44:50] (03CR) 10Jforrester: [C: 032] Disable !important in stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288992 (owner: 10Esanders) [18:45:40] (03Merged) 10jenkins-bot: Add more colour rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288931 (owner: 10Esanders) [18:45:43] (03Merged) 10jenkins-bot: Add font rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288932 (owner: 10Esanders) [18:45:48] (03Merged) 10jenkins-bot: Add whitespace rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288933 (owner: 10Esanders) [18:45:50] (03Merged) 10jenkins-bot: Add single quotes rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288934 (owner: 10Esanders) [18:45:52] (03PS2) 10Esanders: Enforce ascending specificity with stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288964 [18:45:55] (03PS2) 10Esanders: Disable browser hacks for unsupported browsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288963 [18:45:56] (03PS2) 10Esanders: Disable !important in stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288992 [18:46:21] (03CR) 10Esanders: "still passes with 9" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288963 (owner: 10Esanders) [18:47:23] James_F: https://gerrit.wikimedia.org/r/#/c/288925/1/.stylelintrc [18:49:45] (03CR) 10Jforrester: [WIP] build: Enable a bunch of stylelint rules (039 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 (owner: 10Jforrester) [18:50:21] edsanders: Patience. :-) [18:50:34] (03CR) 10Jforrester: [C: 032] Remove -ms-repeating-linear-gradient rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 (owner: 10Esanders) [18:51:34] (03CR) 10Jforrester: [C: 032] Disable browser hacks for unsupported browsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288963 (owner: 10Esanders) [19:06:52] (03PS2) 10Jforrester: [WIP] build: Enable a bunch of other stylelint rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 [19:10:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] build: Enable a bunch of other stylelint rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 (owner: 10Jforrester) [19:12:21] (03Merged) 10jenkins-bot: Remove -ms-repeating-linear-gradient rules [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288938 (owner: 10Esanders) [19:12:24] (03Merged) 10jenkins-bot: Add duplicate property rule to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288944 (owner: 10Esanders) [19:12:26] (03Merged) 10jenkins-bot: Add block formatting rules to stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288947 (owner: 10Esanders) [19:12:28] (03Merged) 10jenkins-bot: Add selector whitespace and double colon rules to styleline [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288948 (owner: 10Esanders) [19:12:30] (03Merged) 10jenkins-bot: Add whitespace rules for media sections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288955 (owner: 10Esanders) [19:12:33] (03Merged) 10jenkins-bot: Enforce tabs and file-level whitespace (newlines) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288960 (owner: 10Esanders) [19:12:35] (03Merged) 10jenkins-bot: Disallow duplicate selectors with stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288961 (owner: 10Esanders) [19:12:37] (03Merged) 10jenkins-bot: Require animations to exist using stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288962 (owner: 10Esanders) [19:12:47] (03Merged) 10jenkins-bot: Disable browser hacks for unsupported browsers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288963 (owner: 10Esanders) [19:12:50] (03Merged) 10jenkins-bot: Enforce ascending specificity with stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288964 (owner: 10Esanders) [19:12:52] (03Merged) 10jenkins-bot: Disable !important in stylelint [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288992 (owner: 10Esanders) [19:28:55] 10WikiEditor, 05MW-1.28-release-notes, 13Patch-For-Review, 07User-notice, 05WMF-deploy-2016-05-17_(1.28.0-wmf.2): Signature button in Hungarian should produce "– ~~~~" - https://phabricator.wikimedia.org/T26191#284398 (10nyuszika7h) > (Hungarian makes an orthographic distinction between the em- and en-da... [19:29:59] 10Cite, 10MobileFrontend, 10Reading-Web-Backlog, 10Reading-Web-Planning, and 2 others: Create Special:Citations fallback for non-JavaScript/Resourceloader unsupported users - https://phabricator.wikimedia.org/T125897#2000071 (10phuedx) a:05Jdlrobson>03None [20:02:02] 10Citoid, 10VisualEditor, 07Browser-Support-Internet-Explorer: Automation citation insert does not work in IE 9 - https://phabricator.wikimedia.org/T134928#2298941 (10matmarex) >>! In T134928#2286192, @Esanders wrote: > Adding `$.support.cors = true` fixes the issue but changing a global setting would be evi... [21:01:38] (03PS3) 10Jforrester: build: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 (owner: 10Esanders) [21:01:39] (03PS1) 10Jforrester: Update VE core submodule to master (12ad256) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289061 [21:08:18] (03CR) 10jenkins-bot: [V: 04-1] build: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 (owner: 10Esanders) [21:15:10] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (12ad256) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289061 (owner: 10Jforrester) [21:27:02] (03Merged) 10jenkins-bot: Update VE core submodule to master (12ad256) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289061 (owner: 10Jforrester) [21:31:05] (03PS4) 10Esanders: build: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 [21:31:41] (03CR) 10Jforrester: [C: 031] build: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 (owner: 10Esanders) [21:31:48] (03CR) 10Jforrester: [C: 032] build: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 (owner: 10Esanders) [21:33:27] (03PS2) 10Jforrester: build: Fix watch list (csslint -> stylelint) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288949 (owner: 10Esanders) [21:33:33] (03CR) 10Jforrester: [C: 032] build: Fix watch list (csslint -> stylelint) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288949 (owner: 10Esanders) [21:46:20] (03Merged) 10jenkins-bot: build: Replace csslint with stylelint [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288953 (owner: 10Esanders) [21:46:29] (03Merged) 10jenkins-bot: build: Fix watch list (csslint -> stylelint) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288949 (owner: 10Esanders) [21:54:11] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2299197 (10Mattflaschen) [21:55:25] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2299208 (10Catrope) >>! In T135126#2292045, @Trizek-WMF wrote: > Should I split that task in sub-tasks? Yes please. [23:58:32] (03CR) 10VolkerE: [WIP] build: Enable a bunch of other stylelint rules (034 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/288925 (owner: 10Jforrester)