[02:34:10] (03PS1) 10Alex Monk: Debug log strange-looking ETags being sent to RB [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289585 (https://phabricator.wikimedia.org/T135171) [02:36:23] (03PS1) 10Alex Monk: Debug log strange-looking ETags being sent to RB [extensions/VisualEditor] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/289586 (https://phabricator.wikimedia.org/T135171) [02:36:33] (03PS1) 10Alex Monk: Debug log strange-looking ETags being sent to RB [extensions/VisualEditor] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289587 (https://phabricator.wikimedia.org/T135171) [03:24:11] (03CR) 10Alex Monk: "What's the purpose of paction=wikitext when you could have the VE client hit action=query directly?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/229567 (https://phabricator.wikimedia.org/T104479) (owner: 10Esanders) [07:32:49] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow: Copy/pasting a link to a page (except user page) on Flow has an unexpected behavior - https://phabricator.wikimedia.org/T135621#2307931 (10Trizek-WMF) I've tried with: # links already included on some topics (quoting) -> Works # on a Topic, with the... [09:24:07] (03CR) 10Jforrester: [C: 032] Debug log strange-looking ETags being sent to RB [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289585 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [09:34:11] (03Merged) 10jenkins-bot: Debug log strange-looking ETags being sent to RB [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289585 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [10:18:30] 10VisualEditor, 10VisualEditor-MediaWiki: "Editing tabs" dialog shows up again if you click edit after saving without reloading the page - https://phabricator.wikimedia.org/T135534#2308242 (10Jdforrester-WMF) p:05Triage>03Lowest [10:19:02] 10VisualEditor, 10VisualEditor-MediaWiki: "Editing tabs" dialog shows up again if you click edit after saving without reloading the page - https://phabricator.wikimedia.org/T135534#2302102 (10Jdforrester-WMF) p:05Lowest>03Triage I don't consider this a significant issue, as the editing pattern described he... [10:21:17] 10VisualEditor: "Start editing" popup interferes with talk page usage - https://phabricator.wikimedia.org/T135682#2308251 (10Jdforrester-WMF) 05Open>03Invalid > I think the popup is generated by VisualEditor, correct? The code lives in VisualEditor, yes, but is independent of which editor you use. > Is suc... [10:24:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Please put templates on separate lines - https://phabricator.wikimedia.org/T135667#2308258 (10Jdforrester-WMF) 05Open>03Invalid This was fixed months ago. The first two templates lack the TemplateData asking for them to be put on separate lines. [10:26:37] (03CR) 10Jforrester: [C: 032] Add support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289443 (https://phabricator.wikimedia.org/T135620) (owner: 10Esanders) [10:28:46] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2308271 (10Jdforrester-WMF) [10:28:49] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): VE won't recognise tags on paste - https://phabricator.wikimedia.org/T135620#2304760 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [10:31:09] (03CR) 10Jforrester: Remap store indexes when modifying items during #sanitize (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) (owner: 10Esanders) [10:31:34] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review: Clear links created by copy/pasting on Flow have an unexpected behavior - https://phabricator.wikimedia.org/T135622#2304795 (10Jdforrester-WMF) a:03Esanders [10:31:47] 10VisualEditor, 10VisualEditor-MediaWiki: "Editing tabs" dialog shows up again if you click edit after saving without reloading the page - https://phabricator.wikimedia.org/T135534#2308281 (10Jdforrester-WMF) p:05Triage>03Lowest [10:32:57] 10VisualEditor, 10VisualEditor-EditingTools, 07Browser-Support-Internet-Explorer: IE9 doesn't support repeating gradients - https://phabricator.wikimedia.org/T135497#2308283 (10Jdforrester-WMF) >>! In T135497#2300875, @Danny_B wrote: > Some further description would be appreciated... https://www.w3.org/TR/c... [10:33:08] (03Merged) 10jenkins-bot: Add support [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289443 (https://phabricator.wikimedia.org/T135620) (owner: 10Esanders) [10:36:33] (03CR) 10Jforrester: "Argh, rebase and changes in the same commit make it hard to see what happened. :-( AFAICT, you've addressed all Roan's actionable comments" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [10:58:35] 10VisualEditor: "Start editing" popup interferes with talk page usage - https://phabricator.wikimedia.org/T135682#2308358 (10Nemo_bis) 05Invalid>03Open >>! In T135682#2308251, @Jdforrester-WMF wrote: > The code lives in VisualEditor, yes, but is independent of which editor you use. Talk page editing is not... [11:42:26] 10VisualEditor, 10VisualEditor-MediaWiki: "Editing tabs" dialog shows up again if you click edit after saving without reloading the page - https://phabricator.wikimedia.org/T135534#2308435 (10QuimGil) I am not contesting your Lowest priority, but I wouldn't say that "Edit -> Save -> Edit again" isn't at all co... [12:28:21] 10VisualEditor, 10VisualEditor-EditingTools, 07Browser-Support-Internet-Explorer: IE9 doesn't support repeating gradients - https://phabricator.wikimedia.org/T135497#2308538 (10Danny_B) @Jdforrester-WMF well, that's description of status quo, not description of the task, of what should be done. [12:51:02] 10VisualEditor, 10VisualEditor-EditingTools, 07Browser-Support-Internet-Explorer: IE9 doesn't support repeating gradients - https://phabricator.wikimedia.org/T135497#2308642 (10Jdforrester-WMF) >>! In T135497#2308538, @Danny_B wrote: > @Jdforrester-WMF well, that's description of status quo, not description... [13:27:54] (03PS1) 10Jforrester: Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) [13:28:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Authentication-and-authorization, 06Reading-Infrastructure-Team, and 3 others: Update VisualEditor for AuthManager - https://phabricator.wikimedia.org/T135071#2308887 (10Jdforrester-WMF) a:03Jdforrester-WMF [13:30:47] (03PS3) 10Esanders: Remap store indexes when modifying items during #sanitize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) [13:32:28] (03CR) 10Jforrester: [C: 032] Remap store indexes when modifying items during #sanitize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) (owner: 10Esanders) [13:33:01] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): Clear links created by copy/pasting on Flow have an unexpected behavior - https://phabricator.wikimedia.org/T135622#2308906 (10Jdforrester-WMF) [13:33:20] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow: Copy/pasting links on Flow has multiple unexpected behaviors - https://phabricator.wikimedia.org/T135126#2308910 (10Jdforrester-WMF) [13:33:23] 10VisualEditor, 06Collaboration-Team-Interested, 10Flow, 13Patch-For-Review, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): Clear links created by copy/pasting on Flow have an unexpected behavior - https://phabricator.wikimedia.org/T135622#2304795 (10Jdforrester-WMF) 05Open>03Resolved [13:34:54] (03CR) 10Esanders: [C: 04-1] Remap store indexes when modifying items during #sanitize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) (owner: 10Esanders) [13:35:16] (03PS4) 10Esanders: Update store hashes when modifying items in store during #sanitize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) [13:35:23] (03CR) 10Esanders: Update store hashes when modifying items in store during #sanitize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) (owner: 10Esanders) [13:44:44] (03CR) 10Jforrester: [C: 032] Update store hashes when modifying items in store during #sanitize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) (owner: 10Esanders) [13:52:50] (03Merged) 10jenkins-bot: Update store hashes when modifying items in store during #sanitize [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289544 (https://phabricator.wikimedia.org/T135622) (owner: 10Esanders) [14:12:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10WikiEditor, 06Community-Liaisons (Apr-Jun-2016), and 2 others: Add the "welcome" dialog (with button to switch) to the wikitext editor - https://phabricator.wikimedia.org/T133800#2309118 (10Elitre) For clarity, the button to switch isn't shown in namespaces where... [14:32:09] FWIW in FF "start editing" and "switch" appear on different lines - not so in Chrome, IE, Opera. [14:33:35] OOjs-UI thing I guess [14:55:34] (03CR) 10Anomie: Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [14:59:20] MatmaRex, ^ [14:59:27] oh, you joined afterwards [14:59:38] MatmaRex, FWIW in FF "start editing" and "switch" appear on different lines - not so in Chrome, IE, Opera. [15:00:21] yeah, the layout of the buttons depends on the length of the text in them [15:00:30] i guess firefox renders them a pixel wider or something [15:04:49] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289587 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [15:08:42] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/VisualEditor] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/289586 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [15:15:18] (03CR) 10Gergő Tisza: Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [15:15:22] (03Merged) 10jenkins-bot: Debug log strange-looking ETags being sent to RB [extensions/VisualEditor] (wmf/1.28.0-wmf.2) - 10https://gerrit.wikimedia.org/r/289587 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [15:19:04] (03CR) 10Jforrester: Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [15:21:09] (03PS2) 10Jforrester: Hooks: Replace AddNewAccount, AuthPluginAutoCreate with LocalUserCreated [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) [15:22:59] (03CR) 10Anomie: [C: 031] "Looks sane. Haven't tested." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289654 (https://phabricator.wikimedia.org/T135071) (owner: 10Jforrester) [15:23:57] 10VisualEditor, 10VisualEditor-MediaWiki: wikEd doesn't update #wpTextbox1 before switching to VE so changes are lost - https://phabricator.wikimedia.org/T135747#2309437 (10Esanders) [15:25:23] (03Merged) 10jenkins-bot: Debug log strange-looking ETags being sent to RB [extensions/VisualEditor] (wmf/1.28.0-wmf.1) - 10https://gerrit.wikimedia.org/r/289586 (https://phabricator.wikimedia.org/T135171) (owner: 10Alex Monk) [15:28:45] 10VisualEditor, 10VisualEditor-MediaWiki: Create path to fallback to source editor if VE load fails - https://phabricator.wikimedia.org/T135748#2309455 (10Esanders) [15:39:06] 10VisualEditor, 10VisualEditor-CopyPaste: Paste HTML into Visual Editor sometimes does nothing at all - https://phabricator.wikimedia.org/T135683#2306925 (10Esanders) Can you provide some actual sample HTML (by pasting here http://edg2s.github.io/content-editable-sandbox/) or a link to an Etherpad that fails.... [16:31:30] (03CR) 10DLynch: [C: 032] Convert references in place [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/288381 (https://phabricator.wikimedia.org/T135108) (owner: 10Esanders) [16:35:04] (03Merged) 10jenkins-bot: Convert references in place [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/288381 (https://phabricator.wikimedia.org/T135108) (owner: 10Esanders) [16:38:57] (03PS8) 10DLynch: Insert undo breakpoints at word breaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/287972 (https://phabricator.wikimedia.org/T127834) [16:40:55] (03PS1) 10Esanders: Remove .csslintrc [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289688 [16:42:45] (03CR) 10Jforrester: [C: 032] "Whoops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289688 (owner: 10Esanders) [16:57:50] (03Merged) 10jenkins-bot: Remove .csslintrc [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289688 (owner: 10Esanders) [16:58:24] On the plus side, that reminded me to set up Sublime Text linter integration for stylelint. [16:58:33] Kemayo: Or Atom! [16:58:35] * James_F coughs. [16:58:58] I'm not using Atom until they merge my patch, damnit. [16:59:38] Which patch? [16:59:43] * James_F loads GitHub to stalk. [17:00:01] If you open the VisualEditor folder in a mediawiki vagrant setup, it'll not show any files in the file palette, because the parent folder has it gitignored. [17:00:23] It's https://github.com/atom/fuzzy-finder/pull/152 [17:00:31] Oh, hah. Yeah, there's a config option to switch that off. [17:00:32] Which, in fairness, I suppose I need to rebase and fix up. [17:01:03] Yeah, but *then* you have to deal with node_modules polluting everything again. [17:01:35] My approach is to instead say "stop reimplementing this! Just use what the sidebar uses!" :D [17:15:02] Kemayo: :-) [17:16:13] Kemayo: BTW, https://github.com/atom/fuzzy-finder/pull/152 needs rebasing… [17:17:49] Hm, looks like they might have added a patch over that issues anyway... https://github.com/atom/fuzzy-finder/pull/207/files [17:18:12] So I'll have to decide how much the purity of my own approach matters to me, versus it now actually-working. [17:30:31] Well, actually-working once the next release comes out. [17:43:39] 10VisualEditor, 06Parsing-Team, 10TemplateStyles, 10ArchCom-RfC (ArchCom-Approved), 07RfC: RfC: Allow styling in templates - https://phabricator.wikimedia.org/T483#2309929 (10dr0ptp4kt) Hi @coren. We're looking at goal options for [[ https://www.mediawiki.org/wiki/Reading/Quarterly_planning/FY2016-2017/Q... [18:03:00] (03PS1) 10Jforrester: build: Bump grunt-stylelint to v0.3.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289703 [18:04:19] (03PS1) 10Jforrester: build: Bump grunt-stylelint to v0.3.0 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/289704 [18:38:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Please put templates on separate lines - https://phabricator.wikimedia.org/T135667#2310139 (10Thryduulf) Please could you link to the relevant task where this was fixed and/or the relevant TemplateData documentation to help people if this happens again. [19:17:56] (03PS1) 10Jforrester: build: Replace csslint with stylelint and bump others [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/289717 [19:20:50] (03CR) 10jenkins-bot: [V: 04-1] build: Replace csslint with stylelint and bump others [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/289717 (owner: 10Jforrester) [19:22:30] (03PS2) 10Jforrester: build: Replace csslint with stylelint and bump others [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/289717 [19:52:03] "I just got this stupid popup, I've been editing for seven years and am at no. 185 in the most edits list. I turned off VE as soon as an option to do so was available. I've been an admin since 2011 ferchrissakes. Get real." [19:53:44] sigh [19:53:46] " WMF: I volunteer here, doing the work that makes this wiki popular enough that you get to be handsomely paid for whatever it is you do. Stay out of my workflow. Take your abysmal Visual Editor and shove it, don't thrust it in front of me, I and the vast majority of the people who actually work around here told you it sucks, it sucks, that's it, stop demanding we choose between it and what works!" [20:34:25] (03CR) 10Jforrester: [C: 04-2] "Patch moved up to https://github.com/wikimedia/stylelint-config-wikimedia/pull/7" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289173 (owner: 10Jforrester) [20:35:46] (03CR) 10Jdlrobson: "I see Trevor +2ed this and then it didn't get merged. Still relevant more than a year later?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [20:36:03] (03CR) 10Jforrester: [C: 04-2] "Patch moved up to https://github.com/wikimedia/stylelint-config-wikimedia/pull/8" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/289180 (owner: 10Jforrester) [20:37:06] (03CR) 10Jforrester: "> I see Trevor +2ed this and then it didn't get merged. Still relevant more than a year later?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [20:38:57] (03CR) 10Cscott: "A reminder I should dust off this patch set, I guess!" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/151783 (owner: 10Cscott) [20:43:25] okay,
  • ApiVisualEditor.php line 615 calls ApiVisualEditor->storeInSerializationCache()
  • [20:43:27] usually [20:43:46] but sometimes
  • ApiVisualEditor.php line 577 calls ApiVisualEditor->postHTML()
  • [20:44:46] or
  • ApiVisualEditorEdit.php line 148 calls ApiVisualEditor->postHTML()
  • [21:01:55] James_F: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Why_am_I_seeing_a_.22Welcome.22_message.3F [21:02:13] complaints are acumulating. [21:18:52] 10VisualEditor, 10RESTBase, 06Services, 13Patch-For-Review: Investigate source of null / missing If-Match headers in VE html2wt requests - https://phabricator.wikimedia.org/T135171#2310732 (10GWicke) > Possibly related are transform requests that reach Parsoid without dp data in them This sounds a lot lik... [21:20:25] 10VisualEditor, 10RESTBase, 06Services, 13Patch-For-Review: Investigate source of null / missing If-Match headers in VE html2wt requests - https://phabricator.wikimedia.org/T135171#2310740 (10GWicke) There have been no matches for the `null` etag check in RESTBase in the last seven days, so it looks pretty... [21:27:07] thedj: Indeed. [21:48:22] James_F: small observation, you also get the dialog on pages you do not have permission to edit. [21:49:37] thedj: Hmm. Yeah, true. But only once. [22:00:34] 10VisualEditor, 10VisualEditor-MediaWiki, 10RESTBase, 06Services, and 3 others: Investigate source of null / missing If-Match headers in VE html2wt requests - https://phabricator.wikimedia.org/T135171#2310980 (10Jdforrester-WMF) a:03AlexMonk-WMF [22:03:01] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 05WMF-deploy-2016-05-24_(1.28.0-wmf.3): Update named references when using convert button - https://phabricator.wikimedia.org/T135108#2310988 (10Jdforrester-WMF) p:05Triage>03Normal a:03Esanders [22:09:23] James_F, I suspect the null etag issue is browser-related, I want to log some data from the client but I think the only existing infrastructure for doing this is EventLogging :/ [22:10:01] * James_F nods. :-( [22:10:15] may just have to make a schema and try to get it logging to that [22:10:17] At a random guess I'm happy to blame Safari, because it's normally the one that breaks. [22:10:30] Fun. [22:10:32] Yes [22:10:54] Safari is the most common browser involved in this issue [22:23:59] James_F, thinking of making an AdHocDebug schema like we have for wfDebugLog [22:29:46] * James_F nods. [23:28:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Enable single edit tab on enwiki - https://phabricator.wikimedia.org/T128478#2311195 (10Jdforrester-WMF) [23:28:07] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Enwiki is a wikitext-primary site, and the visual editor is the primary editor for new logged-in editors - https://phabricator.wikimedia.org/T132806#2210738 (10Jdforrester-WMF) 05stalled>03Resolved a:03Jdforrester-WMF Should now be working a...