[06:33:11] 10VisualEditor, 10VisualEditor-EditingTools: Cite > Re-use should ignore leading and trailing spaces - https://phabricator.wikimedia.org/T138278#2395724 (10Whatamidoing-WMF) [11:39:30] hey edsanders, yesterday James_F said you had a demo of how to add a Google Maps and a YouTube adder, it would be great to have for me [11:39:43] ypnos: hi [11:40:19] my own goal is to add simple custom elements that reference entities in a database [11:40:33] so they should be editable only by a custom interface, like right now with editing a comment [11:40:55] I would greatly appreciate if you have any pointers for me how to do it [11:41:15] ok - well you'll need the dm node and the ce node [11:41:26] and then either an inspector or a dialog to edit it [11:41:37] then also a tool for getting an edit button [11:41:50] I've browsed the code to try understand these node objects, is there any documentation apart from the existing examples? [11:43:27] just the generated docs [11:43:48] https://doc.wikimedia.org/VisualEditor/master/ [11:44:08] thats already much better than just the code :-) [11:48:10] how to define how such a node is rendered? like the CommentNode just has iconWhenInvisible set, but what about if I need an icon and text? [11:48:43] or I have seen these toHtml methods [11:50:46] could you tell me where ve.ui.ContextItem is used? [11:55:18] ContextItem is used in the context menu [11:55:26] which is what you get when you first click on the node [11:55:31] (before you press 'Edit') [11:55:51] ok I see [11:59:01] is there a plugin system to add the new classes, i18n etc? [12:01:06] on https://www.mediawiki.org/wiki/VisualEditor:Test I can add all kinds of things (e.g. Maps, Graphs), is that code also open source? [12:05:39] not really in standalone [12:05:49] you can add the files to modules.json and rebuild [12:06:05] or you can bulid - use the dist files and just load your modules separately [12:06:33] in MediaWiki, ResourceLoader does all the concatenation [12:07:02] MediaWiki has a plugin system for VE [12:07:16] basically a global variable called VisualEditorPluginModules [12:07:31] the code for Maps & Graphs lives in their respective extension repos [12:07:59] ok I see [12:09:21] is there a list of known users of ve outside mediawiki? [12:10:09] https://github.com/wikimedia/mediawiki-extensions-Kartographer/tree/master/modules/ve-maps [12:10:26] thanks :) [12:11:26] ypnos: I don't think so, I'm not actually aware of any, James_F might remember the name of one who worked on table support a year or so ago [12:12:23] ypnos: this is probably the simplest extension: https://github.com/wikimedia/mediawiki-extensions-wikihiero/tree/master/modules/ve-wikihiero [12:12:34] most of the behaviour is inherited from more generic classes [12:14:48] ok so I am going to try to build this with one of these extensions bundled first [12:14:53] thanks for your help so far! [12:19:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Template + First paragraph treated like a complex transclusion - https://phabricator.wikimedia.org/T137942#2396180 (10Esanders) [12:35:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 10Parsoid: Template + First paragraph treated like a complex transclusion - https://phabricator.wikimedia.org/T137942#2384495 (10Esanders) Could also be a malformed template [12:36:05] 10VisualEditor: VisualEditor loses subpage breadcrumb post-save - https://phabricator.wikimedia.org/T137934#2396199 (10Esanders) p:05Triage>03Low [12:42:12] 10VisualEditor: Change some shortcuts for French keyboards (slash /, point . and backslash \) - https://phabricator.wikimedia.org/T136948#2396213 (10Esanders) One issue may be that extensions can also register new keyboard shortcuts - so having multiple keyboard mappings in core could lead to conflicts. [12:44:56] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Internet-Explorer: Can't extend backwards selection in IE11 - https://phabricator.wikimedia.org/T137773#2396215 (10Esanders) a:03dchan [13:48:42] (03PS1) 10Esanders: Fix ve.BranchNode#traverse and make non-static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295345 [13:50:54] (03PS2) 10Esanders: Fix ve.BranchNode#traverse and make non-static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295345 [14:06:43] (03CR) 10Catrope: [C: 032] Fix ve.BranchNode#traverse and make non-static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295345 (owner: 10Esanders) [14:13:42] (03Merged) 10jenkins-bot: Fix ve.BranchNode#traverse and make non-static [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295345 (owner: 10Esanders) [14:27:04] (03PS1) 10Esanders: Add a node-type index [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295349 (https://phabricator.wikimedia.org/T135950) [14:57:36] (03CR) 10Catrope: [C: 04-1] "LGTM, one minor thing" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295349 (https://phabricator.wikimedia.org/T135950) (owner: 10Esanders) [15:14:26] (03CR) 10DLynch: [C: 032] Make namespace and content model lists extensible (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/292165 (owner: 10Esanders) [15:20:32] (03Merged) 10jenkins-bot: Make namespace and content model lists extensible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/292165 (owner: 10Esanders) [15:21:31] (03PS2) 10Esanders: Add a node-type index [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295349 (https://phabricator.wikimedia.org/T135950) [15:21:33] (03PS1) 10Esanders: Simplify node class comparison in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295355 [15:26:37] James_F: what's the sidebar-live-editing-suggestions epic bug? [15:31:03] (03CR) 10Catrope: [C: 032] Add a node-type index [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295349 (https://phabricator.wikimedia.org/T135950) (owner: 10Esanders) [15:31:11] (03CR) 10Catrope: [C: 032] Simplify node class comparison in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295355 (owner: 10Esanders) [15:34:44] (03Merged) 10jenkins-bot: Add a node-type index [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295349 (https://phabricator.wikimedia.org/T135950) (owner: 10Esanders) [15:37:08] (03Merged) 10jenkins-bot: Simplify node class comparison in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/295355 (owner: 10Esanders) [16:40:32] Found it T110644 [16:40:33] T110644: Provide a system for prompting the user to do things as they edit - https://phabricator.wikimedia.org/T110644 [16:41:44] 10VisualEditor, 10VisualEditor-DataModel, 13Patch-For-Review, 07Technical-Debt: Create a generic type-indexed node cache - https://phabricator.wikimedia.org/T135950#2396940 (10Esanders) [16:41:48] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic: Provide a system for prompting the user to do things as they edit - https://phabricator.wikimedia.org/T110644#2396939 (10Esanders) [16:43:05] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: Design a user workflow system which prompts/suggests/requires the user to do things as they edit - https://phabricator.wikimedia.org/T111848#2396954 (10Esanders) What is the difference between this and T110644? [17:14:30] (03CR) 10Divec: "Is creating ve.MWutils.js the right way to do this?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294393 (owner: 10Divec) [18:05:24] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Links to Wikivoyages aren't being transformed correctly into interwiki links - https://phabricator.wikimedia.org/T138336#2397305 (10Whatamidoing-WMF) [18:07:10] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Table format broken due to enwiki's {{Yes}} and {{No}} templates - https://phabricator.wikimedia.org/T138338#2397332 (10Whatamidoing-WMF) [18:55:48] edsanders, is there an official "external resources" lib anywhere that wraps upstream js libs as MW resources? [18:59:28] or maybe James_F knows - i see there is a number of resources in VE that are named as "blah", instead of "ext.ve.lib.blah" -- in other words implying that other extensions might want to use them [18:59:46] there are some common libs that are useful to many extensions - e.g. d3 [19:00:01] we already use it in >3 extensions under different resource names [20:54:58] 10VisualEditor, 10VisualEditor-MediaWiki: wikEd doesn't update #wpTextbox1 before switching to VE so changes are lost - https://phabricator.wikimedia.org/T135747#2397700 (10AlexMonk-WMF) I seem to recall the issue with mw.hook was that it ran hook functions asynchronously... Maybe we can trigger an event on wp... [20:58:14] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Table format broken due to enwiki's {{Yes}} and {{No}} templates - https://phabricator.wikimedia.org/T138338#2397332 (10ssastry) This may not be a Parsoid issue - depends on what the editor did during the edit. Can you check if this is reproducible? [23:23:46] 10VisualEditor, 10VisualEditor-MediaWiki: wikEd doesn't update #wpTextbox1 before switching to VE so changes are lost - https://phabricator.wikimedia.org/T135747#2398023 (10AlexMonk-WMF) a:03AlexMonk-WMF [23:24:22] (03PS1) 10Alex Monk: Trigger a custom event on #wpTextbox1 when we need to get the latest wikitext out of it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747)