[07:29:58] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Makes VE -> Wikitext switch work for Page: pages - https://phabricator.wikimedia.org/T138538#2403822 (10Jdforrester-WMF) p:05Normal>03High [07:32:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 13Patch-For-Review: Switching from WT to VE in ProofreadPage (using the pencil) leads to an odd, broken editor - https://phabricator.wikimedia.org/T138393#2403831 (10Jdforrester-WMF) a:03Tpt [07:32:30] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 13Patch-For-Review: Makes VE -> Wikitext switch work (with changes) for Page: pages - https://phabricator.wikimedia.org/T138538#2403832 (10Jdforrester-WMF) a:03Tpt [07:33:40] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Make it impossible for people to add things before the PageQuality tag in VE - https://phabricator.wikimedia.org/T138518#2403836 (10Jdforrester-WMF) One thing @tpt and I discussed adding a fourth section in the surface at the top which only has the q... [07:46:42] 10VisualEditor: Switch between VE and source editor doesn't change URL - https://phabricator.wikimedia.org/T138556#2403845 (10Dvorapa) [09:57:10] (03CR) 10Krinkle: [C: 032] Make visualeditor-quick-access-characters.json always exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/293746 (https://phabricator.wikimedia.org/T137368) (owner: 10Alex Monk) [10:04:56] (03Merged) 10jenkins-bot: Make visualeditor-quick-access-characters.json always exist [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/293746 (https://phabricator.wikimedia.org/T137368) (owner: 10Alex Monk) [10:08:09] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor registers a dependency on "visualeditor-quick-access-characters.json" but it doesn't exist - https://phabricator.wikimedia.org/T137368#2404171 (10Jdforrester-WMF) 05Open>03Resolved [10:09:06] 10Cite: Cite registers a dependency on "visualeditor-cite-tool-definition.json" but it doesn't exist - https://phabricator.wikimedia.org/T138573#2404174 (10Jdforrester-WMF) [10:09:46] 10Citoid, 10VisualEditor: Citoid registers a dependency on "citoid-template-type-map.json" but it doesn't exist - https://phabricator.wikimedia.org/T138574#2404189 (10Jdforrester-WMF) [10:10:38] 10Cite: Cite registers a dependency on "visualeditor-cite-tool-definition.json" but it doesn't exist - https://phabricator.wikimedia.org/T138573#2404204 (10Jdforrester-WMF) We should rename the message whilst we're at it, maybe to just "cite-tool-definition.json" (with a double-fetch fall-back if the new name do... [10:10:48] 10Cite, 10VisualEditor: Cite registers a dependency on "visualeditor-cite-tool-definition.json" but it doesn't exist - https://phabricator.wikimedia.org/T138573#2404205 (10Jdforrester-WMF) [12:47:54] (03PS1) 10Tpt: Adds support of preload hooks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295906 [12:52:08] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10ProofreadPage: Adds support of EditFormPreloadText hooks - https://phabricator.wikimedia.org/T138588#2404619 (10Tpt) [12:53:21] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#555851 (10Tpt) [12:53:29] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#555851 (10Tpt) ProofreadPage needs support of the EditFormPreloadText hook instead of editinfo/preload para... [12:53:52] (03PS2) 10Tpt: Adds support of preload hooks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295906 [13:31:31] 10VisualEditor, 10ProofreadPage, 06Wikisource, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Add the visual editor to Wikisource - https://phabricator.wikimedia.org/T93525#1139268 (10Zdzislaw) >>! In T93525#2401285, @Jdforrester-WMF wrote: >>>! In T93525#2399147, @Ankry wrote: >> * Any attempt to edit header/foo... [13:51:05] 10VisualEditor, 10ProofreadPage, 06Wikisource, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Add the visual editor to Wikisource - https://phabricator.wikimedia.org/T93525#2404728 (10Jdforrester-WMF) >>! In T93525#2404697, @Zdzislaw wrote: >>>! In T93525#2401285, @Jdforrester-WMF wrote: >>>>! In T93525#2399147,... [13:54:28] (03PS3) 10Jforrester: Execute the EditFormPreloadText hook on load for empty pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295906 (https://phabricator.wikimedia.org/T138588) (owner: 10Tpt) [13:56:22] (03CR) 10Jforrester: [C: 031] Execute the EditFormPreloadText hook on load for empty pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295906 (https://phabricator.wikimedia.org/T138588) (owner: 10Tpt) [13:59:36] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10ProofreadPage, 13Patch-For-Review: Execute the EditFormPreloadText hook in VE-MW on empty page load - https://phabricator.wikimedia.org/T138588#2404771 (10Jdforrester-WMF) p:05Triage>03High a:03Tpt [14:27:29] (03PS1) 10Esanders: Add screenshots grunt task for taking documentation screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295924 (https://phabricator.wikimedia.org/T119482) [14:52:35] Hello, could I ask for something? [14:52:45] *ask about [14:53:52] On cswiki we have a gadget, which adds some special helpful buttons under summary field (something similar has got also skwiki, hewiki and enwiki) [14:54:50] Code snippet: http://pastebin.com/wkW70pV6 [14:55:32] This part adds my buttons. It works if I go to the file [14:55:50] *if I go to some article [14:56:00] click edit [14:56:29] and make changes and click to save button. Buttons are shown [14:56:30] (these my special) [14:57:16] But if I click edit source and then switch from source editor to VE, it doesn't work! Why? How to fix it? [15:05:50] (03PS1) 10Tpt: Allows to register a specific target per content model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295936 [15:10:13] 10Cite, 06TCB-Team, 07RfC: Possibility to refine existing , e.g. reference individual pages in a book - https://phabricator.wikimedia.org/T138601#2405038 (10thiemowmde) [15:16:34] 10Cite, 06TCB-Team, 07RfC: Possibility to refine existing , e.g. reference individual pages in a book - https://phabricator.wikimedia.org/T138601#2405038 (10Izno) This is {T138260}. I think this is a slightly cleaner presentation of that bug, so I might suggest the other be closed as a duplicate, even t... [15:20:28] 10Cite, 06TCB-Team, 07RfC: Possibility to refine existing , e.g. reference individual pages in a book - https://phabricator.wikimedia.org/T138601#2405075 (10WMDE-leszek) I'd also consider this a possible solution to https://phabricator.wikimedia.org/T15127. OTOH I am not sure if this should this be seen... [15:23:37] 10Cite: acting as a citation template using attributes of the ref element - https://phabricator.wikimedia.org/T24134#2405093 (10Izno) [15:24:27] figured out my code is run once and it should be run every time [15:25:57] what is cswiki? [15:26:19] czech wikipedia [15:26:27] ah I see [15:26:30] 10Cite, 06TCB-Team, 07RfC: Possibility to refine existing , e.g. reference individual pages in a book - https://phabricator.wikimedia.org/T138601#2405103 (10Izno) Here's another one: {T100645}, actually being worked on during the Hackathon? [15:26:59] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10ProofreadPage, 06Wikisource: incorrect header/footer edits using VisualEditor with ProofreadPage - https://phabricator.wikimedia.org/T138604#2405105 (10Zdzislaw) [15:27:14] 10Cite, 06TCB-Team, 07Community-Wishlist-Survey, 07Epic, and 2 others: [GTWL] Epic: Efficient way to refer to different pages of the same work when adding references to an article - https://phabricator.wikimedia.org/T100645#1317261 (10Izno) [15:27:32] is there any hook, which is run after I switch between VE and source? [15:28:21] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10ProofreadPage, 06Wikisource: incorrect header/footer edits using VisualEditor with ProofreadPage - https://phabricator.wikimedia.org/T138604#2405123 (10Zdzislaw) [15:28:50] (in order to add them it once more when the user switches to source and then back to VE) [15:29:22] (because it is run also on source editor page) [15:29:37] *them it = buttons [15:32:31] I am really 100% clueless here, but maybe you could just hook into the resp. button? [15:34:41] I don't understand, but simply: I need to detect, when user switches between editors and then just run function (which adds my special buttons) once more [15:35:17] There is a ?veswitched=1 in url, but it doesn't change if I switch once more [15:36:59] well you can always use jquery to attach to the visualeditor interface which you intend to outfit with an extra button becoming visible [15:38:19] but I need the same vice versa for source editor. [15:38:30] (03PS2) 10Jforrester: Allow extensions to register a specific target per content model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295936 (https://phabricator.wikimedia.org/T138489) (owner: 10Tpt) [15:38:49] again, you have new interface elements becoming visible so you can hook into that using jQuery [15:39:27] I would like something like `mw.hook('ve.editor.switched')`, but I think there is nothing like this [15:40:00] still don't understand [15:40:43] (better just `mw.hook('editor.switched')`) [15:41:01] (03CR) 10Jforrester: [C: 031] "This seems to work, but it does remove the (theoretical, never used or announced) ability for config/extensions to disable VE on particula" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295936 (https://phabricator.wikimedia.org/T138489) (owner: 10Tpt) [15:43:23] 10VisualEditor: Images inside gallery can be swapped or re-ordered only twice? - https://phabricator.wikimedia.org/T138491#2405183 (10Ryasmeen) In production and also in Beta cluster. [15:43:23] is there any list of existing hooks? (maybe I'll find some useful there [15:43:54] (for VE or SE) [15:48:57] I still don't know, if I explained correctly, but if I switch between editors 50 times, I want 50 times to run my function [15:49:13] ok Dvorapa in the source edit there is a
with id "wikiEditor-ui-toolbar" [15:49:50] got it! [15:51:28] (maybe) and for VE there is another id for the bar? therefore I need somehow to listen, if there is by JS (assuming editors are switched by JS) added one or another? well, I need to find out how to detect this in jQuery [15:51:37] thank you [15:51:54] yes in visualeditor you have a corresponding div with some valuable classes [15:57:06] 10VisualEditor, 10VisualEditor-MediaWiki-Plugins, 10ProofreadPage, 06Wikisource: incorrect header/footer edits using VisualEditor with ProofreadPage - https://phabricator.wikimedia.org/T138604#2405105 (10Jdforrester-WMF) OK, so, first thing first: we need to fix the bug you've uncovered so it doesn't corru... [15:57:09] * Dvorapa is not familiar with jQuery [15:58:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource: Writing manual
s into header/footer using VisualEditor with ProofreadPage corrupts the page - https://phabricator.wikimedia.org/T138604#2405237 (10Jdforrester-WMF) p:05Triage>03High [15:58:56] well read about selectors [15:58:58] it is very powerful [16:02:27] Dvorapa: have a look at this https://github.com/adampietrasiak/jquery.initialize [16:02:42] jQuery is like $( element ) what does this do? Does this wait until element is loaded? or does this find element in DOM for further use? well... both! scary! confused! [16:02:59] element is a selector [16:03:41] it has a specific syntax to select elements, e.g. '.foo' will select all elements of class foo, '#foo' will select all elements (== the element) with id foo [16:04:33] sure, like querySelector() [16:04:35] see the examples in jquery.initialize, there you would use $("#wikiEditor-ui-toolbar").initialize( function() { … } [16:05:19] that library looks cool [16:07:08] I hoped jQuery has something itself (I googled out something like jQuery.load: isn't this the same?) [16:07:49] 10VisualEditor, 07Browser-Tests, 13Patch-For-Review: Fix language screenshots browser test on VisualEditor - https://phabricator.wikimedia.org/T119482#2405286 (10Jdforrester-WMF) a:03Esanders [16:10:10] no it's not [16:10:24] yeah, I see [16:10:38] I agree this functionality could be built into jquery, it is only a page of code basically anyways [16:12:24] OK, initialize is awesome and exactly what I need. I hope some hook will be added in the future into mw (I mean for switching between editors) and I hope jQuery devs add this small page of code inside. Thank you [16:14:46] I don't like that initialize doesn't work on IEs [16:14:53] but better than nothing [16:18:06] Dvorapa: I suggest you use wikimedia's phabricator to write a feature request [16:20:27] I'll do, thank you [16:39:40] 10VisualEditor: Add a hook if user switches editors - https://phabricator.wikimedia.org/T138616#2405399 (10Dvorapa) [16:40:11] 10VisualEditor: Add a hook if user switches editors - https://phabricator.wikimedia.org/T138616#2405411 (10Dvorapa) [16:41:18] 10VisualEditor: Add a hook if user switches editors - https://phabricator.wikimedia.org/T138616#2405399 (10Dvorapa) [16:42:23] 10VisualEditor: Add a hook if user switches editors - https://phabricator.wikimedia.org/T138616#2405413 (10Dvorapa) [16:43:20] (03CR) 10Tpt: "> it does remove the (theoretical, never used or announced) ability for config/extensions to disable VE on particular content models… Eh." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295936 (https://phabricator.wikimedia.org/T138489) (owner: 10Tpt) [16:46:19] 10VisualEditor, 07Browser-Tests, 13Patch-For-Review, 15User-zeljkofilipin: Fix language screenshots browser test on VisualEditor - https://phabricator.wikimedia.org/T119482#2405420 (10zeljkofilipin) [16:55:55] (03CR) 10Jforrester: [C: 032] "Aha, yes. Let's do this then." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295936 (https://phabricator.wikimedia.org/T138489) (owner: 10Tpt) [17:04:15] (03Merged) 10jenkins-bot: Allow extensions to register a specific target per content model [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295936 (https://phabricator.wikimedia.org/T138489) (owner: 10Tpt) [17:10:44] ypnos: OK, I tried, for Se works as expected, but for VE surprisingly not [17:10:46] http://pastebin.com/PtcdENiV [17:12:25] maybe I should detect another element (just the top bar or something) [17:17:11] * Dvorapa loves Google Dart even more [17:18:12] interesting [17:18:36] did you try adding an alert or console.info() to see if it gets triggered before the mw.hook line? [17:18:48] I'll try [17:25:26] OK this is weird [17:27:24] It works as expected, until I switch from SE to VE (it works for Edit, Edit source and for Edit and then Edit source, but it doesn't work for Edit source and then Edit [17:28:12] It does pass both initialize, it does pass ve.saveDialog.stateChanged hook [17:29:02] But it does not fire ve.init.target.saveDialog.$body.find('.ve-ui-mwSaveDialog-summary textarea'); [17:29:19] *find [17:29:23] (not fire) [17:30:45] maybe ve.init.target is not valid anymore [17:31:17] but only if I switch from SE to VE, if I initialize VE directly, it is ok [17:51:37] finally it was in my gadget [17:55:57] (03PS1) 10Esanders: Add multi-language support for screenshots [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295959 [18:15:38] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource: Writing manual s into header/footer using VisualEditor with ProofreadPage corrupts the page - https://phabricator.wikimedia.org/T138604#2405621 (10Zdzislaw) >>! In T138604#2405228, @Jdforrester-WMF wrote: > OK, so, first thing f... [18:27:39] (03PS1) 10Esanders: Groups some tasks into sessions to improve performance [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295963 [19:54:02] (03CR) 10Jforrester: "As the screenshots task isn't ever passed to RL, I don't think it should be in modules/; normally we put these in tasks/ or build/tasks/ —" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295924 (https://phabricator.wikimedia.org/T119482) (owner: 10Esanders) [20:32:18] 10VisualEditor, 10ProofreadPage, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Sometimes the regular pagetarget gets loaded, not the proofreadpage target (due to a concurrency issue and a double-loading one) - https://phabricator.wikimedia.org/T138489#2405762 (10Jdforrester-WMF) 05Open>03Resolved a:03Tpt [21:34:06] 10VisualEditor: Minor edit checkbox should have id or class - https://phabricator.wikimedia.org/T138631#2405855 (10Dvorapa) [21:44:41] 10VisualEditor: Minor edit checkbox should have id or class - https://phabricator.wikimedia.org/T138631#2405871 (10Dvorapa) [21:56:35] 10VisualEditor: Minor edit checkbox should have id or class - https://phabricator.wikimedia.org/T138631#2405886 (10Dvorapa) [23:11:33] 10VisualEditor, 10MassMessage: Visual editor for MassMessage - https://phabricator.wikimedia.org/T138636#2405993 (10Harej) [23:16:28] 10VisualEditor, 10MassMessage: Allow using VisualEditor on Special:MassMessage - https://phabricator.wikimedia.org/T138636#2406021 (10Legoktm) [23:24:51] (03PS1) 10Alex Monk: Make citoid-template-type-map.json message always exist [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/295971 (https://phabricator.wikimedia.org/T138574) [23:25:15] 10Citoid, 10VisualEditor, 13Patch-For-Review: Citoid registers a dependency on "citoid-template-type-map.json" but it doesn't exist - https://phabricator.wikimedia.org/T138574#2406027 (10AlexMonk-WMF) a:03AlexMonk-WMF [23:26:49] 10Cite, 10VisualEditor: Cite registers a dependency on "visualeditor-cite-tool-definition.json" but it doesn't exist - https://phabricator.wikimedia.org/T138573#2406028 (10AlexMonk-WMF) a:03AlexMonk-WMF