[00:30:13] 10TemplateData, 10VisualEditor, 07Technical-Debt: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2413367 (10Krinkle) >>! In T127958#2077206, @Jdforrester-WMF wrote: > We could upgrade-on-edit, I suppose? For on-edit in TemplateDataGenerator, an automat... [00:36:43] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Enable VisualEditor by default for all users of the Chinese Wikivoyage - https://phabricator.wikimedia.org/T136996#2413372 (10Liuxinyu970226) [00:50:37] 10TemplateData, 10VisualEditor, 07Technical-Debt: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2413382 (10Dvorapa) @Krinkle It looks acceptable for this, T138200 and T127969 too [01:27:28] 10VisualEditor: Cannot load VE in Beta cluster, showing error"TypeError: obj is undefined" - https://phabricator.wikimedia.org/T138893#2413412 (10Ryasmeen) [01:32:25] 10VisualEditor: Unchecking Styled (Wikitable) does not change the table property - https://phabricator.wikimedia.org/T138896#2413450 (10Ryasmeen) [02:30:18] 10VisualEditor, 10VisualEditor-MediaWiki: "Uncaught TypeError: Cannot read property '0' of undefined" and VE not loading when repeatedly switching back and forth between read and edit modes - https://phabricator.wikimedia.org/T135387#2413545 (10AlexMonk-WMF) a:03AlexMonk-WMF The original steps worked for me.... [02:34:49] 10VisualEditor, 10VisualEditor-MediaWiki: "Uncaught TypeError: Cannot read property '0' of undefined" and VE not loading when repeatedly switching back and forth between read and edit modes - https://phabricator.wikimedia.org/T135387#2413547 (10AlexMonk-WMF) Looks like it may be this, in DAT.init.js: ```lang=j... [02:59:36] (03PS1) 10Alex Monk: Replace section edit click handlers in DAT instead of doing it badly in init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296496 (https://phabricator.wikimedia.org/T135387) [03:00:43] I keep seeing this in console: [03:00:44] Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null [03:01:14] from ve.ui.PositionedTargetToolbar.onViewportResize called by ve.ui.PositionedTargetToolbar.onWindowScroll [03:01:18] sounds like your thing edsanders? [04:11:17] 10TemplateData, 10VisualEditor, 07Technical-Debt: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2413629 (10ssastry) I think it might be good to fix T138200 (which seems like a potential easy/quick fix) before undertaking this bigger change since deploy... [08:27:28] 10VisualEditor, 07Design: Consider changing the highlight color in the Search tool - https://phabricator.wikimedia.org/T138914#2413838 (10Elitre) [09:51:57] (03CR) 10Jforrester: [C: 032] screenshots: Add task for cite button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296461 (owner: 10Esanders) [09:52:32] (03CR) 10Jforrester: [C: 031] screenshots: Crop to viewport [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296462 (owner: 10Esanders) [09:53:03] (03CR) 10Jforrester: [C: 032] Execute the EditFormPreloadText hook on load for non-existent pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295906 (https://phabricator.wikimedia.org/T138588) (owner: 10Tpt) [09:59:31] (03Merged) 10jenkins-bot: screenshots: Add task for cite button [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296461 (owner: 10Esanders) [09:59:33] (03Merged) 10jenkins-bot: Execute the EditFormPreloadText hook on load for non-existent pages [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295906 (https://phabricator.wikimedia.org/T138588) (owner: 10Tpt) [10:10:51] (03CR) 10Jforrester: [C: 032] Follow-up I454380c3: Handle rename of Cite extension's messages [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/296472 (owner: 10Alex Monk) [10:18:37] (03Merged) 10jenkins-bot: Follow-up I454380c3: Handle rename of Cite extension's messages [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/296472 (owner: 10Alex Monk) [10:21:53] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10ProofreadPage, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Execute the EditFormPreloadText hook in VE-MW on empty page load - https://phabricator.wikimedia.org/T138588#2414109 (10Jdforrester-WMF) 05Open>03Resolved [10:26:52] 10VisualEditor: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#1751433 (10Jdforrester-WMF) >>! In T116520#2407333, @Ciencia_Al_Poder wrote: > This is not an iOS-safari problem only. This happens also on Mozilla Firefox and Google Chrome: No. The bug you're... [10:27:04] 10VisualEditor, 07Browser-Support-Apple-Safari: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#2414127 (10Jdforrester-WMF) [11:03:48] 10VisualEditor: Unchecking Styled (Wikitable) does not change the table property - https://phabricator.wikimedia.org/T138896#2414229 (10Jdforrester-WMF) 05Open>03stalled It does for me on Beta Cluster (testing just now). Do you have a particular page on which this happened? [12:05:27] (03CR) 10Jforrester: [C: 031] Move around parameter renaming logic to update paramOrder [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/296401 (https://phabricator.wikimedia.org/T138800) (owner: 10Alex Monk) [12:09:22] (03CR) 10Esanders: [C: 04-1] Move around parameter renaming logic to update paramOrder (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/296401 (https://phabricator.wikimedia.org/T138800) (owner: 10Alex Monk) [12:09:55] 10VisualEditor: Cannot load VE in Beta cluster, showing error"TypeError: obj is undefined" - https://phabricator.wikimedia.org/T138893#2414482 (10Jdforrester-WMF) 05Open>03stalled Can't reproduce. Temporary bug? [12:11:06] (03CR) 10Esanders: [C: 032] Replace section edit click handlers in DAT instead of doing it badly in init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296496 (https://phabricator.wikimedia.org/T135387) (owner: 10Alex Monk) [12:11:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 10Parsoid: External link wrongly serialised with internal link syntax - https://phabricator.wikimedia.org/T138864#2414501 (10Jdforrester-WMF) [12:11:58] (03CR) 10Esanders: [C: 032] When logging in, if VEE cookie is set, change the user's preference to match it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295312 (https://phabricator.wikimedia.org/T133304) (owner: 10Alex Monk) [12:12:26] (03CR) 10Esanders: [C: 032] Change 'Cite' label to 'Citation' if the tool is going to be moved into the Insert menu instead [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/287847 (https://phabricator.wikimedia.org/T133727) (owner: 10Alex Monk) [12:17:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 10Parsoid: External link wrongly serialised with internal link syntax - https://phabricator.wikimedia.org/T138864#2412413 (10Jdforrester-WMF) Yes, `//tools.wmflabs.org/wi... [12:18:00] 10TemplateData, 10VisualEditor, 13Patch-For-Review: When you change the name of a parameter, ParamOrder should get updated to use the new name - https://phabricator.wikimedia.org/T138800#2410688 (10Jdforrester-WMF) p:05Triage>03High [12:18:51] (03Merged) 10jenkins-bot: Replace section edit click handlers in DAT instead of doing it badly in init [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296496 (https://phabricator.wikimedia.org/T135387) (owner: 10Alex Monk) [12:19:49] 10VisualEditor, 10VisualEditor-MediaWiki: On SET wikis/"Remember my last editor", section edit links say "Edit" even when they mean "Edit source" - https://phabricator.wikimedia.org/T137424#2414539 (10Jdforrester-WMF) p:05Triage>03Low [12:20:14] (03Merged) 10jenkins-bot: When logging in, if VEE cookie is set, change the user's preference to match it [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295312 (https://phabricator.wikimedia.org/T133304) (owner: 10Alex Monk) [12:20:16] (03Merged) 10jenkins-bot: Change 'Cite' label to 'Citation' if the tool is going to be moved into the Insert menu instead [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/287847 (https://phabricator.wikimedia.org/T133727) (owner: 10Alex Monk) [12:32:49] (03CR) 10Jforrester: [C: 032] screenshots: Add task for link inspector search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296463 (owner: 10Esanders) [12:32:58] (03CR) 10Jforrester: [C: 032] screenshots: Crop to viewport [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296462 (owner: 10Esanders) [12:33:52] 10VisualEditor, 10VisualEditor-MediaWiki: "Uncaught TypeError: Cannot read property '0' of undefined" and VE not loading when repeatedly switching back and forth between read and edit modes - https://phabricator.wikimedia.org/T135387#2414554 (10Jdforrester-WMF) 05Open>03Resolved [12:34:09] 10VisualEditor, 10VisualEditor-MediaWiki: SET does not seem to respect user's existing cookie if no preference is set - https://phabricator.wikimedia.org/T133304#2414557 (10Jdforrester-WMF) 05Open>03Resolved [12:37:17] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: At Wikivoyage, move the Cite button into the Insert menu - https://phabricator.wikimedia.org/T133725#2414591 (10Jdforrester-WMF) [12:37:19] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Make it possible to push the cite menu into the "insert" (other) toolbar bucket - https://phabricator.wikimedia.org/T133727#2414590 (10Jdforrester-WMF) 05Open>03Resolved [12:39:56] (03Merged) 10jenkins-bot: screenshots: Crop to viewport [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296462 (owner: 10Esanders) [12:40:21] (03Merged) 10jenkins-bot: screenshots: Add task for link inspector search results [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296463 (owner: 10Esanders) [12:40:57] (03PS3) 10Jforrester: Move around parameter renaming logic to update paramOrder [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/296401 (https://phabricator.wikimedia.org/T138800) (owner: 10Alex Monk) [12:41:12] (03CR) 10Jforrester: Move around parameter renaming logic to update paramOrder (031 comment) [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/296401 (https://phabricator.wikimedia.org/T138800) (owner: 10Alex Monk) [12:41:18] (03CR) 10Jforrester: [C: 032] Move around parameter renaming logic to update paramOrder [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/296401 (https://phabricator.wikimedia.org/T138800) (owner: 10Alex Monk) [12:41:42] 10TemplateData, 10VisualEditor: When you change the name of a parameter, ParamOrder should get updated to use the new name - https://phabricator.wikimedia.org/T138800#2414625 (10Jdforrester-WMF) 05Open>03Resolved [12:44:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: At Wikivoyage, move the Cite button into the Insert menu - https://phabricator.wikimedia.org/T133725#2414634 (10Jdforrester-WMF) 05stalled>03Open [12:52:29] (03PS1) 10Esanders: screenshots: References list dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296564 [12:52:31] (03PS1) 10Esanders: screenshots: Add delay to wait for link inspector images to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296565 [12:53:09] (03CR) 10Jforrester: [C: 032] screenshots: Add delay to wait for link inspector images to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296565 (owner: 10Esanders) [12:53:18] (03CR) 10Jforrester: [C: 032] screenshots: References list dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296564 (owner: 10Esanders) [12:56:44] (03Merged) 10jenkins-bot: Move around parameter renaming logic to update paramOrder [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/296401 (https://phabricator.wikimedia.org/T138800) (owner: 10Alex Monk) [12:59:13] (03CR) 10Esanders: [C: 032] DesktopContext: Positioning a maybe-floated not-embeddable popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/294524 (https://phabricator.wikimedia.org/T137546) (owner: 10DLynch) [13:00:30] (03Merged) 10jenkins-bot: screenshots: References list dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296564 (owner: 10Esanders) [13:01:47] (03Merged) 10jenkins-bot: screenshots: Add delay to wait for link inspector images to load [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296565 (owner: 10Esanders) [13:08:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests, 13Patch-For-Review: At Wikivoyage, move the Cite button into the Insert menu - https://phabricator.wikimedia.org/T133725#2414699 (10Jdforrester-WMF) Scheduled for late Wednesday next week. [13:09:49] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link inspector ends up in the wrong position on short pages with long suggestions - https://phabricator.wikimedia.org/T137546#2414701 (10Jdforrester-WMF) 05Open>03Resolved [13:10:31] (03Merged) 10jenkins-bot: DesktopContext: Positioning a maybe-floated not-embeddable popup [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/294524 (https://phabricator.wikimedia.org/T137546) (owner: 10DLynch) [13:18:35] (03PS1) 10Esanders: screenshots: Add screenshots for highlighted items in the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296577 [13:28:29] (03CR) 10Jforrester: [C: 04-1] "Per Ed, has some issues where shots are of the menu collapsed when they shouldn't be." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296577 (owner: 10Esanders) [13:32:37] (03PS2) 10Esanders: screenshots: Add screenshots for highlighted items in the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296577 [13:35:03] (03PS1) 10Jforrester: Update OOjs UI to v0.17.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/296579 [13:38:00] (03CR) 10Jforrester: [C: 032] screenshots: Add screenshots for highlighted items in the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296577 (owner: 10Esanders) [13:40:02] 10VisualEditor: VisualEdior can be started when page is protected / semiprotected - https://phabricator.wikimedia.org/T138716#2414757 (10Jdforrester-WMF) [13:40:04] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Provide a "view VE" mode for protected pages - https://phabricator.wikimedia.org/T53547#2414759 (10Jdforrester-WMF) [13:46:30] (03Merged) 10jenkins-bot: screenshots: Add screenshots for highlighted items in the insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296577 (owner: 10Esanders) [13:55:32] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 07Epic: Adding or updating a reference in VisualEditor does not update fake references blocks inside templates - https://phabricator.wikimedia.org/T52769#2414785 (10Ciencia_Al_Poder) [14:00:44] 10VisualEditor, 07Browser-Support-Apple-Safari: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#2414810 (10Ciencia_Al_Poder) @Jdforrester-WMF I don't see how is it different from T52769, that page has not a but a template containing it... Th... [14:07:18] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 07Epic: Adding or updating a reference in VisualEditor does not update fake references blocks inside templates - https://phabricator.wikimedia.org/T52769#2414821 (10Ciencia_Al_Poder) >>! In T52769#541738, @Jdforrester-WMF wrote: > Note that we... [14:09:56] (03PS1) 10Esanders: screenshots: De-duplicate menu screenshotting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296587 [14:10:11] (03CR) 10Esanders: [C: 032] screenshots: Run on enwiki rather than Beta Cluster for content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296586 (owner: 10Jforrester) [14:11:13] (03PS2) 10Esanders: screenshots: De-duplicate menu screenshotting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296587 [14:13:00] (03PS2) 10Esanders: screenshots: Correct name of a list menu screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296585 (owner: 10Jforrester) [14:13:12] (03CR) 10Esanders: [C: 032] screenshots: Correct name of a list menu screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296585 (owner: 10Jforrester) [14:14:23] (03CR) 10Esanders: [C: 032] Update OOjs UI to v0.17.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/296579 (owner: 10Jforrester) [14:14:38] (03CR) 10Jforrester: [C: 032] screenshots: De-duplicate menu screenshotting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296587 (owner: 10Esanders) [14:19:28] (03Merged) 10jenkins-bot: screenshots: Correct name of a list menu screenshot [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296585 (owner: 10Jforrester) [14:22:37] (03Merged) 10jenkins-bot: Update OOjs UI to v0.17.5 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/296579 (owner: 10Jforrester) [14:23:33] (03Merged) 10jenkins-bot: screenshots: De-duplicate menu screenshotting code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296587 (owner: 10Esanders) [14:29:45] 10VisualEditor, 07Browser-Support-Apple-Safari: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#2414827 (10Jdforrester-WMF) >>! In T116520#2414810, @Ciencia_Al_Poder wrote: > @Jdforrester-WMF I don't see how is it different from T52769, that page has not a... [14:29:56] 10VisualEditor, 07Browser-Support-Apple-Safari: [iOS Safari on desktop site] References do not get updated - https://phabricator.wikimedia.org/T116520#2414828 (10Jdforrester-WMF) [14:29:59] 10VisualEditor, 10VisualEditor-MediaWiki-References, 10Parsoid, 07Epic: Adding or updating a reference in VisualEditor does not update fake references blocks inside templates - https://phabricator.wikimedia.org/T52769#2414830 (10Jdforrester-WMF) [14:30:16] (03PS2) 10Jforrester: screenshots: Run on enwiki rather than Beta Cluster for content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296586 [14:30:25] (03CR) 10Jforrester: [C: 032] screenshots: Run on enwiki rather than Beta Cluster for content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296586 (owner: 10Jforrester) [14:38:05] (03Merged) 10jenkins-bot: screenshots: Run on enwiki rather than Beta Cluster for content [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296586 (owner: 10Jforrester) [14:59:47] (03PS1) 10Esanders: screenshots: Add category menu item task [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296594 [15:02:53] (03PS2) 10Esanders: screenshots: Add category and page settings menu item tasks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296594 [15:22:15] 10VisualEditor: VE seems to be able to "add" links to files that are (probably) stored on the editor's local hard drive - https://phabricator.wikimedia.org/T138956#2414935 (10Amire80) [15:36:08] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Q4 personal goal: start building a volunteer, cross-wiki taskforce to help with the community side of VE work - https://phabricator.wikimedia.org/T130533#2414967 (10Elitre) [15:36:25] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Q4 personal goal: start building a volunteer, cross-wiki taskforce to help with the community side of VE work - https://phabricator.wikimedia.org/T130533#2138685 (10Elitre) [15:42:48] 10TemplateData, 10VisualEditor: TemplateData: Normalisation should not assume paramOrder - https://phabricator.wikimedia.org/T138200#2414973 (10Krinkle) [15:43:12] 10TemplateData, 10VisualEditor: TemplateData: Normalisation should not assume paramOrder - https://phabricator.wikimedia.org/T138200#2392996 (10Krinkle) [15:43:14] 10TemplateData, 10VisualEditor, 07Technical-Debt: TemplateData shouldn't store paramOrder as a separate list - https://phabricator.wikimedia.org/T127958#2414974 (10Krinkle) [15:45:09] 10TemplateData, 10VisualEditor: TemplateData: Normalisation should not assume paramOrder - https://phabricator.wikimedia.org/T138200#2414976 (10Krinkle) LGTM. Let's remove the auto-creation of this property from the parser normalisation. The specification does not describe `paramOrder` as required, and for ba... [15:48:51] 10TemplateData, 10VisualEditor: TemplateData: Normalisation should not assume paramOrder - https://phabricator.wikimedia.org/T138200#2414985 (10ssastry) >>! In T138200#2414976, @Krinkle wrote: > Let's verify (or fix) VisualEditor and Parsoid to indeed not assume the existence of `paramOrder` and function prope... [16:02:02] (03CR) 10Esanders: MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288650 (https://phabricator.wikimedia.org/T97482) (owner: 10Jforrester) [16:04:24] 10TemplateData, 10VisualEditor: Support a TemplateData parameter type of "Regex" - https://phabricator.wikimedia.org/T125101#1974395 (10Krinkle) We already have types for `number`, `date`, and `url` (which are sometimes validated in Lua modules using a regex). T53375 (approved) will provide a way to provide a... [16:05:48] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 07Design: Create dedicated input methods for transclusion parameters (using "Param#type" from TemplateData) - https://phabricator.wikimedia.org/T55613#2415019 (10Krinkle) [16:06:23] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: Create dedicated input methods for "string" transclusion parameters - https://phabricator.wikimedia.org/T124917#2415020 (10Krinkle) [16:07:52] (03CR) 10Esanders: [C: 032] "Could be upstreamed into MW core later" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294393 (owner: 10Divec) [16:08:28] (03CR) 10Esanders: [C: 032] Fix our display of redirects during and after editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294531 (owner: 10Alex Monk) [16:08:48] (03CR) 10Esanders: [C: 032] Tell the client whether we created a redirect or not properly. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294536 (https://phabricator.wikimedia.org/T136546) (owner: 10Alex Monk) [16:09:17] (03CR) 10Esanders: [C: 032] Set an automatic summary of empty string when switching from VE into WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294526 (https://phabricator.wikimedia.org/T135979) (owner: 10Alex Monk) [16:09:19] (03CR) 10Jforrester: [C: 032] screenshots: Add category and page settings menu item tasks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296594 (owner: 10Esanders) [16:10:02] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Enable multiline TemplateData descriptions with \n - https://phabricator.wikimedia.org/T115641#1728880 (10Krinkle) >>! In T115641#1937714, @Krenair wrote: >
would be part of T52656, but I think we should probably make \n get handled as a newline?... [16:10:45] (03CR) 10Esanders: [C: 04-1] Hack to not show menu immediately upon meta dialog opening for redirect change (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294359 (https://phabricator.wikimedia.org/T137309) (owner: 10Alex Monk) [16:12:15] 10TemplateData, 10VisualEditor: Changing parameter doesn't adjust the paramOrder list, leaving it out of sync - https://phabricator.wikimedia.org/T127969#2059878 (10Krinkle) For TemplateDataGenerator this can be (or already is) handled. For wikitext, we can emit save errors, but transforming it automatically... [16:14:44] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: Enable multiline TemplateData descriptions with \n - https://phabricator.wikimedia.org/T115641#2415041 (10Jdforrester-WMF) 05Open>03declined Agreed. On reflection, I'm going to Decline. [16:15:43] (03Merged) 10jenkins-bot: New decodeURIComponentIntoArticleTitle method [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294393 (owner: 10Divec) [16:15:46] (03Merged) 10jenkins-bot: Fix our display of redirects during and after editing [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294531 (owner: 10Alex Monk) [16:16:56] (03Merged) 10jenkins-bot: Tell the client whether we created a redirect or not properly. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294536 (https://phabricator.wikimedia.org/T136546) (owner: 10Alex Monk) [16:16:59] (03Merged) 10jenkins-bot: Set an automatic summary of empty string when switching from VE into WTE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294526 (https://phabricator.wikimedia.org/T135979) (owner: 10Alex Monk) [16:17:28] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Creating a new redirect in VE results in being redirected to the target instead of viewing the newly created page - https://phabricator.wikimedia.org/T136546#2415076 (10Jdforrester-WMF) 05Open>03Resolved [16:17:54] 10VisualEditor, 10VisualEditor-MediaWiki: After switching from VE to wikitext, you're warned about the summary being missing even if you have one (because it's the same as it starts with) - https://phabricator.wikimedia.org/T135979#2415077 (10Jdforrester-WMF) 05Open>03Resolved [16:20:19] (03Merged) 10jenkins-bot: screenshots: Add category and page settings menu item tasks [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296594 (owner: 10Esanders) [16:22:01] (03CR) 10Jforrester: [C: 04-1] "Needs a rebase; switch to ApiVisualEditor::getAvailableNamespaceIds conflicts?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 (owner: 10Alex Monk) [16:25:20] (03CR) 10Esanders: [C: 032] Fix display of subpage breadcrumbs show after save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281463 (https://phabricator.wikimedia.org/T97700) (owner: 10Alex Monk) [16:29:20] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Q4 personal goal: Facilitate deployment of VisualEditor at Phase 6 wikis - https://phabricator.wikimedia.org/T96500#2415157 (10Elitre) [16:29:24] 10VisualEditor, 10Wikimedia-Site-requests, 07User-notice: Enable VisualEditor by default for all users of all "phase 6" Wikipedias - https://phabricator.wikimedia.org/T93387#2415158 (10Elitre) [16:29:42] edsanders, hey [16:30:11] (03CR) 10Esanders: [C: 04-1] "I don't think this should be a ve-specific event on the textarea - but rather a generic mw hook that says that the page content is about t" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747) (owner: 10Alex Monk) [16:30:25] Krenair: hi [16:30:37] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 07Epic: Make VisualEditor good enough for mobile tablet and phone default enablement - https://phabricator.wikimedia.org/T94725#2415163 (10Jdforrester-WMF) [16:30:39] Thanks for reviewing most of my commits [16:30:41] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 07Design, 07Epic, 13Patch-For-Review: Agree a new overall design for VisualEditor on mobile phone-sized devices - https://phabricator.wikimedia.org/T93325#2415162 (10Jdforrester-WMF) 05Open>03stalled [16:30:44] Did you see my message about getToolbarDialogs? [16:31:03] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Enable VisualEditor by default for all users of the Chinese Wikivoyage - https://phabricator.wikimedia.org/T136996#2415165 (10Jdforrester-WMF) 05Open>03stalled [16:31:43] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Q4 personal goal: Facilitate deployment of VisualEditor at Phase 6 wikis - https://phabricator.wikimedia.org/T96500#2415168 (10Elitre) 05stalled>03Resolved Further Phase 6 wikis will be tracked on different tasks. [16:32:14] 10VisualEditor, 10MediaWiki-Vagrant, 13Patch-For-Review: visualeditor loading fails on local vagrant instance - https://phabricator.wikimedia.org/T138659#2406639 (10Jdforrester-WMF) p:05Triage>03Low [16:35:15] 10TemplateData, 10VisualEditor, 13Patch-For-Review, 07RfC, 07User-notice: Add support for actual format strings to TemplateData's "format" parameter - https://phabricator.wikimedia.org/T138492#2415177 (10Jdforrester-WMF) This probably needs to specify whether the template has to sit on its own line or in... [16:35:31] 10TemplateData, 10VisualEditor, 13Patch-For-Review, 07User-notice: Add support for actual format strings to TemplateData's "format" parameter - https://phabricator.wikimedia.org/T138492#2415178 (10Jdforrester-WMF) p:05Triage>03Low [16:40:08] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic, 13Patch-For-Review: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2415209 (10Jdforrester-WMF) p:05Normal>03High [16:40:13] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10VisualEditor-MediaWiki-References: References in media captions do not appear in Re-Use Reference list - https://phabricator.wikimedia.org/T87134#2415211 (10Jdforrester-WMF) [16:40:15] 10VisualEditor, 10VisualEditor-ContentEditable: Provide true nested, inheriting surfaces - https://phabricator.wikimedia.org/T76550#2415212 (10Jdforrester-WMF) [16:40:17] 10VisualEditor, 10VisualEditor-Performance, 07Performance: Explore performance gains from progressive (JIT?) de-alienation of content types in VisualEditor - https://phabricator.wikimedia.org/T76544#2415213 (10Jdforrester-WMF) [16:40:19] 10VisualEditor, 10VisualEditor-DataModel: VisualEditor: When adding a reference, and a reference in a caption, in the same edit, then the ref in the caption is changed to the ref from the text - https://phabricator.wikimedia.org/T60322#2415215 (10Jdforrester-WMF) [16:40:21] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor: "Use an Existing Reference" option remains disabled for a reference inside Media Settings while there is a reference available to re-use in the page - https://phabricator.wikimedia.org/T62919#2415214 (10Jdforrester-WMF) [16:40:23] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10MediaWiki-extensions-Translate: Create a VisualEditor plugin tool to add/edit translations and translation variables (Translate extension) - https://phabricator.wikimedia.org/T55974#2415216 (10Jdforrester-WMF) [16:40:25] 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor: Rich content copied from sub-documents (image captions, references, etc.) down-cast to plain text when the sub-document is closed - https://phabricator.wikimedia.org/T53725#2415217 (10Jdforrester-WMF) [16:40:27] 10VisualEditor, 10VisualEditor-Performance, 07Epic, 13Patch-For-Review, and 2 others: Internal nodes should eventually be in a separate document ("sub-documents") - https://phabricator.wikimedia.org/T49344#2415210 (10Jdforrester-WMF) 05Open>03stalled [16:40:29] 10VisualEditor, 10VisualEditor-DataModel, 10VisualEditor-MediaWiki-References, 07Epic: In VisualEditor, references in templates cannot be reused and are numbered separately from references in the text. - https://phabricator.wikimedia.org/T52474#2415218 (10Jdforrester-WMF) [16:40:31] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 07Performance: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#2415219 (10Jdforrester-WMF) [16:41:07] (03Merged) 10jenkins-bot: Fix display of subpage breadcrumbs show after save [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/281463 (https://phabricator.wikimedia.org/T97700) (owner: 10Alex Monk) [16:43:37] Np [16:44:15] edsanders: [16:44:17] I keep seeing this in console: [16:44:17] Uncaught TypeError: Cannot read property 'getToolbarDialogs' of null [16:44:17] from ve.ui.PositionedTargetToolbar.onViewportResize called by ve.ui.PositionedTargetToolbar.onWindowScroll [16:45:30] 10VisualEditor, 10VisualEditor-MediaWiki: Subpage breadcrumbs not shown after saving the page with VisualEditor - https://phabricator.wikimedia.org/T97700#2415238 (10Jdforrester-WMF) 05Open>03Resolved [16:47:11] Krenair: That's sort of weird. The call to surface. getToolbarDialogs() comes after a call to surface.getViewportDimensions(), so I'm not sure why it wouldn't be failing on the first one instead. [16:48:19] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links, 10Parsoid: External link wrongly serialised with internal link syntax - https://phabricator.wikimedia.org/T138864#2412413 (10ssastry) This is an edge case bug in Parsoid html2wt ... ``` [subbu@earth lib] echo '03Open Actually it happens for a page which has map in it. Try here: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:RYasmeen_(WM... [17:06:13] (03PS1) 10Jforrester: Update VE core submodule to master (3ea50c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296608 [17:08:20] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (3ea50c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296608 (owner: 10Jforrester) [17:11:23] jaufrecht, hey [17:11:37] yo. [17:11:43] phlogiston.wmflabs.org points to http://phlogiston-1.phlogiston.eqiad.wmflabs:80 [17:11:50] But: [17:11:52] | ab9a7a7b-709f-4bb6-9f33-c56942f30ab5 | phlogiston-1 | ERROR | - | Shutdown | public=10.68.18.67 | [17:12:01] | a734e77c-1ba4-4ed7-babf-9e78c73f1a91 | phlogiston-2 | ACTIVE | - | Running | public=10.68.19.110 | [17:12:15] phlogiston-1 is broken [17:12:18] has been for a few days [17:12:19] https://phabricator.wikimedia.org/T137736 [17:12:27] phlogiston-dev (phlogiston-2) is working [17:12:32] although it's also a bit crashy [17:13:12] difference being that phlogiston-2 responds to reboot commands from the wikitech control panel, but as of the last few weeks, phlogiston-1 has required as sysadmin to reboot when it dies, and since Monday even that hasn't worked [17:14:09] krenair@silver:~$ OS_TENANT_NAME=phlogiston nova console-log phlogiston-1 [17:14:10] Ubuntu 14.04.3 LTS phlogiston-1 ttyS0 [17:14:10] phlogiston-1 login: [17:14:10]  [17:14:17] that's all that's in the log :/ [17:14:49] Cannot 'start' instance ab9a7a7b-709f-4bb6-9f33-c56942f30ab5 while it is in vm_state error (HTTP 409) [17:14:58] yeah this needs proper labs ops to fix [17:15:41] let's see if I can find someone to do it [17:16:49] (03Merged) 10jenkins-bot: Update VE core submodule to master (3ea50c4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296608 (owner: 10Jforrester) [17:19:51] jaufrecht, Chase will look after lunch [17:20:29] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Make the VisualEditor/ProofreadPage integration good enough to enable by default - https://phabricator.wikimedia.org/T138966#2415386 (10Jdforrester-WMF) [17:20:44] great, thanks [17:21:57] 10VisualEditor, 10ProofreadPage, 13Patch-For-Review: Execution of ?veaction=edit sometimes fails on Page: pages, emitting "Error: No class registered by that name: proofread-page" - https://phabricator.wikimedia.org/T138644#2415404 (10Jdforrester-WMF) [17:21:59] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource: Writing manual s into header/footer using VisualEditor with ProofreadPage corrupts the page - https://phabricator.wikimedia.org/T138604#2415405 (10Jdforrester-WMF) [17:22:01] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10ProofreadPage, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): Execute the EditFormPreloadText hook in VE-MW on empty page load - https://phabricator.wikimedia.org/T138588#2415406 (10Jdforrester-WMF) [17:22:03] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Make it impossible for people to add things before the PageQuality tag in VE - https://phabricator.wikimedia.org/T138518#2415408 (10Jdforrester-WMF) [17:22:06] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Makes VE -> Wikitext switch work (with changes) for Page: pages - https://phabricator.wikimedia.org/T138538#2415407 (10Jdforrester-WMF) [17:22:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: ProofreadPageTarget dirty diffing - https://phabricator.wikimedia.org/T138472#2415410 (10Jdforrester-WMF) [17:22:10] 10VisualEditor, 10ProofreadPage, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Sometimes the regular pagetarget gets loaded, not the proofreadpage target (due to a concurrency issue and a double-loading one) - https://phabricator.wikimedia.org/T138489#2415409 (10Jdforrester-WMF) [17:22:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 13Patch-For-Review, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Switching from WT to VE in ProofreadPage (using the pencil) leads to an odd, broken editor - https://phabricator.wikimedia.org/T138393#2415411 (10Jdforrester-WMF) [17:22:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource, and 2 others: Get rid of
which spans multiple sections, so that each section is balanced HTML - https://phabricator.wikimedia.org/T133294#2415412 (10Jdforrester-WMF) [17:22:15] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Make the VisualEditor/ProofreadPage integration good enough to enable by default - https://phabricator.wikimedia.org/T138966#2415402 (10Jdforrester-WMF) [17:22:18] 10VisualEditor, 10ProofreadPage, 06Wikisource, 05WMF-deploy-2016-06-28_(1.28.0-wmf.8): Add the visual editor to Wikisource - https://phabricator.wikimedia.org/T93525#2415413 (10Jdforrester-WMF) [17:22:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Plugins, 10ProofreadPage, and 6 others: Create a VisualEditor plugin to integrate with ProofreadPage - https://phabricator.wikimedia.org/T48580#2415414 (10Jdforrester-WMF) [17:22:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: Make the VisualEditor/ProofreadPage integration good enough to enable by default - https://phabricator.wikimedia.org/T138966#2415386 (10Jdforrester-WMF) [17:22:29] 10VisualEditor, 10Wikimedia-Site-requests, 06Wikisource, 07User-notice: Enable VisualEditor by default for all users of all Wikisources - https://phabricator.wikimedia.org/T138391#2415441 (10Jdforrester-WMF) [17:23:01] 10VisualEditor, 10VisualEditor-MediaWiki, 07Community-consensus-needed, 13Patch-For-Review: Enable VisualEditor by default for all users of the Chinese Wikivoyage - https://phabricator.wikimedia.org/T136996#2415443 (10zhuyifei1999) >>! In T136996#2357952, @Jdforrester-WMF wrote: > See the discussion at the... [17:28:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: VisualEditor should retrieve content of all Page: pages wikitext editor field when switching from WikiEditor - https://phabricator.wikimedia.org/T138673#2415453 (10AlexMonk-WMF) [17:29:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: VisualEditor should retrieve content of all Page: pages wikitext editor field when switching from WikiEditor - https://phabricator.wikimedia.org/T138673#2415456 (10Jdforrester-WMF) p:05Triage>03Unbreak! [17:43:42] 10VisualEditor, 10VisualEditor-MediaWiki, 07Community-consensus-needed, 13Patch-For-Review: Enable VisualEditor by default for all users of the Chinese Wikivoyage - https://phabricator.wikimedia.org/T136996#2415504 (10Elitre) You probably meant a different link - that one shows no opposition. In any case,... [17:46:49] 10VisualEditor, 06Community-Liaisons (Apr-Jun-2016): Q4 personal goal: start building a volunteer, cross-wiki taskforce to help with the community side of VE work - https://phabricator.wikimedia.org/T130533#2415507 (10Elitre) 05Open>03Resolved Here are the top things I made for this task this quarter: 1)... [18:13:43] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Enable VisualEditor by default for all users of the Chinese Wikivoyage - https://phabricator.wikimedia.org/T136996#2415568 (10zhuyifei1999) [18:17:24] 10VisualEditor: Cannot load VE for a page which contains map, showing error"TypeError: obj is undefined" - https://phabricator.wikimedia.org/T138893#2415585 (10Ryasmeen) [18:36:47] cscott: Hi. I'm working on Collaborative extension for VE. I was using TogetherJS itself. Untill now, I have added collaboration. But the collaboration works only on search box(which is a input field) of the page, not on VE(which is a div). [18:36:55] I just wanted to know how was that TogetherJS extension which you made was working. Was collaboration enabled even within the VE ? [18:37:33] yes, to some degree. it required patches to VE. [18:38:11] sagarhani: these are some of the VE patches: https://gerrit.wikimedia.org/r/#/q/status:open+project:VisualEditor/VisualEditor+branch:master+topic:xact-hi-1,n,z [18:39:39] and more VE support was here: https://github.com/cscott/mediawiki-extensions-togetherjs/blob/master/js/ext.togetherjs.ve.js [18:39:40] cscott: Are these patches are merged with VE or I need to do it locally to my VE ? [18:40:00] the patches were to an old version of VE, they would need to be updated quite a lot. [18:51:22] cscott: Okay, Thanks. I'll look into this. :) [18:51:56] sagarhani: sure. keep me in the loop, if you've got the time I can perhaps help you update the patches. [18:54:23] cscott: Sure. I'm working on this as part of my GSoC project for WikiToLearn.org I got to know that you were held up with hackathon and wikimania so I was waiting for you these days. [18:57:09] sagarhani: cool. i think i've got PDF export patches from wikitolearn.org waiting for me to look at as well. [18:57:18] sagarhani: could you send me a link to your GSoC project description? [18:57:48] https://summerofcode.withgoogle.com/projects/#6727661862780928 [18:59:43] Initially we came up with a new design to build the extension from the scratch. But felt that would be highly difficult. [18:59:54] cscott: This was the design : https://sagarhani.files.wordpress.com/2016/06/workflow.png?w=700 [19:21:36] sagarhani: you might be interested in: https://wikimania2014.wikimedia.org/wiki/Submissions/Real-time_Collaborative_Editing_with_TogetherJS [19:22:00] your proposal is indeed extremely ambitious. but i think you might be able to do it if you ignore visual editor for now and concentrate on wikitext editing. [19:22:05] togetherjs already has reasonable support for that. [19:22:23] it will still be a big project to build all the necessary UX for collaboration, for deciding when everyone is done editing, etc. [19:23:03] there was some discussion on good protocols for deciding whether to save a revision at https://phabricator.wikimedia.org/T112984#1920342 [19:30:42] Slide no.16 : https://docs.google.com/presentation/d/1O-mxmygpSIJE_gjTlEYh4pl1cxW6CYL_0LM4vhEkVKc/edit?pref=2&pli=1#slide=id.g370dc073f_116 [19:31:14] Is that a mockup or a existing one ? [19:39:58] (03PS1) 10Esanders: screenshots: Add task for plain insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296625 [19:40:22] sagarhani: mockup [19:49:12] uhm, guys, are we intentionally loading VE in talk pages now? Twice already a talk page "edit" button for a section loaded VE for me on mediawiki.org [19:49:23] Is this a fluke? [19:50:15] not intentionally [19:50:27] sounds like a section edit bug, Krenair was fixing those recently [19:51:04] is there a task? [20:00:48] Krenair, I just saw it, so not yet [20:00:53] I wasn't sure if it's a local fluke or not [20:01:01] does anyone why VE has just (as in, 10 minutes ago) been disabled in the Research namespace on meta? [20:03:19] Krenair, my test was to try and edit my user talk page: https://www.mediawiki.org/wiki/User_talk:Mooeypoo?action=edit <-- it loads VE [20:03:22] want me to open a ticket? [20:03:45] yes please [20:03:51] I can reproduce the issue [20:05:27] 10VisualEditor: VisualEditor loads on editing talk pages in mw.org - https://phabricator.wikimedia.org/T138980#2415884 (10Mooeypoo) [20:05:31] Krenair, ^^ [20:05:37] wasn't sure what to tag it with except VE [20:05:37] thanks [20:05:42] VisualEditor-MediaWiki [20:05:54] oh, duh. heh. I forgot those tags :) [20:05:57] gets it into my inbox [20:07:25] neilpquinn, I don't, but I see it is disabled there. Last VE edit in that namespace was at 23:55 [20:09:54] neilpquinn, a change could've happened two hours ago theoretically [20:09:59] Krenair: Hmm, interesting. It just changed—I noticed because I had loaded a page right before it was disabled, so I got the edit tab, but when I clicked it, I got an error popup. Is there a trick to force it anymore now that veaction=edit is gone? [20:10:02] maybe caching made it take a while to be noticed [20:10:13] veaction=edit is not gone [20:10:38] ah, actually, maybe 1 hour ago. damn DST [20:11:11] Really? It does nothing when I try it so I assumed it was lost when we switched to SET [20:11:12] 1 hour ago meta switched from 1.28.0-wmf.7 to 1.28.0-wmf.8 [20:11:19] Huh. [20:11:20] really [20:12:35] you might have to change SET mode to multi-tab to use it, I don't know. The mess that is our init logic has gotten so complex with SET that I can't remember what happens in exactly which case anymore [20:12:55] Krenair: oh, I see, I think it doesn't work because the namespace disable overrides it. [20:16:36] no page listing changes in wmf/1.28.0-wmf.8 yet [20:17:27] It should be enabled looking at the config [20:18:04] For some reason I keep typing 'mweval' instead of 'mwrepl' [20:18:20] hphpd> =$wmgVisualEditorAvailableNamespaces[202] [20:18:20] =$wmgVisualEditorAvailableNamespaces[202] [20:18:20] true [20:18:43] (202 = index of the Research namespace) [20:19:24] mooeypoo, neilpquinn: Your issues might be the same thing actually [20:19:27] mw.config.values.wgVisualEditorConfig.namespaces [20:19:28] [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 2, 6, 14, 10] [20:19:41] This can't possibly be right, odd numbered namespaces = talk namespaces [20:19:55] and this doesn't match the server's wmgVisualEditorAvailableNamespaces [20:21:41] ha [20:23:48] will be something in ApiVisualEditor::getAvailableNamespaceIds I guess [20:27:16] $availableNamespaces = array_merge( ExtensionRegistry::getInstance()->getAttribute( 'VisualEditorAvailableNamespaces' ), $config->get( 'VisualEditorAvailableNamespaces' ) ); [20:27:17] What. [20:29:54] I thought I said not to add this [20:30:57] $config->get( 'VisualEditorAvailableNamespaces' ) is fine, this array_merge with the empty array returned by ExtensionRegistry returns some nonsense [20:31:16] It went in in https://gerrit.wikimedia.org/r/#/c/292165/2/ApiVisualEditor.php [20:32:44] There's a break in the deployment windows in half an hour [20:34:27] This will have to block further 1.28.0-wmf.8 deployment until we can fix it [20:34:46] Krenair: thanks for figuring it out! [20:35:00] Thanks for reporting it in the first place, same for you mooey|lunch [20:38:43] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor loads on editing talk pages in mw.org - https://phabricator.wikimedia.org/T138980#2416034 (10AlexMonk-WMF) @neil_p._quinn_WMF just reported what turns out to be the same issue: https://gerrit.wikimedia.org/r/#/c/292165/2/ApiVisualEditor.php Seems to be tha... [20:39:04] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor loads in the wrong namespaces - https://phabricator.wikimedia.org/T138980#2416050 (10AlexMonk-WMF) [20:39:44] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor loads in the wrong namespaces - https://phabricator.wikimedia.org/T138980#2415884 (10AlexMonk-WMF) [20:41:05] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor loads in the wrong namespaces - https://phabricator.wikimedia.org/T138980#2416069 (10AlexMonk-WMF) a:03AlexMonk-WMF [20:48:49] (03PS1) 10Alex Monk: Remove consideration of extension registry configured namespaces until we can find the correct way to merge them [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296652 (https://phabricator.wikimedia.org/T138980) [20:50:43] (03PS1) 10Alex Monk: Remove consideration of extension registry configured namespaces until we can find the correct way to merge them [extensions/VisualEditor] (wmf/1.28.0-wmf.8) - 10https://gerrit.wikimedia.org/r/296653 (https://phabricator.wikimedia.org/T138980) [21:01:54] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: VisualEditor loads in the wrong namespaces - https://phabricator.wikimedia.org/T138980#2416115 (10Jdforrester-WMF) p:05Triage>03Unbreak! [21:03:43] (03CR) 10Esanders: [C: 032] Remove consideration of extension registry configured namespaces until we can find the correct way to merge them [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296652 (https://phabricator.wikimedia.org/T138980) (owner: 10Alex Monk) [21:03:56] (03CR) 10Esanders: [C: 032] Remove consideration of extension registry configured namespaces until we can find the correct way to merge them [extensions/VisualEditor] (wmf/1.28.0-wmf.8) - 10https://gerrit.wikimedia.org/r/296653 (https://phabricator.wikimedia.org/T138980) (owner: 10Alex Monk) [21:09:16] (03Merged) 10jenkins-bot: Remove consideration of extension registry configured namespaces until we can find the correct way to merge them [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296652 (https://phabricator.wikimedia.org/T138980) (owner: 10Alex Monk) [21:11:34] (03Merged) 10jenkins-bot: Remove consideration of extension registry configured namespaces until we can find the correct way to merge them [extensions/VisualEditor] (wmf/1.28.0-wmf.8) - 10https://gerrit.wikimedia.org/r/296653 (https://phabricator.wikimedia.org/T138980) (owner: 10Alex Monk) [21:11:59] (03PS1) 10DLynch: Don't use array_merge for namespace configs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296655 (https://phabricator.wikimedia.org/T138980) [21:12:21] (03CR) 10jenkins-bot: [V: 04-1] Don't use array_merge for namespace configs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296655 (https://phabricator.wikimedia.org/T138980) (owner: 10DLynch) [21:13:29] (03PS2) 10DLynch: Don't use array_merge for namespace configs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296655 (https://phabricator.wikimedia.org/T138980) [21:13:41] (03CR) 10Esanders: [C: 031] "although you should rebase on the removal" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296655 (https://phabricator.wikimedia.org/T138980) (owner: 10DLynch) [21:21:07] (03CR) 10Alex Monk: [C: 032] Don't use array_merge for namespace configs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296655 (https://phabricator.wikimedia.org/T138980) (owner: 10DLynch) [21:21:56] (03PS1) 10Alex Monk: Don't use array_merge for namespace configs [extensions/VisualEditor] (wmf/1.28.0-wmf.8) - 10https://gerrit.wikimedia.org/r/296659 (https://phabricator.wikimedia.org/T138980) [21:22:08] (03CR) 10Alex Monk: [C: 032] Don't use array_merge for namespace configs [extensions/VisualEditor] (wmf/1.28.0-wmf.8) - 10https://gerrit.wikimedia.org/r/296659 (https://phabricator.wikimedia.org/T138980) (owner: 10Alex Monk) [21:30:09] (03Merged) 10jenkins-bot: Don't use array_merge for namespace configs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296655 (https://phabricator.wikimedia.org/T138980) (owner: 10DLynch) [21:30:16] (03Merged) 10jenkins-bot: Don't use array_merge for namespace configs [extensions/VisualEditor] (wmf/1.28.0-wmf.8) - 10https://gerrit.wikimedia.org/r/296659 (https://phabricator.wikimedia.org/T138980) (owner: 10Alex Monk) [21:43:15] mooey|lunch, neilpquinn: fix is syncing now [21:46:20] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: VisualEditor loads in the wrong namespaces - https://phabricator.wikimedia.org/T138980#2416293 (10AlexMonk-WMF) 05Open>03Resolved Thanks to everyone involved in finding and fixing this, especially @mooeypoo, @Neil_P._Quinn_WMF and @DLynch. It... [21:49:36] Krenair: yep, it looks like VE works in the Research namespace again! thanks! [21:52:33] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage, 06Wikisource, and 2 others: Get rid of
which spans multiple sections, so that each section is balanced HTML - https://phabricator.wikimedia.org/T133294#2416306 (10Mpaa) >>! In T133294#2407470, @Tpt wrote: >> @Tpt, how can one... [21:57:00] Krenair, thanks for the quick action! [22:03:09] (03PS1) 10Esanders: screenshots: Restore save button to more settings task [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296664 [22:10:23] (03PS2) 10Alex Monk: Hack to not show menu immediately upon meta dialog opening for redirect change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294359 (https://phabricator.wikimedia.org/T137309) [22:11:05] (03CR) 10Jforrester: [C: 031] Hack to not show menu immediately upon meta dialog opening for redirect change [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294359 (https://phabricator.wikimedia.org/T137309) (owner: 10Alex Monk) [22:17:40] (03CR) 10Alex Monk: "I believe that change fixed the biggest issue but I'll replace this commit with one fixing a remaining one" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 (owner: 10Alex Monk) [22:18:09] (03PS4) 10Alex Monk: Fix preference namespace list count to handle duplicates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 [22:22:28] (03CR) 10Alex Monk: [C: 04-1] "actually this commit doesn't make much sense anymore" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 (owner: 10Alex Monk) [22:24:58] (03PS5) 10Alex Monk: Fix preference namespace list to handle duplicates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/294199 [22:27:14] (03CR) 10Alex Monk: MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288650 (https://phabricator.wikimedia.org/T97482) (owner: 10Jforrester) [22:35:31] (03CR) 10Alex Monk: [C: 032] MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288650 (https://phabricator.wikimedia.org/T97482) (owner: 10Jforrester) [22:37:12] (03CR) 10Alex Monk: "From my comment on the task:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/295444 (https://phabricator.wikimedia.org/T135747) (owner: 10Alex Monk) [22:39:16] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: If a parameter is marked as suggested or required in TemplateData, then always display that parameter in the template dialog - https://phabricator.wikimedia.org/T97482#2416409 (10Jdforrester-WMF) 05Open>03Resolved [22:42:27] (03Merged) 10jenkins-bot: MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/288650 (https://phabricator.wikimedia.org/T97482) (owner: 10Jforrester) [22:44:34] (03CR) 10Jforrester: [C: 032] screenshots: Add task for plain insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296625 (owner: 10Esanders) [22:45:05] (03CR) 10Jforrester: [C: 032] screenshots: Restore save button to more settings task [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296664 (owner: 10Esanders) [22:45:52] 10VisualEditor, 10VisualEditor-MediaWiki, 07Technical-Debt: Replace all the existing numerical configs with named ones - https://phabricator.wikimedia.org/T138999#2416446 (10Jdforrester-WMF) [22:51:24] (03Merged) 10jenkins-bot: screenshots: Add task for plain insert menu [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296625 (owner: 10Esanders) [22:51:26] (03Merged) 10jenkins-bot: screenshots: Restore save button to more settings task [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296664 (owner: 10Esanders) [23:00:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10ProofreadPage: VisualEditor should retrieve content of all Page: pages wikitext editor field when switching from WikiEditor - https://phabricator.wikimedia.org/T138673#2406978 (10AlexMonk-WMF) Yes, but at this stage ve.init.mw isn't even set up so we can't go and g... [23:09:56] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): If a parameter is marked as suggested or required in TemplateData, then always display that parameter in the template dialog - https://phabricator.wikimedia.org/T97482#2416492 (10Sphilbrick) I see this is marked as re... [23:20:39] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 07Technical-Debt: Replace all the existing numerical configs with named ones - https://phabricator.wikimedia.org/T138999#2416528 (10AlexMonk-WMF) a:03AlexMonk-WMF [23:26:32] Why does the template get weird html code visable in VE-mode? https://usercontent.irccloud-cdn.com/file/VNNQuSgz/Screenshot%202016-06-30%20at%2001.25.31.png https://usercontent.irccloud-cdn.com/file/x1DGKgfe/Screenshot%202016-06-30%20at%2001.25.24.png [23:30:39] Don't know, but it appears in https://sv.wikipedia.org/api/rest_v1/page/html/Musa_rosea/36205053 [23:30:53] maybe some wrongly-cached broken template? [23:31:02] perhaps even a parsoid issue [23:31:14] but, not VE itself [23:31:44] same with the the template {{enwp}} as well.. [23:31:56] multiple templates on sv.wp seems to have a similar issue... [23:32:46] hm. maybe parsoid [23:33:41] been seing it with {{enwp}} for a year+ now, but just recently noticed it with other templates as well [23:45:15] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 05WMF-deploy-2016-07-05_(1.28.0-wmf.9): If a parameter is marked as suggested or required in TemplateData, then always display that parameter in the template dialog - https://phabricator.wikimedia.org/T97482#2416579 (10Sphilbrick) My next test failed. I'll...