[00:08:18] 10Cite, 07Wikimedia-log-errors: Undefined index: {count,key} in Cite::referencesFormatEntry method - https://phabricator.wikimedia.org/T132583#2478106 (10Dereckson) [00:11:35] (03CR) 10Alex Monk: [C: 032] MWSaveDialog: Give checkboxes a class based on their origin's name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299779 (https://phabricator.wikimedia.org/T138631) (owner: 10DLynch) [00:21:07] (03Merged) 10jenkins-bot: MWSaveDialog: Give checkboxes a class based on their origin's name [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299779 (https://phabricator.wikimedia.org/T138631) (owner: 10DLynch) [00:38:35] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: VE save dialog's checkboxes should have id or class set - https://phabricator.wikimedia.org/T138631#2478261 (10Jdforrester-WMF) 05Open>03Resolved [00:46:56] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: VE save dialog's checkboxes should have id or class set - https://phabricator.wikimedia.org/T138631#2478267 (10Dvorapa) Thank you [01:39:24] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (c2c1695) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299821 (owner: 10Jforrester) [01:40:53] 10VisualEditor, 10VisualEditor-MediaWiki, 06Editing-Analysis, 13Patch-For-Review, 07Wikimedia-log-errors: Invalid value None for integer property "action.abort.timing" (schema:Edit) - https://phabricator.wikimedia.org/T116718#1756296 (10demon) What's the status here? Above patches not merged. [01:46:22] (03Merged) 10jenkins-bot: Update VE core submodule to master (c2c1695) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/299821 (owner: 10Jforrester) [02:05:13] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Plugins, 10VisualEditor-Tables, 07Tracking: Support tables (tracking) - https://phabricator.wikimedia.org/T41596#2478511 (10Danny_B) [05:02:04] 10VisualEditor, 06Operations, 13Patch-For-Review, 07Performance: reinstall osmium with jessie - https://phabricator.wikimedia.org/T132530#2478616 (10Dzahn) reinstalled with jessie, then after first boot: 18:11 < mutante> "mdadm: No devices listed in conf file were found. 18:14 < mutante> ALERT! /dev/d... [05:08:05] 10VisualEditor, 06Operations, 13Patch-For-Review, 07Performance: reinstall osmium with jessie - https://phabricator.wikimedia.org/T132530#2478625 (10Dzahn) @ori @TimStarling I rsynced -avp the entire /home and entire /srv (minus /srv/mediawiki which got recreated by puppet and was quite large temp over t... [06:35:57] 10VisualEditor, 10MediaWiki-extensions-MultimediaViewer, 06Reading-Web-Backlog, 07User-notice, and 2 others: MediaViewer throws error after save in VisualEditor - https://phabricator.wikimedia.org/T140574#2478852 (10jeblad) Thanks! Seems like my test article works now! :) [09:08:49] 10VisualEditor, 10VisualEditor-DataModel: Error thrown when deleting a heading next to a table - https://phabricator.wikimedia.org/T140871#2479124 (10Esanders) [09:29:12] 10VisualEditor, 10VisualEditor-EditingTools: VisualEditor sometimes shows redirects as missing pages in - https://phabricator.wikimedia.org/T140873#2479183 (10Nnvu) [09:40:38] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Image list in gallery dialog is not keyboard accessible - https://phabricator.wikimedia.org/T140874#2479208 (10Esanders) [09:40:45] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Image list in gallery dialog is not keyboard accessible - https://phabricator.wikimedia.org/T140874#2479220 (10Esanders) a:03Tchanders [10:47:17] 10VisualEditor, 10Flow: Ctrl+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2479434 (10Aklapper) [11:28:48] (03PS6) 10Esanders: Rewrite TOCWidget based on Linker::generateTOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297693 [11:47:09] (03PS7) 10Esanders: Rewrite TOCWidget based on Linker::generateTOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297693 [11:48:49] (03PS3) 10Esanders: Make ArticleTarget#goToHeading work at all times [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297692 [11:48:51] (03PS5) 10Esanders: Fix experimental TOCWidget to use node cache for finding headings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297609 [11:48:53] (03PS8) 10Esanders: Rewrite TOCWidget based on Linker::generateTOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297693 [11:51:21] (03PS4) 10Esanders: Make ArticleTarget#goToHeading work at all times [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297692 [11:51:23] (03PS9) 10Esanders: Rewrite TOCWidget based on Linker::generateTOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297693 [11:51:43] (03Abandoned) 10Esanders: Fix experimental TOCWidget to use node cache for finding headings [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297609 (owner: 10Esanders) [11:56:03] (03CR) 10jenkins-bot: [V: 04-1] Rewrite TOCWidget based on Linker::generateTOC [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/297693 (owner: 10Esanders) [12:30:17] (03CR) 10Esanders: [C: 04-1] TransactionProcessor: Apply annotations to ranges at the highest uniform offset (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299570 (https://phabricator.wikimedia.org/T140538) (owner: 10Divec) [12:37:17] (03CR) 10Esanders: TransactionProcessor: Apply annotations to ranges at the highest uniform offset (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299570 (https://phabricator.wikimedia.org/T140538) (owner: 10Divec) [12:37:41] (03CR) 10Esanders: "Code looks good and fixed my breaking cases." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299570 (https://phabricator.wikimedia.org/T140538) (owner: 10Divec) [13:30:21] 10VisualEditor: Change some shortcuts for French keyboards (slash /, point . and backslash \) - https://phabricator.wikimedia.org/T136948#2479947 (10Trizek-WMF) >>! In T136948#2476758, @Jdforrester-WMF wrote: > Maybe re-purpose this to "provide additional shortcuts that are easier to use on AZERTY keyboards"? I... [13:50:02] 10VisualEditor, 10Flow: Ctrl+M on VE mode has unexpected behavour on VE and on VE mode on Flow with an Azerty keyboard - https://phabricator.wikimedia.org/T134164#2480036 (10Trizek-WMF) I've cheched on both my browsers (chromium is for my WMF account, Firefox for my volunteer one). Edouard's accound and both m... [15:13:00] 10VisualEditor, 06Operations, 13Patch-For-Review, 07Performance: reinstall osmium with jessie - https://phabricator.wikimedia.org/T132530#2480365 (10Dzahn) a:03Dzahn [15:13:07] 10VisualEditor, 06Operations, 13Patch-For-Review, 07Performance: reinstall osmium with jessie - https://phabricator.wikimedia.org/T132530#2201664 (10Dzahn) 05Open>03Resolved [15:19:57] 10VisualEditor, 10VisualEditor-Media: It should be possible to search for a media file by pasting the full URL - https://phabricator.wikimedia.org/T140906#2480397 (10Esanders) [15:21:47] 10VisualEditor, 10VisualEditor-Media, 06Discovery: It should be possible to search for a media file by pasting the full URL - https://phabricator.wikimedia.org/T140906#2480410 (10Esanders) [15:46:35] 10VisualEditor, 07JavaScript, 13Patch-For-Review, 15User-zeljkofilipin: Run language screenshots script for VisualEditor in Jenkins - https://phabricator.wikimedia.org/T139613#2480513 (10zeljkofilipin) The first job created using Jenkins Job Builder: [[ https://integration.wikimedia.org/ci/job/language-scr... [16:17:32] (03CR) 10Jforrester: TransactionProcessor: Apply annotations to ranges at the highest uniform offset (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299570 (https://phabricator.wikimedia.org/T140538) (owner: 10Divec) [16:38:29] 10VisualEditor: Pre-annotations not applied to inline templates - https://phabricator.wikimedia.org/T140919#2480946 (10Catrope) [16:54:12] 10VisualEditor: Pre-annotations not applied to inline templates - https://phabricator.wikimedia.org/T140919#2480998 (10Esanders) p:05Triage>03Low [17:35:14] RoanKattouw: why does ve.ce.DocumentNode have a surface property, but not ve.dm.DocumentNode? [17:36:51] we have bunch of places where the view triggers a model change, and in those cases we do viewNode.surface.getModel().change ... [17:37:13] but we can't do viewNode.getModel().getDocument().getSurface().change ... [17:37:31] more specifically we can't put code that is purely for modifying the DM surface in the DM node [17:41:32] 10VisualEditor: Use surface fragments instead of dm.Surface#change directly - https://phabricator.wikimedia.org/T140924#2481131 (10Esanders) [17:42:08] (03PS3) 10Esanders: Use surface fragments in IndentationAction methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299564 (https://phabricator.wikimedia.org/T140924) [17:43:20] 10VisualEditor, 10VisualEditor-DataModel, 13Patch-For-Review, 07Technical-Debt: Use surface fragments instead of dm.Surface#change directly - https://phabricator.wikimedia.org/T140924#2481146 (10Jdforrester-WMF) p:05Triage>03Normal a:03Esanders [17:43:23] (03PS1) 10Esanders: Use surface fragment in resizable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300069 (https://phabricator.wikimedia.org/T140924) [17:43:53] (03CR) 10Jforrester: Use surface fragments in IndentationAction methods (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/299564 (https://phabricator.wikimedia.org/T140924) (owner: 10Esanders) [17:52:58] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 07Accessibility: Image list in gallery dialog is not keyboard accessible - https://phabricator.wikimedia.org/T140874#2481195 (10Jdforrester-WMF) p:05Triage>03Normal [17:54:03] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki-Templates: Pre-annotations not applied to inline templates - https://phabricator.wikimedia.org/T140919#2480946 (10Jdforrester-WMF) [18:47:45] James_F, what's the status of the panoviewer? Have you built any backend tech for it? Also, do you know who is working on it? [18:48:03] i would love to collab on it [19:13:24] edsanders: You can (theoretically, and in my subdocuments branch also practically) have multiple views on one model [19:13:46] sure, but I'm talking about dmdoc->dmsurface [19:13:47] For this reason and other more fundamental reasons you cannot have pointers from DM to CE or UI [19:13:59] Oh, OK [19:14:21] What is your use case here? [19:14:35] I'm doubtful that putting code in Nodes that interacts with Surfaces (even all in DM) is a good diea [19:15:24] we already do [19:15:53] ve.ce.ResizableNode [19:17:11] Right [19:17:11] OK, there I understand why [19:17:14] Why do you need it in DM? [19:18:40] yurik: This is not the right channel; mlitn, marktracuer and others can't answer your questions about multimedia if you hide your questions from them. :-P [19:19:01] James_F, channel link pls :) [19:19:20] yurik: #wikimedia-multimedia. It pre-dates this one by years. [19:19:32] * yurik joins... [19:21:31] RoanKattouw: just about where the code should live [19:36:55] edsanders: Which code? [19:40:43] the code that builds the model changes [20:48:49] Oh I see [20:49:05] That's actually something I've been wanting to fix for a while [20:49:24] What if the nodes had methods that built transactions or descriptions thereof, but didn't actually apply them? [22:28:20] 10VisualEditor, 06Operations, 07Performance: reinstall osmium with jessie - https://phabricator.wikimedia.org/T132530#2482280 (10Dzahn) [22:28:37] 10VisualEditor, 10MediaWiki-Vagrant: visualeditor loading fails on local vagrant instance - https://phabricator.wikimedia.org/T138659#2482281 (10Jdforrester-WMF) 05Open>03Resolved a:03Tgr