[04:14:09] 10VisualEditor, 10Parsoid, 10RESTBase: Intermittent corruptions on saves, likely related to data-parsoid mis-matches - https://phabricator.wikimedia.org/T134593#2517900 (10GWicke) Since the VE changes, there have been no new reports on https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback, which is e... [05:25:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly) - https://phabricator.wikimedia.org/T72123#2517928... [05:25:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo - https://phabricator.wikimedia.org/T65355#2517930 (10Krinkle) [05:28:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Links: Direct link to a non-extant local file ([[:File:Foo]]) is red even if there is an extant file in a remote repo - https://phabricator.wikimedia.org/T65355#2517931 (10Krinkle) >>! In T65355#2517538, @Quiddity wrote: > These are probably... [05:59:33] 10VisualEditor: Consider multi line formula editing with Math inspector - https://phabricator.wikimedia.org/T141950#2517512 (10Krinkle) Hi. Thanks for the report. The LaTE [07:09:21] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly) - https://phabricator.wikimedia.org/T72123#726825... [07:14:14] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Check if links on load are 'known' rather than 'exist' locally - https://phabricator.wikimedia.org/T104604#1421989 (10Legoktm) I don't think this works - or it has regressed since. Visiting I s... [10:04:49] 10Cite, 06Wikisource: Within the and tags are ignored - https://phabricator.wikimedia.org/T141971#2518385 (10Billinghurst) [10:05:29] 10Cite, 06Wikisource: Within the and tags are ignored, problematic when transcluded - https://phabricator.wikimedia.org/T141971#2518397 (10Billinghurst) [11:25:36] 10Cite, 06Wikisource: Within the and tags are ignored, problematic when transcluded - https://phabricator.wikimedia.org/T141971#2518385 (10Izno) This seems like a pathological edge case and can't personally understand what the desire is there. [12:03:29] 10Cite, 06Wikisource: Within the and tags are ignored, problematic when transcluded - https://phabricator.wikimedia.org/T141971#2518690 (10Billinghurst) Definitely an edge case, but it is one that should be queued for Cite addressing as we have numbers of situations of mediawiki... [13:53:30] 10VisualEditor: Table not rendering how it has been designed - https://phabricator.wikimedia.org/T141984#2518868 (10Trizek-WMF) [14:00:59] 10VisualEditor: Table not rendering how it has been designed - https://phabricator.wikimedia.org/T141984#2518868 (10matmarex) Diff of the VE edit: https://fr.wikipedia.org/w/index.php?title=Liste_des_additifs_alimentaires&diff=prev&oldid=128348925 Looks like a newline is missing before the `|---` (new table row... [14:08:18] 10Cite, 06Wikisource: Within the and tags are ignored, problematic when transcluded - https://phabricator.wikimedia.org/T141971#2518913 (10Izno) >>! In T141971#2518690, @Billinghurst wrote: > Definitely an edge case, but it is one that should be queued for Cite addressing as we... [15:13:17] 10VisualEditor, 06Community-Liaisons (Jul-Sep-2016): Facilitate deployment of the visual editor at Arabic script wikis - https://phabricator.wikimedia.org/T141994#2519198 (10Elitre) [15:13:55] 10VisualEditor, 06Community-Liaisons (Jul-Sep-2016): Facilitate deployment of the visual editor at Arabic script wikis - https://phabricator.wikimedia.org/T141994#2519219 (10Elitre) [15:13:59] 10VisualEditor, 10Wikimedia-Site-requests, 07User-notice: Enable VisualEditor by default for all users of all "phase 6" Wikipedias - https://phabricator.wikimedia.org/T93387#2519218 (10Elitre) [16:19:06] (03CR) 10DLynch: [C: 032] Use more surface fragments in paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300262 (https://phabricator.wikimedia.org/T140924) (owner: 10Esanders) [16:21:24] (03Merged) 10jenkins-bot: Use more surface fragments in paste [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300262 (https://phabricator.wikimedia.org/T140924) (owner: 10Esanders) [16:26:27] (03CR) 10Jforrester: [C: 031] Use surface fragment in resizable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300069 (https://phabricator.wikimedia.org/T140924) (owner: 10Esanders) [16:39:04] (03CR) 10DLynch: [C: 032] Use surface fragment in resizable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300069 (https://phabricator.wikimedia.org/T140924) (owner: 10Esanders) [16:41:27] (03Merged) 10jenkins-bot: Use surface fragment in resizable node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/300069 (https://phabricator.wikimedia.org/T140924) (owner: 10Esanders) [16:42:35] (03PS1) 10Jforrester: Update OOjs UI to v0.17.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302737 [16:45:03] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.17.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302737 (owner: 10Jforrester) [16:45:37] 10VisualEditor, 10VisualEditor-DataModel, 07Technical-Debt: Use surface fragments instead of dm.Surface#change directly - https://phabricator.wikimedia.org/T140924#2519614 (10Jdforrester-WMF) [16:45:41] 10VisualEditor, 10VisualEditor-DataModel, 07Technical-Debt: Use surface fragments instead of dm.Surface#change directly - https://phabricator.wikimedia.org/T140924#2481131 (10Jdforrester-WMF) Anything left? [16:49:27] 10VisualEditor, 10VisualEditor-DataModel, 07Technical-Debt: Use surface fragments instead of dm.Surface#change directly - https://phabricator.wikimedia.org/T140924#2519636 (10Jdforrester-WMF) FWICT, there's `ve.dm.MetaList#insertMeta` and `#removeMeta`, and a few in TableAction. [16:54:50] (03Merged) 10jenkins-bot: Update OOjs UI to v0.17.7 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302737 (owner: 10Jforrester) [17:25:11] (03CR) 10Jforrester: [C: 032] Add maintainIndices param to SurfaceFragment#getText [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302243 (owner: 10Esanders) [17:25:20] (03CR) 10Jforrester: [C: 031] Make keepEmptyContentBranches an option of #sanitize and simplify usage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302256 (owner: 10Esanders) [17:27:41] (03Merged) 10jenkins-bot: Add maintainIndices param to SurfaceFragment#getText [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302243 (owner: 10Esanders) [17:27:55] (03CR) 10Catrope: [C: 032] Factor out creation of invisible 'icon' for overriding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302407 (https://phabricator.wikimedia.org/T141861) (owner: 10Esanders) [17:29:34] 10VisualEditor, 10VisualEditor-MediaWiki, 07User-notice: Add inline labels to invisible template icons - https://phabricator.wikimedia.org/T141861#2519794 (10Catrope) [17:30:12] (03Merged) 10jenkins-bot: Factor out creation of invisible 'icon' for overriding [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/302407 (https://phabricator.wikimedia.org/T141861) (owner: 10Esanders) [18:02:01] 10VisualEditor, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Tranche charts missing from VE report - https://phabricator.wikimedia.org/T141793#2519913 (10JAufrecht) p:05Triage>03Normal [18:32:46] (03CR) 10Jforrester: [C: 031] Mark context wrappers as wrappers [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/301850 (https://phabricator.wikimedia.org/T141639) (owner: 10Esanders) [18:33:14] Kemayo: Want to merge https://gerrit.wikimedia.org/r/#/c/141617/ ? :-) [18:34:01] James_F: Hm, give me a few minutes to read it over. [18:40:10] Kemayo: Thank you. :-) [18:40:19] (03CR) 10Catrope: [C: 031] "Good to merge once Id842389d is pulled through" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302411 (https://phabricator.wikimedia.org/T141861) (owner: 10Esanders) [18:49:37] (03CR) 10DLynch: [C: 04-1] "Applying big or small by selecting text and then using the menu item throws this error: `ve.dm.TransactionProcessor.js:200 Uncaught Error:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://phabricator.wikimedia.org/T53613) (owner: 10Jforrester) [18:51:03] (03PS1) 10Jforrester: Update VE core submodule to master (2567ca9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302764 [18:52:22] (03PS2) 10Jforrester: Show name of template for invisible templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302411 (https://phabricator.wikimedia.org/T141861) (owner: 10Esanders) [18:52:28] (03PS2) 10Jforrester: build: Bump stylelint-related devDependencies to latest [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302609 [18:54:28] Kemayo: Oh dear. That's… different from when I last tested it. :-( I'll have a look at some point (or if you want you can adopt the patch ;-)). [18:58:20] (03CR) 10Jforrester: [C: 032] "Per Roan." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302411 (https://phabricator.wikimedia.org/T141861) (owner: 10Esanders) [18:58:56] Kemayo: https://gerrit.wikimedia.org/r/#/c/302764/ would be nice to merge (but I'm distracting you from 'real' work). [19:10:00] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (2567ca9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302764 (owner: 10Jforrester) [19:11:59] James_F: It's actually *possible* that it seemed to work when you tested it. It errors, but the annotation still applies when it's done by selecting text. [19:12:13] So if you didn't have the console open... [19:13:53] Kemayo: Ho-hum. [19:14:56] 10VisualEditor, 10Wikimedia-Site-requests, 07Tracking, 07User-notice: Enable VisualEditor by default for all users of all Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T52000#2520241 (10Neil_P._Quinn_WMF) [19:19:56] (03Merged) 10jenkins-bot: Update VE core submodule to master (2567ca9) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302764 (owner: 10Jforrester) [19:19:58] (03Merged) 10jenkins-bot: Show name of template for invisible templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/302411 (https://phabricator.wikimedia.org/T141861) (owner: 10Esanders) [19:26:28] 10VisualEditor, 10VisualEditor-MediaWiki, 07User-notice: Add inline labels to invisible template icons - https://phabricator.wikimedia.org/T141861#2520302 (10Jdforrester-WMF) 05Open>03Resolved [19:27:12] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Microsoft-Edge, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Cannot cut or copy from VisualEditor using Microsoft Edge - https://phabricator.wikimedia.org/T141611#2520305 (10Jdforrester-WMF) 05Open>03Resolved [19:27:22] 10VisualEditor, 10VisualEditor-MediaWiki, 07User-notice, 05WMF-deploy-2016-08-09_(1.28.0-wmf.14): Add inline labels to invisible template icons - https://phabricator.wikimedia.org/T141861#2514791 (10Jdforrester-WMF) [19:31:28] 10VisualEditor, 10Wikimedia-Site-requests, 07Tracking, 07User-notice: Enable VisualEditor by default for all users of all Wikimedia wikis (tracking) - https://phabricator.wikimedia.org/T52000#2520332 (10Jdforrester-WMF) [19:48:03] James_F: should https://phabricator.wikimedia.org/T104604#2518083 be re-opened or I file a new ticket? [19:49:30] (03PS10) 10DLynch: Provide tools to make text bigger or smaller [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/141617 (https://phabricator.wikimedia.org/T53613) (owner: 10Jforrester) [19:52:55] James_F: I rewrote the big/small patch a bit, so it doesn't need to add new annotation actions and surfacefragment methods. Rather, it can just behave exactly like subscript/superscript do. [19:53:09] Kemayo: Oh. [19:53:22] Kemayo: Does that handle nested annotations though? [19:53:39] Most of the complexity is dealing with Foo, ISTR. [19:54:27] (It's literally two years since I wrote the main code, though, so…) [19:56:48] No, nested sub/superscripts don't get allowed (even though they work in non-VE HTML like 2n3, if you make them happen). Do we actually want Big bigger biggest to be facilitated? [20:04:36] James_F: I would note that the previous version of the patch doesn't seem to allow you to create nested s anyway. [20:05:09] (This delay between messages brought to you by me trying to remember the syntax for specifying a specific patch number to git review.) [20:08:15] (For reference: `git review -d ,` [21:12:28] Kemayo: Yeah. Multiple s (more normally, multiple s) are actually used from time to time on wiki (much, much more often than multiple s). And I'm unsurprised that my code didn't work. Maybe we could merge it as-is and make it able to handle multiples later? [21:15:16] James_F|Away: Seems like a workable plan. [21:20:39] The model treats nested s applied via editing the HTML as multiple instances of the textStyle/big annotation, so I think the major change to your previous patch would just be having to make the commands not register as already-applied if the annotation is already present. [21:22:58] Hm, or combine big/small into a single annotation type (textStyle/sized?) which can have an attribute for how many levels up/down it's gone, and serializes into big/small/removing-itself depending on being positive/negative. [23:21:23] 10Citoid, 10VisualEditor, 10WikiCite, 10Wikidata, and 3 others: [Story] Support for citoid in Wikidata - https://phabricator.wikimedia.org/T131661#2521150 (10czar) @BrillLyle Not sure what you mean by inter-operability with Wikidata or how it might relate to this ticket, but if you're looking for URL → wik... [23:23:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly) - https://phabricator.wikimedia.org/T72123#726825...