[00:35:11] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 7 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2232911 (10Platonides) I don't think all of above has been addressed, Dere... [00:45:11] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 7 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2581101 (10MZMcBride) I don't think [[https://gerrit.wikimedia.org/r/30630... [00:57:52] (03PS3) 10DLynch: init: Discard attempts to activate while we're already activating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/306240 (https://phabricator.wikimedia.org/T143160) [01:20:09] (03PS9) 10Divec: WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 [01:20:24] (03PS8) 10Divec: WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 [01:20:38] (03PS17) 10Divec: WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [01:22:34] (03CR) 10jenkins-bot: [V: 04-1] WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [01:23:13] (03CR) 10jenkins-bot: [V: 04-1] WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 (owner: 10Divec) [01:23:51] (03CR) 10jenkins-bot: [V: 04-1] WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 (owner: 10Divec) [06:59:19] (03CR) 10Esanders: [C: 031] "Haven't tested yet" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/306240 (https://phabricator.wikimedia.org/T143160) (owner: 10DLynch) [15:10:35] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2582652 (10Nirzar) >@Quiddity Yes! That's T136... [15:26:31] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2582714 (10Pginer-WMF) > i think we should foc... [15:27:01] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2582715 (10Elitre) The eye doesn't really work... [15:49:01] 10VisualEditor, 10VisualEditor-MediaWiki, 07Regression: Editing mode not properly closed after section editing - https://phabricator.wikimedia.org/T143257#2562157 (10DLynch) I just tested this, and cannot reproduce it. Perhaps it was another symptom fixed by 11a4e4e6b9aca0963ddf90fc4b63081f7e1aff5b? [15:54:26] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: On selection dragging, getting error "TypeError: this.onDocumentSelectionChangeDebounced is not a function" - https://phabricator.wikimedia.org/T138503#2582770 (10DLynch) 05Open>03Resolved a:03Esanders This was fixed by Ed in... [16:32:03] (03CR) 10Jforrester: [C: 032] Show a different label for buttons on create vs. modify [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296745 (https://phabricator.wikimedia.org/T139033) (owner: 10Jforrester) [16:34:23] 10VisualEditor, 10VisualEditor-MediaWiki, 07Performance: Loading of editor should not be blocked on the editor preference getting saved - https://phabricator.wikimedia.org/T133758#2241850 (10DLynch) The delay in switching to wikitext if VE is navigated to was added by Alex in 76a12f2f9b3c0a7a89a3d116cbc9dee7... [16:37:25] 10VisualEditor, 10VisualEditor-MediaWiki, 07Browser-Support-Apple-Safari: Find/replace dialog in VE overlaps edit notice warning (? in Safari) - https://phabricator.wikimedia.org/T128523#2077794 (10DLynch) The overlap seems to have been fixed, at least, ignoring the issue of whether find/replace should be pr... [16:38:06] (03PS7) 10Jforrester: Vary the 'save' labels to 'publish' for public wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296746 (https://phabricator.wikimedia.org/T131132) [16:40:23] (03Merged) 10jenkins-bot: Show a different label for buttons on create vs. modify [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296745 (https://phabricator.wikimedia.org/T139033) (owner: 10Jforrester) [16:52:39] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 7 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2582928 (10Jdforrester-WMF) [16:53:03] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10MediaWiki-Internationalization, and 5 others: Re-label the "Save" (or "Publish") button to use "Publish page" when creating and "Publish changes" when modifying an existing page - https://phabricator.wikimedia.org/T139033#2582927 (10Jdforrester-WMF) 05... [16:55:46] 10VisualEditor, 10VisualEditor-MediaWiki, 07Browser-Support-Apple-Safari: Find/replace dialog in VE overlaps edit notice warning (? in Safari) - https://phabricator.wikimedia.org/T128523#2582956 (10Jdforrester-WMF) 05Open>03Resolved a:03Volker_E Yeah, this is probably the same bug as {T140237} [16:57:34] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: On selection dragging, getting error "TypeError: this.onDocumentSelectionChangeDebounced is not a function" - https://phabricator.wikimedia.org/T138503#2582964 (10Jdforrester-WMF) [17:04:31] (03PS1) 10DLynch: DatraTransferHandlerFactory: don't assume there's a constructor for everything [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306694 [17:05:05] (03PS2) 10DLynch: DataTransferHandlerFactory: don't assume there's a constructor for everything [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306694 [17:08:19] (03CR) 10DLynch: "I did this because the wikitext surface causes errors when you paste because there's no handler for wikitextString registered." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306694 (owner: 10DLynch) [17:15:15] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2583026 (10Nirzar) >The eye doesn't really wor... [17:45:51] (03PS10) 10Divec: WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 [17:46:06] (03PS9) 10Divec: WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 [17:46:21] (03PS18) 10Divec: WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [17:48:38] 10VisualEditor, 10VisualEditor-MediaWiki: Modification are lost when switching from NWE to VE - https://phabricator.wikimedia.org/T143917#2583167 (10Esanders) [17:49:14] 10VisualEditor, 10VisualEditor-MediaWiki: Modification are lost when switching from NWE to VE - https://phabricator.wikimedia.org/T143917#2583182 (10Esanders) [17:49:16] 10VisualEditor, 10VisualEditor-MediaWiki: In the new wikitext editor, be able to smoothly toggle between editors - https://phabricator.wikimedia.org/T142643#2583183 (10Esanders) [17:53:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 (owner: 10Divec) [17:53:58] (03CR) 10jenkins-bot: [V: 04-1] WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 (owner: 10Divec) [17:54:50] (03CR) 10jenkins-bot: [V: 04-1] WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [18:01:37] 10VisualEditor, 10WikiEditor, 06Community-Liaisons, 06Editing-Department, and 7 others: Re-label the "Save" button to be "Publish", to better indicate to users the outcomes of their action - https://phabricator.wikimedia.org/T131132#2236553 (10thcipriani) This was rescheduled for morning SWAT again today.... [18:06:31] (03PS19) 10Divec: WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [18:09:31] (03CR) 10jenkins-bot: [V: 04-1] WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [18:18:54] (03PS1) 10Tchanders: WIP/EXPERIMENTAL Tree differ to run on dm.DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306712 [18:19:13] (03CR) 10jenkins-bot: [V: 04-1] WIP/EXPERIMENTAL Tree differ to run on dm.DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306712 (owner: 10Tchanders) [18:20:55] 10VisualEditor, 10VisualEditor-MediaWiki: After switching from NWE to VE, switching back triggers errors - https://phabricator.wikimedia.org/T143920#2583352 (10Esanders) [18:37:27] (03PS2) 10Tchanders: WIP/EXPERIMENTAL Tree differ to run on dm.DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306712 [18:37:28] (03PS4) 10Tchanders: WIP/EXPERIMENTAL Reconcile.js modified to run on dm.DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303502 (owner: 10Esanders) [18:39:34] (03CR) 10jenkins-bot: [V: 04-1] WIP/EXPERIMENTAL Tree differ to run on dm.DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306712 (owner: 10Tchanders) [18:40:43] (03CR) 10jenkins-bot: [V: 04-1] WIP/EXPERIMENTAL Reconcile.js modified to run on dm.DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303502 (owner: 10Esanders) [18:51:16] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 2 others: RFC: API for retrieval and saving of top-level HTML elements / sections by element ID - https://phabricator.wikimedia.org/T94890#2583507 (10GWicke) >>! In T94890#2581012, @GWicke wrote: > I'm working on the client-side code at... [19:53:09] (03CR) 10Esanders: [C: 04-1] "Isn't 'names' built from filtering internal properties which are themselves built up of registered names, so surely was can assume they al" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306694 (owner: 10DLynch) [20:06:24] (03CR) 10Esanders: [C: 032] init: Discard attempts to activate while we're already activating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/306240 (https://phabricator.wikimedia.org/T143160) (owner: 10DLynch) [20:06:39] (03CR) 10DLynch: "Apparently not, since I'm getting that error..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306694 (owner: 10DLynch) [20:07:08] (03PS1) 10Esanders: Preserve data when switching from NWE to VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/306737 (https://phabricator.wikimedia.org/T143917) [20:12:48] (03Merged) 10jenkins-bot: init: Discard attempts to activate while we're already activating [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/306240 (https://phabricator.wikimedia.org/T143160) (owner: 10DLynch) [20:38:38] 10VisualEditor, 10VisualEditor-MediaWiki: Fix tab behaviour when using two edit tabs with NWE - https://phabricator.wikimedia.org/T143577#2583857 (10Esanders) a:03Esanders [20:39:55] (03PS11) 10Divec: WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 [20:39:56] (03PS10) 10Divec: WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 [20:39:57] (03PS20) 10Divec: WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [20:43:17] (03CR) 10jenkins-bot: [V: 04-1] WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 (owner: 10Divec) [20:43:41] (03CR) 10jenkins-bot: [V: 04-1] WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 (owner: 10Divec) [20:44:11] (03CR) 10jenkins-bot: [V: 04-1] WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [20:46:31] (03PS21) 10Divec: WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [20:49:55] (03CR) 10jenkins-bot: [V: 04-1] WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [21:00:55] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 05WMF-deploy-2016-08-30_(1.28.0-wmf.17): VisualEditor loading stuck on blue bar if you click the Edit tab twice during loading - https://phabricator.wikimedia.org/T143160#2583986 (10Jdforrester-WMF) 05Open>03Resolved [21:03:34] (03PS1) 10Esanders: Update tab and history state when switching between NWE & VE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/306798 (https://phabricator.wikimedia.org/T143577) [21:28:02] (03CR) 10Esanders: [C: 032] Vary the 'save' labels to 'publish' for public wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296746 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [21:28:07] edsanders, James_F: is there a VE ticket about section editing / sending back only changes, to complement https://phabricator.wikimedia.org/T94890 ? [21:28:37] Petr is drafting an announcement for the api change [21:29:02] https://phabricator.wikimedia.org/T142320 [21:29:19] cool, thanks! [21:30:47] 10VisualEditor, 10VisualEditor-Performance, 10Parsoid, 10RESTBase, and 2 others: RFC: API for retrieval and saving of top-level HTML elements / sections by element ID - https://phabricator.wikimedia.org/T94890#2584084 (10GWicke) The VE effort to speed up saves using this section edit API is tracked at {T14... [21:36:42] (03Merged) 10jenkins-bot: Vary the 'save' labels to 'publish' for public wikis [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/296746 (https://phabricator.wikimedia.org/T131132) (owner: 10Jforrester) [21:49:31] RoanKattouw: ping [22:00:29] RoanKattouw: it would be great if Petr had post access to the mediawiki-api-announce list; he joined the list, but I think can't post by default [22:00:45] since you are listed as one of the list admins, could you perhaps give him the necessary bits? [22:01:36] gwicke: Sure, will do [22:02:09] RoanKattouw: many thanks! [22:03:47] gwicke: OK, I've unmoderated him (everyone's moderated by default), I think taht might be enoguh? If it still doesn't work, let me know [22:08:23] should be, I think that's the status I am in as well, and I can post directly to the list [22:08:41] we'll have another announcement going out on Tuesday, which will be a good test for Petr [22:08:50] thanks again! [22:11:07] 10VisualEditor, 10VisualEditor-ContentLanguage, 10MediaWiki-Language-converter, 10Parsoid, and 4 others: Decide on a strategy for supporting language variants in VisualEditor (or decide to give up) - https://phabricator.wikimedia.org/T95674#2584264 (10GWicke) Some interesting page view data by country from... [22:42:15] (03CR) 10Esanders: "When? Is there a ticket?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306694 (owner: 10DLynch) [23:02:45] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Modifications are lost when switching from NWE to VE - https://phabricator.wikimedia.org/T143917#2584506 (10Esanders) [23:14:50] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749049 (10Esanders) >>! In T116417#2582652, @... [23:16:42] 10VisualEditor: Pasting into VE with new Wikitext surface enabled causes error - https://phabricator.wikimedia.org/T143954#2584537 (10DLynch) [23:17:01] (03CR) 10DLynch: "There is now T143954." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/306694 (owner: 10DLynch) [23:22:49] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2584559 (10Esanders) >>! In T116417#2572593, @... [23:26:34] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design, 07Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2584563 (10Esanders) @Pine Our quarterly goal is to make it available as Beta Feature. [23:31:37] 10VisualEditor: Pasting into VE with new Wikitext surface enabled causes error - https://phabricator.wikimedia.org/T143954#2584581 (10Esanders) This is a bug in ve.ce.MWWikitextSurface where I unconditionally unregister ve.ui.MWWikitextStringTransferHandler. The handler should be available in VE, but not NWE. [23:31:46] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 07Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#2584582 (10Nirzar) I think we did the blue s... [23:32:12] 10VisualEditor: Pasting into VE with new Wikitext surface enabled causes error - https://phabricator.wikimedia.org/T143954#2584583 (10Esanders) The way I did this with the other factories was by create wikitext versions of the factories, but this might be overkill for removing/disabling one item. [23:34:31] 10VisualEditor: Pasting into VE with new Wikitext surface enabled causes error - https://phabricator.wikimedia.org/T143954#2584592 (10Esanders) But also this reveals that unregister isn't working properly in this case - it needs to be overridden to update all the extra caches DTHFactory creates.