[00:03:21] (03PS1) 10Esanders: Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309211 (https://phabricator.wikimedia.org/T144881) [00:05:08] Krenair: If you think https://gerrit.wikimedia.org/r/#/c/309211/ is a good change please +2 it and we can SWAT it now. [00:07:15] (03CR) 10Alex Monk: [C: 032] Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309211 (https://phabricator.wikimedia.org/T144881) (owner: 10Esanders) [00:12:25] Thanks. [00:13:09] (03Merged) 10jenkins-bot: Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309211 (https://phabricator.wikimedia.org/T144881) (owner: 10Esanders) [00:13:30] (03PS1) 10Paladox: Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309213 (https://phabricator.wikimedia.org/T144881) [00:13:34] (03PS2) 10Paladox: Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309213 (https://phabricator.wikimedia.org/T144881) [00:13:36] (03PS3) 10Jforrester: Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309213 (https://phabricator.wikimedia.org/T144881) (owner: 10Paladox) [00:23:43] (03CR) 10Jforrester: [C: 032] Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309213 (https://phabricator.wikimedia.org/T144881) (owner: 10Paladox) [00:29:35] (03Merged) 10jenkins-bot: Make ext.visualEditor.mediawiki a dependency of .mwcore [extensions/VisualEditor] (wmf/1.28.0-wmf.18) - 10https://gerrit.wikimedia.org/r/309213 (https://phabricator.wikimedia.org/T144881) (owner: 10Paladox) [00:38:37] (03PS4) 10Jforrester: Provide the new wikitext editor as a beta feature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308005 (https://phabricator.wikimedia.org/T142644) [00:38:55] (03CR) 10Jforrester: "Yeah, forgot to add it to extension.json so MW defaulted to "0" instead of 0." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308005 (https://phabricator.wikimedia.org/T142644) (owner: 10Jforrester) [01:07:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Beta-Cluster-Infrastructure: On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE - https://phabricator.wikimedia.org/T144884#2618053 (10Jdforrester-WMF) [01:09:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Beta-Cluster-Infrastructure: On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE - https://phabricator.wikimedia.org/T144884#2618056 (10Jdforrester-WMF) Maybe someone is doing something... [01:12:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Beta-Cluster-Infrastructure, 10Parsoid: On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE - https://phabricator.wikimedia.org/T144884#2618063 (10Jdforrester-WMF) I think the Special... [01:15:31] James_F, ryasmeen: I'm not getting these FilePath URLs [01:15:57] (03CR) 10Jforrester: "> shouldn't we just leave the default unstyled?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309178 (https://phabricator.wikimedia.org/T145016) (owner: 10Esanders) [01:16:09] Krenair: In Beta Cluster? [01:16:46] yes [01:16:54] Krenair: Try https://en.wikipedia.beta.wmflabs.org/wiki/User:Jdforrester_(WMF)/sandbox?veaction=edit for instance (it fails for me in incognito as well). [01:17:31] I see them there [01:18:04] Odd. Maybe only some kinds of image transclusion makes it break? [01:19:02] They're part of the document in RB: view-source:https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/User%3AJdforrester_(WMF)%2Fsandbox?redirect=false [01:20:55] ohhhh [01:20:59] this type of bug [01:20:59] again [01:21:08] https://en.wikipedia.beta.wmflabs.org/w/Special:FilePath/Bart_map_sandbox.svg [01:21:10] https://en.wikipedia.beta.wmflabs.org/wiki/Special:FilePath/Bart_map_sandbox.svg [01:43:32] I have a feeling this is actually a distraction from the real bug hiding these images though [01:44:12] ce.MWBlockImageNode is not appending this.$image because isError is set [01:44:55] because the document in RB has it marked with a mw:Error [01:45:12]
[01:58:30] think RB might also be broken [01:58:37] * Krenair is wondering if there is anything not broken today [02:02:19] krenair@deployment-tin:~$ curl -X POST http://deployment-parsoid09:8000/en.wikipedia.beta.wmflabs.org/v3/transform/wikitext/to/html/Main_Page --data "wikitext=[[File:Ophelia - Hybrid Tea.jpg]]" 2>/dev/null | grep -o mw:Error [02:02:19] mw:Error [02:03:57] interesting [02:04:05] parsoid logs show Batch request failure for \"95d7ac503d0cb1ede0052fd3c9066c7b\": 403 [02:04:10] it's receiving a 403 from the mw api?? [02:10:07] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Beta-Cluster-Infrastructure, 10Parsoid: On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE - https://phabricator.wikimedia.org/T144884#2618147 (10ssastry) Try refreshing the content... [02:11:02] subbu, try the command I just posted above [02:11:07] skip RB entirely [02:11:11] the issue is still there [02:11:33] I think I know which commit caused this too [02:11:47] https://gerrit.wikimedia.org/r/#/c/307762/ [02:12:06] we enabled secure POST enforcement to match prod [02:13:44] fixed [02:14:01] I did this [02:14:02] krenair@deployment-parsoid09:/srv/deployment/parsoid/deploy$ sudo sed -i conf/wmf/betalabs.localsettings.js -e 's/http:/https:/' [02:20:50] hmm [02:20:52] how to deploy this thing [02:20:59] ugh it's that deploy-service group [02:23:02] okay that's weird, what magic does scap3 do on the target hosts? Had to cd `pwd` to get the new changes to show up in git... [02:25:25] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Beta-Cluster-Infrastructure, 10Parsoid: On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE - https://phabricator.wikimedia.org/T144884#2613500 (10AlexMonk-WMF) So, the cause will be... [02:31:11] there's really no one else here [02:31:22] I could've stopped talking over an hour ago, it's just me and wikibugs [02:59:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Beta-Cluster-Infrastructure, 10Parsoid: On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE - https://phabricator.wikimedia.org/T144884#2618197 (10ssastry) >>! In T144884#2618153, @Al... [03:40:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 10Beta-Cluster-Infrastructure, and 2 others: On beta cluster, images are replaced with failed (404) links to Special:FilePath when you load VE - https://phabricator.wikimedia.org/T144884#2618215 (10Ryasmeen) 05Open>03Resolved [03:44:00] 10VisualEditor: Several nodes are not being rendered on Edit Mode in VE in beta - https://phabricator.wikimedia.org/T144883#2618230 (10Ryasmeen) 05Open>03Resolved a:03Ryasmeen I guess this issue had the same cause as T144884. Looks like all those nodes are rendering properly now. [03:44:40] (03PS2) 10Aaron Schulz: Avoid DBPerformance log warnings in parseAndStash() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309072 [03:48:03] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 07Verified, and 2 others: [Regression wmf.18] Cannot open any page with VE on mw.org, getting error "Cannot read property 'getInitializedPromise' of undefined TypeError: Cannot read property 'get... - https://phabricator.wikimedia.org/T144881#2618236 [03:53:15] 10Citoid, 10VisualEditor, 07Documentation: Documentation for citoid in general, but dwindled down info type handling - https://phabricator.wikimedia.org/T133531#2618242 (10jeblad) Some examples - [[ http://arkiv.nrk.no/programoversikt/avansert/indexcc0e.html | NRK: Ny reality-serie ]] ([[ https://citoid.wi... [04:01:56] 10VisualEditor: Several nodes are not being rendered on Edit Mode in VE in beta - https://phabricator.wikimedia.org/T144883#2618251 (10Ryasmeen) a:05Ryasmeen>03None [04:40:43] (03PS1) 10Catrope: [WIP] ApiVisualEditor: Move paction=diff|serialize|serializeforcachekey to a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309236 [04:40:45] (03PS1) 10Catrope: [WIP] ApiVisualEditor: Clean up giant switch statement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 [04:44:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ApiVisualEditor: Move paction=diff|serialize|serializeforcachekey to a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309236 (owner: 10Catrope) [04:44:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ApiVisualEditor: Clean up giant switch statement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 (owner: 10Catrope) [05:02:21] (03PS2) 10Catrope: [WIP] ApiVisualEditor: Clean up giant switch statement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 [05:02:23] (03PS2) 10Catrope: [WIP] ApiVisualEditor: Move diffing and serializing to a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309236 [05:05:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ApiVisualEditor: Clean up giant switch statement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 (owner: 10Catrope) [05:05:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ApiVisualEditor: Move diffing and serializing to a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309236 (owner: 10Catrope) [05:07:30] (03PS3) 10Catrope: [WIP] ApiVisualEditor: Clean up giant switch statement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 [05:07:33] (03PS3) 10Catrope: [WIP] ApiVisualEditor: Move diffing and serializing to a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309236 [05:10:39] (03CR) 10Catrope: [C: 04-2] "This will break JS code that sends GETs to this module. Instead, we should split this module: https://gerrit.wikimedia.org/r/#/c/309236" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309072 (owner: 10Aaron Schulz) [05:11:29] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ApiVisualEditor: Move diffing and serializing to a separate module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309236 (owner: 10Catrope) [05:11:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] ApiVisualEditor: Clean up giant switch statement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 (owner: 10Catrope) [05:54:38] (03PS24) 10Catrope: WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [05:54:40] (03PS13) 10Catrope: WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 (owner: 10Divec) [05:57:36] (03CR) 10jenkins-bot: [V: 04-1] WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [05:57:48] (03CR) 10jenkins-bot: [V: 04-1] WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 (owner: 10Divec) [06:22:39] (03PS1) 10Aaron Schulz: Avoid DBPerformance log warnings due to isBlockedFrom() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309245 [08:44:38] 10Citoid, 10VisualEditor: Automatic citation tool adds wrong date - https://phabricator.wikimedia.org/T145052#2618486 (10Schnark) [08:49:59] (03Abandoned) 10Aaron Schulz: Avoid DBPerformance log warnings in parseAndStash() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309072 (owner: 10Aaron Schulz) [09:29:04] 10VisualEditor: Prompt for edit summary: When you switch from VisualEditor to the wikitext editor, it can't see your edit summary - https://phabricator.wikimedia.org/T144906#2618576 (10Schnark) 05stalled>03Open I can reproduce that the issue still/again exists: * I made sure that the warning is enabled in m... [09:53:10] 10Citoid, 10VisualEditor: Automatic citation tool adds wrong date - https://phabricator.wikimedia.org/T145052#2618486 (10Mvolz) We're using this property: ``` ``` Which, in UTC is ``` > var d = new Date('2016-03-08T01:16:07+02:0... [09:53:26] 10Citoid, 10VisualEditor, 06Services: Automatic citation tool adds wrong date - https://phabricator.wikimedia.org/T145052#2618675 (10Mvolz) [09:57:08] 10Citoid, 10VisualEditor, 06Services: Automatic citation tool adds wrong date - https://phabricator.wikimedia.org/T145052#2618691 (10Mvolz) It's a bit of a funny edge case, because as you point out, there is other metadata on the page, which we don't currently read in at all, that seems to have it published... [10:23:57] 10Citoid, 10VisualEditor, 06Services: Automatic citation tool adds wrong date - https://phabricator.wikimedia.org/T145052#2618730 (10Schnark) The difference between the data on the page and the metadata is probably caused by a similar issue that exists in Mediawiki version histories, too: When the entry was... [10:33:13] 10VisualEditor: Prompt for edit summary: When you switch from VisualEditor to the wikitext editor, it can't see your edit summary - https://phabricator.wikimedia.org/T144906#2618733 (10Whatamidoing-WMF) The report was on 20 August 2016. I believe that this editor is usually (but not always) running the lastest... [10:39:23] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, and 2 others: [Regression] Users can no longer edit reference features of citations to e.g. change their group or add {{openaccess}} or {{deadlink}} - https://phabricator.wikimedia.org/T133255#2618734 (10Whatamidoing-WMF... [10:40:29] 10VisualEditor, 06Community-Liaisons (Oct-Dec-2016), 05Goal: Phase 3, 4 in building the visual editor taskforce - https://phabricator.wikimedia.org/T145059#2618735 (10Elitre) [11:52:07] (03PS1) 10TheDJ: [Untested] Configure Ace with it's base path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) [12:09:49] 10VisualEditor, 10WikiEditor, 06Editing-Department, 10GLAM-Tech, and 2 others: Add support for hashtags (URL parameter -> edit summary) in VisualEditor, WikiEditor, and ?? other editors - https://phabricator.wikimedia.org/T123529#1931860 (10Pginer-WMF) >>! In T123529#2199342, @Sadads wrote: >>>! In T123529... [12:23:34] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: When inserting templates, consider using the name instead of a redirect - https://phabricator.wikimedia.org/T145067#2618919 (10Whatamidoing-WMF) [12:26:09] 10VisualEditor, 10CodeEditor, 13Patch-For-Review: VisualEditor/SyntaxHighlight/CodeEditor loads missing /w/worker-css.js file - https://phabricator.wikimedia.org/T124419#2618947 (10TheDJ) I've added the start of a patch to configure the base path, but I don't have anything setup for VE on my machines, so i h... [13:34:07] 10VisualEditor, 10VisualEditor-Tables: In VisualEditor Ctrl-Tab moves to the next table cell in addition to switching the tab - https://phabricator.wikimedia.org/T145074#2619131 (10Amire80) [15:12:56] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid, 13Patch-For-Review: Please put templates on separate lines (when it won't break things) and don't (when it will) - https://phabricator.wikimedia.org/T135667#2306229 (10Pols12) Is this bug fixed? If so, how to edit TemplateData parmaters... [15:31:36] (03CR) 10Jforrester: [C: 032] Rename mediawiki.action.history.diff to mediawiki.diff.styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/307487 (owner: 10WMDE-leszek) [15:37:49] (03Merged) 10jenkins-bot: Rename mediawiki.action.history.diff to mediawiki.diff.styles [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/307487 (owner: 10WMDE-leszek) [15:45:42] (03CR) 10Jforrester: "Is there an advantage to have APIVESerialise and APIVEEdit rather than combining them?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309236 (owner: 10Catrope) [16:12:46] (03CR) 10Alex Monk: Section editing in NWE (032 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [16:36:06] 10VisualEditor, 10MobileFrontend, 06Reading-Web-Backlog: some VisualEditor edits add