[05:50:18] 10VisualEditor: Virtual Editor display a long of text in Chinese Wikivoyage! - https://phabricator.wikimedia.org/T145318#2627450 (10Liuxinyu970226) [05:55:06] 10VisualEditor: Link to user guide should follow locally chosen language - https://phabricator.wikimedia.org/T145357#2627455 (10Elitre) [06:03:39] 10VisualEditor: "Show me both editor tabs" doesn't mean "switch" - https://phabricator.wikimedia.org/T145358#2627470 (10Elitre) [07:23:50] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#1936248 (10TheDJ) I also was able to reproduce this today on nl.wikipedia a bit too easily. I suspect it is the Zeusmodus gadget that... [10:22:10] (03PS2) 10Aaron Schulz: Avoid DBPerformance log warnings due to isBlockedFrom() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309245 [10:23:30] (03CR) 10Addshore: [C: 031] Avoid DBPerformance log warnings due to isBlockedFrom() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309245 (owner: 10Aaron Schulz) [10:33:45] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#2627934 (10TheDJ) It's the 'hiddeneditform' that zeus loads into read pages. If you enable the gadget, then visit a page, Zeus will a... [11:02:06] thedj: if you're right about ^^^, then we should probably make a sculpture in your honor or something. [11:06:34] 10VisualEditor, 10VisualEditor-MediaWiki: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor - https://phabricator.wikimedia.org/T123708#2628015 (10TheDJ) ``` "wgCurRevisionId":47439646 "wgRevisionId":47439646 "wgArticleId":453547, edittoken: f144bc25a67cc7c12038a8cc11a... [11:11:59] 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: Let users choose a visual or wikitext diff in the "Review your changes" tab - https://phabricator.wikimedia.org/T143350#2628045 (10Elitre) The RevisionSlider work (https://meta.wikimedia.org/wiki/Community_Tech/RevisionSlider - https://meta.wikimedia.org/wiki... [13:37:24] 10Cite, 06TCB-Team, 07Community-Wishlist-Survey, 07German-Community-Wishlist-Main-Wishes, and 2 others: Efficient way to refer to different pages of the same work when adding references to an article (#17) - https://phabricator.wikimedia.org/T100645#2628533 (10Lea_WMDE) [14:34:30] 10Citoid, 10VisualEditor: Please pull new HighBeam translator into Citoid - https://phabricator.wikimedia.org/T145398#2628732 (10Elitre) [14:41:57] 10Citoid, 10VisualEditor: Please pull new HighBeam translator into Citoid - https://phabricator.wikimedia.org/T145398#2628759 (10Elitre) [15:40:38] (03PS6) 10Mvolz: [WIP] Allow users to select cite template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265200 (https://phabricator.wikimedia.org/T97936) [15:41:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Allow users to select cite template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/265200 (https://phabricator.wikimedia.org/T97936) (owner: 10Mvolz) [15:42:02] edsanders: this change used to work and I can't figure out what has broken in the interrum: ^It displays all the insert buttons, but only the first one is highlighted, and the insert button doesn't work. maybe a change to how unique buttons can be in ooui or something? [15:42:04] ideas? [15:42:31] insert buttons used to work about 6 months ago :P [15:49:24] (03CR) 10DLynch: [C: 032] Move image-paste blocking to transfer handler match function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/304056 (https://phabricator.wikimedia.org/T142622) (owner: 10Esanders) [15:55:20] (03Merged) 10jenkins-bot: Move image-paste blocking to transfer handler match function [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/304056 (https://phabricator.wikimedia.org/T142622) (owner: 10Esanders) [16:40:01] 10VisualEditor: "Uncaught TypeError: Cannot read property 'scrollElementIntoView' of null" - https://phabricator.wikimedia.org/T145334#2626859 (10DLynch) It's not consistent. So far, I've seen the error happen: 1. When initially loading the wikitext error. 1. When switching to VE. 1. When switching back from VE... [16:45:24] 10VisualEditor, 10VisualEditor-MediaWiki, 06Developer-Relations (Oct-Dec-2016), 07Notice: Tech Talk for the 2017 wikitext editor - https://phabricator.wikimedia.org/T145417#2629431 (10Elitre) [16:54:21] 10VisualEditor: "Uncaught TypeError: Cannot read property 'scrollElementIntoView' of null" - https://phabricator.wikimedia.org/T145334#2626859 (10Jdforrester-WMF) >>! In T145334#2629370, @DLynch wrote: > It's not consistent. So far, I've seen the error happen: > > 1. When initially loading the wikitext error. >... [17:40:30] 10VisualEditor: "Uncaught TypeError: Cannot read property 'scrollElementIntoView' of null" - https://phabricator.wikimedia.org/T145334#2629683 (10Jdforrester-WMF) I've now switched back and forth with and without changes a bunch of times in master without triggering this bug. Plausibly this is fixed. [18:40:25] (03PS2) 10Bartosz Dziewoński: ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) [18:41:28] (03CR) 10Jforrester: [C: 031] ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [18:59:19] 10VisualEditor: "Show me both editor tabs" doesn't mean "switch" - https://phabricator.wikimedia.org/T145358#2627470 (10Esanders) I assume this is because we reload the current URI to get both tabs, but we've already set ?action=edit [19:02:01] 10VisualEditor: Virtual Editor display a long of text in Chinese Wikivoyage! - https://phabricator.wikimedia.org/T145318#2626381 (10Esanders) VE does not yet support the language variations syntax used by Chinese wikis. [19:05:20] 10VisualEditor: Link to user guide should follow locally chosen language - https://phabricator.wikimedia.org/T145357#2627455 (10Esanders) If we're going to link to User guide/LANGCODE, we need to know in advance if the guide has been translated into that language, otherwise they'll get a 404. [19:08:54] 10VisualEditor, 10Flow, 03Collab-Team-Q1-July-Sep-2016, 13Patch-For-Review, 05WMF-deploy-2016-09-06_(1.28.0-wmf.18): [Regression wmf.17] "Uncaught TypeError: Cannot read property 'model' of undefined" on clicking 'Edit description' - https://phabricator.wikimedia.org/T139972#2630132 (10Jdforrester-WMF) ... [19:15:59] Elitre: yeah, so zeusmode loads the editpage in the background and inserts it into the current page. [19:17:35] this either corrupts the content that is posted to parsoid, or and I think this is more likely the edittoken changes and visualeditoredit doesn't handle that fully when it tries to post to parsoid. [19:18:41] 10VisualEditor: VisualEditor used the longer "mediawikiwiki" interwiki prefix instead of the (usually) standard "mw" one - https://phabricator.wikimedia.org/T145337#2626999 (10Jdforrester-WMF) I think this is the order specified in the interwiki map, which is what Parsoid uses. [19:19:03] in the mean time, it seems i have problems with addOnloadHook ... [19:21:06] 10Citoid, 10VisualEditor: Please pull new HighBeam translator into Citoid - https://phabricator.wikimedia.org/T145398#2630164 (10Jdforrester-WMF) p:05Triage>03Normal [19:29:26] 10VisualEditor: Link to user guide should follow locally chosen language - https://phabricator.wikimedia.org/T145357#2630183 (10Esanders) So the link is taken from a message 'visualeditor-help-link'. If you change that on TranslateWiki it should come through in the next release. [19:30:05] 10VisualEditor: Link to user guide should follow locally chosen language - https://phabricator.wikimedia.org/T145357#2630199 (10Esanders) 05Open>03Resolved a:03Esanders [19:40:09] 10VisualEditor: Link to user guide should follow locally chosen language - https://phabricator.wikimedia.org/T145357#2630224 (10Esanders) 05Resolved>03Open Currently we link to Special:MyLanguage which will use your preference language for MW.org. Unfortunately this will be unset for most people. I think it... [19:41:10] 10VisualEditor, 10VisualEditor-InterfaceLanguage, 10VisualEditor-MediaWiki, 07I18n: VisualEditor: As much as possible, the link to the user manual should lead directly to a manual in the user's language - https://phabricator.wikimedia.org/T53797#2630230 (10Esanders) [19:41:12] 10VisualEditor: Link to user guide should follow locally chosen language - https://phabricator.wikimedia.org/T145357#2630232 (10Esanders) [19:44:21] 10VisualEditor, 10VisualEditor-InterfaceLanguage, 10VisualEditor-MediaWiki, 07I18n: VisualEditor: As much as possible, the link to the user manual should lead directly to a manual in the user's language - https://phabricator.wikimedia.org/T53797#2630239 (10Esanders) >>! In T53797#564658, @Nikerabbit wrote:... [19:50:24] 10VisualEditor: "Uncaught TypeError: Cannot read property 'scrollElementIntoView' of null" - https://phabricator.wikimedia.org/T145334#2630271 (10Esanders) 05Open>03Resolved a:03Esanders [19:55:03] 10VisualEditor, 07Technical-Debt: ve.dm.APIResultsProvider seems to be mostly dead code - https://phabricator.wikimedia.org/T145301#2625980 (10Esanders) Plausibly having an abstract parent class would make sense here, and it could be used in other cases we want to infinite-scroll a set of API results, e.g. T14... [19:56:18] (03CR) 10Krinkle: "Consider using the much smaller phpjs/md5.js or phpjs/sha1.js implementation instead of SparkMD5, or perhaps fnv1 instead of md5 or sha1." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/304970 (https://phabricator.wikimedia.org/T142943) (owner: 10Esanders) [20:19:28] 10VisualEditor, 07Community-Wishlist-Survey: Save edits before publishing - https://phabricator.wikimedia.org/T120479#2630388 (10Quiddity) [20:34:43] 10VisualEditor, 07Community-Wishlist-Survey: Save edits before publishing - https://phabricator.wikimedia.org/T120479#1854520 (10Jdforrester-WMF) Is this just a dupe of {T57370} effectively? (We're working on that one, slowly.) [20:52:45] (03CR) 10Esanders: "I'm happy to use fnv1 if it is" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/304970 (https://phabricator.wikimedia.org/T142943) (owner: 10Esanders) [20:54:59] 10VisualEditor, 10VisualEditor-DataModel: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2630656 (10Esanders) [20:55:34] 10VisualEditor, 10VisualEditor-DataModel: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2630675 (10Esanders) //From gerrit:// I'm happy to use fnv1 if it is * Collision safe (although doesn't have to be cryptographically secure) * Faster * Put in a separat... [20:55:42] (03CR) 10Esanders: "See T145456" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/304970 (https://phabricator.wikimedia.org/T142943) (owner: 10Esanders) [20:57:11] 10VisualEditor, 10VisualEditor-DataModel, 07Performance, 07Technical-Debt: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2630681 (10Jdforrester-WMF) p:05Triage>03Normal [20:59:05] 10VisualEditor, 10VisualEditor-DataModel, 07Performance, 07Technical-Debt: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2630701 (10Esanders) >>! In T145456#2630675, @Esanders wrote: > * Faster To clarify, our typical use case is hashing HTML strings... [21:14:00] 10VisualEditor, 10Wikimedia-General-or-Unknown: List items in toolbar of WikiEditor missing in Chinese Wikivoyage - https://phabricator.wikimedia.org/T145203#2630752 (10Jdforrester-WMF) [21:17:50] 10Citoid, 10VisualEditor, 06Services, 13Patch-For-Review: Citoid returns a date in UTC, not following the timezone - https://phabricator.wikimedia.org/T145052#2630781 (10Jdforrester-WMF) p:05Triage>03Normal [21:24:25] 10Citoid, 10VisualEditor, 07User-notice: Provide auto-citations based on ISBNs in Wikimedia production - https://phabricator.wikimedia.org/T145462#2630816 (10Jdforrester-WMF) [21:26:05] 10Citoid, 10VisualEditor: Credit the source of the ISBN data - https://phabricator.wikimedia.org/T145463#2630832 (10Jdforrester-WMF) [21:26:54] 10Citoid, 10VisualEditor: Credit the source of the citation - https://phabricator.wikimedia.org/T145464#2630847 (10Jdforrester-WMF) [21:28:56] 10Citoid, 10VisualEditor: Indicate the source of the citation data in the response - https://phabricator.wikimedia.org/T145465#2630861 (10Jdforrester-WMF) [21:29:15] 10Citoid, 10VisualEditor, 07User-notice: Provide auto-citations based on ISBNs in Wikimedia production - https://phabricator.wikimedia.org/T145462#2630875 (10Jdforrester-WMF) [21:29:17] 10Citoid, 10VisualEditor, 07Epic, 15User-mobrovac, 07User-notice: Add ISBN as look-up option - https://phabricator.wikimedia.org/T1084#2630876 (10Jdforrester-WMF) [21:35:26] 10Citoid, 10VisualEditor: Credit the source of the citation - https://phabricator.wikimedia.org/T145464#2630903 (10Jdforrester-WMF) Something like this: {F4461188} (//i.e.//, `
Powered by Zotero
` in the `

`). and ``` lang=css .credit { font-size:x-small; text-align:right;... [21:38:43] 10Citoid, 10VisualEditor: Where returning data from WorldCat, include the OCLC# - https://phabricator.wikimedia.org/T145467#2630909 (10Jdforrester-WMF) [21:39:15] 10Citoid, 10VisualEditor, 07Epic, 15User-mobrovac: Add ISBN as look-up option to the citoid service - https://phabricator.wikimedia.org/T1084#2630923 (10Jdforrester-WMF) [21:42:19] 10Citoid, 10VisualEditor, 15User-mobrovac: Add OCLC API key/token to citoid production service and get everything ready - https://phabricator.wikimedia.org/T145468#2630932 (10Jdforrester-WMF) [21:47:54] 10Citoid, 10VisualEditor, 15User-mobrovac: Please pull new HighBeam translator into Citoid - https://phabricator.wikimedia.org/T145398#2630966 (10mobrovac) a:03mobrovac [22:00:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-ZeroBanner, 06Reading-Web-Backlog, and 2 others: ZeroBanner referencing a VE-MW renamed class - viewPageTarget - https://phabricator.wikimedia.org/T111843#2630998 (10Jdlrobson) Thanks Alex! [22:04:05] (03CR) 10Esanders: [C: 04-1] ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [22:49:26] 10VisualEditor, 10OOjs-UI: Gray for active elements in the VE toolbar is too light - https://phabricator.wikimedia.org/T98988#2631173 (10Volker_E) [22:55:17] 10VisualEditor, 10OOjs-UI: Gray for active elements in the VE toolbar is too light - https://phabricator.wikimedia.org/T98988#1282844 (10Volker_E) Version 0.17.9 of OOjs UI will roll out an overhaul of various elements to comply to WCAG 2.0 level AA guidelines, based on a new, improved color palette by design... [23:04:39] (03CR) 10Bartosz Dziewoński: ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [23:32:35] 10VisualEditor, 10VisualEditor-EditingTools, 10OOjs-UI, 10UI-Standardization, and 3 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#2631301 (10Volker_E)