[00:02:53] 10VisualEditor, 10ProofreadPage, 07Verified: Cannot open VE on test2, getting error "TypeError: Right-hand side of 'instanceof' is not an object " - https://phabricator.wikimedia.org/T145715#2642473 (10AlexMonk-WMF) On test2 or in beta? [00:08:12] 10VisualEditor, 10ProofreadPage, 07Verified: Cannot open VE on test2, getting error "TypeError: Right-hand side of 'instanceof' is not an object " - https://phabricator.wikimedia.org/T145715#2639029 (10Paladox) Ah yeh they rolled back wmf 19 back to wmf 18. We will need to back port that patch to wmf 19 and 18. [00:09:41] 10Cite: Cite RefToolbar - Templates dropdown not displaying - https://phabricator.wikimedia.org/T145787#2642480 (10BrillLyle) @Aklapper -- Hey I just tried logging OUT of Wikipedia and the dropdown menu works in Chrome! Why would it do that?!? It also works (either logged on or logged out) in Firefox. Blargh.... [00:38:44] 10VisualEditor, 10ProofreadPage, 07Verified: Cannot open VE on test2, getting error "TypeError: Right-hand side of 'instanceof' is not an object " - https://phabricator.wikimedia.org/T145715#2642508 (10Ryasmeen) Yeah, I am getting it on test2. [01:23:32] (03PS1) 10Legoktm: Remove unused ContentHandlerDefaultModelFor hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311076 [01:23:34] (03PS1) 10Legoktm: Avoid RequestContext::getMain() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311077 [03:02:02] 10VisualEditor, 10VisualEditor-EditingTools, 10UI-Standardization, 07Accessibility, and 3 others: Gray for "inactive" elements in the toolbar is too light - https://phabricator.wikimedia.org/T89271#2642671 (10Volker_E) [08:57:53] 10VisualEditor: While editing on VE, ctrl+clic should open the link in a new tab, not opening link inspector - https://phabricator.wikimedia.org/T145850#2643006 (10Trizek-WMF) [09:43:12] hi folks. a lot of time when people change links with VisualEditor, they change only the link text, leading to awkward stuff like this: https://no.wikipedia.org/w/index.php?title=Per_Brandtz%C3%A6g&action=history [09:43:39] i've been trying to search phabricator to see if there is a bug for it, or if i should file one, but i'm not really sure what search terms to use TBH [09:44:51] so i guess my question is if anyone knows if this is an open issue, or if i should file it [09:45:31] wrong link in my first message, this is the correct one: https://no.wikipedia.org/w/index.php?title=Per_Brandtz%C3%A6g&diff=16669753&oldid=16669728 [09:52:26] 10Citoid, 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki-References: Incorrect itemType causing missing parameter in citation - https://phabricator.wikimedia.org/T93355#2643109 (10The_RedBurn) [10:46:39] Jhs: yeah, it's a known issue. i can't find the task for it, but when James_F wakes up he'll probably know which one it is [10:46:56] MatmaRex, coolio (Y) [10:53:49] MatmaRex, Jhs: was it one of the ones related to https://phabricator.wikimedia.org/T55973 perhaps? [11:01:08] 10VisualEditor, 10ProofreadPage, 07Verified: Cannot open VE on test2, getting error "TypeError: Right-hand side of 'instanceof' is not an object " - https://phabricator.wikimedia.org/T145715#2643280 (10AlexMonk-WMF) If it can be reproduced in beta, let's keep this open. If it can be reproduced on non-testing... [11:03:26] 10VisualEditor, 07Browser-Tests: Disable VisualEditor Selenium tests that fail with RSpec::Expectations::ExpectationNotMetError - https://phabricator.wikimedia.org/T145861#2643284 (10zeljkofilipin) [11:03:49] 10VisualEditor, 07Browser-Tests: Disable VisualEditor Selenium tests that fail with RSpec::Expectations::ExpectationNotMetError - https://phabricator.wikimedia.org/T145861#2643297 (10zeljkofilipin) p:05Triage>03Low [11:03:58] 10VisualEditor, 07Browser-Tests, 15User-zeljkofilipin: Disable VisualEditor Selenium tests that fail with RSpec::Expectations::ExpectationNotMetError - https://phabricator.wikimedia.org/T145861#2643284 (10zeljkofilipin) [11:12:36] (03PS1) 10Zfilipin: Disable failing Selenium tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311113 (https://phabricator.wikimedia.org/T145861) [11:15:49] yeah, probably [11:15:53] (03CR) 10Zfilipin: "Tested at:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311113 (https://phabricator.wikimedia.org/T145861) (owner: 10Zfilipin) [11:16:55] 10VisualEditor, 07Browser-Tests, 13Patch-For-Review, 15User-zeljkofilipin: Disable VisualEditor Selenium tests that fail with RSpec::Expectations::ExpectationNotMetError - https://phabricator.wikimedia.org/T145861#2643349 (10zeljkofilipin) [12:03:57] (03CR) 10Zfilipin: "The job is green. I will wait a few days for comments before self-merging. +2 at will." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311113 (https://phabricator.wikimedia.org/T145861) (owner: 10Zfilipin) [12:46:53] 10Citoid, 10VisualEditor: Credit the source of the ISBN data - https://phabricator.wikimedia.org/T145463#2630832 (10Mvolz) Not sure this merits a separate task from T145464? Implementation wise, it'll probably say "Powered by" or "Metadata retrieved from" and then the remaining text one or multiple of Zotero,... [12:48:04] 10Citoid, 10VisualEditor: Credit the source of the ISBN data - https://phabricator.wikimedia.org/T145463#2643490 (10Mvolz) (Is there a clean way to give multiple sources and then do that in i18n?) [12:52:49] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Harv style citations based on T95702 solution - https://phabricator.wikimedia.org/T144695#2643494 (10Mvolz) @Jdforrester-WMF thoughts? This particular tack seems like it would make the front end not very clean. For instance, the cas... [12:58:14] 10Citoid, 10VisualEditor: Where returning data from WorldCat, include the OCLC# - https://phabricator.wikimedia.org/T145467#2630909 (10Mvolz) Is this a worldcat requirement? The OCLC # is already in the URL. It is indeed already a valid param on en wiki though so that's trivia to add to template data at lea... [12:58:29] 10Citoid, 10VisualEditor: Indicate the source of the citation data in the response - https://phabricator.wikimedia.org/T145465#2643501 (10Mvolz) a:03Mvolz [13:31:40] 10VisualEditor, 10GLAM-Tech: Add controls to set start and end times for audio and video files when adding media to articles in Visual Editor - https://phabricator.wikimedia.org/T145761#2643560 (10Sadads) [13:52:01] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Harv style citations based on T95702 solution - https://phabricator.wikimedia.org/T144695#2643616 (10Trizek-WMF) I think the idea is not to focus on Harv itself but to have a way to define a source somewhere and insert that source by... [15:05:33] 10Citoid, 10VisualEditor: Indicate the source of the citation data in the response - https://phabricator.wikimedia.org/T145465#2643799 (10Mvolz) Does anyone care what I call this? Currently calling it 'source' because that is short and sweet, but possibly ambiguous. metadataSource? [16:31:29] (03CR) 10Jforrester: [C: 032] "Can you see why this suddenly started failing? The code for the settings page hasn't changed in years." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311113 (https://phabricator.wikimedia.org/T145861) (owner: 10Zfilipin) [16:31:58] (03CR) 10Jforrester: [C: 032] Remove unused ContentHandlerDefaultModelFor hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311076 (owner: 10Legoktm) [16:33:18] (03CR) 10Jforrester: [C: 032] Avoid RequestContext::getMain() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311077 (owner: 10Legoktm) [16:40:26] (03Merged) 10jenkins-bot: Disable failing Selenium tests [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311113 (https://phabricator.wikimedia.org/T145861) (owner: 10Zfilipin) [16:40:29] (03Merged) 10jenkins-bot: Remove unused ContentHandlerDefaultModelFor hook [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311076 (owner: 10Legoktm) [16:41:44] (03Merged) 10jenkins-bot: Avoid RequestContext::getMain() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311077 (owner: 10Legoktm) [16:43:26] 10VisualEditor, 10VisualEditor-MediaWiki: Update VisualEditor to be compatible with magic links being disabled - https://phabricator.wikimedia.org/T145589#2643951 (10AlexMonk-WMF) Wouldn't this need to be dealt with in parsoid? Or are you suggesting we might want to disable any kind of recognition of this type... [16:55:41] 10Citoid, 10VisualEditor, 13Patch-For-Review: Indicate the source of the citation data in the response - https://phabricator.wikimedia.org/T145465#2643984 (10Mvolz) [17:36:51] 10Citoid, 10VisualEditor: Where returning data from WorldCat, include the OCLC# - https://phabricator.wikimedia.org/T145467#2644135 (10Jdforrester-WMF) >>! In T145467#2643499, @Mvolz wrote: > Is this a worldcat requirement? It's a strongly requested feature, and I think it's worth adding. Having it in the cit... [17:38:32] 10Citoid, 10VisualEditor: Credit the source of the ISBN data - https://phabricator.wikimedia.org/T145463#2644137 (10Jdforrester-WMF) >>! In T145463#2643486, @Mvolz wrote: > Not sure this merits a separate task from T145464? I was assuming we'd do one before the other. :-) > Implementation wise, it'll probabl... [17:40:17] 10VisualEditor, 10VisualEditor-MediaWiki: Update VisualEditor to be compatible with magic links being disabled - https://phabricator.wikimedia.org/T145589#2635134 (10Jdforrester-WMF) It'd need to be dealt with in Parsoid too, but VE has client-side auto-magic-linking of typed and pasted content, IIRC? [17:40:58] 10Citoid, 10VisualEditor, 13Patch-For-Review: Indicate the source of the citation data in the response - https://phabricator.wikimedia.org/T145465#2644147 (10Jdforrester-WMF) >>! In T145465#2643799, @Mvolz wrote: > Does anyone care what I call this? Currently calling it 'source' because that is short and swe... [17:42:59] 10Citoid, 10VisualEditor: Credit the source of the ISBN data - https://phabricator.wikimedia.org/T145463#2644150 (10Jdforrester-WMF) (Sorry, forgot to actually give the rest of my comment.) … So, I was thinking this'd return some string values 'foo', 'bar' and locally we'd check to know if we recognise them;... [18:19:12] thanks James_F [18:19:31] James_F: you also might have an opinion on https://www.mediawiki.org/wiki/Topic:Tbnj635o3gu7m6xs [18:30:31] 10Citoid, 10VisualEditor: Where returning data from WorldCat, include the OCLC# - https://phabricator.wikimedia.org/T145467#2644295 (10Mvolz) a:03Mvolz [18:52:38] legoktm: Looking. [19:08:21] (03PS1) 10Tchanders: WIP/EXPERIMENTAL Make ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311173 [19:08:42] (03CR) 10jenkins-bot: [V: 04-1] WIP/EXPERIMENTAL Make ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311173 (owner: 10Tchanders) [19:38:09] 10VisualEditor, 10VisualEditor-MediaWiki: Update VisualEditor to be compatible with magic links being disabled - https://phabricator.wikimedia.org/T145589#2644377 (10AlexMonk-WMF) >>! In T145589#2644144, @Jdforrester-WMF wrote: > VE has client-side auto-magic-linking of typed and pasted content, IIRC? Right.... [20:20:36] 10VisualEditor: Tab to indent bullets causes an unselected bullet to indent - https://phabricator.wikimedia.org/T145892#2644434 (10ksmith) [20:24:26] 10VisualEditor: Clicking between a bullet circle and the associated text doesn't move the cursor - https://phabricator.wikimedia.org/T145893#2644448 (10ksmith) [20:25:04] 10VisualEditor: Clicking between a bullet circle and the associated text doesn't move the cursor - https://phabricator.wikimedia.org/T145893#2644461 (10ksmith) [20:31:46] (03PS2) 10Tchanders: WIP/EXPERIMENTAL Make ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311173 [20:32:05] (03CR) 10jenkins-bot: [V: 04-1] WIP/EXPERIMENTAL Make ve.dm.VisualDiff [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311173 (owner: 10Tchanders) [20:59:52] 10VisualEditor, 10VisualEditor-MediaWiki: Update VisualEditor to be compatible with magic links being disabled - https://phabricator.wikimedia.org/T145589#2644544 (10Legoktm) Yeah, I think we have two options: 1. not treat them any different when functionality is disabled, and let users manually create links... [21:35:13] 10VisualEditor, 07Beta-Cluster-reproducible: Getting Error loading data from server: HTTP 504 while trying to open VE on Beta cluster - https://phabricator.wikimedia.org/T145900#2644613 (10Ryasmeen) [23:00:58] 10VisualEditor, 10Phlogiston (Technical Debt), 15User-JAufrecht: Points column in Recently Closed report is empty. - https://phabricator.wikimedia.org/T145593#2644927 (10JAufrecht)