[00:25:31] 10VisualEditor, 10Phlogiston (Burnup-Support), 15User-JAufrecht: Velocity tracking in Phlogiston for VE/NWE seems off? - https://phabricator.wikimedia.org/T144516#2654582 (10Jdforrester-WMF) 05Open>03Resolved I think External should trump the tree, actually (because work done by others should be counted... [00:47:27] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Harv style citations based on T95702 solution - https://phabricator.wikimedia.org/T144695#2654593 (10Whatamidoing-WMF) I think that your first point is redundant. It sounds like you'd really be having it search for a particular param... [01:11:12] (03CR) 10Jforrester: [C: 032] Pass document to preview through PST [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311863 (owner: 10Alex Monk) [01:16:14] (03PS10) 10Jforrester: Section editing in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [01:16:16] (03PS2) 10Jforrester: Pass document to preview through PST [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311863 (owner: 10Alex Monk) [01:16:48] (03CR) 10Jforrester: [C: 04-1] "Section edit loads into VE for me on e.g. template pages. :-(" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [01:17:03] (03CR) 10Jforrester: [C: 032] "Bah." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311863 (owner: 10Alex Monk) [01:23:02] (03Merged) 10jenkins-bot: Pass document to preview through PST [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311863 (owner: 10Alex Monk) [05:48:50] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Harv style citations based on T95702 solution - https://phabricator.wikimedia.org/T144695#2655090 (10ManosHacker) A " {{Citation " citation should be treated as if it already contains a " |ref=harv " in code, because it behaves like i... [05:52:44] (03PS1) 10Esanders: Temporarily override broken toolbar border colour [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311919 [07:46:22] 10VisualEditor, 10Parsoid: Headings occasionally serialised as

elements rather than \n\n== Foo ==\n in Parsoid - https://phabricator.wikimedia.org/T145211#2655268 (10Elitre) [07:50:59] 10VisualEditor: While editing on VE, ctrl+clic should open the link in a new tab, not opening link inspector - https://phabricator.wikimedia.org/T145850#2655275 (10Trizek-WMF) While editing, a ctrl+clic on a link doesn't open the link on a new tab. * on Chromium 52 (Ubuntu 16.04), it opens the link inspector, *... [08:03:44] 10VisualEditor, 10VisualEditor-ContentEditable: Reconsider hiding slugs between two content (text) nodes - https://phabricator.wikimedia.org/T146128#2655284 (10Trizek-WMF) Maybe have a test and compare which solution is the best? [08:35:23] 10VisualEditor: Typing "=" at start of headline should increase level - https://phabricator.wikimedia.org/T146264#2655333 (10Schnark) [08:49:16] 10VisualEditor, 10MediaWiki-Authentication-and-authorization, 10MobileFrontend: SMW triggers "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T134562#2655365 (10Nikerabbit) The general issue stills pops out here and then in somewhat different forms. I saw it happen with visual... [11:52:49] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media, 06Multimedia, 13Patch-For-Review: In the cross-wiki upload tool, check that the name of the file doesn't duplicate a local files elsewise they can't use the file - https://phabricator.wikimedia.org/T117498#2655728 (10matthiasmull... [11:57:07] 10Cite, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#2655733 (10Cenarium) >>! In T124840#2653575, @daniel wrote: > Mashing this into page_props str... [14:36:16] 10VisualEditor, 10MediaWiki-Authentication-and-authorization, 10MobileFrontend: SMW triggers "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T134562#2656041 (10Anomie) MobileFrontend in that stack trace is doing what it's supposed to do: it's loading the message via the Resou... [15:02:38] (03CR) 10Jforrester: [C: 032] Temporarily override broken toolbar border colour [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311919 (owner: 10Esanders) [15:06:35] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 06Multimedia, 13Patch-For-Review: In the cross-wiki upload tool, the upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#2656087 (10matthiasmullie) a:03matthiasmullie [15:09:44] (03Merged) 10jenkins-bot: Temporarily override broken toolbar border colour [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311919 (owner: 10Esanders) [16:34:09] (03PS1) 10DLynch: dm.MWInternalLinkAnnotation: Add some test cases [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312028 [16:35:19] (03CR) 10DLynch: "I've written up a test of the current behavior here: https://gerrit.wikimedia.org/r/#/c/312028/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [16:38:16] (03CR) 10jenkins-bot: [V: 04-1] dm.MWInternalLinkAnnotation: Add some test cases [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312028 (owner: 10DLynch) [16:46:20] (03PS2) 10DLynch: dm.MWInternalLinkAnnotation: Add some test cases [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312028 [16:50:21] 10Cite, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#2656486 (10daniel) @Cenarium Looks like it's worth further investigation. The interaction with... [16:57:53] 10VisualEditor, 10Parsoid: Headings occasionally serialised as

elements rather than \n\n== Foo ==\n in Parsoid - https://phabricator.wikimedia.org/T145211#2656531 (10Nnvu) I asked some of the users in itwiki if they remember how they have done the edits that added the

tag. If the answer me with usefu... [16:58:01] (03PS3) 10Jforrester: dm.MWInternalLinkAnnotation: Add some test cases [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312028 (owner: 10DLynch) [16:58:03] (03PS1) 10Jforrester: Update VE core submodule to master (e3192e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312043 [16:58:10] (03CR) 10DLynch: [C: 032] On CBN detach, mark contentBranchNodeChanged in the CE Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311371 (https://phabricator.wikimedia.org/T122291) (owner: 10Divec) [17:01:13] (03Merged) 10jenkins-bot: On CBN detach, mark contentBranchNodeChanged in the CE Surface [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311371 (https://phabricator.wikimedia.org/T122291) (owner: 10Divec) [17:09:25] James_F, okay we actually have 14 references to parsoid in ve core [17:09:42] particularly src/ui/widgets/ve.ui.MediaSizeWidget.js talking about upright [17:09:42] Krenair: Yeah. :-( [17:09:51] Oh, hah, yeah, that's a mess. [17:10:01] src/dm/ve.dm.Annotation.js: * FIXME T126037: This method strips data-parsoid & Parsoid IDs from HTML attributes for comparisons. [17:10:03] T126037: ve.dm.Annotation#getComparableHtmlAttributes: Remove if we're convinced Parsoid merges similar annotations well enough - https://phabricator.wikimedia.org/T126037 [17:10:08] this is the part we're interested in? [17:13:10] 10VisualEditor, 10VisualEditor-Links, 13Patch-For-Review: Error when clicking on a link ending with a question mark - https://phabricator.wikimedia.org/T145978#2656587 (10Jdforrester-WMF) p:05Triage>03High a:03Catrope [17:14:11] (03CR) 10Jforrester: [C: 032] dm.MWInternalLinkAnnotation: Add some test cases [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312028 (owner: 10DLynch) [17:15:00] (03CR) 10DLynch: [C: 032] Update VE core submodule to master (e3192e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312043 (owner: 10Jforrester) [17:18:40] Thanks Kemayo. [17:19:06] Krenair: No, I think it's going to be in Surface. [17:20:32] ve.ce.Surface#onPaste() I guess. [17:20:33] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, 13Patch-For-Review: In the cross-wiki upload tool, the upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#2656635 (10matmarex) [17:20:55] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, 13Patch-For-Review: In the cross-wiki upload tool, the upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#1777212 (10matmarex) [17:22:12] Sorry, am in a meeting. [17:22:59] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, 13Patch-For-Review: In the cross-wiki upload tool, the upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#2656645 (10matmarex) Per T141814, this is not causing exceptions today,... [17:23:03] (03Merged) 10jenkins-bot: Update VE core submodule to master (e3192e2) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312043 (owner: 10Jforrester) [17:23:05] (03Merged) 10jenkins-bot: dm.MWInternalLinkAnnotation: Add some test cases [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312028 (owner: 10DLynch) [17:27:07] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-DataModel, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Native selection broken after branch node conversion - https://phabricator.wikimedia.org/T122291#2656655 (10Jdforrester-WMF) 05Open>03Resolved a:03Jdforrester-WMF [17:30:24] src/ce/ve.ce.Surface.js: // FIXME T126044: Remove Parsoid IDs [17:30:25] T126044: ve.ce.Surface#afterPaste shouldn't have code to remove Parsoid IDs - https://phabricator.wikimedia.org/T126044 [17:30:43] (03PS3) 10Jforrester: dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [17:31:17] (03PS2) 10Jforrester: ce.MWTransclusionNode: Clean up href normalization [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311355 (owner: 10Catrope) [17:32:30] 10Cite, 06TCB-Team, 07German-Community-Wishlist, 13Patch-For-Review: Section edit preview doesn't let you preview references defined outside the section being previewed - https://phabricator.wikimedia.org/T124840#2656675 (10Cenarium) >>! In T124840#2656486, @daniel wrote: > @Cenarium Looks like it's worth... [17:33:24] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia: In the upload dialog, pre-populate date information from the file's EXIF data - https://phabricator.wikimedia.org/T117547#2656679 (10matmarex) [17:33:27] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia: Show progress during media upload - https://phabricator.wikimedia.org/T117546#2656680 (10matmarex) [17:33:31] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, and 2 others: In the cross-wiki upload tool, check that the name of the file doesn't duplicate a local files elsewise they can't use the file - https://phabricator.wikimedia.org/T117498#2656682 (10matmarex) [17:33:35] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, and 3 others: Give guidance in the new upload form, to prevent the most common errors - e.g. bad file titles - https://phabricator.wikimedia.org/T116086#2656683 (10matmarex) [17:33:40] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, and 2 others: Name the licence on the first screen of the media upload dialog - https://phabricator.wikimedia.org/T116046#2656684 (10matmarex) [17:33:50] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, 07Design: Provide a way during the upload stage for the user to change their mind about what file to upload once they've started it uploading - https://phabricator.wikimedia.org/T114938#2656690 (10matmarex) [17:35:24] (03CR) 10jenkins-bot: [V: 04-1] dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [17:36:06] (03CR) 10jenkins-bot: [V: 04-1] ce.MWTransclusionNode: Clean up href normalization [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311355 (owner: 10Catrope) [17:45:15] 10VisualEditor, 10Parsoid: Headings occasionally serialised as

elements rather than \n\n== Foo ==\n in Parsoid - https://phabricator.wikimedia.org/T145211#2656752 (10Nnvu) Une user told me he had done a copy-paste from a page in VE edit mode to another one in VE edit mode. Unfortunately, his edit was done... [18:15:41] Kemayo: You around to talk about href decoding? [18:17:27] (03PS4) 10Catrope: dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) [18:21:40] (03CR) 10jenkins-bot: [V: 04-1] dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [18:22:13] Kemayo, James_F: It turns out T119431 is actually already broken even for non-percent-containing URLs. I'll file a bug [18:22:14] T119431: Percent-encoded URIs to Wikipedia articles aren't recognized when pasted into the Link tool - https://phabricator.wikimedia.org/T119431 [18:24:40] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Internal link URL detection incorrectly switches inspector state to "External link" - https://phabricator.wikimedia.org/T146306#2656903 (10Catrope) [18:25:56] 10WikiEditor, 06Multimedia, 07Design: "Insert media" dialog offers confusing insert/upload alternative buttons - https://phabricator.wikimedia.org/T135917#2315270 (10Whatamidoing-WMF) @Nemo_bis, I'd like to know more about exactly what you're observing. Generally speaking, I'd expect people who click on t... [18:26:48] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Internal link URL detection incorrectly switches inspector state to "External link" - https://phabricator.wikimedia.org/T146306#2656921 (10Catrope) [18:29:06] (03CR) 10Catrope: "This change doesn't break T119431, and actually makes its behavior better. In master, pasting http://localhost:8080/wiki/Question_mark%3F " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [18:29:29] (03CR) 10Catrope: "(PS4 updates the tests introduced in the previous commit to account for the fact that the definition of origTitle changed)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [19:02:15] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, and 2 others: In the cross-wiki upload tool, the upload can timeout causing an unhandled exception - https://phabricator.wikimedia.org/T117545#2657076 (10matmarex) 05Open>03Resolved [19:19:48] (03CR) 10Esanders: On CBN detach, mark contentBranchNodeChanged in the CE Surface (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311371 (https://phabricator.wikimedia.org/T122291) (owner: 10Divec) [19:23:03] 10TemplateData, 10VisualEditor: Have a way to prevent unexpected additions of parameters in a template via TemplateData - https://phabricator.wikimedia.org/T146129#2651616 (10Whatamidoing-WMF) This might be addressed by {T64417}, especially the idea of marking the current TemplateData as "complete" in T64417#1... [20:08:53] (03PS1) 10Esanders: Only unregister WT string handler in WT handler factory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312096 (https://phabricator.wikimedia.org/T144653) [20:09:32] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Enabling NWE breaks wikitext pasting in VE - https://phabricator.wikimedia.org/T144653#2657266 (10Esanders) Turns out I'd already done most of the hard work to make this happen (creating a separate DTH for the wikitext surface). [20:24:22] (03PS1) 10Esanders: Only show NWE beta feature if enabled in config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312100 [20:26:35] (03PS1) 10Jforrester: Only register the NWE beta feature if the feature flag is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312102 [20:32:56] 10VisualEditor, 10VisualEditor-MediaWiki: With two edit tabs, 'edit source' link in NWE has an href than loads old wikitext editor (e.g. with middle click/ctrl+click) - https://phabricator.wikimedia.org/T146323#2657396 (10Esanders) [20:34:59] 10VisualEditor, 10VisualEditor-MediaWiki: In the new wikitext editor, be able to smoothly toggle between editors - https://phabricator.wikimedia.org/T142643#2657412 (10Esanders) [20:35:01] 10VisualEditor, 10VisualEditor-MediaWiki: With two edit tabs, 'edit source' link in NWE has an href than loads old wikitext editor (e.g. with middle click/ctrl+click) - https://phabricator.wikimedia.org/T146323#2657411 (10Esanders) [20:59:28] 10VisualEditor, 10VisualEditor-MediaWiki: With two edit tabs, 'edit source' link in NWE has an href than loads old wikitext editor (e.g. with middle click/ctrl+click) - https://phabricator.wikimedia.org/T146323#2657503 (10Jdforrester-WMF) p:05Triage>03High [21:01:32] (03CR) 10Jforrester: [C: 032] Only show NWE beta feature if enabled in config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312100 (owner: 10Esanders) [21:01:42] (03Abandoned) 10Jforrester: Only register the NWE beta feature if the feature flag is set [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312102 (owner: 10Jforrester) [21:17:39] (03Merged) 10jenkins-bot: Only show NWE beta feature if enabled in config [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312100 (owner: 10Esanders) [21:27:54] James_F: Is [[mw:Visual Editor]] basically the Wikimedia Visual Editor Team page, if there was such a thing? [21:28:34] greg-g: Ish. Mostly it's the programme page, but it also has that role. [21:29:39] kaldari: NWE seems to be sorta-kinda working on Beta Cluster. [21:30:56] James_F: better alternative? just [[Editing]]? [21:31:11] (this is for mw:Developers/Maintainers, fwiw) [21:31:13] greg-g: That's for the whole department. What's the context? [21:31:18] ^ :) [21:31:19] Oh. Yeah, just tag Editing. [21:31:32] I put mw:Collaboration for them since that's their team page [21:38:40] greg-g: Yeah. Eventually we'll probably rename the team again, at which point we can call it that. [21:42:16] :) [21:42:38] James_F: to be clear, this list https://www.mediawiki.org/wiki/Editing#Maintained.2C_supported.2C_and_related_editing-related_tools is what the VE team self-identifies as "things we care about", right? [21:43:37] greg-g: Yes, though it might be out-of-date. [21:44:09] sure, after I copy it to mw:dev/maint feel free to update that :) [21:46:02] Is the page going to be protected? [21:46:34] Given that mw:dev/maint has drive-by edits quite frequently from people who decide that other people aren't maintaining things. :-( [21:53:53] I'm watching it actively [21:54:38] greg-g: Mostly I'm not keen on mixing team ownership with individual expertise. Loads of bits of core are 'owned' by Editing but a volunteer or non-WMF staffer does most of the changes in that area, e.g. e-mail or ContentHandler or OCR/DjVu or … [21:55:00] I don't want us to undermine their work. [21:56:06] it won't, I'm not removing anyone [23:02:39] greg-g: Also we should get rid of the templates for that page. :-) [23:02:54] after I'm done, plz :) [23:03:17] and yes, I wanted (initially) to add another column and just got to the point of "eh, ef it, not worth it" :) [23:04:03] greg-g: If only you'd used the visual editor it'd be easy. ;-P [23:04:17] to edit the templates? [23:04:32] (And yes, adding a distinct column between team and individual would be good.) [23:04:42] Hence the order of operations being important. [23:22:45] leg.o argued the opposite. I chose to JFDI for now, we can change later :) [23:24:30] (03PS2) 10TheDJ: MWAceEditorWidget: Configure Ace with its base path [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) [23:24:54] (03CR) 10Jforrester: "We should really move this code into the SyntaxHighlight extension repo some time." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) (owner: 10TheDJ) [23:30:48] (03PS5) 10Jforrester: dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [23:41:38] (03CR) 10Alex Monk: "which of my commits didn't you fully understand?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope)