[00:45:52] 10Cite: Cite RefToolbar - Templates dropdown not displaying - https://phabricator.wikimedia.org/T145787#2640799 (10Agtx) I'm having the same issue, which was resolved when I disabled syntax highlighter. Some kind of interaction between the two gadgets is causing a problem in Chrome. [01:08:15] (03CR) 10Catrope: "I think I was thinking of 818c6e4928cfd69d13251aee38029f384022c1d5 , but in hindsight that one didn't introduce the special treatment of s" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [02:09:10] (03PS1) 10Legoktm: Don't re-implement EditPage::getCopyrightWarning() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312159 (https://phabricator.wikimedia.org/T144364) [02:11:27] greg-g: I guess I need to talk leg.o now ;) [02:54:21] (03CR) 10Esanders: [C: 032] ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [03:01:55] (03Merged) 10jenkins-bot: ve.dm.MWMediaResourceProvider: Use mw.ForeignApi rather than JSONP [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [03:05:02] (03CR) 10Bartosz Dziewoński: "I guess Depends-On doesn't count if you put other stuff after the change-id, because I372e7bdff35400287b3d961da979d6f094d13bd9 is not merg" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309767 (https://phabricator.wikimedia.org/T143279) (owner: 10Bartosz Dziewoński) [03:13:45] James_F, this is more complicated than patching afterPaste - that function doesn't get called because the event has preventDefault [03:15:10] ugh [03:15:18] console.trace() literally just shows where itself was called [03:15:20] useful [03:17:35] Oh, fun. Does it have to be at the end of the WikitextPasteDataTransferHandler or whatever? [03:20:30] looks like it so far [03:21:15] To get it to recognise anything I had to comment ve.ui.dataTransferHandlerFactory.unregister( ve.ui.MWWikitextStringTransferHandler ); at the bottom of modules/ve-mw/ce/ve.ce.MWWikitextSurface.js [03:35:44] Oh, yeah, Ed's got a fix for that. [03:35:47] Err. [03:36:03] Krenair: https://gerrit.wikimedia.org/r/#/c/312096/ merge that. :-) [03:59:33] (03PS1) 10Alex Monk: Strip element IDs from HTML generated when wikitext is pasted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) [04:03:19] (03CR) 10Alex Monk: [C: 032] Only unregister WT string handler in WT handler factory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312096 (https://phabricator.wikimedia.org/T144653) (owner: 10Esanders) [04:03:21] (03CR) 10jenkins-bot: [V: 04-1] Strip element IDs from HTML generated when wikitext is pasted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) (owner: 10Alex Monk) [04:09:19] (03Merged) 10jenkins-bot: Only unregister WT string handler in WT handler factory [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312096 (https://phabricator.wikimedia.org/T144653) (owner: 10Esanders) [04:09:19] ^ yeah someone else will need to think about that one [04:09:28] (03CR) 10Jforrester: [C: 031] dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [04:10:56] (03PS2) 10Alex Monk: Strip element IDs from HTML generated when wikitext is pasted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) [04:14:32] (03CR) 10jenkins-bot: [V: 04-1] Strip element IDs from HTML generated when wikitext is pasted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) (owner: 10Alex Monk) [04:15:44] Kk. [07:21:35] (03PS15) 10Divec: Method to rebase a transaction onto another [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305438 [07:21:47] (03PS21) 10Divec: WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 [07:22:26] (03PS16) 10Divec: WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 [07:22:40] (03PS29) 10Divec: WIP surface synchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [07:22:56] (03PS7) 10Divec: [WIP] sockets [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309720 (owner: 10Catrope) [11:25:14] (03PS8) 10Divec: [WIP] sockets (rebaser) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309720 (owner: 10Catrope) [11:25:33] (03PS30) 10Divec: WIP surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [11:27:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] sockets (rebaser) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309720 (owner: 10Catrope) [11:28:25] (03Abandoned) 10Divec: WIP: Rebaser [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305564 (owner: 10Divec) [11:28:34] (03CR) 10jenkins-bot: [V: 04-1] WIP surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [11:32:46] (03CR) 10Divec: "Merged in code from I068447d8155b0732c08d642357dab07cfca5aa2a ." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309720 (owner: 10Catrope) [12:23:15] 10Cite: Cite RefToolbar - Templates dropdown not displaying - https://phabricator.wikimedia.org/T145787#2658682 (10BrillLyle) @Agtx -- You are brilliant! That was the problem. I posted on the syntax highlighter discussion page as well as updated the RefToolbar discussion page. I love me my syntax highlighter but... [14:10:59] 10Cite, 10SyntaxHighlight: Cite RefToolbar: Templates dropdown not displaying due to SyntaxHighlighter - https://phabricator.wikimedia.org/T145787#2658878 (10Aklapper) [14:14:03] (03PS1) 10Matthias Mullie: Change mid-upload 'cancel' button to 'back' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312253 (https://phabricator.wikimedia.org/T114938) [14:19:22] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Uploading, 06Multimedia, and 2 others: Provide a way during the upload stage for the user to change their mind about what file to upload once they've started it uploading - https://phabricator.wikimedia.org/T114938#2658904 (10matthiasmullie) a:03... [14:34:19] 10Cite: Cite RefToolbar: Templates dropdown not displaying due to SyntaxHighlighter - https://phabricator.wikimedia.org/T145787#2659072 (10Izno) [14:35:45] 10Cite: Cite RefToolbar: Templates dropdown not displaying due to SyntaxHighlighter - https://phabricator.wikimedia.org/T145787#2640799 (10Izno) @Aklapper Based on Agtx's comment, he is probably referring to [[https://www.mediawiki.org/wiki/User:Remember_the_dot/Syntax_highlighter|the syntax highlighter gadget]]... [14:40:52] 10Cite: Cite RefToolbar: Templates dropdown not displaying due to RTD's syntax highlighter gadget - https://phabricator.wikimedia.org/T145787#2659095 (10Izno) [15:32:08] (03CR) 10DLynch: [C: 04-1] "I'm fine with how all this works (and didn't mean to imply that I thought this would break what I'd done, sorry), but: you probably don't " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [15:55:31] (03PS9) 10Divec: [WIP] sockets (rebaser) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309720 (owner: 10Catrope) [15:57:55] (03CR) 10DLynch: [C: 04-1] Test selections without relying on a ve.dm.Surface select event listener (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311238 (https://phabricator.wikimedia.org/T145938) (owner: 10Divec) [16:01:43] (03PS31) 10Divec: WIP surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [16:10:58] (03PS6) 10Jforrester: dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [16:11:32] (03CR) 10Jforrester: [C: 032] "I think that was my fault. Fixed now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [16:19:14] (03Merged) 10jenkins-bot: dm.MWInternalLinkAnnotation: Fix href normalization for special characters [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/311354 (https://phabricator.wikimedia.org/T145978) (owner: 10Catrope) [16:23:22] 10VisualEditor, 10VisualEditor-MediaWiki, 07Beta-Feature, 07Category, 07Epic: Provide a Beta Feature of a modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T141149#2659428 (10Jdforrester-WMF) [16:23:25] 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Enabling NWE breaks wikitext pasting in VE - https://phabricator.wikimedia.org/T144653#2659425 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [16:25:02] (03PS1) 10DLynch: ui.MWLinkAnnotationInspector: skip internal link checking if the value has changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312276 (https://phabricator.wikimedia.org/T146306) [17:17:24] 10VisualEditor, 10MediaWiki-Authentication-and-authorization, 10MobileFrontend, 06Reading-Web-Backlog: SMW triggers "Sessions are disabled for this entry point" - https://phabricator.wikimedia.org/T134562#2659531 (10MBinder_WMF) [17:25:46] (03PS16) 10Divec: Method to rebase a transaction onto another [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305438 [17:28:25] (03PS22) 10Divec: WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 [17:42:23] 10WikiEditor, 06Multimedia, 07Design: "Insert media" dialog offers confusing insert/upload alternative buttons - https://phabricator.wikimedia.org/T135917#2659622 (10Nemo_bis) > figure it out pretty quickly: "Ooops, that dialog says "select a file" and then tries to search my hard drive for images... Yeah, t... [18:08:59] (03PS10) 10Divec: [WIP] sockets (rebaser) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309720 (owner: 10Catrope) [18:09:50] (03PS32) 10Divec: WIP surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [18:12:30] (03CR) 10Bartosz Dziewoński: "Can you do the same for /resources/src/mediawiki/mediawiki.Upload.Dialog.js in MediaWiki core, so that the interfaces are the same? That o" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312253 (https://phabricator.wikimedia.org/T114938) (owner: 10Matthias Mullie) [18:12:41] (03CR) 10Bartosz Dziewoński: [C: 031] Change mid-upload 'cancel' button to 'back' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312253 (https://phabricator.wikimedia.org/T114938) (owner: 10Matthias Mullie) [18:21:06] 10VisualEditor, 10VisualEditor-Links, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): Error when clicking on a link ending with a question mark - https://phabricator.wikimedia.org/T145978#2659840 (10Jdforrester-WMF) 05Open>03Resolved [18:21:09] 10Cite: Cite RefToolbar: Templates dropdown not displaying due to RTD's syntax highlighter gadget - https://phabricator.wikimedia.org/T145787#2659842 (10Aklapper) True, thanks for correcting! [18:27:41] (03CR) 10Divec: "I've switched to more primitive rebasing rules (slightly less conflict avoidance) that cannot cause invalid ve.dm.Document tree structure " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305438 (owner: 10Divec) [18:36:07] (03CR) 10Alex Monk: MWAceEditorWidget: Configure Ace with its base path (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) (owner: 10TheDJ) [19:01:01] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660005 (10Legoktm) Some quick thoughts: The content handler should be responsible for defining (like in the format... [19:14:52] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch) - https://phabricator.wikimedia.org/T146182#2660060 (10Jdforrester-WMF) This first half of this is done, but the swi... [19:14:59] 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2016-10-04_(1.28.0-wmf.21): NWE should let you edit talk pages, templates, and JSON blobs, (but not let you switch) - https://phabricator.wikimedia.org/T146182#2660061 (10Jdforrester-WMF) [19:19:09] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660067 (10Jdforrester-WMF) >>! In T120414#2660005, @Legoktm wrote: > Some quick thoughts: > > The content handler s... [19:24:06] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660075 (10Legoktm) >>! In T120414#2660067, @Jdforrester-WMF wrote: > In a post-MCR world, would the control be on th... [19:31:20] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660101 (10daniel) Basically, I slot, one editor (which is a text box for textual content). The slot name will have t... [19:43:00] (03CR) 10Alex Monk: "James: I was thinking of doing that a few days ago, however it turned out there are a few more callers than I expected:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309288 (https://phabricator.wikimedia.org/T124419) (owner: 10TheDJ) [19:49:55] (03CR) 10Catrope: [C: 032] ui.MWLinkAnnotationInspector: skip internal link checking if the value has changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312276 (https://phabricator.wikimedia.org/T146306) (owner: 10DLynch) [19:56:13] (03Merged) 10jenkins-bot: ui.MWLinkAnnotationInspector: skip internal link checking if the value has changed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312276 (https://phabricator.wikimedia.org/T146306) (owner: 10DLynch) [20:44:31] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References, 10Parsoid: Parsoid DOM spec: Improve Cite representation to support section editing & simpler clients - https://phabricator.wikimedia.org/T146072#2660352 (10ssastry) [21:17:23] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660512 (10Jdforrester-WMF) Theoretical example: On a post-MCR wiki, you click edit on a File page. The slots are f... [21:22:28] 10VisualEditor, 10ProofreadPage, 07Verified, 07Verified-in-Phase0: Cannot open VE on test2, getting error "TypeError: Right-hand side of 'instanceof' is not an object " - https://phabricator.wikimedia.org/T145715#2660521 (10Ryasmeen) [21:25:55] 10VisualEditor, 10ProofreadPage, 07Verified, 07Verified-in-Phase0, 07Verified-in-Phase2: Cannot open VE on test2, getting error "TypeError: Right-hand side of 'instanceof' is not an object " - https://phabricator.wikimedia.org/T145715#2660530 (10Ryasmeen) [21:30:38] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660565 (10Legoktm) Above, I specifically said "content format" instead of "content model". So if we only had a pla... [21:36:53] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660589 (10daniel) Ah, sorry, I missed the format bit. Some non-text content can be edited as text via sieralization... [21:46:52] 10VisualEditor, 10WikiEditor, 10ArchCom-RfC, 10CodeEditor, and 4 others: RFC: MediaWiki should provide a pluggable registry for editor interfaces - https://phabricator.wikimedia.org/T120414#2660671 (10daniel) @Jdforrester-WMF If you have a mediainfo slot, you also have wikibase installed, and you would use... [22:18:29] 10VisualEditor, 15User-JAufrecht: Review Q3 work via Phabricator task reporting - https://phabricator.wikimedia.org/T132967#2660775 (10JAufrecht) 05Open>03Resolved Probably obsolete at this point. [22:58:36] (03CR) 10Krinkle: "fixme!" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311219 (owner: 10Catrope)