[00:30:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 06Multimedia, and 2 others: Unify mw.widgets.CategorySelector and ve.ui.MWCategoryWidget - https://phabricator.wikimedia.org/T147811#2704637 (10Prtksxna) [02:47:18] (03PS1) 10Divec: Optimize batchPush on small lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315196 [02:50:14] (03PS2) 10Divec: Optimize batchPush on small lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315196 [03:34:57] 10VisualEditor, 10VisualEditor-ContentEditable: That annoying cursor bug (external links version) - https://phabricator.wikimedia.org/T147827#2704762 (10Whatamidoing-WMF) [04:21:26] 10VisualEditor, 10OOjs-UI: VisualEditor Icons misaligned - https://phabricator.wikimedia.org/T147794#2703720 (10Esanders) Well I did warn you... [04:25:33] (03CR) 10Esanders: "it's complicated: T147607" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) (owner: 10Alex Monk) [04:30:03] 10VisualEditor, 10Parsoid, 10RESTBase: Restbase IDs should not conflict with other Parsoid IDs - https://phabricator.wikimedia.org/T147607#2704795 (10Esanders) The offending lines in Parsoid: `uid = 'mw' + JSUtils.counterToBase64(docDp.counter);` ... ``` counterToBase64: function(n) { /* jshint bitwise: f... [05:03:38] (03PS1) 10Divec: Apply inserted annotations above background annotation stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) [05:05:34] (03CR) 10jenkins-bot: [V: 04-1] Apply inserted annotations above background annotation stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) (owner: 10Divec) [05:05:36] (03CR) 10Divec: Apply inserted annotations above background annotation stack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) (owner: 10Divec) [05:08:01] (03PS2) 10Divec: Apply inserted annotations above background annotation stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) [05:12:23] (03PS1) 10Divec: ve.Range: Don't fixup invalid arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315199 [05:16:05] (03PS2) 10Divec: ve.Range: Don't fixup invalid arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315199 [05:19:10] (03PS3) 10Divec: ve.Range: Don't fixup invalid arguments [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315199 [05:29:34] 10VisualEditor, 10Parsoid, 10RESTBase: Restbase IDs should not conflict with other Parsoid IDs - https://phabricator.wikimedia.org/T147607#2704819 (10Esanders) My best guess for a regex to match Parsoid IDs at the moment is `/^mw[a-zA-Z0-9\-_]{2,6}$/` This restricts the match to 6 characters so IDs like 'm... [05:49:41] (03PS3) 10Divec: Apply inserted annotations above background annotation stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) [05:56:56] (03PS4) 10Divec: WIP: Apply inserted annotations above background annotation stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) [06:34:47] 10VisualEditor, 10OOjs-UI: VisualEditor Icons misaligned - https://phabricator.wikimedia.org/T147794#2704839 (10Volker_E) @Esanders Yes, you did. I will look into this in the next days. I'm still optimistic to find a solution that satisfies all of us… [09:37:01] 10VisualEditor, 06Community-Liaisons (Oct-Dec-2016): Deliver multilingual October newsletter for the visual editor - https://phabricator.wikimedia.org/T147831#2705065 (10Qgil) [09:38:09] 10VisualEditor, 06Community-Liaisons (Oct-Dec-2016): Deliver multilingual October newsletter for the visual editor - https://phabricator.wikimedia.org/T147831#2704877 (10Qgil) p:05Triage>03Normal [10:18:30] 10VisualEditor, 06Community-Liaisons (Oct-Dec-2016): Deliver multilingual October newsletter for the visual editor - https://phabricator.wikimedia.org/T147831#2705171 (10Elitre) p:05Normal>03High [10:40:41] 10Citoid, 10VisualEditor, 10Wikidata, 03Wikidata-Sprint-2016-08-30: [Task] Handle title language properly as part of citoid support for Wikidata - https://phabricator.wikimedia.org/T141856#2705203 (10Lydia_Pintscher) @Jan_Dittrich can you please add what you discussed with Katie here for the design? And mo... [11:31:06] 10Citoid, 10VisualEditor, 10Wikidata, 03Wikidata-Sprint-2016-08-30: [Task] Handle title language properly as part of citoid support for Wikidata - https://phabricator.wikimedia.org/T141856#2705268 (10Jan_Dittrich) @Lydia_Pintscher: We did not discuss much, I only remarked that two buttons side by side that... [14:25:32] (03Abandoned) 10Divec: WIP POC: fixup Chromium cursoring [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/187889 (owner: 10Divec) [14:50:28] 10VisualEditor, 10VisualEditor-Tables, 07Browser-Support-Firefox, 13Patch-For-Review: In VisualEditor, Ctrl-Tab moves to the next table cell in addition to switching the tab in Firefox - https://phabricator.wikimedia.org/T145074#2705777 (10DLynch) @Amire80: I just tried it in production in firefox-for-mac,... [15:18:12] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-NewWikitextEditor, 05WMF-deploy-2016-10-25_(1.28.0-wmf.23): Help dialog in NWE suggests you can use command sequences - https://phabricator.wikimedia.org/T147810#2705852 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:0... [15:40:23] (03CR) 10DLynch: [C: 032] Optimize batchPush on small lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315196 (owner: 10Divec) [15:42:48] (03Merged) 10jenkins-bot: Optimize batchPush on small lists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315196 (owner: 10Divec) [15:49:18] 10VisualEditor, 10OOjs-UI: VisualEditor Icons misaligned - https://phabricator.wikimedia.org/T147794#2705927 (10Esanders) I'm worried that with the number of layout hacks we already have (and we'll need to add some more to fix this) that this element is going to keep causing us problems as people extend it and... [15:54:09] 10VisualEditor, 10VisualEditor-MediaWiki: Indent/outdent tools don't work in NWE - https://phabricator.wikimedia.org/T147858#2705932 (10Esanders) [15:55:28] (03PS1) 10DLynch: ve.batchPush: add unit test to exercise long-array path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315292 [16:00:33] 10VisualEditor, 10VisualEditor-ContentEditable: Cursoring across focusable nodes has problems in Safari 10 - https://phabricator.wikimedia.org/T147827#2705952 (10Esanders) [16:01:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Enable VE in namespace 103 in RuWP - https://phabricator.wikimedia.org/T147732#2701984 (10Esanders) Just a note: We should enable by canonical name as opposed to numerical ID. [16:24:12] (03CR) 10DLynch: [C: 04-1] "Seems like a helpful shortcut overall. Could you update the cloneFromRange unit test to cover this case as well?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314724 (owner: 10Tchanders) [16:37:40] (03PS10) 10Tchanders: WIP/EXPERIMENTAL Make ve.dm.VisualDiff and ve.ui.DiffElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311173 [16:39:29] (03CR) 10jenkins-bot: [V: 04-1] WIP/EXPERIMENTAL Make ve.dm.VisualDiff and ve.ui.DiffElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/311173 (owner: 10Tchanders) [16:58:25] 10VisualEditor, 10VisualEditor-MediaWiki: Converting multiple lines to a list in NWE should probably remove linebreaks - https://phabricator.wikimedia.org/T147863#2706182 (10Esanders) [17:18:42] (03PS3) 10Jforrester: NWE: Use a different change tag to the visual editor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315194 (https://phabricator.wikimedia.org/T147587) (owner: 10Alex Monk) [17:19:59] (03CR) 10Jforrester: "New wording. Also, let's not use 'newwikitext' in things that are going to stay around for more than a year. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315194 (https://phabricator.wikimedia.org/T147587) (owner: 10Alex Monk) [17:20:05] (03CR) 10Esanders: [C: 032] ve.batchPush: add unit test to exercise long-array path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315292 (owner: 10DLynch) [17:22:41] (03Merged) 10jenkins-bot: ve.batchPush: add unit test to exercise long-array path [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315292 (owner: 10DLynch) [17:25:42] 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikimedia-Site-requests: Enable VE in namespace 103 in RuWP - https://phabricator.wikimedia.org/T147732#2706313 (10Jdforrester-WMF) 05Open>03declined We do not make the visual editor available in talk namespaces, sorry. https://www.mediawiki.org/wiki/Flow#If_yo... [17:45:37] 10VisualEditor, 10MediaWiki-extensions-Score: Use TitleInputWidget in the Score inspector for choosing filenames - https://phabricator.wikimedia.org/T114798#2706457 (10Anomie) [17:45:43] 10VisualEditor, 10VisualEditor-MediaWiki, 10GlobalUserPage, 10MediaWiki-extensions-EducationProgram: VisualEditor redlink detection should obey Title::isAlwaysKnown (so that links to Special pages, EducationProgram pages and GlobalUserPages render correctly) - https://phabricator.wikimedia.org/T72123#2706458... [18:12:52] 10VisualEditor, 10Wikimedia-Site-requests, 07Community-consensus-needed, 13Patch-For-Review, 07User-notice: Enable VisualEditor by default for all users of all remaining non-language variant Wikipedias - https://phabricator.wikimedia.org/T142589#2706617 (10Jdforrester-WMF) Logged-in users done; logged-ou... [19:01:00] 10VisualEditor, 10VisualEditor-MediaWiki: Indent/outdent tools don't work in NWE - https://phabricator.wikimedia.org/T147858#2705932 (10Jdforrester-WMF) Disable them for now? [19:01:44] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Indent/outdent tools don't work in NWE - https://phabricator.wikimedia.org/T147858#2706857 (10Jdforrester-WMF) p:05Triage>03Normal [19:03:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Converting multiple lines to a list in NWE should probably remove linebreaks - https://phabricator.wikimedia.org/T147863#2706893 (10Jdforrester-WMF) p:05Triage>03Low [19:05:04] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Apple-Safari: Cursoring across focusable nodes has problems in Safari 10 - https://phabricator.wikimedia.org/T147827#2706905 (10Jdforrester-WMF) p:05Triage>03Normal [19:05:41] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 06Multimedia, and 3 others: Unify mw.widgets.CategorySelector and ve.ui.MWCategoryWidget - https://phabricator.wikimedia.org/T147811#2706910 (10Jdforrester-WMF) p:05Triage>03Low [19:06:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: NWE's 'Show preview' doesn't load in new modules based on added content, e.g. gallery/maps - https://phabricator.wikimedia.org/T147702#2706918 (10Jdforrester-WMF) p:05Triage>03Normal [19:07:41] (03PS12) 10Esanders: Section editing in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) [19:07:42] 10VisualEditor, 06Community-Liaisons (Oct-Dec-2016): Deliver multilingual October newsletter for the visual editor - https://phabricator.wikimedia.org/T147831#2706924 (10Elitre) Now at https://meta.wikimedia.org/wiki/VisualEditor/Newsletter/2016/October [19:08:04] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki: Don't lose focus when opening on a new (or otherwise blank) page, as re-selecting the cursor position might be hard for new users - https://phabricator.wikimedia.org/T147764#2706926 (10Jdforrester-WMF) p:05Triage>03Low [19:08:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Round-trip transformations applied in NWE end up adding - https://phabricator.wikimedia.org/T147767#2706936 (10Jdforrester-WMF) p:05Triage>03High [19:10:21] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10MediaWiki-General-or-Unknown, 07Browser-Support-Google-Chrome, 07JavaScript: `( new mw.Title('ß') ).getPrefixedText()` does not round-trip in Chromium - https://phabricator.wikimedia.org/T147646#2706941 (10Jdforrester-WMF) p:05Triage>03Normal [19:12:36] 10VisualEditor, 10OOjs-UI: VisualEditor Icons misaligned - https://phabricator.wikimedia.org/T147794#2706961 (10Jdforrester-WMF) p:05Triage>03High [19:16:50] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Harv style citations based on T95702 solution - https://phabricator.wikimedia.org/T144695#2706986 (10Jdforrester-WMF) [19:16:59] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Harv style citations based on T95702 solution - https://phabricator.wikimedia.org/T144695#2607593 (10Jdforrester-WMF) p:05Normal>03Lowest [19:17:22] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Harv style citations based on T95702 solution - https://phabricator.wikimedia.org/T144695#2607593 (10Jdforrester-WMF) [19:18:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10Math, 07Performance: Loading Formula dialog code for the first time in each session (delayed loading) is slow - https://phabricator.wikimedia.org/T145254#2624773 (10Jdforrester-WMF) p:05Triage>03Low [19:19:26] 10VisualEditor, 10MediaWiki-extensions-GuidedTour: Update VE tours for Single Edit Tab - https://phabricator.wikimedia.org/T142447#2706997 (10Jdforrester-WMF) p:05Triage>03Normal [19:19:59] 10VisualEditor, 10MediaWiki-extensions-GuidedTour: "Switch to VisualEditor" flow conflicts with onboarding flow - https://phabricator.wikimedia.org/T138124#2707000 (10Jdforrester-WMF) p:05Triage>03Low [19:28:52] (03CR) 10Esanders: "Added fix for WT -> VE switch (prompts to discard changes). We need to fix URL handling and updating, but that can be done in a later comm" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [19:38:48] 10VisualEditor, 07Technical-Debt: ve.ce.Surface#afterPaste shouldn't have code to remove RESTBase IDs - https://phabricator.wikimedia.org/T126044#2707044 (10Esanders) [19:47:34] (03PS1) 10Esanders: Factor out RESTBase ID regular expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315337 (https://phabricator.wikimedia.org/T126044) [19:48:54] (03PS1) 10Esanders: Define RESTBase ID pattern in platform and fix slightly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315339 (https://phabricator.wikimedia.org/T147607) [19:49:31] (03CR) 10jenkins-bot: [V: 04-1] Factor out RESTBase ID regular expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315337 (https://phabricator.wikimedia.org/T126044) (owner: 10Esanders) [19:51:01] (03PS4) 10Esanders: Strip element IDs from HTML generated when wikitext is pasted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) (owner: 10Alex Monk) [19:52:47] (03CR) 10Esanders: "You can now use ve.init.platform.getMetadataIdRegExp() from the parent commit (correct usage requires you to check it isn't null first)." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) (owner: 10Alex Monk) [19:53:48] (03CR) 10jenkins-bot: [V: 04-1] Define RESTBase ID pattern in platform and fix slightly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315339 (https://phabricator.wikimedia.org/T147607) (owner: 10Esanders) [19:54:27] 10VisualEditor, 10OOjs-UI: VisualEditor Icons misaligned - https://phabricator.wikimedia.org/T147794#2707069 (10matmarex) It is actually not a new issue, 0.17.8 (before the `` changes) also has it. It's probably been broken like this for a while, but I checked a random old version (0.13.0) and it look... [19:55:48] (03CR) 10jenkins-bot: [V: 04-1] Strip element IDs from HTML generated when wikitext is pasted [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/312170 (https://phabricator.wikimedia.org/T146054) (owner: 10Alex Monk) [21:02:12] (03PS2) 10Esanders: Factor out RESTBase ID regular expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315337 (https://phabricator.wikimedia.org/T126044) [21:03:02] (03PS1) 10Esanders: Use hasMatchingAncestor for indetation command [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315415 [21:05:08] 10VisualEditor, 10VisualEditor-MediaWiki: VE loads on "Edit source" pages on wmf.22 like the MediaWiki namespace - https://phabricator.wikimedia.org/T147890#2707303 (10Jdforrester-WMF) [21:07:05] 10VisualEditor, 10VisualEditor-MediaWiki: VE in non-NWE mode loads on "Edit source" pages on wmf.22 like the Template and MediaWiki namespaces - https://phabricator.wikimedia.org/T147890#2707324 (10Jdforrester-WMF) [21:08:34] 10VisualEditor, 10VisualEditor-MediaWiki: VE in non-NWE mode loads on "Edit source" pages on wmf.22 like the Template and MediaWiki namespaces - https://phabricator.wikimedia.org/T147890#2707303 (10Jdforrester-WMF) [21:15:06] 10VisualEditor, 10Parsoid, 10RESTBase, 13Patch-For-Review: Restbase IDs should not conflict with other Parsoid IDs - https://phabricator.wikimedia.org/T147607#2707381 (10ssastry) >>! In T147607#2704819, @Esanders wrote: > My best guess for a regex to match Parsoid IDs at the moment is > > `/^mw[a-zA-Z0-9\... [21:19:14] (03PS1) 10Esanders: Follow-up I9547dfd: Only enable VE tabs if VE is available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315420 (https://phabricator.wikimedia.org/T147890) [21:19:51] (03PS2) 10Esanders: Follow-up I9547dfd: Only enable VE tabs if VE is available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315420 (https://phabricator.wikimedia.org/T147890) [21:23:54] (03CR) 10Alex Monk: [C: 032] Follow-up I9547dfd: Only enable VE tabs if VE is available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315420 (https://phabricator.wikimedia.org/T147890) (owner: 10Esanders) [21:24:09] edsanders, James_F: I knew that patch was too easy to be correct... [21:24:27] Krenair: Ed and I are discussing renaming some of the variables to make it less confusing. [21:24:50] Krenair: E.g. "pageCanLoadVE" actually is "pageCanLoadVEOrNWESoDoSomethingToIt". [21:24:57] I think a bit more than that is necessary to make our initialisation code less confusing :) [21:25:19] So s/pageCanLoadVE/shouldAlterPage/g [21:25:21] Etc. [21:27:36] And in the wikitext editor, are we showing the switcher based on pageCanLoadVE? [21:29:27] Ah, no, we use init.isVisualAvailable. [21:32:37] (03Merged) 10jenkins-bot: Follow-up I9547dfd: Only enable VE tabs if VE is available [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315420 (https://phabricator.wikimedia.org/T147890) (owner: 10Esanders) [21:33:15] (03PS1) 10Jforrester: Follow-up I9547dfd: Only enable VE tabs if VE is available [extensions/VisualEditor] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/315424 (https://phabricator.wikimedia.org/T147890) [21:50:29] 10VisualEditor, 10Graphs, 03Interactive-Sprint: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2707541 (10MaxSem) [21:51:27] (03PS1) 10Jforrester: mw.LinkCache: Links aren't missing if they're known [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315432 (https://phabricator.wikimedia.org/T72123) [21:51:29] (03PS1) 10Jforrester: Update VE core submodule to master (fb43a0a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315433 [22:02:00] (03PS2) 10Esanders: Define RESTBase ID pattern in platform and fix slightly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315339 (https://phabricator.wikimedia.org/T147607) [22:02:44] (03PS2) 10Esanders: IndentationCommand: Use hasMatchingAncestor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315415 [22:02:58] (03PS3) 10Esanders: Factor out RESTBase ID regular expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315337 (https://phabricator.wikimedia.org/T126044) [22:03:05] (03CR) 10jenkins-bot: [V: 04-1] Define RESTBase ID pattern in platform and fix slightly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315339 (https://phabricator.wikimedia.org/T147607) (owner: 10Esanders) [22:04:48] (03CR) 10Jforrester: [C: 032] IndentationCommand: Use hasMatchingAncestor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315415 (owner: 10Esanders) [22:05:42] (03PS3) 10Esanders: Define RESTBase ID pattern in platform and fix slightly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315339 (https://phabricator.wikimedia.org/T147607) [22:06:06] (03PS3) 10Esanders: IndentationCommand: Use hasMatchingAncestor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315415 (https://phabricator.wikimedia.org/T147858) [22:06:15] (03CR) 10Jforrester: [C: 032] IndentationCommand: Use hasMatchingAncestor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315415 (https://phabricator.wikimedia.org/T147858) (owner: 10Esanders) [22:09:25] (03Merged) 10jenkins-bot: IndentationCommand: Use hasMatchingAncestor [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315415 (https://phabricator.wikimedia.org/T147858) (owner: 10Esanders) [22:09:50] (03CR) 10Jforrester: [C: 032] Factor out RESTBase ID regular expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315337 (https://phabricator.wikimedia.org/T126044) (owner: 10Esanders) [22:10:47] (03Abandoned) 10Jforrester: WIP/EXPERIMENTAL Reconcile.js modified to run on dm.DocumentNode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303502 (owner: 10Esanders) [22:11:12] (03CR) 10jenkins-bot: [V: 04-1] Define RESTBase ID pattern in platform and fix slightly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315339 (https://phabricator.wikimedia.org/T147607) (owner: 10Esanders) [22:12:45] (03Merged) 10jenkins-bot: Factor out RESTBase ID regular expression [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315337 (https://phabricator.wikimedia.org/T126044) (owner: 10Esanders) [22:13:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-10-25_(1.28.0-wmf.23): Indent/outdent tools don't work in NWE - https://phabricator.wikimedia.org/T147858#2707578 (10Jdforrester-WMF) 05Open>03Resolved [22:18:34] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-MediaWiki, 07Technical-Debt, 05WMF-deploy-2016-10-11_(1.28.0-wmf.22): ve.ce.Surface#afterPaste shouldn't have code to remove RESTBase IDs - https://phabricator.wikimedia.org/T126044#2707599 (10Jdforrester-WMF) 05Open>03Resolved a:03Esand... [22:21:51] 10VisualEditor: VE breaks Col-begin - https://phabricator.wikimedia.org/T142823#2547342 (10Jdforrester-WMF) In discussion with @Whatamidoing-WMF, this'd best be done with proper multi-columns support, so I'm merging into that. [22:22:00] 10VisualEditor: VE breaks Col-begin - https://phabricator.wikimedia.org/T142823#2707629 (10Jdforrester-WMF) [22:27:12] 10VisualEditor, 10Parsoid, 10RESTBase, 13Patch-For-Review: Restbase IDs should not conflict with other Parsoid IDs - https://phabricator.wikimedia.org/T147607#2698174 (10GWicke) The issue you are trying to avoid is clashes between ids in new, pasted content & existing content, as well as the false data-par... [22:35:23] (03CR) 10Alex Monk: [C: 031] "PS3 changes are fine" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315194 (https://phabricator.wikimedia.org/T147587) (owner: 10Alex Monk) [22:51:22] 10VisualEditor, 10Graphs, 03Interactive-Sprint: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2707682 (10MaxSem) a:03MaxSem [22:51:44] (03CR) 10Esanders: [C: 04-1] NWE: Use a different change tag to the visual editor (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315194 (https://phabricator.wikimedia.org/T147587) (owner: 10Alex Monk) [23:11:46] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (fb43a0a) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315433 (owner: 10Jforrester) [23:12:42] (03PS13) 10Esanders: Section editing in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) [23:12:44] (03CR) 10Jforrester: "(Oh no you didn't!)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [23:12:53] (03PS14) 10Esanders: Section editing in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) [23:13:24] (03CR) 10Esanders: "PS13 contains the fix." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [23:14:38] (03CR) 10Jforrester: "Are we leaving this to Roan to merge?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305438 (owner: 10Divec) [23:25:08] (03PS1) 10Tchanders: WIP Update gallery dialog actions to reflect presence of changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315449 (https://phabricator.wikimedia.org/T62311) [23:26:17] (03CR) 10Jforrester: [C: 032] Section editing in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [23:26:54] (03CR) 10Alex Monk: [C: 04-2] "Doesn't address my -1" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [23:29:06] (03CR) 10jenkins-bot: [V: 04-1] WIP Update gallery dialog actions to reflect presence of changes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315449 (https://phabricator.wikimedia.org/T62311) (owner: 10Tchanders) [23:34:47] (03CR) 10Alex Monk: "specifically PS11 DesktopArticleTarget.init.js l861" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/308888 (https://phabricator.wikimedia.org/T144654) (owner: 10Esanders) [23:40:57] (03CR) 10EBernhardson: [C: 032] Follow-up I9547dfd: Only enable VE tabs if VE is available [extensions/VisualEditor] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/315424 (https://phabricator.wikimedia.org/T147890) (owner: 10Jforrester) [23:45:45] (03CR) 10Legoktm: "Due to T104604#2518083, should we remove the checking of links before load?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/315432 (https://phabricator.wikimedia.org/T72123) (owner: 10Jforrester) [23:47:21] (03Merged) 10jenkins-bot: Follow-up I9547dfd: Only enable VE tabs if VE is available [extensions/VisualEditor] (wmf/1.28.0-wmf.22) - 10https://gerrit.wikimedia.org/r/315424 (https://phabricator.wikimedia.org/T147890) (owner: 10Jforrester) [23:57:47] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 05WMF-deploy-2016-10-25_(1.28.0-wmf.23): VE in non-NWE mode loads on "Edit source" pages on wmf.22 like the Template and MediaWiki namespaces - https://phabricator.wikimedia.org/T147890#2707816 (10AlexMonk-WMF) 05Open>03Resolved a:03Esanders