[07:00:21] 10VisualEditor, 06Community-Liaisons (Oct-Dec-2016): Update translators and wikis lists for Editing newsletter - https://phabricator.wikimedia.org/T148293#2724561 (10Qgil) [08:08:53] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10MediaWiki-extensions-Disambiguator: When link suggestions contain a disambiguation page, also show pages linked on that page - https://phabricator.wikimedia.org/T145622#2724591 (10Schnark) >>! In T145622#2689936, @Jdforrester-WMF wrote: > We don't know which... [13:53:05] hmm, seems that entire mapbox lib is loaded unconditionally when you open VE [13:53:18] that can't be good for performance... [13:56:32] > $1.mapbox [13:56:33] < {requiredBy: ["ext.kartographer.settings", "ext.kartographer.lib.topojson"], requires: []} [13:57:08] > $1["ext.kartographer.settings"] [13:57:08] < {requiredBy: ["ext.kartographer.box"], requires: ["mapbox"]} [13:57:30] > $1["ext.kartographer.box"] [13:57:31] < {requiredBy: ["ext.kartographer.visualEditor"], requires: Array} [14:00:10] 10VisualEditor, 10Kartographer: Opening VisualEditor on en.wp always loads Mapbox - https://phabricator.wikimedia.org/T148511#2725171 (10TheDJ) [14:31:24] 10VisualEditor, 10VisualEditor-EditingTools, 10CodeEditor, 10SyntaxHighlight: VE Code block inspector confuses pygments languages and ACE language modes - https://phabricator.wikimedia.org/T148515#2725282 (10TheDJ) [15:04:40] 10VisualEditor, 10VisualEditor-EditingTools, 10CodeEditor: ve.ui.MWAceEditorWidget breaks autoloading of text modes - https://phabricator.wikimedia.org/T148518#2725377 (10TheDJ) [15:41:00] (03PS1) 10TheDJ: Enable conditional loading of ACE language modes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/316572 (https://phabricator.wikimedia.org/T148518) [15:45:32] 10VisualEditor, 10VisualEditor-EditingTools, 10CodeEditor, 13Patch-For-Review: ve.ui.MWAceEditorWidget breaks autoloading of text modes - https://phabricator.wikimedia.org/T148518#2725696 (10TheDJ) [16:46:39] (03CR) 10Esanders: [C: 04-1] "If I select php5 it looks up php5.json which doesn't exist and fails." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/316572 (https://phabricator.wikimedia.org/T148518) (owner: 10TheDJ) [17:15:38] 10VisualEditor, 10VisualEditor-MediaWiki, 07User-notice, 05WMF-deploy-2016-10-11_(1.28.0-wmf.22): Show some of HTML comments' text as an inline labels, like with 'invisible' templates' name - https://phabricator.wikimedia.org/T147089#2726132 (10DLynch) If we see a rash of deleted comments in edits on comme... [17:17:35] (03PS3) 10DLynch: LinkAnnotationInspector: add a "label" field [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303956 (https://phabricator.wikimedia.org/T55973) [17:32:23] 10VisualEditor, 10VisualEditor-MediaWiki: Double clicking on a image in results of the gallery dialog results in the image being added twice - https://phabricator.wikimedia.org/T148558#2726178 (10Esanders) [18:05:16] 10VisualEditor: Icons doesn't appear on function buttons - https://phabricator.wikimedia.org/T148564#2726341 (10utro5750) [18:55:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-General-or-Unknown, 06Multimedia, and 3 others: Unify mw.widgets.CategorySelector and ve.ui.MWCategoryWidget - https://phabricator.wikimedia.org/T147811#2726578 (10Prtksxna) I spoke with @Esanders and @matmarex about this and we feel that it'll be bette... [19:00:54] anyone seen this before ? [19:00:55] ==> default: Error: /usr/bin/npm install --no-bin-links returned 1 instead of one of [0] [19:00:58] ==> default: Error: /Stage[main]/Changeprop/Service::Node[changeprop]/Npm::Install[/vagrant/srv/changeprop]/Exec[/vagrant/srv/changeprop_npm_install]/returns: change from notrun to 0 failed: /usr/bin/npm install --no-bin-links returned 1 instead of one of [0] [19:01:23] been trying to install VE into vagrant for about 1,5 hours now :) [19:02:25] ah it's a make error [19:02:26] ./deps/librdkafka/src/rdkafka_sasl.c:35:23: fatal error: sasl/sasl.h [19:02:37] nothing to do with VE [19:03:06] that's either changeprop or kafka-related [19:04:33] if i do vagrant roles enable visualeditor, than as far as i'm concerned, its VE :) [19:05:18] sudo apt-get install libsasl2-dev [19:05:25] thedj: only the services folks seem to actually maintain the puppet code for all the nodejs stuff in mw-vagrant [19:05:41] and it gets more twisted all the time :/ [19:05:43] and we will see in another half hour i guess [19:10:16] right, so it's kafka it seems from the logs [19:10:39] checking for libsasl2 (by compile)... failed (disable) [19:10:45] checking for libsasl (by compile)... failed (disable) [19:11:01] Configuration summary: [19:11:02] ENABLE_SASL y [19:11:08] [19:11:11] thedj, vagrant is not part of VE. [19:25:03] thedj: it sounds like Marko added EventBus and ChangeProp support to Vagrant; could you create a task describing the task you ran into, and cc #services and @mobrovac? [19:25:16] err, issue you ran into [19:29:54] gwicke: just did. will add those subscribers [19:30:24] thedj: thank you! [20:36:36] gwicke: [20:37:00] "message":"Use of const in strict mode." [20:37:02] /vagrant/srv/restbase/node_modules/hyperswitch/index.js:3:18 [20:37:10] ever seen that before ? [20:37:58] thedj: is this using node 4.x? [20:38:30] node 0.10 wouldn't like const, but in prod (and afaik also vagrant) we are on 4.x [20:39:07] node -v [20:39:07] v0.10.25 [20:39:33] hmm, that won't work [20:39:49] I was pretty sure we had upgraded node in vagrant as well [20:40:12] bummer [20:40:16] i do note that something downgraded it when i provisioned visualeditor and all its dependencies [20:41:17] I'm afraid I'm pretty useless with vagrant as I haven't used it myself [20:41:45] thedj: it should force back up if you update to the latest mw-vagrant puppet code. mobrovac put in a patch to fix that yesterday. [20:41:53] Marko is pretty much single-handedly maintaining all the services stuff in vagrant [20:42:17] bd808: hm, ok, lets see about that then... [20:43:02] we are/were using a PPA to get newer node and then some change in the prod apt repos made it flip out and use the older package from upstream. It should be pinned to prefer the PPA now. [20:43:40] I guess vagrant is still on trusty? [20:43:55] yeah. we haven't started moving to jessie yet [20:44:19] there's a ticket for it but no time from me yet and no patches from others either :/ [20:44:19] nod [20:44:40] vagrant is pretty much the only way for me to test VE stuff really. [20:44:57] installing all that stuff by hand is no party either. :) [20:45:21] also why i don't contribute to VE in general though. [20:45:37] 4,5 hours and counting now to setup. [20:45:57] yeah, we haven't done the best job at creating a nice, up to date dev environment recently [20:46:16] it's a big task to modernize all this [20:46:34] the problem is really that all this components are fun and all if you work on isolated features/bugs. [20:47:08] but if you work on 'something does this in this and this Wikipedia context', then you basically need everything after all, with all it's complexities :) [20:47:21] ops it working on kubernetes & yuvi was planning to pick up mediawiki-containers in that context [20:47:50] we also want to make that happen, just need more hours in the day [20:48:30] for now, vagrant is still the best we have [20:52:50] 10VisualEditor, 06Discovery, 10Kartographer, 06Maps: Add a center point (or crosshairs) to interactive maps - https://phabricator.wikimedia.org/T147514#2727005 (10JGirault) [20:57:13] (03PS1) 10Catrope: Follow-up e3192e2d3: property fix layout thrashing in updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/316703 [20:57:39] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Tools can get marked as enabled/disabled incorrectly in NWE - https://phabricator.wikimedia.org/T144323#2596192 (10Esanders) It's possible we may not want to do all of these things for performance reasons. In VE we can jus... [20:58:48] (03CR) 10jenkins-bot: [V: 04-1] Follow-up e3192e2d3: property fix layout thrashing in updateInvisibleIcon [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/316703 (owner: 10Catrope) [22:11:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Tools can get marked as enabled/disabled incorrectly in NWE - https://phabricator.wikimedia.org/T144323#2727241 (10Esanders) Also it may not make as much sense as you can't always remove annotations from your selection, so... [22:34:44] (03CR) 10TheDJ: "@Esanders: Yes. specifically:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/316572 (https://phabricator.wikimedia.org/T148518) (owner: 10TheDJ) [22:37:05] 10VisualEditor, 10Kartographer, 07Performance: Opening VisualEditor on en.wp always loads Mapbox - https://phabricator.wikimedia.org/T148511#2727292 (10Aklapper) [22:59:08] 10VisualEditor, 06Discovery, 10Kartographer, 06Maps, and 2 others: Opening VisualEditor on en.wp always loads Mapbox - https://phabricator.wikimedia.org/T148511#2727327 (10Yurik) [23:01:34] 10VisualEditor, 06Community-Liaisons: Future of the visual editor newsletter - https://phabricator.wikimedia.org/T139305#2727346 (10Elitre) [23:09:16] (03PS2) 10TheDJ: Enable conditional loading of ACE language modes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/316572 (https://phabricator.wikimedia.org/T148518) [23:10:43] (03CR) 10TheDJ: "Now with language mode validation to avoid 404 requests." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/316572 (https://phabricator.wikimedia.org/T148518) (owner: 10TheDJ) [23:14:13] (03CR) 10jenkins-bot: [V: 04-1] Enable conditional loading of ACE language modes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/316572 (https://phabricator.wikimedia.org/T148518) (owner: 10TheDJ)