[00:03:59] (03CR) 10Divec: [C: 032] Fix typo in ve.dm.LinearSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317724 (owner: 10Esanders) [00:06:32] (03Merged) 10jenkins-bot: Fix typo in ve.dm.LinearSelection [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317724 (owner: 10Esanders) [00:11:01] (03PS2) 10Divec: Human-readable transaction summary [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317094 [00:11:22] (03PS2) 10Divec: ve.dm.Transaction: add 'author' field [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317373 [00:12:05] (03PS4) 10Divec: Fix translateRange bug that expands selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 [00:14:43] (03CR) 10jenkins-bot: [V: 04-1] Fix translateRange bug that expands selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 (owner: 10Divec) [00:15:12] (03CR) 10Divec: Fix translateRange bug that expands selections (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 (owner: 10Divec) [00:15:37] (03PS5) 10Divec: Fix translateRange bug that expands selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 [00:18:03] (03CR) 10jenkins-bot: [V: 04-1] Fix translateRange bug that expands selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 (owner: 10Divec) [00:29:32] (03PS6) 10Divec: Fix translateRange bug that expands selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 [00:29:33] (03CR) 10jenkins-bot: [V: 04-1] Fix translateRange bug that expands selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 (owner: 10Divec) [00:32:20] (03PS7) 10Divec: Fix translateRange bug that expands selections [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 [01:55:30] (03PS26) 10Divec: WIP: ve.dm.Change class with rebase operations [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 [02:12:33] (03PS14) 10Divec: [WIP] sockets (rebaser) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309720 (owner: 10Catrope) [02:12:55] (03PS36) 10Divec: WIP surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [02:41:03] (03PS6) 10Divec: Apply inserted annotations above background annotation stack [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) [02:42:37] (03CR) 10Divec: Apply inserted annotations above background annotation stack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) (owner: 10Divec) [04:00:23] 10VisualEditor, 07Browser-Support-Internet-Explorer: QuotaExceededError while editing with VE on IE11 - https://phabricator.wikimedia.org/T148858#2734960 (10Esanders) That sounds like ResourceLoader, as VE doesn't really use local storage. [04:02:52] 10VisualEditor, 10MediaWiki-ResourceLoader, 07Browser-Support-Internet-Explorer: QuotaExceededError while editing with VE on IE11 - https://phabricator.wikimedia.org/T148858#2741029 (10Esanders) [08:27:53] 10Citoid, 10VisualEditor, 10ProveIt-Gadget, 10Wikidata: Wikidata integration - https://phabricator.wikimedia.org/T148928#2741136 (10Mvolz) [08:28:08] 10Citoid, 10VisualEditor, 10ProveIt-Gadget, 10Wikidata: Wikidata integration - https://phabricator.wikimedia.org/T148928#2741138 (10Mvolz) [08:30:19] 10Citoid, 10VisualEditor, 10ProveIt-Gadget, 10Wikidata: Wikidata integration for proveit gadget - https://phabricator.wikimedia.org/T148928#2741141 (10Mvolz) [08:49:25] 10Citoid, 10VisualEditor, 10ProveIt-Gadget, 10Wikidata: Wikidata integration for proveit gadget - https://phabricator.wikimedia.org/T148928#2736847 (10Mvolz) You might be interested in this task, which is about adding support in citoid for wikidata: T131661 It faces a lot of the same challenges, although... [08:58:50] (03PS1) 10Hashar: .gitreview: swapping defaultbranch for track [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317779 (https://phabricator.wikimedia.org/T146293) [09:00:56] (03CR) 10Hashar: [C: 032] .gitreview: swapping defaultbranch for track [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317779 (https://phabricator.wikimedia.org/T146293) (owner: 10Hashar) [09:08:07] 10Citoid, 10VisualEditor, 10WikiCite, 10Wikidata, 07Story: [Story] Support for citoid in Wikidata - https://phabricator.wikimedia.org/T131661#2741229 (10Mvolz) >>! In T131661#2515755, @BrillLyle wrote: > Curious if it would be possible to have whatever is currently working in Wiki Markup (the magnifier/l... [09:18:05] (03Merged) 10jenkins-bot: .gitreview: swapping defaultbranch for track [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317779 (https://phabricator.wikimedia.org/T146293) (owner: 10Hashar) [12:58:46] 10VisualEditor, 10MediaWiki-ResourceLoader, 07Browser-Support-Internet-Explorer: QuotaExceededError while editing with VE on IE11 - https://phabricator.wikimedia.org/T148858#2734960 (10Gilles) This message is coming from mw.track. The error is being caught and is simply reported. It's not the reason why VE c... [12:59:39] 10VisualEditor, 07Browser-Support-Internet-Explorer: VE won't start on specific article on IE11 - https://phabricator.wikimedia.org/T148858#2741567 (10Gilles) [13:45:32] (03PS2) 10Esanders: Always serve quick-access-characters in content language [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317663 (https://phabricator.wikimedia.org/T149051) [13:46:04] (03CR) 10Alex Monk: [C: 032] Always serve quick-access-characters in content language [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317663 (https://phabricator.wikimedia.org/T149051) (owner: 10Esanders) [13:54:44] (03Merged) 10jenkins-bot: Always serve quick-access-characters in content language [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317663 (https://phabricator.wikimedia.org/T149051) (owner: 10Esanders) [13:57:53] (03CR) 10Alex Monk: Create init.isWikitextAvailable and add page content check (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317667 (https://phabricator.wikimedia.org/T149007) (owner: 10Esanders) [14:15:47] 10VisualEditor, 07Browser-Support-Internet-Explorer: VE won't start on specific article on IE11 - https://phabricator.wikimedia.org/T148858#2734960 (10TheDJ) I get two errors in IE11: 1: there is a dom ready issue with 'archive links', which is enabled by default and triggers on page ready. This seems to block... [17:23:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Links to ?veaction=editsource should redirect to old editor is NWE is not available for any reason - https://phabricator.wikimedia.org/T149101#2742140 (10Esanders) [17:23:45] (03CR) 10Esanders: Create init.isWikitextAvailable and add page content check (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317667 (https://phabricator.wikimedia.org/T149007) (owner: 10Esanders) [17:55:17] (03CR) 10Alex Monk: Create init.isWikitextAvailable and add page content check (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317667 (https://phabricator.wikimedia.org/T149007) (owner: 10Esanders) [18:46:50] 10Citoid, 10VisualEditor, 10ProveIt-Gadget: Add Citoid support - https://phabricator.wikimedia.org/T148226#2742471 (10Iniquity) [18:49:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10ProveIt-Gadget: Add VisualEditor and NewTextEditor support - https://phabricator.wikimedia.org/T148870#2742475 (10Iniquity) [18:50:07] 10VisualEditor, 10ProveIt-Gadget: Add VisualEditor and NewTextEditor support - https://phabricator.wikimedia.org/T148870#2735329 (10AlexMonk-WMF) [20:05:19] (03CR) 10Esanders: Create init.isWikitextAvailable and add page content check (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317667 (https://phabricator.wikimedia.org/T149007) (owner: 10Esanders) [20:08:31] (03CR) 10Esanders: Apply inserted annotations above background annotation stack (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315198 (https://phabricator.wikimedia.org/T142245) (owner: 10Divec) [20:11:39] (03CR) 10Esanders: Fix translateRange bug that expands selections (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317330 (owner: 10Divec) [20:16:30] (03CR) 10Esanders: "This should probably be a utility function that loads in debug mode only." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317094 (owner: 10Divec) [20:20:50] (03PS1) 10Esanders: Make ArticleTargetLoader dependent on user.options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317876 [20:20:58] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: mw.user.options isn't populated when ArticleTargetLoader runs, breaking NWE - https://phabricator.wikimedia.org/T148311#2742694 (10Esanders) That works, thanks. [20:21:16] (03PS2) 10Esanders: Make ArticleTargetLoader dependent on user.options [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317876 (https://phabricator.wikimedia.org/T148311) [20:51:03] 10VisualEditor, 10VisualEditor-MediaWiki: Come up with a (better) placeholder message for new pages - https://phabricator.wikimedia.org/T149120#2742803 (10Esanders) [20:59:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: Enabling WTE while having JavaScript turned off might break editing due to https://gerrit.wikimedia.org/r/#/c/312710/ ? - https://phabricator.wikimedia.org/T148077#2714214 (10Esanders) Should we just be doing all the URL r... [21:06:12] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 05WMF-deploy-2016-11-01_(1.29.0-wmf.1): Local wiki's "often used" special characters don't show if user has different UI language set (visualeditor-quick-access-characters.json) - https://phabricator.wikimedia.org/T149051#2742879 (10AlexMonk-WMF... [21:06:24] 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2016-11-01_(1.29.0-wmf.1): Local wiki's "often used" special characters don't show if user has different UI language set (visualeditor-quick-access-characters.json) - https://phabricator.wikimedia.org/T149051#2740278 (10AlexMonk-WMF) [21:12:56] edsanders, why do I feel like we've had a new page placeholder before... [21:13:41] 10VisualEditor: Icons doesn't appear on function buttons - https://phabricator.wikimedia.org/T148564#2726341 (10Esanders) We aren't having this problem on any of our deployments. Have you run `composer update` after upgrading? [21:14:57] 10VisualEditor: Icons doesn't appear on function buttons - https://phabricator.wikimedia.org/T148564#2742925 (10Esanders) 05Open>03Invalid Closing as invalid - but feel free to continue to ask for help setting up your MW/VE environment. [21:15:22] Krenair: James set it to use the red link new page message [21:15:34] but that is way too long, and has formatting [21:15:41] so I reverted [21:22:03] 10VisualEditor: Enabling "rich content" editor for template fields - https://phabricator.wikimedia.org/T148329#2720260 (10Esanders) Yes - this has been in our pipeline for a long time, but it is blocked on support from Parsoid. [22:33:44] (03PS1) 10Esanders: Fix toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317997 [22:38:30] (03CR) 10jenkins-bot: [V: 04-1] Fix toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317997 (owner: 10Esanders) [22:52:24] (03PS1) 10Esanders: Fix edit source links for NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318006 [22:52:26] (03PS1) 10Esanders: Fix arguments passed to requestPageData when switching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318007 [22:52:59] (03PS2) 10Esanders: Fix arguments passed to requestPageData when switching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318007 [22:56:40] (03PS2) 10Esanders: Fix toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317997 [22:58:51] (03PS1) 10Esanders: CSS styleguide fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318008 [23:38:45] (03CR) 10Jforrester: [C: 04-1] "Should crush the SVG. Also V-1?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317463 (owner: 10Esanders) [23:42:16] (03PS3) 10Esanders: Apply platform language to SA target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317464 [23:42:18] (03PS3) 10Esanders: Suggested fixes to demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317463 [23:43:18] (03CR) 10jenkins-bot: [V: 04-1] Apply platform language to SA target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317464 (owner: 10Esanders) [23:44:04] (03CR) 10jenkins-bot: [V: 04-1] Suggested fixes to demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/317463 (owner: 10Esanders) [23:55:03] (03CR) 10Jforrester: [C: 032] Fix toolbar transition [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/317997 (owner: 10Esanders) [23:55:34] (03CR) 10Jforrester: [C: 032] CSS styleguide fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318008 (owner: 10Esanders) [23:56:21] (03CR) 10Esanders: "I actually prefer switch statements, but I see indentation is a problem. We could fix that by moving each action into a private method whi" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 (owner: 10Catrope) [23:56:44] (03CR) 10Jforrester: [C: 032] Fix arguments passed to requestPageData when switching [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318007 (owner: 10Esanders) [23:57:20] (03CR) 10Jforrester: [C: 04-1] Don't show confirm dialog when switching to NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/316293 (https://phabricator.wikimedia.org/T148099) (owner: 10Esanders)