[02:36:49] 10TemplateData, 10VisualEditor, 06Wikisource: Image container template is broken with the 1.28.0-wmf.23 ab831b0 update in Firefox at English Wikisource. - https://phabricator.wikimedia.org/T149492#2755613 (10AuFCL) @Ineuw: For my money this glitch is entirely related to browser-end caching and not at all rel... [03:30:30] 10TemplateData, 10VisualEditor, 06Wikisource: Image container template is broken with the 1.28.0-wmf.23 ab831b0 update in Firefox at English Wikisource. - https://phabricator.wikimedia.org/T149492#2755651 (10Ineuw) 05Open>03Resolved a:03Ineuw Please close this ticket. With purging of the caches the ima... [04:34:00] (03CR) 10Alex Monk: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 (owner: 10Jforrester) [14:23:45] 10Citoid, 10VisualEditor, 10RESTBase, 10RESTBase-API, and 2 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2756614 (10Mvolz) >>! In T108646#2752712, @GWicke wrote: > One issue @Mvolz brought up is that citoid currently supports another `basefields` flag that changes the f... [14:26:44] 10VisualEditor, 10OOjs, 10OOjs-UI: Submit OOjs UI and OOjs to cdnjs - https://phabricator.wikimedia.org/T106721#2756631 (10Jdforrester-WMF) 05Open>03Resolved Thanks, David! [14:29:09] 10VisualEditor, 07Epic, 05WMF-deploy-2016-11-01_(1.29.0-wmf.1): In VE core, provide a tree differ library - https://phabricator.wikimedia.org/T149570#2756639 (10Jdforrester-WMF) [14:30:05] 10VisualEditor, 05WMF-deploy-2016-11-01_(1.29.0-wmf.1): In VE core, provide a node differ library - https://phabricator.wikimedia.org/T149571#2756657 (10Jdforrester-WMF) [14:34:10] (03PS3) 10Jforrester: Update VE core submodule to master (1bd6c44) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 [14:38:57] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (1bd6c44) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 (owner: 10Jforrester) [14:41:25] (03CR) 10Jforrester: [C: 032] Diff style tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318792 (owner: 10Esanders) [14:44:55] (03Merged) 10jenkins-bot: Diff style tweaks [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318792 (owner: 10Esanders) [14:49:00] (03PS4) 10Jforrester: Update VE core submodule to master (1bd6c44) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 [14:49:02] (03PS1) 10Jforrester: WIP: Pullthrough of diffing code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318930 [14:54:11] (03CR) 10jenkins-bot: [V: 04-1] WIP: Pullthrough of diffing code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318930 (owner: 10Jforrester) [14:54:50] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (1bd6c44) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 (owner: 10Jforrester) [15:00:50] 10VisualEditor, 10VisualEditor-MediaWiki, 07Technical-Debt: Ensure VE-core's modules.json groups are a subset of VE-MW's extension.json ones - https://phabricator.wikimedia.org/T149577#2756810 (10Jdforrester-WMF) [15:13:46] (03PS1) 10Jforrester: build: Move diffing code to its own module for slimness [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 [15:15:08] 10VisualEditor, 10VisualEditor-MediaWiki, 07Technical-Debt: Ensure VE-core's modules.json groups are a subset of VE-MW's extension.json ones - https://phabricator.wikimedia.org/T149577#2756810 (10Esanders) There are also core-specific modules, like the bulid and mobile groups, and libraries we already have i... [15:20:36] (03CR) 10Esanders: [C: 04-1] build: Move diffing code to its own module for slimness (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 (owner: 10Jforrester) [15:20:43] 10VisualEditor, 10VisualEditor-MediaWiki, 07Technical-Debt: Ensure VE-core's modules.json groups are a subset of VE-MW's extension.json ones - https://phabricator.wikimedia.org/T149577#2756908 (10Jdforrester-WMF) Fair point, it's a bit complicated. [15:28:10] 10VisualEditor, 10VisualEditor-MediaWiki, 07Technical-Debt: Ensure VE-core's modules.json groups are a subset of VE-MW's extension.json ones - https://phabricator.wikimedia.org/T149577#2756949 (10Esanders) I'd suggest creating a extension-ve-mw.json with ve-mw specific modules, then creating a grunt task to... [15:31:10] (03PS2) 10Esanders: Cleanup dependency graph [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309470 [15:32:00] (03CR) 10Esanders: "@Krinkle to an extent... we don't add jQuery as dependency of every module." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309470 (owner: 10Esanders) [15:35:09] (03PS2) 10Jforrester: build: Move diffing code to its own module for slimness [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 [15:36:49] (03CR) 10jenkins-bot: [V: 04-1] Cleanup dependency graph [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309470 (owner: 10Esanders) [15:37:42] 10VisualEditor, 07Design, 07Epic, 05WMF-deploy-2016-11-01_(1.29.0-wmf.1): Let users of VE core see a visual diff in the stand-alone demo - https://phabricator.wikimedia.org/T149585#2757023 (10Jdforrester-WMF) [15:41:23] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 13Patch-For-Review: Can't edit really big galleries - https://phabricator.wikimedia.org/T147067#2679795 (10Jdforrester-WMF) p:05Triage>03Low [15:42:06] 10VisualEditor, 10VisualEditor-MediaWiki: Prompt for edit summary: When you switch from VisualEditor to the wikitext editor, it can't see your edit summary - https://phabricator.wikimedia.org/T144906#2757060 (10Jdforrester-WMF) p:05Triage>03Normal [15:47:55] (03CR) 10Jforrester: "You still need to have language pulled in; the unit test failure is saying you don't." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309470 (owner: 10Esanders) [15:50:51] (03CR) 10Esanders: [C: 04-1] build: Move diffing code to its own module for slimness (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 (owner: 10Jforrester) [16:01:04] Krenair, James_F: do you think it would be a good idea to remove citoid from this herald rule https://phabricator.wikimedia.org/H10? I estimate that only 29/120 currently open citoid tasks on the board are strictly relevant to VisualEditor (deal with extension). [16:05:54] mvolz: It's there so we can track them as team work, though. [16:06:01] mvolz: Same as TemplateData and so on. [16:06:06] ok :) [16:06:30] as long as you don't mind moving things to external and administrivia all the time :D [16:06:56] (just noticed that someone removed the tag, then herald added it back in, then you had to move columns for it again.) [16:10:50] (03CR) 10TheDJ: "@esanders: No not jquery indeed, because of: "The modules jquery and mediawiki together form the base environment ("startup") and are pres" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309470 (owner: 10Esanders) [16:33:07] 10VisualEditor, 10VisualEditor-MediaWiki: Prompt for edit summary: When you switch from VisualEditor to the wikitext editor, it can't see your edit summary - https://phabricator.wikimedia.org/T144906#2614008 (10AlexMonk-WMF) Works for me if I disabled NWE [16:37:12] mvolz: It's fine by me. :-) [16:49:29] 10VisualEditor, 06ELiSo, 06Operations, 10RESTBase, 07Esperanto-Sites: RESTBase thinks beta.wikiversity pages don't exist - https://phabricator.wikimedia.org/T148861#2757349 (10Psychoslave) Seems like it works now, thank you to those who helped. :) [16:51:36] (03PS1) 10Alex Monk: Keep edit summary when switching between VE and NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318960 (https://phabricator.wikimedia.org/T144906) [16:53:34] (03PS3) 10Esanders: Cleanup dependency graph [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309470 [17:02:07] (03CR) 10Jforrester: [C: 031] "Ha." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309470 (owner: 10Esanders) [17:02:22] 10VisualEditor, 10VisualEditor-MediaWiki: Visual Editor Welcome message leads to the wikitext editor with the wrong label in Catalan - https://phabricator.wikimedia.org/T149285#2757386 (10AlexMonk-WMF) 05Open>03Resolved a:03Pginer-WMF [17:12:07] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Please add support for adding and editing alt text in the gallery tool - https://phabricator.wikimedia.org/T149596#2757413 (10Whatamidoing-WMF) [17:16:58] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery: Display some more information about the images in the gallery dialog - https://phabricator.wikimedia.org/T145247#2757464 (10Whatamidoing-WMF) I think that making the description page similar to the media dialog would be great. Also, I'd... [17:19:04] 10VisualEditor, 10VisualEditor-MediaWiki: Visual Editor Welcome message leads to the wikitext editor with the wrong label in Catalan - https://phabricator.wikimedia.org/T149285#2757471 (10Jdforrester-WMF) p:05Triage>03Normal [17:21:49] 10VisualEditor, 10VisualEditor-EditingTools, 10CodeEditor, 10SyntaxHighlight, 13Patch-For-Review: VE Code block inspector confuses pygments languages and ACE language modes - https://phabricator.wikimedia.org/T148515#2757484 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal [17:32:27] (03PS6) 10Jforrester: BranchNode: make block slug contenteditable=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303820 (https://phabricator.wikimedia.org/T139428) (owner: 10DLynch) [17:32:58] (03CR) 10Jforrester: [C: 04-1] "Interpreting Ed's comment as a -1." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314032 (https://phabricator.wikimedia.org/T147304) (owner: 10Divec) [17:34:44] 10VisualEditor: Allow rich text editing of image captions in gallery dialog - https://phabricator.wikimedia.org/T149602#2757553 (10Tchanders) [17:35:35] (03PS3) 10Jforrester: build: Move diffing code to its own module for slimness [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 [17:42:17] 10VisualEditor: Allow rich text editing of image captions in gallery dialog - https://phabricator.wikimedia.org/T149602#2757611 (10Tchanders) [17:44:28] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Please add support for adding and editing alt text in the gallery tool - https://phabricator.wikimedia.org/T149596#2757615 (10Tchanders) [17:44:32] (03CR) 10jenkins-bot: [V: 04-1] Partially convert just the modified parts of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/303441 (https://phabricator.wikimedia.org/T142320) (owner: 10Esanders) [17:46:21] 10VisualEditor, 10MediaWiki-extensions-Quiz, 10Possible-Tech-Projects: Add support for Quiz extension in VisualEditor - https://phabricator.wikimedia.org/T148972#2738144 (10Jdforrester-WMF) Presumably this code would live in the Quiz extension? [17:47:56] (03PS20) 10Esanders: Partially convert just the modified parts of the document [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/303441 (https://phabricator.wikimedia.org/T142320) [17:47:58] (03PS1) 10Esanders: Factor out getWikitext in ApiVisualEditorEdit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318965 [17:49:12] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery: Display some more information about the images in the gallery dialog - https://phabricator.wikimedia.org/T145247#2757631 (10Tchanders) +1 to rich text caption editing. See T149602 [17:54:21] 10VisualEditor: Visual diffing: indenting a list item throws an exception - https://phabricator.wikimedia.org/T149537#2757651 (10Jdforrester-WMF) p:05Triage>03High [17:54:42] 10VisualEditor: Visual diffing a removed a row from a table throws an exception - https://phabricator.wikimedia.org/T149528#2757654 (10Jdforrester-WMF) p:05Triage>03High [17:55:02] 10VisualEditor: Add option to DiffElement to show limited context - https://phabricator.wikimedia.org/T149524#2757657 (10Jdforrester-WMF) p:05Triage>03Normal [18:09:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-11-01_(1.29.0-wmf.1): mw.user.options isn't populated when ArticleTargetLoader runs, breaking NWE - https://phabricator.wikimedia.org/T148311#2757733 (10Jdforrester-WMF) [18:18:12] 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: Let users choose a visual or wikitext diff in the "Review your changes" tab - https://phabricator.wikimedia.org/T143350#2757751 (10Jdforrester-WMF) [18:22:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile: After saving mobile visual editor edit, the page edited is now unwatched - https://phabricator.wikimedia.org/T148914#2757777 (10Jdforrester-WMF) p:05Triage>03High Meh. Do we read the wrong setting, write the wrong setting, or is t... [18:24:59] (03PS4) 10Jforrester: build: Move diffing code to its own module for slimness [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 [18:36:01] 10VisualEditor, 10VisualEditor-DataModel, 07Performance, 07Technical-Debt: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2757841 (10Krinkle) [18:53:06] 10VisualEditor, 10VisualEditor-DataModel, 07Performance, 07Technical-Debt: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2757918 (10Krinkle) @Esanders The speed isn't an issue. I presume it'll be faster than any md5/sha1 implementation. However the col... [19:43:50] 10Citoid, 10VisualEditor, 06Community-Tech, 10RESTBase, and 3 others: Consider removing basefields option from citoid API - https://phabricator.wikimedia.org/T149619#2758085 (10Mvolz) [19:50:49] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Math: [Regression pre-wmf.22] Math functions are rendering as tiny nodes - https://phabricator.wikimedia.org/T133096#2758125 (10Jdforrester-WMF) We're pretty sure that this is a Beta Cluster infrastructure bug. [19:51:02] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Math: Math functions are rendering as tiny nodes on the Beta Cluster sometimes - https://phabricator.wikimedia.org/T133096#2758127 (10Jdforrester-WMF) [19:57:57] 10VisualEditor, 10Graphs, 03Interactive-Sprint, 13Patch-For-Review: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2758139 (10JGirault) >>! In T147768#2753642, @Yurik wrote: > @JGirault @MaxSem - the frame looks good, but I was not expecting the background color change.... [20:09:15] 10VisualEditor, 10VisualEditor-DataModel, 07Performance, 07Technical-Debt: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2758189 (10Esanders) >>! In T145456#2757918, @Krinkle wrote: > auto-incrementing integers They should also be unique across multip... [20:09:47] 10VisualEditor, 07Epic, 15User-JAufrecht: [EPIC] Negotiate Service Levels between VE and Stakeholders and identify underlying contradictory needs - https://phabricator.wikimedia.org/T102571#2758191 (10JAufrecht) [20:10:10] (03CR) 10Esanders: [C: 032] build: Move diffing code to its own module for slimness [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 (owner: 10Jforrester) [20:10:42] 10VisualEditor, 07Epic, 15User-JAufrecht: [EPIC] Clarify and maintain service levels between VE and Stakeholders - https://phabricator.wikimedia.org/T102571#1368036 (10JAufrecht) [20:13:43] (03Merged) 10jenkins-bot: build: Move diffing code to its own module for slimness [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318938 (owner: 10Jforrester) [20:25:49] 10VisualEditor, 10VisualEditor-DataModel, 07Performance, 07Technical-Debt: Use a different hash library / algorithm in the IV store - https://phabricator.wikimedia.org/T145456#2630656 (10GWicke) `crypto.subtle.digest` might be an option now that we use HTTPS everywhere: http://caniuse.com/#feat=cryptography [20:26:26] (03CR) 10Esanders: "It looks like this is caused by ve.init.mw.ArticleTarget.prototype.setupToolbar which clears the save dialog when the surface is changed (" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318960 (https://phabricator.wikimedia.org/T144906) (owner: 10Alex Monk) [20:26:33] (03CR) 10Esanders: [C: 04-1] Keep edit summary when switching between VE and NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318960 (https://phabricator.wikimedia.org/T144906) (owner: 10Alex Monk) [20:35:16] (03PS1) 10Esanders: Update treeDiffer library & remove all but dist, licence & readme [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318984 [21:02:23] 10VisualEditor, 10MediaWiki-extensions-Quiz, 10Possible-Tech-Projects: Add VisualEditor support to Quiz extension - https://phabricator.wikimedia.org/T148972#2758339 (10Mvolz) [21:02:36] 10VisualEditor, 10MediaWiki-extensions-Quiz, 10Possible-Tech-Projects: Add VisualEditor support to Quiz extension - https://phabricator.wikimedia.org/T148972#2738144 (10Mvolz) >>! In T148972#2757621, @Jdforrester-WMF wrote: > Presumably this code would live in the Quiz extension? Yes [21:08:14] (03CR) 10Jforrester: [C: 031] "Thalia should be the one to merge https://github.com/Tchanders/treeDiffer.js/pull/5 and this." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318984 (owner: 10Esanders) [21:24:14] (03PS5) 10Jforrester: Update VE core submodule to master (977d3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 [21:29:01] (03CR) 10jenkins-bot: [V: 04-1] Update VE core submodule to master (977d3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 (owner: 10Jforrester) [21:31:33] 10VisualEditor, 10Graphs, 03Interactive-Sprint, 13Patch-For-Review: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2758463 (10Yurik) I think we should do transparent, because on some wikis, especially the non-article pages use different background colors. [21:35:54] (03PS6) 10Jforrester: Update VE core submodule to master (977d3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 [21:39:37] James_F, got any more details about https://phabricator.wikimedia.org/T133096#2758125 ? [21:39:50] Just that the bug is only reproducible in beta, nowhere else? [21:44:03] 10VisualEditor, 07Epic, 15User-JAufrecht: [EPIC] Clarify and maintain service levels between VE and Stakeholders - https://phabricator.wikimedia.org/T102571#2758496 (10JAufrecht) [21:47:06] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (977d3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 (owner: 10Jforrester) [21:57:28] (03Merged) 10jenkins-bot: Update VE core submodule to master (977d3ad) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318585 (owner: 10Jforrester) [22:16:12] (03PS1) 10Esanders: Fix typo in getModifiedRanges [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318997 [22:16:14] (03PS1) 10Esanders: Fix behaviour of attribute change in getModifiedRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318998 [22:24:43] 10VisualEditor, 10MediaWiki-extensions-Quiz, 10Possible-Tech-Projects: Add VisualEditor support to Quiz extension - https://phabricator.wikimedia.org/T148972#2758600 (10Mvolz) Although at present time, this is not terribly useful, because VE is only enabled on a few wikiversities where Quiz is also enabled.... [22:54:58] (03CR) 10Tchanders: [C: 032] Remove #rebuildTree calls and ensure #getDocumentNode is used [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318788 (owner: 10Esanders) [22:57:39] (03Merged) 10jenkins-bot: Remove #rebuildTree calls and ensure #getDocumentNode is used [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318788 (owner: 10Esanders) [23:02:02] 10VisualEditor, 10Beta-Cluster-Infrastructure, 10Math: Math functions are rendering as tiny nodes on the Beta Cluster sometimes - https://phabricator.wikimedia.org/T133096#2219865 (10AlexMonk-WMF) >>! In T133096#2758125, @Jdforrester-WMF wrote: > We're pretty sure that this is a Beta Cluster infrastructure b... [23:11:34] (03CR) 10Tchanders: [C: 032] Extract DM document from node instead of passing it as argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318794 (owner: 10Esanders) [23:13:45] (03Merged) 10jenkins-bot: Extract DM document from node instead of passing it as argument [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318794 (owner: 10Esanders) [23:55:10] Krenair: It's a semi-continuous problem; ryasmeen is the expert. [23:55:56] (03CR) 10Jforrester: [C: 031] "Oh dear." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/318997 (owner: 10Esanders)