[06:49:11] 10VisualEditor, 10Graphs, 03Interactive-Sprint, 13Patch-For-Review: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2775534 (10Yurik) While we are on this topic, @JGirault et al, what do you think about citations and source links in graphs? We are getting closer to cross... [07:48:23] 10VisualEditor: Insertion of nowiki tags at the nowiki project - https://phabricator.wikimedia.org/T150140#2775560 (10jeblad) Some examples - [[ https://no.wikipedia.org/w/index.php?title=Venstre&curid=1196&diff=16879398&oldid=16635564 | Venstre ]] (due to missing curly paenthesis?) - [[ https://no.wikipedia... [08:03:40] 10VisualEditor: Insertion of out of sync link text at the nowiki project - https://phabricator.wikimedia.org/T150141#2775562 (10jeblad) Some examples - [[ https://no.wikipedia.org/w/index.php?title=Bevegelsen_for_Sosialisme&curid=27409&diff=16878477&oldid=16849954 | Bevegelsen for Sosialisme ]] - [[ https://... [10:04:00] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 11 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2775679 (10Amire80) p:05Triage>03Normal [10:04:27] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 11 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2748980 (10Amire80) p:05Normal>03Triage [11:05:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10ProveIt-Gadget: Add VisualEditor and 2017 wikitext editor support to ProveIt - https://phabricator.wikimedia.org/T148870#2775856 (10Iniquity) >>! In T148870#2774879, @TheDJ wrote: > So you want a way to quickly navigate and edit existing referenc... [11:25:12] 10VisualEditor: Remove the "Start editing" welcome panel when a user wants to edit a protected page - https://phabricator.wikimedia.org/T150087#2775895 (10Trizek-WMF) [11:31:54] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2775922 (10Trizek-WMF) >>! In T55973#2769070, @Quiddity wrote: > Losing occasional text-... [13:40:55] 10WikiEditor, 10MediaWiki-Parser: Wikieditor: Replace the
tag button with HTML5 preffered
- https://phabricator.wikimedia.org/T150172#2776137 (10Perhelion) [13:42:41] 10WikiEditor, 10MediaWiki-Parser: Wikieditor: Replace the
tag button with HTML5 preffered
- https://phabricator.wikimedia.org/T150172#2776151 (10Perhelion) [14:19:08] (03PS5) 10Esanders: Factor out active node functionality from SectionNode for captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320068 (https://phabricator.wikimedia.org/T149753) [14:23:06] 10VisualEditor: In visual diff, indented bullet/numbered item are preceded by an extra bullet/number instead of just space - https://phabricator.wikimedia.org/T149823#2776236 (10Esanders) 05Open>03Invalid That is actually the browser's native rendering of a double indented list, as is how it would look in re... [14:26:29] 10VisualEditor, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Visual diffing: indenting a list item produces an incorrect diff - https://phabricator.wikimedia.org/T149537#2776241 (10Esanders) 05Resolved>03Open Actually the patch improved the rendering, but it still shows one item removed and two inserted: {F470... [16:15:58] (03CR) 10Jforrester: [C: 032] Don't bother testing data on direction key tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320086 (owner: 10Esanders) [16:17:51] (03CR) 10DLynch: [C: 04-1] Avoid jQuery in PreviewElement and ve.resolveAttributes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320006 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [16:18:16] (03CR) 10Jforrester: [C: 032] Use shallow copy for internal list data inside shallowCloneFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320000 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [16:18:20] (03Merged) 10jenkins-bot: Don't bother testing data on direction key tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320086 (owner: 10Esanders) [16:22:36] 10VisualEditor: Insertion of out of sync link text at the nowiki project - https://phabricator.wikimedia.org/T150141#2775149 (10matmarex) This is being actively worked on, as {T55973}. [16:28:05] 10VisualEditor: Insertion of nowiki tags at the nowiki project - https://phabricator.wikimedia.org/T150140#2776778 (10matmarex) >>! In T150140#2775560, @jeblad wrote: > Some examples > - [[ https://no.wikipedia.org/w/index.php?title=Venstre&curid=1196&diff=16879398&oldid=16635564 | Venstre ]] (due to missing c... [16:32:14] (03CR) 10DLynch: [C: 04-1] Converter: Remove internal during the main loop (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320005 (owner: 10Esanders) [16:37:34] 10Cite, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07User-notice, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Make a better keyboard shortcut for adding a citation - https://phabricator.wikimedia.org/T99299#2776806 (10DLynch) The logic, incidentally, being that we already have the "add a link" shor... [16:40:00] (03CR) 10Jforrester: [C: 032] Cleanup elements passed to MWImageNode mixin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320099 (owner: 10Esanders) [16:40:33] (03Merged) 10jenkins-bot: Use shallow copy for internal list data inside shallowCloneFromRange [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320000 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [16:45:16] 10VisualEditor, 10VisualEditor-MediaWiki: Add to the Cite menu for non-Citoid wikis - https://phabricator.wikimedia.org/T137250#2362261 (10DLynch) The current state of affairs does have an advantage: if you edit a wiki with VE, "insert reference list" is always in the same place. Making this cha... [16:50:14] (03CR) 10DLynch: [C: 032] Ensure inserted reference gets selected [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/320065 (owner: 10Esanders) [16:51:20] (03Merged) 10jenkins-bot: Cleanup elements passed to MWImageNode mixin [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320099 (owner: 10Esanders) [16:51:54] (03Merged) 10jenkins-bot: Ensure inserted reference gets selected [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/320065 (owner: 10Esanders) [17:24:30] airhacks [17:49:02] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2777112 (10DLynch) One reason to consider keeping the internal-labels is that they're eas... [18:00:36] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2777160 (10Quiddity) >>! In T55973#2775922, @Trizek-WMF wrote: > How do you deal with som... [18:28:39] 10Citoid, 10VisualEditor, 06Operations, 06Services (blocked): Separate citoid service for beta that runs off master instead of deploy - https://phabricator.wikimedia.org/T92304#2777252 (10Mvolz) >>! In T92304#2767678, @mobrovac wrote: > Nope, @Mvolz that's not it. I will likely delete that instance as it's... [18:28:49] 10Citoid, 10VisualEditor, 06Operations, 06Services (blocked): Separate citoid service for beta that runs off master instead of deploy - https://phabricator.wikimedia.org/T92304#2777253 (10Mvolz) >>! In T92304#2767678, @mobrovac wrote: > Nope, @Mvolz that's not it. I will likely delete that instance as it's... [18:35:24] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link was broken when a different part of the page was edited - https://phabricator.wikimedia.org/T150196#2777271 (10Whatamidoing-WMF) [18:37:03] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Parsoid: Potentially valid but complex link was broken when a different part of the page was edited - https://phabricator.wikimedia.org/T150196#2777288 (10Whatamidoing-WMF) I'm adding Parsoid to the tags so that the Parsing team can check this, too; feel free... [18:38:56] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link can't be edited - https://phabricator.wikimedia.org/T150197#2777305 (10Whatamidoing-WMF) [18:39:12] (03PS1) 10Deskana: Clarify wording of __NOINDEX__ option in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320240 [18:40:42] (03CR) 10Jforrester: [C: 032] Clarify wording of __NOINDEX__ option in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320240 (owner: 10Deskana) [18:44:52] 10VisualEditor, 10VisualEditor-MediaWiki-Links, 10Parsoid: Potentially valid but complex link was broken when a different part of the page was edited - https://phabricator.wikimedia.org/T150196#2777271 (10matmarex) I don't think `[http://example.com Label [[File:Smiley.png|16px]]]` is actually valid. With Ti... [18:54:11] (03Merged) 10jenkins-bot: Clarify wording of __NOINDEX__ option in VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320240 (owner: 10Deskana) [19:08:21] 10VisualEditor, 10VisualEditor-MediaWiki, 06Services (watching), 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): VisualEditor should provide api-user-agent to RESTBase - https://phabricator.wikimedia.org/T149050#2777402 (10Jdforrester-WMF) [19:08:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Disable NWE on pages with a different content type (e.g. common.js/css) - https://phabricator.wikimedia.org/T149007#2777403 (10Jdforrester-WMF) [19:08:27] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Double clicking on a image in results of the gallery dialog results in the image being added twice - https://phabricator.wikimedia.org/T148558#2777404 (10Jdforrester-WMF) [19:08:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Don't show "Switch to source editing?" dialog for VE->NWE, just switch with changes - https://phabricator.wikimedia.org/T148099#2777405 (10Jdforrester-WMF) [19:08:29] 10VisualEditor, 10Graphs, 07Technical-Debt, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Refactor TableWidget to use a proper model - https://phabricator.wikimedia.org/T120630#2777406 (10Jdforrester-WMF) [19:09:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Prompt for edit summary: When you switch from VisualEditor to the wikitext editor, it can't see your edit summary - https://phabricator.wikimedia.org/T144906#2777412 (10Jdforrester... [19:15:51] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 07Accessibility: Please add support for adding and editing alt text in the gallery tool - https://phabricator.wikimedia.org/T149596#2777469 (10Jdforrester-WMF) p:05Triage>03Normal [19:46:40] (03CR) 10Esanders: Avoid jQuery in PreviewElement and ve.resolveAttributes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320006 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [19:47:20] 10VisualEditor, 15User-JAufrecht: Follow up on VE SLUs after the Engineering Offsite - https://phabricator.wikimedia.org/T111226#2777689 (10JAufrecht) [19:47:22] 10VisualEditor, 15User-JAufrecht: Follow up on VE/DR SLU - https://phabricator.wikimedia.org/T129687#2777687 (10JAufrecht) 05Open>03Resolved Covered by second round of SLU tasks. [19:53:05] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10MediaWiki-Page-editing, 07Accessibility: Put the focus on the content and the cursor at the beginning of the aimed content - https://phabricator.wikimedia.org/T150133#2774896 (10matmarex) This works for me in VisualEditor, actually (clicking "modifier"), bu... [20:01:11] (03CR) 10DLynch: [C: 032] Avoid jQuery in PreviewElement and ve.resolveAttributes (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320006 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [20:03:38] (03PS3) 10Esanders: Converter: Remove internal during the main loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320005 [20:05:42] (03PS2) 10Tchanders: Refactor diff element getChangedNodeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320101 [20:08:35] (03CR) 10jenkins-bot: [V: 04-1] Refactor diff element getChangedNodeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320101 (owner: 10Tchanders) [20:43:31] (03PS4) 10Jforrester: Avoid jQuery in PreviewElement and ve.resolveAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320006 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [20:43:36] (03CR) 10Jforrester: [C: 032] Avoid jQuery in PreviewElement and ve.resolveAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320006 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [20:47:21] (03Merged) 10jenkins-bot: Avoid jQuery in PreviewElement and ve.resolveAttributes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320006 (https://phabricator.wikimedia.org/T134975) (owner: 10Esanders) [20:57:27] (03PS4) 10Jforrester: Converter: Remove internal during the main loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320005 (owner: 10Esanders) [20:57:52] (03PS3) 10Jforrester: Improve performance of shallowCloneFromRange( undefined ) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320008 (owner: 10Esanders) [21:00:05] (03CR) 10jenkins-bot: [V: 04-1] Improve performance of shallowCloneFromRange( undefined ) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320008 (owner: 10Esanders) [21:51:58] 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Performance, 05WMF-deploy-2016-11-08_(1.29.0-wmf.2): Re-using a reference is slow for articles with very large numbers of references - https://phabricator.wikimedia.org/T134975#2778147 (10Jdforrester-WMF) Ed, do you think we should keep this open or de... [21:52:32] (03PS1) 10Jforrester: Update VE core submodule to master (88ba26b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320296 [22:10:44] (03CR) 10Alex Monk: [C: 032] Update VE core submodule to master (88ba26b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320296 (owner: 10Jforrester) [22:19:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (88ba26b) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320296 (owner: 10Jforrester) [23:48:44] (03PS5) 10Esanders: Converter: Remove internal during the main loop [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320005 [23:55:30] (03PS1) 10Alex Monk: Move NWE URL changes into JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320318 (https://phabricator.wikimedia.org/T148077) [23:55:33] (03PS2) 10Jforrester: WIP: Pullthrough of diffing code [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/318930