[00:25:01] (03CR) 10Alex Monk: Move NWE URL changes into JS (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320318 (https://phabricator.wikimedia.org/T148077) (owner: 10Alex Monk) [00:27:29] (03CR) 10Alex Monk: "please open a bug for whatever this solves" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320379 (owner: 10Esanders) [00:31:23] (03CR) 10Alex Monk: [C: 032] Rename methods used for setting up multiple edit tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320383 (owner: 10Esanders) [00:45:02] (03Merged) 10jenkins-bot: Rename methods used for setting up multiple edit tabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320383 (owner: 10Esanders) [00:59:27] (03PS1) 10Jforrester: Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 [01:01:39] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 (owner: 10Jforrester) [01:11:48] (03PS2) 10Jforrester: Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 [01:17:12] (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 (owner: 10Jforrester) [01:32:56] (03PS3) 10Jforrester: Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 [01:51:04] James_F: want me to merge these ^, or not yet? [01:51:53] MatmaRex: It's got a parent that edsanders wanted to fiddle with. [01:52:10] MatmaRex: (For VE.) [01:53:37] James_F: should MW core also wait? [01:53:49] MatmaRex: Let's do it in the morning. [01:54:08] okay [01:54:27] Thank you, though. [01:54:37] Also I should help Volker write the release notes announcement. [02:22:00] 10VisualEditor, 10VisualEditor-CopyPaste: Can't paste in HTML wrapped in unsupported tags, e.g. - https://phabricator.wikimedia.org/T149714#2781764 (10Whatamidoing-WMF) Kerry reports that forcing a plain-text paste works, and also that the problem is only when copying the beginning of the file name. [03:34:44] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 12 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2781773 (10MoritzMuehlenhoff) I've just completed a backport of 6.9.1 for jessie-wikimedia. My build no longer links against the shared library copy of c-ares since it req... [03:41:03] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 12 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2781774 (10Yurik) I have tried running Kartotherian (without rebuilding) under nodejs 6.9.1, and had some issues - Kartotherian wouldn't start due to mapnik native library... [06:41:06] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link can't be edited - https://phabricator.wikimedia.org/T150197#2781867 (10Whatamidoing-WMF) I can get the normal link editing flyout: just place your cursor at the very start of the link/template, and the flyout automatically appe... [08:54:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Don't select signature when inserting it in NWE - https://phabricator.wikimedia.org/T150320#2781948 (10Schnark) [09:05:22] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link can't be edited - https://phabricator.wikimedia.org/T150197#2781962 (10Schnark) Interesting. Now I even succeed to get a combined flyout: {F4709303} Editing the link from there works as expected. [09:06:05] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 12 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2781963 (10MoritzMuehlenhoff) >>! In T149331#2781773, @MoritzMuehlenhoff wrote: > I've just completed a backport of 6.9.1 for jessie-wikimedia. My build no longer links ag... [11:06:46] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: beta-update-databases-eqiad fails running update.php on Beta cluster since Nov 9th 3:20am UTC - https://phabricator.wikimedia.org/T150323#2782076 (10hashar) MediaWiki core change is https://gerrit.wikimedia.org/r/#/c/320558/ That fails the... [11:11:51] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2782081 (10hashar) [11:15:38] (03CR) 10Paladox: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320379 (owner: 10Esanders) [11:17:03] (03PS1) 10Paladox: Test: DO not merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320577 [11:17:12] (03PS2) 10Paladox: Test: DO not merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320577 [11:17:34] (03PS3) 10Paladox: Test: DO not merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320577 [11:18:13] (03PS1) 10Paladox: Test: Do not merge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320578 [11:18:36] (03Abandoned) 10Paladox: Test: Do not merge [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320578 (owner: 10Paladox) [11:18:52] (03CR) 10jenkins-bot: [V: 04-1] Don't re-bind edit tab in DAT when using SET [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320379 (owner: 10Esanders) [11:19:02] (03Abandoned) 10Paladox: Test: DO not merge [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320577 (owner: 10Paladox) [11:20:21] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI, 13Patch-For-Review: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2782106 (10Paladox) @hashar visualeditor is using oojs ui 0.17.0 so that may be because it fa... [11:34:06] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI, 13Patch-For-Review: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2782113 (10Paladox) @hashar reverting it seems to pass, see https://gerrit.wikimedia.org/r/#/... [11:45:15] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI, 13Patch-For-Review: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2782145 (10Paladox) @hashar change https://gerrit.wikimedia.org/r/#/c/320580/ [11:45:51] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 12 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2782147 (10mobrovac) >>! In T149331#2781774, @Yurik wrote: > I have tried running Kartotherian (without rebuilding) under nodejs 6.9.1, and had some issues - Kartotherian... [12:06:24] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI, 13Patch-For-Review: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2782165 (10Reedy) p:05Triage>03Normal [12:06:33] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2782049 (10Reedy) [12:28:37] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 12 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2782174 (10MoritzMuehlenhoff) > I'll refrain from uploading this to apt.wikimedia.org until the karthotherian problems are sorted out. In the mean time I've copied the pa... [13:14:44] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 12 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2782209 (10KartikMistry) I suggest we should test new Node in Beta cluster first. [13:28:45] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2782249 (10Mvolz) [13:44:58] 10Citoid, 10VisualEditor, 10Possible-Tech-Projects, 07Documentation, 10Outreachy (Round-13): Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#2782274 (10Niharika) [13:46:12] 10VisualEditor, 10MediaWiki-General-or-Unknown, 10MediaWiki-Page-editing: At click, do not do unexpected page scrolling, and put the cursor at the clicked place - https://phabricator.wikimedia.org/T150139#2782293 (10Elitre) OS X El Capitan 10.11.4 (15E65), Safari 9.1 (11601.5.17.1). I have "Les conditions c... [13:49:36] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Visual Editor get confused when adding external links that include pipe symbols (|) - https://phabricator.wikimedia.org/T150064#2782303 (10Mrjohncummings) Hmmm, I can't seem to replicate it, perhaps its not the pipe symbol that was confusing it, here is the diff... [14:00:46] 10VisualEditor: Browser tab still says Editing:PAGETITLE after saving a page using VE - https://phabricator.wikimedia.org/T150331#2782312 (10Mrjohncummings) [14:01:00] 10VisualEditor: Browser tab still says Editing:PAGETITLE after saving a page using VE - https://phabricator.wikimedia.org/T150331#2782324 (10Mrjohncummings) [14:02:47] 10VisualEditor: Browser tab still says Editing:PAGETITLE after saving a page using VE - https://phabricator.wikimedia.org/T150331#2782312 (10Mrjohncummings) [14:23:08] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2782367 (10Mvolz) [14:27:01] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link can't be edited - https://phabricator.wikimedia.org/T150197#2782380 (10Trizek-WMF) @Whatamidoing-WMF : I've tried to edit like you did, and I was not able to remove the link. However, If i click on the template and click on the... [14:55:30] (03CR) 10Esanders: "No, I'm and idiot and forgot to clone the test data :/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320008 (owner: 10Esanders) [14:58:57] (03CR) 10Esanders: "Ignore above message about this being reverted, it was abandoned." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320005 (owner: 10Esanders) [14:59:15] (03PS4) 10Esanders: Fix and improve performance of shallowCloneFromRange( undefined ) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320008 [15:02:23] edsanders: https://simplyedit.io [15:02:36] edsanders: looks like it might be a project that you'd be interested in [15:02:41] thanks [15:04:49] live demo: https://simplyedit.github.io/sublime/#simply-edit [15:09:53] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend: New grey footer code causes VE to have a grey background below a certain point - https://phabricator.wikimedia.org/T150333#2782467 (10Esanders) [15:11:13] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend: New grey footer code causes VE to have a grey background below a certain point - https://phabricator.wikimedia.org/T150333#2782483 (10Jdlrobson) [15:13:21] (03CR) 10Esanders: Move NWE URL changes into JS (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320318 (https://phabricator.wikimedia.org/T148077) (owner: 10Alex Monk) [15:14:04] (03CR) 10Esanders: [C: 032] Refactor diff element getChangedNodeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320101 (owner: 10Tchanders) [15:14:38] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2782490 (10Mvolz) [15:17:27] (03Merged) 10jenkins-bot: Refactor diff element getChangedNodeHtml [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320101 (owner: 10Tchanders) [15:19:46] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link can't be edited - https://phabricator.wikimedia.org/T150197#2782537 (10Whatamidoing-WMF) Perhaps the behavior is browser-specific in addition to depending upon exactly how you trigger the link box. I'm running Version 10.0.1 (1... [15:25:46] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link can't be edited - https://phabricator.wikimedia.org/T150197#2782589 (10Trizek-WMF) >>! In T150197#2782380, @Trizek-WMF wrote: > @Schnark, how did you get that?!? I've always see that on mockups, never in a live-editing environne... [15:27:05] (03PS1) 10Esanders: Collapse to end after inserting WT signature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320609 (https://phabricator.wikimedia.org/T150320) [15:28:09] 10VisualEditor, 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt: VisualEditor browser test inside MobileFrontend are skipped - https://phabricator.wikimedia.org/T150338#2782598 (10Jdlrobson) [15:28:36] 10VisualEditor: Insertion of out of sync link text at the no.wiki project - https://phabricator.wikimedia.org/T150141#2782613 (10Esanders) [15:31:11] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2782619 (10Esanders) > How do you deal with something like `[[Parrot|{{lang|fr|perroquet}... [16:40:07] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2782737 (10Mvolz) [16:55:07] (03Abandoned) 10DLynch: BranchNode: make block slug contenteditable=false [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303820 (https://phabricator.wikimedia.org/T139428) (owner: 10DLynch) [16:55:21] 10VisualEditor: Cursor gets active inside the slug label and the text "Insert Paragraph" can be edited - https://phabricator.wikimedia.org/T139428#2782767 (10DLynch) 05Open>03Resolved This is fixed, now, by some post-selection fixups. (There's a momentary flicker of the cursor being inside the slug, and then... [17:05:38] 10VisualEditor, 10VisualEditor-ContentEditable: In Firefox, dragging the selection past a block slug resets the selected text - https://phabricator.wikimedia.org/T150345#2782805 (10DLynch) [17:07:32] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2782817 (10Mvolz) [17:09:56] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Potentially valid but complex link can't be edited - https://phabricator.wikimedia.org/T150197#2782820 (10Whatamidoing-WMF) Following that process, I can get the combined tool in Firefox 49 but not Safari 10. [17:12:07] 10VisualEditor, 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt: VisualEditor browser test inside MobileFrontend are skipped - https://phabricator.wikimedia.org/T150338#2782822 (10Jdlrobson) @Esanders @Jdforrester-WMF any preference on what we should do? After a brief discussion we are proposing... [17:42:52] (03PS1) 10DLynch: ce.Surface: Tougher check on whether cursorHolders are still in-document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320621 (https://phabricator.wikimedia.org/T139822) [17:44:06] 10Cite, 10Citoid, 10VisualEditor, 13Patch-For-Review: "Cannot read property 'removeChild' of null" when pressing "Journal" in the Cite window - https://phabricator.wikimedia.org/T139822#2443777 (10DLynch) Can't reproduce it either, but here's a safeguard patch for it. [17:48:54] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 12 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2782913 (10Yurik) @KartikMistry I agree, but we don't have Kartotherian/Tilerator running in beta cluster (we should). @mobrovac, seems like my git repo got corrupted. Sti... [18:27:43] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2783044 (10Jdforrester-WMF) Argh. @Volker_E merged https://gerrit.wikimedia.org/r/#/c/320557/ but not https://gerri... [18:36:10] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2783071 (10Paladox) @Jdforrester-WMF Hi, it failed the qunit tests https://integration.wikimedia.org/ci/job/mediawi... [18:51:12] 10VisualEditor, 15User-JAufrecht: Book and prep VE/Editing Design SLU Review - https://phabricator.wikimedia.org/T150351#2783103 (10JAufrecht) [18:51:57] 10VisualEditor, 15User-JAufrecht: Set up SLU Review between VE and CL - https://phabricator.wikimedia.org/T150352#2783118 (10JAufrecht) [18:53:21] 10VisualEditor, 07Epic, 15User-JAufrecht: [EPIC] Conduct second round of VE SLU checkups - https://phabricator.wikimedia.org/T149621#2783133 (10JAufrecht) [19:03:18] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10MobileFrontend, 06Reading-Web-Backlog, 07Regression: Long overlays have gray backgrounds - https://phabricator.wikimedia.org/T148794#2783156 (10Jdforrester-WMF) [19:19:13] (03CR) 10Jforrester: [C: 032] Collapse to end after inserting WT signature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320609 (https://phabricator.wikimedia.org/T150320) (owner: 10Esanders) [19:19:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Don't select signature when inserting it in NWE - https://phabricator.wikimedia.org/T150320#2783194 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [19:20:43] 10VisualEditor: Cursor gets active inside the slug label and the text "Insert Paragraph" can be edited - https://phabricator.wikimedia.org/T139428#2783201 (10Jdforrester-WMF) Nice, thank you. [19:30:04] (03PS1) 10Jforrester: MWExtensionWindow: Use #setDir, not the removed #setRTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320635 [19:30:31] (03CR) 10jenkins-bot: [V: 04-1] Collapse to end after inserting WT signature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320609 (https://phabricator.wikimedia.org/T150320) (owner: 10Esanders) [19:35:19] (03CR) 10Catrope: [C: 032] MWExtensionWindow: Use #setDir, not the removed #setRTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320635 (owner: 10Jforrester) [19:37:32] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 11 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2748980 (10Yurik) [19:38:30] (03CR) 10jenkins-bot: [V: 04-1] MWExtensionWindow: Use #setDir, not the removed #setRTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320635 (owner: 10Jforrester) [19:44:14] (03Merged) 10jenkins-bot: MWExtensionWindow: Use #setDir, not the removed #setRTL [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320635 (owner: 10Jforrester) [19:49:09] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 11 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2783313 (10GWicke) @MoritzMuehlenhoff, thanks a lot for preparing the node debs! [19:51:55] (03CR) 10Jforrester: [C: 032] Collapse to end after inserting WT signature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320609 (https://phabricator.wikimedia.org/T150320) (owner: 10Esanders) [19:55:14] (03PS2) 10Jforrester: LinkAnnotation{Inspector|Widget}: Stop using deprecated TextInputWidget#isValid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320531 [19:56:41] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2783338 (10Paladox) It passes now, https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/15841... [19:58:06] (03CR) 10jenkins-bot: [V: 04-1] LinkAnnotation{Inspector|Widget}: Stop using deprecated TextInputWidget#isValid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320531 (owner: 10Jforrester) [19:59:08] (03PS3) 10Jforrester: LinkAnnotation{Inspector|Widget}: Stop using deprecated TextInputWidget#isValid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320531 [19:59:58] (03CR) 10Catrope: [C: 032] LinkAnnotation{Inspector|Widget}: Stop using deprecated TextInputWidget#isValid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320531 (owner: 10Jforrester) [20:00:06] (03Merged) 10jenkins-bot: Collapse to end after inserting WT signature [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320609 (https://phabricator.wikimedia.org/T150320) (owner: 10Esanders) [20:01:23] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2783371 (10Jdforrester-WMF) 05Open>03Resolved a:03hashar [20:02:12] 10VisualEditor, 10MobileFrontend, 06Reading-Web-Backlog, 07Technical-Debt: VisualEditor browser test inside MobileFrontend are skipped - https://phabricator.wikimedia.org/T150338#2783377 (10Jdforrester-WMF) I'm content to remove. [20:03:34] (03Merged) 10jenkins-bot: LinkAnnotation{Inspector|Widget}: Stop using deprecated TextInputWidget#isValid [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320531 (owner: 10Jforrester) [20:03:46] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Firefox: In Firefox, dragging the selection past a block slug resets the selected text - https://phabricator.wikimedia.org/T150345#2783382 (10Jdforrester-WMF) p:05Triage>03Low [20:16:09] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2783448 (10Volker_E) Repeating from the patch: That was a troubled evening yesterday and my Internet stopped unexpe... [20:20:38] James_F: You need to pull through https://gerrit.wikimedia.org/r/320531 because the link inspector is broken in master right now [20:20:54] (Discovered during the Flow bug bash) [20:26:50] RoanKattouw: You didn't merge https://gerrit.wikimedia.org/r/#/c/320553/ … [20:26:55] (03PS4) 10Jforrester: Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 [20:26:58] Oh sorry [20:27:00] I couldn't find it earlier [20:27:03] Will do now [20:27:05] Ta. [20:27:21] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 (owner: 10Jforrester) [20:30:51] (03Merged) 10jenkins-bot: Update OOjs UI to v0.18.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320553 (owner: 10Jforrester) [20:36:28] (03PS1) 10Jforrester: Update VE core submodule to master (5f569e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320650 [20:36:29] RoanKattouw: ^^^ [20:36:45] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (5f569e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320650 (owner: 10Jforrester) [20:45:19] (03Merged) 10jenkins-bot: Update VE core submodule to master (5f569e4) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320650 (owner: 10Jforrester) [20:48:51] (03CR) 10Jforrester: [C: 031] "OK, this should no longer be needed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313916 (owner: 10Jforrester) [20:48:59] (03PS2) 10Jforrester: Revert "Temporarily override broken toolbar border colour" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313916 [21:41:11] (03CR) 10Esanders: [C: 032] Revert "Temporarily override broken toolbar border colour" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313916 (owner: 10Jforrester) [21:42:17] (03CR) 10Esanders: [C: 032] ce.Surface: Tougher check on whether cursorHolders are still in-document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320621 (https://phabricator.wikimedia.org/T139822) (owner: 10DLynch) [21:47:31] (03Merged) 10jenkins-bot: ce.Surface: Tougher check on whether cursorHolders are still in-document [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320621 (https://phabricator.wikimedia.org/T139822) (owner: 10DLynch) [21:49:54] (03Merged) 10jenkins-bot: Revert "Temporarily override broken toolbar border colour" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313916 (owner: 10Jforrester) [21:50:40] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2783954 (10hashar) @Volker_E no worries! We caught it fast enough and the fix was quite easy (just press the rever... [21:58:47] 10Cite, 10Citoid, 10VisualEditor, 13Patch-For-Review: "Cannot read property 'removeChild' of null" when pressing "Journal" in the Cite window - https://phabricator.wikimedia.org/T139822#2783994 (10Jdforrester-WMF) 05Open>03Resolved a:03DLynch [22:00:16] 10Cite, 10VisualEditor, 10Beta-Cluster-Infrastructure, 10OOjs-UI: OOjs v0.18.0 not in mediawiki/core and VE QUnit tests fails when trying to use it - https://phabricator.wikimedia.org/T150323#2784001 (10Jdforrester-WMF) >>! In T150323#2783954, @hashar wrote: > @Volker_E no worries! We caught it fast enoug... [22:04:48] (03Abandoned) 10Jforrester: [WIP] build: Force DesktopArticleTarget.init to be ES3-compatible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/232574 (owner: 10Jforrester) [22:14:26] (03PS6) 10Jforrester: [WIP] ArticleTarget: Use an OOUI MessageDialog, not window.alert() [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/224216