[00:02:51] (03Merged) 10jenkins-bot: Move NWE URL changes into JS [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320318 (https://phabricator.wikimedia.org/T148077) (owner: 10Alex Monk) [00:11:48] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): If you have NWE enabled, on a non-JS machine (or disabled) you can't edit - https://phabricator.wikimedia.org/T148077#2789629 (10Jdforrester-WMF) 05Open>03Resolved [00:11:53] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design, 07Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#2789631 (10Jdforrester-WMF) [03:47:09] this diff3 function seems broken [03:47:19] Diff.diff3_merge( 'fgha\n\nFile:', 'fghakpjwqe\n\nFile:', 'fghakpjwqe\n\nFile:', true ).length [03:47:19] 1 [03:47:24] Diff.diff3_merge( 'fgha\n\nFile:' + suffix, 'fghakpjwqe\n\nFile:' + suffix, 'fghakpjwqe\n\nFile:' + suffix, true ).length [03:47:24] 43 [04:03:30] Diff.diff3_merge( 'aalla', 'aaaaaa' + 'aalla', 'aaaaaa' + 'aalla', true ).length [04:03:31] 3 [04:03:31] Diff.diff3_merge( 'aala', 'aaaaaa' + 'aala', 'aaaaaa' + 'aala', true ).length [04:03:31] 1 [04:03:36] very strange [04:03:49] only seems to happen with certain combinations of certain characters [05:29:04] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: Provide simultaneous access to diff preview and edit summary - https://phabricator.wikimedia.org/T148297#2789778 (10Nnemo) >>! In T148297#2789183, @Tgr wrote: > Ideally, the summary box would always be on-screen while looking at the diff. Yes. Ideally, the... [06:26:08] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2789819 (10Elitre) What matma said. [14:09:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Create a config option to enable NWE by default - https://phabricator.wikimedia.org/T150578#2790062 (10Esanders) [14:28:01] (03PS1) 10Esanders: Add teardownToolbar to ve.init.Target [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321106 [14:28:42] (03PS2) 10Esanders: Teardown the toolbar properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321082 [14:30:24] (03PS1) 10Esanders: Cache this.getToolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321107 [14:31:51] (03PS2) 10Esanders: Cache this.getToolbar [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321107 [14:41:28] (03PS1) 10Esanders: eslint: Re-enable wrap-iife and partially enable dot-notation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321109 [14:44:25] (03PS1) 10Esanders: eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321110 [16:12:47] (03PS1) 10Esanders: Always set mode when activating the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321115 [16:20:36] (03PS1) 10Esanders: Reject activatingDeferred as soon as loadFail runs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321116 [16:21:06] (03CR) 10Esanders: [C: 04-1] Reject activatingDeferred as soon as loadFail runs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321116 (owner: 10Esanders) [16:44:37] (03PS2) 10Esanders: Fix handling of failure to load visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321116 [23:34:47] (03CR) 10Jforrester: [C: 032] eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321110 (owner: 10Esanders) [23:37:21] (03CR) 10Jforrester: [C: 032] eslint: Re-enable wrap-iife and partially enable dot-notation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321109 (owner: 10Esanders) [23:43:33] (03Merged) 10jenkins-bot: eslint: Re-enable wrap-iife and partially enable dot-notation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321110 (owner: 10Esanders) [23:43:54] (03Merged) 10jenkins-bot: eslint: Re-enable wrap-iife and partially enable dot-notation [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321109 (owner: 10Esanders)