[02:37:49] (03CR) 10Divec: [C: 032] Avoid annotation set clones when unused [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321021 (owner: 10Esanders) [02:40:04] (03Merged) 10jenkins-bot: Avoid annotation set clones when unused [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321021 (owner: 10Esanders) [02:55:13] 10VisualEditor, 10Parsoid: Parsoid serialised an edit to a wikitext table adding a /n without stripping the double-pipes, breaking the table format (`\n|| align="right" | …`) - https://phabricator.wikimedia.org/T149209#2791541 (10ssastry) Another example to demonstrate bad serialization (from T149428#2790836)... [02:58:21] 10VisualEditor, 10VisualEditor-Tables, 10Parsoid: Inserting image into table in VisualEditor creates a line break in the table wikicode - https://phabricator.wikimedia.org/T149428#2791544 (10ssastry) >>! In T149428#2790836, @Esanders wrote: > The issue is `

` tags inside `` > ... > I think this is a Pa... [08:58:19] 10VisualEditor: Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2791790 (10Trizek-WMF) [09:24:55] 10VisualEditor: Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2791845 (10Trizek-WMF) [09:26:41] 10VisualEditor: Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2791790 (10Elitre) While testing in Chrome/Win 10, what happens on fr.wp or ko.wp is that you launch the gallery tool, then click on a picture. It doesn't load in the tool, you can write in the capt... [10:42:21] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2792012 (10Pginer-WMF) >>! In T55973#2789271, @matmarex wrote: >> As I understand it, the... [10:46:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Documentation: Update documentation for VE gadgets to include information about NWE - https://phabricator.wikimedia.org/T150081#2792023 (10Schnark) I just created https://www.mediawiki.org/wiki/VisualEditor/Gadgets/Add_a_tool. I didn't yet link i... [11:16:46] 10VisualEditor: Losing all progress when switching from Edit to Edit Source - https://phabricator.wikimedia.org/T150519#2792098 (10Joescull1) Yes it is running a previous version of mediaWiki, one version behind maybe. However due to many extensions not being compatible with the newest mediawiki and not wanting... [12:00:37] 10VisualEditor, 06Editing-Department, 10MediaWiki-extensions-ContentTranslation, 07Design, 07WorkType-NewFunctionality: Minimal requirements for first phase of implementation of VisualEditor integration into Content Translation - https://phabricator.wikimedia.org/T150652#2792172 (10Arrbee) [12:16:28] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2792226 (10matmarex) Another idea (strawman): If a wikilink's target is identical to labe... [12:27:31] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2792259 (10Amire80) >>! In T55973#2792226, @matmarex wrote: > Another idea (strawman): If... [13:47:55] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10Parsoid, 13Patch-For-Review: Parsoid/VE adds images with pointless link parameter - https://phabricator.wikimedia.org/T108504#1522184 (10Trizek-WMF) [[ https://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:%C3%89diteurVisuel/Avis&diff=0&oldid=131819592#... [14:24:05] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 10 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2748980 (10MoritzMuehlenhoff) Another nodejs-based service we're running is etherpad-lite (running etherpad.wikimedia.org), I've added @akosiaris to the ticket. [14:33:36] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 10 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2792476 (10akosiaris) That's gonna be a problem. Etherpad is practically unmaintained these days. The leading developer has moved on to other projects (http://mclear.co.uk... [14:42:53] (03PS2) 10Esanders: Always set mode when activating the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321115 [14:42:55] (03PS2) 10Esanders: Pass isModified when switching from VE to NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321080 [14:42:57] (03PS3) 10Esanders: Fix handling of failure to load visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321116 [15:11:07] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 10 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2792535 (10GWicke) @akosiaris, in the short term, I would propose to test if it works with node 6. The level of compatibility between 4 & 6 has been generally high with mo... [15:19:11] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 10 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2792545 (10MoritzMuehlenhoff) There's at least anecdotal evidence that it works/worked with 6.2: https://github.com/ether/etherpad-lite/issues/2956 [16:24:30] (03PS1) 10Esanders: Migrate DesktopWikitextArticleTarget code upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321386 [16:36:23] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2792689 (10DLynch) > This issue seems to happen when editing a link that uses the page ti... [16:46:03] (03CR) 10Jforrester: [C: 04-1] ve.ui.MergeCellsContextItem: Correct @extends documentation comment (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321226 (owner: 10Bartosz Dziewoński) [16:47:22] (03CR) 10Jforrester: [C: 032] Wrap attribute resolve in try-catch for IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321236 (https://phabricator.wikimedia.org/T148858) (owner: 10Esanders) [16:52:43] (03CR) 10Bartosz Dziewoński: ve.ui.MergeCellsContextItem: Correct @extends documentation comment (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321226 (owner: 10Bartosz Dziewoński) [16:54:41] (03Merged) 10jenkins-bot: Wrap attribute resolve in try-catch for IE [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321236 (https://phabricator.wikimedia.org/T148858) (owner: 10Esanders) [17:00:06] (03CR) 10DLynch: [C: 04-1] Add HTML blacklist for content which doesn't have a model type yet (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320763 (https://phabricator.wikimedia.org/T149714) (owner: 10Esanders) [17:32:45] (03PS1) 10Jforrester: Update VE core submodule to master (2bc2ddf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321394 [17:32:46] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (2bc2ddf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321394 (owner: 10Jforrester) [17:32:46] (03CR) 10Esanders: "Let's merge If9cc876a57272 next" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321394 (owner: 10Jforrester) [17:32:48] (03CR) 10Jforrester: [C: 032] Teardown the toolbar properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321082 (owner: 10Esanders) [17:32:54] (03Merged) 10jenkins-bot: Update VE core submodule to master (2bc2ddf) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321394 (owner: 10Jforrester) [17:32:55] (03Merged) 10jenkins-bot: Teardown the toolbar properly [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321082 (owner: 10Esanders) [17:43:34] 10VisualEditor: [Regression wmf.2] Cursor stays at the beginning of comment node instead of moving to the end of it after adding - https://phabricator.wikimedia.org/T150557#2792899 (10DLynch) I initially thought this might be c3d3d29, which changed the preview. However, at that point it was still selecting the n... [17:49:56] (03PS1) 10DLynch: ui.CommentInspector: Select placeholder comment node while editing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321399 (https://phabricator.wikimedia.org/T150557) [17:51:10] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Links, 07Design: VisualEditor: Link input widget should have separate inputs for target and display text - https://phabricator.wikimedia.org/T55973#2792916 (10Pginer-WMF) >>! In T55973#2792226, @matmarex wrote: > Another idea (strawman):... [19:04:47] (03CR) 10Esanders: [C: 032] extension.json: Bump MW requirement to 1.29 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321469 (owner: 10Jforrester) [19:14:58] (03CR) 10jenkins-bot: [V: 04-1] Update for API error i18n [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321462 (owner: 10Anomie) [19:15:30] (03Merged) 10jenkins-bot: extension.json: Bump MW requirement to 1.29 [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321469 (owner: 10Jforrester) [19:24:38] (03CR) 10Jforrester: [C: 031] "Fine to merge when this goes ahead." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321462 (owner: 10Anomie) [19:25:10] (03CR) 10Jforrester: [C: 031] "TD is master-only-compat. like VE, so you could do this the simpler way if you prefer." [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/321452 (owner: 10Anomie) [19:34:49] (03CR) 10Esanders: [C: 032] ui.CommentInspector: Select placeholder comment node while editing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321399 (https://phabricator.wikimedia.org/T150557) (owner: 10DLynch) [19:38:49] (03Merged) 10jenkins-bot: ui.CommentInspector: Select placeholder comment node while editing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321399 (https://phabricator.wikimedia.org/T150557) (owner: 10DLynch) [19:39:39] (03PS1) 10Jforrester: Update VE core submodule to master (f0c7873) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321475 (https://phabricator.wikimedia.org/T150557) [21:49:06] (03PS1) 10Esanders: Add ve.init.Target#isModeAvailable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321503 [21:56:04] (03PS2) 10Esanders: Add HTML blacklist for content which doesn't have a model type yet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320763 (https://phabricator.wikimedia.org/T149714) [22:00:05] (03CR) 10Jforrester: [C: 032] Add ve.init.Target#isModeAvailable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321503 (owner: 10Esanders) [22:03:21] (03Merged) 10jenkins-bot: Add ve.init.Target#isModeAvailable [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321503 (owner: 10Esanders) [22:04:26] (03CR) 10Esanders: [C: 032] ve.ui.MergeCellsContextItem: Correct @extends documentation comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321226 (owner: 10Bartosz Dziewoński) [22:06:37] (03Merged) 10jenkins-bot: ve.ui.MergeCellsContextItem: Correct @extends documentation comment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321226 (owner: 10Bartosz Dziewoński) [22:09:23] (03CR) 10Esanders: "can you update this?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321475 (https://phabricator.wikimedia.org/T150557) (owner: 10Jforrester) [22:13:51] (03PS2) 10Jforrester: Update VE core submodule to master (cf1a9c8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321475 [22:20:45] (03PS1) 10Tchanders: Normalise filename after image is chosen in gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321549 (https://phabricator.wikimedia.org/T150638) [22:22:22] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (cf1a9c8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321475 (owner: 10Jforrester) [22:28:21] (03PS1) 10Tchanders: Fix attribute.style typo in gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321551 [22:31:03] (03Merged) 10jenkins-bot: Update VE core submodule to master (cf1a9c8) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321475 (owner: 10Jforrester) [22:32:43] (03CR) 10Jforrester: [C: 031] Fix attribute.style typo in gallery dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321551 (owner: 10Tchanders) [22:33:17] (03CR) 10Jforrester: [C: 031] Normalise filename after image is chosen in gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321549 (https://phabricator.wikimedia.org/T150638) (owner: 10Tchanders) [22:41:02] (03PS2) 10Esanders: Migrate DesktopWikitextArticleTarget code upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321386 [22:41:04] (03PS3) 10Esanders: Always set mode when activating the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321115 [22:41:06] (03PS3) 10Esanders: Pass isModified when switching from VE to NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321080 [22:41:08] (03PS4) 10Esanders: Fix handling of failure to load visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321116 [22:47:25] (03CR) 10jenkins-bot: [V: 04-1] Migrate DesktopWikitextArticleTarget code upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321386 (owner: 10Esanders) [23:05:24] (03PS4) 10Esanders: Pass isModified when switching from VE to NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321080 (https://phabricator.wikimedia.org/T150707) [23:05:30] (03CR) 10Jforrester: [C: 032] Pass isModified when switching from VE to NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321080 (https://phabricator.wikimedia.org/T150707) (owner: 10Esanders) [23:07:35] (03CR) 10Jforrester: [C: 032] Always set mode when activating the target [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321115 (owner: 10Esanders) [23:08:22] (03CR) 10Jforrester: [C: 031] Fix handling of failure to load visual mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321116 (owner: 10Esanders) [23:08:55] (03CR) 10Jforrester: "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321386 (owner: 10Esanders) [23:14:47] (03Merged) 10jenkins-bot: Pass isModified when switching from VE to NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321080 (https://phabricator.wikimedia.org/T150707) (owner: 10Esanders)