[03:19:10] What could be the reason for receiving this message on the citation-tool: "The Template:Cite journal template doesn't yet have a description, but there might be some information on the template's page." ? [05:17:34] 10VisualEditor: Clicking on section link with NWE enabled and "Remember my last editor" set, prompts "Do you want to leave this site?" instead of opening NWE - https://phabricator.wikimedia.org/T151020#2804918 (10Ryasmeen) [05:22:24] 10VisualEditor: Clicking on section link opens OWE instead of NWE when Editing mode is set to "Always Source Editor" - https://phabricator.wikimedia.org/T151021#2804930 (10Ryasmeen) [05:27:02] 10VisualEditor: Getting "Error loading data from server: [object Object]" while trying to save an empty page with NWE - https://phabricator.wikimedia.org/T151022#2804942 (10Ryasmeen) [05:39:13] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2804957 (10jayvdb) See also {T150732}, for a specific area where our lack of modern communication system is hurting out outreach efforts, an... [08:41:09] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Moving from Visual Editor to Wikitext editor substitutes module invocation - https://phabricator.wikimedia.org/T144586#2805091 (10Strainu) @ssastry, I can reproduce it reliably on FF 49 on Windows. I think the trick is to edit the page in Visual Editor, **... [08:43:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Moving from Visual Editor to Wikitext editor substitutes module invocation - https://phabricator.wikimedia.org/T144586#2805106 (10Strainu) [10:12:19] Hi, I'm working at Wikia and our users really want to have newlines in the templates inserted from VE Template Dialog. I've checked that the VE used on Wikibooks doesn't have this feature so I guess we can't copy the solution but have to come with our own. [10:12:19] We've tried adding `\n` before each param in `ve.dm.MWTransclusionNode.prototype.getWikitext` (https://github.com/Wikia/app/commit/44a7c99cefa981fc56333f28844f216eb267c9ff) and it works only partially. [10:12:19] After specifying params in the Template Dialog and clicking Apply there is an API request sent: [10:12:19] ``` [10:12:19] Content-Disposition: form-data; name="action" [10:12:19] visualeditor [10:12:19] Content-Disposition: form-data; name="paction" [10:12:20] parsefragment [10:12:20] Content-Disposition: form-data; name="wikitext" [10:12:21] {{Navbox [10:12:21] |header=asdzxc [10:12:22] |body=wqeasd}} [10:12:48] 10VisualEditor: Categories moved by VE from the bottom of the article to a content section - https://phabricator.wikimedia.org/T151035#2805311 (10Trizek-WMF) [10:31:08] igor-wikia: hey. you can define the format in whcih the template will be serialized using TemplateData [10:31:39] https://www.mediawiki.org/wiki/Help:TemplateData#Description_and_parameters [10:32:01] (you need https://www.mediawiki.org/wiki/Extension:TemplateData#Format installed to use it) [10:32:13] https://www.mediawiki.org/wiki/Extension:TemplateData * [10:36:45] MatmaRex: Thanks for info but it requires MW 1.21+ and we're permanently stuck at 1.19.24 [10:37:04] I'll take a look at how this extension handles it, though [10:38:17] 10VisualEditor: "Start editing" popup should probably say "Continue editing" - https://phabricator.wikimedia.org/T135938#2805460 (10Nemo_bis) 05declined>03Open I agree that complex conditions are not required. It's enough to make the text accurate. [10:38:37] 10VisualEditor: "Start editing" popup interferes with talk page usage - https://phabricator.wikimedia.org/T135682#2805463 (10Nemo_bis) 05declined>03Open No reason seen above. [11:00:45] MatmaRex: In the TemplateData extension's code I found that it sets the format but doesn't really use it for adding newlines. In https://github.com/wikimedia/mediawiki-extensions-TemplateData/blob/master/Specification.md#316-format there is text "If the parameter is set to 'block', Consumers SHOULD create a wikitext representation with a single newline after the template invocation [11:00:45] and each parameter value" so it seems like it's handled in some other place, not the extension itself. Would you happen to know where that place is? [11:37:56] igor-wikia: in Parsoid [11:44:56] Yup, found it in https://github.com/wikimedia/parsoid/blob/737ed24891060617942ce3fe39d0e266ab888dc5/lib/html2wt/WikitextSerializer.js#L538. Thanks, I'll dig in there [12:20:10] 10VisualEditor, 10VisualEditor-MediaWiki, 07Performance: Investigate why VE is consistently **2-4X** slower to switch to Edit after switching back to Read the first time, compared to the first switch after load - https://phabricator.wikimedia.org/T127921#2805796 (10Aklapper) @Krinkle: Last call: Any input? O... [16:08:37] 10VisualEditor: What do I do with popup second link popup? - https://phabricator.wikimedia.org/T105206#2806365 (10Aklapper) 05stalled>03Open Answered in last comment; removing "stalled" status [16:25:04] Thanks again MatmaRex, I ended up adding newlines for every template invocation during serializing (https://github.com/Wikia/mediawiki-services-parsoid/pull/24/files) and it seems to work fine. This is not exactly what we wanted as it will ignore user's opinion and force a standard but maybe that's something we can live with. [16:26:27] If anyone has an idea how to fix the Insert Template Dialog itself, I'd still appreciate the help. In-depth description above. [18:06:37] 10TemplateData, 10VisualEditor: Parameters were alphabetized instead of following the expected order - https://phabricator.wikimedia.org/T150763#2806658 (10Whatamidoing-WMF) I can't reproduce this on enwiki. I wonder if the problem is language/script-specific. [18:58:43] 10VisualEditor: [Regression] Inconsistent display of images in Gallery when same image is added multiple times - https://phabricator.wikimedia.org/T150894#2806840 (10Ryasmeen) [18:59:23] 10VisualEditor: [Regression ?] Inconsistent display of images in Gallery when same image is added multiple times - https://phabricator.wikimedia.org/T150894#2800501 (10Ryasmeen) [19:07:58] Hmm. How do I pull down the TX list from inside VE? [19:10:13] Aha, ve.init.target.surfaces[0].model.undoStack [19:14:01] 10VisualEditor, 10VisualEditor-MediaWiki: [Regression wmf.3] None of the changes made to the Page Settings are getting saved, all the changes are getting reverted to Default Settings - https://phabricator.wikimedia.org/T151005#2806899 (10Jdforrester-WMF) p:05Triage>03Unbreak! The changes make it to the tra... [19:22:20] 10VisualEditor, 10MediaWiki-ResourceLoader: Create a system for registering modules to load if content changes asynchronously - https://phabricator.wikimedia.org/T139852#2806936 (10Krinkle) I agree with @matmarex. Extensions that lazy-load modules based on server-side checks would be calling addModules() accor... [19:37:09] 10VisualEditor, 10MediaWiki-ResourceLoader: Create a system for registering modules to load if content changes asynchronously - https://phabricator.wikimedia.org/T139852#2806998 (10Esanders) In this case I am using RESTBase to convert wikitext to HTML (to show preview in the new wikitext editor). [19:53:02] 10VisualEditor: What do I do with popup second link popup? - https://phabricator.wikimedia.org/T105206#2807045 (10Jdforrester-WMF) 05Open>03Invalid No response in over a year to question asking what is meant. [20:02:52] 10VisualEditor: What do I do with popup second link popup? - https://phabricator.wikimedia.org/T105206#2807063 (10Neil_P._Quinn_WMF) 05Invalid>03Open @Jdforrester-WMF, looking back on this, it seems pretty clear that the author of this task meant what @JAufrecht said above and my question was unnecessary. So... [20:25:05] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Create a system for registering modules to load if content changes asynchronously - https://phabricator.wikimedia.org/T139852#2807106 (10Krinkle) [20:26:50] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Create a system for registering modules to load if content changes asynchronously - https://phabricator.wikimedia.org/T139852#2444530 (10Krinkle) The client-side hooks would still work as long as VE triggers them. I'm not sure about the server-side ones. I im... [20:27:22] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Expose `modules` and `jsconfigvars` from Parse API in Parsoid when converting wikitext - https://phabricator.wikimedia.org/T139852#2807108 (10Krinkle) [21:03:29] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Expose `modules` and `jsconfigvars` from Parse API in Parsoid when converting wikitext - https://phabricator.wikimedia.org/T139852#2444530 (10ssastry) Parsoid adds module styles to the page (see [[ https://github.com/wikimedia/parsoid/blob/7fda6c45386993ec398... [21:35:16] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Moving from Visual Editor to Wikitext editor substitutes module invocation - https://phabricator.wikimedia.org/T144586#2807264 (10ssastry) Ah, okay. Reduced case for this is: ``` [subbu@earth parsoid] echo "[[File:Foo.jpg|link={{1x|http://google.com}}/foob... [21:36:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10Parsoid: Moving from Visual Editor to Wikitext editor substitutes module invocation - https://phabricator.wikimedia.org/T144586#2807265 (10ssastry) Dont remember if this is a known limitation, or something that we missed, or a regression. Anyway, to be investigated. [23:17:23] (03PS6) 10Krinkle: build: Bring over eg-iframe fixes from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215003 (https://phabricator.wikimedia.org/T109170) (owner: 10Esanders) [23:17:44] (03CR) 10Krinkle: [C: 031] "Rebased." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215003 (https://phabricator.wikimedia.org/T109170) (owner: 10Esanders) [23:19:02] (03CR) 10Krinkle: [C: 032] "Fixes the demo. Verified locally." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215003 (https://phabricator.wikimedia.org/T109170) (owner: 10Esanders) [23:24:46] 10VisualEditor, 10MediaWiki-Interface, 10Parsoid: Expose `modules` and `jsconfigvars` from Parse API in Parsoid when converting wikitext - https://phabricator.wikimedia.org/T139852#2807447 (10Esanders) `transform/wikitext/to/html` [23:25:28] 10VisualEditor, 10Continuous-Integration-Config, 07Documentation, 13Patch-For-Review: VisualEditor documentation examples on doc.wikimedia.org not working - https://phabricator.wikimedia.org/T109170#2807448 (10Jdforrester-WMF) 05Open>03Resolved [23:29:13] What could be the reason for receiving this message on the citation-tool when the Template:Cite journal does have TemplateData: "The Template:Cite journal template doesn't yet have a description, but there might be some information on the template's page." ? [23:29:27] (03Merged) 10jenkins-bot: build: Bring over eg-iframe fixes from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/215003 (https://phabricator.wikimedia.org/T109170) (owner: 10Esanders) [23:39:49] 10VisualEditor, 10Continuous-Integration-Config, 07Documentation, 13Patch-For-Review: VisualEditor documentation examples on doc.wikimedia.org not working - https://phabricator.wikimedia.org/T109170#2807492 (10Krinkle) Subsequent publish build successfully synced the new eg-iframe.html file, but it failed... [23:41:30] 10VisualEditor: Editing a gallery in VE with multiple copies of the same image drops the duplicates - https://phabricator.wikimedia.org/T151095#2807493 (10Arlolra) [23:43:21] 10VisualEditor, 10Continuous-Integration-Config, 07Documentation, 13Patch-For-Review: VisualEditor documentation examples on doc.wikimedia.org not working - https://phabricator.wikimedia.org/T109170#2807506 (10Krinkle) Looks like the mwext-VisualEditor-publish job need to be migrated to run on nodepool-jes... [23:56:33] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow: Opening help dialog in Flow VE (CTRL+?) throws an exception - https://phabricator.wikimedia.org/T151096#2807528 (10Esanders)