[00:19:03] (03PS1) 10Jforrester: Update OOjs UI to v0.18.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324360 [00:25:42] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 07Verified, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): In Gallery, the order of images in search result section changes randomly while trying to re-edit it - https://phabricator.wikimedia.org/T151659#2833720 (10Ryasmeen) [02:03:05] 10WikiEditor, 10Revision-Slider, 06TCB-Team, 03WMDE-QWERTY-Team-Board: Loading jquery.ui.draggable triggers deprecation warnings - https://phabricator.wikimedia.org/T151564#2833928 (10Krinkle) [02:04:49] 10WikiEditor, 10Revision-Slider, 06TCB-Team, 03WMDE-QWERTY-Team-Board: Loading jquery.ui.draggable triggers deprecation warnings - https://phabricator.wikimedia.org/T151564#2821183 (10Krinkle) (Removing ResourceLoader tag, ResourceLoader is the framework for defining and loading modules - it is not concern... [02:13:34] (03CR) 10Krinkle: [C: 032] extension.json: Remove dependency on json module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/322775 (owner: 10Jforrester) [02:13:50] (03PS1) 10Krinkle: Remove use of deprecated "json" module [extensions/Citoid] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324374 [02:14:54] (03Merged) 10jenkins-bot: extension.json: Remove dependency on json module [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/322775 (owner: 10Jforrester) [04:43:24] (03PS9) 10Divec: Factor out active node functionality from SectionNode for captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320068 (https://phabricator.wikimedia.org/T149753) (owner: 10Esanders) [04:53:39] (03CR) 10Divec: "It was our use of -moz-user-select in ve.ce.FocusableNode.css , which we weren't overriding in ve.ce.ActiveNode.css ." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320068 (https://phabricator.wikimedia.org/T149753) (owner: 10Esanders) [05:41:36] (03CR) 10Jforrester: [C: 031] Remove use of deprecated "json" module [extensions/Citoid] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324374 (owner: 10Krinkle) [07:05:20] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 07Design, and 5 others: reconsider terminology about template parameters in VisualEditor and ContentTranslation - https://phabricator.wikimedia.org/T151865#2834236 (10santhosh) a:03Amire80 [07:11:25] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 07Design, and 4 others: reconsider terminology about template parameters in VisualEditor and ContentTranslation - https://phabricator.wikimedia.org/T151865#2834244 (10Arrbee) [07:34:32] (03CR) 10Divec: "No, you're right that we originally said strings, then backtracked :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/305563 (owner: 10Divec) [10:14:06] (03PS1) 10Amire80: Clearer English for visualeditor-preference-newwikitexteditor-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 [10:43:04] (03PS18) 10Zfilipin: WIP Selenium test for loading VisualEditor [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320829 (https://phabricator.wikimedia.org/T150435) (owner: 10Ryasmeen) [10:52:22] 10VisualEditor, 10Wikimedia-General-or-Unknown: Stray wikitext markup prevented page from being edited via VisualEditor (http:// 400 error) - https://phabricator.wikimedia.org/T151942#2834466 (10Aklapper) [10:58:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery: Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2834499 (10Schnark) [11:50:36] (03PS1) 10Divec: Refactor ve.dm.Transaction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 [12:02:16] (03PS1) 10Esanders: Move 'mode' property to surface, rename target property to 'defaultMode' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324418 [12:26:06] (03CR) 10Esanders: [C: 04-1] "Nice" (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 (owner: 10Divec) [12:38:54] (03PS1) 10Esanders: Get edit mode from surface where possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 [12:45:46] (03CR) 10jenkins-bot: [V: 04-1] Get edit mode from surface where possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 (owner: 10Esanders) [12:52:19] (03CR) 10Esanders: [C: 04-1] "Doesn't this have a bug number?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324256 (owner: 10Jforrester) [12:53:32] (03CR) 10Esanders: "Given that all our documentation is English and this a dev tool I didn't think it was necessary. But meh." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323977 (owner: 10Jforrester) [12:56:14] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834743 (10Pginer-WMF) [12:57:12] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834756 (10Pginer-WMF) Here are some thoughts and a quick exploration. Thoughts: - Green and red bring intuitive associations with addition and substraction. they are used in oth... [12:57:15] (03CR) 10Esanders: "See comments on I23f1e0933023ed196b32af00d887674de21c5c4b" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323885 (owner: 10Jforrester) [12:57:50] (03CR) 10Esanders: "See comments on I23f1e0933023ed196b32af00d887674de21c5c4b" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323884 (owner: 10Jforrester) [12:58:36] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834759 (10Pginer-WMF) [13:00:19] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834743 (10Pginer-WMF) As a reference, here is another example: In Google docs suggestions a thicker semi-transparent green line is used for removals, and green text is used for... [13:07:22] 10VisualEditor: Search for sections in link inspector - https://phabricator.wikimedia.org/T152003#2834776 (10Trizek-WMF) [13:08:19] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834788 (10Pginer-WMF) [13:10:58] 10VisualEditor, 10VisualEditor-MediaWiki, 07Accessibility, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Consider using semantic elements in addition to colours for visual diffs - https://phabricator.wikimedia.org/T149702#2834793 (10Pginer-WMF) I created a separate ticket for the separate discussion: {T152001}.... [13:17:36] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2834833 (10Pginer-WMF) In a [[ https://ca.wikipedia.org/wiki/Viquiprojecte:Viquitrobada_2016 | recent event]] with editors of the Catalan Wikipedia , [[ https://ca.wikipedia.org/... [13:44:11] 10VisualEditor: Nowiki added to links that use article title plus a suffix - https://phabricator.wikimedia.org/T151628#2834878 (10Trizek-WMF) So that's due to an incorrect copy/pasting? [13:53:27] 10VisualEditor, 10Wikimedia-General-or-Unknown: Stray wikitext markup prevented page from being edited via VisualEditor (http:// 400 error) - https://phabricator.wikimedia.org/T151942#2834893 (10Trizek-WMF) >>! In T151942#2834380, @Qgil wrote: > At least @Trizek-WMF and I run into this problem. He took a scree... [14:00:06] 10VisualEditor: MediaWiki:Visualeditor-feedback-link can't work on zhwiki - https://phabricator.wikimedia.org/T152007#2834909 (10Shizhao) [14:01:33] 10VisualEditor: MediaWiki:Visualeditor-feedback-link can't work on zhwiki - https://phabricator.wikimedia.org/T152007#2834927 (10Shizhao) [14:30:56] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2835001 (10Esanders) Copying my comment from the previous bug: >>! In T149702#2820166, @Pginer-WMF wrote: >>>! In T149702#2818990, @Esanders wrote: >> The problem with using stri... [14:34:52] 10VisualEditor, 10VisualEditor-MediaWiki, 07Accessibility, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Consider using semantic elements in addition to colours for visual diffs - https://phabricator.wikimedia.org/T149702#2835016 (10Esanders) >>! In T149702#2832097, @Jdforrester-WMF wrote: > No. People who want... [15:10:29] 10VisualEditor, 07Design: Design a way to present content changes in a rich text context - https://phabricator.wikimedia.org/T152001#2835078 (10Pginer-WMF) >>! In T152001#2835001, @Esanders wrote: > As we aren't using a custom edit surface it won't be very easy to change the colour of the strikethrough, or hav... [15:18:01] RoanKattouw: how does this work when Parsoid HTML isn't XML? https://gerrit.wikimedia.org/r/#/c/160583/ [15:23:25] (03PS2) 10Esanders: Get edit mode from surface where possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 [15:26:05] edsanders: That's not supposed to happen I think? [15:26:15] Parsoid claims that their HTML is also valid XML AFAIK [15:26:58] I couldn't see it on https://www.mediawiki.org/wiki/Specs/HTML/1.2.1 [15:31:08] (03CR) 10jenkins-bot: [V: 04-1] Get edit mode from surface where possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 (owner: 10Esanders) [15:31:42] To be fair I now realize I may not actually have told them that we were making this assumption [15:31:54] Though they did assure me that it was a safe assumption to make I think [15:38:07] (03PS3) 10Esanders: Get edit mode from surface where possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 [15:43:45] (03CR) 10jenkins-bot: [V: 04-1] Get edit mode from surface where possible [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 (owner: 10Esanders) [16:07:41] (03CR) 10Divec: Refactor ve.dm.Transaction (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 (owner: 10Divec) [16:08:09] (03PS2) 10Divec: Refactor ve.dm.Transaction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 [16:17:17] (03CR) 10Divec: Refactor ve.dm.Transaction (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 (owner: 10Divec) [16:21:24] (03PS3) 10Divec: Refactor ve.dm.Transaction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 [16:24:24] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2835260 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03High a:03Esanders Ouch. Ha... [16:25:18] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2835270 (10Jdforrester-WMF) a:05Esanders>03Tchanders [16:47:08] (03CR) 10Jforrester: [C: 031] Move 'mode' property to surface, rename target property to 'defaultMode' (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324418 (owner: 10Esanders) [17:11:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Drag-and-drop of image from the file page into VisualEditor should insert a thumbnail, not an external link - https://phabricator.wikimedia.org/T151647#2835433 (10matmarex) No, dragging and dropping an image file from your computer sti... [17:25:08] (03PS1) 10DLynch: Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) [17:25:17] (03CR) 10jenkins-bot: [V: 04-1] Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) [17:26:53] (03PS2) 10DLynch: Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) [17:30:13] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-Gallery, 05WMF-deploy-2016-11-29_(1.29.0-wmf.4): Editing a gallery without "File:" prefixes throws JS error in VE - https://phabricator.wikimedia.org/T151992#2835546 (10Jdforrester-WMF) Sorry, wrong patch previously; it'll roll out tomorrow. [17:41:22] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Copy-paste of wikitext from "Use this file" on Commons into VisualEditor does not work when the filename is too long because it's limited for performance - https://phabricator.wikimedia.org/T151646#2835591 (10matmarex) Right, so this was act... [17:45:14] (03CR) 10Jforrester: "> Doesn't this have a bug number?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324256 (owner: 10Jforrester) [17:45:37] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: Copy-paste of wikitext from "Use this file" on Commons into VisualEditor does not work when the filename is too long because it's limited for performance - https://phabricator.wikimedia.org/T151646#2835613 (10matmarex) >>! In T151646#2832480... [18:08:02] (03PS1) 10Bartosz Dziewoński: ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324514 (https://phabricator.wikimedia.org/T151646) [18:08:22] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 13Patch-For-Review: Copy-paste of wikitext from "Use this file" on Commons into VisualEditor does not work when the filename is too long because it's limited for performance - https://phabricator.wikimedia.org/T151646#2835686 (10matmarex)... [18:21:37] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOjs UI to v0.18.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324360 (owner: 10Jforrester) [18:25:20] (03CR) 10Jforrester: [C: 04-1] "We should be consistent. "80" is the length we limit for the others…" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324514 (https://phabricator.wikimedia.org/T151646) (owner: 10Bartosz Dziewoński) [18:26:02] 10Cite: Invalid HTML markup standalone LI element when using references on main page - https://phabricator.wikimedia.org/T73023#2835759 (10phuedx) [18:26:35] 10Cite: Invalid HTML markup standalone LI element when using references on main page - https://phabricator.wikimedia.org/T73023#766851 (10phuedx) 05Open>03stalled [18:26:52] (03CR) 10Jforrester: [C: 04-1] "I don't like this wording, it feels unnatural. What's unclear about the current form, and can we change it to make it clearer for you?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 (owner: 10Amire80) [18:27:34] (03CR) 10Bartosz Dziewoński: "By "others", you mean "only headings", and I think headings are sufficiently different than links. (And '==' is probably slightly more lik" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324514 (https://phabricator.wikimedia.org/T151646) (owner: 10Bartosz Dziewoński) [18:29:00] (03Merged) 10jenkins-bot: Update OOjs UI to v0.18.1 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324360 (owner: 10Jforrester) [18:31:19] (03PS4) 10Jforrester: [WIP Failing test case] Cursoring over empty alienInline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280683 (https://phabricator.wikimedia.org/T123608) [18:33:14] (03CR) 10Jforrester: "The underlying issue is still broken in both Chrome and Firefox for two of the use cases David mentioned:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280683 (https://phabricator.wikimedia.org/T123608) (owner: 10Jforrester) [18:37:08] (03CR) 10Amire80: "Mmm... It might be very stupid of me to argue with an English speaker, but here goes." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 (owner: 10Amire80) [18:42:30] (03PS1) 10Esanders: wrapAllNodes in sourcefragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324524 [18:42:32] (03PS1) 10Esanders: Core source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 [18:42:51] (03PS1) 10Esanders: Inherit more functionality from core source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324526 [18:48:57] (03CR) 10Esanders: "It doesn't ready too badly as it, but we could make the last 'and' a 'and also', or separate the third point into another sentence." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 (owner: 10Amire80) [18:50:54] (03CR) 10Esanders: [C: 031] ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324514 (https://phabricator.wikimedia.org/T151646) (owner: 10Bartosz Dziewoński) [18:53:57] (03CR) 10Esanders: [C: 032] Refactor ve.dm.Transaction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 (owner: 10Divec) [18:56:06] (03PS1) 10Esanders: Use getApi in title widget [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324531 [18:57:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP Failing test case] Cursoring over empty alienInline nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/280683 (https://phabricator.wikimedia.org/T123608) (owner: 10Jforrester) [18:57:47] (03Merged) 10jenkins-bot: Refactor ve.dm.Transaction [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324415 (owner: 10Divec) [19:03:28] (03PS1) 10Esanders: Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324535 [19:06:00] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2835913 (10AlexMonk-WMF) I did some digging and found https://gerrit.wikimedia.org/r/#/c/323090/2 pr... [19:06:41] (03CR) 10jenkins-bot: [V: 04-1] Inherit more functionality from core source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324526 (owner: 10Esanders) [19:19:01] 10VisualEditor, 10Graphs, 03Interactive-Sprint, 13Patch-For-Review: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2702951 (10debt) Hi @CKoerner_WMF - this came up during our sprint planning...should this be one release or two and what do we need to do for community inv... [19:19:13] 10VisualEditor: MediaWiki:Visualeditor-feedback-link can't work on zhwiki - https://phabricator.wikimedia.org/T152007#2834909 (10Stryn) https://phabricator.wikimedia.org/T125400#1998584 [19:22:42] (03CR) 10Esanders: Move 'mode' property to surface, rename target property to 'defaultMode' (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324418 (owner: 10Esanders) [19:30:09] (03CR) 10Jforrester: [C: 032] Move 'mode' property to surface, rename target property to 'defaultMode' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324418 (owner: 10Esanders) [19:34:37] (03CR) 10Jforrester: [C: 032] Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324535 (owner: 10Esanders) [19:34:38] (03Merged) 10jenkins-bot: Move 'mode' property to surface, rename target property to 'defaultMode' [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324418 (owner: 10Esanders) [19:38:19] (03CR) 10Jforrester: "Hmm, I suppose it's a little overly-colloquial to re-use the verb once? What about:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 (owner: 10Amire80) [19:40:16] (03Merged) 10jenkins-bot: Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324535 (owner: 10Esanders) [19:49:20] (03CR) 10Jforrester: "Cute, but unfortunately selection, B, I creates "Foo" (good) but then "<b>foo</b>" :-(" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) [19:49:27] (03CR) 10Jforrester: [C: 04-1] Core source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) [19:50:23] (03CR) 10Jforrester: [C: 031] build: Load OOjs from npm as a dependency, not from lib/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323353 (owner: 10Divec) [19:51:48] (03PS2) 10Jforrester: MWTemplateTitleInputWidget: Use new #getApi method from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324531 (owner: 10Esanders) [19:51:54] (03CR) 10Jforrester: [C: 032] MWTemplateTitleInputWidget: Use new #getApi method from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324531 (owner: 10Esanders) [19:54:53] (03CR) 10Jforrester: [C: 031] wrapAllNodes in sourcefragment (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324524 (owner: 10Esanders) [19:58:03] (03CR) 10Esanders: [C: 04-1] "Per last comment. This would break live documentation examples, amongst the other metioned things." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323353 (owner: 10Divec) [19:59:39] (03CR) 10Esanders: "Yes, and links are broken, and headings etc." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) [20:04:27] (03Merged) 10jenkins-bot: MWTemplateTitleInputWidget: Use new #getApi method from upstream [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324531 (owner: 10Esanders) [20:08:55] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2836177 (10Tchanders) Yes indeed - thanks for pointing that out. It was a problem with any gallery w... [20:33:44] 10VisualEditor, 10Graphs, 03Interactive-Sprint, 13Patch-For-Review: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2836285 (10CKoerner_WMF) I'd say separate. This release/task is about the frame and attributes for the graph. Let's keep things separate and smaller to dig... [20:39:46] (03PS1) 10Esanders: Bring in source mode WindowAction hacks from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 [20:44:20] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 07Design: "Add new image" button in gallery is difficult to discover after adding 4/5 images, since the button floats down as the list grows - https://phabricator.wikimedia.org/T151506#2836297 (10Tchanders) a:03Tchanders [20:53:32] (03CR) 10Catrope: [C: 04-1] Rebase logic (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 (owner: 10Divec) [21:15:17] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): Impossible to create a gallery on some wikis using VE - https://phabricator.wikimedia.org/T150638#2836460 (10AlexMonk-WMF) 05Open>03Resolved [21:20:22] (03PS26) 10Catrope: [WIP] docserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309812 [21:20:50] (03CR) 10jenkins-bot: [V: 04-1] [WIP] docserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309812 (owner: 10Catrope) [21:51:00] (03PS1) 10Tchanders: Fix "Add new image" button in the gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324604 (https://phabricator.wikimedia.org/T151506) [21:54:08] (03PS2) 10Tchanders: Fix "Add new image" button in the gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324604 (https://phabricator.wikimedia.org/T151506) [21:58:01] (03CR) 10Amire80: "> Hmm, I suppose it's a little overly-colloquial to re-use the verb" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 (owner: 10Amire80) [21:59:31] (03PS2) 10Amire80: Clearer English for visualeditor-preference-newwikitexteditor-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 [22:05:00] (03PS1) 10Jforrester: Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324609 [22:07:03] (03CR) 10Jforrester: [C: 032] Clearer English for visualeditor-preference-newwikitexteditor-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 (owner: 10Amire80) [22:12:42] (03CR) 10jenkins-bot: [V: 04-1] Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324609 (owner: 10Jforrester) [22:19:31] (03PS1) 10Esanders: Remove WikitextWindowAction, inherits from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324615 [22:28:16] (03CR) 10Divec: Rebase logic (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 (owner: 10Divec) [22:29:02] (03PS8) 10Divec: Rebase logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 [22:29:15] (03CR) 10jenkins-bot: [V: 04-1] Rebase logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 (owner: 10Divec) [22:30:15] (03Merged) 10jenkins-bot: Clearer English for visualeditor-preference-newwikitexteditor-description [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324393 (owner: 10Amire80) [22:32:22] (03CR) 10jenkins-bot: [V: 04-1] Remove WikitextWindowAction, inherits from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324615 (owner: 10Esanders) [22:32:41] (03PS9) 10Divec: Rebase logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 [22:34:44] (03CR) 10Esanders: [C: 04-1] "Looks good - suggested minor layout tweak." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324604 (https://phabricator.wikimedia.org/T151506) (owner: 10Tchanders) [22:38:23] (03PS3) 10Tchanders: Fix "Add new image" button in the gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324604 (https://phabricator.wikimedia.org/T151506) [22:39:10] (03CR) 10Tchanders: Fix "Add new image" button in the gallery dialog (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324604 (https://phabricator.wikimedia.org/T151506) (owner: 10Tchanders) [22:40:19] 10VisualEditor, 10VisualEditor-MediaWiki: GalleryDialog: Items should scroll into view when selected - https://phabricator.wikimedia.org/T152053#2836662 (10Esanders) [22:52:10] (03CR) 10Alex Monk: Prevent endless error loop if falling back to wikitext (after a load failure) fails. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321908 (owner: 10Alex Monk) [22:56:25] (03PS5) 10Alex Monk: Batch gallery imageinfo requests via ImageInfoCache subclass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313605 (https://phabricator.wikimedia.org/T147067) [22:56:33] (03CR) 10jenkins-bot: [V: 04-1] Batch gallery imageinfo requests via ImageInfoCache subclass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313605 (https://phabricator.wikimedia.org/T147067) (owner: 10Alex Monk) [22:56:54] (03PS6) 10Alex Monk: Batch gallery imageinfo requests via ImageInfoCache subclass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313605 (https://phabricator.wikimedia.org/T147067) [22:57:05] (03CR) 10jenkins-bot: [V: 04-1] Batch gallery imageinfo requests via ImageInfoCache subclass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313605 (https://phabricator.wikimedia.org/T147067) (owner: 10Alex Monk) [23:02:05] (03PS7) 10Alex Monk: Batch gallery imageinfo requests via ImageInfoCache subclass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313605 (https://phabricator.wikimedia.org/T147067) [23:02:57] (03PS43) 10Divec: WIP Surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [23:15:48] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery: GalleryDialog: Items should scroll into view when selected - https://phabricator.wikimedia.org/T152053#2836751 (10Jdforrester-WMF) p:05Triage>03Normal [23:47:30] (03CR) 10Esanders: "That CSS was for a specific Firefox bug T70537, no need to add it to other browsers if they already work." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320068 (https://phabricator.wikimedia.org/T149753) (owner: 10Esanders) [23:49:15] (03PS3) 10Tchanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 [23:50:39] (03CR) 10Esanders: [C: 031] "Firefox fix looks good. Let's merge this and worry about the spanning selection another day (soon)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320068 (https://phabricator.wikimedia.org/T149753) (owner: 10Esanders) [23:51:27] (03PS2) 10Esanders: Make table caption node an active node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321232 [23:52:14] (03CR) 10Esanders: "Next commit (WindowAction) fixes links." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) [23:55:24] (03CR) 10jenkins-bot: [V: 04-1] WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (owner: 10Tchanders) [23:55:29] (03CR) 10Esanders: [C: 031] Batch gallery imageinfo requests via ImageInfoCache subclass [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/313605 (https://phabricator.wikimedia.org/T147067) (owner: 10Alex Monk) [23:57:27] (03CR) 10Esanders: Prevent endless error loop if falling back to wikitext (after a load failure) fails. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321908 (owner: 10Alex Monk)