[00:01:40] <grrrit-wm>	 (03CR) 10Esanders: "If the -1 is for the tools not working when HTML is selected, I don't intend to fix that yet. The purpose of this commit is to move more l" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) 
[00:02:45] <grrrit-wm>	 (03PS2) 10Esanders: Bring in source mode WindowAction hacks from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 
[00:02:47] <grrrit-wm>	 (03PS2) 10Esanders: Core source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 
[00:02:49] <grrrit-wm>	 (03PS1) 10Esanders: SourceSurfaceFragment: Check range is not collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324629 
[00:04:11] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] i18n: Kill last two uses of 'parameter' in lieu of 'field' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324256 (owner: 10Jforrester) 
[00:08:59] <grrrit-wm>	 (03PS27) 10Divec: [WIP] docserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309812 (owner: 10Catrope) 
[00:09:50] <grrrit-wm>	 (03PS28) 10Divec: [WIP] docserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309812 (owner: 10Catrope) 
[00:11:10] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] Save Dialog: add shortcut for opening to the review panel (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[00:13:16] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "You missed the table headings - but I don't think we want to translate stuff like that." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323977 (owner: 10Jforrester) 
[00:14:00] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Fix "Add new image" button in the gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324604 (https://phabricator.wikimedia.org/T151506) (owner: 10Tchanders) 
[00:14:08] <James_F>	 edsanders: I only looked at src/, yes.
[00:14:36] <edsanders>	 ?
[00:15:07] <edsanders>	 they're in the same file, just in a big HTML string
[00:15:44] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Remove use of deprecated "json" module [extensions/Citoid] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324374 (owner: 10Krinkle) 
[00:18:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: DebugBar: Remove hard-coded i18n [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323977 (owner: 10Jforrester) 
[00:19:32] <grrrit-wm>	 (03Merged) 10jenkins-bot: i18n: Kill last two uses of 'parameter' in lieu of 'field' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324256 (owner: 10Jforrester) 
[00:20:15] <grrrit-wm>	 (03CR) 10Esanders: [C: 031] Remove use of deprecated "json" module [extensions/Citoid] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324374 (owner: 10Krinkle) 
[00:20:54] <edsanders>	 James_F, Err, is this a branch I shouldn't +2 on: https://gerrit.wikimedia.org/r/#/c/324374/1 ?
[00:22:09] <James_F>	 edsanders: Oooh, hmm.
[00:22:19] <James_F>	 edsanders: Yes, don't +2 wmf.* branches unless you're deploying.
[00:22:59] <grrrit-wm>	 (03CR) 10Jforrester: DebugBar: Remove hard-coded i18n (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323977 (owner: 10Jforrester) 
[00:24:18] <grrrit-wm>	 (03CR) 10Jforrester: "> If the -1 is for the tools not working when HTML is selected, I don't intend to fix that yet. The purpose of this commit is to move more" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) 
[00:25:49] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix "Add new image" button in the gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324604 (https://phabricator.wikimedia.org/T151506) (owner: 10Tchanders) 
[00:42:00] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Factor out active node functionality from SectionNode for captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320068 (https://phabricator.wikimedia.org/T149753) (owner: 10Esanders) 
[00:42:18] <grrrit-wm>	 (03CR) 10DLynch: Save Dialog: add shortcut for opening to the review panel (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[00:44:07] <grrrit-wm>	 (03PS3) 10DLynch: Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) 
[00:44:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Factor out active node functionality from SectionNode for captions [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/320068 (https://phabricator.wikimedia.org/T149753) (owner: 10Esanders) 
[00:47:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[00:48:43] <grrrit-wm>	 (03PS4) 10DLynch: Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) 
[00:48:56] <Kemayo>	 Trailing commas in JSON, y'know.
[00:52:40] * James_F grins.
[00:56:23] <James_F>	 Kemayo: The best bit is that HHVM's JSON interpreter thinks that trailing commas are valid.
[00:59:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[01:02:47] <Kemayo>	 I think it's just that the test harness fell over a bit that time.
[01:05:41] <James_F>	 It's it great that everything's so reliable and stable?
[01:11:06] <grrrit-wm>	 (03CR) 10Krinkle: [C: 032] Remove use of deprecated "json" module [extensions/Citoid] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324374 (owner: 10Krinkle) 
[01:11:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove use of deprecated "json" module [extensions/Citoid] (wmf/1.29.0-wmf.4) - 10https://gerrit.wikimedia.org/r/324374 (owner: 10Krinkle) 
[01:19:49] <grrrit-wm>	 (03CR) 10Esanders: Save Dialog: add shortcut for opening to the review panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[01:40:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Make table caption node an active node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321232 (owner: 10Esanders) 
[01:44:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make table caption node an active node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/321232 (owner: 10Esanders) 
[03:50:35] <grrrit-wm>	 (03PS44) 10Divec: WIP Surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) 
[03:50:59] <grrrit-wm>	 (03PS29) 10Divec: [WIP] docserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309812 (owner: 10Catrope) 
[04:09:18] <grrrit-wm>	 (03CR) 10DLynch: Save Dialog: add shortcut for opening to the review panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[06:14:43] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-References: Reusing a citation and replacing the reference list template removes the original citation - https://phabricator.wikimedia.org/T152070#2837320 (10neilpquinn)
[06:16:22] <wikibugs_>	 10VisualEditor, 10VisualEditor-MediaWiki-References: Reusing a citation and replacing the reference list template removes the original citation - https://phabricator.wikimedia.org/T152070#2837336 (10neilpquinn)
[08:47:57] <wikibugs_>	 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Wikidata, and 2 others: CX and VisualEditor template editors are not aware of parameters that can be auto-filled from Wikidata - https://phabricator.wikimedia.org/T152082#2837612 (10Amire80)
[09:00:06] <wikibugs>	 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Wikidata, and 2 others: CX and VisualEditor template editors are not aware of parameters that can be auto-filled from Wikidata - https://phabricator.wikimedia.org/T152082#2837612 (10Kippelboy) Maybe we could somehow add a markup o...
[10:45:32] <wikibugs>	 10TemplateData, 10VisualEditor: Provide more information error than "Bad JSON format" - https://phabricator.wikimedia.org/T152086#2837837 (10Mvolz)
[10:48:56] <wikibugs_>	 10TemplateData, 10VisualEditor: Provide more information error than "Bad JSON format" in GUI TD editor - https://phabricator.wikimedia.org/T152086#2837853 (10Mvolz)
[10:49:05] <wikibugs>	 10TemplateData, 10VisualEditor: Provide more information error than "Bad JSON format" in GUI TD editor - https://phabricator.wikimedia.org/T152086#2837837 (10Mvolz)
[10:49:17] <wikibugs_>	 10TemplateData, 10VisualEditor: Provide more information about error "Bad JSON format" in GUI TD editor - https://phabricator.wikimedia.org/T152086#2837837 (10Mvolz)
[10:49:44] <wikibugs_>	 10TemplateData, 10VisualEditor: Provide more information about error "Bad JSON format" in GUI TD editor - https://phabricator.wikimedia.org/T152086#2837837 (10Mvolz) p:05Triage>03Low
[12:12:19] <wikibugs_>	 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Wikidata, and 2 others: CX and VisualEditor template editors are not aware of parameters that can be auto-filled from Wikidata - https://phabricator.wikimedia.org/T152082#2837939 (10Amire80) Thanks, @Kippelboy. The question is wha...
[12:25:41] <wikibugs_>	 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 10Wikidata: TemplateData: TemplateData should have a parameter to support Wikidata - https://phabricator.wikimedia.org/T69659#713126 (10Amire80) A very closely related issue: T138219.
[12:26:26] <wikibugs>	 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 10Wikidata, and 2 others: CX and VisualEditor template editors are not aware of parameters that can be auto-filled from Wikidata - https://phabricator.wikimedia.org/T152082#2837952 (10Amire80) A closely related issue: {T69659}.
[12:39:35] <wikibugs>	 10TemplateData, 10VisualEditor: Template Data allowing invalid JSON to be saved. - https://phabricator.wikimedia.org/T152090#2837965 (10Mvolz)
[15:50:43] <Elitre>	 Krenair: any chance https://www.mediawiki.org/w/index.php?title=Topic:Tg05soh213o8tnt0&topic_showPostId=tg05soh217mb1rr8#flow-post-tg05soh217mb1rr8 is related to recent issues such as https://phabricator.wikimedia.org/T150638 ?
[16:13:21] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] WIP Surface synchronizer (sockets) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) 
[16:14:00] <wikibugs_>	 10TemplateData, 10VisualEditor: Template Data allowing invalid JSON to be saved. - https://phabricator.wikimedia.org/T152090#2837965 (10Jdforrester-WMF) Yeah, this a bug caused by our production use of HHVM combined with its loose configuration: {T128029}. :-(
[16:14:06] <wikibugs>	 10TemplateData, 10VisualEditor: Template Data allowing invalid JSON to be saved. - https://phabricator.wikimedia.org/T152090#2838530 (10Jdforrester-WMF)
[16:14:09] <wikibugs_>	 10TemplateData, 10VisualEditor, 07HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2061803 (10Jdforrester-WMF)
[16:16:57] <grrrit-wm>	 (03CR) 10Catrope: WIP Surface synchronizer (sockets) (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) 
[16:17:29] <grrrit-wm>	 (03PS1) 10Esanders: Use DOMPurify to sanitize incoming HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 
[16:24:55] <grrrit-wm>	 (03CR) 10Jforrester: "Need to add to AUTHORS.txt which has all the licences and libraries." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 (owner: 10Esanders) 
[16:27:48] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 07Design, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): "Add new image" button in gallery is difficult to discover after adding 4/5 images, since the button floats down as the list grows - https://phabricator.wikimedia.org/T151506#2838566 (10J...
[16:28:29] <wikibugs_>	 10TemplateData, 10VisualEditor: Provide more information about error "Bad JSON format" in GUI TD editor - https://phabricator.wikimedia.org/T152086#2838568 (10Mvolz) 05Open>03Invalid
[16:31:01] <grrrit-wm>	 (03CR) 10Esanders: "Yes - we have the same bug in MW. If you select '''foo''' and make it a link you get nowikis. This is a known issue. In most cases it's fi" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) 
[16:31:34] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Core source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) 
[16:31:56] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Oops, thought I'd +2'ed this yesterday." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324524 (owner: 10Esanders) 
[16:37:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: wrapAllNodes in sourcefragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324524 (owner: 10Esanders) 
[16:37:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Core source mode [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324525 (owner: 10Esanders) 
[16:41:17] <grrrit-wm>	 (03CR) 10Esanders: "That one's already been fixed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) 
[16:42:49] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] "Given there are no uses of this in VE-core yet, should we rename handlesWikitext first?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 (owner: 10Esanders) 
[16:43:37] <grrrit-wm>	 (03PS2) 10Jforrester: SourceSurfaceFragment: Check range is not collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324629 (owner: 10Esanders) 
[16:43:46] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] SourceSurfaceFragment: Check range is not collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324629 (owner: 10Esanders) 
[16:47:14] <grrrit-wm>	 (03PS2) 10Esanders: Use DOMPurify to sanitize incoming HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 
[16:49:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: SourceSurfaceFragment: Check range is not collapsed [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324629 (owner: 10Esanders) 
[16:52:58] <wikibugs_>	 10VisualEditor, 10Parsoid, 13Patch-For-Review: Parsoid serialised an edit to a wikitext table adding a /n without stripping the double-pipes, breaking the table format (`\n|| align="right" | …`) - https://phabricator.wikimedia.org/T149209#2745376 (10ssastry) a:03ssastry
[16:53:27] <wikibugs>	 10VisualEditor, 10Parsoid, 13Patch-For-Review: Parsoid serialised an edit to a wikitext table adding a /n without stripping the double-pipes, breaking the table format (`\n|| align="right" | …`) - https://phabricator.wikimedia.org/T149209#2745376 (10ssastry) 05Open>03Resolved This code has been merged an...
[17:08:41] <grrrit-wm>	 (03CR) 10Divec: WIP Surface synchronizer (sockets) (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) 
[17:09:20] <grrrit-wm>	 (03PS45) 10Divec: WIP Surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) 
[18:44:22] <grrrit-wm>	 (03PS2) 10Jforrester: Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324609 
[18:44:24] <grrrit-wm>	 (03PS4) 10Jforrester: Update VE core submodule to master (ae30d71) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 (owner: 10Esanders) 
[18:44:55] <grrrit-wm>	 (03PS2) 10Jforrester: Inherit more functionality from core source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324526 (owner: 10Esanders) 
[19:08:19] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Inherit more functionality from core source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324526 (owner: 10Esanders) 
[19:08:24] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (ae30d71) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 (owner: 10Esanders) 
[19:20:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update VE core submodule to master (ae30d71) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324423 (owner: 10Esanders) 
[19:20:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Inherit more functionality from core source mode [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324526 (owner: 10Esanders) 
[19:24:17] <grrrit-wm>	 (03PS1) 10Esanders: [BREAKING CHANGE] Parse selection before applying source tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324777 
[19:24:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324514 (https://phabricator.wikimedia.org/T151646) (owner: 10Bartosz Dziewoński) 
[19:31:51] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324609 (owner: 10Jforrester) 
[19:35:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: ve.ui.MWWikitextTransferRegistry: Just look for '[[' when detecting links [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324514 (https://phabricator.wikimedia.org/T151646) (owner: 10Bartosz Dziewoński) 
[19:44:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use canonical ve.dm.TransactionBuilder.static.newFrom* methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324609 (owner: 10Jforrester) 
[20:08:43] <grrrit-wm>	 (03PS1) 10DLynch: DesktopArticleTarget: Rebuild the category links when they're edited [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324786 (https://phabricator.wikimedia.org/T151651) 
[20:12:26] <grrrit-wm>	 (03CR) 10Divec: "I now think we should abandon, based on Ed's point - running off source code copies (e.g. https://cdn.rawgit.com/wikimedia/VisualEditor/ma" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323353 (owner: 10Divec) 
[20:22:10] <wikibugs_>	 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 10 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2839551 (10Yurik)
[20:38:36] <wikibugs>	 10VisualEditor: VisualEditor breaking tabber and comments parser extension tags - https://phabricator.wikimedia.org/T152137#2839632 (10StarWarden)
[21:03:48] <grrrit-wm>	 (03PS1) 10Esanders: Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 
[21:06:35] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 (owner: 10Esanders) 
[21:09:56] <grrrit-wm>	 (03CR) 10Alex Monk: Prevent endless error loop if falling back to wikitext (after a load failure) fails. (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321908 (owner: 10Alex Monk) 
[21:11:51] <grrrit-wm>	 (03PS3) 10Esanders: Use DOMPurify to sanitize incoming HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 
[21:12:28] <wikibugs>	 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): Copy-paste of wikitext from "Use this file" on Commons into VisualEditor does not work when the filename is too long because it's limited for perform... - https://phabricator.wikimedia.org/T151646#2839771
[21:26:23] <grrrit-wm>	 (03CR) 10Jforrester: [C: 031] Rebase logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 (owner: 10Divec) 
[21:26:49] <grrrit-wm>	 (03Abandoned) 10Jforrester: build: Load OOjs from npm as a dependency, not from lib/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323353 (owner: 10Divec) 
[21:26:51] <grrrit-wm>	 (03Abandoned) 10Jforrester: build: Load jQuery from npm as a dependency, not from lib/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323884 (owner: 10Jforrester) 
[21:27:02] <grrrit-wm>	 (03Abandoned) 10Jforrester: build: Load OOjs UI from npm as a dependency, not from lib/ [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/323885 (owner: 10Jforrester) 
[21:32:02] <grrrit-wm>	 (03PS2) 10Esanders: [BREAKING CHANGE] Parse selection before applying source tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324777 
[21:32:04] <grrrit-wm>	 (03PS3) 10Esanders: Bring in source mode WindowAction hacks from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 
[21:32:06] <grrrit-wm>	 (03PS2) 10Esanders: Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 
[21:36:11] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Rebase logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 (owner: 10Divec) 
[21:38:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 (owner: 10Esanders) 
[21:41:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Rebase logic [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/322714 (owner: 10Divec) 
[22:14:25] <wikibugs_>	 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery, 07Design, and 2 others: "Add new image" button in gallery is difficult to discover after adding 4/5 images, since the button floats down as the list grows - https://phabricator.wikimedia.org/T151506#2840076 (10Ryasmeen)
[22:34:14] <grrrit-wm>	 (03CR) 10Esanders: WIP Surface synchronizer (sockets) (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) 
[22:43:08] <wikibugs>	 10VisualEditor: Searching for templates in VE throws error "Uncaught TypeError: this.getApi is not a function" - https://phabricator.wikimedia.org/T152154#2840132 (10Ryasmeen)
[22:50:41] <grrrit-wm>	 (03PS1) 10Esanders: Implement convertFromSource/convertToSource in WikitextSurfaceFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 
[22:51:05] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement convertFromSource/convertToSource in WikitextSurfaceFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 (owner: 10Esanders) 
[22:54:35] <grrrit-wm>	 (03PS1) 10Alex Monk: Use widget.getApi, not this.getApi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324823 (https://phabricator.wikimedia.org/T152154) 
[22:56:15] <wikibugs_>	 10VisualEditor, 13Patch-For-Review: Searching for templates in VE throws error "Uncaught TypeError: this.getApi is not a function" - https://phabricator.wikimedia.org/T152154#2840163 (10AlexMonk-WMF) a:03AlexMonk-WMF yep. specifically when you get a valid result back. caused by https://gerrit.wikimedia.org/r...
[22:56:36] <grrrit-wm>	 (03CR) 10Alex Monk: "caused T152154" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324531 (owner: 10Esanders) 
[23:06:59] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] Prevent endless error loop if falling back to wikitext (after a load failure) fails. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321908 (owner: 10Alex Monk) 
[23:12:24] <grrrit-wm>	 (03CR) 10Esanders: [C: 04-1] DesktopArticleTarget: Rebuild the category links when they're edited (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324786 (https://phabricator.wikimedia.org/T151651) (owner: 10DLynch) 
[23:17:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Prevent endless error loop if falling back to wikitext (after a load failure) fails. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/321908 (owner: 10Alex Monk) 
[23:18:00] <grrrit-wm>	 (03CR) 10Esanders: Save Dialog: add shortcut for opening to the review panel (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[23:27:06] <wikibugs_>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: [Regression pre-wmf.5] Searching for templates in VE throws error "Uncaught TypeError: this.getApi is not a function"  - https://phabricator.wikimedia.org/T152154#2840251 (10Jdforrester-WMF) p:05Triage>03High
[23:27:12] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] "Oops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324823 (https://phabricator.wikimedia.org/T152154) (owner: 10Alex Monk) 
[23:27:29] <wikibugs>	 10VisualEditor, 10VisualEditor-MediaWiki-Templates: [Regression pre-wmf.5] Searching for templates in VE throws error "Uncaught TypeError: this.getApi is not a function" - https://phabricator.wikimedia.org/T152154#2840132 (10Jdforrester-WMF) 05Open>03Resolved
[23:38:37] <grrrit-wm>	 (03CR) 10DLynch: Save Dialog: add shortcut for opening to the review panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[23:42:58] <grrrit-wm>	 (03CR) 10Esanders: Save Dialog: add shortcut for opening to the review panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[23:43:00] <grrrit-wm>	 (03CR) 10DLynch: DesktopArticleTarget: Rebuild the category links when they're edited (033 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324786 (https://phabricator.wikimedia.org/T151651) (owner: 10DLynch) 
[23:43:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use widget.getApi, not this.getApi [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324823 (https://phabricator.wikimedia.org/T152154) (owner: 10Alex Monk) 
[23:43:39] <grrrit-wm>	 (03CR) 10Esanders: [C: 032] "recheck" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[23:44:42] <grrrit-wm>	 (03PS2) 10DLynch: DesktopArticleTarget: Rebuild the category links when they're edited [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324786 (https://phabricator.wikimedia.org/T151651) 
[23:46:19] <grrrit-wm>	 (03CR) 10Esanders: DesktopArticleTarget: Rebuild the category links when they're edited (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324786 (https://phabricator.wikimedia.org/T151651) (owner: 10DLynch) 
[23:49:15] <grrrit-wm>	 (03PS3) 10DLynch: DesktopArticleTarget: Rebuild the category links when they're edited [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324786 (https://phabricator.wikimedia.org/T151651) 
[23:53:28] <grrrit-wm>	 (03PS3) 10Esanders: [BREAKING CHANGE] Parse selection before applying source tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324777 
[23:53:30] <grrrit-wm>	 (03PS3) 10Esanders: Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 
[23:55:09] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) 
[23:59:09] <grrrit-wm>	 (03PS2) 10Jforrester: Clear preview when document is modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323859 (owner: 10Esanders)