[00:06:39] (03CR) 10jenkins-bot: [V: 04-1] Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 (owner: 10Esanders) [00:08:57] Can anyone tell what's actually breaking here? https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit-jessie/17734/consoleFull [00:09:39] Wait, wait, I think I see it. [00:11:44] 23:49:27 Chrome 53.0.2785 (Linux 0.0.0) ERROR: 'TypeError: Cannot read property 'static' of undefined', TypeError{} [00:12:17] Via the good old "ohhh, scroll further up from where the failure is" method. [00:16:23] (03PS5) 10DLynch: Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) [00:24:53] Kemayo: Isn't it lovely? ;-) [00:25:16] (03CR) 10Jforrester: [C: 032] "Per Ed." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) [00:36:35] It's also the Jenkins qunit environment being sufficiently different from things like "grunt test" that I don't actually get the error locally. [00:36:41] (03Merged) 10jenkins-bot: Save Dialog: add shortcut for opening to the review panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324501 (https://phabricator.wikimedia.org/T149914) (owner: 10DLynch) [01:18:11] (03CR) 10Esanders: "I blame the reviewer..." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324823 (https://phabricator.wikimedia.org/T152154) (owner: 10Alex Monk) [01:22:55] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/322714/ merged BTW. :-) [01:23:15] Kemayo: Yup. [01:28:41] Oh nice [02:34:25] (03CR) 10DLynch: [C: 032] Clear preview when document is modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323859 (owner: 10Esanders) [02:45:29] (03Merged) 10jenkins-bot: Clear preview when document is modified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323859 (owner: 10Esanders) [03:16:43] 10VisualEditor, 10VisualEditor-MediaWiki-Templates, 07Verified, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5): [Regression pre-wmf.5] Searching for templates in VE throws error "Uncaught TypeError: this.getApi is not a function" - https://phabricator.wikimedia.org/T152154#2840769 (10Ryasmeen) [06:52:43] (03PS4) 10Divec: Use DOMPurify to sanitize incoming HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 (owner: 10Esanders) [06:55:42] (03CR) 10Divec: "I rebased this directly onto master, as it doesn't depend on the surface synchronizer/docserver" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 (owner: 10Esanders) [06:57:29] (03CR) 10Divec: [C: 032] Use DOMPurify to sanitize incoming HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 (owner: 10Esanders) [07:00:45] (03Merged) 10jenkins-bot: Use DOMPurify to sanitize incoming HTML [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324742 (owner: 10Esanders) [07:09:33] (03CR) 10Divec: WIP Surface synchronizer (sockets) (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [07:09:39] (03PS46) 10Divec: WIP Surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [07:11:31] (03PS47) 10Divec: Surface synchronizer (sockets) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [07:13:40] (03PS30) 10Divec: [WIP] docserver [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/309812 (owner: 10Catrope) [09:25:05] 10VisualEditor, 06Collaboration-Team-Triage, 10Flow, 10Notifications, 10Wikimedia-Developer-Summit (2017): Tackling Chat - https://phabricator.wikimedia.org/T149661#2841096 (10Qgil) In terms of room capacity and configuration, what would be your preference? * The biggest room in theater configuration (u... [09:26:02] 10VisualEditor, 06Collaboration-Team-Triage, 06Editing-Department, 10Editing-UX-Research, and 4 others: Next Steps for Real Time Collaboration - https://phabricator.wikimedia.org/T149663#2841098 (10Qgil) In terms of room capacity and configuration, what would be your preference? * The biggest room in thea... [10:16:25] (03CR) 10Hashar: "check experimental" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/163847 (owner: 10Hashar) [14:02:24] (03PS1) 10Esanders: Update and fix DOMPurify library, fix IE9 return type issues [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324907 [14:48:50] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 4 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2841635 (10mobrovac) >>! In T108646#2761433, @Pchelolo wrote: > Moving to blocked until the `basefields` question is resolved. We have decided on the PR that we shall... [14:52:50] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2841648 (10faidon) Citoid is already fronted by our #Traffic infrastructure (Varnish), which is obviously a layer capable of caching, with cache hits there being obvio... [15:19:52] (03CR) 10Esanders: "Looks good - a few functions missing documentation (low priority)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [15:26:33] (03CR) 10Esanders: "It would also be good if the unit tests ran the domNodeArray path." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324907 (owner: 10Esanders) [15:44:49] (03PS1) 10Esanders: Basic unit tests for article/section nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324924 [16:26:00] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2841876 (10GWicke) @faidon: Request rates are very low, and have a wide spread. By the time a given URL or DOI is requested again, the response will very likely have f... [17:04:04] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2841986 (10mobrovac) [17:04:48] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1526094 (10mobrovac) @Mvolz would you mind looking into making the Citoid extension using the RESTBase endpoint instead of placing a call to `citoid.wikimedia.org` ? [17:24:37] 10Citoid, 10VisualEditor: Change requests in extension to new RESTBase endpoint. - https://phabricator.wikimedia.org/T152220#2842076 (10Mvolz) [17:24:40] 10Citoid, 10VisualEditor: Change requests in citoid extension to new RESTBase endpoint. - https://phabricator.wikimedia.org/T152220#2842092 (10Mvolz) [17:25:44] 10Citoid, 10VisualEditor, 06Community-Tech: Change reftoolbar to make requests to new RESTbase service. - https://phabricator.wikimedia.org/T152221#2842093 (10Mvolz) [17:26:04] 10Citoid, 10VisualEditor, 06Community-Tech: Change reftoolbar to make requests to new citoid RESTbase service. - https://phabricator.wikimedia.org/T152221#2842108 (10Mvolz) [17:27:20] 10Citoid, 10VisualEditor, 06Community-Tech: Change reftoolbar to make requests to new citoid RESTbase service. - https://phabricator.wikimedia.org/T152221#2842093 (10Mvolz) Paging @kaldari :). [17:48:03] 10Citoid, 10VisualEditor, 10MediaWiki-Page-editing: Implementation of form driven bibliographic reference editing for wiki articles. - https://phabricator.wikimedia.org/T8535#2842131 (10mobrovac) [17:48:05] 10Citoid, 10VisualEditor, 07Epic, 13Patch-For-Review, 15User-mobrovac: Add ISBN as look-up option to the citoid service - https://phabricator.wikimedia.org/T1084#2842129 (10mobrovac) 05stalled>03Open [17:48:55] (03CR) 10Jforrester: [C: 031] "Misses dm.SectionNode#toDomElements where the style attribute isn't set, ce.SectionNode#getTagName with an invalid style, and calls to ce." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324924 (owner: 10Esanders) [18:06:15] (03PS2) 10Jforrester: DOMPurify: Use pre-release & add fix, and fix IE9 return type issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324907 (owner: 10Esanders) [18:06:20] (03CR) 10Jforrester: [C: 032] DOMPurify: Use pre-release & add fix, and fix IE9 return type issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324907 (owner: 10Esanders) [18:10:19] (03Merged) 10jenkins-bot: DOMPurify: Use pre-release & add fix, and fix IE9 return type issue [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324907 (owner: 10Esanders) [18:14:55] 10TemplateData, 10VisualEditor: Parameters were alphabetized instead of following the expected order - https://phabricator.wikimedia.org/T150763#2842199 (10Whatamidoing-WMF) This has been reported on enwiki: [[https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=752598063#Visual_ed... [18:15:25] 10TemplateData, 10VisualEditor: Parameters were rearranged instead of following the expected order, defined in TemplateData - https://phabricator.wikimedia.org/T150763#2842200 (10Whatamidoing-WMF) [18:28:24] 10VisualEditor, 10VisualEditor-MediaWiki-Media: Gallery tool adds undocumented "classes" parameter - https://phabricator.wikimedia.org/T152226#2842204 (10Whatamidoing-WMF) [18:36:40] (03PS4) 10Esanders: [BREAKING CHANGE] Parse selection before applying source tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324777 [18:36:42] (03PS4) 10Esanders: Bring in source mode WindowAction hacks from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 [18:36:44] (03PS4) 10Esanders: Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 [18:39:26] (03PS2) 10Esanders: Remove WikitextWindowAction, inherits from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324615 [18:39:28] (03PS2) 10Esanders: Implement convertFromSource/convertToSource in WikitextSurfaceFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 [18:40:09] (03CR) 10Esanders: "Done." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 (owner: 10Esanders) [18:51:36] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Internet-Explorer, 07Regression, 05WMF-deploy-2016-11-15_(1.29.0-wmf.3): [Regression 1.28.0-wmf.15] Programmatic document change (e.g. make bold) causes scroll to top in IE<=11 - https://phabricator.wikimedia.org/T150450#2842304 (10Esanders... [18:57:55] (03CR) 10jenkins-bot: [V: 04-1] Add #convertNodes to SourceSurfaceFragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 (owner: 10Esanders) [18:58:46] (03CR) 10Jforrester: [C: 032] Bring in source mode WindowAction hacks from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 (owner: 10Esanders) [19:00:36] (03CR) 10jenkins-bot: [V: 04-1] Implement convertFromSource/convertToSource in WikitextSurfaceFragment [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 (owner: 10Esanders) [19:00:37] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery: Gallery tool adds undocumented "classes" parameter - https://phabricator.wikimedia.org/T152226#2842357 (10Jdforrester-WMF) p:05Triage>03High [19:03:52] (03Merged) 10jenkins-bot: Bring in source mode WindowAction hacks from MW [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324554 (owner: 10Esanders) [19:08:15] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TemplateData editor can't be launched from NWE - https://phabricator.wikimedia.org/T152230#2842369 (10Esanders) [19:16:31] James_F: citoid should be working on test [19:17:35] edsanders: Nice. Thank you. [19:18:38] just pointed it at citoid.wikimedia.org instead of faffing around with opening ports [19:36:08] (03PS1) 10Esanders: Follow-up I3b0483a7d: Fix append loop in PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324960 (https://phabricator.wikimedia.org/T151511) [19:37:33] RoanKattouw: what happens is you move a node between documents without using importNode? [19:42:37] 10VisualEditor, 10VisualEditor-MediaWiki-References, 13Patch-For-Review, 07Regression: [Regression 1.29.0-wmf.2] Only every second node displayed in footnote flyout in VE - https://phabricator.wikimedia.org/T151511#2842455 (10Jdforrester-WMF) a:03Esanders [19:48:30] edsanders: (Also answered in hangouts) I don't know, maybe nothing, maybe bad things, may depend on the browser. I suggest not trying [19:49:45] (03CR) 10DLynch: [C: 032] Follow-up I3b0483a7d: Fix append loop in PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324960 (https://phabricator.wikimedia.org/T151511) (owner: 10Esanders) [19:53:07] (03PS3) 10Jforrester: Remove WikitextWindowAction, inherits from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324615 (owner: 10Esanders) [19:53:09] (03PS1) 10Jforrester: Update VE core submodule to master (c9619a0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324964 [19:54:06] (03Merged) 10jenkins-bot: Follow-up I3b0483a7d: Fix append loop in PreviewElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324960 (https://phabricator.wikimedia.org/T151511) (owner: 10Esanders) [19:55:12] (03PS1) 10Esanders: PreviewElement: Use adoptNode when moving rendering to view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324966 [19:57:36] (03CR) 10Catrope: [C: 032] PreviewElement: Use adoptNode when moving rendering to view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324966 (owner: 10Esanders) [20:01:55] (03CR) 10Jforrester: [C: 032] Remove WikitextWindowAction, inherits from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324615 (owner: 10Esanders) [20:03:15] (03CR) 10Esanders: DesktopArticleTarget: Rebuild the category links when they're edited (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324786 (https://phabricator.wikimedia.org/T151651) (owner: 10DLynch) [20:03:29] (03Merged) 10jenkins-bot: PreviewElement: Use adoptNode when moving rendering to view [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324966 (owner: 10Esanders) [20:10:43] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TemplateData editor can't be launched from NWE - https://phabricator.wikimedia.org/T152230#2842515 (10Esanders) The 'edit templatedata' should probably be in the toolbar, but we're running out of space [20:22:10] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TemplateData editor can't be launched from NWE - https://phabricator.wikimedia.org/T152230#2842369 (10Jdforrester-WMF) Put it in "Insert" like for Templates? [20:38:17] 10Citoid, 10VisualEditor, 06Community-Tech: Change reftoolbar to make requests to new citoid RESTbase service. - https://phabricator.wikimedia.org/T152221#2842598 (10kaldari) a:03kaldari [20:42:03] (03CR) 10Jforrester: [C: 031] "Shall we get this merged now and add documentation in a follow-up, rather than risk the rebase fun?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/303572 (owner: 10Esanders) [21:03:21] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (c9619a0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324964 (owner: 10Jforrester) [21:16:58] (03Merged) 10jenkins-bot: Update VE core submodule to master (c9619a0) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324964 (owner: 10Jforrester) [21:17:00] (03Merged) 10jenkins-bot: Remove WikitextWindowAction, inherits from core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324615 (owner: 10Esanders) [21:21:27] (03PS1) 10Jforrester: Update VE core submodule to master (af7fb69) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325028 [21:22:31] (03CR) 10Jforrester: [C: 032] [BREAKING CHANGE] Parse selection before applying source tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324777 (owner: 10Esanders) [21:25:57] (03Merged) 10jenkins-bot: [BREAKING CHANGE] Parse selection before applying source tools [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324777 (owner: 10Esanders) [21:35:29] (03PS3) 10Jforrester: Update VE core submodule to master (5be61ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 (owner: 10Esanders) [21:45:20] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2842822 (10kaldari) [21:45:21] 10Citoid, 10VisualEditor, 06Community-Tech: Change reftoolbar to make requests to new citoid RESTbase service. - https://phabricator.wikimedia.org/T152221#2842820 (10kaldari) 05Open>03Resolved Done and deployed. [21:46:43] (03PS5) 10Jforrester: SourceSurfaceFragment: Add #convertNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 (owner: 10Esanders) [21:47:20] (03CR) 10Jforrester: [C: 032] "PS5: Removed stray \n that was causing this to fail eslint. :-)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 (owner: 10Esanders) [21:52:11] (03Merged) 10jenkins-bot: SourceSurfaceFragment: Add #convertNodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/324800 (owner: 10Esanders) [22:05:22] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (5be61ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 (owner: 10Esanders) [22:05:46] (03PS1) 10Esanders: build: Replace jscs/jshint with eslint [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/325043 [22:05:53] (03PS2) 10Jforrester: Update VE core submodule to master (af7fb69) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325028 (https://phabricator.wikimedia.org/T151511) [22:13:10] (03CR) 10Jforrester: [C: 032] build: Replace jscs/jshint with eslint [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/325043 (owner: 10Esanders) [22:15:51] (03Merged) 10jenkins-bot: build: Replace jscs/jshint with eslint [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/325043 (owner: 10Esanders) [22:31:41] (03PS1) 10Jforrester: Follow-up ae8a2750: Stop passing long-dead second parameter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325047 [22:55:12] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (af7fb69) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325028 (https://phabricator.wikimedia.org/T151511) (owner: 10Jforrester) [23:04:59] (03Merged) 10jenkins-bot: Update VE core submodule to master (af7fb69) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325028 (https://phabricator.wikimedia.org/T151511) (owner: 10Jforrester)