[00:35:37] in the VE documentation, it says "Note that the bi-directional switching functionality requires RESTbase installation rather than talking directly to Parsoid." [00:35:39] why? [03:44:00] (03PS4) 10Jforrester: Update VE core submodule to master (5be61ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 (owner: 10Esanders) [03:44:15] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (5be61ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 (owner: 10Esanders) [03:54:55] (03Merged) 10jenkins-bot: Update VE core submodule to master (5be61ce) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/324821 (owner: 10Esanders) [06:43:44] 10VisualEditor, 06Editing-Department, 10MediaWiki-Page-editing, 06Performance-Team: Investigate bad_token statsd spikes - https://phabricator.wikimedia.org/T109797#2843753 (10Krinkle) 05Open>03declined 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki: TemplateData editor can't be launched from NWE - https://phabricator.wikimedia.org/T152230#2842369 (10Schnark) I'd expect it in the "page options" dropdown menu. [13:03:46] (03PS1) 10Tchanders: Correct class/classes typo in gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325098 (https://phabricator.wikimedia.org/T152226) [14:02:43] 10Citoid, 10VisualEditor, 07Easy, 03Google-Code-In-2016: Add reading in of html "lang" property to html-metadata's parseGeneral method - https://phabricator.wikimedia.org/T148303#2843934 (10FilipGCI) a:03FilipGCI I'll make it for GCI [14:34:12] 10Citoid, 10VisualEditor, 07Easy, 03Google-Code-In-2016: 'npm test' failing on Citoid extension - https://phabricator.wikimedia.org/T152289#2844011 (10Mvolz) [14:34:23] 10Citoid, 10VisualEditor, 07Easy, 03Google-Code-In-2016: 'npm test' failing on Citoid extension - https://phabricator.wikimedia.org/T152289#2844024 (10Mvolz) p:05Triage>03Low [14:36:58] 10Citoid, 10VisualEditor, 07Easy, 03Google-Code-In-2016: 'npm test' failing on Citoid extension - https://phabricator.wikimedia.org/T152289#2844029 (10Mvolz) 05Open>03Invalid [15:00:42] 10VisualEditor: Height of images in slideshow is not changing. - https://phabricator.wikimedia.org/T151482#2818815 (10Tchanders) There is a slightly complicated reason for this... The gallery tag's height attribute doesn't have an effect in slideshow mode: https://en.wikipedia.org/wiki/Help:Gallery_tag#Attribut... [15:09:22] 10VisualEditor: Height of images in slideshow is not changing. - https://phabricator.wikimedia.org/T151482#2844110 (10Tchanders) It would be less confusing if the gallery dialog disabled height, width, etc in the modes that they don't apply to. [15:10:47] (03CR) 10Esanders: [C: 032] Correct class/classes typo in gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325098 (https://phabricator.wikimedia.org/T152226) (owner: 10Tchanders) [15:20:54] (03Merged) 10jenkins-bot: Correct class/classes typo in gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325098 (https://phabricator.wikimedia.org/T152226) (owner: 10Tchanders) [15:31:31] (03PS1) 10Esanders: Follow-up Iaa41c49e2f: Fix `this` context in window action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325101 [15:37:52] (03PS1) 10Tchanders: Disable heights option in gallery dialog when mode is slideshow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325102 (https://phabricator.wikimedia.org/T151482) [15:47:51] (03PS1) 10Tchanders: Scroll highlighted item into view in gallery dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325103 (https://phabricator.wikimedia.org/T152053) [16:02:21] (03PS2) 10Tchanders: Disable heights option in gallery dialog when mode is slideshow [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325102 (https://phabricator.wikimedia.org/T151482) [16:20:11] (03PS1) 10Esanders: Abstract out $textbox manipulation form UI [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/325105 (https://phabricator.wikimedia.org/T152230) [16:29:53] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 10MediaWiki-Gallery: Gallery dialog's search results aspect ratio is different to the media dialog's search results - https://phabricator.wikimedia.org/T151509#2819688 (10Tchanders) I think this is because the space in the gallery dialog is narrower. After play... [16:39:20] (03PS1) 10Tchanders: Decrease height of gallery search results for better fit [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325108 (https://phabricator.wikimedia.org/T151509) [16:48:46] (03CR) 10Jforrester: [C: 032] Follow-up Iaa41c49e2f: Fix `this` context in window action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325101 (owner: 10Esanders) [16:51:15] (03Merged) 10jenkins-bot: Follow-up Iaa41c49e2f: Fix `this` context in window action [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325101 (owner: 10Esanders) [16:53:25] (03CR) 10Tchanders: "8.45am in SF and James beats me to it..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325101 (owner: 10Esanders) [17:13:40] (03PS1) 10Esanders: NWE: Disable progress bar when pre-parsing for WindowAction's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325110 [17:19:53] (03CR) 10Esanders: "This unbreaks all dialogs in NWE :/" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325110 (owner: 10Esanders) [17:20:18] (03PS1) 10Esanders: Bypass API call when wikitext is empty string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325111 [17:20:31] (03PS2) 10Jforrester: NWE: Disable progress bar when pre-parsing for WindowAction's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325110 (owner: 10Esanders) [17:23:39] (03PS1) 10Esanders: Use faster batchPush in #insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325113 [17:25:12] (03PS1) 10Esanders: Don't wait for fragmentPromise before closing open windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325114 [17:27:08] (03CR) 10Jforrester: [C: 032] NWE: Disable progress bar when pre-parsing for WindowAction's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325110 (owner: 10Esanders) [17:31:39] (03PS1) 10Esanders: Update VE core submodule to master (aa8ef3e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325115 [17:35:32] (03CR) 10Jforrester: [C: 032] Bypass API call when wikitext is empty string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325111 (owner: 10Esanders) [17:36:08] (03CR) 10Jforrester: [C: 032] Don't wait for fragmentPromise before closing open windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325114 (owner: 10Esanders) [17:36:50] (03PS5) 10Jforrester: WIP Edit image captions in place [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/320070 (https://phabricator.wikimedia.org/T149753) (owner: 10Esanders) [17:37:16] (03Merged) 10jenkins-bot: NWE: Disable progress bar when pre-parsing for WindowAction's [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325110 (owner: 10Esanders) [17:39:45] (03Merged) 10jenkins-bot: Don't wait for fragmentPromise before closing open windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325114 (owner: 10Esanders) [17:40:45] (03CR) 10Jforrester: [C: 032] Update VE core submodule to master (aa8ef3e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325115 (owner: 10Esanders) [17:44:05] (03PS2) 10Jforrester: Bypass API call when wikitext is empty string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325111 (owner: 10Esanders) [17:44:10] (03CR) 10Jforrester: [C: 032] Bypass API call when wikitext is empty string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325111 (owner: 10Esanders) [17:45:29] (03CR) 10Jforrester: [C: 031] Use faster batchPush in #insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325113 (owner: 10Esanders) [17:50:18] (03Merged) 10jenkins-bot: Update VE core submodule to master (aa8ef3e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325115 (owner: 10Esanders) [17:51:09] (03CR) 10DLynch: [C: 032] Use faster batchPush in #insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325113 (owner: 10Esanders) [17:53:29] (03Merged) 10jenkins-bot: Use faster batchPush in #insertContent [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325113 (owner: 10Esanders) [17:56:20] (03Merged) 10jenkins-bot: Bypass API call when wikitext is empty string [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325111 (owner: 10Esanders) [19:14:06] (03PS4) 10Tchanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 [19:22:51] (03CR) 10jenkins-bot: [V: 04-1] WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (owner: 10Tchanders) [23:32:57] (03PS1) 10Esanders: Bypass fragment parsing for non-fragment windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325135 [23:46:46] (03PS2) 10Esanders: Bypass fragment parsing for non-fragment windows [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325135 [23:49:04] (03PS1) 10Esanders: SaveDialog inherits from plain dialog, not FragmentDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325139 [23:56:02] (03CR) 10jenkins-bot: [V: 04-1] SaveDialog inherits from plain dialog, not FragmentDialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325139 (owner: 10Esanders)