[02:50:53] 10VisualEditor, 10VisualEditor-Tables: Cannot add columns to tables in VisualEditor - https://phabricator.wikimedia.org/T152659#2856327 (10gpaumier) [02:54:03] (03PS4) 10Catrope: ApiVisualEditorEdit: ApiParse ignores 'page' when 'oldid' is supplied [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325641 (https://phabricator.wikimedia.org/T152547) (owner: 10Anomie) [02:54:48] (03CR) 10Catrope: [V: 040 C: 032] ApiVisualEditorEdit: ApiParse ignores 'page' when 'oldid' is supplied [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325641 (https://phabricator.wikimedia.org/T152547) (owner: 10Anomie) [02:54:54] (03CR) 10jenkins-bot: [V: 040 C: 040] ApiVisualEditorEdit: ApiParse ignores 'page' when 'oldid' is supplied [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325641 (https://phabricator.wikimedia.org/T152547) (owner: 10Anomie) [02:55:00] 10VisualEditor, 10VisualEditor-Tables: Cannot add columns to tables in VisualEditor - https://phabricator.wikimedia.org/T152659#2856348 (10gpaumier) I just noticed that the two tables I experienced this issue with had either missing or merged cells. Adding the missing cell fixed the issue in the former case (I... [02:57:17] (03Abandoned) 10Catrope: ApiVisualEditor: Clean up giant switch statement [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309237 (owner: 10Catrope) [03:07:53] (03Merged) 10jenkins-bot: ApiVisualEditorEdit: ApiParse ignores 'page' when 'oldid' is supplied [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/325641 (https://phabricator.wikimedia.org/T152547) (owner: 10Anomie) [03:24:07] (03CR) 10Jforrester: "David C., from a brief perusal this might indeed be non-WIP, but Roan and I thought that you should have a think about each of the "subdoc" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [03:56:10] (03CR) 10Gergő Tisza: [C: 032] Update for API error i18n [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/321452 (owner: 10Anomie) [03:58:40] (03Merged) 10jenkins-bot: Update for API error i18n [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/321452 (owner: 10Anomie) [07:34:18] 10VisualEditor, 10MediaWiki-Uploading, 06Multimedia, 13Patch-For-Review: "A file with name "$1" already exists in the shared file repository, and cannot be overwritten" shows up while trying to rename a file with single letter which is different from stand... - https://phabricator.wikimedia.org/T115946#2856528 [07:43:59] 10VisualEditor, 10Parsoid: selflinks aren't marked as selflinks in VisualEditor - https://phabricator.wikimedia.org/T152665#2856542 (10Florian) [09:22:45] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Empty lines are deleted when pasting text - https://phabricator.wikimedia.org/T152671#2856669 (10Schnark) [11:39:30] 10TemplateData, 10VisualEditor, 07HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2856839 (10Mvolz) I was able to save something with multiple keys, is this the same issue? https://es.wikipedia.org/w/in... [11:40:43] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2856843 (10Mvolz) [12:50:02] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2856937 (10Mvolz) [13:09:37] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References: Long links in reference context don't wrap - https://phabricator.wikimedia.org/T152680#2856942 (10Esanders) [13:15:12] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 10RESTBase, 06Services (watching): Wikitext surface needs an etag to use RESTBase - https://phabricator.wikimedia.org/T142861#2856961 (10Esanders) Yesh - if you are using wikitext mode only we fetch wikitext directly f... [13:18:00] mooeypoo: I am trying to edit td by hand in he wiki *cries* [13:53:14] 10Citoid, 10VisualEditor: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2857006 (10Mvolz) [13:53:26] when I scroll the page, the toolbar of visualeditor weirdly floats around, how to control that feature? [13:53:37] something sets an absolute position for it [13:54:02] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design: Convert plain references of type URL to rich references in one click using Citoid - https://phabricator.wikimedia.org/T114564#2857007 (10Esanders) Example: {F5010914,size=full} [14:44:24] Krenair, RoanKattouw: In the edit API I can set 'section' to 'new' to create a new section, but in the revisions API if I set 'rvsection' to 'new' it doesn't recognise it. Is there a way to do this? [14:45:09] arguably showing a diff for a new section is pointless - but the old editor allows for it... [14:45:50] and it would parse substitutions [14:47:32] 10VisualEditor, 10VisualEditor-MediaWiki-References: Highlight the string of text for which the reference is provided - https://phabricator.wikimedia.org/T152685#2857095 (10Juandev) [14:51:25] 10VisualEditor, 10VisualEditor-MediaWiki-References: When first reference is added, add reflist automaticaly in VisualEditor - https://phabricator.wikimedia.org/T152686#2857115 (10Juandev) [14:59:17] 10TemplateData, 10VisualEditor, 07HHVM: TemplateData's PHP JSON validation isn't strict enough because WMF cluster's HHVM allows trailing commas - https://phabricator.wikimedia.org/T128029#2857150 (10Mvolz) Another json validation issue, it's very hard to see in this diff, but there was an extra closing } in... [16:25:08] 10VisualEditor, 10MediaWiki-API, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): [Regression pre-wmf.6] Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together." - https://phabricator.wikimedia.org/T152547#2857251 (10Anomie) I'm pretty su... [16:26:32] 10VisualEditor, 10Parsoid: selflinks aren't marked as selflinks in VisualEditor - https://phabricator.wikimedia.org/T152665#2857258 (10Arlolra) [17:11:15] (03PS1) 10DLynch: ce.Surface showSelectionState: Avoid unnecessary refocusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325960 (https://phabricator.wikimedia.org/T150450) [17:26:15] 10VisualEditor, 10MediaWiki-API, 13Patch-For-Review, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): [Regression pre-wmf.6] Cannot save any edit with VisualEditor getting error "The parameters "page" and "oldid" can not be used together." - https://phabricator.wikimedia.org/T152547#2852222 (10demon) >>! In T152547... [17:38:28] edsanders: Hmm... the reason for that is is because the rvsection param predates the diff part of that API, it was originally just for fetching content [17:46:06] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Internet-Explorer, 13Patch-For-Review, 07Regression: [Regression 1.28.0-wmf.15] Programmatic document change (e.g. make bold) causes scroll to top in IE<=11 - https://phabricator.wikimedia.org/T150450#2857459 (10DLynch) Issue was: in IE<=1... [17:57:05] edsanders, I'm not sure what you're trying to achieve exactly [17:57:43] Show the correct change for adding a new section [17:58:20] so on a talk page, use 'new section', then press show changes after typing [18:01:13] ...via the API [18:01:29] * need to do the same thing via the API [18:26:32] edsanders: diff it against empty text...? [18:27:33] legoktm: I'll probably go with that. Diff against new shows which line it will be inserted at, but it's close enough. [18:38:04] talking about diffs, is the "Get diff" button supposed to work here? https://wikimedia.github.io/VisualEditor/demos/ve/desktop-dist.html [18:39:29] possibly not on the dist version yet - it will work on the slower non-dist version: https://wikimedia.github.io/VisualEditor/demos/ve/desktop.html#!pages/simple.html [18:42:34] thank you, that's great! [18:48:00] James_F: the other issue is that there's no edit summary on section=new, but there are edit checkboxes - so we need to hide the textbox in the save dialog :/ [18:49:05] edsanders: Hmm. Disable would be a lot better than hide. [18:51:07] prefilled with subjectTitle? [19:02:33] Yeah. [19:26:06] (03PS1) 10Esanders: Simplify #updateTabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326000 [19:26:08] (03PS1) 10Esanders: Expand dummy surface to be at least valid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326001 [19:26:10] (03PS1) 10Esanders: Cleanup handling of 'section' param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326002 [19:26:12] (03PS1) 10Esanders: WIP Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) [19:36:46] (03CR) 10Jforrester: [C: 031] Simplify #updateTabs (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326000 (owner: 10Esanders) [19:37:00] (03PS2) 10Jforrester: Expand dummy surface to be at least valid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326001 (owner: 10Esanders) [19:37:04] (03CR) 10Jforrester: [C: 032] Expand dummy surface to be at least valid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326001 (owner: 10Esanders) [19:37:35] (03CR) 10Jforrester: [C: 032] "This'll do for now, we can fix later." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326000 (owner: 10Esanders) [19:38:48] (03CR) 10Jforrester: [C: 032] Cleanup handling of 'section' param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326002 (owner: 10Esanders) [19:40:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-References: Long links in reference context don't wrap - https://phabricator.wikimedia.org/T152680#2857905 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [19:52:00] (03Merged) 10jenkins-bot: Expand dummy surface to be at least valid [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326001 (owner: 10Esanders) [19:59:30] (03Merged) 10jenkins-bot: Simplify #updateTabs [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326000 (owner: 10Esanders) [20:06:34] (03CR) 10jenkins-bot: [V: 04-1] WIP Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [20:24:20] (03PS2) 10Jforrester: Cleanup handling of 'section' param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326002 (owner: 10Esanders) [20:24:27] (03CR) 10Jforrester: [C: 032] Cleanup handling of 'section' param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326002 (owner: 10Esanders) [20:33:18] (03Merged) 10jenkins-bot: Cleanup handling of 'section' param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326002 (owner: 10Esanders) [20:58:04] (03CR) 10Jforrester: ce.Surface showSelectionState: Avoid unnecessary refocusing (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325960 (https://phabricator.wikimedia.org/T150450) (owner: 10DLynch) [20:59:58] (03PS2) 10DLynch: ce.Surface showSelectionState: Avoid unnecessary refocusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325960 (https://phabricator.wikimedia.org/T150450) [21:00:11] (03CR) 10DLynch: ce.Surface showSelectionState: Avoid unnecessary refocusing (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325960 (https://phabricator.wikimedia.org/T150450) (owner: 10DLynch) [21:01:51] (03CR) 10Jforrester: [C: 031] ce.Surface showSelectionState: Avoid unnecessary refocusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325960 (https://phabricator.wikimedia.org/T150450) (owner: 10DLynch) [21:31:40] (03PS2) 10Esanders: WIP Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) [21:35:03] (03CR) 10Esanders: [C: 032] ce.Surface showSelectionState: Avoid unnecessary refocusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325960 (https://phabricator.wikimedia.org/T150450) (owner: 10DLynch) [21:38:54] (03Merged) 10jenkins-bot: ce.Surface showSelectionState: Avoid unnecessary refocusing [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/325960 (https://phabricator.wikimedia.org/T150450) (owner: 10DLynch) [21:41:19] (03CR) 10jenkins-bot: [V: 04-1] WIP Support section=new in NWE [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [21:43:10] (03CR) 10Jforrester: WIP Support section=new in NWE (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326003 (https://phabricator.wikimedia.org/T150709) (owner: 10Esanders) [22:17:29] 10VisualEditor, 10VisualEditor-Tables: Cannot add columns to tables in VisualEditor - https://phabricator.wikimedia.org/T152659#2856327 (10Esanders) It should still work with missing and merged cells, so this is indeed a bug. [22:38:10] (03PS5) 10Tchanders: WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 [22:38:18] (03CR) 10jenkins-bot: [V: 04-1] WIP Make gallery dialog work with native gallery implementation [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/322490 (owner: 10Tchanders) [22:47:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: insertContent for MWWikitextSurfaceFragment has a bit unexpected behavior with multi-line strings - https://phabricator.wikimedia.org/T151613#2822749 (10Esanders) Probably fixed by https://gerrit.wikimedia.org/r/#/c/325236/ [22:59:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Empty lines are deleted when pasting text - https://phabricator.wikimedia.org/T152671#2856669 (10Esanders) WFM in beta labs and master. If there was a regression, it was possibly fixed by https://gerrit.wikimedia.org/r/#/c/325236/