[00:10:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: Support 'Add topic' in NWE - https://phabricator.wikimedia.org/T150709#2794061 (10Jdforrester-WMF) a:03Esanders [04:06:50] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 10MediaWiki-Page-editing: Add support for (the equivalent of?) editintro and preload - https://phabricator.wikimedia.org/T51622#2859212 (10Gryllida) VisualEditor having preload support for page creation would be nice. Preload is used in... [06:37:29] 10VisualEditor, 10VisualEditor-MediaWiki-Templates: VisualEditor Add a Template autocomplete is showing no results (3rd party install) - https://phabricator.wikimedia.org/T152471#2859314 (10JimmyRoxburgh) Yes, during edit mode - i go to insert -> template. The drop down for "Add a Category" works [06:49:20] (03PS7) 10Divec: WIP: Store metadata as block nodes in the main data list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 [06:49:31] (03PS4) 10Divec: WIP: metalist bonfire [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315905 [06:53:10] (03CR) 10jenkins-bot: [V: 04-1] WIP: Store metadata as block nodes in the main data list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 (owner: 10Divec) [06:54:44] (03CR) 10jenkins-bot: [V: 04-1] WIP: metalist bonfire [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/315905 (owner: 10Divec) [08:57:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: insertContent for MWWikitextSurfaceFragment has a bit unexpected behavior with multi-line strings - https://phabricator.wikimedia.org/T151613#2859407 (10Schnark) This will still add linebreaks at the start and end, but if you say that this behavior i... [09:02:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Empty lines are deleted when pasting text - https://phabricator.wikimedia.org/T152671#2859409 (10Schnark) I can still reproduce the issue on https://en.wikipedia.beta.wmflabs.org/wiki/User:Schnark?veaction=editsource and https://de.wikipedia.bet... [09:46:59] 10VisualEditor: Editing mode option does not change anything in hywiktionary - https://phabricator.wikimedia.org/T152768#2859454 (10Ashot1997) [11:20:10] is there any preliminary work on a OOjs UI Bootstrap theme [12:17:22] 10VisualEditor: Visual editor and navigation popups don't work together - https://phabricator.wikimedia.org/T152558#2852504 (10Esanders) It's unlikely we'll have a public API that emits an event every time a context item is shown. You could extend the context item, but you might get into a registry fight if othe... [13:11:34] (03PS1) 10Ethanlee: Added check for empty template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 [13:28:55] 10VisualEditor, 10VisualEditor-MediaWiki, 10CodeEditor: Support CodeEditor in NWE - https://phabricator.wikimedia.org/T152775#2859692 (10Esanders) [15:13:38] 10VisualEditor, 10VisualEditor-MediaWiki-References: When first reference is added, add reflist automaticaly in VisualEditor - https://phabricator.wikimedia.org/T152686#2857115 (10Esanders) Most wikis use a template for ref lists, which is very annoying. [15:38:07] 10VisualEditor, 10VisualEditor-MediaWiki-References: When first reference is added, add reflist automaticaly in VisualEditor - https://phabricator.wikimedia.org/T152686#2859971 (10Esanders) [15:38:10] 10Cite, 13Patch-For-Review, 07User-notice: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#2859972 (10Esanders) [16:11:31] (03CR) 10Mvolz: [C: 04-1] Added check for empty template (032 comments) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (owner: 10Ethanlee) [16:23:21] (03PS9) 10Jforrester: [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [16:24:11] (03CR) 10Jforrester: "PS9: Rebased onto David's work to merge metadata into the data list, as otherwise we'll have a nightmare on our hands." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [16:26:02] (03CR) 10Jforrester: "Are we going to try to rebase this onto I5b1ada33c (the first bit of this), or just carve it up into further commits and abandon?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/179940 (owner: 10Catrope) [16:26:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Subdocuments: Current uses of Document are contained in a DocumentSet [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/269449 (owner: 10DLynch) [16:30:27] ypnos: Not that I'm aware of. [16:30:47] thanks James_F [16:31:21] Happy to help, though I've never used Bootstrap so… :-) [16:32:21] (03PS1) 10Jforrester: Update VE core submodule to master (9be803f) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326141 (https://phabricator.wikimedia.org/T150450) [16:33:18] I think a bootstrap theme would be a great help to foster adoption of visualeditor in other websites, I use bootstrap myself so that's why I am asking [16:33:26] maybe I can do something in this regard but it will take a while [16:34:03] many themes are built on bootstrap, so if you support bootstrap (the right way) you automatically support many other themes as well [16:34:22] 10VisualEditor, 10VisualEditor-MediaWiki, 10CodeEditor, 07Epic: Support CodeEditor in NWE - https://phabricator.wikimedia.org/T152775#2860026 (10Jdforrester-WMF) p:05Triage>03Low We'll need to provide a content model registration system in CodeEditor that VE reads from and so knows what it can and can'... [16:34:31] it also uses less so that's already good [16:35:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-12-13_(1.29.0-wmf.6): insertContent for MWWikitextSurfaceFragment has a bit unexpected behavior with multi-line strings - https://phabricator.wikimedia.org/T151613#2860032 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [16:35:49] (03PS1) 10Ethanlee: Added check for empty template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326143 [16:36:16] * James_F nods. [16:37:07] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Empty lines are deleted when pasting text - https://phabricator.wikimedia.org/T152671#2860042 (10Jdforrester-WMF) p:05Triage>03Normal [16:40:20] (03Abandoned) 10Ethanlee: Added check for empty template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (owner: 10Ethanlee) [17:22:22] 10VisualEditor, 10VisualEditor-Tables: [Regression?] Cannot add columns to sparse tables in VisualEditor - https://phabricator.wikimedia.org/T152659#2860122 (10Jdforrester-WMF) p:05Triage>03High [17:23:56] 10VisualEditor, 10VisualEditor-Tables: [Regression?] Cannot add columns to sparse tables in VisualEditor - https://phabricator.wikimedia.org/T152659#2860126 (10Esanders) Probably not a regression as we haven't touched the code. This may be more about an entire row of sparse cells. [17:25:24] 10VisualEditor, 10VisualEditor-Tables: [Regression?] Cannot add columns to sparse tables in VisualEditor - https://phabricator.wikimedia.org/T152659#2860128 (10Jdforrester-WMF) Yeah, it's more likely that we missed an edge case in the test suite. But just in case… [17:35:18] edsanders: Do we have a method to drop leading/trailing whitespace and empty paragraphs from documents? [17:44:59] I don't think so [17:45:20] Sounds like something Parsoid should do though, not us... [18:23:36] (03Restored) 10Ethanlee: Added check for empty template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (owner: 10Ethanlee) [18:25:22] (03PS2) 10Ethanlee: Added check for empty template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 [18:26:40] (03Abandoned) 10Ethanlee: Added check for empty template [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326143 (owner: 10Ethanlee) [18:30:27] (03CR) 10Mvolz: [C: 04-1] Added check for empty template (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (owner: 10Ethanlee) [18:46:46] 10VisualEditor: enable visual editor in Wikiprojects spaces on English Wikipedia - https://phabricator.wikimedia.org/T152794#2860307 (10Mrjohncummings) [19:02:14] 10VisualEditor: Floating toolbar fails in minimal example - https://phabricator.wikimedia.org/T152781#2860355 (10Aklapper) [19:13:48] (03PS3) 10Ethanlee: ve.ui.CiteFromIdInspector: Add check for empty templates [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (https://phabricator.wikimedia.org/T92428) [19:16:31] 10VisualEditor: enable visual editor in Wikiprojects spaces on English Wikipedia - https://phabricator.wikimedia.org/T152794#2860307 (10Stryn) There's no namespace called "Wikiproject". So AFAIK if you want to enable VE in wikiprojects, it should be enabled in the entire Wikipedia namespace. It was already once... [19:28:29] (03PS1) 10Esanders: Follow-up Iaa41c49e: Don't assume source dialogs have a fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326157 [19:31:31] (03CR) 10jenkins-bot: [V: 04-1] Follow-up Iaa41c49e: Don't assume source dialogs have a fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326157 (owner: 10Esanders) [19:44:29] (03PS1) 10Esanders: Get content format from EditPage, instead of guessing 'text/x-wiki' [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326158 [19:53:38] (03CR) 10Jforrester: Get content format from EditPage, instead of guessing 'text/x-wiki' (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326158 (owner: 10Esanders) [19:57:40] 10VisualEditor, 10VisualEditor-Tables: [Regression?] Cannot add columns to sparse tables in VisualEditor - https://phabricator.wikimedia.org/T152659#2856327 (10DLynch) This is the same error as T152387 -- so probably the same issue. [20:02:34] (03CR) 10Jforrester: [C: 032] Follow-up Iaa41c49e: Don't assume source dialogs have a fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326157 (owner: 10Esanders) [20:04:50] (03CR) 10jenkins-bot: [V: 04-1] Follow-up Iaa41c49e: Don't assume source dialogs have a fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326157 (owner: 10Esanders) [20:05:30] (03PS1) 10DLynch: ui.TableAction: don't try to add cells if none have been provided [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) [20:07:22] I have to say, I didn't really feel its absence before, but getting the review-changes keyboard shortcut landed has actually made some things far easier. [20:09:49] (03CR) 10jenkins-bot: [V: 04-1] ui.TableAction: don't try to add cells if none have been provided [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) (owner: 10DLynch) [20:13:20] James_F: ^^^ That's interesting. It's an eslint error in a file which my patch doesn't touch, which also doesn't occur locally. [20:16:46] And "Expected indentation of 18 tabs but found 6" is a bit weird. [20:17:11] Kemayo: Yeah, looks like CI is broken. [20:17:58] Ah, yeah, I see that WindowAction patch failed in the same way. [20:18:48] Something about the copy of ve.ui.TableAction.test.js it has checked out being messed up, maybe. It's at least consistently complaining about the indentation in that file in both of them. [20:25:03] Found it. [20:25:25] grunt-eslint isn't updated (still 19.0.0) but it doesn't pin versions, and uses eslint ^3.0.0. [20:25:44] eslint 3.12.0 got released four hours ago, and looks like it's an (accidental?) breaking change somehow. [20:26:43] If you rm -rf node_modules/eslint and npm install it adds it (but doesn't unnecessarily upgrade), and you get the error. [20:26:44] * James_F sighs. [20:27:11] Quick fix would be to require a fixed version of eslint (3.11.1 was working fine). [20:39:11] Ah, OK. [20:39:18] Found what's causing it to be unhappy. [20:39:22] Might just fix that. [20:40:41] The problem is the data.splice( 110, 0,\n … ). If we put the params all on one line or each on their own line it's fine, but starting inline and then putting the object on its own line makes it grumble. [20:41:40] (03PS2) 10Jforrester: Follow-up Iaa41c49e: Don't assume source dialogs have a fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326157 (owner: 10Esanders) [20:41:42] (03PS1) 10Jforrester: ve.ui.TableAction.test.js: Make formmatting pass in eslint 3.12.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326170 [20:41:51] Kemayo: +2 326170? [20:42:50] (03CR) 10DLynch: [C: 032] ve.ui.TableAction.test.js: Make formmatting pass in eslint 3.12.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326170 (owner: 10Jforrester) [20:50:41] (03Merged) 10jenkins-bot: ve.ui.TableAction.test.js: Make formmatting pass in eslint 3.12.0 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326170 (owner: 10Jforrester) [20:53:15] (03Merged) 10jenkins-bot: Follow-up Iaa41c49e: Don't assume source dialogs have a fragment [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326157 (owner: 10Esanders) [20:58:44] (03PS2) 10Jforrester: ui.TableAction: don't try to add cells if none have been provided [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) (owner: 10DLynch) [20:59:27] Kemayo: Test case for 326162? :-) [21:01:16] 10VisualEditor: enable visual editor in Wikiprojects spaces on English Wikipedia - https://phabricator.wikimedia.org/T152794#2860619 (10Mrjohncummings) I don't really understand, but does this mean if I want VE to be enabled in Wikiprojects I have to get them enabled in all Wikipedia: namespaces? That sounds lik... [21:04:41] Yeah, I suppose I should. [21:10:21] Actually, should I open a parsoid bug about it producing invalid HTML, too? An empty is outright a validation error. (Albeit one that's a fair representation of the wikitext in question.) [21:16:18] It's also a case where Parsoid's output is different from our normal rendered wikitext output -- the standard rendering of the wikitext in these cases does strip the empty . [21:29:22] Only because Tidy kills them. [21:29:31] The "real" HTML emitted by the PHP parser contains it. [21:29:51] And we're getting rid of Tidy (thus bringing the "standard rendering" into line a bit more). [21:30:09] 10Cite, 10MediaWiki-Internationalization, 07I18n, 13Patch-For-Review, 07RTL: parser tags such as , , etc. cannot be localized - https://phabricator.wikimedia.org/T30980#2860662 (10Amire80) [21:30:11] But yeah, ask the Parsing team what they think should happen with blank trs. [21:55:48] Okay, made T152806 about it. [21:55:48] T152806: Wikitext representing an empty produces technically-invalid output - https://phabricator.wikimedia.org/T152806 [22:17:10] (03CR) 10Jforrester: [C: 031] "Please add a test (even if this DOM is invalid)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) (owner: 10DLynch) [22:34:52] 10VisualEditor, 06Collaboration-Team-Triage, 10Notifications: Problem with visual editor, and notifications - https://phabricator.wikimedia.org/T152810#2860800 (10ASammour) [22:36:46] 10VisualEditor, 06Collaboration-Team-Triage, 10Notifications: Problem with visual editor, and notifications - https://phabricator.wikimedia.org/T152810#2860815 (10Catrope) [22:44:02] (03PS3) 10DLynch: ui.TableAction: don't try to add cells if none have been provided [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) [22:45:48] (03CR) 10DLynch: "Added the test. Previous tests missed it because they only tested sparse rows in the context of moving a row near them, rather than column" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) (owner: 10DLynch) [22:48:17] (03CR) 10Jforrester: [C: 032] ui.TableAction: don't try to add cells if none have been provided [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) (owner: 10DLynch) [22:52:08] 10VisualEditor: Standalone: Floating toolbar fails when page gets too long with keyboard-only input - https://phabricator.wikimedia.org/T152781#2860855 (10Jdforrester-WMF) p:05Triage>03Low [22:54:13] (03Merged) 10jenkins-bot: ui.TableAction: don't try to add cells if none have been provided [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326162 (https://phabricator.wikimedia.org/T152387) (owner: 10DLynch) [22:57:20] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Community-Liaisons, 07Notice: Tech Talk for the 2017 wikitext editor - https://phabricator.wikimedia.org/T145417#2860871 (10Rfarrand) Great, thanks James. As is the new-tradition (if you can use those words together... [23:01:05] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Community-Liaisons, 07Notice: Tech Talk for the 2017 wikitext editor - https://phabricator.wikimedia.org/T145417#2860878 (10Jdforrester-WMF) Well @dchan and @Esanders and @catrope did all the talking. ;-) But to be v... [23:19:11] (03PS1) 10Jforrester: build: Replace jshint and jscs with eslint [unicodejs] - 10https://gerrit.wikimedia.org/r/326194 [23:19:13] (03PS1) 10Jforrester: Tag v0.1.6 [unicodejs] - 10https://gerrit.wikimedia.org/r/326195 [23:19:19] RoanKattouw: ^^^ :-) [23:21:49] (03CR) 10Catrope: [C: 032] build: Replace jshint and jscs with eslint [unicodejs] - 10https://gerrit.wikimedia.org/r/326194 (owner: 10Jforrester) [23:29:42] (03CR) 10Catrope: [C: 032] Tag v0.1.6 [unicodejs] - 10https://gerrit.wikimedia.org/r/326195 (owner: 10Jforrester) [23:30:11] (03Merged) 10jenkins-bot: build: Replace jshint and jscs with eslint [unicodejs] - 10https://gerrit.wikimedia.org/r/326194 (owner: 10Jforrester) [23:32:34] (03Merged) 10jenkins-bot: Tag v0.1.6 [unicodejs] - 10https://gerrit.wikimedia.org/r/326195 (owner: 10Jforrester) [23:40:25] (03PS1) 10Jforrester: Update UnicodeJS to v0.1.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326198 [23:43:24] Kemayo: Could I steal a +2 on https://gerrit.wikimedia.org/r/#/c/326198/ from you so I can update my last pull-through for the year? ;-) [23:44:40] (03CR) 10DLynch: [C: 032] Update UnicodeJS to v0.1.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326198 (owner: 10Jforrester) [23:44:47] Ta! [23:45:22] Should make gerrit notice when I'm doing +2 from a phone UA and have it add something sarcastic. [23:46:37] Something like "grrrit-wm (Mobile CR 😱🚨☠️) DLynch: [C: 2] Update UnicodeJS to v0.1.6 [VisualEditor/VisualEditor] - https://gerrit.wikimedia.org/r/326198 (owner: Jforrester)"? :-) [23:47:33] (03Merged) 10jenkins-bot: Update UnicodeJS to v0.1.6 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/326198 (owner: 10Jforrester) [23:47:55] Exactly. :D [23:54:40] (03PS2) 10Jforrester: Update VE core submodule to master (33012af) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/326141 (https://phabricator.wikimedia.org/T150450) [23:54:57] Kemayo: And on https://gerrit.wikimedia.org/r/326141 too? ;-) [23:58:59] 10VisualEditor, 15User-JAufrecht (This Week): Book and prep SLU between VE and Editing Design - https://phabricator.wikimedia.org/T150351#2861043 (10JAufrecht) [23:59:02] 10VisualEditor, 06Parsing-Team, 10TemplateStyles, 10ArchCom-RfC (ArchCom-Approved), 07RfC: RfC: Allow styling in templates - https://phabricator.wikimedia.org/T483#2861042 (10Tgr)