[04:46:49] (03PS1) 10Jo12bar: Replace all usages of Linker::link() with LinkRenderer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329731 (https://phabricator.wikimedia.org/T149346) [05:05:47] (03CR) 10MtDu: [C: 04-1] "Thanks for the change! I think youre making a bit more complicated than it needs to be though. See https://www.mediawiki.org/wiki/Manual:L" (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329731 (https://phabricator.wikimedia.org/T149346) (owner: 10Jo12bar) [05:13:14] (03CR) 10Jo12bar: "On it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329731 (https://phabricator.wikimedia.org/T149346) (owner: 10Jo12bar) [05:28:48] (03PS2) 10Jo12bar: Replace all usages of Linker::link() with LinkRenderer [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329731 (https://phabricator.wikimedia.org/T149346) [05:32:40] (03CR) 10Jo12bar: "Alright, tried to make it simpler. Sorry about that - I've got this bad habit of overcomplicating things." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329731 (https://phabricator.wikimedia.org/T149346) (owner: 10Jo12bar) [09:12:24] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Promote the signature button to the toolbar (or somewhere else more prominent) in VE/NWE - https://phabricator.wikimedia.org/T153255#2908306 (10Schnark) >>! In T153255#2907756, @matmarex wrote: >>>! In T153255#2879829, @Schnark wrote: >> * Find a way... [09:23:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Can't use arrow keys to scroll through the preview - https://phabricator.wikimedia.org/T154334#2907732 (10Schnark) This works when you first press the TAB key 3 times. [11:39:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Can't use arrow keys to scroll through the preview - https://phabricator.wikimedia.org/T154334#2907732 (10AlexMonk-WMF) >>! In T154334#2908309, @Schnark wrote: > This works when you first press the TAB key 3 times. Yeah, but only if there's somethin... [14:00:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Promote the signature button to the toolbar (or somewhere else more prominent) in VE/NWE - https://phabricator.wikimedia.org/T153255#2908533 (10matmarex) Hmm, good point. I can't think of any case where the "Add new section" button would be added on... [14:59:14] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE copies tags on displayed text - https://phabricator.wikimedia.org/T154364#2908601 (10MarcoAurelio) [15:18:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Editing-Department: New WikiText Editor fails when trying to edit articles with editintros - https://phabricator.wikimedia.org/T153481#2908640 (10Esanders) [15:18:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Add support for editintro and preload - https://phabricator.wikimedia.org/T153538#2908642 (10Esanders) [15:23:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Editing-Department: New WikiText Editor fails when trying to edit articles with editintros - https://phabricator.wikimedia.org/T153481#2881990 (10Esanders) NB Actually supporting editintro's in VE is T56029. [15:24:09] (03PS1) 10Esanders: Don't block VE/NWE from loading if 'editintro' is specified [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329794 (https://phabricator.wikimedia.org/T153481) [17:03:48] (03PS1) 10Esanders: Add editintro to notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329796 (https://phabricator.wikimedia.org/T56029) [17:09:32] (03CR) 10jerkins-bot: [V: 04-1] Add editintro to notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329796 (https://phabricator.wikimedia.org/T56029) (owner: 10Esanders) [18:59:32] (03PS2) 10Esanders: Add editintro to notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329796 (https://phabricator.wikimedia.org/T56029) [19:06:35] (03CR) 10jerkins-bot: [V: 04-1] Add editintro to notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329796 (https://phabricator.wikimedia.org/T56029) (owner: 10Esanders) [19:31:48] (03PS2) 10Esanders: Remove unit test hack, no longer needed. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/329690 [19:31:50] (03PS2) 10Esanders: Rebaser: Separate namespace creation from /doc/edit [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/329714 [19:31:53] (03PS1) 10Esanders: DOMPurify config: Change ALLOWED_ATTR to ADD_ATTR [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/329802 [19:46:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE copies tags on displayed text - https://phabricator.wikimedia.org/T154364#2908933 (10MarcoAurelio) While copying an OTRS ticket number from the OTRS interface, the result is: ``` ☀ = = ☂ ``` Never saw those symbols at the... [19:47:02] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 Wikitext Editor copies tags on displayed text - https://phabricator.wikimedia.org/T154364#2908934 (10MarcoAurelio) [19:47:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 Wikitext Editor copies tags on displayed text and adds other symbols - https://phabricator.wikimedia.org/T154364#2908601 (10MarcoAurelio) [19:53:15] 10Citoid, 10VisualEditor, 03Google-Code-In-2016: TypeError: result.isFulfilled is not a function in html-metadata - https://phabricator.wikimedia.org/T154238#2908939 (10Aklapper) Thanks! Imported as https://codein.withgoogle.com/tasks/5646221060341760/ [20:02:01] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Not replacing pasted links - https://phabricator.wikimedia.org/T154377#2908950 (10Wargo) [21:39:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Links to missing pages should be red in preview - https://phabricator.wikimedia.org/T153535#2883457 (10Alsee) Not just redlinks. External links need to show as external links, and a page that links to itself needs to be a black (non-)link. Same... [22:03:30] (03PS3) 10Esanders: Add editintro to notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329796 (https://phabricator.wikimedia.org/T56029) [22:05:01] (03PS1) 10Esanders: Give focus to preview panel for keyboard scrolling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329809 (https://phabricator.wikimedia.org/T154334) [22:32:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE breaks templates by adding some extra space - https://phabricator.wikimedia.org/T154382#2909062 (10Stryn) [23:05:48] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Painfully bad framerate while vertical scrolling preview in Chrome. It seems fine in Firefox. - https://phabricator.wikimedia.org/T154385#2909112 (10Alsee) [23:18:03] (03PS4) 10Esanders: [WIP] Undo support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323357 (https://phabricator.wikimedia.org/T78550) (owner: 10Alex Monk) [23:18:45] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: The undo link in the page history leads to the source editor and not VisualEditor - https://phabricator.wikimedia.org/T78550#848117 (10Esanders) This is higher priority with the new source mode. [23:22:06] (03PS5) 10Esanders: [WIP] Undo support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323357 (https://phabricator.wikimedia.org/T78550) (owner: 10Alex Monk) [23:23:33] (03PS4) 10Esanders: Add editintro to notices [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329796 (https://phabricator.wikimedia.org/T56029) [23:56:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New Wikitext Editor: Preview is broken for OGG element (and probably other media) - https://phabricator.wikimedia.org/T154387#2909153 (10Alsee)