[00:15:17] 10VisualEditor, 10Graphs, 03Interactive-Sprint, 13Patch-For-Review: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2915305 (10Yurik) Apparently there are some bugs and limitations in Vega that make predicting width/height ahead of time difficult. We might need to figure... [00:29:16] (03PS1) 10Jforrester: Update OOjs UI to v0.18.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330336 [00:44:57] (03CR) 10Catrope: [C: 032] Update OOjs UI to v0.18.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330336 (owner: 10Jforrester) [00:50:57] (03Merged) 10jenkins-bot: Update OOjs UI to v0.18.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330336 (owner: 10Jforrester) [00:53:22] 10VisualEditor, 10MobileFrontend, 13Patch-For-Review: HTML-based CAPTCHAs don't display properly on mobile frontend. - https://phabricator.wikimedia.org/T154082#2915367 (10Jdlrobson) [00:57:07] 10VisualEditor, 10VisualEditor-MediaWiki-Links: VisualEditor should let people link to another wiki easily, maybe with integrated suggestions or its own tab? - https://phabricator.wikimedia.org/T98135#2915380 (10Gryllida) I believe that we can ask at different projects what they want the interface to be and ho... [00:57:12] (03CR) 10jenkins-bot: Update OOjs UI to v0.18.3 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330336 (owner: 10Jforrester) [01:15:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): [Regression] VE Link inspector stops working properly when NWE is enabled. - https://phabricator.wikimedia.org/T153668#2915470 (10Ryasmeen) [01:22:53] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: §ion=new results in an un-editable default edit summary - https://phabricator.wikimedia.org/T153609#2915484 (10Jdforrester-WMF) 05Open>03declined In general, we don't hide things in some modes, we disable them instead. [01:27:41] 10TemplateData, 10VisualEditor, 07JavaScript: TemplateData should use "jquery.textSelection" for interaction with textareas - https://phabricator.wikimedia.org/T73363#2915490 (10Jdforrester-WMF) p:05Triage>03Lowest Compatibility with gadgets is not a priority for us right now, but we'd be happy to review... [01:29:24] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): a sun ☀ appeared after pasting an article title into new wikitext editor - https://phabricator.wikimedia.org/T153247#2873997 (10Ryasmeen) The issue of "☀" character appearing after... [01:33:01] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2016-12-06_(1.29.0-wmf.5), 05WMF-deploy-2016-12-13_(1.29.0-wmf.6), 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Pasting links into NWE throws an excpetion - https://phabricator.wikimedia.org/T153269#2874679 (10Ryasmeen) Not getting any... [01:43:08] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): a sun ☀ appeared after pasting an article title into new wikitext editor - https://phabricator.wikimedia.org/T153247#2915576 (10Ryasmeen) [01:46:42] 10Cite, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, and 7 others: Inserting a new citation in the new wikitext editor JS fatals with "Uncaught TypeError: Cannot read property 'getRange' of null" in TransactionBuilder#newFromDocume... - https://phabricator.wikimedia.org/T153254#2915579 [01:57:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): Can't mark an edit as Minor or Watch the page after switching to wikitext - https://phabricator.wikimedia.org/T153889#2915640 (10Ryasmeen) [02:04:01] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): NWE: Edit section does not add section title into summary - https://phabricator.wikimedia.org/T153245#2915650 (10Ryasmeen) [02:59:49] 10VisualEditor, 10MonoBook, 10OOjs-UI, 07Design: Apex's progressive buttons are not visually distinct - https://phabricator.wikimedia.org/T128577#2079324 (10Volker_E) I think it's bad, that we still offer `constructive` in Apex. In T110555 the flaws of the dual system of progressive and constructive button... [03:00:15] 10VisualEditor, 10MonoBook, 10OOjs-UI, 07Design: Apex's constructive buttons are not visually distinct - https://phabricator.wikimedia.org/T128577#2915718 (10Volker_E) [03:00:29] 10VisualEditor, 10MonoBook, 10OOjs-UI: Apex's constructive buttons are not visually distinct - https://phabricator.wikimedia.org/T128577#2079324 (10Volker_E) [03:11:43] 10VisualEditor, 07Wikimedia-log-errors: Undefined index: oldid in /srv/mediawiki/php-1.29.0-wmf.6/extens ions/VisualEditor/ApiVisualEditorEdit.php - https://phabricator.wikimedia.org/T154559#2915748 (10bd808) [06:52:12] 10VisualEditor: VisualEditor: Bug when attempting to edit a protected page - https://phabricator.wikimedia.org/T154565#2915895 (10MusikAnimal) [06:53:03] 10VisualEditor: VisualEditor: Bug when attempting to edit a protected page - https://phabricator.wikimedia.org/T154565#2915921 (10MusikAnimal) [06:54:19] 10VisualEditor: VisualEditor: Bug when attempting to edit a protected page - https://phabricator.wikimedia.org/T154565#2915895 (10MusikAnimal) p:05Triage>03Normal [06:56:26] 10VisualEditor: VisualEditor: Bug when attempting to edit a protected page - https://phabricator.wikimedia.org/T154565#2915925 (10MusikAnimal) Changing the priority to Normal (tempted to make it High) in regards to the bug itself. Allowing users to get to step #4, where in a worst case scenario, they spend a lot... [06:59:12] 10VisualEditor: Bug when attempting to edit a protected page - https://phabricator.wikimedia.org/T154565#2915926 (10MusikAnimal) [07:01:02] 10VisualEditor: Don't prompt to use VisualEditor when attempting to edit a protected page - https://phabricator.wikimedia.org/T154565#2915895 (10MusikAnimal) [08:45:44] 10VisualEditor, 10VisualEditor-MediaWiki: Provide preview in visual mode - https://phabricator.wikimedia.org/T153293#2915973 (10Schnark) I mean "give me things I can interact with": For example: "Does the table sorter code recognize that this column contains numbers and will sort it correctly, or do I have to... [08:56:03] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Linking a subpage in VE fails - https://phabricator.wikimedia.org/T154567#2915979 (10Schnark) [10:03:34] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Sometimes old WikiText editor loads after user has switched to new WikiText editor - https://phabricator.wikimedia.org/T153561#2884240 (10Arrbee) I saw this happening when clicking red links i.e. if I select 'Edit Source' on an existing page I see th... [14:27:12] 10VisualEditor: Don't prompt to use VisualEditor when attempting to edit a protected page - https://phabricator.wikimedia.org/T154565#2915895 (10Krenair) The exception referenced was this: ```archive/exception.log-20170104:2017-01-04 06:26:37 [WGyVnQpAEDMAAa7HZiQAAACD] mw1286 enwiki 1.29.0-wmf.6 exception ERROR:... [14:31:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Sometimes old WikiText editor loads after user has switched to new WikiText editor - https://phabricator.wikimedia.org/T153561#2884240 (10Dvorapa) I can claim this bug I use almost every time keyboard shortcut (alt-shift-e) and it behaves that way re... [15:00:28] (03PS1) 10Alex Monk: More error handling fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330419 [15:54:20] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor should show the actual link, not the text what is written - https://phabricator.wikimedia.org/T154331#2907608 (10DLynch) I don't see this occurring. E.g. {F5228932} Is it still happening for you? [16:16:11] (03PS3) 10Jforrester: Remove mobile window logic upstreamed to OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/328518 (https://phabricator.wikimedia.org/T126029) (owner: 10Esanders) [16:16:16] (03CR) 10Jforrester: [C: 032] Remove mobile window logic upstreamed to OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/328518 (https://phabricator.wikimedia.org/T126029) (owner: 10Esanders) [16:17:40] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 07Technical-Debt: ve.ui.MobileWindowManager#onMobileOpening: Don't un-frame buttons - https://phabricator.wikimedia.org/T126029#2916679 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [16:17:43] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 07Technical-Debt: ve.ui.MobileWindowManager#onMobileOpening: Don't un-frame buttons - https://phabricator.wikimedia.org/T126029#2003064 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [16:21:31] (03Merged) 10jenkins-bot: Remove mobile window logic upstreamed to OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/328518 (https://phabricator.wikimedia.org/T126029) (owner: 10Esanders) [16:26:55] (03CR) 10jenkins-bot: Remove mobile window logic upstreamed to OOUI [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/328518 (https://phabricator.wikimedia.org/T126029) (owner: 10Esanders) [16:52:25] (03PS1) 10Jforrester: Update VE core submodule to master (838df50) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330434 (https://phabricator.wikimedia.org/T126029) [16:53:04] (03PS4) 10Jforrester: Allow 'T-' prefixed sections, and redirect if section link title isn't current page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327398 (https://phabricator.wikimedia.org/T153176) (owner: 10Esanders) [16:53:10] (03CR) 10Jforrester: [C: 031] Allow 'T-' prefixed sections, and redirect if section link title isn't current page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327398 (https://phabricator.wikimedia.org/T153176) (owner: 10Esanders) [16:58:30] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2916808 (10Jdforrester-WMF) [16:58:36] 10Citoid, 10VisualEditor, 10ContentTranslation-CXserver, 10MediaWiki-extensions-ContentTranslation, and 5 others: Decom legacy ex-parsoidcache cxserver, citoid, and restbase service hostnames - https://phabricator.wikimedia.org/T133001#2916807 (10Jdforrester-WMF) [16:58:53] 10Citoid, 10VisualEditor, 10ContentTranslation-CXserver, 10MediaWiki-extensions-ContentTranslation, and 4 others: Decom legacy ex-parsoidcache cxserver, citoid, and restbase service hostnames - https://phabricator.wikimedia.org/T133001#2216638 (10Jdforrester-WMF) [17:28:54] (03PS1) 10DLynch: ui.AnnotationInspector: Don't assume previousSelection exists [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330439 (https://phabricator.wikimedia.org/T153378) [17:30:39] (03PS1) 10DLynch: ui.AnnotationInspector: In source mode, provide fallback insertionData [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330441 (https://phabricator.wikimedia.org/T153378) [17:31:05] (03PS2) 10Bartosz Dziewoński: Add "templates used" page to meta dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/328055 (https://phabricator.wikimedia.org/T149009) (owner: 10Esanders) [17:31:43] (03CR) 10Bartosz Dziewoński: "The EditPage method you're calling is not public, fixed in: https://gerrit.wikimedia.org/r/330440" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/328055 (https://phabricator.wikimedia.org/T149009) (owner: 10Esanders) [17:31:58] (03CR) 10Bartosz Dziewoński: "(Rebased to fix conflict in ve.init.mw.ArticleTarget.js)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/328055 (https://phabricator.wikimedia.org/T149009) (owner: 10Esanders) [17:34:20] (03CR) 10Bartosz Dziewoński: [C: 032] Add "templates used" page to meta dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/328055 (https://phabricator.wikimedia.org/T149009) (owner: 10Esanders) [17:36:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: Uncaught TypeError: Cannot read property 'clone' of null when inserting language - https://phabricator.wikimedia.org/T153378#2916899 (10Jdforrester-WMF) p:05Triage>03High a:03DLynch [17:42:06] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: Uncaught TypeError: Cannot read property 'clone' of null when inserting language - https://phabricator.wikimedia.org/T153378#2916927 (10DLynch) To explain the issue, this is two things happening: In source mode (NWE), the annot... [17:44:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: Uncaught TypeError: Cannot read property 'clone' of null when inserting language - https://phabricator.wikimedia.org/T153378#2916940 (10DLynch) (The latter patch probably removes all cases where the former is actually required,... [17:45:42] (03Merged) 10jenkins-bot: Add "templates used" page to meta dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/328055 (https://phabricator.wikimedia.org/T149009) (owner: 10Esanders) [17:48:19] (03CR) 10jenkins-bot: Add "templates used" page to meta dialog [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/328055 (https://phabricator.wikimedia.org/T149009) (owner: 10Esanders) [17:51:59] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (838df50) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330434 (https://phabricator.wikimedia.org/T126029) (owner: 10Jforrester) [17:55:33] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: NWE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T149009#2739576 (10Jdforrester-WMF) I'll re-work this a bit to make this not about NWE but about VE, and then make... [17:58:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design, 07Epic: Provide a second version of a beta modern wikitext editor integrated into the visual editor - https://phabricator.wikimedia.org/T142523#2916985 (10Jdforrester-WMF) [17:58:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: NWE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T149009#2916984 (10Jdforrester-WMF) [17:59:08] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): VE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T149009#2739576 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [17:59:35] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T154598#2916991 (10Jdforrester-WMF) [17:59:36] (03Merged) 10jenkins-bot: Update VE core submodule to master (838df50) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330434 (https://phabricator.wikimedia.org/T126029) (owner: 10Jforrester) [17:59:47] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): VE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T149009#2739576 (10Jdforrester-WMF) [17:59:49] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE should implement a replacement for "Templates used on this page" feature - https://phabricator.wikimedia.org/T154598#2917008 (10Jdforrester-WMF) [18:03:29] (03CR) 10jenkins-bot: Update VE core submodule to master (838df50) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330434 (https://phabricator.wikimedia.org/T126029) (owner: 10Jforrester) [18:04:08] MatmaRex: Meeting? :-) [18:04:43] oh. sure [18:21:09] 10VisualEditor, 10VisualEditor-MediaWiki: Move the Categories item to the top of the Page options menu because it's used more - https://phabricator.wikimedia.org/T74399#2917155 (10Jdforrester-WMF) [18:28:20] 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 07Technical-Debt, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): ve.ui.MobileWindowManager#onMobileOpening: Don't un-frame buttons - https://phabricator.wikimedia.org/T126029#2917169 (10Jdforrester-WMF) [18:28:32] 10VisualEditor, 10VisualEditor-ContentEditable, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Can't select more than one of page of text without scrolling back to top - https://phabricator.wikimedia.org/T153601#2917171 (10Jdforrester-WMF) [18:30:37] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-Plugins: VisualEditor: Extend the rich TemplateData editor to be used inside VE - https://phabricator.wikimedia.org/T52169#2917185 (10Jdforrester-WMF) 05Open>03Resolved This was done as part of {T152230}. {F5229438} [18:56:59] 10VisualEditor, 06Discovery, 10UI-Standardization, 10Wikimedia-Portals, 07Design: Align the style for lists of pages - https://phabricator.wikimedia.org/T153417#2917255 (10Volker_E) Wondering if Related articles should be included in our conversation? {F5229509 size=full} [19:09:09] 10VisualEditor, 10VisualEditor-MediaWiki: Move the Categories item to the top of the Page options menu because it's used more - https://phabricator.wikimedia.org/T74399#2917302 (10Jdforrester-WMF) OK, let's do this. [19:09:30] 10VisualEditor, 10VisualEditor-MediaWiki, 07User-notice: Move the Categories item to the top of the Page options menu because it's used more - https://phabricator.wikimedia.org/T74399#2917304 (10Jdforrester-WMF) a:03Jdforrester-WMF [19:19:22] (03PS1) 10Jforrester: MWMetaDialog: Move categories to the top as they're used most [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330451 (https://phabricator.wikimedia.org/T74399) [19:39:11] 10VisualEditor, 10Graphs, 03Interactive-Sprint, 13Patch-For-Review: Add a frame and caption text to - https://phabricator.wikimedia.org/T147768#2917429 (10debt) 05Open>03stalled [19:44:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: 2017 Wikitext Editor copies tags on displayed text and adds other symbols - https://phabricator.wikimedia.org/T154364#2917444 (10MarcoAurelio) @Jdforrester-WMF: Does it resolve the tags too? FWIW the workaround I found for... [19:49:49] (03PS1) 10Jforrester: ApiVisualEditorEditor#postData: Use isset on oldid post param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) [19:50:27] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 07Wikimedia-log-errors: Undefined index: oldid in /srv/mediawiki/php-1.29.0-wmf.6/extens ions/VisualEditor/ApiVisualEditorEdit.php - https://phabricator.wikimedia.org/T154559#2917467 (10Jdforrester-WMF) p:05Triage>03Normal a:03Jdforrester-W... [20:00:08] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor should show the actual link, not the text what is written - https://phabricator.wikimedia.org/T154331#2917522 (10Stryn) Ok, I see it only happens if you have the New wikitext mode enabled in your settings. [20:49:53] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor should show the actual link, not the text what is written - https://phabricator.wikimedia.org/T154331#2917699 (10DLynch) Ah, okay. Pretty certain this is T154331, which has been fixed, but the fix isn't deployed all the way out to wikipedia yet. [20:58:14] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor should show the actual link, not the text what is written - https://phabricator.wikimedia.org/T154331#2907608 (10Jdforrester-WMF) >>! In T154331#2917699, @DLynch wrote: > Ah, okay. Pretty certain this is T154331, which has been fixed, but the fix isn'... [20:58:27] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor should show the actual link, not the text what is written - https://phabricator.wikimedia.org/T154331#2917722 (10Jdforrester-WMF) [20:58:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): [Regression] VE Link inspector stops working properly when NWE is enabled. - https://phabricator.wikimedia.org/T153668#2886724 (10Jdforrester-WMF) [21:06:16] 10VisualEditor, 10VisualEditor-MediaWiki-Links: Link editor should show the actual link, not the text what is written - https://phabricator.wikimedia.org/T154331#2917743 (10DLynch) Look, copying and pasting is hard, okay? ;_; [21:47:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/330551 (owner: 10L10n-bot) [21:57:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330565 (owner: 10L10n-bot) [22:06:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This is not exactly equivalent. In this version, if `$parserParams['oldid'] === 0`, we append a '/' at the end; previously we did not. I h" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) (owner: 10Jforrester) [22:12:21] (03CR) 10Jforrester: "Ah, if ( '' ) {} evals to false?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) (owner: 10Jforrester) [22:13:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Conflicts with https://gerrit.wikimedia.org/r/#/c/327721/ , can you reconcile them?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330419 (owner: 10Alex Monk) [22:14:10] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Conflicts with https://gerrit.wikimedia.org/r/#/c/330419/ , can you reconcile them?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327721 (https://phabricator.wikimedia.org/T152429) (owner: 10Alex Monk) [22:15:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Yeah." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) (owner: 10Jforrester) [22:16:46] (03PS2) 10Jforrester: ApiVisualEditorEditor#postData: Use isset on oldid post param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) [22:17:32] MatmaRex: As Roan pointed out over my shoulder, the entire first if is pointless as 0 and '' are both false. [22:20:01] hm, indeed. [22:20:04] (03CR) 10Bartosz Dziewoński: [C: 032] ApiVisualEditorEditor#postData: Use isset on oldid post param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) (owner: 10Jforrester) [22:29:20] (03CR) 10Alex Monk: "Oops, no wonder I was confused. Review that one and I may update this" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330419 (owner: 10Alex Monk) [22:29:22] (03CR) 10Bartosz Dziewoński: [C: 032] Allow 'T-' prefixed sections, and redirect if section link title isn't current page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327398 (https://phabricator.wikimedia.org/T153176) (owner: 10Esanders) [22:30:09] (03CR) 10Bartosz Dziewoński: [C: 032] "Per comment there." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327721 (https://phabricator.wikimedia.org/T152429) (owner: 10Alex Monk) [22:30:31] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I was just reviewing that and noticed this. Merged now." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330419 (owner: 10Alex Monk) [22:30:42] (03Merged) 10jenkins-bot: ApiVisualEditorEditor#postData: Use isset on oldid post param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) (owner: 10Jforrester) [22:31:12] (03PS6) 10Bartosz Dziewoński: Fix loadFail parameter handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327721 (https://phabricator.wikimedia.org/T151278) (owner: 10Alex Monk) [22:31:17] (03CR) 10Bartosz Dziewoński: [C: 032] Fix loadFail parameter handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327721 (https://phabricator.wikimedia.org/T151278) (owner: 10Alex Monk) [22:31:46] (03CR) 10Bartosz Dziewoński: [C: 032] "(Added mention of T151278 to commit message, was mentioned in a comment here earlier)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327721 (https://phabricator.wikimedia.org/T151278) (owner: 10Alex Monk) [22:31:58] 10VisualEditor, 07Accessibility: Hidden HTML comments are in very light grey and hard to read - https://phabricator.wikimedia.org/T154622#2918078 (10Quiddity) [22:34:31] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 07Technical-Debt: mw.DesktopArticleTarget.prototype#loadFail sometimes given (unexpected?) jqXHR - https://phabricator.wikimedia.org/T151278#2918114 (10matmarex) a:03AlexMonk-WMF [22:35:42] (03CR) 10jenkins-bot: ApiVisualEditorEditor#postData: Use isset on oldid post param [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330458 (https://phabricator.wikimedia.org/T154559) (owner: 10Jforrester) [22:38:35] (03Merged) 10jenkins-bot: Allow 'T-' prefixed sections, and redirect if section link title isn't current page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327398 (https://phabricator.wikimedia.org/T153176) (owner: 10Esanders) [22:38:55] 10VisualEditor: Hidden HTML comments are not selectable text - https://phabricator.wikimedia.org/T154624#2918120 (10Quiddity) [22:43:12] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Can't edit transcluded sections - https://phabricator.wikimedia.org/T153176#2918158 (10Jdforrester-WMF) 05Open>03Resolved [22:44:25] 10VisualEditor: Hidden HTML comments are not selectable text - https://phabricator.wikimedia.org/T154624#2918120 (10Jdforrester-WMF) You can select it by opening it with "Edit". Making the content snippet shown in the surface, or in the context menu, selectable would break, I think. [22:46:27] (03Merged) 10jenkins-bot: Fix loadFail parameter handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327721 (https://phabricator.wikimedia.org/T151278) (owner: 10Alex Monk) [22:47:27] (03CR) 10jenkins-bot: Allow 'T-' prefixed sections, and redirect if section link title isn't current page [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327398 (https://phabricator.wikimedia.org/T153176) (owner: 10Esanders) [22:52:07] (03CR) 10jenkins-bot: Fix loadFail parameter handling [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/327721 (https://phabricator.wikimedia.org/T151278) (owner: 10Alex Monk) [22:54:07] 10VisualEditor, 10VisualEditor-MediaWiki, 07Technical-Debt: mw.DesktopArticleTarget.prototype#loadFail sometimes given (unexpected?) jqXHR - https://phabricator.wikimedia.org/T151278#2918188 (10Jdforrester-WMF) 05Open>03Resolved [22:55:31] 10VisualEditor, 10VisualEditor-MediaWiki, 05WMF-deploy-2017-01-17_(1.29.0-wmf.8): Weird dialog box asking me "http" appears on editing a page - https://phabricator.wikimedia.org/T152429#2918197 (10Jdforrester-WMF) 05Open>03Resolved Let's aspirationally say we'll have fixed this. [23:38:20] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2918257 (10GWicke) [23:40:37] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2918289 (10GWicke) With T152221 resolved it seems that only T152220 remains to be done until we can call this done. @Esanders, @mobrovac, @Jdforrester-WMF, could you t...