[00:29:38] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Language inspector does not work in NWE, crasher with error "Uncaught TypeError: Cannot read property 'clone' of null" - https://phabricator.wikimedia.org/T154636#2918430 (10Ryasmeen) [00:44:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Adding citation is not working with NWE, nothing gets added to the page after clicking on "Insert" - https://phabricator.wikimedia.org/T153509#2918472 (10Ryasmeen) This happens when adding citation from Basic Reference dialog. Cite Web/Automatic thos... [00:45:18] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Adding citation from "Basic Form" is not working with NWE, nothing gets added to the page after clicking on "Insert" - https://phabricator.wikimedia.org/T153509#2918473 (10Ryasmeen) [00:56:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: "Templates used" section appears empty after opening NWE with a section link - https://phabricator.wikimedia.org/T154638#2918482 (10Ryasmeen) [01:03:55] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: [Regression pre-wmf.8] "Page Settings" section is accessible from Options in NWE although it's disabled in the menu - https://phabricator.wikimedia.org/T154639#2918497 (10Ryasmeen) [01:04:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Language inspector does not work in NWE, crashes with error "Uncaught TypeError: Cannot read property 'clone' of null" - https://phabricator.wikimedia.org/T154636#2918509 (10Ryasmeen) [03:36:21] 10Cite, 13Patch-For-Review, 07User-notice: Render references list in multiple columns based on the number of items - https://phabricator.wikimedia.org/T33597#2918628 (10Krinkle) p:05High>03Normal [03:45:10] 10VisualEditor, 07Accessibility: Hidden HTML comments are in very light grey and hard to read - https://phabricator.wikimedia.org/T154622#2918078 (10Volker_E) Oh, there's some image transformation magic going on. The color of the Gifs seems to be maximum `#919191`. The text inside the dialog is currently `#555... [04:38:29] How-to install other extensions to the editor, with config...? [07:23:08] (03PS13) 10Divec: Store metadata as block nodes in the main data list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 [07:23:50] (03CR) 10Divec: "Manual rebase and s/2016/2017/" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 (owner: 10Divec) [07:24:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330641 (owner: 10L10n-bot) [07:46:56] 10VisualEditor, 10VisualEditor-ContentEditable, 10VisualEditor-EditingTools: wikitable sortable in visual editor - https://phabricator.wikimedia.org/T154649#2918805 (10Pearli123) [08:18:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When editting on a section NWE should add in the summary the section being editted as it happens whith raw wikitext - https://phabricator.wikimedia.org/T154650#2918858 (10MarcoAurelio) [08:41:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When editting on a section NWE should add in the summary the section being editted as it happens whith raw wikitext - https://phabricator.wikimedia.org/T154650#2918888 (10Schnark) [08:41:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-01-03_(1.29.0-wmf.7): NWE: Edit section does not add section title into summary - https://phabricator.wikimedia.org/T153245#2918891 (10Schnark) [11:24:17] 10Cite, 10MediaWiki-extensions-ContentTranslation, 07Tracking: ContentTranslation issues with references (tracking) - https://phabricator.wikimedia.org/T115045#2919198 (10Amire80) [12:56:02] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Performance, 07Performance: Support editing parts of a page in VisualEditor - https://phabricator.wikimedia.org/T50429#2919350 (10Liuxinyu970226) [13:31:48] (03PS6) 10Mvolz: ve.ui.CiteFromIdInspector: Add check for empty templates [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (https://phabricator.wikimedia.org/T92428) (owner: 10Ethanlee) [13:32:12] (03CR) 10Mvolz: "recheck" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (https://phabricator.wikimedia.org/T92428) (owner: 10Ethanlee) [13:32:19] (03PS7) 10Mvolz: ve.ui.CiteFromIdInspector: Add check for empty templates [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (https://phabricator.wikimedia.org/T92428) (owner: 10Ethanlee) [13:32:30] (03CR) 10Mvolz: "recheck" [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (https://phabricator.wikimedia.org/T92428) (owner: 10Ethanlee) [13:37:58] (03CR) 10Mvolz: [C: 032] ve.ui.CiteFromIdInspector: Add check for empty templates [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (https://phabricator.wikimedia.org/T92428) (owner: 10Ethanlee) [13:38:13] (03Restored) 10Mvolz: Add ISBN to field name and credit Worldcat [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/327512 (owner: 10Mvolz) [13:38:17] (03PS2) 10Mvolz: Add ISBN to field name and credit Worldcat [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/327512 [13:39:25] (03Merged) 10jenkins-bot: ve.ui.CiteFromIdInspector: Add check for empty templates [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/326112 (https://phabricator.wikimedia.org/T92428) (owner: 10Ethanlee) [13:40:40] (03PS7) 10Mvolz: Use new restbase endpoint for service [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/327244 [14:56:04] edsanders: hey, got some time for reviews today? i'm starting to lose track of my open patches. most of these should be trivial, some of the UploadWizard are followups to your eslint work. https://gerrit.wikimedia.org/r/#/q/owner:matma.rex%2540gmail.com+status:open [14:58:25] MatmaRex: yeah I'll have a look later, just packing atm [15:00:16] (03CR) 10Bartosz Dziewoński: [C: 032] Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329061 (owner: 10Alex Monk) [15:00:31] thanks [15:08:33] (03Merged) 10jenkins-bot: Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329061 (owner: 10Alex Monk) [15:10:28] (03CR) 10jenkins-bot: Fix MWInternalLinkAnnotation.getTargetDataFromHref's behaviour with URLs containing query parts [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/329061 (owner: 10Alex Monk) [15:15:02] (03PS2) 10Alex Monk: More error handling fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330419 [15:20:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Language inspector does not work in NWE, crashes with error "Uncaught TypeError: Cannot read property 'clone' of null" - https://phabricator.wikimedia.org/T154636#2919549 (10DLynch) [15:20:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: Uncaught TypeError: Cannot read property 'clone' of null when inserting language - https://phabricator.wikimedia.org/T153378#2919552 (10DLynch) [15:30:56] (03CR) 10Bartosz Dziewoński: [C: 032] ui.Surface: scrollCursorIntoView should handle below the screen, too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/328395 (https://phabricator.wikimedia.org/T153628) (owner: 10DLynch) [15:35:27] (03Merged) 10jenkins-bot: ui.Surface: scrollCursorIntoView should handle below the screen, too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/328395 (https://phabricator.wikimedia.org/T153628) (owner: 10DLynch) [15:39:32] (03CR) 10jenkins-bot: ui.Surface: scrollCursorIntoView should handle below the screen, too [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/328395 (https://phabricator.wikimedia.org/T153628) (owner: 10DLynch) [15:41:02] (03CR) 10Bartosz Dziewoński: [C: 031] "Looks sane. Good to go?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330419 (owner: 10Alex Monk) [15:59:56] 10VisualEditor, 10VisualEditor-ContentLanguage: Switching from wikitext mode to visual editor converts the local "DEFAULTSORT" message to the English message - https://phabricator.wikimedia.org/T154669#2919637 (10Stryn) [16:29:37] 10VisualEditor, 10VisualEditor-ContentEditable: [Regression 1.28.0-wmf.15] VE does not scroll cursor into view when adding new lines to end of document - https://phabricator.wikimedia.org/T153628#2919731 (10Jdforrester-WMF) [16:31:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: [Regression pre-wmf.8] "Page Settings" section is accessible from Options in NWE although it's disabled in the menu - https://phabricator.wikimedia.org/T154639#2918497 (10Jdforrester-WMF) p:05Triage>03High [16:57:47] 10VisualEditor, 10Wikimedia-Site-requests: Enable visual editor in Wikipedia namespace in Finnish Wikipedia - https://phabricator.wikimedia.org/T154678#2919860 (10Stryn) [17:09:03] 10TemplateData, 10VisualEditor, 10MediaWiki-extensions-ContentTranslation, 07I18n, and 3 others: reconsider terminology about template parameters in VisualEditor and ContentTranslation - https://phabricator.wikimedia.org/T151865#2919903 (10Volker_E) [17:42:15] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 07User-notice: Move the Categories item to the top of the Page options menu because it's used more - https://phabricator.wikimedia.org/T74399#774307 (10Johan) When will this go into production? [18:20:38] (03CR) 10Esanders: "What does this fix? I can insert languages fine in source mode." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330441 (https://phabricator.wikimedia.org/T153378) (owner: 10DLynch) [18:20:55] 10VisualEditor, 10MobileFrontend, 06Reading-Web-Backlog, 13Patch-For-Review: HTML-based CAPTCHAs don't display properly on mobile frontend. - https://phabricator.wikimedia.org/T154082#2920236 (10MBinder_WMF) [18:22:58] (03CR) 10DLynch: "Use the insert-language menu item with nothing selected. It'll error out, in such a way that the inspector cannot be closed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330441 (https://phabricator.wikimedia.org/T153378) (owner: 10DLynch) [18:26:40] (03CR) 10DLynch: "To explain the issue in more detail, this is two things happening:" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/330441 (https://phabricator.wikimedia.org/T153378) (owner: 10DLynch) [18:27:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Sometimes old WikiText editor loads after user has switched to new WikiText editor - https://phabricator.wikimedia.org/T153561#2920289 (10Whatamidoing-WMF) @Dvorapa: Is your account configured to show one tab or two ("Edit" and "Edit source")? [18:38:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Sometimes old WikiText editor loads after user has switched to new WikiText editor - https://phabricator.wikimedia.org/T153561#2920316 (10Urbanecm) Cswiki users can't have one tab yet. Dvorapa is cswiki user. [18:39:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Sometimes old WikiText editor loads after user has switched to new WikiText editor - https://phabricator.wikimedia.org/T153561#2920318 (10Urbanecm) >>! In T153561#2916093, @Arrbee wrote: > I saw this happening when clicking red links i.e. if I select... [18:40:36] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Sometimes old WikiText editor loads after user has switched to new WikiText editor - https://phabricator.wikimedia.org/T153561#2920332 (10Urbanecm) [19:02:39] 10Citoid, 10VisualEditor, 07Easy, 03Google-Code-In-2016, and 2 others: Show "we were unable to make citation for you" instead of offering completely empty template. - https://phabricator.wikimedia.org/T92428#1110478 (10Jdforrester-WMF) a:03ethanlee [19:04:25] (03CR) 10Jforrester: [C: 032] Use new restbase endpoint for service (031 comment) [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/327244 (owner: 10Mvolz) [19:05:47] (03Merged) 10jenkins-bot: Use new restbase endpoint for service [extensions/Citoid] - 10https://gerrit.wikimedia.org/r/327244 (owner: 10Mvolz) [19:07:55] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2920441 (10Jdforrester-WMF) [19:07:57] 10Citoid, 10VisualEditor, 13Patch-For-Review: Change requests in citoid extension to new RESTBase endpoint. - https://phabricator.wikimedia.org/T152220#2920439 (10Jdforrester-WMF) 05Open>03Resolved Will roll out with wmf.8, so should be completed by 20th January if nothing goes wrong. [19:08:07] 10Citoid, 10VisualEditor, 13Patch-For-Review: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#2920442 (1... [19:08:30] 10Citoid, 10VisualEditor, 13Patch-For-Review: Add ability to request base types in citoid, and offer use of both in extension for backwards compatibility until all templateData has been updated, and undo its use in extension, including use of templateData - https://phabricator.wikimedia.org/T114515#1874389 (1... [19:21:36] 10Citoid, 10VisualEditor, 13Patch-For-Review: Change requests in citoid extension to new RESTBase endpoint. - https://phabricator.wikimedia.org/T152220#2920529 (10Mvolz) [19:21:42] 10Citoid, 10VisualEditor: Change requests in citoid extension to new RESTBase endpoint. - https://phabricator.wikimedia.org/T152220#2842076 (10Mvolz) [19:22:34] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#2920532 (10Mvolz) [19:22:46] 10Citoid, 10VisualEditor, 06Operations, 10RESTBase, and 5 others: Set-up Citoid behind RESTBase - https://phabricator.wikimedia.org/T108646#1526094 (10Mvolz) [19:22:55] 10Citoid, 10VisualEditor: Change requests in citoid extension to new RESTBase endpoint. - https://phabricator.wikimedia.org/T152220#2842076 (10Mvolz) [19:27:22] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki-2017WikitextEditor: Consider allowing sequences (like {{ [[ etc.) in wikitext mode - https://phabricator.wikimedia.org/T153956#2920569 (10Jdforrester-WMF) p:05Triage>03Normal [19:35:10] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: SurfaceWidget when active should be styled like other OOUI widgets are (blue box/etc.) - https://phabricator.wikimedia.org/T78358#843255 (10Volker_E) @Jdforrester-WMF Is this still a problem? Seems fixed to me (alternate text box)… [19:36:01] 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References, 07Design, 07Voice & Tone: Change label "Basic form" to something clearer - https://phabricator.wikimedia.org/T108713#2920616 (10Volker_E) [19:43:24] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: SurfaceWidget when active should be styled like other OOUI widgets are (blue box/etc.) - https://phabricator.wikimedia.org/T78358#2920663 (10Jdforrester-WMF) The alternate text box is not a SurfaceWidget, it's a TextInputWidget. The problem is with the capt... [19:43:53] 10VisualEditor, 10Wikimedia-Site-requests, 07Community-consensus-needed, 15User-Urbanecm: Enable visual editor in Wikipedia namespace in Finnish Wikipedia - https://phabricator.wikimedia.org/T154678#2920667 (10Urbanecm) Sorry, I've misread. Reverting my project change back. Signature is possible and will... [19:44:15] 10VisualEditor, 10Wikimedia-Site-requests, 07Community-consensus-needed, 15User-Urbanecm: Enable visual editor in Wikipedia namespace in Finnish Wikipedia - https://phabricator.wikimedia.org/T154678#2920673 (10Urbanecm) @Jdforrester-WMF can be helpful there too. [19:46:45] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: SurfaceWidget when active should be styled like other OOUI widgets are (blue box/etc.) - https://phabricator.wikimedia.org/T78358#2920686 (10Jdforrester-WMF) [19:53:28] 10VisualEditor, 07Design: Emphasize VE's save button by animating the progress bar attached to the bottom of the toolbar - https://phabricator.wikimedia.org/T99274#2920745 (10Volker_E) In contrast to the last screen where the Save button is hidden – which is in my opinion more confusing to users, than starting... [20:06:16] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review, 07User-notice: Move the Categories item to the top of the Page options menu because it's used more - https://phabricator.wikimedia.org/T74399#2920791 (10Jdforrester-WMF) >>! In T74399#2920013, @Johan wrote: > When will this go into production?... [20:15:47] (03CR) 10Jforrester: "What's the review strategy for this? I mean, it looks fine, the tests pass, it seems to work…" (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 (owner: 10Divec) [20:18:28] 10VisualEditor, 10Wikimedia-Site-requests, 07Community-consensus-needed, 15User-Urbanecm: Enable visual editor in Wikipedia namespace in Finnish Wikipedia - https://phabricator.wikimedia.org/T154678#2920831 (10Jdforrester-WMF) Happy to help out. [20:43:36] 10VisualEditor, 10VisualEditor-MediaWiki, 07Design: Polish : VisualEditor Loading indicator should feel more integrated into the interface - https://phabricator.wikimedia.org/T1181#20433 (10Volker_E) Related to {T99274} [20:43:42] 10VisualEditor, 10Wikimedia-Site-requests, 07Community-consensus-needed, 15User-Urbanecm: Enable visual editor in Wikipedia namespace in Finnish Wikipedia - https://phabricator.wikimedia.org/T154678#2920875 (10Stryn) If it requires more participants I have asked people again to comment there https://fi.wik... [21:00:33] 10VisualEditor: VisualEditor, after save, intermittently leaves the browser believing that VisualEditor is still running - https://phabricator.wikimedia.org/T154093#2901055 (10Krinkle) I also see this from time to time. It seems various different parts of the editor teardown don't happen sometimes. Just now I m... [21:01:36] 10VisualEditor: After saving in VisualEditor some parts are not deactivated (intermittent) - https://phabricator.wikimedia.org/T154093#2901055 (10Krinkle) [21:05:48] 10VisualEditor: Inserting row in VE duplicated entire contents of table - https://phabricator.wikimedia.org/T154699#2920922 (10Deskana) [21:06:31] Is there an easy way to get a GUI for editing and saving arbitrary JSON on a wiki page? Basically, a generic equivalent of the TemplateData editor? [21:10:06] Ah, nevermind. Naming a page with the .json extension is the trick I was looking for. [21:49:45] (03Abandoned) 10Alex Monk: More error handling fixes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/330419 (owner: 10Alex Monk) [21:49:50] (03Abandoned) 10Alex Monk: [WIP] Undo support [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/323357 (https://phabricator.wikimedia.org/T78550) (owner: 10Alex Monk) [21:49:56] (03Abandoned) 10Alex Monk: [WIP] Improve template parameter type fallback/return [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/286917 (https://phabricator.wikimedia.org/T133681) (owner: 10Alex Monk) [21:50:16] (03Abandoned) 10Alex Monk: Use NumberInputWidget for number template parameter fields [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/269433 (https://phabricator.wikimedia.org/T124850) (owner: 10Alex Monk) [21:51:43] (03Abandoned) 10Alex Monk: [WIP] Allow TemplateData to output information about magic words [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/140445 (https://phabricator.wikimedia.org/T51996) (owner: 10Alex Monk) [21:51:53] (03Abandoned) 10Alex Monk: [WIP] Add a parameter key to limit possible valid values to a given set [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/263655 (https://phabricator.wikimedia.org/T53375) (owner: 10Alex Monk) [21:54:39] 10VisualEditor, 10Wikimedia-Site-requests, 07Community-consensus-needed, 15User-Urbanecm: Enable visual editor in Wikipedia namespace in Finnish Wikipedia - https://phabricator.wikimedia.org/T154678#2921059 (10Susannaanas) I'm afraid being forced to use Flow will be a no-go. Or at least we must make it ver... [22:16:51] (03PS1) 10Chad: Don't allow $section to be unset [extensions/VisualEditor] (wmf/1.29.0-wmf.7) - 10https://gerrit.wikimedia.org/r/330740 [22:22:31] 10TemplateData, 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: TemplateData: Add parameter type for selecting one of predefined values (like "