[00:39:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, and 2 others: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2974942 (10Volker_E) 05declined>03Open Re-open through ongoing questions apart from flawed proposal on m... [00:40:06] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2974952 (10Volker_E) [03:46:45] (03CR) 10Jforrester: [C: 032] Further "custom format" spec tweaks. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/332569 (owner: 10C. Scott Ananian) [03:48:29] (03Merged) 10jenkins-bot: Further "custom format" spec tweaks. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/332569 (owner: 10C. Scott Ananian) [03:48:40] (03CR) 10jenkins-bot: Further "custom format" spec tweaks. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/332569 (owner: 10C. Scott Ananian) [03:54:16] (03CR) 10Jforrester: "Testable? https://doc.wikimedia.org/cover/visualeditor/Chrome%2055.0.2883%20(Linux%200.0.0)/src/ce/keydownhandlers/index.html suggests a b" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334368 (https://phabricator.wikimedia.org/T156376) (owner: 10Esanders) [06:41:50] (03CR) 10Bartosz Dziewoński: [C: 04-1] MWSaveDialog: only focus summary if we're on the save panel (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334373 (https://phabricator.wikimedia.org/T153958) (owner: 10DLynch) [06:50:05] (03CR) 10Bartosz Dziewoński: "Hm, neat, but we don't actually prefill with this version of the patch?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334151 (https://phabricator.wikimedia.org/T155818) (owner: 10DLynch) [06:51:39] (03PS2) 10DLynch: MWSaveDialog: only focus summary if we're on the save panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334373 (https://phabricator.wikimedia.org/T153958) [06:54:09] (03CR) 10DLynch: "Yeah, this version has it as a placeholder." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334151 (https://phabricator.wikimedia.org/T155818) (owner: 10DLynch) [07:00:38] (03CR) 10Bartosz Dziewoński: "I can't get this to work. As I understand, if I have a page with content like:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:03:49] (03CR) 10Bartosz Dziewoński: "Hm, hold on, maybe it's just my fault." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:09:18] (03CR) 10DLynch: "I do have some evidence for it working on Firefox: https://phabricator.wikimedia.org/F5370054" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:10:43] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Aha, I see it :D This was added to the 'ext.visualEditor.mwwikitext' module, so it only gets loaded with the VE wikitext editor. It works " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:12:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "(Actually, it always works if you have the wikitext beta feature enabled at all, and never works if you don't.)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:12:54] (03CR) 10DLynch: "Ah, good catch, thanks. Probably mwcore." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:13:45] (03PS5) 10DLynch: Override ui.CommentInspector so that copying from it sets text/x-wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) [07:15:41] (03CR) 10Bartosz Dziewoński: [C: 032] Override ui.CommentInspector so that copying from it sets text/x-wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:16:03] (03CR) 10Bartosz Dziewoński: [C: 032] MWSaveDialog: only focus summary if we're on the save panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334373 (https://phabricator.wikimedia.org/T153958) (owner: 10DLynch) [07:17:48] (03CR) 10Bartosz Dziewoński: "The task asked to prefill it, so that it can be easily edited, rather than forcing the user to back out of dialog and copy-paste from the " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334151 (https://phabricator.wikimedia.org/T155818) (owner: 10DLynch) [07:25:30] (03Merged) 10jenkins-bot: Override ui.CommentInspector so that copying from it sets text/x-wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:25:32] (03Merged) 10jenkins-bot: MWSaveDialog: only focus summary if we're on the save panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334373 (https://phabricator.wikimedia.org/T153958) (owner: 10DLynch) [07:27:45] (03CR) 10jenkins-bot: Override ui.CommentInspector so that copying from it sets text/x-wiki [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/331535 (https://phabricator.wikimedia.org/T154837) (owner: 10DLynch) [07:29:26] (03CR) 10jenkins-bot: MWSaveDialog: only focus summary if we're on the save panel [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334373 (https://phabricator.wikimedia.org/T153958) (owner: 10DLynch) [08:04:27] (03PS17) 10Divec: WIP: Store metadata as block nodes in the main data list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 [08:08:12] (03CR) 10jerkins-bot: [V: 04-1] WIP: Store metadata as block nodes in the main data list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 (owner: 10Divec) [08:21:08] 10Citoid, 10VisualEditor, 10Possible-Tech-Projects, 07Documentation, 10Outreachy (Round-13): Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#2975446 (10Amit_gkp) @srishakatux I'm mentoring RGSO... [08:32:50] (03PS8) 10Divec: WIP: Make RebaseServer asynchronous [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/331423 [08:37:53] 10VisualEditor, 13Patch-For-Review: Formatting issues with Edit Notices window - https://phabricator.wikimedia.org/T156407#2975493 (10Whatamidoing-WMF) Volker, your idea seems okay generally, but I don't know if the established editors at the English Wikipedia would accept these changes. [10:04:54] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel: Inline node pasted into an annotation throws exception - https://phabricator.wikimedia.org/T156463#2975727 (10Esanders) [10:06:48] (03PS1) 10Esanders: Fix annotation of nodes in document insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334517 (https://phabricator.wikimedia.org/T156463) [10:11:43] (03PS1) 10WMDE-Fisch: Add missing return in doc block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334522 [10:14:10] 10VisualEditor: Edit notices icon (ve-ui-mwNoticesPopupTool-items) is empty for new articles - https://phabricator.wikimedia.org/T156432#2975773 (10Esanders) It's likely a local wiki issue or with a specific user setup which hides the message with CSS. I think @Krinkle knows how to fix it on the wiki, but I coul... [10:16:29] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 11 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2975775 (10akosiaris) 05Open>03Resolved And etherpad is now upgraded to 1.6.0-2 running on nodejs 6.9.1~dfsg-1+wmf1. Resolving the task once more [10:16:52] 10Citoid, 10VisualEditor, 10Analytics, 10ChangeProp, and 11 others: Node 6 upgrade planning - https://phabricator.wikimedia.org/T149331#2975777 (10akosiaris) [10:20:02] (03CR) 10Esanders: [C: 032] Add missing return in doc block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334522 (owner: 10WMDE-Fisch) [10:25:29] 10VisualEditor, 13Patch-For-Review: Formatting issues with Edit Notices window - https://phabricator.wikimedia.org/T156407#2975826 (10Esanders) These are WMF specific styles, possibly en.wiki styles. If we're going to hack them then we should do it on-wiki where they are defined: https://en.wikipedia.org/wiki/... [10:26:13] (03CR) 10Esanders: [C: 04-2] "These are en.wiki hacked styles in MediaWiki:common.css, so these fixes should go there, not in the code." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334444 (https://phabricator.wikimedia.org/T156407) (owner: 10VolkerE) [10:29:26] (03Merged) 10jenkins-bot: Add missing return in doc block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334522 (owner: 10WMDE-Fisch) [10:32:34] (03CR) 10jenkins-bot: Add missing return in doc block [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334522 (owner: 10WMDE-Fisch) [10:50:51] (03PS1) 10Hashar: .gitreview: update defaultbranch to REL1_23 [extensions/WikiEditor] (REL1_23) - 10https://gerrit.wikimedia.org/r/334540 (https://phabricator.wikimedia.org/T66157) [10:57:12] (03CR) 10jerkins-bot: [V: 04-1] .gitreview: update defaultbranch to REL1_23 [extensions/WikiEditor] (REL1_23) - 10https://gerrit.wikimedia.org/r/334540 (https://phabricator.wikimedia.org/T66157) (owner: 10Hashar) [12:10:14] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Drag-and-drop of image from the file page into VisualEditor should insert a thumbnail, not an external link - https://phabricator.wikimedia.org/T151647#2976114 (10Niharika) >>! In T151647#2968890, @matmarex wrote: > There shouldn't be... [12:17:24] (03PS1) 10WMDE-Fisch: Add .idea to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334553 [13:08:04] (03CR) 10Esanders: "Looks ok, but what do I know..." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/331423 (owner: 10Divec) [13:14:03] (03PS3) 10Esanders: Handle home/end/pageup/pagedown keys when on focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334368 (https://phabricator.wikimedia.org/T156376) [13:30:28] 10VisualEditor, 10VisualEditor-CopyPaste: Plain paste (Ctrl+Shift+V) of external content into a non-paragraph node breaks, shows ☂ and/or ☀ - https://phabricator.wikimedia.org/T129310#2976253 (10Esanders) This might not be the same bug - where did you copy the text from? [13:42:45] (03CR) 10Esanders: [C: 04-1] ve.ce.MWTableNode: Provide preview of sortable table styling (034 comments) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/332743 (https://phabricator.wikimedia.org/T139072) (owner: 10Bartosz Dziewoński) [13:57:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/334632 (owner: 10L10n-bot) [14:02:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334638 (owner: 10L10n-bot) [16:06:11] 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#2976763 (10Esanders) | | **Transactions** | **HTML** | **Entire linear model** | | **Initial storage** | None. With the caveat that we will have access to the initial do... [16:11:23] 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#2976776 (10Esanders) The main concern is what happens when we run out of storage. A single document is unlikely to do this, but with multiple documents saved this would... [16:13:47] 10VisualEditor, 10VisualEditor-MediaWiki, 07Epic: VisualEditor: Implement some form of auto-save - https://phabricator.wikimedia.org/T57370#2976780 (10Jdforrester-WMF) Twice HTML => maybe 3.4MiB for Obama => two unsaved edits and we've over-flowed Firefox's local storage, that sucks quite a bit, which would... [16:20:01] (03CR) 10Jforrester: [C: 032] Handle home/end/pageup/pagedown keys when on focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334368 (https://phabricator.wikimedia.org/T156376) (owner: 10Esanders) [16:20:07] (03CR) 10Jforrester: [C: 032] Add .idea to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334553 (owner: 10WMDE-Fisch) [16:23:11] (03Merged) 10jenkins-bot: Handle home/end/pageup/pagedown keys when on focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334368 (https://phabricator.wikimedia.org/T156376) (owner: 10Esanders) [16:26:11] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 13Patch-For-Review, 05WMF-deploy-2017-01-31_(1.29.0-wmf.10): VE: Allow commenting out and uncommenting of wikitext - https://phabricator.wikimedia.org/T154837#2976816 (10Jdforrester-WMF) >>! In T154837#2930051, @Schnark wrote: >>>! In... [16:26:35] 10VisualEditor, 10VisualEditor-EditingTools, 10VisualEditor-MediaWiki, 05WMF-deploy-2017-01-31_(1.29.0-wmf.10): VE: Allow commenting out and uncommenting of wikitext - https://phabricator.wikimedia.org/T154837#2976817 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03DLynch [16:29:13] (03CR) 10jenkins-bot: Handle home/end/pageup/pagedown keys when on focusable nodes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334368 (https://phabricator.wikimedia.org/T156376) (owner: 10Esanders) [16:29:47] (03CR) 10Jforrester: [C: 032] Fix annotation of nodes in document insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334517 (https://phabricator.wikimedia.org/T156463) (owner: 10Esanders) [16:30:29] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-DataModel: Inline node pasted into an annotation throws exception - https://phabricator.wikimedia.org/T156463#2976828 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [16:33:01] (03Merged) 10jenkins-bot: Fix annotation of nodes in document insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334517 (https://phabricator.wikimedia.org/T156463) (owner: 10Esanders) [16:34:50] (03Merged) 10jenkins-bot: Add .idea to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334553 (owner: 10WMDE-Fisch) [16:36:25] (03CR) 10jenkins-bot: Fix annotation of nodes in document insertion [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334517 (https://phabricator.wikimedia.org/T156463) (owner: 10Esanders) [16:37:17] (03CR) 10jenkins-bot: Add .idea to .gitignore [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334553 (owner: 10WMDE-Fisch) [16:45:18] (03CR) 10Esanders: [C: 032] Follow-up c352e8f: Don't use i18n key clashing with archaïc usage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334351 (owner: 10Jforrester) [16:47:47] 10VisualEditor, 10VisualEditor-ContentLanguage: Pressing the Shift key moves the cursor (Windows only?) - https://phabricator.wikimedia.org/T156228#2976876 (10Esanders) Which version of IE. I can't reproduce. [16:48:34] (03Merged) 10jenkins-bot: Follow-up c352e8f: Don't use i18n key clashing with archaïc usage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334351 (owner: 10Jforrester) [16:51:12] (03CR) 10jenkins-bot: Follow-up c352e8f: Don't use i18n key clashing with archaïc usage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334351 (owner: 10Jforrester) [16:51:36] 10Citoid, 10VisualEditor: In Visual Editor 'Add a citation tool' if the title of the URL has a | in it is causes an error message to show up - https://phabricator.wikimedia.org/T156366#2976883 (10Esanders) [16:52:26] 10Citoid, 10VisualEditor: In Visual Editor 'Add a citation tool' if the title of the URL has a | in it is causes an error message to show up - https://phabricator.wikimedia.org/T156366#2972506 (10Esanders) The URL doesn't have a pipe in it but I do get an error: {F5376763,size=full} [16:56:45] (03PS1) 10Jforrester: Update VE core submodule to master (e5dffec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334678 (https://phabricator.wikimedia.org/T151404) [16:58:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Feature request - A Preview panel that doesn't obscure the wikitext box - https://phabricator.wikimedia.org/T155732#2976906 (10Esanders) >>! In T155732#2964588, @dialmove wrote: > But both are displayed in the same page, which means that at least I c... [16:58:19] (03PS4) 10Jforrester: Remove VE standalone module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309472 (owner: 10Esanders) [16:59:31] (03CR) 10Jforrester: [C: 04-1] "Unit test failures look real?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/333963 (owner: 10Esanders) [17:02:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#2876033 (10Esanders) We are looking in to this. Also for those that are interested, the acce... [17:03:51] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#2976933 (10Esanders) >>! In T153306#2885372, @Tgr wrote: > Also, the save button is scary fo... [17:04:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When pasting text, don't translate multiple normal spaces into multiple non-breaking spaces - https://phabricator.wikimedia.org/T156498#2976934 (10Whatamidoing-WMF) [17:09:28] (03CR) 10jerkins-bot: [V: 04-1] Remove VE standalone module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309472 (owner: 10Esanders) [17:10:50] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editor reload after switching to another tab in your browser on desktop - https://phabricator.wikimedia.org/T156378#2976971 (10Esanders) [17:11:05] 10VisualEditor: Edit notices icon (ve-ui-mwNoticesPopupTool-items) is empty for new articles - https://phabricator.wikimedia.org/T156432#2976973 (10Etonkovidova) @Esanders The issue is on enwiki and cawiki (wmf.8 and wmf.9); the user does not have any specific setups. [17:13:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: It would be nice to have Show preview and Review your changes more directly accessible in the New Wikitext Editor - https://phabricator.wikimedia.org/T153306#2976975 (10Elitre) [17:23:23] 10VisualEditor, 13Patch-For-Review: Formatting issues with Edit Notices window - https://phabricator.wikimedia.org/T156407#2977000 (10Volker_E) @Whatamidoing-WMF What do you think would be challenged? The layout change of those message boxes within Visual Editor's edit notices (and only there) or adding VE rel... [17:24:24] (03PS1) 10Esanders: Overwrite selected content when pasting via DataTransferItem [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334681 (https://phabricator.wikimedia.org/T154020) [17:26:07] (03CR) 10Jforrester: "Is this just a tedious CI circular dependency? Cite runs with this, but is using… old code, which still pulls in ext.visualEditor.standalo" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309472 (owner: 10Esanders) [17:37:37] (03PS1) 10Esanders: Ensure clipboard is never empty text [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334682 (https://phabricator.wikimedia.org/T156302) [17:40:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When pasting text, don't translate multiple normal spaces into multiple non-breaking spaces - https://phabricator.wikimedia.org/T156498#2977102 (10Whatamidoing-WMF) Original report here: https://www.mediawiki.org/wiki/Topic:Tibkgp6gx32dvc8z [17:40:40] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: When pasting text, don't translate multiple normal spaces into multiple non-breaking spaces - https://phabricator.wikimedia.org/T156498#2976934 (10Esanders) I get `{{Infobox example↵| parameter1 =↵| para2 =↵}}` in both Chrome & FF, which is... [17:46:29] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2977136 (10Esanders) We used the button as a toggle because vertical space is at a premium and it seems wastef... [17:47:37] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10Parsoid: Issues with template parameters - https://phabricator.wikimedia.org/T156507#2977140 (10Elitre) [17:47:48] (03CR) 10Esanders: [C: 032] Update VE core submodule to master (e5dffec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334678 (https://phabricator.wikimedia.org/T151404) (owner: 10Jforrester) [17:56:38] (03Merged) 10jenkins-bot: Update VE core submodule to master (e5dffec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334678 (https://phabricator.wikimedia.org/T151404) (owner: 10Jforrester) [17:58:30] (03CR) 10jenkins-bot: Update VE core submodule to master (e5dffec) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/334678 (https://phabricator.wikimedia.org/T151404) (owner: 10Jforrester) [18:06:28] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2977182 (10Nirzar) @Esanders horizontal space is at premium on the toolbar and it seems wasteful to throw away... [20:24:12] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2977656 (10Esanders) I wasn't saying there weren't better solutions. Just explaining the decision. [20:31:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2977697 (10Nirzar) just questioning that decision because I see a false logic. it's a choice between **40px ve... [20:32:22] (03CR) 10Esanders: [C: 04-1] "No, dependencies are fine, but we (ab)use the SA target in tests." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309472 (owner: 10Esanders) [20:49:30] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2977739 (10Nirzar) furthermore, as this is an unique panel, we can have a close inside the panel {F5378501}... [20:53:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2977749 (10Volker_E) I'd see a panel like proposed in the comment above by @Nirzar as favorable, actually had... [20:59:33] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2977761 (10Nirzar) moving symbol out of toolbar has added advantage of that icon with a label. right now the i... [22:28:01] (03PS1) 10Esanders: Create dummy platform and target for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334724 [22:36:09] (03PS2) 10Esanders: Create dummy platform and target for tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334724 [22:43:19] (03PS5) 10Esanders: Remove VE standalone module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309472 [22:46:22] 10Citoid, 10VisualEditor: In Visual Editor 'Add a citation tool' if the title of the URL has a | in it is causes an error message to show up - https://phabricator.wikimedia.org/T156366#2978735 (10Mrjohncummings) Yes, sorry, that's what I meant, thanks [22:48:59] (03CR) 10jerkins-bot: [V: 04-1] Remove VE standalone module [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/309472 (owner: 10Esanders)