[00:09:07] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 3 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#2955370 (10Krinkle) In any event, I would recommend against a situation where all templates with styles register a module... [00:50:15] 10VisualEditor: Adding a mw typeof to html pre strips newlines in rendering in VE - https://phabricator.wikimedia.org/T156675#2983281 (10Catrope) What is Template:1x? Is it like Template:Echo? What is the HTML corresponding to the 1x example? [01:24:16] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 3 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#2984571 (10Tgr) >>! In T155813#2983904, @Anomie wrote: > Should we be changing all of those extensions to load styles and... [01:45:52] 10VisualEditor: Adding a mw typeof to html pre strips newlines in rendering in VE - https://phabricator.wikimedia.org/T156675#2984624 (10Arlolra) @Catrope Yeah, `1x` replaced `Echo` Here's Parsoid's output for two, respectively, ``` 
haha  noooo  haha
``... [01:48:08] 10VisualEditor: Adding a mw typeof to html pre strips newlines in rendering in VE - https://phabricator.wikimedia.org/T156675#2984633 (10Arlolra) And here's a screenshot of what that looks like in VE, {F5424700} [01:51:22] (03PS2) 10Divec: WIPissimo: RebaseServer persistent storage [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/334995 [04:33:25] 10VisualEditor, 10VisualEditor-LanguageTool: Language inspector is too small, has scroll bars - https://phabricator.wikimedia.org/T156735#2984731 (10Catrope) [06:55:50] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 5 others: Discuss CSS storage options with community - https://phabricator.wikimedia.org/T156689#2984826 (10Qgil) @Moushira, please add #community-liaisons to all the CL tasks assigned to you, otherwise it is easy that they fall out of... [09:31:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#2985327 (10Elitre) There is [[ https://www.mediawiki.org/wiki/Topic:Tk54vc0txr00xw0l | a report of this problem ]] happening wit... [09:44:31] (03PS20) 10Divec: WIP: Store metadata as block nodes in the main data list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 [09:47:53] (03CR) 10jerkins-bot: [V: 04-1] WIP: Store metadata as block nodes in the main data list [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/314568 (owner: 10Divec) [12:55:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: VE+NWE: Add ability to submit an edit from summary field or checkboxes underneath - https://phabricator.wikimedia.org/T153241#2986010 (10matmarex) >>! In T153241#2909616, @Dvorapa wrote: > Does anybody started the user testing/logging to see, what us... [13:41:49] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Remove unused $saveActions div [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335221 [13:41:51] (03PS1) 10Bartosz Dziewoński: ve.init.mw.ArticleTarget: Don't try to clear non-existent message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335222 [13:41:53] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Prettify the 'messages' shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335223 [13:41:55] (03PS1) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335224 (https://phabricator.wikimedia.org/T153241) [13:51:15] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.MWSaveDialog: Prettify the 'messages' shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335223 (owner: 10Bartosz Dziewoński) [13:53:15] (03CR) 10jerkins-bot: [V: 04-1] ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335224 (https://phabricator.wikimedia.org/T153241) (owner: 10Bartosz Dziewoński) [15:17:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2986503 (10Esanders) It is also worth noting we have an on-going piece of work to integrate jquery-IME with th... [15:18:43] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 06Collaboration-Team-Triage, 10Flow, 07Design: VE+NWE: Move Omega button into Insert menu - https://phabricator.wikimedia.org/T156349#2986504 (10Esanders) >>! In T156349#2977749, @Volker_E wrote: > @Esanders, was a panel with included close ico... [15:38:32] edsanders: i wanted to update an old wikitext gadget to work with NWE, and maybe document that on https://www.mediawiki.org/wiki/VisualEditor/Gadgets , and i'm trying to figure out how to get the wikitext from the surface and set it back [15:38:51] edsanders: so, given that i have surface = ve.init.target.getSurface(), and it is a wikitext surface (surface.getMode() === 'source') [15:39:01] edsanders: getting is easy, but kind of weird - wikitext = surface.getDom(); [15:39:21] edsanders: but the easiest way to set the wikitext i found is crazy - surface.getModel().getLinearFragment( new ve.Range() ).expandLinearSelection( 'root' ).insertContent( wikitext ) [15:39:30] am i doing this wrong? or is it really the way? [15:41:25] so my only implementation so far was for TemplateData support [15:43:59] this.surface.getModel().getLinearFragment( new ve.Range( 0, this.surface.getModel().getDocument().data.getLength() ) ) [15:43:59] .insertContent( newWikitext ); [15:44:13] so yeah - we could do with a better API [15:44:39] at least for getting a spanning fragment [15:45:25] yeah, that would make it a bit less ugly [15:45:47] but it's still silly that you can get the contents from a ui.Surface, but have to set them from a dm.SurfaceFragment [15:51:10] do you mean set? [15:52:20] * edsanders re-reads - ignore me [15:53:38] I think if you have simple getters/setters for a surface you trick people into thinking they're simple text widgets, but they're not [15:54:08] for example in TemplateData I should really be creating a fragment around the tags and selectively replacing that text [15:54:57] if you have a gadget that creates a giant replace transaction on the whole document just to replace a few words, that will cause headaches down the line [15:55:06] e.g. with collaborative editing or local stashing [15:57:46] well sure, it's not optimal, but realistically, people are not going to completely rewrite gadgets that just did wikitext = $('#wpTextbox1').text(); wikitext = wikitext.replace(…).replace(…).replace(…); $('#wpTextbox1').text( wikitext ); to use whatever API VE has for replacing text [15:57:51] (if it even has one) [16:43:45] (03CR) 10Esanders: "If the extension is fully incompatible with VE then how the code is at the moment is fine. Only move the code if you specifically want to " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335025 (https://phabricator.wikimedia.org/T156251) (owner: 10WMDE-Fisch) [16:47:25] MatmaRex: That's exactly what I want to discourage [16:58:36] I'm not sure how effective discouraging it will be. People will copy whatever boilerplate they need to get that effect. Maybe we should outright rewrite some popular gadgets with The Right Way To Do It, so there's a visible alternative. [16:59:35] yeah, i think this will result in either no one writing/updating any gadgets for NWE (and thus people not using it), or people writing shoddy gadgets that will be breaking left and right. [17:01:38] i'm also not sure about the performance of doing a couple hundred of 'replace all' operations "the right way", with all the transactions and document updates and stuff happening [17:32:09] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: When adding {{DISPLAYTITLE:}} using VE, prefill the input field with the page name - https://phabricator.wikimedia.org/T155818#2987123 (10DLynch) a:03DLynch [17:33:52] (for reference, i was looking into gadgets for NWE because of this thread: https://www.mediawiki.org/wiki/Topic:Thhmt4otpvlbxwxq) [17:34:02] (also, are we still calling it NWE?) [17:37:03] (03PS2) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Prettify the 'messages' shown [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335223 [17:37:11] (03PS2) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335224 (https://phabricator.wikimedia.org/T153241) [18:18:00] MatmaRex: the operation itself isn't that bad, but the implications could be problematic in the future [18:18:10] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Epic, 07Performance: New Wikitext Editor: Major improvement to load time to edit - https://phabricator.wikimedia.org/T154843#2987279 (10Alsee) >>! In T154843#2982245, @Whatamidoing-WMF wrote: > Alsee, are you running... [18:18:24] what if a popular user gadget starts doing full doc replace several times per session [18:18:43] if we give a simple API we are just encouraging it [18:19:14] yes they'll do it anyway - but it makes it easier for someone to come along later and say "this is garbage, let's make it more efficient" [18:19:49] i'm not sure if 1000 small transactions is more efficient than 1 big transaction. :) [18:19:55] whereas if I have "setDoc(fulltext)" and someone tries to replace that with a loop of replace commands you might see people saying "keep it simple" [18:20:34] depends on the use case - I think 10 word replaces is more efficient that a 1MB full document replace [18:20:43] especially if we implement local stashing of transactions [18:20:53] or sharing of transactions over the wire (collaboration) [18:21:18] or diffs optimised based on transaction ranges [18:21:25] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Urbanecm: Page blanked when editing a section after an edit conflict - https://phabricator.wikimedia.org/T154217#2987285 (10Whatamidoing-WMF) What we need is a reliable way to reproduce this. [18:23:23] I'd rather have some guides showing how to use our find/replace APIs and adding support for multi-line regexes [18:31:17] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 3 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#2987308 (10Anomie) >>! In T155813#2984105, @Krinkle wrote: > In any event, I would recommend against a situation where al... [18:37:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Newly parsed/inserted template content should honour parse data (especially style modules) - https://phabricator.wikimedia.org/T156699#2984063 (10Anomie) > After saving, the text is styled. When I try this, I don't see styled text... [18:37:32] 10VisualEditor: VisualEditor does not handle wikitext that adds ResourceLoader modules correctly - https://phabricator.wikimedia.org/T156414#2987318 (10Anomie) T156699 seems to be steps 3–5 here. [18:40:45] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Epic, 07Performance: New Wikitext Editor: Major improvement to load time to edit - https://phabricator.wikimedia.org/T154843#2987330 (10Alsee) Summary of load times reported at the RFC: Alsee: United States 30 second... [19:52:10] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Selected text is not replaced in new wikitext editor when a paste gets transformed - https://phabricator.wikimedia.org/T154020#2987608 (10Whatamidoing-WMF) In [[https://www.mediawiki.org/w/index.php?title=VisualEditor/Metr... [20:46:23] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Selected text is not replaced in new wikitext editor when a paste gets transformed - https://phabricator.wikimedia.org/T154020#2987674 (10Esanders) It doesn't look like the code has been deployed yet to MW. [22:01:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335354 (owner: 10L10n-bot) [22:32:56] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10SyntaxHighlight: New wikitext editor does not show tracking categories in preview - https://phabricator.wikimedia.org/T156862#2988127 (10Tgr) [23:58:53] 10VisualEditor: VisualEditor doesn't include closing parenthesis while pasting a URI - https://phabricator.wikimedia.org/T156878#2988513 (10MarkAHershberger)