[00:03:08] (03CR) 10Divec: [C: 04-1] Honorably discharge ve.dm.DocumentSynchronizer (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 (owner: 10Catrope) [00:35:19] 10VisualEditor, 10Wikimedia-Site-requests, 06Wiktionary: Enable the Visual Editor for Projet namespace on frwiktionary - https://phabricator.wikimedia.org/T156660#2982858 (10Dereckson) @Pamputt Currently, deployments are overseen by the Editing team at WMF Product. They would like to restrict VE to namespace... [00:36:23] 10VisualEditor, 10Wikimedia-Site-requests, 06Wiktionary: Enable the Visual Editor for Projet namespace on frwiktionary - https://phabricator.wikimedia.org/T156660#2982858 (10Dereckson) a:03Dereckson [02:18:37] 10Citoid, 10VisualEditor, 10Possible-Tech-Projects, 07Documentation, 10Outreachy (Round-13): Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3004156 (10srishakatux) @Amit_gkp thanks for showing... [02:20:20] 10Citoid, 10VisualEditor, 10Possible-Tech-Projects, 07Documentation, 10Outreachy (Round-13): Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3004160 (10srishakatux) @Mvolz and team: Very soon w... [02:32:11] 10Cite, 10Parsoid: Parsoid and the PHP parser handle numeric named references differently - https://phabricator.wikimedia.org/T157405#3004172 (10Tgr) [02:35:54] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3004184 (10Tgr) [02:39:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting lots of text into the new wikitext editor takes very long - https://phabricator.wikimedia.org/T157407#3004197 (10Tgr) [02:44:49] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3004212 (10Tgr) [02:45:13] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting lots of text into the new wikitext editor takes very long - https://phabricator.wikimedia.org/T157407#3004213 (10Tgr) [02:46:57] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor handles selecting/pasting newlines weirdly - https://phabricator.wikimedia.org/T157408#3004220 (10Tgr) [03:28:03] 10Cite, 10Continuous-Integration-Config, 10Parsoid: Parsoid should run tests against the Cite parser tests, not just MediaWiki core's - https://phabricator.wikimedia.org/T114256#3004272 (10Arlolra) a:03Arlolra [07:34:16] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#3004592 (10dialmove) >>! In T153315#3003479, @Whatamidoing-WMF wrote: >>>! In T153315#2945065, @Samw... [08:28:05] (03CR) 10Catrope: Honorably discharge ve.dm.DocumentSynchronizer (037 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 (owner: 10Catrope) [10:11:04] 10VisualEditor, 10VisualEditor-Initialisation: VE plugins from user scripts not always loaded - https://phabricator.wikimedia.org/T157113#3004802 (10Schnark) This might be caused by some strange loading order: when all dependencies of ext.visualEditor.desktopArticleTarget.init are already ready when it loads,... [10:13:44] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3004184 (10Schnark) In Firefox the spaces are almost preserved, only converted to non-breaking ones (which is reported in some other task, I can't find it at... [11:28:30] (03PS3) 10Catrope: Honorably discharge ve.dm.DocumentSynchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 [11:31:36] (03CR) 10Catrope: Honorably discharge ve.dm.DocumentSynchronizer (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 (owner: 10Catrope) [11:56:28] (03PS4) 10Catrope: Honorably discharge ve.dm.DocumentSynchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 [11:57:22] (03CR) 10Catrope: Honorably discharge ve.dm.DocumentSynchronizer (032 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 (owner: 10Catrope) [14:23:08] 10VisualEditor, 06Community-Liaisons, 07Documentation: Write a help page that explains how to create interlanguage and interproject links - https://phabricator.wikimedia.org/T134186#3005588 (10Qgil) p:05Normal>03Low [14:41:03] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#3005654 (10MGChecker) I don't want that the work of power-users is disturbed by unnecassary magic in... [15:36:45] 10Citoid, 10VisualEditor, 10Possible-Tech-Projects, 07Documentation, 10Outreachy (Round-13): Write a Zotero translator and document process for creating new Zotero translator and getting it live in production - https://phabricator.wikimedia.org/T115158#3005846 (10Amit_gkp) @srishakatux Last year I did li... [15:43:15] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: [Regression] Page links are getting added as plain text in NWE when the editor is open for a long time(?) - https://phabricator.wikimedia.org/T156991#3005863 (10DLynch) Problem here is that the CSRF token the editor's using for API calls times out, a... [15:51:08] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor handles selecting/pasting newlines weirdly - https://phabricator.wikimedia.org/T157408#3004220 (10Esanders) ctrl+insert does nothing for me (also using chrome+ubuntu) but replacing that with ctrl+c/v gives the desired results. [16:55:37] (03PS5) 10Catrope: Honorably discharge ve.dm.DocumentSynchronizer [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 [16:55:39] (03PS1) 10Catrope: dm.Document: Make tree validation stricter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336435 [16:59:58] (03CR) 10Catrope: Honorably discharge ve.dm.DocumentSynchronizer (033 comments) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335981 (owner: 10Catrope) [17:19:03] (03PS1) 10DLynch: ArticleTarget: try to refresh editToken if getWikitextFragment fails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) [17:21:05] (03PS2) 10DLynch: ArticleTarget: try to refresh editToken if getWikitextFragment fails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) [17:21:20] (03CR) 10DLynch: "Easy way to test this is to switch line 2187 out for `token: isRetry ? this.editToken : 'foo',`" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [17:32:19] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3006182 (10Anomie) >>! In T155813#2997166, @GWicke wrote: >>>! In T155813#2993846, @Anomie wrote: >>>>! In T155813#299143... [17:37:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 13Patch-For-Review: [Regression] Page links are getting added as plain text in NWE when the editor is open for a long time(?) - https://phabricator.wikimedia.org/T156991#3006226 (10DLynch) I did take a look at whether it'd be easy to have just `ser... [17:56:09] (03PS1) 10Esanders: Fix definition of HTML whitespace in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336445 (https://phabricator.wikimedia.org/T157406) [17:57:04] 10VisualEditor, 13Patch-For-Review: VisualEditor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3006274 (10Esanders) [17:57:38] 10VisualEditor, 13Patch-For-Review: VisualEditor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3004184 (10Esanders) This is actually not specific to NWE, it was a bug in the converter. [18:17:33] 10VisualEditor, 10ArchCom-RfC, 06Parsing-Team, 06Performance-Team, and 4 others: Decide on storage and delivery method for TemplateStyles CSS - https://phabricator.wikimedia.org/T155813#3006350 (10GWicke) >>! In T155813#3006182, @Anomie wrote: > Except this task //isn't// where all the discussion has happe... [18:21:45] (03CR) 10Catrope: [C: 032] Fix definition of HTML whitespace in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336445 (https://phabricator.wikimedia.org/T157406) (owner: 10Esanders) [18:27:33] (03Merged) 10jenkins-bot: Fix definition of HTML whitespace in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336445 (https://phabricator.wikimedia.org/T157406) (owner: 10Esanders) [18:28:23] 10Cite, 10Parsoid, 07Parsoid-Rendering: Add wiki-specific CSS styles for Parsoid Cite output so that it renders exactly like core Cite output - https://phabricator.wikimedia.org/T156351#3006393 (10Elitre) [18:28:34] (03PS1) 10Jforrester: Update VE core submodule to master (121100d74) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336450 (https://phabricator.wikimedia.org/T156599) [18:42:58] (03CR) 10Catrope: [C: 032] Destroy unicorns properly when cursoring to another branch node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335962 (https://phabricator.wikimedia.org/T157019) (owner: 10Divec) [18:43:34] (03CR) 10jenkins-bot: Fix definition of HTML whitespace in converter [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336445 (https://phabricator.wikimedia.org/T157406) (owner: 10Esanders) [18:46:56] (03Merged) 10jenkins-bot: Destroy unicorns properly when cursoring to another branch node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335962 (https://phabricator.wikimedia.org/T157019) (owner: 10Divec) [18:53:22] (03CR) 10jenkins-bot: Destroy unicorns properly when cursoring to another branch node [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/335962 (https://phabricator.wikimedia.org/T157019) (owner: 10Divec) [18:58:16] 10VisualEditor, 10VisualEditor-CopyPaste: VisualEditor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3004184 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03High a:03Esanders [19:02:12] 10VisualEditor, 13Patch-For-Review: Visual diffing: Implement a fallback for when tree diffing takes too long - https://phabricator.wikimedia.org/T156599#3006602 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Esanders [19:03:48] 10VisualEditor, 10VisualEditor-ContentEditable: Unicorn does not get destroyed when arrowing out of a paragraph, causes weird arrow key behavior - https://phabricator.wikimedia.org/T157019#3006607 (10Jdforrester-WMF) 05Open>03Resolved [19:04:05] RoanKattouw: If you're going to be merging things can you +2 https://gerrit.wikimedia.org/r/336450 ? ;-) [19:08:04] (03CR) 10Catrope: [C: 032] Update VE core submodule to master (121100d74) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336450 (https://phabricator.wikimedia.org/T156599) (owner: 10Jforrester) [19:10:44] (03CR) 10Bartosz Dziewoński: "I wonder why VE doesn't just use mw.Api#postWithToken (which handles 'badtoken' errors and retrying automatically). Do we need our own bad" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:11:37] (03CR) 10Jforrester: "I'm pretty sure it pre-dates it." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:11:49] RoanKattouw: You're a champ. [19:12:55] 10VisualEditor, 10MediaWiki-API, 05MW-1.29-release-notes, 05WMF-deploy-2017-01-24_(1.29.0-wmf.9): ApiErrorFormatter_BackCompat: Choose first error, not last, in addWarningOrError - https://phabricator.wikimedia.org/T155268#3006670 (10Jdforrester-WMF) 05Open>03Resolved [19:13:14] (03CR) 10DLynch: "I admit, I just assumed that since this code was already in here to handle this case, there wasn't a core function for it. I'll look at po" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:15:48] (03CR) 10Bartosz Dziewoński: "Looking more closely, some of what we do here is actually custom, e.g. we check if the user was logged out and display a custom warning. S" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:18:37] (03Merged) 10jenkins-bot: Update VE core submodule to master (121100d74) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336450 (https://phabricator.wikimedia.org/T156599) (owner: 10Jforrester) [19:18:58] (03CR) 10DLynch: "Looking at the postWithToken source, it looks like we also do a whole updating-the-userinfo thing, if the user has switched accounts in an" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:19:25] (03CR) 10Bartosz Dziewoński: [C: 032] "This is a nice refactoring anyway :D" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:22:02] (03CR) 10Catrope: "Yeah don't use mw.Api's edit token handling, it silently proceeds if the user's identity changed and James felt strongly that we should sh" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:22:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen: Page links are getting added as plain text in NWE when the editor is open for a long time(?) - https://phabricator.wikimedia.org/T156991#3006697 (10Jdforrester-WMF) 05Open>03Resolved a:03DLynch [19:25:13] (03CR) 10jenkins-bot: Update VE core submodule to master (121100d74) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336450 (https://phabricator.wikimedia.org/T156599) (owner: 10Jforrester) [19:28:12] (03CR) 10Bartosz Dziewoński: [C: 032] "As a side note, the API has an &assert=user parameter, and recently gained &assertuser= too – I thought these could let us simpl" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:30:01] The result of that spate of commenting "aha! we were right all along!" [19:31:44] Ah, right. [19:32:30] Now I think about it, I think (a) our code pre-dates mw.Api's retry code, and (b) our code post-thinks that terrible concept that was taken from the PHP layer and results in bad edits. [19:37:29] (03Merged) 10jenkins-bot: ArticleTarget: try to refresh editToken if getWikitextFragment fails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:39:23] 10VisualEditor, 10VisualEditor-CopyPaste, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): VisualEditor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3006732 (10Jdforrester-WMF) [19:39:36] 10VisualEditor, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Visual diffing: Implement a fallback for when tree diffing takes too long - https://phabricator.wikimedia.org/T156599#3006733 (10Jdforrester-WMF) [19:39:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Page links are getting added as plain text in NWE when the editor is open for a long time(?) - https://phabricator.wikimedia.org/T156991#3006734 (10Jdforrester-WMF) [19:43:57] (03CR) 10jenkins-bot: ArticleTarget: try to refresh editToken if getWikitextFragment fails [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336439 (https://phabricator.wikimedia.org/T156991) (owner: 10DLynch) [19:47:31] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Selecting text is glitchy - https://phabricator.wikimedia.org/T157291#3006770 (10Esanders) For selecting text as you scroll up, bisect blames https://gerrit.wikimedia.org/r/#/c/328395/ (cc @DLynch author, @matmarex reviewer) [19:47:53] 10VisualEditor: Selecting text is glitchy - https://phabricator.wikimedia.org/T157291#3006772 (10Esanders) [19:49:07] 10VisualEditor: Selecting text beyond the screen with mouse is glitchy - https://phabricator.wikimedia.org/T157291#3000946 (10Esanders) [19:49:19] Kemayo: https://phabricator.wikimedia.org/T157291 [19:49:42] (03PS4) 10Jforrester: Media upload: Get allowed file extensions and mime types from MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders) [19:49:48] (03CR) 10Jforrester: "PS4: Rebase." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders) [19:56:43] 10VisualEditor, 10WikiEditor, 10CodeEditor, 13Patch-For-Review: CodeEditor should fail if WikiEditor is not available - https://phabricator.wikimedia.org/T157195#3006798 (10Jdforrester-WMF) p:05Triage>03Normal a:03MarkAHershberger [19:59:04] (03CR) 10jerkins-bot: [V: 04-1] Media upload: Get allowed file extensions and mime types from MW core [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/245961 (owner: 10Esanders) [20:03:00] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor handles selecting/pasting newlines weirdly - https://phabricator.wikimedia.org/T157408#3004220 (10Jdforrester-WMF) 05Open>03stalled Is the software providing the Ctrl+Insert functionality the cause, perhaps? [20:06:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting lots of text into the new wikitext editor takes very long - https://phabricator.wikimedia.org/T157407#3004197 (10Jdforrester-WMF) On master, pasting that into NWE took a couple of seconds; special-pasting took about three seconds; and pasting... [20:07:03] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting lots of text into the new wikitext editor takes very long - https://phabricator.wikimedia.org/T157407#3006824 (10Jdforrester-WMF) p:05Triage>03Low [20:08:24] 10VisualEditor, 06Discovery, 10Graphs, 06Maps, 07Browser-Support-Apple-Safari: In Safari, VE crashes while trying to save a page after adding a Map/Graph - https://phabricator.wikimedia.org/T157389#3006829 (10Jdforrester-WMF) p:05Triage>03High [20:10:06] 10VisualEditor: Selecting text beyond the screen with mouse is glitchy - https://phabricator.wikimedia.org/T157291#3006835 (10Jdforrester-WMF) p:05Triage>03Normal [20:11:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Inconsistent availability of "Insert signature" between the visual editor and the 2017 source editor - https://phabricator.wikimedia.org/T157286#3006843 (10Jdforrester-WMF) p:05Triage>03Low Sounds like NWE's tool isn't respecting the `$wgExtraSig... [20:11:39] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Inconsistent availability of "Insert signature" between the visual editor and the 2017 source editor - https://phabricator.wikimedia.org/T157286#3006849 (10Jdforrester-WMF) (And yes, that namespace is not signed, so it shouldn't be available in either.) [20:13:33] (03PS1) 10Esanders: Define default HTML types for extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336464 (https://phabricator.wikimedia.org/T157389) [20:16:54] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links: Copying a piped link from VE to VE results in javascript:void(0) in wikitext - https://phabricator.wikimedia.org/T157205#3006870 (10Jdforrester-WMF) p:05Triage>03Unbreak! Interesting. In master, paste of the HTML into NWE works fi... [20:18:08] 10VisualEditor, 10VisualEditor-Tables: Provide a way to justify the contents of a table cell - https://phabricator.wikimedia.org/T103276#3006881 (10Jdforrester-WMF) [20:18:10] 10VisualEditor: Consider adding margin adjustment and text align features in tables. - https://phabricator.wikimedia.org/T157166#3006883 (10Jdforrester-WMF) [20:21:08] 10VisualEditor, 10VisualEditor-Initialisation: VE plugins from user scripts not always loaded - https://phabricator.wikimedia.org/T157113#2995975 (10Jdforrester-WMF) This might be related to {T154329} (browsers being aggressive in not executing code in background tabs)? [20:21:30] 10VisualEditor, 10VisualEditor-Initialisation: VE plugins from user scripts not always loaded - https://phabricator.wikimedia.org/T157113#3006899 (10Jdforrester-WMF) p:05Triage>03Low [20:22:18] (03PS1) 10Esanders: Move wikitext signature command to correct file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336467 (https://phabricator.wikimedia.org/T157286) [20:24:20] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Clicking "New section" does nothing while editing in New Wikitext Editor - https://phabricator.wikimedia.org/T153547#3006908 (10Jdforrester-WMF) 05Open>03Resolved p:05Triage>03Normal a:03Jdforrester-WMF This appears to be working now (but T... [20:24:35] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: The tab "New section" does not work with the New Wikitext Editor unless the editor is already active - https://phabricator.wikimedia.org/T157104#2995609 (10Jdforrester-WMF) p:05Triage>03High [20:25:19] 10VisualEditor, 10VisualEditor-MediaWiki-Media, 07Design: Give me an easy way to filter media/images for type, size, and the other cool things that CirrusSearch can do - https://phabricator.wikimedia.org/T157086#2995132 (10Jdforrester-WMF) p:05Triage>03Low [20:28:14] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3006947 (10Jdforrester-WMF) 05Open>03stalled I cannot replicate. When I click "edit source" in that context I get the editor loaded on the page with th... [20:29:25] 10VisualEditor, 10VisualEditor-MediaWiki: Clicking "save changes" in the diff screen saves your changes; some users expect it to do the same as the "back" button - https://phabricator.wikimedia.org/T156891#3006950 (10Jdforrester-WMF) [20:33:02] 10VisualEditor, 10VisualEditor-MediaWiki: Clicking "save changes" in the diff screen saves your changes; some users expect it to do the same as the "back" button - https://phabricator.wikimedia.org/T156891#3007046 (10Jdforrester-WMF) 05Open>03stalled So… this is behaving as designed. There was a request fo... [20:33:36] (03CR) 10Jforrester: [C: 032] Define default HTML types for extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336464 (https://phabricator.wikimedia.org/T157389) (owner: 10Esanders) [20:34:39] (03PS3) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335224 (https://phabricator.wikimedia.org/T153241) [20:35:11] (03PS1) 10Bartosz Dziewoński: Explain that Escape/Ctrl+Enter can be used to cancel/confirm a dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336470 [20:35:13] (03PS1) 10Bartosz Dziewoński: Move platform handling from CommandHelpDialog to CommandHelpRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336471 [20:35:15] (03PS4) 10Bartosz Dziewoński: ve.ui.MWSaveDialog: Show a hint to use Ctrl+Enter to submit when pressing Enter [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335224 (https://phabricator.wikimedia.org/T153241) [20:35:43] MatmaRex: Showy. :-) [20:35:50] :o [20:36:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#3007061 (10Raymond) I can reproduce today too. The header shows that the old revision is loaded, but at least the last section > 4 Vorschau > 4.1 Versi... [20:36:57] (03CR) 10Jforrester: [C: 032] Move wikitext signature command to correct file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336467 (https://phabricator.wikimedia.org/T157286) (owner: 10Esanders) [20:37:10] James_F: well, it seemed to make sense. although i started doing it this way because i thought we localise the shortcuts, like Ctrl->Strg for German. but we don't… shouldn't we be doing that? [20:38:10] (03CR) 10Bartosz Dziewoński: "Mostly I'm unsure about how clear to users it will be to "confirm" or "cancel" a dialog. We don't use this naming internally, so it could " [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336470 (owner: 10Bartosz Dziewoński) [20:38:10] MatmaRex: I asked this a few years ago and someone (can't remember who) from Language was adamant that Ctrl was expected. Maybe their views have changed? [20:38:20] (oh no, i forgot qqq…) [20:38:25] Ha. [20:38:27] (03CR) 10jerkins-bot: [V: 04-1] Explain that Escape/Ctrl+Enter can be used to cancel/confirm a dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336470 (owner: 10Bartosz Dziewoński) [20:38:43] James_F: i dunno, i don't speak german, but i've seen their keyboards and they had Strg on them. :) [20:38:50] Indeed. [20:39:12] (03CR) 10Bartosz Dziewoński: "Also, the new messages don't show up right for me in the help dialog in MW. Not sure if it's a local problem, or if they need to be listed" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336470 (owner: 10Bartosz Dziewoński) [20:39:31] (i'm away for a few minutes) [20:39:48] (03CR) 10jerkins-bot: [V: 04-1] Move platform handling from CommandHelpDialog to CommandHelpRegistry [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336471 (owner: 10Bartosz Dziewoński) [20:44:57] (03Merged) 10jenkins-bot: Define default HTML types for extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336464 (https://phabricator.wikimedia.org/T157389) (owner: 10Esanders) [20:47:58] (03Merged) 10jenkins-bot: Move wikitext signature command to correct file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336467 (https://phabricator.wikimedia.org/T157286) (owner: 10Esanders) [20:51:05] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor handles selecting/pasting newlines weirdly - https://phabricator.wikimedia.org/T157408#3007173 (10Tgr) Same behavior with ctrl-v (or right-click + "paste" or "paste as plain text"). I use standard settings as far as I am aware - (... [20:51:21] (03CR) 10jenkins-bot: Define default HTML types for extension nodes [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336464 (https://phabricator.wikimedia.org/T157389) (owner: 10Esanders) [20:57:57] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting lots of text into the new wikitext editor takes very long - https://phabricator.wikimedia.org/T157407#3007177 (10Tgr) Is there a test install where I can try master without having to set it up locally? If you ask... [20:58:07] (03CR) 10jenkins-bot: Move wikitext signature command to correct file [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336467 (https://phabricator.wikimedia.org/T157286) (owner: 10Esanders) [21:04:30] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting lots of text into the new wikitext editor takes very long - https://phabricator.wikimedia.org/T157407#3007187 (10Jdforrester-WMF) >>! In T157407#3007177, @Tgr wrote: > Is there a test install where I can try master... [21:06:22] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor displays some control characters (enter, tab) as icons, making text hard to read - https://phabricator.wikimedia.org/T157491#3007192 (10Tgr) [21:07:46] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Inconsistent availability of "Insert signature" between the visual editor and the 2017 source editor - https://phabricator.wikimedia.org/T157286#3007207 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [21:13:19] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting lots of text into the new wikitext editor takes very long - https://phabricator.wikimedia.org/T157407#3007256 (10Tgr) Ah, thanks. I thought VE is submodule'd and you meant its master. I get the same timing you des... [21:14:26] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Insertion of coded information/garbage? into the page after paste - https://phabricator.wikimedia.org/T156906#2989345 (10Esanders) We use h[hex] as the hashes for inline annotations (bold/italic..). Looks like it has the converted linear data array t... [21:17:00] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Templates: Inserting template makes 2x the same API parser calls - https://phabricator.wikimedia.org/T156698#2984030 (10Esanders) The first one is to determine if the template is going to be inline or block by looking at the generated HTML. W... [21:26:19] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor confused by select-all - https://phabricator.wikimedia.org/T157499#3007340 (10Tgr) [21:26:41] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: New wikitext editor displays some control characters (enter, tab) as icons, making text hard to read - https://phabricator.wikimedia.org/T157491#3007353 (10Tgr) [21:36:12] (03PS1) 10Esanders: Cache generated content request when inserting templates [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336494 (https://phabricator.wikimedia.org/T156698) [22:02:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/336523 (owner: 10L10n-bot) [22:18:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/336535 (owner: 10L10n-bot) [22:37:28] 10VisualEditor, 10OOjs-UI (OOjs-UI-0.19.0), 15User-Ryasmeen, 07Verified: [Regression pre-wmf.9] Various dialogs have horizontal scrolling - https://phabricator.wikimedia.org/T155711#3007589 (10Ryasmeen) [22:39:03] (03PS1) 10Tchanders: VisualDiff: Distinguish between annotation/character changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336547 (https://phabricator.wikimedia.org/T156189) [22:41:01] Hey guys, had a VE/parsoid dev question, didn't know if this was the right place. [22:42:57] 10VisualEditor, 10VisualEditor-LanguageTool, 07Verified, 05WMF-deploy-2017-02-07_(1.29.0-wmf.11): [Regression] Language inspector is too small, has scroll bars - https://phabricator.wikimedia.org/T156735#3007603 (10Ryasmeen) [22:54:03] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10MediaWiki-General-or-Unknown: " Prompt me when entering a blank edit summary" claims that there's no edit summary - https://phabricator.wikimedia.org/T157509#3007638 (10Whatamidoing-WMF) [23:01:49] (03PS2) 10Tchanders: VisualDiff: Distinguish between annotation/character changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336547 (https://phabricator.wikimedia.org/T156189) [23:07:05] (03CR) 10jerkins-bot: [V: 04-1] VisualDiff: Distinguish between annotation/character changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336547 (https://phabricator.wikimedia.org/T156189) (owner: 10Tchanders) [23:18:25] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, and 2 others: When pasting text, don't translate multiple normal spaces into multiple non-breaking spaces - https://phabricator.wikimedia.org/T156498#3007689 (10Ryasmeen)