[00:00:20] (03CR) 10jerkins-bot: [V: 04-1] Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [00:01:03] (03CR) 10Jforrester: Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [00:01:11] (03CR) 10Jforrester: [C: 032] "…" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [00:02:29] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Plain text paste into new wikitext editor adds newline markers wrongly - https://phabricator.wikimedia.org/T157491#3027801 (10Tanveer07) [00:05:24] (03CR) 10jerkins-bot: [V: 04-1] Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [00:17:59] (03CR) 10Jforrester: "How did the tests pass before and fail now?" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [00:29:51] 10VisualEditor: OOjs UI v0.19.2 let lib/ve tests fail - https://phabricator.wikimedia.org/T158141#3027969 (10Volker_E) [00:29:57] 10VisualEditor: OOjs UI v0.19.2 let lib/ve tests fail - https://phabricator.wikimedia.org/T158141#3027981 (10Volker_E) p:05Triage>03High [01:46:14] (03CR) 10Jforrester: [C: 031] "Oh, right. :-)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [02:15:31] 10VisualEditor, 10VisualEditor-ContentEditable, 07Verified, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Selecting text beyond the screen with mouse is glitchy - https://phabricator.wikimedia.org/T157291#3028236 (10Ryasmeen) [08:24:24] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: NWE: Copying tab/newline characters using mouse only (on unixoid systems) doesn't work as expected - https://phabricator.wikimedia.org/T157956#3028493 (10Schnark) Using this way to copy just normal text works as expected.... [09:05:09] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: "Add section" does not work - https://phabricator.wikimedia.org/T158164#3028574 (10Raymond) [09:31:47] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: "Add section" does not work - https://phabricator.wikimedia.org/T158164#3028599 (10Schnark) [09:31:51] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen, and 2 others: [regression] The tab "New section" does not work with the New Wikitext Editor unless the editor is already active - https://phabricator.wikimedia.org/T157104#3028602 (10Schnark) [09:44:42] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Editing an old revision loads the current revision - https://phabricator.wikimedia.org/T156998#2992374 (10Schnark) Using the above links, I get a revision that is neither the requested nor the current revision: The first headline in the content shown... [09:56:16] 10VisualEditor: Improve preformated text format for multi-lines usage - https://phabricator.wikimedia.org/T157538#3028650 (10Pyro853) Hi, In use case 1, this is not the ticket you mention. Here, I suggest to remove the need to use the Shift key to add new lines in preformated text. This is not intiutive, nor eas... [10:21:11] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Page_Forms, 07Epic: Provide an integration of VisualEditor for SemanticForms - https://phabricator.wikimedia.org/T131686#3028733 (10Pyro853) I created a little extension for this use case, available here : https://github.com/Wikifab/mediawiki... [10:48:46] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#3028764 (10dialmove) Another use case to consider for you designers of this "feature", which just ha... [10:58:17] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Documentation: Update documentation for VE gadgets to include information about NWE - https://phabricator.wikimedia.org/T150081#3028788 (10Schnark) Uh, I more or less forgot about this. I'd be really happy if someone could just have a look at htt... [11:03:23] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting formatted code at the end of a paragraph breaks cursor positioning - https://phabricator.wikimedia.org/T158170#3028789 (10dialmove) [11:04:27] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting formatted code at the end of a paragraph breaks cursor positioning - https://phabricator.wikimedia.org/T158170#3028807 (10dialmove) [13:50:28] (03PS1) 10WMDE-Fisch: Replace deprecated suppress warning methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337843 [15:11:07] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor does not handle wikitext that adds ResourceLoader modules correctly - https://phabricator.wikimedia.org/T156414#3029478 (10Anomie) [15:35:21] (03CR) 10Jforrester: [C: 032] Replace deprecated suppress warning methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337843 (owner: 10WMDE-Fisch) [16:39:07] (03Merged) 10jenkins-bot: Replace deprecated suppress warning methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337843 (owner: 10WMDE-Fisch) [16:44:57] (03CR) 10jenkins-bot: Replace deprecated suppress warning methods [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337843 (owner: 10WMDE-Fisch) [17:02:37] (03CR) 10Esanders: [C: 032] VisualDiff: Distinguish between annotation/character changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336547 (https://phabricator.wikimedia.org/T156189) (owner: 10Tchanders) [17:07:14] (03Merged) 10jenkins-bot: VisualDiff: Distinguish between annotation/character changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336547 (https://phabricator.wikimedia.org/T156189) (owner: 10Tchanders) [17:10:27] (03CR) 10jenkins-bot: VisualDiff: Distinguish between annotation/character changes [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/336547 (https://phabricator.wikimedia.org/T156189) (owner: 10Tchanders) [17:34:26] 10VisualEditor, 10VisualEditor-MediaWiki, 10MediaWiki-extensions-Page_Forms, 07Epic: Provide an integration of VisualEditor for SemanticForms - https://phabricator.wikimedia.org/T131686#2174885 (10Yaron_Koren) @Pyro853 - Wow, that's amazing! I didn't think that this was possible at all, let alone with just... [18:11:28] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Per my previous comment." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335888 (owner: 10Esanders) [18:13:48] (03CR) 10Bartosz Dziewoński: "Is this supposed to work for tables without captions? (It doesn't.)" (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [18:57:59] (03CR) 10Bartosz Dziewoński: [C: 04-1] Preview collapsible handles in tables (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [19:05:37] 10TemplateData, 10VisualEditor: TemplateData's suggested parameters to add doesn't know that `{{{!}}` isn't a parameter but a special thing for MediaWiki - https://phabricator.wikimedia.org/T157029#3030399 (10JAnD) [19:06:52] 10VisualEditor, 07Design: Have the visual diff system display content attribute changes - https://phabricator.wikimedia.org/T156189#3030404 (10Jdforrester-WMF) Hard bit done, now it 'just' needs to be turned into UI. [19:36:58] 10VisualEditor, 10VisualEditor-EditingTools: Problems with scrolling in the "Options" dialog make some tooltips drop of the displayed dialog - https://phabricator.wikimedia.org/T100571#3030572 (10matmarex) [19:46:23] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: "Add section" does not work - https://phabricator.wikimedia.org/T158164#3028574 (10Jdforrester-WMF) Sorry about this; fix is rolling out to dewiki tomorrow. [19:55:53] cscott: Can I borrow your brain for a minute or two? On https://gerrit.wikimedia.org/r/#/c/333963/ we're making how transfer handlers work consistent by changing the UrlStringTH take the text too. You wrote the unit test that had to get changed and neither Ed nor I are sure we're right to have so changed it… [20:02:18] i'll take a look & try to page that stuff in, hang on. [20:10:09] cscott: You're awesome, thanks. [20:11:37] (03CR) 10C. Scott Ananian: Pass text & html data to all DTH handlers (031 comment) [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/333963 (owner: 10Esanders) [20:12:29] hopefully my comment is clear? [20:14:22] 10VisualEditor, 10Math, 15User-Ryasmeen, 07Verified, and 2 others: [Regression pre-wmf.12] VE crashes while trying to open Math inspector, getting error "TypeError: Cannot read property 'replace' of undefined" - https://phabricator.wikimedia.org/T157751#3030757 (10Ryasmeen) [20:15:46] 10VisualEditor, 06Discovery, 10Graphs, 06Maps, and 5 others: In Safari, VE crashes while trying to save a page after adding a Map/Graph - https://phabricator.wikimedia.org/T157389#3030760 (10Ryasmeen) [20:16:30] cscott: Thanks! [20:18:28] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen, and 3 others: [regression] The tab "New section" does not work with the New Wikitext Editor unless the editor is already active - https://phabricator.wikimedia.org/T157104#3030765 (10Ryasmeen) [20:21:20] 10VisualEditor, 10VisualEditor-Tables, 07Design, 15User-Ryasmeen, and 3 others: There should be a visual indication that setting a table's properties to 'sortable' worked - https://phabricator.wikimedia.org/T139072#3030766 (10Ryasmeen) [20:23:52] (03PS2) 10Jforrester: Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [20:24:02] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [20:26:48] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in ve.ce.Surface.test: special key down: linear arrow keys with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3030769 (10Jdforrester-WMF) p:05High>03Unbreak! a:03Esanders [20:27:02] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in ve.ce.Surface.test: special key down: linear arrow keys with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3030775 (10Jdforrester-WMF) :-( [20:27:46] (03CR) 10Jforrester: [C: 04-1] "Per cscott." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/333963 (owner: 10Esanders) [20:34:04] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 06Reading-Web-Backlog, and 4 others: MobileFrontend's wikitext editor fails to refresh the page after editing a section and saving - https://phabricator.wikimedia.org/T127496#3030785 (10Ryasmeen) [20:35:22] (03CR) 10jerkins-bot: [V: 04-1] Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [20:37:04] 10VisualEditor, 10VisualEditor-CopyPaste, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): VisualEditor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3030800 (10Ryasmeen) [20:40:58] 10VisualEditor, 10VisualEditor-ContentEditable, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Selecting text beyond the screen with mouse is glitchy - https://phabricator.wikimedia.org/T157291#3030804 (10Ryasmeen) [20:44:05] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, and 2 others: Plain text paste into new wikitext editor adds newline markers wrongly - https://phabricator.wikimedia.org/T157491#3030822 (10Ryasmeen) [20:48:42] 10TemplateData, 10VisualEditor, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 3 others: Content jumps after JavaScript is loaded on slow connections - https://phabricator.wikimedia.org/T138177#3030841 (10Dvorapa) [21:46:47] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in ve.ce.Surface.test: special key down: linear arrow keys with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3031000 (10matmarex) This is very much a bug in VE's test code. It's... [21:51:36] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3031046 (10matmarex) [21:56:22] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3031061 (10matmarex) So actually, `v... [21:58:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337998 (owner: 10L10n-bot) [22:10:58] MatmaRex: Fun. :-( [22:14:04] (03PS1) 10Bartosz Dziewoński: ve.ce.Surface.test: Gross workaround for failing tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338011 (https://phabricator.wikimedia.org/T158141) [22:14:32] James_F: ^ that works for me. i'll let edsanders think about a real fix. [22:14:50] * James_F will look after the MCR IRC meeting. [22:21:41] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI, 13Patch-For-Review: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3031209 (10matm... [22:23:47] MatmaRex: Won't we need to rebase them the other way up? [22:24:33] (03CR) 10Esanders: [C: 032] ve.ce.Surface.test: Gross workaround for failing tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338011 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [22:24:35] James_F: yes. i wanted to see that it passes on jenkins first [22:24:46] before amending other changesets [22:24:57] Sure. [22:25:17] Ed's OK with it, apparently. :-) [22:26:34] (03CR) 10Esanders: Preview collapsible handles in tables (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [22:27:29] 10VisualEditor, 10Wikimedia-Site-requests, 07Spanish-Sites: Enable VisualEditor for some user groups at the Spanish Wikipedia - https://phabricator.wikimedia.org/T117410#3031273 (10MarcoAurelio) [22:27:42] Will rebase and need to rotate it. [22:27:42] 10VisualEditor, 07Browser-Support-Internet-Explorer, 07Spanish-Sites: VisualEditor hangs on Spanish Wikipedia in IE11 - https://phabricator.wikimedia.org/T97788#3031282 (10MarcoAurelio) [22:28:26] (03PS2) 10Jforrester: ve.ce.Surface.test: Gross workaround for failing tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338011 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [22:28:29] And we'll need to pull through. [22:28:30] (03PS3) 10Jforrester: Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [22:28:46] (03CR) 10Jforrester: [C: 032] "Per Ed." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338011 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [22:28:58] (03CR) 10Jforrester: [C: 032] Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [22:29:18] i like the double meaning of pull through, James_F. [22:29:30] MatmaRex: ;-) [22:32:46] (03Merged) 10jenkins-bot: ve.ce.Surface.test: Gross workaround for failing tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338011 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [22:36:02] (03Merged) 10jenkins-bot: Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [22:39:16] (03PS1) 10Jforrester: Update VE core submodule to master (ac6db50ca) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338017 [22:40:07] MatmaRex: If you +2 ^^^ then theoretically we can merge MW/vendor and MW/core patches for the OOUI release. [22:40:43] yeah, let's [22:40:46] (03CR) 10Bartosz Dziewoński: [C: 032] Update VE core submodule to master (ac6db50ca) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338017 (owner: 10Jforrester) [22:41:04] Thank you. [22:53:41] (03PS1) 10VolkerE: Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 [22:56:39] (03Merged) 10jenkins-bot: Update VE core submodule to master (ac6db50ca) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338017 (owner: 10Jforrester) [22:59:52] (03CR) 10jenkins-bot: ve.ce.Surface.test: Gross workaround for failing tests [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338011 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [23:02:08] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#3031416 (10Whatamidoing-WMF) >>! In T153315#3028764, @dialmove wrote: > Please don't let your answer... [23:03:15] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3031417 (10Jdforrester-WMF) p:05Unb... [23:03:29] (03CR) 10jenkins-bot: Update OOjs UI to v0.19.2 [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/337760 (owner: 10VolkerE) [23:08:36] (03CR) 10VolkerE: "Copying my comment from I1789fe9e5e80" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [23:09:50] (03CR) 10Jforrester: "It's not just "empty", it's "empty and will get automatically trimmed when you press apply", which is a lot closer to disabled than it sou" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [23:10:09] (03CR) 10jenkins-bot: Update VE core submodule to master (ac6db50ca) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338017 (owner: 10Jforrester) [23:10:50] MatmaRex: Eurgh. https://gerrit.wikimedia.org/r/#/c/337762/ (OOUI in MW/core) didn't merge. [23:11:19] * James_F puts his head in his hands. [23:11:42] (03CR) 10jerkins-bot: [V: 04-1] Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [23:11:45] James_F: well, that totally looks like the failure that we just fixed. maybe it just needs a poke> [23:11:46] ? [23:12:46] MatmaRex: It does, but async… it ran on top of the new version of MW-VE. [23:12:54] * James_F re-slaps it just in acse. [23:13:01] Ah, you did. [23:13:12] * James_F crosses his fingers. [23:13:32] i think i grepped for other usages of that function when trying to debug the problem, and that was the only one [23:13:41] * James_F nods. [23:13:49] (and also something with FindAndReplaceDialog that used a different pattern that should not be problematic) [23:21:18] MatmaRex: Nope. :-( [23:24:09] James_F: eh [23:24:44] James_F: can you reproduce the failure locally with ve-mw? [23:25:04] MatmaRex: Nope. But I couldn't with VE core either. [23:26:32] (i'm trying to make the tests run) [23:26:34] MatmaRex: (Move to -dev given the wider interest.) [23:26:35] * James_F nods. [23:52:27] 10VisualEditor: [Regression] Cursor does not go to the next on pressing Return after a section heading - https://phabricator.wikimedia.org/T158259#3031582 (10Ryasmeen) [23:57:04] 10VisualEditor: Cannot add a new section, getting error "Please enter a comment below" while trying to save the page - https://phabricator.wikimedia.org/T158262#3031652 (10Ryasmeen) [23:58:36] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3027969 (10Jdforrester-WMF)