[00:02:35] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3031680 (10Jdforrester-WMF) OK, MW/c... [00:10:38] 10VisualEditor: [Regression] Cursor does not go to the next line on pressing Return after adding a section heading - https://phabricator.wikimedia.org/T158259#3031694 (10Ryasmeen) [00:17:35] (03PS1) 10Bartosz Dziewoński: ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338028 (https://phabricator.wikimedia.org/T158141) [00:22:06] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI, 13Patch-For-Review: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3031730 (10matm... [00:27:23] (03CR) 10Jforrester: [C: 04-1] "Other than the OOUI fun, the npm test failure (descending specificity) is real." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [00:34:01] Did a new OOUI push break CI? https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm/37392/console [00:34:10] oojs/oojs-ui: 0.19.2 installed, 0.19.1 required. [00:34:25] Not sure what's going on [00:34:41] that extension doesnt even use OOUI [00:36:29] (03CR) 10Krinkle: [C: 032] ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338028 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [00:47:21] (03Merged) 10jenkins-bot: ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338028 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [00:58:57] (03CR) 10jenkins-bot: ve.test.utils.createSurfaceFromDocument: Actually attach surface to DOM [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338028 (https://phabricator.wikimedia.org/T158141) (owner: 10Bartosz Dziewoński) [01:03:54] ^ James_F ? [01:04:06] or edsanders if you are still around :) [01:04:30] jdlrobson: hi. yes [01:04:33] (03PS2) 10VolkerE: Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 [01:04:36] jdlrobson: See T158141 and discussion in -dev. Should be fixed now. [01:04:36] T158141: Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141 [01:04:41] (03CR) 10jerkins-bot: [V: 04-1] Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [01:04:42] awesome. let me try rechecking it [01:04:43] Thank you, stashbot. [01:04:51] jdlrobson: Sorry for the disruption. :-( [01:19:33] (03PS1) 10Bartosz Dziewoński: ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language variants [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338039 [01:21:00] James_F: ^ someone should be testing VE in Serbian or Chinese more often. ;) [01:21:03] (03PS3) 10VolkerE: Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 [01:21:26] MatmaRex: We don't support variants in the content block yet, so… [01:21:51] (03CR) 10Jforrester: [C: 032] "Whoops." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338039 (owner: 10Bartosz Dziewoński) [01:22:01] Only 2 years and 5 months late. :-) [01:38:41] (03Merged) 10jenkins-bot: ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language variants [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338039 (owner: 10Bartosz Dziewoński) [01:40:35] 10VisualEditor, 10VisualEditor-ContentEditable, 07Verified, 07Verified-in-Phase0, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Unicorn does not get destroyed when arrowing out of a paragraph, causes weird arrow key behavior - https://phabricator.wikimedia.org/T157019#3031936 (10Tanveer07) [01:43:28] (03CR) 10jerkins-bot: [V: 04-1] Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [01:46:27] (03CR) 10jenkins-bot: ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language variants [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338039 (owner: 10Bartosz Dziewoński) [01:48:25] (03PS4) 10Jforrester: Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [01:48:36] (03CR) 10Jforrester: "CI flakiness, oh joy." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [01:51:19] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is... - https://phabricator.wikimedia.org/T158141#3031980 [02:06:52] 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: Hover effect inconsistent for Help icon - https://phabricator.wikimedia.org/T58617#644569 (10matmarex) This doesn't appear to be a problem anymore (not even on MonoBook, which still uses the original toolbar design), or I'm misunderstanding your descripti... [02:07:53] 10VisualEditor, 10VisualEditor-EditingTools: Problems with scrolling in the "Options" dialog make some tooltips drop of the displayed dialog - https://phabricator.wikimedia.org/T100571#3032015 (10matmarex) [02:08:00] 10VisualEditor: Scrolling does not work for last hint in the window - https://phabricator.wikimedia.org/T96281#3032017 (10matmarex) [02:08:02] (03PS1) 10Bartosz Dziewoński: Pass $overlay to FieldsetLayout and FieldLayout in various places [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338041 (https://phabricator.wikimedia.org/T100571) [02:09:15] 10VisualEditor, 10VisualEditor-EditingTools, 13Patch-For-Review: Problems with scrolling in the "Options" dialog make some tooltips drop of the displayed dialog - https://phabricator.wikimedia.org/T100571#3032021 (10matmarex) a:03matmarex | Before | {F5649076} | | After | {F5649079} | [02:10:03] (03CR) 10Bartosz Dziewoński: "(Depends on https://gerrit.wikimedia.org/r/337896 in OOjs UI)" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338041 (https://phabricator.wikimedia.org/T100571) (owner: 10Bartosz Dziewoński) [08:34:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338075 (owner: 10L10n-bot) [08:43:11] 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting formatted code at the end of a paragraph breaks cursor positioning - https://phabricator.wikimedia.org/T158170#3028789 (10Schnark) The console shows: TypeError: annotation is undefined * openAnnotation() * ve.dm.Converter.static.openAndClose... [09:55:54] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#3032510 (10dialmove) >>! In T153315#3031416, @Whatamidoing-WMF wrote: > Your browser will let you pa... [10:06:02] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting annotated wikitext results in double encoding and therefore s - https://phabricator.wikimedia.org/T153315#3032523 (10dialmove) P.S. I'm not the only one who prefers plain text as the default for copy/paste... [10:39:19] (03PS1) 10Esanders: Increase margin on DiffElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338093 [10:52:23] 10VisualEditor: Cell change missing in table diff - https://phabricator.wikimedia.org/T158294#3032599 (10Esanders) [10:57:26] 10VisualEditor, 07Browser-Support-Google-Chrome: VE sometimes inserts paragraph in wrong place - https://phabricator.wikimedia.org/T158295#3032620 (10Lokal_Profil) [11:20:18] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor: Pasting formatted code at the end of a paragraph breaks cursor positioning - https://phabricator.wikimedia.org/T158170#3032662 (10Dvorapa) [12:01:32] 10VisualEditor, 07Browser-Support-Google-Chrome: VE sometimes inserts paragraph in wrong place - https://phabricator.wikimedia.org/T158295#3032620 (10Samtar) @Lokal_Profil Hej! Could you just confirm which version of Google Chrome you're running? - To find the version please click this icon ≡ in the upper... [12:20:53] 10VisualEditor, 07Browser-Support-Google-Chrome: VE sometimes inserts paragraph in wrong place - https://phabricator.wikimedia.org/T158295#3032793 (10Lokal_Profil) >>! In T158295#3032709, @Samtar wrote: > @Lokal_Profil Hej! Could you just confirm which version of Google Chrome you're running? > > > The vers... [13:16:43] (03PS3) 10Esanders: Preview collapsible handles in tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 [13:52:55] (03PS1) 10Esanders: Use windowAction to open diff dialog in demo [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338099 [13:52:57] (03PS1) 10Esanders: Move standalone diff dialog into separate module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338100 [13:53:22] (03PS1) 10Esanders: Introduce visual differ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 [13:54:47] (03PS1) 10Esanders: DiffElement: Use important background colours to force override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338103 [14:05:28] (03CR) 10jerkins-bot: [V: 04-1] Introduce visual differ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (owner: 10Esanders) [14:52:52] 10VisualEditor: VisualEditor doesn't include closing parenthesis while pasting a URI - https://phabricator.wikimedia.org/T156878#3033108 (10MarkAHershberger) 05stalled>03Invalid I agree, I cannot reproduce it. I've asked the user for more information, but until (if) we get it, I'm closing this. I should hav... [16:15:15] 10VisualEditor: VisualEditor Cite dialog, when Ctrl+Enter is pressed, inserts a newline before closing the dialog - https://phabricator.wikimedia.org/T158321#3033363 (10maiden_taiwan) [16:23:20] (03PS5) 10Bartosz Dziewoński: Tables: Add support for editing mw-collapsible/mw-collapsed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335888 (https://phabricator.wikimedia.org/T157989) (owner: 10Esanders) [16:24:04] (03CR) 10Bartosz Dziewoński: [C: 032] "PS5 restores James's commit message and fixes the issue I pointed out." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335888 (https://phabricator.wikimedia.org/T157989) (owner: 10Esanders) [16:24:27] (03PS4) 10Bartosz Dziewoński: Preview collapsible handles in tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [16:25:27] (03PS5) 10Bartosz Dziewoński: Preview collapsible handles in tables [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [16:27:22] (03CR) 10Bartosz Dziewoński: "PS5 has several small fixes:" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [16:31:46] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This is still a bit buggy – I'm not sure if these are blockers – James?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [16:34:19] (03PS1) 10DLynch: MWSaveDialog: Switch to save panel when showing message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338134 (https://phabricator.wikimedia.org/T156891) [16:35:54] 10VisualEditor, 10VisualEditor-MediaWiki, 13Patch-For-Review: Clicking "save changes" in the diff screen saves your changes; some users expect it to do the same as the "back" button - https://phabricator.wikimedia.org/T156891#3033478 (10DLynch) That patch stops the flicker, which I think will help avoid conf... [16:39:37] (03Merged) 10jenkins-bot: Tables: Add support for editing mw-collapsible/mw-collapsed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335888 (https://phabricator.wikimedia.org/T157989) (owner: 10Esanders) [16:45:58] (03CR) 10jenkins-bot: Tables: Add support for editing mw-collapsible/mw-collapsed [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/335888 (https://phabricator.wikimedia.org/T157989) (owner: 10Esanders) [16:58:37] (03CR) 10Bartosz Dziewoński: [C: 032] MWSaveDialog: Switch to save panel when showing message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338134 (https://phabricator.wikimedia.org/T156891) (owner: 10DLynch) [17:14:13] (03Merged) 10jenkins-bot: MWSaveDialog: Switch to save panel when showing message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338134 (https://phabricator.wikimedia.org/T156891) (owner: 10DLynch) [17:14:37] (03CR) 10Jforrester: "> When the cell with the collapsible handle is changed from header to content (or the other way), the handle disappears. I'm guessing the " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337561 (owner: 10Esanders) [17:24:49] (03CR) 10jenkins-bot: MWSaveDialog: Switch to save panel when showing message [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338134 (https://phabricator.wikimedia.org/T156891) (owner: 10DLynch) [17:28:12] (03CR) 10Jforrester: "Is mw.msg definitely available at this point?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337610 (https://phabricator.wikimedia.org/T156141) (owner: 10DLynch) [17:31:58] 10VisualEditor, 10VisualEditor-MediaWiki: Clicking "save changes" in the diff screen saves your changes; some users expect it to do the same as the "back" button - https://phabricator.wikimedia.org/T156891#3033694 (10Jdforrester-WMF) 05stalled>03declined Yeah, that should help a bit. Our design policy mean... [17:32:07] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3033700 (10Jonesey95) It doesn't make sense to change any templates until the root cause of this problem is identified. What has changed recently to cause this probl... [17:34:16] (03CR) 10DLynch: "> Is mw.msg definitely available at this point?" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337610 (https://phabricator.wikimedia.org/T156141) (owner: 10DLynch) [17:34:24] 10VisualEditor, 10VisualEditor-MediaWiki: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#3033731 (10Jdforrester-WMF) This will be solved by {T104479}. [17:39:39] (03CR) 10Bartosz Dziewoński: "mw.msg is always available." [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337610 (https://phabricator.wikimedia.org/T156141) (owner: 10DLynch) [17:45:17] (03CR) 10Bartosz Dziewoński: [C: 032] DesktopArticleTarget.init: Don't hardcode single-tab accesskey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337610 (https://phabricator.wikimedia.org/T156141) (owner: 10DLynch) [17:55:29] (03CR) 10Jforrester: [C: 032] Increase margin on DiffElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338093 (owner: 10Esanders) [17:57:08] (03CR) 10Jforrester: "Won't this make it harder for downstream to override the colours (in MW they're currently a3d3ff and ffe49c)." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338103 (owner: 10Esanders) [17:57:45] (03PS2) 10Jforrester: demo: Use windowAction to open diff dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338099 (owner: 10Esanders) [17:57:49] (03CR) 10Jforrester: [C: 032] demo: Use windowAction to open diff dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338099 (owner: 10Esanders) [17:58:08] (03CR) 10Jforrester: [C: 032] Move standalone diff dialog into separate module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338100 (owner: 10Esanders) [18:36:56] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-Tables, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): Let me set/unset tables as collapsible and collapsed - https://phabricator.wikimedia.org/T157989#3034015 (10Jdforrester-WMF) 05Open>03Resolved [18:45:34] 10VisualEditor, 10VisualEditor-MediaWiki: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#3034045 (10Nemo_bis) >>! In T90864#3033731, @Jdforrester-WMF wrote: > This will be solved by {T104479}. The solution feels rather overkill for the issue reported here, b... [18:49:49] 10VisualEditor, 10VisualEditor-MediaWiki: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#3034069 (10Jdforrester-WMF) [18:50:01] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Design, 07Epic: Provide a modern wikitext editor - https://phabricator.wikimedia.org/T104479#3034070 (10Jdforrester-WMF) [18:50:06] 10VisualEditor, 10VisualEditor-MediaWiki: Help VisualEditor users find the wikitext "Save" button - https://phabricator.wikimedia.org/T90864#1069602 (10Jdforrester-WMF) Sorry for the gnostic comment; meant to add as a sub-task too. :-) [19:18:00] (03Merged) 10jenkins-bot: Increase margin on DiffElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338093 (owner: 10Esanders) [19:18:02] (03Merged) 10jenkins-bot: demo: Use windowAction to open diff dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338099 (owner: 10Esanders) [19:19:43] (03Merged) 10jenkins-bot: DesktopArticleTarget.init: Don't hardcode single-tab accesskey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337610 (https://phabricator.wikimedia.org/T156141) (owner: 10DLynch) [19:28:49] (03PS2) 10Jforrester: Move standalone diff dialog into separate module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338100 (owner: 10Esanders) [19:28:56] (03CR) 10Jforrester: [C: 032] Move standalone diff dialog into separate module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338100 (owner: 10Esanders) [19:30:57] (03CR) 10Jforrester: [C: 031] Transclusion dialog: Add VE specific rules from OOjs UI [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [19:34:29] (03Merged) 10jenkins-bot: Move standalone diff dialog into separate module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338100 (owner: 10Esanders) [19:57:44] (03CR) 10Esanders: "Downstream can just use important again." [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338103 (owner: 10Esanders) [19:57:54] (03CR) 10Esanders: "(which they'd need to do anyway)" [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338103 (owner: 10Esanders) [19:58:28] (03CR) 10Jforrester: [C: 032] DiffElement: Use important background colours to force override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338103 (owner: 10Esanders) [20:02:02] (03CR) 10jenkins-bot: DesktopArticleTarget.init: Don't hardcode single-tab accesskey [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/337610 (https://phabricator.wikimedia.org/T156141) (owner: 10DLynch) [20:02:29] (03CR) 10jenkins-bot: Increase margin on DiffElement [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338093 (owner: 10Esanders) [20:05:34] (03Merged) 10jenkins-bot: DiffElement: Use important background colours to force override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338103 (owner: 10Esanders) [20:08:29] (03CR) 10jenkins-bot: demo: Use windowAction to open diff dialog [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338099 (owner: 10Esanders) [20:13:12] (03PS2) 10Esanders: Introduce visual differ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 [20:14:06] (03CR) 10jenkins-bot: Move standalone diff dialog into separate module [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338100 (owner: 10Esanders) [20:15:12] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3034437 (10JJMC89) Report by @Bluerasberry [[https://en.wikipedia.org/w/index.php?oldid=765826310#Problem_with_citation_generation|w:en:VPT#Problem with citation gen... [20:22:35] (03CR) 10jenkins-bot: DiffElement: Use important background colours to force override [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338103 (owner: 10Esanders) [20:28:19] (03PS3) 10Esanders: Introduce visual differ [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 [20:32:55] (03CR) 10Jforrester: "Also need to change the colours." (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (owner: 10Esanders) [20:32:57] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3034458 (10Bluerasberry) Thanks for pointing me here @JJMC89 Note that this happens in Visual editor but not in source editor because the source editor makes no att... [20:52:55] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This does not actually work. MWTransclusion dialog does not actually add the '.ve-ui-mwTransclusionDialog' CSS class. All of the other pre" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [20:55:49] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think it's been broken since 926700fbca6b34ec1292139952669ad2688a0be5 (April 2014). We can probably safely remove all the dead code, no " [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [20:58:14] (03PS1) 10Jforrester: Update VE core submodule to master (979e9fe0e) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338167 [21:02:12] 10VisualEditor, 07Browser-Support-Google-Chrome: VE sometimes inserts paragraph in wrong place - https://phabricator.wikimedia.org/T158295#3032620 (10Esanders) This is a regression. Bisect blames OOjs UI 0.18.0. [21:03:42] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Google-Chrome: {Regression] Paragraph-insert slug in a block context in a table cell instead inserted at start of document in Chrome - https://phabricator.wikimedia.org/T158295#3034545 (10Jdforrester-WMF) p:05Triage>03High [21:05:43] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Google-Chrome: {Regression] Paragraph-insert slug in a block context in a table cell instead inserted at start of document in Chrome - https://phabricator.wikimedia.org/T158295#3032620 (10matmarex) Probably caused by the ButtonWidget focus cha... [21:16:01] 10VisualEditor, 10VisualEditor-ContentEditable, 07Browser-Support-Google-Chrome: {Regression] Paragraph-insert slug in a block context in a table cell instead inserted at start of document in Chrome - https://phabricator.wikimedia.org/T158295#3034580 (10Esanders) Most likely https://gerrit.wikimedia.org/r/#/... [21:21:12] (03CR) 10Jforrester: [C: 04-1] Introduce visual differ (031 comment) [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338101 (owner: 10Esanders) [21:30:01] 10Citoid, 10VisualEditor: Visual Editor adds erroneous text "PMC" to citation template pmc= parameter - https://phabricator.wikimedia.org/T157152#3034589 (10Whatamidoing-WMF) News: The problem is in citoid, and it's on the list for the devs to fix. On @Bluerasberry's point, I assume that he's talking about [... [21:32:35] 10VisualEditor, 10VisualEditor-ContentEditable, 10OOjs-UI, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is... - https://phabricator.wikimedia.org/T158141#3034596 [21:35:30] 10VisualEditor, 10VisualEditor-ContentEditable, 05WMF-deploy-2017-02-21_(1.29.0-wmf.13): Test failure in "ve.ce.Surface.test: special key down: table cells: Tab at end of table inserts new row" with OOjs UI v0.19.2 (clipping a PopupWidget that is unattached) - https://phabricator.wikimedia.org/T158141#3034620... [21:48:02] 10VisualEditor, 10Math, 15User-Ryasmeen, 07Verified, and 3 others: [Regression pre-wmf.12] VE crashes while trying to open Math inspector, getting error "TypeError: Cannot read property 'replace' of undefined" - https://phabricator.wikimedia.org/T157751#3034647 (10Ryasmeen) [21:52:32] 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor, 15User-Ryasmeen, and 4 others: [regression] The tab "New section" does not work with the New Wikitext Editor unless the editor is already active - https://phabricator.wikimedia.org/T157104#3034654 (10Ryasmeen) [21:53:45] 10VisualEditor, 10VisualEditor-Tables, 07Design, 15User-Ryasmeen, and 4 others: There should be a visual indication that setting a table's properties to 'sortable' worked - https://phabricator.wikimedia.org/T139072#3034656 (10Ryasmeen) [21:55:26] 10VisualEditor, 06Editing-Department, 10MobileFrontend, 06Reading-Web-Backlog, and 5 others: MobileFrontend's wikitext editor fails to refresh the page after editing a section and saving - https://phabricator.wikimedia.org/T127496#3034660 (10Ryasmeen) [21:58:25] 10VisualEditor, 06Discovery, 10Graphs, 06Maps, and 6 others: In Safari, VE crashes while trying to save a page after adding a Map/Graph - https://phabricator.wikimedia.org/T157389#3034664 (10Ryasmeen) [22:05:20] 10VisualEditor, 10VisualEditor-CopyPaste, 07Verified, 07Verified-in-Phase0, and 2 others: VisualEditor eats leading spaces on paste - https://phabricator.wikimedia.org/T157406#3034691 (10Ryasmeen) [22:05:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateData] - 10https://gerrit.wikimedia.org/r/338252 (owner: 10L10n-bot) [22:06:54] 10VisualEditor, 10VisualEditor-ContentEditable, 07Verified, 07Verified-in-Phase0, and 2 others: Selecting text beyond the screen with mouse is glitchy - https://phabricator.wikimedia.org/T157291#3034693 (10Ryasmeen) [22:12:49] (03CR) 10VolkerE: "Holy fuck! I was wondering, why it's `ve-ui-mwTemplateDialog ve-ui-mwTransclusionDialog-single`, so should TransclusionDialog always be Te" [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338020 (owner: 10VolkerE) [22:15:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/VisualEditor] - 10https://gerrit.wikimedia.org/r/338263 (owner: 10L10n-bot) [22:15:40] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-2017WikitextEditor, 07Verified, and 3 others: Plain text paste into new wikitext editor adds newline markers wrongly - https://phabricator.wikimedia.org/T157491#3034727 (10Ryasmeen) [22:17:58] 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki-Links, 07Verified-in-Phase2, 05WMF-deploy-2017-02-14_(1.29.0-wmf.12): Copying a piped link from VE to VE results in javascript:void(0) in wikitext - https://phabricator.wikimedia.org/T157205#3034737 (10Ryasmeen) [22:38:35] (03PS1) 10Esanders: Don't allow slug buttons to take focus [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338275 (https://phabricator.wikimedia.org/T158295) [22:50:00] (03PS2) 10Esanders: Don't allow slug buttons to take focus on click [VisualEditor/VisualEditor] - 10https://gerrit.wikimedia.org/r/338275 (https://phabricator.wikimedia.org/T158295)